27c015dfcf
Tight quads and conics may nearly fold over on themselves, confusing coincidence against other curves. Split them at their max curvature early on to avoid complicating later logic. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357353002 Review-Url: https://codereview.chromium.org/2357353002
187 lines
11 KiB
C++
187 lines
11 KiB
C++
/*
|
|
* Copyright 2013 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
#include "PathOpsExtendedTest.h"
|
|
#include "SkPath.h"
|
|
#include "SkPathOps.h"
|
|
#include "SkPoint.h"
|
|
#include "Test.h"
|
|
|
|
static const SkPoint nonFinitePts[] = {
|
|
{ SK_ScalarInfinity, 0 },
|
|
{ 0, SK_ScalarInfinity },
|
|
{ SK_ScalarInfinity, SK_ScalarInfinity },
|
|
{ SK_ScalarNegativeInfinity, 0},
|
|
{ 0, SK_ScalarNegativeInfinity },
|
|
{ SK_ScalarNegativeInfinity, SK_ScalarNegativeInfinity },
|
|
{ SK_ScalarNegativeInfinity, SK_ScalarInfinity },
|
|
{ SK_ScalarInfinity, SK_ScalarNegativeInfinity },
|
|
{ SK_ScalarNaN, 0 },
|
|
{ 0, SK_ScalarNaN },
|
|
{ SK_ScalarNaN, SK_ScalarNaN },
|
|
};
|
|
|
|
const size_t nonFinitePtsCount = sizeof(nonFinitePts) / sizeof(nonFinitePts[0]);
|
|
|
|
static const SkPoint finitePts[] = {
|
|
{ 0, 0 },
|
|
{ SK_ScalarMax, 0 },
|
|
{ 0, SK_ScalarMax },
|
|
{ SK_ScalarMax, SK_ScalarMax },
|
|
{ SK_ScalarMin, 0 },
|
|
{ 0, SK_ScalarMin },
|
|
{ SK_ScalarMin, SK_ScalarMin },
|
|
};
|
|
|
|
const size_t finitePtsCount = sizeof(finitePts) / sizeof(finitePts[0]);
|
|
|
|
static void failOne(skiatest::Reporter* reporter, int index) {
|
|
SkPath path;
|
|
int i = (int) (index % nonFinitePtsCount);
|
|
int f = (int) (index % finitePtsCount);
|
|
int g = (int) ((f + 1) % finitePtsCount);
|
|
switch (index % 13) {
|
|
case 0: path.lineTo(nonFinitePts[i]); break;
|
|
case 1: path.quadTo(nonFinitePts[i], nonFinitePts[i]); break;
|
|
case 2: path.quadTo(nonFinitePts[i], finitePts[f]); break;
|
|
case 3: path.quadTo(finitePts[f], nonFinitePts[i]); break;
|
|
case 4: path.cubicTo(nonFinitePts[i], finitePts[f], finitePts[f]); break;
|
|
case 5: path.cubicTo(finitePts[f], nonFinitePts[i], finitePts[f]); break;
|
|
case 6: path.cubicTo(finitePts[f], finitePts[f], nonFinitePts[i]); break;
|
|
case 7: path.cubicTo(nonFinitePts[i], nonFinitePts[i], finitePts[f]); break;
|
|
case 8: path.cubicTo(nonFinitePts[i], finitePts[f], nonFinitePts[i]); break;
|
|
case 9: path.cubicTo(finitePts[f], nonFinitePts[i], nonFinitePts[i]); break;
|
|
case 10: path.cubicTo(nonFinitePts[i], nonFinitePts[i], nonFinitePts[i]); break;
|
|
case 11: path.cubicTo(nonFinitePts[i], finitePts[f], finitePts[g]); break;
|
|
case 12: path.moveTo(nonFinitePts[i]); break;
|
|
}
|
|
SkPath result;
|
|
result.setFillType(SkPath::kWinding_FillType);
|
|
bool success = Simplify(path, &result);
|
|
REPORTER_ASSERT(reporter, !success);
|
|
REPORTER_ASSERT(reporter, result.isEmpty());
|
|
REPORTER_ASSERT(reporter, result.getFillType() == SkPath::kWinding_FillType);
|
|
reporter->bumpTestCount();
|
|
}
|
|
|
|
static void dontFailOne(skiatest::Reporter* reporter, int index) {
|
|
SkPath path;
|
|
int f = (int) (index % finitePtsCount);
|
|
int g = (int) ((f + 1) % finitePtsCount);
|
|
switch (index % 11) {
|
|
case 0: path.lineTo(finitePts[f]); break;
|
|
case 1: path.quadTo(finitePts[f], finitePts[f]); break;
|
|
case 2: path.quadTo(finitePts[f], finitePts[g]); break;
|
|
case 3: path.quadTo(finitePts[g], finitePts[f]); break;
|
|
case 4: path.cubicTo(finitePts[f], finitePts[f], finitePts[f]); break;
|
|
case 5: path.cubicTo(finitePts[f], finitePts[f], finitePts[g]); break;
|
|
case 6: path.cubicTo(finitePts[f], finitePts[g], finitePts[f]); break;
|
|
case 7: path.cubicTo(finitePts[f], finitePts[g], finitePts[g]); break;
|
|
case 8: path.cubicTo(finitePts[g], finitePts[f], finitePts[f]); break;
|
|
case 9: path.cubicTo(finitePts[g], finitePts[f], finitePts[g]); break;
|
|
case 10: path.moveTo(finitePts[f]); break;
|
|
}
|
|
SkPath result;
|
|
result.setFillType(SkPath::kWinding_FillType);
|
|
bool success = Simplify(path, &result);
|
|
if (index != 17 && index != 31 && index != 38) { // cubic fails to chop in two without creating NaNs
|
|
REPORTER_ASSERT(reporter, success);
|
|
REPORTER_ASSERT(reporter, result.getFillType() != SkPath::kWinding_FillType);
|
|
}
|
|
reporter->bumpTestCount();
|
|
}
|
|
|
|
static void fuzz_59(skiatest::Reporter* reporter, const char* filename) {
|
|
SkPath path;
|
|
path.moveTo(SkBits2Float(0x430c0000), SkBits2Float(0xce58f41c)); // 140, -9.09969e+08f
|
|
path.lineTo(SkBits2Float(0x43480000), SkBits2Float(0xce58f419)); // 200, -9.09969e+08f
|
|
path.lineTo(SkBits2Float(0x42200000), SkBits2Float(0xce58f41b)); // 40, -9.09969e+08f
|
|
path.lineTo(SkBits2Float(0x43700000), SkBits2Float(0xce58f41b)); // 240, -9.09969e+08f
|
|
path.lineTo(SkBits2Float(0x428c0000), SkBits2Float(0xce58f419)); // 70, -9.09969e+08f
|
|
path.lineTo(SkBits2Float(0x430c0000), SkBits2Float(0xce58f41c)); // 140, -9.09969e+08f
|
|
path.close();
|
|
testSimplifyFuzz(reporter, path, filename);
|
|
}
|
|
|
|
static void fuzz_x1(skiatest::Reporter* reporter, const char* filename) {
|
|
SkPath path;
|
|
path.moveTo(SkBits2Float(0x00000000), SkBits2Float(0x00000000)); // 0, 0
|
|
path.cubicTo(SkBits2Float(0x1931204a), SkBits2Float(0x2ba1a14a), SkBits2Float(0x4a4a08ff), SkBits2Float(0x4a4a08ff), SkBits2Float(0x4a4a4a34), SkBits2Float(0x4a4a4a4a)); // 9.15721e-24f, 1.14845e-12f, 3.31014e+06f, 3.31014e+06f, 3.31432e+06f, 3.31432e+06f
|
|
path.moveTo(SkBits2Float(0x000010a1), SkBits2Float(0x19312000)); // 5.96533e-42f, 9.15715e-24f
|
|
path.cubicTo(SkBits2Float(0x4a6a4a4a), SkBits2Float(0x4a4a4a4a), SkBits2Float(0xa14a4a4a), SkBits2Float(0x08ff2ba1), SkBits2Float(0x08ff4a4a), SkBits2Float(0x4a344a4a)); // 3.83861e+06f, 3.31432e+06f, -6.85386e-19f, 1.53575e-33f, 1.53647e-33f, 2.95387e+06f
|
|
path.cubicTo(SkBits2Float(0x4a4a4a4a), SkBits2Float(0x4a4a4a4a), SkBits2Float(0x2ba1a14a), SkBits2Float(0x4e4a08ff), SkBits2Float(0x4a4a4a4a), SkBits2Float(0xa1a181ff)); // 3.31432e+06f, 3.31432e+06f, 1.14845e-12f, 8.47397e+08f, 3.31432e+06f, -1.09442e-18f
|
|
testSimplify(reporter, path, filename);
|
|
}
|
|
|
|
static void fuzz_x2(skiatest::Reporter* reporter, const char* filename) {
|
|
SkPath path;
|
|
path.moveTo(SkBits2Float(0x00000000), SkBits2Float(0x00000000)); // 0, 0
|
|
path.cubicTo(SkBits2Float(0x1931204a), SkBits2Float(0x2ba1a14a), SkBits2Float(0x4a4a08ff), SkBits2Float(0x4a4a08ff), SkBits2Float(0x4a4a4a34), SkBits2Float(0x4a4a4a4a)); // 9.15721e-24f, 1.14845e-12f, 3.31014e+06f, 3.31014e+06f, 3.31432e+06f, 3.31432e+06f
|
|
path.moveTo(SkBits2Float(0x000010a1), SkBits2Float(0x19312000)); // 5.96533e-42f, 9.15715e-24f
|
|
path.cubicTo(SkBits2Float(0x4a6a4a4a), SkBits2Float(0x4a4a4a4a), SkBits2Float(0xa14a4a4a), SkBits2Float(0x08ff2ba1), SkBits2Float(0x08ff4a4a), SkBits2Float(0x4a344a4a)); // 3.83861e+06f, 3.31432e+06f, -6.85386e-19f, 1.53575e-33f, 1.53647e-33f, 2.95387e+06f
|
|
path.cubicTo(SkBits2Float(0x4a4a4a4a), SkBits2Float(0x4a4a4a4a), SkBits2Float(0x2ba1a14a), SkBits2Float(0x4e4a08ff), SkBits2Float(0x4a4a4a4a), SkBits2Float(0xa1a181ff)); // 3.31432e+06f, 3.31432e+06f, 1.14845e-12f, 8.47397e+08f, 3.31432e+06f, -1.09442e-18f
|
|
testSimplify(reporter, path, filename);
|
|
}
|
|
|
|
static void fuzz763_1(skiatest::Reporter* reporter, const char* filename) {
|
|
SkPath path;
|
|
path.setFillType((SkPath::FillType) 0);
|
|
path.moveTo(SkBits2Float(0x00000000), SkBits2Float(0x00000000)); // 0, 0
|
|
path.cubicTo(SkBits2Float(0xbcb63000), SkBits2Float(0xb6b6b6b7), SkBits2Float(0x38b6b6b6), SkBits2Float(0xafb63a5a), SkBits2Float(0xca000087), SkBits2Float(0xe93ae9e9)); // -0.0222397f, -5.44529e-06f, 8.71247e-05f, -3.31471e-10f, -2.09719e+06f, -1.41228e+25f
|
|
path.quadTo(SkBits2Float(0xb6007fb6), SkBits2Float(0xb69fb6b6), SkBits2Float(0xe9e964b6), SkBits2Float(0xe9e9e9e9)); // -1.91478e-06f, -4.75984e-06f, -3.52694e+25f, -3.5348e+25f
|
|
path.quadTo(SkBits2Float(0xb6b6b8b7), SkBits2Float(0xb60000b6), SkBits2Float(0xb6b6b6b6), SkBits2Float(0xe9e92064)); // -5.44553e-06f, -1.90739e-06f, -5.44529e-06f, -3.52291e+25f
|
|
path.quadTo(SkBits2Float(0x000200e9), SkBits2Float(0xe9e9d100), SkBits2Float(0xe93ae9e9), SkBits2Float(0xe964b6e9)); // 1.83997e-40f, -3.53333e+25f, -1.41228e+25f, -1.72812e+25f
|
|
path.quadTo(SkBits2Float(0x40b6e9e9), SkBits2Float(0xe9b60000), SkBits2Float(0x00b6b8e9), SkBits2Float(0xe9000001)); // 5.71605f, -2.75031e+25f, 1.67804e-38f, -9.67141e+24f
|
|
path.quadTo(SkBits2Float(0xe9d3b6b2), SkBits2Float(0x40404540), SkBits2Float(0x803d4043), SkBits2Float(0xe9e9e9ff)); // -3.19933e+25f, 3.00423f, -5.62502e-39f, -3.53481e+25f
|
|
path.cubicTo(SkBits2Float(0x00000000), SkBits2Float(0xe8b3b6b6), SkBits2Float(0xe90a0003), SkBits2Float(0x4040403c), SkBits2Float(0x803d4040), SkBits2Float(0xe9e80900)); // 0, -6.78939e+24f, -1.0427e+25f, 3.00392f, -5.62501e-39f, -3.50642e+25f
|
|
path.quadTo(SkBits2Float(0xe9e910e9), SkBits2Float(0xe9e93ae9), SkBits2Float(0x0000b6b6), SkBits2Float(0xb6b6aab6)); // -3.52199e+25f, -3.52447e+25f, 6.55443e-41f, -5.4439e-06f
|
|
path.moveTo(SkBits2Float(0xe9e92064), SkBits2Float(0xe9e9d106)); // -3.52291e+25f, -3.53334e+25f
|
|
path.quadTo(SkBits2Float(0xe9e93ae9), SkBits2Float(0x0000abb6), SkBits2Float(0xb6b6bdb6), SkBits2Float(0xe92064b6)); // -3.52447e+25f, 6.15983e-41f, -5.44611e-06f, -1.2119e+25f
|
|
path.quadTo(SkBits2Float(0x0000e9e9), SkBits2Float(0xb6b6b6e9), SkBits2Float(0x05ffff05), SkBits2Float(0xe9ea06e9)); // 8.39112e-41f, -5.44532e-06f, 2.40738e-35f, -3.53652e+25f
|
|
path.quadTo(SkBits2Float(0xe93ae9e9), SkBits2Float(0x02007fe9), SkBits2Float(0xb8b7b600), SkBits2Float(0xe9e9b6b6)); // -1.41228e+25f, 9.44066e-38f, -8.76002e-05f, -3.53178e+25f
|
|
path.quadTo(SkBits2Float(0xe9e9e9b6), SkBits2Float(0xedb6b6b6), SkBits2Float(0x5a38a1b6), SkBits2Float(0xe93ae9e9)); // -3.53479e+25f, -7.06839e+27f, 1.29923e+16f, -1.41228e+25f
|
|
path.quadTo(SkBits2Float(0x0000b6b6), SkBits2Float(0xb6b6b6b6), SkBits2Float(0xe9e9e9b6), SkBits2Float(0xe9e9e954)); // 6.55443e-41f, -5.44529e-06f, -3.53479e+25f, -3.53477e+25f
|
|
path.quadTo(SkBits2Float(0xb6e9e93a), SkBits2Float(0x375837ff), SkBits2Float(0xceb6b6b6), SkBits2Float(0x0039e94f)); // -6.97109e-06f, 1.28876e-05f, -1.53271e+09f, 5.31832e-39f
|
|
path.quadTo(SkBits2Float(0xe9e9e9e9), SkBits2Float(0xe9e6e9e9), SkBits2Float(0xb6b641b6), SkBits2Float(0xede9e9e9)); // -3.5348e+25f, -3.48947e+25f, -5.43167e-06f, -9.0491e+27f
|
|
path.moveTo(SkBits2Float(0xb6b6e9e9), SkBits2Float(0xb6b60000)); // -5.45125e-06f, -5.42402e-06f
|
|
path.moveTo(SkBits2Float(0xe9b6b6b6), SkBits2Float(0xe9b6b8e9)); // -2.76109e+25f, -2.76122e+25f
|
|
path.close();
|
|
path.moveTo(SkBits2Float(0xe9b6b6b6), SkBits2Float(0xe9b6b8e9)); // -2.76109e+25f, -2.76122e+25f
|
|
path.quadTo(SkBits2Float(0xe93ae9e9), SkBits2Float(0xe964b6e9), SkBits2Float(0x0000203a), SkBits2Float(0xb6000000)); // -1.41228e+25f, -1.72812e+25f, 1.15607e-41f, -1.90735e-06f
|
|
path.moveTo(SkBits2Float(0x64b6b6b6), SkBits2Float(0xe9e9e900)); // 2.69638e+22f, -3.53475e+25f
|
|
path.quadTo(SkBits2Float(0xb6b6b6e9), SkBits2Float(0xb6b6b6b6), SkBits2Float(0xe9e9b6ce), SkBits2Float(0xe9e93ae9)); // -5.44532e-06f, -5.44529e-06f, -3.53179e+25f, -3.52447e+25f
|
|
|
|
testSimplifyFuzz(reporter, path, filename);
|
|
}
|
|
|
|
|
|
#define TEST(test) test(reporter, #test)
|
|
|
|
DEF_TEST(PathOpsSimplifyFail, reporter) {
|
|
TEST(fuzz763_1),
|
|
TEST(fuzz_x2);
|
|
TEST(fuzz_x1);
|
|
TEST(fuzz_59);
|
|
for (int index = 0; index < (int) (13 * nonFinitePtsCount * finitePtsCount); ++index) {
|
|
failOne(reporter, index);
|
|
}
|
|
for (int index = 0; index < (int) (11 * finitePtsCount); ++index) {
|
|
dontFailOne(reporter, index);
|
|
}
|
|
}
|
|
|
|
#undef TEST
|
|
|
|
DEF_TEST(PathOpsSimplifyFailOne, reporter) {
|
|
int index = 0;
|
|
failOne(reporter, index);
|
|
}
|
|
|
|
DEF_TEST(PathOpsSimplifyDontFailOne, reporter) {
|
|
int index = 17;
|
|
dontFailOne(reporter, index);
|
|
}
|