ec9b4aab87
https://clang.llvm.org/extra/clang-tidy/checks/readability-const-return-type.html `const` on a non-pointer/reference return type typically doesn't add value and can have negative side effects. (i.e., returning a `const std::string` isn't meaningfully different from returning a `std::string`, but can sometimes inhibit move-related optimizations.) In Skia's case, the priv() functions are a notable exception where const return types are intentional and valuable. These calls have been marked with NOLINT to exclude them from the check. This check does not affect pointer and reference returns, where constness is important. Change-Id: I86cab92332f164e5ab710b4127182eec99831d7d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308564 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
53 lines
1.5 KiB
C++
53 lines
1.5 KiB
C++
/*
|
|
* Copyright 2019 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef GrImageContext_DEFINED
|
|
#define GrImageContext_DEFINED
|
|
|
|
#include "include/private/GrContext_Base.h"
|
|
#include "include/private/GrSingleOwner.h"
|
|
|
|
class GrImageContextPriv;
|
|
class GrProxyProvider;
|
|
|
|
class GrImageContext : public GrContext_Base {
|
|
public:
|
|
~GrImageContext() override;
|
|
|
|
// Provides access to functions that aren't part of the public API.
|
|
GrImageContextPriv priv();
|
|
const GrImageContextPriv priv() const; // NOLINT(readability-const-return-type)
|
|
|
|
protected:
|
|
friend class GrImageContextPriv; // for hidden functions
|
|
|
|
GrImageContext(sk_sp<GrContextThreadSafeProxy>);
|
|
|
|
SK_API virtual void abandonContext();
|
|
SK_API virtual bool abandoned();
|
|
|
|
GrProxyProvider* proxyProvider() { return fProxyProvider.get(); }
|
|
const GrProxyProvider* proxyProvider() const { return fProxyProvider.get(); }
|
|
|
|
/** This is only useful for debug purposes */
|
|
GrSingleOwner* singleOwner() const { return &fSingleOwner; }
|
|
|
|
GrImageContext* asImageContext() override { return this; }
|
|
|
|
private:
|
|
std::unique_ptr<GrProxyProvider> fProxyProvider;
|
|
|
|
// In debug builds we guard against improper thread handling
|
|
// This guard is passed to the GrDrawingManager and, from there to all the
|
|
// GrRenderTargetContexts. It is also passed to the GrResourceProvider and SkGpuDevice.
|
|
mutable GrSingleOwner fSingleOwner;
|
|
|
|
typedef GrContext_Base INHERITED;
|
|
};
|
|
|
|
#endif
|