edea19858c
This fixes several issues introduced with DirectWrite and onMakeClone. The primary issue is that the font file loader and collection loader need to remain registered until the last font using them is no longer in use. Prior to onMakeClone this was just the original font, so unregistration was simple. However, when cloning a new font is brought into existence using the same loaders as the original. All clones need to keep a reference to the loaders so that the last can unregister them. In addition variable fonts complicated the concept of equality of fonts. As a result when variable font support was introduced an Equal method was provided to make comparison easier. Use it when available to avoid issues when comparing two system fonts which differ only by their variation design position. Change-Id: I6aa8d8cc3240f1244d16f661f6fbfd17ff0f7412 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288159 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> |
||
---|---|---|
animations | ||
bench | ||
bin | ||
build/fuchsia | ||
build_overrides | ||
client_utils/android | ||
dm | ||
docker | ||
docs/examples | ||
example | ||
experimental | ||
fuzz | ||
gm | ||
gn | ||
include | ||
infra | ||
modules | ||
platform_tools | ||
resources | ||
samplecode | ||
site | ||
specs | ||
src | ||
tests | ||
third_party | ||
tools | ||
.clang-format | ||
.clang-tidy | ||
.gitignore | ||
.gn | ||
AUTHORS | ||
BUILD.gn | ||
codereview.settings | ||
CONTRIBUTING | ||
CQ_COMMITTERS | ||
DEPS | ||
go.mod | ||
go.sum | ||
LICENSE | ||
OWNERS | ||
PRESUBMIT.py | ||
public.bzl | ||
README | ||
README.chromium | ||
RELEASE_NOTES.txt | ||
whitespace.txt |
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.