skia2/include/sksl
Tyler Denniston 193c16380f Revert "Eliminate DSLPossibleExpression."
This reverts commit f2d000328f.

Reason for revert: breaking google3 roll

Original change's description:
> Eliminate DSLPossibleExpression.
>
> The Possible(Expression|Statement) classes were added at
> http://review.skia.org/375069. These classes were responsible for
> capturing `__builtin_FILE()` and `__builtin_LINE()` when an
> expression or statement was added to a hand-authored DSL program. This
> allowed errors to be reported on the C++ file/line where they were
> encountered. This was a good feature to have, when the plan was to
> author the majority of SkSL code via DSL.
>
> Later, IRNode positions were converted from an integer line number to
> SkSL Positions at http://review.skia.org/518137. This gave us range
> tracking, but at a high memory cost (16 bytes per IRNode, versus four
> bytes when we tracked line numbers only).
>
> Positions were reduced to 8 bytes at http://review.skia.org/521005 by
> removing the filename, which was only used for hand-authored DSL. (The
> size was pared all the way back to 4 bytes at
> http://review.skia.org/533699 by packing the data more efficiently.)
>
> __builtin_FILE/LINE capturing was removed entirely at
> http://review.skia.org/528366; the filename was discarded anyway and
> the line number didn't have a range and wasn't very meaningful without
> a filename. Also, it didn't matter very much since we no longer intended
> to hand-craft our programs in DSL.
>
> At this stage, DSLPossibleExpression stopped adding value and simply
> served to move Expressions around.
>
> Change-Id: I29ac33e08dcc1804cc0619c1e8856ba28ebcc51d
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/542145
> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> Auto-Submit: John Stiles <johnstiles@google.com>

Change-Id: I33badbdcce8760200246bf50e4932d42721ea952
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/543078
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
2022-05-23 15:04:00 +00:00
..
BUILD.bazel Eliminate vtable from DSLVar class hierarchy. 2022-05-19 19:57:19 +00:00
DSL.h Reland "Remove DSLWrapper helper class." 2022-05-19 14:49:56 +00:00
DSLBlock.h Remove C++14 workaround code. 2022-05-18 13:53:00 +00:00
DSLCase.h Remove C++14 workaround code. 2022-05-18 13:53:00 +00:00
DSLCore.h Improved positions of for loop errors 2022-04-21 16:56:12 +00:00
DSLExpression.h Revert "Eliminate DSLPossibleExpression." 2022-05-23 15:04:00 +00:00
DSLFunction.h Reland "Remove DSLWrapper helper class." 2022-05-19 14:49:56 +00:00
DSLLayout.h Removed Position::Capture 2022-04-08 17:26:24 +00:00
DSLModifiers.h Removed Position::Capture 2022-04-08 17:26:24 +00:00
DSLStatement.h Revert "Eliminate DSLPossibleExpression." 2022-05-23 15:04:00 +00:00
DSLSymbols.h Removed Position::Capture 2022-04-08 17:26:24 +00:00
DSLType.h Revert "Eliminate DSLPossibleExpression." 2022-05-23 15:04:00 +00:00
DSLVar.h Revert "Eliminate DSLPossibleExpression." 2022-05-23 15:04:00 +00:00
OWNERS Add Ethan and John to OWNERS for include/sksl/. 2022-04-26 23:38:58 +00:00
SkSLDebugTrace.h Add SkRuntimeEffect::MakeTraced API for SkShader debugging. 2021-12-07 22:34:00 +00:00
SkSLErrorReporter.h [includes] Enforce IWYU on sksl code 2022-03-21 12:43:02 +00:00
SkSLOperator.h Added an SkSL Operator enum 2022-03-31 13:20:57 +00:00
SkSLPosition.h Fit Position in 4 bytes. 2022-04-27 00:01:06 +00:00
SkSLVersion.h Reland "Add SkCapabilities object" 2022-05-17 13:15:06 +00:00