d98f78cd01
Anonymous enums play havoc with documentation; there's no name to refer to. It may be that all enums may either be named or replaced with constexpr without breaking anything. Try replacing all anonymous enums in include/core to see what happens. This names SkCanvas::SaveLayerFlagsSet but leaves SkCanvas::SaveLayerFlags as a uint32_t, to reduce risk as compared to review.skia.org/123584. There's also some chance that external linkage will break if some client refers to anonymous enum in a way that could require its address: see https://stackoverflow.com/questions/22867654/enum-vs-constexpr-for-actual-static-constants-inside-classes (This CL does not require definitions + declarations) Brought bookmaker docs in line with this change. This also tripped over missing code in bookmaker handling constexpr so added that as well. R=reed@google.com,bsalomon@google.com Docs-Preview: https://skia.org/?cl=123920 Docs-Preview: https://skia.org/?cl=123584 Bug: skia:6898 Change-Id: I14a342edcfd59e139ef9e4501f562417c4c60391 Reviewed-on: https://skia-review.googlesource.com/123920 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Cary Clark <caryclark@skia.org> |
||
---|---|---|
.. | ||
android | ||
bookmaker | ||
calmbench | ||
copyright | ||
debugger | ||
fiddle | ||
flags | ||
fonts | ||
gdb | ||
gpu | ||
lottiecap | ||
lua | ||
mdbviz | ||
rebaseline | ||
shape | ||
sk_app | ||
skdiff | ||
skiaserve | ||
skp | ||
skpbench | ||
skqp | ||
svg | ||
timer | ||
trace | ||
viewer | ||
__init__.py | ||
add_codereview_message.py | ||
AndroidSkDebugToStdOut.cpp | ||
BigPathBench.inc | ||
bisect_roll | ||
bisect_roll.bat | ||
bisect_roll.go | ||
build_command_buffer.py | ||
BUILD_simulator.py | ||
build_workaround_header.py | ||
check-headers-self-sufficient | ||
chrome_fuzz.cpp | ||
colorspaceinfo.cpp | ||
compare_codereview.py | ||
CrashHandler.cpp | ||
CrashHandler.h | ||
create_flutter_test_images.cpp | ||
doxygen_footer.txt | ||
dump_record.cpp | ||
DumpRecord.cpp | ||
DumpRecord.h | ||
embed_resources.py | ||
find_run_binary.py | ||
fix_pythonpath.py | ||
gcov_shim | ||
generate_vk_interface.sh | ||
get_current_monitor_profile.cpp | ||
get_images_from_skps.cpp | ||
git-sync-deps | ||
gyp | ||
imgblur.cpp | ||
imgslice.cpp | ||
install_dependencies.sh | ||
ios_utils.h | ||
ios_utils.m | ||
jsondiff.py | ||
list_gms.cpp | ||
list_gpu_unit_tests.cpp | ||
LsanSuppressions.cpp | ||
merge_static_libs.py | ||
milestone.py | ||
mirror-dev.sh | ||
misc_utils.py | ||
OverwriteLine.h | ||
parse_llvm_coverage.py | ||
pathops_sorter.htm | ||
pathops_visualizer.htm | ||
picture_utils.cpp | ||
picture_utils.h | ||
ProcStats.cpp | ||
ProcStats.h | ||
public_headers_warnings_check.cpp | ||
random_parse_path.cpp | ||
random_parse_path.h | ||
reformat-json.py | ||
Registry.h | ||
remote_demo.cpp | ||
ResourceFactory.h | ||
Resources.cpp | ||
Resources.h | ||
retrieve_from_googlesource.py | ||
sanitize_source_files.py | ||
sk_pixel_iter.h | ||
sk_tool_utils.cpp | ||
sk_tool_utils.h | ||
skhello.cpp | ||
SkJSONCPP.h | ||
skp_parser.cpp | ||
skpinfo.cpp | ||
skpmaker.cpp | ||
Stats.h | ||
test_all.py | ||
test_pdfs.py | ||
UrlDataManager.cpp | ||
UrlDataManager.h | ||
valgrind.supp | ||
whitelist_typefaces.cpp | ||
win_dbghelp.cpp | ||
win_dbghelp.h | ||
win_lcid.cpp |