skia2/tests
John Stiles abc3b78011 Eliminate left-side comma expressions without side effects.
This takes away one of our gadgets for thwarting dead-code elimination
in unit tests, but it's the right thing to do. Comma expression left-
sides without side effects are clearly dead code.

Change-Id: Iaee490b4a742d06a0a0be94cddaa69a51543d8f5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/366719
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-02-05 16:50:33 +00:00
..
sksl Eliminate left-side comma expressions without side effects. 2021-02-05 16:50:33 +00:00
AAClipTest.cpp
AdvancedBlendTest.cpp
AndroidCodecTest.cpp
AnimatedImageTest.cpp
AnnotationTest.cpp
ApplyGammaTest.cpp drawBitmap is deprecated 2021-01-24 17:39:15 +00:00
ArenaAllocTest.cpp
AsADashTest.cpp
BackendAllocationTest.cpp Reland "Make GrDirectContext::updateBackendTexture handle pixmaps with non-type row bytes." 2021-01-31 19:34:51 +00:00
BackendSurfaceMutableStateTest.cpp Replace SkImage_Base::view() and ::refView() with new asView(). 2021-02-03 19:05:49 +00:00
BadIcoTest.cpp
BitmapCopyTest.cpp
BitmapGetColorTest.cpp
BitmapTest.cpp
BitSetTest.cpp
BlendTest.cpp
BlitMaskClip.cpp
BlurTest.cpp
BRDTest.cpp
BulkRectTest.cpp
CachedDataTest.cpp
CachedDecodingPixelRefTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
CanvasStateHelpers.cpp
CanvasStateHelpers.h
CanvasStateTest.cpp
CanvasTest.cpp
ChecksumTest.cpp
ClearTest.cpp
ClipBoundsTest.cpp
ClipCubicTest.cpp
ClipperTest.cpp
ClipStackTest.cpp
CodecAnimTest.cpp
CodecExactReadTest.cpp
CodecPartialTest.cpp
CodecPriv.h
CodecRecommendedTypeTest.cpp
CodecTest.cpp Migrate to drawImage w/ sampling 2021-01-22 22:38:02 +00:00
ColorFilterTest.cpp
ColorMatrixTest.cpp
ColorPrivTest.cpp
ColorSpaceTest.cpp
ColorTest.cpp
CompressedBackendAllocationTest.cpp Migrate to drawImage w/ sampling 2021-01-22 22:38:02 +00:00
CopySurfaceTest.cpp Make render task targets be just a proxy. 2021-01-21 17:16:06 +00:00
CTest.cpp
CubicMapTest.cpp
DashPathEffectTest.cpp
DataRefTest.cpp
DebugLayerManagerTest.cpp
DefaultPathRendererTest.cpp
DeferredDisplayListTest.cpp
DequeTest.cpp
DescriptorTest.cpp
DeviceTest.cpp
DiscardableMemoryPoolTest.cpp
DiscardableMemoryTest.cpp
DrawBitmapRectTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
DrawOpAtlasTest.cpp
DrawPathTest.cpp
DrawTextTest.cpp
EGLImageTest.cpp Reland "Write pixels goes through GrRenderTask system." 2021-01-26 21:18:35 +00:00
EmptyPathTest.cpp
EncodedInfoTest.cpp
EncodeTest.cpp
ExifTest.cpp
ExtendedSkColorTypeTests.cpp
F16StagesTest.cpp
FakeStreams.h
FillPathTest.cpp
FitsInTest.cpp
FlattenableFactoryToName.cpp
FlattenableNameToFactory.cpp
FlattenDrawableTest.cpp
Float16Test.cpp
FloatingPointTextureTest.cpp
FontHostStreamTest.cpp
FontHostTest.cpp
FontMgrAndroidParserTest.cpp
FontMgrFontConfigTest.cpp
FontMgrTest.cpp
FontNamesTest.cpp
FontTest.cpp
FrontBufferedStreamTest.cpp
GeometryTest.cpp
GifTest.cpp Pass sampling to drawImage 2021-01-29 18:53:48 +00:00
GLBackendSurfaceTest.cpp Replace SkImage_Base::view() and ::refView() with new asView(). 2021-02-03 19:05:49 +00:00
GlyphRunTest.cpp
GpuDrawPathTest.cpp
GpuRectanizerTest.cpp
GradientTest.cpp
GrAHardwareBufferTest.cpp drawBitmap is deprecated 2021-01-28 19:37:45 +00:00
GrBlockAllocatorTest.cpp
GrCCPRTest.cpp
GrClipStackTest.cpp
GrContextAbandonTest.cpp
GrContextFactoryTest.cpp
GrContextOOM.cpp
GrDDLImageTest.cpp
GrFinishedFlushTest.cpp
GrGLExtensionsTest.cpp
GrMemoryPoolTest.cpp
GrMeshTest.cpp Reland "Write pixels goes through GrRenderTask system." 2021-01-26 21:18:35 +00:00
GrMipMappedTest.cpp Replace SkImage_Base::view() and ::refView() with new asView(). 2021-02-03 19:05:49 +00:00
GrOpListFlushTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
GrPathUtilsTest.cpp
GrPipelineDynamicStateTest.cpp
GrPorterDuffTest.cpp
GrQuadBufferTest.cpp
GrQuadCropTest.cpp
GrRenderTaskClusterTest.cpp Fix write-after-read in clustering 2021-01-28 22:46:00 +00:00
GrStyledShapeTest.cpp
GrSubmittedFlushTest.cpp
GrSurfaceTest.cpp Make render task targets be just a proxy. 2021-01-21 17:16:06 +00:00
GrTBlockListTest.cpp
GrTextBlobTest.cpp
GrTextureMipMapInvalidationTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
GrThreadSafeCacheTest.cpp
GrVxTest.cpp
HashTest.cpp
HighContrastFilterTest.cpp
HSVRoundTripTest.cpp
ICCTest.cpp
ImageBitmapTest.cpp
ImageCacheTest.cpp
ImageFilterCacheTest.cpp
ImageFilterTest.cpp Guard legacy matrixtransforms, and expose new one 2021-02-01 22:10:39 +00:00
ImageFrom565Bitmap.cpp
ImageGeneratorTest.cpp
ImageIsOpaqueTest.cpp
ImageNewShaderTest.cpp
ImageTest.cpp Replace SkImage_Base::view() and ::refView() with new asView(). 2021-02-03 19:05:49 +00:00
IncrTopoSortTest.cpp
IndexedPngOverflowTest.cpp drawBitmap is deprecated, use drawImage 2021-01-25 01:44:55 +00:00
InfRectTest.cpp
InsetConvexPolyTest.cpp
InterpolatorTest.cpp
InvalidIndexedPngTest.cpp
IsClosedSingleContourTest.cpp
JSONTest.cpp
LayerDrawLooperTest.cpp
LazyProxyTest.cpp
LListTest.cpp
LRUCacheTest.cpp
M44Test.cpp
MallocPixelRefTest.cpp
MaskCacheTest.cpp
MathTest.cpp
Matrix44Test.cpp
MatrixClipCollapseTest.cpp
MatrixColorFilterTest.cpp
MatrixTest.cpp
MD5Test.cpp
MemoryTest.cpp
MemsetTest.cpp
MessageBusTest.cpp
MetaDataTest.cpp
MipMapTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
MtlBackendAllocationTest.mm
MtlCopySurfaceTest.mm Make render task targets be just a proxy. 2021-01-21 17:16:06 +00:00
MultiPictureDocumentTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
NdkDecodeTest.cpp
NdkEncodeTest.cpp
NonlinearBlendingTest.cpp
OctoBoundsTest.cpp
OffsetSimplePolyTest.cpp
OnceTest.cpp
OnFlushCallbackTest.cpp
OpChainTest.cpp
OSPathTest.cpp
OverAlignedTest.cpp
PackBitsTest.cpp
PaintTest.cpp Don't use filter-quality 2021-01-30 16:09:23 +00:00
ParametricStageTest.cpp
ParseColorTest.cpp
ParsePathTest.cpp
PathBuilderTest.cpp SkPathBuider::addPath() 2021-01-26 03:53:49 +00:00
PathCoverageTest.cpp
PathMeasureTest.cpp
PathOpsAngleIdeas.cpp
PathOpsAngleTest.cpp
PathOpsAsWindingTest.cpp
PathOpsBattles.cpp
PathOpsBoundsTest.cpp
PathOpsBuilderConicTest.cpp
PathOpsBuilderTest.cpp
PathOpsBuildUseTest.cpp
PathOpsChalkboardTest.cpp
PathOpsConicIntersectionTest.cpp
PathOpsConicLineIntersectionTest.cpp
PathOpsConicQuadIntersectionTest.cpp
PathOpsCubicConicIntersectionTest.cpp
PathOpsCubicIntersectionTest.cpp
PathOpsCubicIntersectionTestData.cpp
PathOpsCubicIntersectionTestData.h
PathOpsCubicLineIntersectionIdeas.cpp
PathOpsCubicLineIntersectionTest.cpp
PathOpsCubicQuadIntersectionTest.cpp
PathOpsCubicReduceOrderTest.cpp
PathOpsDCubicTest.cpp
PathOpsDebug.cpp
PathOpsDebug.h
PathOpsDLineTest.cpp
PathOpsDPointTest.cpp
PathOpsDRectTest.cpp
PathOpsDVectorTest.cpp
PathOpsExtendedTest.cpp
PathOpsExtendedTest.h
PathOpsFuzz763Test.cpp
PathOpsInverseTest.cpp
PathOpsIssue3651.cpp
PathOpsLineIntersectionTest.cpp
PathOpsLineParametetersTest.cpp
PathOpsOpCircleThreadedTest.cpp
PathOpsOpCubicThreadedTest.cpp
PathOpsOpLoopThreadedTest.cpp
PathOpsOpRectThreadedTest.cpp
PathOpsOpTest.cpp
PathOpsQuadIntersectionTest.cpp
PathOpsQuadIntersectionTestData.cpp
PathOpsQuadIntersectionTestData.h
PathOpsQuadLineIntersectionTest.cpp
PathOpsQuadLineIntersectionThreadedTest.cpp
PathOpsQuadReduceOrderTest.cpp
PathOpsSimplifyDegenerateThreadedTest.cpp
PathOpsSimplifyFailTest.cpp
PathOpsSimplifyQuadralateralsThreadedTest.cpp
PathOpsSimplifyQuadThreadedTest.cpp
PathOpsSimplifyRectThreadedTest.cpp
PathOpsSimplifyTest.cpp
PathOpsSimplifyTrianglesThreadedTest.cpp
PathOpsSkpTest.cpp
PathOpsTestCommon.cpp
PathOpsTestCommon.h
PathOpsThreadedCommon.cpp
PathOpsThreadedCommon.h
PathOpsThreeWayTest.cpp
PathOpsTigerTest.cpp
PathOpsTightBoundsTest.cpp
PathOpsTSectDebug.h
PathOpsTypesTest.cpp
PathRendererCacheTests.cpp
PathTest.cpp Simplify isconvex 2021-02-01 18:28:09 +00:00
PDFDeflateWStreamTest.cpp
PDFDocumentTest.cpp drawBitmap is deprecated, use drawImage 2021-01-25 01:44:55 +00:00
PDFGlyphsToUnicodeTest.cpp
PDFJpegEmbedTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
PDFMetadataAttributeTest.cpp
PDFOpaqueSrcModeToSrcOverTest.cpp
PDFPrimitivesTest.cpp Move deprecated image filter headers out of include/ and into src/ 2021-01-28 00:41:21 +00:00
PDFTaggedLinkTest.cpp
PDFTaggedPruningTest.cpp
PDFTaggedTableTest.cpp
PDFTaggedTest.cpp drawBitmap is deprecated, use drawImage 2021-01-25 01:44:55 +00:00
PictureBBHTest.cpp
PictureShaderTest.cpp
PictureTest.cpp Update bad_bitmap test 2021-01-28 17:10:19 +00:00
PinnedImageTest.cpp Reland "Remove SkImage_Base::refPinnedImage(), use refView() instead." 2021-02-01 21:06:26 +00:00
PixelRefTest.cpp
Point3Test.cpp
PointTest.cpp
PolyUtilsTest.cpp
PremulAlphaRoundTripTest.cpp
PrimitiveProcessorTest.cpp
ProcessorTest.cpp
ProgramsTest.cpp
PromiseImageTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
ProxyConversionTest.cpp
ProxyRefTest.cpp
ProxyTest.cpp
QuickRejectTest.cpp don't use drawBitmap 2021-01-26 02:24:21 +00:00
RandomTest.cpp
ReadPixelsTest.cpp Consistently fail readPixels when rowbytes not a multiple of bpp 2021-02-01 21:31:58 +00:00
ReadWritePixelsGpuTest.cpp Consistently fail readPixels when rowbytes not a multiple of bpp 2021-02-01 21:31:58 +00:00
RecordDrawTest.cpp
RecorderTest.cpp More hiding of legacy drawImage calls 2021-01-22 13:53:42 +00:00
RecordingXfermodeTest.cpp don't use drawBitmap 2021-01-26 02:24:21 +00:00
RecordOptsTest.cpp
RecordPatternTest.cpp
RecordTest.cpp
RecordTestUtils.h
RectangleTextureTest.cpp Make render task targets be just a proxy. 2021-01-21 17:16:06 +00:00
RectTest.cpp
RefCntTest.cpp
RegionTest.cpp
RenderTargetContextTest.cpp Reland "Write pixels goes through GrRenderTask system." 2021-01-26 21:18:35 +00:00
RepeatedClippedBlurTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
ResourceAllocatorTest.cpp
ResourceCacheTest.cpp don't use drawBitmap 2021-01-26 02:24:21 +00:00
RoundRectTest.cpp
RRectInPathTest.cpp
RTreeTest.cpp
SafeMathTest.cpp
SamplePatternDictionaryTest.cpp
SamplingTest.cpp
ScalarTest.cpp
ScaleToSidesTest.cpp
SerializationTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
SerialProcsTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
ShaderImageFilterTest.cpp
ShaderOpacityTest.cpp
ShaderTest.cpp
ShadowTest.cpp
ShaperTest.cpp
SizeTest.cpp
SkBase64Test.cpp
Skbug5221.cpp
Skbug6389.cpp
Skbug6653.cpp don't use drawBitmap 2021-01-26 02:24:21 +00:00
SkColor4fTest.cpp
SkColorSpaceXformStepsTest.cpp
SkDOMTest.cpp
SkFixed15Test.cpp
SkGaussFilterTest.cpp
SkGlyphBufferTest.cpp
SkGlyphTest.cpp
skia_test.cpp
SkImageTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
SkNxTest.cpp
SkPathRangeIterTest.cpp
SkRasterPipelineTest.cpp
SkRemoteGlyphCacheTest.cpp notify type size for SkGlyphScaler_remote 2021-02-03 22:13:48 +00:00
SkResourceCacheTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
SkRuntimeEffectTest.cpp
SkScalerCacheTest.cpp
SkShaperJSONWriterTest.cpp
SkSharedMutexTest.cpp
SkSLCross.cpp
SkSLDSLTest.cpp Moved SkSL error checking of break / continue / return into a 2021-02-03 19:10:50 +00:00
SkSLFPTestbed.cpp
SkSLGLSLTestbed.cpp
SkSLInterpreterTest.cpp Fix complex lvalues in SkSL-to-SkVM 2021-01-27 16:51:20 +00:00
SkSLMemoryLayoutTest.cpp
SkSLMetalTestbed.cpp
SkSLSPIRVTestbed.cpp
SkSLTest.cpp Migrate even more SkSL tests to run in dm. 2021-02-05 16:04:43 +00:00
SkStrikeCacheTest.cpp
SkUTFTest.cpp
SkVMTest.cpp add single-lane ld2.4s and ld4.4s 2021-01-27 21:38:40 +00:00
SkVxTest.cpp
SortTest.cpp
SpecialImageTest.cpp SpecialImage draw takes sampling, not filter-quality 2021-01-23 03:41:52 +00:00
SpecialSurfaceTest.cpp
SrcOverTest.cpp
SrcSrcOverBatchTest.cpp
SRGBReadWritePixelsTest.cpp Reland "Write pixels goes through GrRenderTask system." 2021-01-26 21:18:35 +00:00
SRGBTest.cpp
StreamBufferTest.cpp
StreamTest.cpp
StringTest.cpp
StrokeIndirectTest.cpp Create an abstract GrStrokeTessellator class 2021-02-04 19:57:28 +00:00
StrokerTest.cpp
StrokeTest.cpp
SubsetPath.cpp
SubsetPath.h
SurfaceSemaphoreTest.cpp
SurfaceTest.cpp Replace SkImage_Base::view() and ::refView() with new asView(). 2021-02-03 19:05:49 +00:00
SVGDeviceTest.cpp
SwizzlerTest.cpp
TArrayTest.cpp
TDPQueueTest.cpp
TemplatesTest.cpp
Test.cpp
Test.h
TestTest.cpp
TestUtils.cpp Make render task targets be just a proxy. 2021-01-21 17:16:06 +00:00
TestUtils.h Make render task targets be just a proxy. 2021-01-21 17:16:06 +00:00
TextBlobCacheTest.cpp
TextBlobTest.cpp
TextureBindingsResetTest.cpp
TextureOpTest.cpp
TextureProxyTest.cpp
TextureStripAtlasManagerTest.cpp filter-quality is deprecated, pass sampling to drawImage 2021-01-28 03:22:51 +00:00
Time.cpp
TLazyTest.cpp
TopoSortTest.cpp
TraceMemoryDumpTest.cpp
TracingTest.cpp
TransferPixelsTest.cpp Pass sk_sps through the GrGpu transferPixels* calls. 2021-02-01 21:46:28 +00:00
TriangulatingPathRendererTests.cpp Make GrTriangulator immutable 2021-01-28 02:38:51 +00:00
TypefaceTest.cpp
UnicodeTest.cpp
UtilsTest.cpp
VerticesTest.cpp
VkBackendSurfaceTest.cpp Replace SkImage_Base::view() and ::refView() with new asView(). 2021-02-03 19:05:49 +00:00
VkDrawableTest.cpp Pass sampling to drawImage 2021-01-29 18:53:48 +00:00
VkHardwareBufferTest.cpp
VkPriorityExtensionTest.cpp
VkProtectedContextTest.cpp
VkWrapTests.cpp
VkYcbcrSamplerTest.cpp
VptrTest.cpp
WangsFormulaTest.cpp Add GrWangsFormula implementation for conics 2021-02-04 20:07:28 +00:00
WebpTest.cpp
WindowRectanglesTest.cpp
WritePixelsTest.cpp
Writer32Test.cpp
YUVCacheTest.cpp
YUVTest.cpp