d68069019b
Previously, any code which emitted a binary expression would always emit a leading and trailing space. This caused comma expressions to look goofy: `foo() , bar();` instead of `foo(), bar();`. Operator::operatorName() now returns the operator token with appropriate whitespace around it, and tightOperatorName() is a new method which omits the whitespace. Functions which assemble binary expressions should now concatenate `x + operatorName() + y` instead of hard-coding `x + " " + operatorName() + " " + y`. Prefix/postfix expressions should use `tightOperatorName()` because otherwise negation looks bad (` - 123` instead of `-123`). Super low priority, but it was easy to fix. Change-Id: I3c92832207293a310fb1070b3b5e72455757b0ce Reviewed-on: https://skia-review.googlesource.com/c/skia/+/497776 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> |
||
---|---|---|
.. | ||
blend | ||
errors | ||
folding | ||
glsl | ||
inliner | ||
intrinsics | ||
metal | ||
runtime | ||
runtime_errors | ||
shared | ||
spirv | ||
workarounds | ||
README.txt |
This directory contains skslc-compiled output from matching source files in the /resources/sksl/ directory.