skia2/include/sksl/DSLErrorHandling.h
Ethan Nicholas fe5d6928d0 DSL var values are now specified at construction time rather than in
Declare

This solves several issues caused by the lack of ordering guarantees in
C++; it was possible for the SkSL backend to look for the value of a
variable before its Declare() call gets processed. Moving the initial
value out of Declare should fix this whole class of problems.

Change-Id: I428fe230f1c312a0128c1f00c2a36cb95f4590a6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/380358
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-05 21:47:28 +00:00

60 lines
1.2 KiB
C++

/*
* Copyright 2021 Google LLC.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#ifndef SKSL_DSL_ERROR_HANDLING
#define SKSL_DSL_ERROR_HANDLING
namespace SkSL {
namespace dsl {
#ifndef __has_builtin
#define __has_builtin(x) 0
#endif
class PositionInfo {
public:
#if __has_builtin(__builtin_FILE) && __has_builtin(__builtin_LINE)
explicit PositionInfo(const char* file = __builtin_FILE(), int line = __builtin_LINE())
#else
explicit PositionInfo(const char* file = nullptr, int line = -1)
#endif // __has_builtin(__builtin_FILE) && __has_builtin(__builtin_LINE)
: fFile(file)
, fLine(line) {}
const char* file_name() {
return fFile;
}
int line() {
return fLine;
}
private:
const char* fFile;
int fLine;
};
/**
* Class which is notified in the event of an error.
*/
class ErrorHandler {
public:
virtual ~ErrorHandler() {}
/**
* Reports a DSL error. Position may not be available, in which case it will be null.
*/
virtual void handleError(const char* msg, PositionInfo* position) = 0;
};
} // namespace dsl
} // namespace SkSL
#endif