b0cee9bf9a
SkCanvas keeps its non-exotic drawBitmap calls for now but they immediately wrap the bitmap in SkImage::MakeFromBitmap. This will add a copy for mutable bitmaps, but this can be worked around by using images directly (preferred), or marking the bitmap as immutable. In practice, mutable bitmaps do not seem to be widely used so this is deemed acceptable for now. Several GMs are updated to mark the bitmaps as immutable in order to avoid pixel churn in how CPU vs. GPU mipmaps are generated. As we move towards explicit mipmap generation, this distinction will become less critical, so I'm just avoiding it for now. See skbug.com/9337 for mipmap proposal. The image diffs encountered in this CL directly related to generating mipmaps for bitmaps already cached on the GPU vs. not on the GPU yet. It was decided to copy if mutable vs. never copying the bitmap because it preserves the image guarantees the devices and canvas' rely on, and imposing the need to inspect an image for mutability is undesired. Bug: skia:10037, skia:9337 Change-Id: If152e6cae1e155ccf6bd2cd755895f3c7a0135a5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276004 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
73 lines
3.4 KiB
C++
73 lines
3.4 KiB
C++
/*
|
|
* Copyright 2016 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef SkOverdrawCanvas_DEFINED
|
|
#define SkOverdrawCanvas_DEFINED
|
|
|
|
#include "include/core/SkCanvasVirtualEnforcer.h"
|
|
#include "include/utils/SkNWayCanvas.h"
|
|
|
|
/**
|
|
* Captures all drawing commands. Rather than draw the actual content, this device
|
|
* increments the alpha channel of each pixel every time it would have been touched
|
|
* by a draw call. This is useful for detecting overdraw.
|
|
*/
|
|
class SK_API SkOverdrawCanvas : public SkCanvasVirtualEnforcer<SkNWayCanvas> {
|
|
public:
|
|
/* Does not take ownership of canvas */
|
|
SkOverdrawCanvas(SkCanvas*);
|
|
|
|
void onDrawTextBlob(const SkTextBlob*, SkScalar, SkScalar, const SkPaint&) override;
|
|
void onDrawPatch(const SkPoint[12], const SkColor[4], const SkPoint[4], SkBlendMode,
|
|
const SkPaint&) override;
|
|
void onDrawPaint(const SkPaint&) override;
|
|
void onDrawBehind(const SkPaint& paint) override;
|
|
void onDrawRect(const SkRect&, const SkPaint&) override;
|
|
void onDrawRegion(const SkRegion&, const SkPaint&) override;
|
|
void onDrawOval(const SkRect&, const SkPaint&) override;
|
|
void onDrawArc(const SkRect&, SkScalar, SkScalar, bool, const SkPaint&) override;
|
|
void onDrawDRRect(const SkRRect&, const SkRRect&, const SkPaint&) override;
|
|
void onDrawRRect(const SkRRect&, const SkPaint&) override;
|
|
void onDrawPoints(PointMode, size_t, const SkPoint[], const SkPaint&) override;
|
|
#ifdef SK_SUPPORT_LEGACY_DRAWVERTS_VIRTUAL
|
|
void onDrawVerticesObject(const SkVertices*, const SkVertices::Bone bones[], int boneCount,
|
|
SkBlendMode, const SkPaint&) override;
|
|
#else
|
|
void onDrawVerticesObject(const SkVertices*, SkBlendMode, const SkPaint&) override;
|
|
#endif
|
|
void onDrawAtlas(const SkImage*, const SkRSXform[], const SkRect[], const SkColor[],
|
|
int, SkBlendMode, const SkRect*, const SkPaint*) override;
|
|
void onDrawPath(const SkPath&, const SkPaint&) override;
|
|
void onDrawImage(const SkImage*, SkScalar, SkScalar, const SkPaint*) override;
|
|
void onDrawImageRect(const SkImage*, const SkRect*, const SkRect&, const SkPaint*,
|
|
SrcRectConstraint) override;
|
|
void onDrawImageNine(const SkImage*, const SkIRect&, const SkRect&, const SkPaint*) override;
|
|
void onDrawImageLattice(const SkImage*, const Lattice&, const SkRect&, const SkPaint*) override;
|
|
void onDrawDrawable(SkDrawable*, const SkMatrix*) override;
|
|
void onDrawPicture(const SkPicture*, const SkMatrix*, const SkPaint*) override;
|
|
|
|
void onDrawAnnotation(const SkRect&, const char key[], SkData* value) override;
|
|
void onDrawShadowRec(const SkPath&, const SkDrawShadowRec&) override;
|
|
|
|
void onDrawEdgeAAQuad(const SkRect&, const SkPoint[4], SkCanvas::QuadAAFlags, const SkColor4f&,
|
|
SkBlendMode) override;
|
|
void onDrawEdgeAAImageSet(const ImageSetEntry[], int count, const SkPoint[], const SkMatrix[],
|
|
const SkPaint*, SrcRectConstraint) override;
|
|
|
|
private:
|
|
void drawPosTextCommon(const SkGlyphID[], int, const SkScalar[], int, const SkPoint&,
|
|
const SkFont&, const SkPaint&);
|
|
|
|
inline SkPaint overdrawPaint(const SkPaint& paint);
|
|
|
|
SkPaint fPaint;
|
|
|
|
typedef SkCanvasVirtualEnforcer<SkNWayCanvas> INHERITED;
|
|
};
|
|
|
|
#endif
|