AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
f953523224
skia2/include/effects
History
Mike Reed b6d2be1330 Revert "Fix SkImageSource::filterBounds()" 
This reverts commit cb4d587666.

Reason for revert: speculative fix for broken layout tests

https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/547101/layout-test-results/results.html

+fast/css/transformed-mask.html		images diff	image	pass
+svg/W3C-SVG-1.1-SE/filters-image-03-f.svg		images diff	image	pass
+svg/W3C-SVG-1.1-SE/filters-image-05-f.svg		images diff	image	pass
+svg/W3C-SVG-1.1/filters-displace-01-f.svg		images diff	image	pass
+svg/filters/feImage-preserveAspectRatio-all.svg		images diff	image	pass
+svg/filters/feImage-preserveAspectratio.svg		images diff	image	pass

Original change's description:
> Fix SkImageSource::filterBounds()
> 
> Previously SkImageSource::filterBounds() uses the default
> SkImageFilter::onFilterNodeBounds() which returns the input rect.
> 
> Now override onFilterNodeBounds() in SkImageSource to return src
> or dst rect (with transform applied).
> 
> Change-Id: I6681e1ba97affb09ef1ca5bc03b3d0f66c10f149
> Reviewed-on: https://skia-review.googlesource.com/46741
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Mike Reed <reed@google.com>

TBR=senorblanco@chromium.org,reed@google.com,wangxianzhu@chromium.org

Change-Id: Ib335f8e2ccbadc2335d23bc5f122fc5de53a8740
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/47342
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-09-15 20:30:36 +00:00
..
Sk1DPathEffect.h remove lots of legacy flags 2016-10-31 19:35:15 +00:00
Sk2DPathEffect.h
SkAlphaThresholdFilter.h remove 4 legacy flags (clients already updated) 2016-10-20 21:08:50 +00:00
SkArithmeticImageFilter.h remove unused variants in imagefilter factories 2017-06-19 01:57:51 +00:00
SkBlurDrawLooper.h Implement SkBlurDrawLooper with SkLayerDrawLooper 2017-03-28 19:29:00 +00:00
SkBlurImageFilter.h Serialize the new TileMode in SkBlurImageFilterImpl. 2017-07-11 18:13:31 +00:00
SkBlurMaskFilter.h "Fix" some ImageFilter fuzzer issues 2016-12-19 17:14:10 +00:00
SkColorFilterImageFilter.h Convert NULL and 0 to nullptr. 2017-08-28 17:48:57 +00:00
SkColorMatrix.h
SkColorMatrixFilter.h remove 4 legacy flags (clients already updated) 2016-10-20 21:08:50 +00:00
SkComposeImageFilter.h SkImageFilter::onMakeColorSpace() - more overrides 2017-04-10 21:28:43 +00:00
SkCornerPathEffect.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkDashPathEffect.h move all details for dashing into impl 2017-05-24 03:22:23 +00:00
SkDiscretePathEffect.h remove lots of legacy flags 2016-10-31 19:35:15 +00:00
SkDisplacementMapEffect.h SkImageFilter::onMakeColorSpace() - more overrides 2017-04-10 21:28:43 +00:00
SkDropShadowImageFilter.h SkImageFilter::onMakeColorSpace() - more overrides 2017-04-10 21:28:43 +00:00
SkGradientShader.h Convert NULL and 0 to nullptr. 2017-08-28 17:48:57 +00:00
SkHighContrastFilter.h Implement SkHighContrastFilter 2017-02-16 02:34:44 +00:00
SkImageSource.h Revert "Fix SkImageSource::filterBounds()" 2017-09-15 20:30:36 +00:00
SkLayerDrawLooper.h Make xformer class for SkCSXCanvas, use for draw loopers 2017-03-30 18:02:58 +00:00
SkLayerRasterizer.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkLightingImageFilter.h Implement clone for GrLightingEffect descendants 2017-07-28 14:39:57 +00:00
SkLumaColorFilter.h Make GrFragmentProcessor be non-refcounted and use std::unique_ptr. 2017-08-11 14:13:26 +00:00
SkMagnifierImageFilter.h SkImageFilter::onMakeColorSpace() - more overrides 2017-04-10 21:28:43 +00:00
SkMatrixConvolutionImageFilter.h SkImageFilter::onMakeColorSpace() - more overrides 2017-04-10 21:28:43 +00:00
SkMergeImageFilter.h Revert "Revert "remove unused api"" 2017-06-20 17:26:09 +00:00
SkMorphologyImageFilter.h SkImageFilter::onMakeColorSpace() - more overrides 2017-04-10 21:28:43 +00:00
SkOffsetImageFilter.h SkImageFilter::onMakeColorSpace() - more overrides 2017-04-10 21:28:43 +00:00
SkOverdrawColorFilter.h Add SK_API to SkOverdrawCanvas and SkOverdrawColorFilter. 2017-08-18 16:53:49 +00:00
SkPaintFlagsDrawFilter.h
SkPaintImageFilter.h Add SkImageFilter::makeColorSpace(SkColorSpaceXformer*) 2017-04-10 13:35:42 +00:00
SkPerlinNoiseShader.h move perlinenoise2 into effects 2017-05-30 20:15:37 +00:00
SkPictureImageFilter.h SkPictureImageFilter::onMakeColorSpace() 2017-04-15 12:15:36 +00:00
SkRRectsGaussianEdgeMaskFilter.h Add SkRRectsGaussianEdgeMaskFilter 2016-10-20 14:06:52 +00:00
SkTableColorFilter.h remove 4 legacy flags (clients already updated) 2016-10-20 21:08:50 +00:00
SkTableMaskFilter.h Revert "remove unused TableMaskFilter" 2017-06-19 02:50:18 +00:00
SkTileImageFilter.h SkImageFilter::onMakeColorSpace() - more overrides 2017-04-10 21:28:43 +00:00
SkToSRGBColorFilter.h Make GrFragmentProcessor be non-refcounted and use std::unique_ptr. 2017-08-11 14:13:26 +00:00
SkXfermodeImageFilter.h Revert "Revert "remove unused api on xfermodeimagefilter"" 2017-06-20 17:26:39 +00:00