f976e97a97
Currently we only constrain vertically, assuming shaped lines don't overflow horizontally. This is not true for very long words. Update kVisualResizeToFit and kVisualDownscaleToFit to constrain in both dimensions. Also drop the early exit condition because a) it makes less sense when checking in 2 dimensions (there are multiple answers which fit snugly in one dimension, but we're ultimately selecting for the largest font size) b) it probably doesn't trigger much in practice Existing tests cover the change in behavior. Bug: skia:9471 Change-Id: I4e53a51500b02ba7db26dad249458bcf491b088a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246305 Reviewed-by: Avinash Parchuri <aparchur@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> |
||
|---|---|---|
| animations | ||
| bench | ||
| bin | ||
| build_overrides | ||
| dm | ||
| docker | ||
| docs/examples | ||
| example | ||
| experimental | ||
| fuzz | ||
| gm | ||
| gn | ||
| include | ||
| infra | ||
| modules | ||
| platform_tools | ||
| resources | ||
| samplecode | ||
| site | ||
| specs | ||
| src | ||
| tests | ||
| third_party | ||
| tools | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gn | ||
| AUTHORS | ||
| BUILD.gn | ||
| codereview.settings | ||
| CONTRIBUTING | ||
| CQ_COMMITTERS | ||
| DEPS | ||
| go.mod | ||
| go.sum | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| public.bzl | ||
| README | ||
| README.chromium | ||
| RELEASE_NOTES.txt | ||
| whitespace.txt | ||
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.