Go to file
John Stiles fd36683fe6 Improve parser behavior with invalid statements inside a Block.
Previously, when the parser found a bad statement inside a Block, it
would stop processing that Block entirely. This caused our brace
matching to fall out of balance. block() would normally only return once
the Block's closing brace was consumed, but in this case, the closing
brace would still be in the parse stream awaiting consumption even
though block() had returned.

Now, when a bad statement is found inside a Block, we just ignore it and
continue processing. (I tried injecting a poisoned statement as well,
to see if it would affect the test results, but they were identical.)
This seems to generate somewhat better errors.

Change-Id: I8dc781d5602bf99d7610f8280cde8b7c1925cb65
Bug: skia:12868
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/506463
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-02-10 14:22:38 +00:00
animations
bazel [bazel] Compile gms for wasm and WebGL 2022-02-09 18:56:17 +00:00
bench Update code to prepare for -Wformat-nonliteral. 2022-02-10 14:17:33 +00:00
bin [sk] Update asset download references to use SK 2021-09-17 16:55:53 +00:00
build/fuchsia [fuchsia] Fix fidlc command. 2020-06-10 03:29:24 +00:00
build_overrides Add Abseil dependency for Dawn 2021-09-22 22:05:32 +00:00
client_utils/android Make class members that are static constexpr also be inline. 2021-10-11 16:22:59 +00:00
demos.skia.org [canvaskit] Add demo excercising lots of text 2022-02-04 13:10:29 +00:00
dm Update DM::Result to check format strings. 2022-02-10 14:18:22 +00:00
docker Switch skia-build-tools to debian11. 2022-01-28 16:51:06 +00:00
docs/examples Revert "Add kR8_unorm_SkColorType" 2022-02-09 18:46:11 +00:00
example [bazel] Use font manager in HelloWorld. 2022-01-11 16:22:52 +00:00
experimental [graphite] Fix two bugs wrt uniform uploading 2022-02-10 14:01:41 +00:00
fuzz Remove default/deprecated arguments to makeShader calls 2022-02-09 20:41:23 +00:00
gm Update code to prepare for -Wformat-nonliteral. 2022-02-10 14:17:33 +00:00
gn Remove experimental/xform 2022-02-09 19:56:49 +00:00
include [bazel] Compile gms for wasm and WebGL 2022-02-09 18:56:17 +00:00
infra [infra] Remove old error message 2022-02-09 19:40:46 +00:00
modules Remove default/deprecated arguments to makeShader calls 2022-02-09 20:41:23 +00:00
platform_tools Add regular expression capability to SKQP unittest filter 2022-01-25 21:39:44 +00:00
resources Improve parser behavior with invalid statements inside a Block. 2022-02-10 14:22:38 +00:00
samplecode Remove default/deprecated arguments to makeShader calls 2022-02-09 20:41:23 +00:00
site Update SkSL docs (isOpaque, folding) 2022-02-09 16:31:38 +00:00
specs [infra] Port serve.py from Python2 to 3 2021-08-31 15:28:19 +00:00
src Improve parser behavior with invalid statements inside a Block. 2022-02-10 14:22:38 +00:00
tests Improve parser behavior with invalid statements inside a Block. 2022-02-10 14:22:38 +00:00
third_party [bazel] Compile gms for wasm and WebGL 2022-02-09 18:56:17 +00:00
toolchain [bazel] Regenerate files and build with c++17 2022-02-01 13:15:22 +00:00
tools Update code to prepare for -Wformat-nonliteral. 2022-02-10 14:17:33 +00:00
.bazelrc [canvaskit] Add more features to Bazel build 2022-02-04 21:33:20 +00:00
.bazelversion [canvaskit] Add skottie to Bazel build 2022-02-04 19:18:27 +00:00
.clang-format no more bin packing in .clang-format 2021-03-04 17:22:50 +00:00
.clang-tidy Disable ClangTidy namespace comments for short blocks. 2020-08-24 14:01:22 +00:00
.gitignore Add .vscode to the default gitignore list. 2021-10-13 15:23:02 +00:00
.gn Pre-emptive fix for upcoming ANGLE change. 2021-01-08 17:23:52 +00:00
.vpython [python3] Reland recipes -> python3 changes 2021-12-01 13:04:03 +00:00
AUTHORS Fix a null pointer bug in SkData::copyRange 2022-01-24 19:27:13 +00:00
BUILD.bazel [bazel] Compile gms for wasm and WebGL 2022-02-09 18:56:17 +00:00
BUILD.gn Remove experimental/xform 2022-02-09 19:56:49 +00:00
codereview.settings
CONTRIBUTING
CQ_COMMITTERS
DEPS Roll ANGLE from 71d06198c62b to 670a6e476ea4 (10 revisions) 2022-02-10 05:28:39 +00:00
DIR_METADATA Move metadata in OWNERS files to DIR_METADATA files 2021-02-02 23:41:54 +00:00
go_repositories.bzl [bazel] Sketching out HelloWorld sk_app using GL 2022-01-11 13:06:19 +00:00
go.mod [bazel] Sketching out HelloWorld sk_app using GL 2022-01-11 13:06:19 +00:00
go.sum [bazel] Sketching out HelloWorld sk_app using GL 2022-01-11 13:06:19 +00:00
LICENSE
OWNERS [infra] Add wildcard OWNERS 2021-08-30 19:19:34 +00:00
PRESUBMIT.py Remove AUTHORS check from PRESUBMIT.py 2021-09-30 14:12:18 +00:00
public.bzl Remove experimental/xform 2022-02-09 19:56:49 +00:00
README
README.chromium
RELEASE_NOTES.txt Revert "Change default of skia_use_wuffs to true" 2022-02-08 22:39:58 +00:00
whitespace.txt Push shaders.skia.org. 2022-01-19 21:46:16 +00:00
WORKSPACE.bazel [bazel] Add mirrors to every external dependency. 2022-01-13 15:53:27 +00:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at https://skia.org.