v8/tools/testrunner/build_config.py

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

177 lines
6.1 KiB
Python
Raw Permalink Normal View History

# Copyright 2022 the V8 project authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
from testrunner.local import utils
# Increase the timeout for these:
SLOW_ARCHS = [
"arm", "arm64", "mips64", "mips64el", "s390", "s390x", "riscv32", "riscv64",
"loong64"
]
class BuildConfig(object):
def __init__(self, build_config, options):
self.options = options
# In V8 land, GN's x86 is called ia32.
if build_config['v8_target_cpu'] == 'x86':
self.arch = 'ia32'
else:
self.arch = build_config['v8_target_cpu']
self.asan = build_config['is_asan']
self.cfi_vptr = build_config['is_cfi']
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
self.code_comments = build_config['v8_code_comments']
self.component_build = build_config['is_component_build']
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
self.concurrent_marking = build_config['v8_enable_concurrent_marking']
self.conservative_stack_scanning = build_config[
'v8_enable_conservative_stack_scanning']
self.control_flow_integrity = build_config['v8_control_flow_integrity']
self.dcheck_always_on = build_config['dcheck_always_on']
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
self.debug_code = build_config['v8_enable_debug_code']
self.dict_property_const_tracking = build_config[
'v8_dict_property_const_tracking']
self.disassembler = build_config['v8_enable_disassembler']
self.gcov_coverage = build_config['is_gcov_coverage']
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
self.gdbjit = build_config['v8_enable_gdbjit']
self.is_android = build_config['is_android']
self.is_clang = build_config['is_clang']
self.is_debug = build_config['is_debug']
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
self.is_DEBUG_defined = build_config['is_DEBUG_defined']
self.is_full_debug = build_config['is_full_debug']
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
self.lite_mode = build_config['v8_enable_lite_mode']
self.maglev = build_config['v8_enable_maglev']
self.msan = build_config['is_msan']
self.no_i18n = not build_config['v8_enable_i18n_support']
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
self.pointer_compression = build_config['v8_enable_pointer_compression']
self.pointer_compression_shared_cage = build_config[
'v8_enable_pointer_compression_shared_cage']
self.predictable = build_config['v8_enable_verify_predictable']
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
self.sandbox = build_config['v8_enable_sandbox']
self.shared_ro_heap = build_config['v8_enable_shared_ro_heap']
self.simulator_run = (
build_config['target_cpu'] != build_config['v8_target_cpu'])
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
self.single_generation = build_config['v8_enable_single_generation']
self.slow_dchecks = build_config['v8_enable_slow_dchecks']
self.third_party_heap = build_config['v8_enable_third_party_heap']
self.tsan = build_config['is_tsan']
[turbofan] Add the v8_enable_turbofan build option When disabled, Turbofan is fully excluded from the compilation result. This is expected to reduce V8's contribution to chromium's binary size by roughly 20%. If Turbofan is disabled, Maglev and Webassembly must also be disabled (since both depend on TF). Note this new configuration (v8_enable_turbofan=false) is not yet used anywhere - we'll probably enable it for lite_mode bots in an upcoming CL for test coverage. Changes in detail: - Split out all src/compiler files from the main source sets. This was mostly done already, here we only clean up the few files that were left. - Define a new main TF entry point in turbofan.h. `NewCompilationJob` replaces `Pipeline::NewCompilationJob`. - When TF is enabled, turbofan-enabled.cc implements the above. - When disabled, turbofan-disabled stubs out the above with a runtime FATAL message. - The build process is modified s.t. mksnapshot always has TF available since it's needed to generate builtins. When disabled, TF is removed from other components, in particular it is no longer included in v8_compiler and transitively in v8_base. - When disabled, v8_for_testing no longer has v8_initializers available. These were only needed for test-serialize.cc, which is now excluded from this build mode. - When disabled, remove all related cctest/ und unittest/ files from the build. Bug: v8:13629 Change-Id: I63ab7632f03d0ee4a787cfc01574b5fdb08fd80b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4128529 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#85210}
2023-01-11 10:08:53 +00:00
self.turbofan = build_config['v8_enable_turbofan']
# TODO(machenbach): We only have ubsan not ubsan_vptr.
self.ubsan_vptr = build_config['is_ubsan_vptr']
self.verify_csa = build_config['v8_enable_verify_csa']
self.verify_heap = build_config['v8_enable_verify_heap']
Revert "[flags,testrunner] Consider readonly flags for conflict detection" This reverts commit ebd933037eb61bb3626675bdf2de800ba9f2518d. Reason for revert: Breaks a test: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8792462319927467985/+/u/OptimizeForSize/CreateIsolateFromReadOnlySnapshot Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I0cb072c6c9f05d92894cc0af83c4d1a28df100d5 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4147098 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#85133}
2023-01-09 08:48:09 +00:00
self.webassembly = build_config['v8_enable_webassembly']
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
self.write_barriers = not build_config['v8_disable_write_barriers']
# Export only for MIPS target
if self.arch in ['mips64', 'mips64el']:
self._mips_arch_variant = build_config['mips_arch_variant']
self.mips_use_msa = build_config['mips_use_msa']
@property
def use_sanitizer(self):
return (self.asan or self.cfi_vptr or self.msan or self.tsan or
self.ubsan_vptr)
@property
def no_js_shared_memory(self):
return (not self.shared_ro_heap) or (
self.pointer_compression and
not self.pointer_compression_shared_cage) or (not self.write_barriers)
@property
def is_mips_arch(self):
return self.arch in ['mips64', 'mips64el']
@property
def simd_mips(self):
return (self.is_mips_arch and self._mips_arch_variant == "r6" and
self.mips_use_msa)
@property
def mips_arch_variant(self):
return (self.is_mips_arch and self._mips_arch_variant)
@property
def no_simd_hardware(self):
# TODO(liviurau): Add some tests and refactor the logic here.
# We try to find all the reasons why we have no_simd.
no_simd_hardware = any(i in self.options.extra_flags for i in [
'--noenable-sse3', '--no-enable-sse3', '--noenable-ssse3',
'--no-enable-ssse3', '--noenable-sse4-1', '--no-enable-sse4_1'
])
# Set no_simd_hardware on architectures without Simd enabled.
if self.arch == 'mips64el':
no_simd_hardware = not self.simd_mips
if self.arch == 'loong64' or \
self.arch == 'riscv32':
no_simd_hardware = True
# S390 hosts without VEF1 do not support Simd.
if self.arch == 's390x' and \
not self.simulator_run and \
not utils.IsS390SimdSupported():
no_simd_hardware = True
# Ppc64 processors earlier than POWER9 do not support Simd instructions
if self.arch == 'ppc64' and \
not self.simulator_run and \
utils.GuessPowerProcessorVersion() < 9:
no_simd_hardware = True
return no_simd_hardware
def timeout_scalefactor(self, initial_factor):
"""Increases timeout for slow build configurations."""
factors = dict(
lite_mode=2,
predictable=4,
tsan=2,
use_sanitizer=1.5,
is_full_debug=4,
)
result = initial_factor
for k, v in factors.items():
if getattr(self, k, False):
result *= v
if self.arch in SLOW_ARCHS:
result *= 4.5
return result
def __str__(self):
attrs = [
'asan',
'cfi_vptr',
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
'code_comments',
'control_flow_integrity',
'dcheck_always_on',
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
'debug_code',
'dict_property_const_tracking',
'disassembler',
'gcov_coverage',
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
'gdbjit',
'is_debug',
'is_DEBUG_defined',
'lite_mode',
'maglev',
'msan',
'no_i18n',
Revert "[flags,testrunner] Consider readonly flags for conflict detection" This reverts commit ebd933037eb61bb3626675bdf2de800ba9f2518d. Reason for revert: Breaks a test: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8792462319927467985/+/u/OptimizeForSize/CreateIsolateFromReadOnlySnapshot Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I0cb072c6c9f05d92894cc0af83c4d1a28df100d5 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4147098 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#85133}
2023-01-09 08:48:09 +00:00
'pointer_compression',
'pointer_compression_shared_cage',
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
'predictable',
Revert "[flags,testrunner] Consider readonly flags for conflict detection" This reverts commit ebd933037eb61bb3626675bdf2de800ba9f2518d. Reason for revert: Breaks a test: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8792462319927467985/+/u/OptimizeForSize/CreateIsolateFromReadOnlySnapshot Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I0cb072c6c9f05d92894cc0af83c4d1a28df100d5 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4147098 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#85133}
2023-01-09 08:48:09 +00:00
'sandbox',
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
'slow_dchecks',
Revert "[flags,testrunner] Consider readonly flags for conflict detection" This reverts commit ebd933037eb61bb3626675bdf2de800ba9f2518d. Reason for revert: Breaks a test: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8792462319927467985/+/u/OptimizeForSize/CreateIsolateFromReadOnlySnapshot Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I0cb072c6c9f05d92894cc0af83c4d1a28df100d5 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4147098 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#85133}
2023-01-09 08:48:09 +00:00
'third_party_heap',
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
'tsan',
[turbofan] Add the v8_enable_turbofan build option When disabled, Turbofan is fully excluded from the compilation result. This is expected to reduce V8's contribution to chromium's binary size by roughly 20%. If Turbofan is disabled, Maglev and Webassembly must also be disabled (since both depend on TF). Note this new configuration (v8_enable_turbofan=false) is not yet used anywhere - we'll probably enable it for lite_mode bots in an upcoming CL for test coverage. Changes in detail: - Split out all src/compiler files from the main source sets. This was mostly done already, here we only clean up the few files that were left. - Define a new main TF entry point in turbofan.h. `NewCompilationJob` replaces `Pipeline::NewCompilationJob`. - When TF is enabled, turbofan-enabled.cc implements the above. - When disabled, turbofan-disabled stubs out the above with a runtime FATAL message. - The build process is modified s.t. mksnapshot always has TF available since it's needed to generate builtins. When disabled, TF is removed from other components, in particular it is no longer included in v8_compiler and transitively in v8_base. - When disabled, v8_for_testing no longer has v8_initializers available. These were only needed for test-serialize.cc, which is now excluded from this build mode. - When disabled, remove all related cctest/ und unittest/ files from the build. Bug: v8:13629 Change-Id: I63ab7632f03d0ee4a787cfc01574b5fdb08fd80b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4128529 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#85210}
2023-01-11 10:08:53 +00:00
'turbofan',
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
'ubsan_vptr',
'verify_csa',
Revert "[flags,testrunner] Consider readonly flags for conflict detection" This reverts commit ebd933037eb61bb3626675bdf2de800ba9f2518d. Reason for revert: Breaks a test: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8792462319927467985/+/u/OptimizeForSize/CreateIsolateFromReadOnlySnapshot Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I0cb072c6c9f05d92894cc0af83c4d1a28df100d5 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4147098 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#85133}
2023-01-09 08:48:09 +00:00
'verify_heap',
Reland "[flags,testrunner] Consider readonly flags for conflict detection" This is a reland of commit ebd933037eb61bb3626675bdf2de800ba9f2518d Original change's description: > [flags,testrunner] Consider readonly flags for conflict detection > > Flag conflict detection 1) bails out on incompatible flag values (e.g. > --jitless and --turbofan) and 2) handles such bailouts transparently in > the test runner by marking affected tests as OUTCOMES_FAIL. > > This CL adds full support for readonly flags to this system, together > with required additional annotations in variants.py. > > Drive-by: assert proper use of v8_enable_slow_dchecks, and add > support when dcheck_always_on is set. > Drive-by: introduce has_maglev build variable detection based on > v8_enable_maglev and use that for .status file annotations. > Drive-by: protect against unintended overwrites of build variables > in statusfile.py. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel > Bug: v8:13629,v8:10577 > Change-Id: I04de399139a0490806df8bfee7e75e2ec767b4b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135879 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#85130} Bug: v8:13629,v8:10577 Change-Id: I49ce322c3fda00a1e1e280d99d2d818772533927 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4151087 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85172}
2023-01-04 13:25:03 +00:00
'webassembly',
]
detected_options = [attr for attr in attrs if getattr(self, attr, False)]
return '\n'.join(detected_options)