AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
073ff8b48a
v8/test/inspector/debugger/class-private-methods-unused-expected.txt

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

84 lines
2.7 KiB
Plaintext
Raw Normal View History

[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
Test accessing unused private methods at runtime
Running test: testScopesPaused
Get privateProperties of A in testStatic()
[
[0] : {
name : #staticMethod
value : {
className : Function
description : #staticMethod() { return 1; }
[inspector] Prepend isolateId to remoteObjectId This changes remoteObjectId format from "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>". Prepending isolateId fixes the problem that remote object ids clash between processes. This is especially troubling during cross-process navigation in Chromium, see bug. We also stop producing and parsing unnecessary json for object ids. Drive-by: fixed some tests dumping object ids. Most tests avoid dumping unstable values like ids, but there were few that still did. BUG=chromium:1137143 Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#70592}
2020-10-18 02:53:33 +00:00
objectId : <objectId>
[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
type : function
}
}
]
Access A.#staticMethod() in testStatic()
{
exceptionDetails : {
columnNumber : 0
exception : {
className : ReferenceError
description : ReferenceError: A is not defined at eval (eval at testStatic (:1:1), <anonymous>:1:1) at Function.testStatic (<anonymous>:6:29) at run (<anonymous>:9:7) at <anonymous>:1:1
[inspector] Prepend isolateId to remoteObjectId This changes remoteObjectId format from "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>". Prepending isolateId fixes the problem that remote object ids clash between processes. This is especially troubling during cross-process navigation in Chromium, see bug. We also stop producing and parsing unnecessary json for object ids. Drive-by: fixed some tests dumping object ids. Most tests avoid dumping unstable values like ids, but there were few that still did. BUG=chromium:1137143 Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#70592}
2020-10-18 02:53:33 +00:00
objectId : <objectId>
[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
subtype : error
type : object
}
[inspector] Prepend isolateId to remoteObjectId This changes remoteObjectId format from "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>". Prepending isolateId fixes the problem that remote object ids clash between processes. This is especially troubling during cross-process navigation in Chromium, see bug. We also stop producing and parsing unnecessary json for object ids. Drive-by: fixed some tests dumping object ids. Most tests avoid dumping unstable values like ids, but there were few that still did. BUG=chromium:1137143 Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#70592}
2020-10-18 02:53:33 +00:00
exceptionId : <exceptionId>
[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
lineNumber : 0
[inspector] Prepend isolateId to remoteObjectId This changes remoteObjectId format from "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>". Prepending isolateId fixes the problem that remote object ids clash between processes. This is especially troubling during cross-process navigation in Chromium, see bug. We also stop producing and parsing unnecessary json for object ids. Drive-by: fixed some tests dumping object ids. Most tests avoid dumping unstable values like ids, but there were few that still did. BUG=chromium:1137143 Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#70592}
2020-10-18 02:53:33 +00:00
scriptId : <scriptId>
[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
text : Uncaught
}
result : {
className : ReferenceError
description : ReferenceError: A is not defined at eval (eval at testStatic (:1:1), <anonymous>:1:1) at Function.testStatic (<anonymous>:6:29) at run (<anonymous>:9:7) at <anonymous>:1:1
[inspector] Prepend isolateId to remoteObjectId This changes remoteObjectId format from "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>". Prepending isolateId fixes the problem that remote object ids clash between processes. This is especially troubling during cross-process navigation in Chromium, see bug. We also stop producing and parsing unnecessary json for object ids. Drive-by: fixed some tests dumping object ids. Most tests avoid dumping unstable values like ids, but there were few that still did. BUG=chromium:1137143 Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#70592}
2020-10-18 02:53:33 +00:00
objectId : <objectId>
[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
subtype : error
type : object
}
}
Access this.#staticMethod() in testStatic()
{
exceptionDetails : {
columnNumber : 0
exception : {
className : Error
description : Error: Unused static private method '#staticMethod' cannot be accessed at debug time at eval (eval at testStatic (:1:1), <anonymous>:1:1) at Function.testStatic (<anonymous>:6:29) at run (<anonymous>:9:7) at <anonymous>:1:1
[inspector] Prepend isolateId to remoteObjectId This changes remoteObjectId format from "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>". Prepending isolateId fixes the problem that remote object ids clash between processes. This is especially troubling during cross-process navigation in Chromium, see bug. We also stop producing and parsing unnecessary json for object ids. Drive-by: fixed some tests dumping object ids. Most tests avoid dumping unstable values like ids, but there were few that still did. BUG=chromium:1137143 Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#70592}
2020-10-18 02:53:33 +00:00
objectId : <objectId>
[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
subtype : error
type : object
}
[inspector] Prepend isolateId to remoteObjectId This changes remoteObjectId format from "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>". Prepending isolateId fixes the problem that remote object ids clash between processes. This is especially troubling during cross-process navigation in Chromium, see bug. We also stop producing and parsing unnecessary json for object ids. Drive-by: fixed some tests dumping object ids. Most tests avoid dumping unstable values like ids, but there were few that still did. BUG=chromium:1137143 Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#70592}
2020-10-18 02:53:33 +00:00
exceptionId : <exceptionId>
[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
lineNumber : 0
[inspector] Prepend isolateId to remoteObjectId This changes remoteObjectId format from "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>". Prepending isolateId fixes the problem that remote object ids clash between processes. This is especially troubling during cross-process navigation in Chromium, see bug. We also stop producing and parsing unnecessary json for object ids. Drive-by: fixed some tests dumping object ids. Most tests avoid dumping unstable values like ids, but there were few that still did. BUG=chromium:1137143 Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#70592}
2020-10-18 02:53:33 +00:00
scriptId : <scriptId>
[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
text : Uncaught
}
result : {
className : Error
description : Error: Unused static private method '#staticMethod' cannot be accessed at debug time at eval (eval at testStatic (:1:1), <anonymous>:1:1) at Function.testStatic (<anonymous>:6:29) at run (<anonymous>:9:7) at <anonymous>:1:1
[inspector] Prepend isolateId to remoteObjectId This changes remoteObjectId format from "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>". Prepending isolateId fixes the problem that remote object ids clash between processes. This is especially troubling during cross-process navigation in Chromium, see bug. We also stop producing and parsing unnecessary json for object ids. Drive-by: fixed some tests dumping object ids. Most tests avoid dumping unstable values like ids, but there were few that still did. BUG=chromium:1137143 Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#70592}
2020-10-18 02:53:33 +00:00
objectId : <objectId>
[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
subtype : error
type : object
}
}
get privateProperties of a in testInstance()
[
[0] : {
name : #instanceMethod
value : {
className : Function
description : #instanceMethod() { return 2; }
[inspector] Prepend isolateId to remoteObjectId This changes remoteObjectId format from "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>". Prepending isolateId fixes the problem that remote object ids clash between processes. This is especially troubling during cross-process navigation in Chromium, see bug. We also stop producing and parsing unnecessary json for object ids. Drive-by: fixed some tests dumping object ids. Most tests avoid dumping unstable values like ids, but there were few that still did. BUG=chromium:1137143 Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#70592}
2020-10-18 02:53:33 +00:00
objectId : <objectId>
[class] error when accessing unused static private method at debug time At the moment when the static private method is unused in source code (either explicitly or through eval) but is accessed at runtime through the debugger, and there are no other potential references to the class variable in the source code otherwise, the reference to the class variable is lost here since the class variable would not be context-allocated, then we could not rebuild a proper brand check for it. For now, a ReferenceError would be thrown and the method is considered "optimized away", similar to how unused ordinary methods in closures work. Before this patch it would DCHECK when generating bytecode for the debugger instead of throwing errors. Bug: v8:9839, v8:8330 Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 17:19:56 +00:00
type : function
}
}
]
Evaluating this.#instanceMethod() in testInstance()
{
result : {
description : 2
type : number
value : 2
}
}
Reference in New Issue Copy Permalink