2016-01-14 19:22:46 +00:00
|
|
|
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file.
|
|
|
|
|
|
|
|
// First test case
|
|
|
|
|
|
|
|
function FirstBuffer () {}
|
|
|
|
FirstBuffer.prototype.__proto__ = Uint8Array.prototype
|
|
|
|
FirstBuffer.__proto__ = Uint8Array
|
|
|
|
|
|
|
|
var buf = new Uint8Array(10)
|
|
|
|
buf.__proto__ = FirstBuffer.prototype
|
|
|
|
|
Revert of [typedarrays] Check detached buffer at start of typed array methods (patchset #10 id:180001 of https://codereview.chromium.org/2778623003/ )
Reason for revert:
Breaks layout tests:
https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/18499
Changes:
https://storage.googleapis.com/chromium-layout-test-archives/v8_linux_blink_rel/18499/layout-test-results/results.html
See:
https://github.com/v8/v8/wiki/Blink-layout-tests
Original issue's description:
> [typedarrays] Check detached buffer at start of typed array methods
>
> - Throw TypeError in ValidateTypedArray, matching JSC, SpiderMonkey
> and ChakraCore.
> - Validate typed arrays at start of each typed array prototype
> methods in src/js/typedarrays.js
> - Add tests to check detached buffers
> - Remove an unnecessary parameter of TypedArraySpeciesCreate
> in src/js/typedarrays.js
> - Standardize TypedArray.prototype.subarray
> - Update test262.status to pass detached buffer tests
>
> BUG=v8:4648,v8:4665,v8:4953
>
> Review-Url: https://codereview.chromium.org/2778623003
> Cr-Commit-Position: refs/heads/master@{#44357}
> Committed: https://chromium.googlesource.com/v8/v8/+/238d5b4453d9166aaddce76a5393514d977238d4
TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,littledan@chromium.org,petermarshall@chromium.org,cwhan.tunz@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4648,v8:4665,v8:4953
Review-Url: https://codereview.chromium.org/2793233003
Cr-Commit-Position: refs/heads/master@{#44362}
2017-04-04 08:01:02 +00:00
|
|
|
var buf2 = buf.subarray(2)
|
|
|
|
assertEquals(8, buf2.length);
|
2016-01-14 19:22:46 +00:00
|
|
|
|
|
|
|
// Second test case
|
|
|
|
|
|
|
|
function SecondBuffer (arg) {
|
|
|
|
var arr = new Uint8Array(arg)
|
|
|
|
arr.__proto__ = SecondBuffer.prototype
|
|
|
|
return arr
|
|
|
|
}
|
|
|
|
SecondBuffer.prototype.__proto__ = Uint8Array.prototype
|
|
|
|
SecondBuffer.__proto__ = Uint8Array
|
|
|
|
|
|
|
|
var buf3 = new SecondBuffer(10)
|
|
|
|
|
|
|
|
var buf4 = buf3.subarray(2)
|
|
|
|
|
Revert of [typedarrays] Check detached buffer at start of typed array methods (patchset #10 id:180001 of https://codereview.chromium.org/2778623003/ )
Reason for revert:
Breaks layout tests:
https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/18499
Changes:
https://storage.googleapis.com/chromium-layout-test-archives/v8_linux_blink_rel/18499/layout-test-results/results.html
See:
https://github.com/v8/v8/wiki/Blink-layout-tests
Original issue's description:
> [typedarrays] Check detached buffer at start of typed array methods
>
> - Throw TypeError in ValidateTypedArray, matching JSC, SpiderMonkey
> and ChakraCore.
> - Validate typed arrays at start of each typed array prototype
> methods in src/js/typedarrays.js
> - Add tests to check detached buffers
> - Remove an unnecessary parameter of TypedArraySpeciesCreate
> in src/js/typedarrays.js
> - Standardize TypedArray.prototype.subarray
> - Update test262.status to pass detached buffer tests
>
> BUG=v8:4648,v8:4665,v8:4953
>
> Review-Url: https://codereview.chromium.org/2778623003
> Cr-Commit-Position: refs/heads/master@{#44357}
> Committed: https://chromium.googlesource.com/v8/v8/+/238d5b4453d9166aaddce76a5393514d977238d4
TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,littledan@chromium.org,petermarshall@chromium.org,cwhan.tunz@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4648,v8:4665,v8:4953
Review-Url: https://codereview.chromium.org/2793233003
Cr-Commit-Position: refs/heads/master@{#44362}
2017-04-04 08:01:02 +00:00
|
|
|
assertEquals(8, buf4.length);
|