v8/include/cppgc/prefinalizer.h

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

76 lines
2.9 KiB
C
Raw Normal View History

// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef INCLUDE_CPPGC_PREFINALIZER_H_
#define INCLUDE_CPPGC_PREFINALIZER_H_
#include "cppgc/internal/compiler-specific.h"
#include "cppgc/liveness-broker.h"
namespace cppgc {
namespace internal {
class V8_EXPORT PrefinalizerRegistration final {
public:
Revert "cppgc: Rework prefinalizers" This reverts commit cf25b3bc53a983ccbdd0d7308f63e723bbb28a94. Reason for revert: https://crbug.com/1307471. TraceTrait must only be used during marking. Original change's description: > cppgc: Rework prefinalizers > > Move the check for whether an object is live or dead out of the > prefinalizer trampoline. Moving it into the backend allows for > inlining the check which avoids a call to the trampoline for live > objects. > > On catapult benchmarks (e.g. cnn:2021, nytimes:2020), there's often > ~2k finalizers registered. In order to avoid memory overhead in the > range of a few KB, we store the fact whether the object points to the > base object payload in the LSB of the pointer. For caged builds this > is replaced with just storing the index into the cage for both object > and base object payload. > > Locally saves around ~10% of atomic sweeping processing time which is > in the order of .05ms. > > Bug: v8:12698 > Change-Id: I198205a6b1d57fc2df821ee4e73e53dc6f825ff5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497764 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79442} Bug: v8:12698, chromium:1307471 Change-Id: I5c4e70d46cb99af66c77f0c013625b6af6c6eb8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3535781 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79527}
2022-03-18 07:44:06 +00:00
using Callback = bool (*)(const cppgc::LivenessBroker&, void*);
Revert "cppgc: Rework prefinalizers" This reverts commit cf25b3bc53a983ccbdd0d7308f63e723bbb28a94. Reason for revert: https://crbug.com/1307471. TraceTrait must only be used during marking. Original change's description: > cppgc: Rework prefinalizers > > Move the check for whether an object is live or dead out of the > prefinalizer trampoline. Moving it into the backend allows for > inlining the check which avoids a call to the trampoline for live > objects. > > On catapult benchmarks (e.g. cnn:2021, nytimes:2020), there's often > ~2k finalizers registered. In order to avoid memory overhead in the > range of a few KB, we store the fact whether the object points to the > base object payload in the LSB of the pointer. For caged builds this > is replaced with just storing the index into the cage for both object > and base object payload. > > Locally saves around ~10% of atomic sweeping processing time which is > in the order of .05ms. > > Bug: v8:12698 > Change-Id: I198205a6b1d57fc2df821ee4e73e53dc6f825ff5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497764 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79442} Bug: v8:12698, chromium:1307471 Change-Id: I5c4e70d46cb99af66c77f0c013625b6af6c6eb8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3535781 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79527}
2022-03-18 07:44:06 +00:00
PrefinalizerRegistration(void*, Callback);
void* operator new(size_t, void* location) = delete;
void* operator new(size_t) = delete;
};
} // namespace internal
/**
* Macro must be used in the private section of `Class` and registers a
* prefinalization callback `void Class::PreFinalizer()`. The callback is
* invoked on garbage collection after the collector has found an object to be
* dead.
*
* Callback properties:
* - The callback is invoked before a possible destructor for the corresponding
* object.
* - The callback may access the whole object graph, irrespective of whether
* objects are considered dead or alive.
* - The callback is invoked on the same thread as the object was created on.
*
* Example:
* \code
* class WithPrefinalizer : public GarbageCollected<WithPrefinalizer> {
* CPPGC_USING_PRE_FINALIZER(WithPrefinalizer, Dispose);
*
* public:
* void Trace(Visitor*) const {}
* void Dispose() { prefinalizer_called = true; }
* ~WithPrefinalizer() {
* // prefinalizer_called == true
* }
* private:
* bool prefinalizer_called = false;
* };
* \endcode
*/
Revert "cppgc: Rework prefinalizers" This reverts commit cf25b3bc53a983ccbdd0d7308f63e723bbb28a94. Reason for revert: https://crbug.com/1307471. TraceTrait must only be used during marking. Original change's description: > cppgc: Rework prefinalizers > > Move the check for whether an object is live or dead out of the > prefinalizer trampoline. Moving it into the backend allows for > inlining the check which avoids a call to the trampoline for live > objects. > > On catapult benchmarks (e.g. cnn:2021, nytimes:2020), there's often > ~2k finalizers registered. In order to avoid memory overhead in the > range of a few KB, we store the fact whether the object points to the > base object payload in the LSB of the pointer. For caged builds this > is replaced with just storing the index into the cage for both object > and base object payload. > > Locally saves around ~10% of atomic sweeping processing time which is > in the order of .05ms. > > Bug: v8:12698 > Change-Id: I198205a6b1d57fc2df821ee4e73e53dc6f825ff5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497764 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79442} Bug: v8:12698, chromium:1307471 Change-Id: I5c4e70d46cb99af66c77f0c013625b6af6c6eb8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3535781 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79527}
2022-03-18 07:44:06 +00:00
#define CPPGC_USING_PRE_FINALIZER(Class, PreFinalizer) \
public: \
static bool InvokePreFinalizer(const cppgc::LivenessBroker& liveness_broker, \
void* object) { \
static_assert(cppgc::IsGarbageCollectedOrMixinTypeV<Class>, \
"Only garbage collected objects can have prefinalizers"); \
Class* self = static_cast<Class*>(object); \
if (liveness_broker.IsHeapObjectAlive(self)) return false; \
self->PreFinalizer(); \
return true; \
} \
\
private: \
CPPGC_NO_UNIQUE_ADDRESS cppgc::internal::PrefinalizerRegistration \
prefinalizer_dummy_{this, Class::InvokePreFinalizer}; \
static_assert(true, "Force semicolon.")
} // namespace cppgc
#endif // INCLUDE_CPPGC_PREFINALIZER_H_