AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
1dec9199ca
v8/src/ia32/full-codegen-ia32.cc

3261 lines
103 KiB
C++
Raw Normal View History

Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Copyright 2010 the V8 project authors. All rights reserved.
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following
// disclaimer in the documentation and/or other materials provided
// with the distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived
// from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include "v8.h"
Allow build-time selection between ia32 and x86_64 in the GYP/Xcode Mac Chromium build. v8.gyp no longer sets any V8_TARGET_ARCH_* macro on the Mac. Instead, the proper V8_TARGET_ARCH_* macro will be set by src/globals.h in the same way as the V8_HOST_ARCH_* macro when it detects that no target macro is currently defined. The Mac build will attempt to compile all ia32 and x86_64 .cc files. #ifdef guards in each of these target-specific source files prevent their compilation when the associated target is not selected. For completeness, these #ifdef guards are also provided for the arm and mips .cc files. BUG=706 TEST=x86_64 Mac GYP/Xcode-based Chromium build (still depends on other changes) Review URL: http://codereview.chromium.org/2133003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4666 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-17 15:41:35 +00:00
#if defined(V8_TARGET_ARCH_IA32)
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
#include "codegen-inl.h"
Obey the flag --lazy in the toplevel code generator. There were two separate implementations of the function 'BuildBoilerplate' that is used to compile function declarations and function literals. The implementations did not do exactly the same thing. In particular, one ignored the flag --lazy. Combine the two implementations. Review URL: http://codereview.chromium.org/360011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3218 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-04 17:59:24 +00:00
#include "compiler.h"
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
#include "debug.h"
Rename the fast-codegen* files to full-codegen*. Review URL: http://codereview.chromium.org/549109 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3662 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 16:28:21 +00:00
#include "full-codegen.h"
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
#include "parser.h"
Inlining a few virtual frame functions. Introducing a virtual-frame-inl.h file containing some platform-independent virtual frame function which are small enough to be inlined. Removed unnecessary #include of virtual-frame.h from register-allocator-inl.h and added the necessary explicit includes in a number of files. Review URL: http://codereview.chromium.org/660104 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3962 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-26 09:32:48 +00:00
#include "scopes.h"
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
namespace v8 {
namespace internal {
#define __ ACCESS_MASM(masm_)
// Generate code for a JS function. On entry to the function the receiver
// and arguments have been pushed on the stack left to right, with the
// return address on top of them. The actual argument count matches the
// formal parameter count expected by the function.
//
// The live registers are:
// o edi: the JS function object being called (ie, ourselves)
// o esi: our context
// o ebp: our caller's frame pointer
Initial port of top-level code generator to ARM. For the constant true at the top level we generate: 0 stmdb sp!, {r1, r8, fp, lr} 4 add fp, sp, #8 8 ldr ip, [r10, #+4] 12 ldr r2, [r10, #+0] 16 str ip, [sp, #-4]! 20 add lr, pc, #4 24 cmp sp, r2 28 ldrcc pc, [pc, #+68] ;; code: STUB, StackCheck, minor: 0 32 ldr ip, [pc, #+68] ;; object: 0xf5bc4161 <true> 36 str ip, [sp, #-4]! 40 ldr ip, [sp, #+0] 44 str ip, [fp, #-12] 48 add sp, sp, #4 52 ldr ip, [fp, #-12] 56 str ip, [sp, #-4]! 60 ldr r0, [sp], #+4 64 mov sp, fp ;; js return 68 ldmia sp!, {fp, lr} 72 add sp, sp, #4 76 bx lr 80 ldr r0, [r10, #+4] 84 mov sp, fp ;; js return 88 ldmia sp!, {fp, lr} 92 add sp, sp, #4 96 bx lr 100 constant pool begin 104 constant 108 constant Review URL: http://codereview.chromium.org/264067 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3073 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 12:42:16 +00:00
// o esp: stack pointer (pointing to return address)
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
//
// The function builds a JS frame. Please see JavaScriptFrameConstants in
// frames-ia32.h for its layout.
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
void FullCodeGenerator::Generate(CompilationInfo* info, Mode mode) {
ASSERT(info_ == NULL);
info_ = info;
SetFunctionPosition(function());
Add comment to generated code that says which code generator compiled it. Review URL: http://codereview.chromium.org/652110 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3932 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-23 12:40:36 +00:00
Comment cmnt(masm_, "[ function compiled by full code generator");
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
if (mode == PRIMARY) {
__ push(ebp); // Caller's frame pointer.
__ mov(ebp, esp);
__ push(esi); // Callee's context.
__ push(edi); // Callee's JS Function.
{ Comment cmnt(masm_, "[ Allocate locals");
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
int locals_count = scope()->num_stack_slots();
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
if (locals_count == 1) {
__ push(Immediate(Factory::undefined_value()));
} else if (locals_count > 1) {
__ mov(eax, Immediate(Factory::undefined_value()));
for (int i = 0; i < locals_count; i++) {
__ push(eax);
}
Improve the allocation and initialization of locals on IA32 in the top-level compiler. This optimization is already done on x64 and ARM. Until now we used a push immediate for each local variable on IA32: push $undefined push $undefined ... to initialize each local variable. This change does: mov eax, $undefined push eax push eax ... Review URL: http://codereview.chromium.org/393009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3304 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-13 13:59:07 +00:00
}
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
}
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
bool function_in_register = true;
// Possibly allocate a local context.
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
int heap_slots = scope()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
if (heap_slots > 0) {
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
Comment cmnt(masm_, "[ Allocate local context");
// Argument to NewContext is the function, which is still in edi.
__ push(edi);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
if (heap_slots <= FastNewContextStub::kMaximumSlots) {
FastNewContextStub stub(heap_slots);
__ CallStub(&stub);
} else {
__ CallRuntime(Runtime::kNewContext, 1);
}
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
function_in_register = false;
// Context is returned in both eax and esi. It replaces the context
// passed to us. It's saved in the stack and kept live in esi.
__ mov(Operand(ebp, StandardFrameConstants::kContextOffset), esi);
// Copy parameters into context if necessary.
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
int num_parameters = scope()->num_parameters();
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
for (int i = 0; i < num_parameters; i++) {
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
Slot* slot = scope()->parameter(i)->slot();
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
if (slot != NULL && slot->type() == Slot::CONTEXT) {
int parameter_offset = StandardFrameConstants::kCallerSPOffset +
(num_parameters - 1 - i) * kPointerSize;
// Load parameter from stack.
__ mov(eax, Operand(ebp, parameter_offset));
Remember to update the write barrier when storing into the context in the full compiler. Clobber all input registers in the RecordWrite code when the debug-code flag is set. Review URL: http://codereview.chromium.org/569008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3761 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-02 07:58:09 +00:00
// Store it in the context.
int context_offset = Context::SlotOffset(slot->index());
__ mov(Operand(esi, context_offset), eax);
// Update the write barrier. This clobbers all involved
// registers, so we have use a third register to avoid
// clobbering esi.
__ mov(ecx, esi);
__ RecordWrite(ecx, context_offset, eax, ebx);
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
}
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
}
}
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
Variable* arguments = scope()->arguments()->AsVariable();
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
if (arguments != NULL) {
// Function uses arguments object.
Comment cmnt(masm_, "[ Allocate arguments object");
if (function_in_register) {
__ push(edi);
} else {
__ push(Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
}
// Receiver is just before the parameters on the caller's stack.
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
int offset = scope()->num_parameters() * kPointerSize;
__ lea(edx,
Operand(ebp, StandardFrameConstants::kCallerSPOffset + offset));
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
__ push(edx);
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
__ push(Immediate(Smi::FromInt(scope()->num_parameters())));
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
// Arguments to ArgumentsAccessStub:
// function, receiver address, parameter count.
// The stub will rewrite receiver and parameter count if the previous
// stack frame was an arguments adapter frame.
ArgumentsAccessStub stub(ArgumentsAccessStub::NEW_OBJECT);
__ CallStub(&stub);
__ mov(ecx, eax); // Duplicate result.
Move(arguments->slot(), eax, ebx, edx);
Slot* dot_arguments_slot =
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
scope()->arguments_shadow()->AsVariable()->slot();
Implement simple fast-path code for functions containing this property stores and global variables. Code is specialized to the initial receiver. Review URL: http://codereview.chromium.org/553149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 17:01:58 +00:00
Move(dot_arguments_slot, ecx, ebx, edx);
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
}
Fast-codegen: Added support for arguments in functions. Functions using "arguments" have their arguments object created on entry. Also added support for variables rewritten into argument object property access. Review URL: http://codereview.chromium.org/384078 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3289 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-12 11:38:01 +00:00
}
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
{ Comment cmnt(masm_, "[ Declarations");
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// For named function expressions, declare the function name as a
// constant.
if (scope()->is_function_scope() && scope()->function() != NULL) {
EmitDeclaration(scope()->function(), Variable::CONST, NULL);
}
// Visit all the explicit declarations unless there is an illegal
// redeclaration.
if (scope()->HasIllegalRedeclaration()) {
scope()->VisitIllegalRedeclaration(this);
} else {
VisitDeclarations(scope()->declarations());
}
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
}
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
{ Comment cmnt(masm_, "[ Stack check");
Label ok;
Fix issue 493: Infinite loop when debug break is set when entering function.apply. In the generated code for function.apply there was a loop checking the stack limit for interruption. This loop would call into the runtime system to handle interuption and keep running until there was no interruption. However if the interuption was debug break the runtime system would never clear the interruption as debug break is prevented in builtins are prevented and the assumption here was that returning with the debug break flag set would move execution forward. Renamed initial_jslimit and initial_climit to real_jslimit and real_climit. Renamed a few external references related to the stack limit as well. Exposed the real stack limit to generated code to make the stack check when entering function.apply use the real stack limit and not the stack limit which is changed to signal interruption. Added the real stack limit to the roots array. BUG=http://code.google.com/p/v8/issues/detail?id=493 TEST=cctest/test-debug/DebugBreakFunctionApply Review URL: http://codereview.chromium.org/345048 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3229 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 13:59:40 +00:00
ExternalReference stack_limit =
ExternalReference::address_of_stack_limit();
__ cmp(esp, Operand::StaticVariable(stack_limit));
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
__ j(above_equal, &ok, taken);
StackCheckStub stub;
__ CallStub(&stub);
__ bind(&ok);
}
Add --trace flag to fast compiler. Review URL: http://codereview.chromium.org/306026 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3111 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 11:21:29 +00:00
if (FLAG_trace) {
__ CallRuntime(Runtime::kTraceEnter, 0);
}
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
{ Comment cmnt(masm_, "[ Body");
Begin using the top-level code generator for code that is inside directly-applied function literals that are themselves compiled with the top-level code generator. The choice is guarded by a test that the function is anonymous (thus not expected to be recursive) and not in a loop. A compilation hint is set in the shared function info and used to make the choice. Review URL: http://codereview.chromium.org/341081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 14:48:59 +00:00
ASSERT(loop_depth() == 0);
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
VisitStatements(function()->body());
Begin using the top-level code generator for code that is inside directly-applied function literals that are themselves compiled with the top-level code generator. The choice is guarded by a test that the function is anonymous (thus not expected to be recursive) and not in a loop. A compilation hint is set in the shared function info and used to make the choice. Review URL: http://codereview.chromium.org/341081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 14:48:59 +00:00
ASSERT(loop_depth() == 0);
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
}
{ Comment cmnt(masm_, "[ return <undefined>;");
Emitting the common return sequence in the top-level compiler in one function for each platform. I factored out the code for emitting the return sequence since we had this code duplicated in the top-level compiler. Review URL: http://codereview.chromium.org/354024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-04 14:11:39 +00:00
// Emit a 'return undefined' in case control fell off the end of the body.
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
__ mov(eax, Factory::undefined_value());
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
EmitReturnSequence(function()->end_position());
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
}
Emitting the common return sequence in the top-level compiler in one function for each platform. I factored out the code for emitting the return sequence since we had this code duplicated in the top-level compiler. Review URL: http://codereview.chromium.org/354024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-04 14:11:39 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EmitReturnSequence(int position) {
Emitting the common return sequence in the top-level compiler in one function for each platform. I factored out the code for emitting the return sequence since we had this code duplicated in the top-level compiler. Review URL: http://codereview.chromium.org/354024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-04 14:11:39 +00:00
Comment cmnt(masm_, "[ Return sequence");
if (return_label_.is_bound()) {
__ jmp(&return_label_);
} else {
// Common return label
__ bind(&return_label_);
if (FLAG_trace) {
__ push(eax);
__ CallRuntime(Runtime::kTraceExit, 1);
Add --trace flag to fast compiler. Review URL: http://codereview.chromium.org/306026 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3111 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 11:21:29 +00:00
}
Emitting the common return sequence in the top-level compiler in one function for each platform. I factored out the code for emitting the return sequence since we had this code duplicated in the top-level compiler. Review URL: http://codereview.chromium.org/354024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-04 14:11:39 +00:00
#ifdef DEBUG
// Add a label for checking the size of the code used for returning.
Label check_exit_codesize;
masm_->bind(&check_exit_codesize);
#endif
CodeGenerator::RecordPositions(masm_, position);
__ RecordJSReturn();
// Do not use the leave instruction here because it is too short to
// patch with the code required by the debugger.
__ mov(esp, ebp);
__ pop(ebp);
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
__ ret((scope()->num_parameters() + 1) * kPointerSize);
Emitting the common return sequence in the top-level compiler in one function for each platform. I factored out the code for emitting the return sequence since we had this code duplicated in the top-level compiler. Review URL: http://codereview.chromium.org/354024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-04 14:11:39 +00:00
#ifdef ENABLE_DEBUGGER_SUPPORT
// Check that the size of the code used for returning matches what is
// expected by the debugger.
Move CPU-specific constants from debug.h into the platform-specific directories. The constant for the return sequence length (JSReturnSequenceLength) was defined in debug.h. Since this constant are also needed outside the debugger code I moved them into assembler-xxx.h. Otherwise compiling with debuggersupport=off would fail on ARM. BUG=http://code.google.com/p/v8/issues/detail?id=533 Review URL: http://codereview.chromium.org/456001 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3383 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-30 15:09:49 +00:00
ASSERT_EQ(Assembler::kJSReturnSequenceLength,
Emitting the common return sequence in the top-level compiler in one function for each platform. I factored out the code for emitting the return sequence since we had this code duplicated in the top-level compiler. Review URL: http://codereview.chromium.org/354024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-04 14:11:39 +00:00
masm_->SizeOfCodeGeneratedSince(&check_exit_codesize));
#endif
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::Apply(Expression::Context context, Register reg) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
switch (context) {
case Expression::kUninitialized:
UNREACHABLE();
case Expression::kEffect:
// Nothing to do.
break;
case Expression::kValue:
// Move value into place.
switch (location_) {
case kAccumulator:
if (!reg.is(result_register())) __ mov(result_register(), reg);
break;
case kStack:
__ push(reg);
break;
}
break;
case Expression::kTest:
// For simplicity we always test the accumulator register.
if (!reg.is(result_register())) __ mov(result_register(), reg);
DoTest(context);
break;
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
case Expression::kValueTest:
case Expression::kTestValue:
if (!reg.is(result_register())) __ mov(result_register(), reg);
switch (location_) {
case kAccumulator:
break;
case kStack:
__ push(result_register());
break;
}
DoTest(context);
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::Apply(Expression::Context context, Slot* slot) {
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
switch (context) {
case Expression::kUninitialized:
UNREACHABLE();
case Expression::kEffect:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
// Nothing to do.
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
break;
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
case Expression::kValue: {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
MemOperand slot_operand = EmitSlotSearch(slot, result_register());
switch (location_) {
case kAccumulator:
__ mov(result_register(), slot_operand);
break;
case kStack:
// Memory operands can be pushed directly.
__ push(slot_operand);
break;
}
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
break;
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
case Expression::kTest:
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
// For simplicity we always test the accumulator register.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Move(result_register(), slot);
DoTest(context);
break;
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
case Expression::kValueTest:
case Expression::kTestValue:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Move(result_register(), slot);
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
switch (location_) {
case kAccumulator:
break;
case kStack:
__ push(result_register());
break;
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
DoTest(context);
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
break;
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::Apply(Expression::Context context, Literal* lit) {
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
switch (context) {
case Expression::kUninitialized:
UNREACHABLE();
case Expression::kEffect:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
// Nothing to do.
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
break;
case Expression::kValue:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
switch (location_) {
case kAccumulator:
__ mov(result_register(), lit->handle());
break;
case kStack:
// Immediates can be pushed directly.
__ push(Immediate(lit->handle()));
break;
}
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
case Expression::kTest:
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
// For simplicity we always test the accumulator register.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ mov(result_register(), lit->handle());
DoTest(context);
break;
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
case Expression::kValueTest:
case Expression::kTestValue:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ mov(result_register(), lit->handle());
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
switch (location_) {
case kAccumulator:
break;
case kStack:
__ push(result_register());
break;
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
DoTest(context);
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
break;
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::ApplyTOS(Expression::Context context) {
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
switch (context) {
case Expression::kUninitialized:
UNREACHABLE();
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
case Expression::kEffect:
__ Drop(1);
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
case Expression::kValue:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
switch (location_) {
case kAccumulator:
__ pop(result_register());
break;
case kStack:
break;
}
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
case Expression::kTest:
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
// For simplicity we always test the accumulator register.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ pop(result_register());
DoTest(context);
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
case Expression::kValueTest:
case Expression::kTestValue:
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
switch (location_) {
case kAccumulator:
__ pop(result_register());
break;
case kStack:
__ mov(result_register(), Operand(esp, 0));
break;
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
DoTest(context);
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
break;
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::DropAndApply(int count,
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
Expression::Context context,
Register reg) {
ASSERT(count > 0);
ASSERT(!reg.is(esp));
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
switch (context) {
case Expression::kUninitialized:
UNREACHABLE();
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
case Expression::kEffect:
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
__ Drop(count);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
case Expression::kValue:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
switch (location_) {
case kAccumulator:
__ Drop(count);
if (!reg.is(result_register())) __ mov(result_register(), reg);
break;
case kStack:
if (count > 1) __ Drop(count - 1);
__ mov(Operand(esp, 0), reg);
break;
}
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
case Expression::kTest:
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
// For simplicity we always test the accumulator register.
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
__ Drop(count);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
if (!reg.is(result_register())) __ mov(result_register(), reg);
DoTest(context);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
case Expression::kValueTest:
case Expression::kTestValue:
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
switch (location_) {
case kAccumulator:
__ Drop(count);
if (!reg.is(result_register())) __ mov(result_register(), reg);
break;
case kStack:
if (count > 1) __ Drop(count - 1);
__ mov(result_register(), reg);
__ mov(Operand(esp, 0), result_register());
break;
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
DoTest(context);
break;
}
}
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
void FullCodeGenerator::PrepareTest(Label* materialize_true,
Label* materialize_false,
Label** if_true,
Label** if_false) {
switch (context_) {
case Expression::kUninitialized:
UNREACHABLE();
break;
case Expression::kEffect:
// In an effect context, the true and the false case branch to the
// same label.
*if_true = *if_false = materialize_true;
break;
case Expression::kValue:
*if_true = materialize_true;
*if_false = materialize_false;
break;
case Expression::kTest:
*if_true = true_label_;
*if_false = false_label_;
break;
case Expression::kValueTest:
*if_true = materialize_true;
*if_false = false_label_;
break;
case Expression::kTestValue:
*if_true = true_label_;
*if_false = materialize_false;
break;
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::Apply(Expression::Context context,
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Label* materialize_true,
Label* materialize_false) {
switch (context) {
case Expression::kUninitialized:
case Expression::kEffect:
ASSERT_EQ(materialize_true, materialize_false);
__ bind(materialize_true);
Add missing break in continue. TBR=fschneider@chromium.org Review URL: http://codereview.chromium.org/542107 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3640 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 23:18:09 +00:00
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
case Expression::kValue: {
Label done;
switch (location_) {
case kAccumulator:
__ bind(materialize_true);
__ mov(result_register(), Factory::true_value());
__ jmp(&done);
__ bind(materialize_false);
__ mov(result_register(), Factory::false_value());
break;
case kStack:
__ bind(materialize_true);
__ push(Immediate(Factory::true_value()));
__ jmp(&done);
__ bind(materialize_false);
__ push(Immediate(Factory::false_value()));
break;
}
__ bind(&done);
break;
}
case Expression::kTest:
break;
case Expression::kValueTest:
__ bind(materialize_true);
switch (location_) {
case kAccumulator:
__ mov(result_register(), Factory::true_value());
break;
case kStack:
__ push(Immediate(Factory::true_value()));
break;
}
__ jmp(true_label_);
break;
case Expression::kTestValue:
__ bind(materialize_false);
switch (location_) {
case kAccumulator:
__ mov(result_register(), Factory::false_value());
break;
case kStack:
__ push(Immediate(Factory::false_value()));
break;
}
__ jmp(false_label_);
break;
}
}
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Convert constant control flow (true or false) to the result expected for
// a given expression context.
void FullCodeGenerator::Apply(Expression::Context context, bool flag) {
switch (context) {
case Expression::kUninitialized:
UNREACHABLE();
break;
case Expression::kEffect:
break;
case Expression::kValue: {
Handle<Object> value =
flag ? Factory::true_value() : Factory::false_value();
switch (location_) {
case kAccumulator:
__ mov(result_register(), value);
break;
case kStack:
__ push(Immediate(value));
break;
}
break;
}
case Expression::kTest:
__ jmp(flag ? true_label_ : false_label_);
break;
case Expression::kTestValue:
switch (location_) {
case kAccumulator:
// If value is false it's needed.
if (!flag) __ mov(result_register(), Factory::false_value());
break;
case kStack:
// If value is false it's needed.
if (!flag) __ push(Immediate(Factory::false_value()));
break;
}
__ jmp(flag ? true_label_ : false_label_);
break;
case Expression::kValueTest:
switch (location_) {
case kAccumulator:
// If value is true it's needed.
if (flag) __ mov(result_register(), Factory::true_value());
break;
case kStack:
// If value is true it's needed.
if (flag) __ push(Immediate(Factory::true_value()));
break;
}
__ jmp(flag ? true_label_ : false_label_);
break;
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::DoTest(Expression::Context context) {
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
// The value to test is in the accumulator. If the value might be needed
// on the stack (value/test and test/value contexts with a stack location
// desired), then the value is already duplicated on the stack.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
ASSERT_NE(NULL, true_label_);
ASSERT_NE(NULL, false_label_);
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
// In value/test and test/value expression contexts with stack as the
// desired location, there is already an extra value on the stack. Use a
// label to discard it if unneeded.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Label discard;
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
Label* if_true = true_label_;
Label* if_false = false_label_;
switch (context) {
case Expression::kUninitialized:
case Expression::kEffect:
case Expression::kValue:
UNREACHABLE();
case Expression::kTest:
break;
case Expression::kValueTest:
switch (location_) {
case kAccumulator:
break;
case kStack:
if_false = &discard;
break;
}
break;
case Expression::kTestValue:
switch (location_) {
case kAccumulator:
break;
case kStack:
if_true = &discard;
break;
}
break;
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
// Emit the inlined tests assumed by the stub.
__ cmp(result_register(), Factory::undefined_value());
__ j(equal, if_false);
__ cmp(result_register(), Factory::true_value());
__ j(equal, if_true);
__ cmp(result_register(), Factory::false_value());
__ j(equal, if_false);
ASSERT_EQ(0, kSmiTag);
__ test(result_register(), Operand(result_register()));
__ j(zero, if_false);
__ test(result_register(), Immediate(kSmiTagMask));
__ j(zero, if_true);
Fix a bug in the short-circuit logical operations in the toplevel code generator. Review URL: http://codereview.chromium.org/542105 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 16:23:24 +00:00
// Save a copy of the value if it may be needed and isn't already saved.
switch (context) {
case Expression::kUninitialized:
case Expression::kEffect:
case Expression::kValue:
UNREACHABLE();
case Expression::kTest:
break;
case Expression::kValueTest:
switch (location_) {
case kAccumulator:
__ push(result_register());
break;
case kStack:
break;
}
break;
case Expression::kTestValue:
switch (location_) {
case kAccumulator:
__ push(result_register());
break;
case kStack:
break;
}
break;
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
// Call the ToBoolean stub for all other cases.
ToBooleanStub stub;
__ push(result_register());
__ CallStub(&stub);
__ test(eax, Operand(eax));
// The stub returns nonzero for true. Complete based on the context.
switch (context) {
case Expression::kUninitialized:
case Expression::kEffect:
case Expression::kValue:
UNREACHABLE();
case Expression::kTest:
__ j(not_zero, true_label_);
__ jmp(false_label_);
break;
case Expression::kValueTest:
switch (location_) {
case kAccumulator:
__ j(zero, &discard);
__ pop(result_register());
__ jmp(true_label_);
break;
case kStack:
__ j(not_zero, true_label_);
break;
}
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
__ bind(&discard);
__ Drop(1);
__ jmp(false_label_);
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
case Expression::kTestValue:
switch (location_) {
case kAccumulator:
__ j(not_zero, &discard);
__ pop(result_register());
__ jmp(false_label_);
break;
case kStack:
__ j(zero, false_label_);
break;
}
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
__ bind(&discard);
__ Drop(1);
__ jmp(true_label_);
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
break;
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
MemOperand FullCodeGenerator::EmitSlotSearch(Slot* slot, Register scratch) {
More cleanup of slot handling in the nonoptimizing code generator. Rename CreateSlotOperand so that it's clear it can emit code. Use it where possible. Review URL: http://codereview.chromium.org/523052 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 11:29:27 +00:00
switch (slot->type()) {
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
case Slot::PARAMETER:
case Slot::LOCAL:
More cleanup of slot handling in the nonoptimizing code generator. Rename CreateSlotOperand so that it's clear it can emit code. Use it where possible. Review URL: http://codereview.chromium.org/523052 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 11:29:27 +00:00
return Operand(ebp, SlotOffset(slot));
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
case Slot::CONTEXT: {
int context_chain_length =
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
scope()->ContextChainLength(slot->var()->scope());
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
__ LoadContext(scratch, context_chain_length);
More cleanup of slot handling in the nonoptimizing code generator. Rename CreateSlotOperand so that it's clear it can emit code. Use it where possible. Review URL: http://codereview.chromium.org/523052 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 11:29:27 +00:00
return CodeGenerator::ContextOperand(scratch, slot->index());
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
}
case Slot::LOOKUP:
More cleanup of slot handling in the nonoptimizing code generator. Rename CreateSlotOperand so that it's clear it can emit code. Use it where possible. Review URL: http://codereview.chromium.org/523052 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 11:29:27 +00:00
UNREACHABLE();
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
}
Style cleanup of switches over Slot::Type in the nonoptimizing code generator. The Slot::Type enumeration has four values. It should never be necessary to use a default to handle the case of a value out of range of the enumeration. Doing so silences a useful warning when one of the enumeration values is actually forgotten or when a new enumeration value is added. Review URL: http://codereview.chromium.org/521019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3532 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 09:11:10 +00:00
UNREACHABLE();
return Operand(eax, 0);
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::Move(Register destination, Slot* source) {
More cleanup of slot handling in the nonoptimizing code generator. Rename CreateSlotOperand so that it's clear it can emit code. Use it where possible. Review URL: http://codereview.chromium.org/523052 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 11:29:27 +00:00
MemOperand location = EmitSlotSearch(source, destination);
__ mov(destination, location);
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::Move(Slot* dst,
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
Register src,
Register scratch1,
Register scratch2) {
More cleanup of slot handling in the nonoptimizing code generator. Rename CreateSlotOperand so that it's clear it can emit code. Use it where possible. Review URL: http://codereview.chromium.org/523052 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 11:29:27 +00:00
ASSERT(dst->type() != Slot::LOOKUP); // Not yet implemented.
ASSERT(!scratch1.is(src) && !scratch2.is(src));
MemOperand location = EmitSlotSearch(dst, scratch1);
__ mov(location, src);
// Emit the write barrier code if the location is in the heap.
if (dst->type() == Slot::CONTEXT) {
int offset = FixedArray::kHeaderSize + dst->index() * kPointerSize;
__ RecordWrite(scratch1, offset, src, scratch2);
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
}
}
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
void FullCodeGenerator::EmitDeclaration(Variable* variable,
Variable::Mode mode,
FunctionLiteral* function) {
Cleanup and fix generated comments in the top-level compiler. Review URL: http://codereview.chromium.org/384087 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3298 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-13 09:42:18 +00:00
Comment cmnt(masm_, "[ Declaration");
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
ASSERT(variable != NULL); // Must have been resolved.
Slot* slot = variable->slot();
Property* prop = variable->AsProperty();
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
if (slot != NULL) {
switch (slot->type()) {
Style cleanup of switches over Slot::Type in the nonoptimizing code generator. The Slot::Type enumeration has four values. It should never be necessary to use a default to handle the case of a value out of range of the enumeration. Doing so silences a useful warning when one of the enumeration values is actually forgotten or when a new enumeration value is added. Review URL: http://codereview.chromium.org/521019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3532 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 09:11:10 +00:00
case Slot::PARAMETER:
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
case Slot::LOCAL:
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
if (mode == Variable::CONST) {
More cleanup of slot handling in the nonoptimizing code generator. Rename CreateSlotOperand so that it's clear it can emit code. Use it where possible. Review URL: http://codereview.chromium.org/523052 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 11:29:27 +00:00
__ mov(Operand(ebp, SlotOffset(slot)),
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
Immediate(Factory::the_hole_value()));
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
} else if (function != NULL) {
VisitForValue(function, kAccumulator);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ mov(Operand(ebp, SlotOffset(slot)), result_register());
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
}
break;
case Slot::CONTEXT:
More cleanup of slot handling in the nonoptimizing code generator. Rename CreateSlotOperand so that it's clear it can emit code. Use it where possible. Review URL: http://codereview.chromium.org/523052 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 11:29:27 +00:00
// We bypass the general EmitSlotSearch because we know more about
// this specific context.
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
// The variable in the decl always resides in the current context.
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
ASSERT_EQ(0, scope()->ContextChainLength(variable->scope()));
Add support for all declarations in the top-level compiler: Until now we only handled global declarations. This change adds declarations of local variables, consts and functions. Review URL: http://codereview.chromium.org/368005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3234 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 17:33:50 +00:00
if (FLAG_debug_code) {
// Check if we have the correct context pointer.
__ mov(ebx,
CodeGenerator::ContextOperand(esi, Context::FCONTEXT_INDEX));
__ cmp(ebx, Operand(esi));
__ Check(equal, "Unexpected declaration in current context.");
}
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
if (mode == Variable::CONST) {
Reapply r4686: Complete version of full codegen for x64. Already reviewed at: http://codereview.chromium.org/2078022/show TBR=vegorov@chromium.org Review URL: http://codereview.chromium.org/2137008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-20 14:33:02 +00:00
__ mov(CodeGenerator::ContextOperand(esi, slot->index()),
Immediate(Factory::the_hole_value()));
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
// No write barrier since the hole value is in old space.
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
} else if (function != NULL) {
VisitForValue(function, kAccumulator);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ mov(CodeGenerator::ContextOperand(esi, slot->index()),
result_register());
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
int offset = Context::SlotOffset(slot->index());
Avoid using RecordWrite with the context (esi, rsi, cp) as one of the arguments since this may clobber the register. Review URL: http://codereview.chromium.org/556101 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3757 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 13:20:43 +00:00
__ mov(ebx, esi);
__ RecordWrite(ebx, offset, result_register(), ecx);
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
}
break;
case Slot::LOOKUP: {
__ push(esi);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
__ push(Immediate(variable->name()));
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
// Declaration nodes are always introduced in one of two modes.
Reapply r4686: Complete version of full codegen for x64. Already reviewed at: http://codereview.chromium.org/2078022/show TBR=vegorov@chromium.org Review URL: http://codereview.chromium.org/2137008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-20 14:33:02 +00:00
ASSERT(mode == Variable::VAR || mode == Variable::CONST);
PropertyAttributes attr = (mode == Variable::VAR) ? NONE : READ_ONLY;
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
__ push(Immediate(Smi::FromInt(attr)));
// Push initial value, if any.
// Note: For variables we must not push an initial value (such as
// 'undefined') because we may have a (legal) redeclaration and we
// must not destroy the current value.
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
if (mode == Variable::CONST) {
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
__ push(Immediate(Factory::the_hole_value()));
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
} else if (function != NULL) {
VisitForValue(function, kStack);
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
} else {
__ push(Immediate(Smi::FromInt(0))); // No initial value!
}
__ CallRuntime(Runtime::kDeclareContextSlot, 4);
break;
}
}
} else if (prop != NULL) {
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
if (function != NULL || mode == Variable::CONST) {
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
// We are declaring a function or constant that rewrites to a
// property. Use (keyed) IC to set the initial value.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(prop->obj(), kStack);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
if (function != NULL) {
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
VisitForValue(prop->key(), kStack);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
VisitForValue(function, kAccumulator);
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
__ pop(ecx);
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
} else {
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
VisitForValue(prop->key(), kAccumulator);
__ mov(ecx, result_register());
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ mov(result_register(), Factory::the_hole_value());
Add support for all declarations in the top-level compiler: Until now we only handled global declarations. This change adds declarations of local variables, consts and functions. Review URL: http://codereview.chromium.org/368005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3234 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 17:33:50 +00:00
}
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
__ pop(edx);
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
// Absence of a test eax instruction following the call
// indicates that none of the load was inlined.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ nop();
The toplevel code generator assumed that declarations did not shadow parameters. This could case the initial value to be lost or worse, a crash. Fix by handling the case of a declaration shadowing both stack-allocated parameters and those in the arguments object. This is related to V8 issue 540. http://code.google.com/p/v8/issues/detail?id=540 BUG=29565 Review URL: http://codereview.chromium.org/469006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 13:31:47 +00:00
}
Add support for all declarations in the top-level compiler: Until now we only handled global declarations. This change adds declarations of local variables, consts and functions. Review URL: http://codereview.chromium.org/368005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3234 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 17:33:50 +00:00
}
}
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
void FullCodeGenerator::VisitDeclaration(Declaration* decl) {
EmitDeclaration(decl->proxy()->var(), decl->mode(), decl->fun());
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) {
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
// Call the runtime to declare the globals.
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
__ push(esi); // The context is the first argument.
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
__ push(Immediate(pairs));
Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Review URL: http://codereview.chromium.org/566008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-03 16:12:55 +00:00
__ push(Immediate(Smi::FromInt(is_eval() ? 1 : 0)));
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
__ CallRuntime(Runtime::kDeclareGlobals, 3);
// Return value is ignored.
}
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
void FullCodeGenerator::VisitSwitchStatement(SwitchStatement* stmt) {
Comment cmnt(masm_, "[ SwitchStatement");
Breakable nested_statement(this, stmt);
SetStatementPosition(stmt);
// Keep the switch value on the stack until a case matches.
VisitForValue(stmt->tag(), kStack);
ZoneList<CaseClause*>* clauses = stmt->cases();
CaseClause* default_clause = NULL; // Can occur anywhere in the list.
Label next_test; // Recycled for each test.
// Compile all the tests with branches to their bodies.
for (int i = 0; i < clauses->length(); i++) {
CaseClause* clause = clauses->at(i);
// The default is not a test, but remember it as final fall through.
if (clause->is_default()) {
default_clause = clause;
continue;
}
Comment cmnt(masm_, "[ Case comparison");
__ bind(&next_test);
next_test.Unuse();
// Compile the label expression.
VisitForValue(clause->label(), kAccumulator);
// Perform the comparison as if via '==='. The comparison stub expects
// the smi vs. smi case to be handled before it is called.
Label slow_case;
__ mov(edx, Operand(esp, 0)); // Switch value.
__ mov(ecx, edx);
__ or_(ecx, Operand(eax));
__ test(ecx, Immediate(kSmiTagMask));
__ j(not_zero, &slow_case, not_taken);
__ cmp(edx, Operand(eax));
__ j(not_equal, &next_test);
__ Drop(1); // Switch value is no longer needed.
__ jmp(clause->body_target()->entry_label());
__ bind(&slow_case);
CompareStub stub(equal, true);
__ CallStub(&stub);
__ test(eax, Operand(eax));
__ j(not_equal, &next_test);
__ Drop(1); // Switch value is no longer needed.
__ jmp(clause->body_target()->entry_label());
}
// Discard the test value and jump to the default if present, otherwise to
// the end of the statement.
__ bind(&next_test);
__ Drop(1); // Switch value is no longer needed.
if (default_clause == NULL) {
__ jmp(nested_statement.break_target());
} else {
__ jmp(default_clause->body_target()->entry_label());
}
// Compile all the case bodies.
for (int i = 0; i < clauses->length(); i++) {
Comment cmnt(masm_, "[ Case body");
CaseClause* clause = clauses->at(i);
__ bind(clause->body_target()->entry_label());
VisitStatements(clause->statements());
}
__ bind(nested_statement.break_target());
}
void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {
Comment cmnt(masm_, "[ ForInStatement");
SetStatementPosition(stmt);
Label loop, exit;
ForIn loop_statement(this, stmt);
increment_loop_depth();
// Get the object to enumerate over. Both SpiderMonkey and JSC
// ignore null and undefined in contrast to the specification; see
// ECMA-262 section 12.6.4.
VisitForValue(stmt->enumerable(), kAccumulator);
__ cmp(eax, Factory::undefined_value());
__ j(equal, &exit);
__ cmp(eax, Factory::null_value());
__ j(equal, &exit);
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Convert the object to a JS object.
Label convert, done_convert;
__ test(eax, Immediate(kSmiTagMask));
__ j(zero, &convert);
__ CmpObjectType(eax, FIRST_JS_OBJECT_TYPE, ecx);
__ j(above_equal, &done_convert);
__ bind(&convert);
__ push(eax);
__ InvokeBuiltin(Builtins::TO_OBJECT, CALL_FUNCTION);
__ bind(&done_convert);
__ push(eax);
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// TODO(kasperl): Check cache validity in generated code. This is a
// fast case for the JSObject::IsSimpleEnum cache validity
// checks. If we cannot guarantee cache validity, call the runtime
// system to check cache validity or get the property names in a
// fixed array.
// Get the set of properties to enumerate.
__ push(eax); // Duplicate the enumerable object on the stack.
__ CallRuntime(Runtime::kGetPropertyNamesFast, 1);
// If we got a map from the runtime call, we can do a fast
// modification check. Otherwise, we got a fixed array, and we have
// to do a slow check.
Label fixed_array;
__ cmp(FieldOperand(eax, HeapObject::kMapOffset), Factory::meta_map());
__ j(not_equal, &fixed_array);
// We got a map in register eax. Get the enumeration cache from it.
__ mov(ecx, FieldOperand(eax, Map::kInstanceDescriptorsOffset));
__ mov(ecx, FieldOperand(ecx, DescriptorArray::kEnumerationIndexOffset));
__ mov(edx, FieldOperand(ecx, DescriptorArray::kEnumCacheBridgeCacheOffset));
// Setup the four remaining stack slots.
__ push(eax); // Map.
__ push(edx); // Enumeration cache.
__ mov(eax, FieldOperand(edx, FixedArray::kLengthOffset));
__ push(eax); // Enumeration cache length (as smi).
__ push(Immediate(Smi::FromInt(0))); // Initial index.
__ jmp(&loop);
// We got a fixed array in register eax. Iterate through that.
__ bind(&fixed_array);
__ push(Immediate(Smi::FromInt(0))); // Map (0) - force slow check.
__ push(eax);
__ mov(eax, FieldOperand(eax, FixedArray::kLengthOffset));
__ push(eax); // Fixed array length (as smi).
__ push(Immediate(Smi::FromInt(0))); // Initial index.
// Generate code for doing the condition check.
__ bind(&loop);
__ mov(eax, Operand(esp, 0 * kPointerSize)); // Get the current index.
__ cmp(eax, Operand(esp, 1 * kPointerSize)); // Compare to the array length.
__ j(above_equal, loop_statement.break_target());
// Get the current entry of the array into register ebx.
__ mov(ebx, Operand(esp, 2 * kPointerSize));
__ mov(ebx, FieldOperand(ebx, eax, times_2, FixedArray::kHeaderSize));
// Get the expected map from the stack or a zero map in the
// permanent slow case into register edx.
__ mov(edx, Operand(esp, 3 * kPointerSize));
// Check if the expected map still matches that of the enumerable.
// If not, we have to filter the key.
Label update_each;
__ mov(ecx, Operand(esp, 4 * kPointerSize));
__ cmp(edx, FieldOperand(ecx, HeapObject::kMapOffset));
__ j(equal, &update_each);
// Convert the entry to a string or null if it isn't a property
// anymore. If the property has been removed while iterating, we
// just skip it.
__ push(ecx); // Enumerable.
__ push(ebx); // Current entry.
__ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION);
__ cmp(eax, Factory::null_value());
__ j(equal, loop_statement.continue_target());
__ mov(ebx, Operand(eax));
// Update the 'each' property or variable from the possibly filtered
// entry in register ebx.
__ bind(&update_each);
__ mov(result_register(), ebx);
// Perform the assignment as if via '='.
EmitAssignment(stmt->each());
// Generate code for the body of the loop.
Label stack_limit_hit, stack_check_done;
Visit(stmt->body());
__ StackLimitCheck(&stack_limit_hit);
__ bind(&stack_check_done);
Reapply r4686: Complete version of full codegen for x64. Already reviewed at: http://codereview.chromium.org/2078022/show TBR=vegorov@chromium.org Review URL: http://codereview.chromium.org/2137008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-20 14:33:02 +00:00
// Generate code for going to the next element by incrementing the
// index (smi) stored on top of the stack.
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
__ bind(loop_statement.continue_target());
__ add(Operand(esp, 0 * kPointerSize), Immediate(Smi::FromInt(1)));
__ jmp(&loop);
// Slow case for the stack limit check.
StackCheckStub stack_check_stub;
__ bind(&stack_limit_hit);
__ CallStub(&stack_check_stub);
__ jmp(&stack_check_done);
// Remove the pointers stored on the stack.
__ bind(loop_statement.break_target());
__ add(Operand(esp), Immediate(5 * kPointerSize));
// Exit and decrement the loop depth.
__ bind(&exit);
decrement_loop_depth();
}
void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info) {
// Use the fast case closure allocation code that allocates in new
// space for nested functions that don't need literals cloning.
if (scope()->is_function_scope() && info->num_literals() == 0) {
FastNewClosureStub stub;
__ push(Immediate(info));
__ CallStub(&stub);
} else {
__ push(esi);
__ push(Immediate(info));
__ CallRuntime(Runtime::kNewClosure, 2);
}
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
Apply(context_, eax);
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitVariableProxy(VariableProxy* expr) {
Do not visit slots in the top-level code generator's backend. Slots appear only indirectly in the AST (through variables linked to variable proxies). Slots are shared among variable references, so putting compilation-time state on them is potentially a source of bugs. Avoid it for now. Review URL: http://codereview.chromium.org/284009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3079 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-16 09:46:09 +00:00
Comment cmnt(masm_, "[ VariableProxy");
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
EmitVariableLoad(expr->var(), context_);
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EmitVariableLoad(Variable* var,
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
Expression::Context context) {
Enable references and assignments to lookup slots in the toplevel code generator. Review URL: http://codereview.chromium.org/553116 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-27 12:14:26 +00:00
// Four cases: non-this global variables, lookup slots, all other
// types of slots, and parameters that rewrite to explicit property
// accesses on the arguments object.
Slot* slot = var->slot();
Property* property = var->AsProperty();
if (var->is_global() && !var->is_this()) {
Add support for global variable references in toplevel code. We use the normal named load IC mechanism for now. Generated code is similar to the case for global variable assignments. Review URL: http://codereview.chromium.org/294021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3101 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:38:21 +00:00
Comment cmnt(masm_, "Global variable");
// Use inline caching. Variable name is passed in ecx and the global
// object on the stack.
Change LoadIC interface on ia32 to take arguments in registers. Review URL: http://codereview.chromium.org/573009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-12 10:32:24 +00:00
__ mov(eax, CodeGenerator::GlobalObject());
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
__ mov(ecx, var->name());
Add support for global variable references in toplevel code. We use the normal named load IC mechanism for now. Generated code is similar to the case for global variable assignments. Review URL: http://codereview.chromium.org/294021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3101 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:38:21 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::LoadIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET_CONTEXT);
Support for property access (named, keyed) in the fast compiler. The generated code is similar to the existing code, but we never inline any IC code in the fast compiler. Review URL: http://codereview.chromium.org/337045 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 16:11:12 +00:00
// By emitting a nop we make sure that we do not have a test eax
// instruction after the call it is treated specially by the LoadIC code
// Remember that the assembler may choose to do peephole optimization
// (eg, push/pop elimination).
__ nop();
Change LoadIC interface on ia32 to take arguments in registers. Review URL: http://codereview.chromium.org/573009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-12 10:32:24 +00:00
Apply(context, eax);
Enable references and assignments to lookup slots in the toplevel code generator. Review URL: http://codereview.chromium.org/553116 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-27 12:14:26 +00:00
} else if (slot != NULL && slot->type() == Slot::LOOKUP) {
Comment cmnt(masm_, "Lookup slot");
__ push(esi); // Context.
__ push(Immediate(var->name()));
__ CallRuntime(Runtime::kLoadContextSlot, 2);
Apply(context, eax);
} else if (slot != NULL) {
Comment cmnt(masm_, (slot->type() == Slot::CONTEXT)
? "Context slot"
: "Stack slot");
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
if (var->mode() == Variable::CONST) {
// Constants may be the hole value if they have not been initialized.
// Unhole them.
Label done;
MemOperand slot_operand = EmitSlotSearch(slot, eax);
__ mov(eax, slot_operand);
__ cmp(eax, Factory::the_hole_value());
__ j(not_equal, &done);
__ mov(eax, Factory::undefined_value());
__ bind(&done);
Apply(context, eax);
} else {
Apply(context, slot);
}
Enable references and assignments to lookup slots in the toplevel code generator. Review URL: http://codereview.chromium.org/553116 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-27 12:14:26 +00:00
Fast-codegen: Added support for arguments in functions. Functions using "arguments" have their arguments object created on entry. Also added support for variables rewritten into argument object property access. Review URL: http://codereview.chromium.org/384078 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3289 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-12 11:38:01 +00:00
} else {
Enable references and assignments to lookup slots in the toplevel code generator. Review URL: http://codereview.chromium.org/553116 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-27 12:14:26 +00:00
Comment cmnt(masm_, "Rewritten parameter");
Fast-codegen: Added support for arguments in functions. Functions using "arguments" have their arguments object created on entry. Also added support for variables rewritten into argument object property access. Review URL: http://codereview.chromium.org/384078 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3289 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-12 11:38:01 +00:00
ASSERT_NOT_NULL(property);
Enable references and assignments to lookup slots in the toplevel code generator. Review URL: http://codereview.chromium.org/553116 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-27 12:14:26 +00:00
// Rewritten parameter accesses are of the form "slot[literal]".
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
// Assert that the object is in a slot.
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
Variable* object_var = property->obj()->AsVariableProxy()->AsVariable();
ASSERT_NOT_NULL(object_var);
Slot* object_slot = object_var->slot();
ASSERT_NOT_NULL(object_slot);
// Load the object.
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
MemOperand object_loc = EmitSlotSearch(object_slot, eax);
Change KeyedLoadIC interface on ia32 to take receiver and name in registers. Review URL: http://codereview.chromium.org/601080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 10:09:54 +00:00
__ mov(edx, object_loc);
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
// Assert that the key is a smi.
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
Literal* key_literal = property->key()->AsLiteral();
ASSERT_NOT_NULL(key_literal);
ASSERT(key_literal->handle()->IsSmi());
// Load the key.
Change KeyedLoadIC interface on ia32 to take receiver and name in registers. Review URL: http://codereview.chromium.org/601080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 10:09:54 +00:00
__ mov(eax, Immediate(key_literal->handle()));
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
// Do a keyed property load.
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::KeyedLoadIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
// Notice: We must not have a "test eax, ..." instruction after the
// call. It is treated specially by the LoadIC code.
Fast-codegen: Arguments object working on all platforms. This time it's true. Review URL: http://codereview.chromium.org/405033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:28:32 +00:00
__ nop();
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
// Drop key and object left on the stack by IC.
Change KeyedLoadIC interface on ia32 to take receiver and name in registers. Review URL: http://codereview.chromium.org/601080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 10:09:54 +00:00
Apply(context, eax);
Eliminate the constant location used for literals in the AST. Literals now have a location of temporary by default and are responsible for moving themselves into their location like all other expressions. The constant location turned out not to allow us to avoid checking subexpressions in AST interior nodes, and it turned out to require checking after some normal calls to Visit (like for the arguments to a call). With this change do not have to check after a call to Visit that we got our result in the expected location. Review URL: http://codereview.chromium.org/339004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3137 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 08:48:01 +00:00
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {
Begin using the top-level code generator for code that is inside directly-applied function literals that are themselves compiled with the top-level code generator. The choice is guarded by a test that the function is anonymous (thus not expected to be recursive) and not in a loop. A compilation hint is set in the shared function info and used to make the choice. Review URL: http://codereview.chromium.org/341081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 14:48:59 +00:00
Comment cmnt(masm_, "[ RegExpLiteral");
Rename the kinds of locations to be consistent with the (codegen) context of the expressions they label. Introduce an "unintialized" location to catch failure to assign any location at all. Changed the object literal initialization on ARM to use a Store IC in the same cases where it did on the other platforms. This was required because the location of the literal property name is given an "unitialized" location. Review URL: http://codereview.chromium.org/339045 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-29 10:35:29 +00:00
Label done;
// Registers will be used as follows:
// edi = JS function.
// ebx = literals array.
// eax = regexp literal.
__ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
__ mov(ebx, FieldOperand(edi, JSFunction::kLiteralsOffset));
int literal_offset =
FixedArray::kHeaderSize + expr->literal_index() * kPointerSize;
__ mov(eax, FieldOperand(ebx, literal_offset));
__ cmp(eax, Factory::undefined_value());
__ j(not_equal, &done);
// Create regexp literal using runtime function
// Result will be in eax.
__ push(ebx);
__ push(Immediate(Smi::FromInt(expr->literal_index())));
__ push(Immediate(expr->pattern()));
__ push(Immediate(expr->flags()));
__ CallRuntime(Runtime::kMaterializeRegExpLiteral, 4);
// Label done:
__ bind(&done);
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
Apply(context_, eax);
Rename the kinds of locations to be consistent with the (codegen) context of the expressions they label. Introduce an "unintialized" location to catch failure to assign any location at all. Changed the object literal initialization on ARM to use a Store IC in the same cases where it did on the other platforms. This was required because the location of the literal property name is given an "unitialized" location. Review URL: http://codereview.chromium.org/339045 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-29 10:35:29 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
Comment cmnt(masm_, "[ ObjectLiteral");
__ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
Create literal boilerplate as part of cloning in the top-level compiler. When generating code for object and array literals we performed the check if the a boilerplate already exists in generated code. In the top-level compiler we now do this check in a new runtime function. This makes the generated code more compact for top-level code. Review URL: http://codereview.chromium.org/465148 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3437 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-09 13:06:08 +00:00
__ push(FieldOperand(edi, JSFunction::kLiteralsOffset));
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
__ push(Immediate(Smi::FromInt(expr->literal_index())));
__ push(Immediate(expr->constant_properties()));
Do not waste space for the fast-case elements backing storage for object-literals with few elements but large element indices. We can decide at parse time whether the created object literal should have fast-case of slow-case elements. Remove unused runtime function. Review URL: http://codereview.chromium.org/805004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4100 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-03-11 10:34:29 +00:00
__ push(Immediate(Smi::FromInt(expr->fast_elements() ? 1 : 0)));
Create literal boilerplate as part of cloning in the top-level compiler. When generating code for object and array literals we performed the check if the a boilerplate already exists in generated code. In the top-level compiler we now do this check in a new runtime function. This makes the generated code more compact for top-level code. Review URL: http://codereview.chromium.org/465148 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3437 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-09 13:06:08 +00:00
if (expr->depth() > 1) {
Do not waste space for the fast-case elements backing storage for object-literals with few elements but large element indices. We can decide at parse time whether the created object literal should have fast-case of slow-case elements. Remove unused runtime function. Review URL: http://codereview.chromium.org/805004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4100 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-03-11 10:34:29 +00:00
__ CallRuntime(Runtime::kCreateObjectLiteral, 4);
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
} else {
Do not waste space for the fast-case elements backing storage for object-literals with few elements but large element indices. We can decide at parse time whether the created object literal should have fast-case of slow-case elements. Remove unused runtime function. Review URL: http://codereview.chromium.org/805004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4100 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-03-11 10:34:29 +00:00
__ CallRuntime(Runtime::kCreateObjectLiteralShallow, 4);
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
// If result_saved is true the result is on top of the stack. If
// result_saved is false the result is in eax.
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
bool result_saved = false;
for (int i = 0; i < expr->properties()->length(); i++) {
ObjectLiteral::Property* property = expr->properties()->at(i);
In the toplevel compiler, shift the responsibility of assigning a location to an Expression AST node from the node's parent to the node itself. This allows an inherited code generation context from a parent node to be passed arbitrarily far down the tree (eg, the subexpression of a unary not is in the same context as the unary expression itself, the then and else subexpressions of the ternary operator are in the same context as the whole expression, and so forth). We do not yet take advantage of this in the backend (eg, the right subexpression of short-circuited OR is still compiled by using the parent's destination location, rather than the subexpression's itself). Review URL: http://codereview.chromium.org/340005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-28 13:25:40 +00:00
if (property->IsCompileTimeValue()) continue;
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
Literal* key = property->key();
Expression* value = property->value();
if (!result_saved) {
__ push(eax); // Save result on the stack
result_saved = true;
}
switch (property->kind()) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
case ObjectLiteral::Property::MATERIALIZED_LITERAL:
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
ASSERT(!CompileTimeValue::IsCompileTimeValue(value));
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
// Fall through.
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
case ObjectLiteral::Property::COMPUTED:
if (key->handle()->IsSymbol()) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(value, kAccumulator);
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
__ mov(ecx, Immediate(key->handle()));
StoreIC interface changed on ia32 to take receiver in edx, not on stack. Review URL: http://codereview.chromium.org/555162 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 08:35:38 +00:00
__ mov(edx, Operand(esp, 0));
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ nop();
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
break;
}
Style cleanup of switches over Slot::Type in the nonoptimizing code generator. The Slot::Type enumeration has four values. It should never be necessary to use a default to handle the case of a value out of range of the enumeration. Doing so silences a useful warning when one of the enumeration values is actually forgotten or when a new enumeration value is added. Review URL: http://codereview.chromium.org/521019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3532 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 09:11:10 +00:00
// Fall through.
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
case ObjectLiteral::Property::PROTOTYPE:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ push(Operand(esp, 0)); // Duplicate receiver.
VisitForValue(key, kStack);
VisitForValue(value, kStack);
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
__ CallRuntime(Runtime::kSetProperty, 3);
break;
Style cleanup of switches over Slot::Type in the nonoptimizing code generator. The Slot::Type enumeration has four values. It should never be necessary to use a default to handle the case of a value out of range of the enumeration. Doing so silences a useful warning when one of the enumeration values is actually forgotten or when a new enumeration value is added. Review URL: http://codereview.chromium.org/521019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3532 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 09:11:10 +00:00
case ObjectLiteral::Property::SETTER:
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
case ObjectLiteral::Property::GETTER:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ push(Operand(esp, 0)); // Duplicate receiver.
VisitForValue(key, kStack);
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
__ push(Immediate(property->kind() == ObjectLiteral::Property::SETTER ?
Smi::FromInt(1) :
Smi::FromInt(0)));
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(value, kStack);
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
__ CallRuntime(Runtime::kDefineAccessor, 4);
break;
default: UNREACHABLE();
}
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
if (result_saved) {
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
ApplyTOS(context_);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
} else {
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
Apply(context_, eax);
Support for object literals in fast compiler. I also added more unit tests for literals. Right now, the fast compiler produces code very similar to the existing code generator. We may consider different ways to further compact the generated code for top-level code. ARM always goes through a runtime function to initialize computed properties in an object literal whereas IA32 and x64 use StoreIC. Review URL: http://codereview.chromium.org/316009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-26 13:21:48 +00:00
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
Comment cmnt(masm_, "[ ArrayLiteral");
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
ZoneList<Expression*>* subexprs = expr->values();
int length = subexprs->length();
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
__ mov(ebx, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
Create literal boilerplate as part of cloning in the top-level compiler. When generating code for object and array literals we performed the check if the a boilerplate already exists in generated code. In the top-level compiler we now do this check in a new runtime function. This makes the generated code more compact for top-level code. Review URL: http://codereview.chromium.org/465148 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3437 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-09 13:06:08 +00:00
__ push(FieldOperand(ebx, JSFunction::kLiteralsOffset));
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
__ push(Immediate(Smi::FromInt(expr->literal_index())));
Use one runtime call for creating object/array literals in the code generator. The runtime function checks if it needs to create a boilerplate object or if it can clone from an existing boilerplate. This is already done in the top-level compiler. Review URL: http://codereview.chromium.org/507036 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3516 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-22 12:41:45 +00:00
__ push(Immediate(expr->constant_elements()));
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
if (expr->depth() > 1) {
Create literal boilerplate as part of cloning in the top-level compiler. When generating code for object and array literals we performed the check if the a boilerplate already exists in generated code. In the top-level compiler we now do this check in a new runtime function. This makes the generated code more compact for top-level code. Review URL: http://codereview.chromium.org/465148 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3437 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-09 13:06:08 +00:00
__ CallRuntime(Runtime::kCreateArrayLiteral, 3);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
} else if (length > FastCloneShallowArrayStub::kMaximumLength) {
Create literal boilerplate as part of cloning in the top-level compiler. When generating code for object and array literals we performed the check if the a boilerplate already exists in generated code. In the top-level compiler we now do this check in a new runtime function. This makes the generated code more compact for top-level code. Review URL: http://codereview.chromium.org/465148 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3437 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-09 13:06:08 +00:00
__ CallRuntime(Runtime::kCreateArrayLiteralShallow, 3);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
} else {
FastCloneShallowArrayStub stub(length);
__ CallStub(&stub);
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
}
bool result_saved = false; // Is the result saved to the stack?
// Emit code to evaluate all the non-constant subexpressions and to store
// them into the newly cloned array.
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
for (int i = 0; i < length; i++) {
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
Expression* subexpr = subexprs->at(i);
// If the subexpression is a literal or a simple materialized literal it
// is already set in the cloned array.
if (subexpr->AsLiteral() != NULL ||
CompileTimeValue::IsCompileTimeValue(subexpr)) {
continue;
}
if (!result_saved) {
__ push(eax);
result_saved = true;
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(subexpr, kAccumulator);
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
// Store the subexpression value in the array's elements.
__ mov(ebx, Operand(esp, 0)); // Copy of array literal.
__ mov(ebx, FieldOperand(ebx, JSObject::kElementsOffset));
int offset = FixedArray::kHeaderSize + (i * kPointerSize);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ mov(FieldOperand(ebx, offset), result_register());
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
// Update the write barrier for the array store.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ RecordWrite(ebx, offset, result_register(), ecx);
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
if (result_saved) {
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
ApplyTOS(context_);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
} else {
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
Apply(context_, eax);
Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Review URL: http://codereview.chromium.org/303021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-22 10:07:45 +00:00
}
}
Fix error in compound assignment to keyed load by making platform-independent full compiler code platform dependent, add test of compound assignments. Review URL: http://codereview.chromium.org/646009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3897 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 12:59:41 +00:00
void FullCodeGenerator::VisitAssignment(Assignment* expr) {
Comment cmnt(masm_, "[ Assignment");
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Invalid left-hand sides are rewritten to have a 'throw ReferenceError'
// on the left-hand side.
if (!expr->target()->IsValidLeftHandSide()) {
VisitForEffect(expr->target());
return;
}
Fix error in compound assignment to keyed load by making platform-independent full compiler code platform dependent, add test of compound assignments. Review URL: http://codereview.chromium.org/646009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3897 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 12:59:41 +00:00
// Left-hand side can only be a property, a global or a (parameter or local)
// slot. Variables with rewrite to .arguments are treated as KEYED_PROPERTY.
enum LhsKind { VARIABLE, NAMED_PROPERTY, KEYED_PROPERTY };
LhsKind assign_type = VARIABLE;
Property* prop = expr->target()->AsProperty();
if (prop != NULL) {
assign_type =
(prop->key()->IsPropertyName()) ? NAMED_PROPERTY : KEYED_PROPERTY;
}
// Evaluate LHS expression.
switch (assign_type) {
case VARIABLE:
// Nothing to do here.
break;
case NAMED_PROPERTY:
if (expr->is_compound()) {
// We need the receiver both on the stack and in the accumulator.
VisitForValue(prop->obj(), kAccumulator);
__ push(result_register());
} else {
VisitForValue(prop->obj(), kStack);
}
break;
case KEYED_PROPERTY:
if (expr->is_compound()) {
VisitForValue(prop->obj(), kStack);
VisitForValue(prop->key(), kAccumulator);
__ mov(edx, Operand(esp, 0));
__ push(eax);
} else {
VisitForValue(prop->obj(), kStack);
VisitForValue(prop->key(), kStack);
}
break;
}
// If we have a compound assignment: Get value of LHS expression and
// store in on top of the stack.
if (expr->is_compound()) {
Location saved_location = location_;
location_ = kStack;
switch (assign_type) {
case VARIABLE:
EmitVariableLoad(expr->target()->AsVariableProxy()->var(),
Expression::kValue);
break;
case NAMED_PROPERTY:
EmitNamedPropertyLoad(prop);
__ push(result_register());
break;
case KEYED_PROPERTY:
EmitKeyedPropertyLoad(prop);
__ push(result_register());
break;
}
location_ = saved_location;
}
// Evaluate RHS expression.
Expression* rhs = expr->value();
VisitForValue(rhs, kAccumulator);
// If we have a compound assignment: Apply operator.
if (expr->is_compound()) {
Location saved_location = location_;
location_ = kAccumulator;
EmitBinaryOp(expr->binary_op(), Expression::kValue);
location_ = saved_location;
}
// Record source position before possible IC call.
SetSourcePosition(expr->position());
// Store the value.
switch (assign_type) {
case VARIABLE:
EmitVariableAssignment(expr->target()->AsVariableProxy()->var(),
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
expr->op(),
Fix error in compound assignment to keyed load by making platform-independent full compiler code platform dependent, add test of compound assignments. Review URL: http://codereview.chromium.org/646009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3897 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 12:59:41 +00:00
context_);
break;
case NAMED_PROPERTY:
EmitNamedPropertyAssignment(expr);
break;
case KEYED_PROPERTY:
EmitKeyedPropertyAssignment(expr);
break;
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EmitNamedPropertyLoad(Property* prop) {
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
SetSourcePosition(prop->position());
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
Literal* key = prop->key()->AsLiteral();
__ mov(ecx, Immediate(key->handle()));
Handle<Code> ic(Builtins::builtin(Builtins::LoadIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
Fix issue 541 and some refactoring of the top-level compiler. * Refactor VisitProperty to use the platform-specific methods for emitting the IC calls. * Refactor recording of source positions in the top-level compiler. * Correct the recorded source positions for assignments and property loads. * Fix bug on x64 where source positions were not recorded before a calling a call-IC. * Correct some inconsistencies between IA-32 and X64 top-level code generator. We now pass all regression tests with --always-fast-compiler. Review URL: http://codereview.chromium.org/550043 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-15 12:00:59 +00:00
__ nop();
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EmitKeyedPropertyLoad(Property* prop) {
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
SetSourcePosition(prop->position());
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::KeyedLoadIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
Fix issue 541 and some refactoring of the top-level compiler. * Refactor VisitProperty to use the platform-specific methods for emitting the IC calls. * Refactor recording of source positions in the top-level compiler. * Correct the recorded source positions for assignments and property loads. * Fix bug on x64 where source positions were not recorded before a calling a call-IC. * Correct some inconsistencies between IA-32 and X64 top-level code generator. We now pass all regression tests with --always-fast-compiler. Review URL: http://codereview.chromium.org/550043 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-15 12:00:59 +00:00
__ nop();
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EmitBinaryOp(Token::Value op,
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Expression::Context context) {
__ push(result_register());
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
GenericBinaryOpStub stub(op,
NO_OVERWRITE,
Make more use of the NumberInfo data. Makes NumberInfo into a real class. Fix bug where NumberInfo was lost in ToRegister. Allow 17 bits in safe Smis instead of 16. Review URL: http://codereview.chromium.org/668151 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4046 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-03-05 23:54:13 +00:00
NO_GENERIC_BINARY_FLAGS,
Rename NumberInfo to TypeInfo. Since we add more type (StringType, PrimitiveType) the name NumberInfo does not make sense anymore. Review URL: http://codereview.chromium.org/1207006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4268 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-03-25 12:44:15 +00:00
TypeInfo::Unknown());
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
__ CallStub(&stub);
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
Apply(context, eax);
Adding compound assignments to the top-level compiler. Review URL: http://codereview.chromium.org/486008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-11 16:09:16 +00:00
}
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
void FullCodeGenerator::EmitAssignment(Expression* expr) {
// Invalid left-hand sides are rewritten to have a 'throw
// ReferenceError' on the left-hand side.
if (!expr->IsValidLeftHandSide()) {
VisitForEffect(expr);
return;
}
// Left-hand side can only be a property, a global or a (parameter or local)
// slot. Variables with rewrite to .arguments are treated as KEYED_PROPERTY.
enum LhsKind { VARIABLE, NAMED_PROPERTY, KEYED_PROPERTY };
LhsKind assign_type = VARIABLE;
Property* prop = expr->AsProperty();
if (prop != NULL) {
assign_type = (prop->key()->IsPropertyName())
? NAMED_PROPERTY
: KEYED_PROPERTY;
}
switch (assign_type) {
case VARIABLE: {
Variable* var = expr->AsVariableProxy()->var();
EmitVariableAssignment(var, Token::ASSIGN, Expression::kEffect);
break;
}
case NAMED_PROPERTY: {
__ push(eax); // Preserve value.
VisitForValue(prop->obj(), kAccumulator);
__ mov(edx, eax);
__ pop(eax); // Restore value.
__ mov(ecx, prop->key()->AsLiteral()->handle());
Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
__ nop(); // Signal no inlined code.
break;
}
case KEYED_PROPERTY: {
__ push(eax); // Preserve value.
VisitForValue(prop->obj(), kStack);
VisitForValue(prop->key(), kAccumulator);
__ mov(ecx, eax);
__ pop(edx);
__ pop(eax); // Restore value.
Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
__ nop(); // Signal no inlined code.
break;
}
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EmitVariableAssignment(Variable* var,
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
Token::Value op,
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
Expression::Context context) {
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Left-hand sides that rewrite to explicit property accesses do not reach
// here.
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
ASSERT(var != NULL);
Refactor code for generating assignments in the fast compiler. 1. Refactor the structure of VisitAssignment: The existing code is not ideal to be extended with support for compound assignments. 2. Reuse common code for keyed property assigments: Now variables rewritten to a property (.arguments access) are treated like normal keyed property assignments. This allows us to remove some code duplication. Review URL: http://codereview.chromium.org/456024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3425 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-04 14:30:27 +00:00
ASSERT(var->is_global() || var->slot() != NULL);
Enable references and assignments to lookup slots in the toplevel code generator. Review URL: http://codereview.chromium.org/553116 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-27 12:14:26 +00:00
Refactor the somewhat complicated code generation for assignments into a platform-independent structure and a few platform-specific helpers to do the heavy lifting. Review URL: http://codereview.chromium.org/342073 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 11:01:47 +00:00
if (var->is_global()) {
Enable references and assignments to lookup slots in the toplevel code generator. Review URL: http://codereview.chromium.org/553116 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-27 12:14:26 +00:00
ASSERT(!var->is_this());
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
// Assignment to a global variable. Use inline caching for the
// assignment. Right-hand-side value is passed in eax, variable name in
// ecx, and the global object on the stack.
Added support for assignments to global variables in the toplevel code generator. We use the normal store IC mechanism with the global object as the receiver. The following code is generated for 'x=true' at toplevel. ======== IA32: 27 mov eax,0xf5d06161 ;; object: 0xf5d06161 <true> 32 mov ecx,0xf5d09c35 ;; object: 0xf5d09c35 <String[1]: x> 37 push [esi+0x17] 40 call StoreIC_Initialize (0xf5ce75c0) ;; code: STORE_IC, UNINITIALIZED 45 mov [esp],eax ======== X64: 25 movq rax,0x7f867a7b6199 ;; object: 0x7f867a7b6199 <true> 35 movq rcx,0x7f867a7bae71 ;; object: 0x7f867a7bae71 <String[1]: x> 45 push [rsi+0x2f] 49 call StoreIC_Initialize (0x7f8655929ac0) ;; code: STORE_IC, UNINITIALIZED 54 movq [rsp],rax ======== ARM: 32 e59f0054 ldr r0, [pc, #+84] ;; object: 0xf5b78161 <true> 36 e59f2054 ldr r2, [pc, #+84] ;; object: 0xf5b7bc35 <String[1]: x> 40 e598c017 ldr ip, [r8, #+23] 44 e52dc004 str ip, [sp, #-4]! 48 e1a0e00f mov lr, pc 52 e59ff048 ldr pc, [pc, #+72] ;; debug: statement 0 ;; code: STORE_IC, UNINITIALIZED 56 e58d0000 str r0, [sp, #+0] Review URL: http://codereview.chromium.org/305005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-20 13:37:26 +00:00
__ mov(ecx, var->name());
StoreIC interface changed on ia32 to take receiver in edx, not on stack. Review URL: http://codereview.chromium.org/555162 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 08:35:38 +00:00
__ mov(edx, CodeGenerator::GlobalObject());
Added support for assignments to global variables in the toplevel code generator. We use the normal store IC mechanism with the global object as the receiver. The following code is generated for 'x=true' at toplevel. ======== IA32: 27 mov eax,0xf5d06161 ;; object: 0xf5d06161 <true> 32 mov ecx,0xf5d09c35 ;; object: 0xf5d09c35 <String[1]: x> 37 push [esi+0x17] 40 call StoreIC_Initialize (0xf5ce75c0) ;; code: STORE_IC, UNINITIALIZED 45 mov [esp],eax ======== X64: 25 movq rax,0x7f867a7b6199 ;; object: 0x7f867a7b6199 <true> 35 movq rcx,0x7f867a7bae71 ;; object: 0x7f867a7bae71 <String[1]: x> 45 push [rsi+0x2f] 49 call StoreIC_Initialize (0x7f8655929ac0) ;; code: STORE_IC, UNINITIALIZED 54 movq [rsp],rax ======== ARM: 32 e59f0054 ldr r0, [pc, #+84] ;; object: 0xf5b78161 <true> 36 e59f2054 ldr r2, [pc, #+84] ;; object: 0xf5b7bc35 <String[1]: x> 40 e598c017 ldr ip, [r8, #+23] 44 e52dc004 str ip, [sp, #-4]! 48 e1a0e00f mov lr, pc 52 e59ff048 ldr pc, [pc, #+72] ;; debug: statement 0 ;; code: STORE_IC, UNINITIALIZED 56 e58d0000 str r0, [sp, #+0] Review URL: http://codereview.chromium.org/305005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-20 13:37:26 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
Fix issue 541 and some refactoring of the top-level compiler. * Refactor VisitProperty to use the platform-specific methods for emitting the IC calls. * Refactor recording of source positions in the top-level compiler. * Correct the recorded source positions for assignments and property loads. * Fix bug on x64 where source positions were not recorded before a calling a call-IC. * Correct some inconsistencies between IA-32 and X64 top-level code generator. We now pass all regression tests with --always-fast-compiler. Review URL: http://codereview.chromium.org/550043 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-15 12:00:59 +00:00
__ nop();
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
} else if (var->mode() != Variable::CONST || op == Token::INIT_CONST) {
// Perform the assignment for non-const variables and for initialization
// of const variables. Const assignments are simply skipped.
Label done;
Slot* slot = var->slot();
Enable writes and reads of context slots in fast compiler. Review URL: http://codereview.chromium.org/360054 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-09 09:56:57 +00:00
switch (slot->type()) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
case Slot::PARAMETER:
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
case Slot::LOCAL:
if (op == Token::INIT_CONST) {
// Detect const reinitialization by checking for the hole value.
__ mov(edx, Operand(ebp, SlotOffset(slot)));
__ cmp(edx, Factory::the_hole_value());
__ j(not_equal, &done);
}
// Perform the assignment.
__ mov(Operand(ebp, SlotOffset(slot)), eax);
Refactor the somewhat complicated code generation for assignments into a platform-independent structure and a few platform-specific helpers to do the heavy lifting. Review URL: http://codereview.chromium.org/342073 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 11:01:47 +00:00
break;
Enable writes and reads of context slots in fast compiler. Review URL: http://codereview.chromium.org/360054 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-09 09:56:57 +00:00
case Slot::CONTEXT: {
More cleanup of slot handling in the nonoptimizing code generator. Rename CreateSlotOperand so that it's clear it can emit code. Use it where possible. Review URL: http://codereview.chromium.org/523052 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 11:29:27 +00:00
MemOperand target = EmitSlotSearch(slot, ecx);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
if (op == Token::INIT_CONST) {
// Detect const reinitialization by checking for the hole value.
__ mov(edx, target);
__ cmp(edx, Factory::the_hole_value());
__ j(not_equal, &done);
}
// Perform the assignment and issue the write barrier.
__ mov(target, eax);
// The value of the assignment is in eax. RecordWrite clobbers its
// register arguments.
__ mov(edx, eax);
Enable writes and reads of context slots in fast compiler. Review URL: http://codereview.chromium.org/360054 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-09 09:56:57 +00:00
int offset = FixedArray::kHeaderSize + slot->index() * kPointerSize;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ RecordWrite(ecx, offset, edx, ebx);
Refactor the somewhat complicated code generation for assignments into a platform-independent structure and a few platform-specific helpers to do the heavy lifting. Review URL: http://codereview.chromium.org/342073 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 11:01:47 +00:00
break;
Added support for assignments to global variables in the toplevel code generator. We use the normal store IC mechanism with the global object as the receiver. The following code is generated for 'x=true' at toplevel. ======== IA32: 27 mov eax,0xf5d06161 ;; object: 0xf5d06161 <true> 32 mov ecx,0xf5d09c35 ;; object: 0xf5d09c35 <String[1]: x> 37 push [esi+0x17] 40 call StoreIC_Initialize (0xf5ce75c0) ;; code: STORE_IC, UNINITIALIZED 45 mov [esp],eax ======== X64: 25 movq rax,0x7f867a7b6199 ;; object: 0x7f867a7b6199 <true> 35 movq rcx,0x7f867a7bae71 ;; object: 0x7f867a7bae71 <String[1]: x> 45 push [rsi+0x2f] 49 call StoreIC_Initialize (0x7f8655929ac0) ;; code: STORE_IC, UNINITIALIZED 54 movq [rsp],rax ======== ARM: 32 e59f0054 ldr r0, [pc, #+84] ;; object: 0xf5b78161 <true> 36 e59f2054 ldr r2, [pc, #+84] ;; object: 0xf5b7bc35 <String[1]: x> 40 e598c017 ldr ip, [r8, #+23] 44 e52dc004 str ip, [sp, #-4]! 48 e1a0e00f mov lr, pc 52 e59ff048 ldr pc, [pc, #+72] ;; debug: statement 0 ;; code: STORE_IC, UNINITIALIZED 56 e58d0000 str r0, [sp, #+0] Review URL: http://codereview.chromium.org/305005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-20 13:37:26 +00:00
}
Enable writes and reads of context slots in fast compiler. Review URL: http://codereview.chromium.org/360054 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-09 09:56:57 +00:00
case Slot::LOOKUP:
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Call the runtime for the assignment. The runtime will ignore
// const reinitialization.
__ push(eax); // Value.
__ push(esi); // Context.
__ push(Immediate(var->name()));
if (op == Token::INIT_CONST) {
// The runtime will ignore const redeclaration.
__ CallRuntime(Runtime::kInitializeConstContextSlot, 3);
} else {
__ CallRuntime(Runtime::kStoreContextSlot, 3);
}
Enable writes and reads of context slots in fast compiler. Review URL: http://codereview.chromium.org/360054 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-09 09:56:57 +00:00
break;
Recognize in the fast-mode code generator when a subexpression is a constant known at compile time. Do not ever use the stack to materialize (non-function-argument) constants. Currently, constants are only the non-materialized, non-function literals in the AST. It is a known issue that there is no test coverage for the cases of assigning a non-literal to a variable and returning a literal. Those code paths are unreachable and tests will be added when they become reachable. For the code '.result = true', we had previously on ia32: 27 push 0xf5c28161 ;; object: 0xf5c28161 <true> 32 pop [ebp+0xf4] Now: 27 mov eax,0xf5c26161 ;; object: 0xf5c26161 <true> 32 mov [ebp+0xf4],eax ======== We had previously on x64: 25 movq r10,0x7fb8c2f78199 ;; object: 0x7fb8c2f78199 <true> 35 push r10 37 pop [rbp-0x18] Now: 25 movq r10,0x7fb131386199 ;; object: 0x7fb131386199 <true> 35 movq [rbp-0x18],r10 The generated code for ARM did not include the extra memory traffic. It was already eliminated by the ARM assembler's push/pop elimination. Review URL: http://codereview.chromium.org/300003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3088 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-19 10:36:42 +00:00
}
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
__ bind(&done);
Added first support for tracking locations of expressions in the fast-mode code generator. AST expression nodes are annotated with a location when doing the initial syntactic check of the AST. In the current implementation, expression locations are 'temporary' (ie, allocated to the stack) or 'nowhere' (ie, the expression's value is not needed though it must be evaluated for side effects). For the assignment '.result = true' on IA32, we had before (with the true value already on top of the stack): 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax Now: 32 pop [ebp+0xf4] ======== On x64, before: 37 movq rax,[rsp] 41 movq [rbp-0x18],rax 45 pop rax Now: 37 pop [rbp-0x18] ======== On ARM, before (with the true value in register ip): 36 str ip, [sp, #-4]! 40 ldr ip, [sp, #+0] 44 str ip, [fp, #-12] 48 add sp, sp, #4 Now: 36 str ip, [fp, #-12] Review URL: http://codereview.chromium.org/267118 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3076 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 16:42:22 +00:00
}
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
Apply(context, eax);
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EmitNamedPropertyAssignment(Assignment* expr) {
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
// Assignment to a property, using a named store IC.
Property* prop = expr->target()->AsProperty();
ASSERT(prop != NULL);
ASSERT(prop->key()->AsLiteral() != NULL);
// If the assignment starts a block of assignments to the same object,
// change to slow case to avoid the quadratic behavior of repeatedly
// adding fast properties.
if (expr->starts_initialization_block()) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ push(result_register());
__ push(Operand(esp, kPointerSize)); // Receiver is now under value.
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
__ CallRuntime(Runtime::kToSlowProperties, 1);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ pop(result_register());
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
}
Fix issue 541 and some refactoring of the top-level compiler. * Refactor VisitProperty to use the platform-specific methods for emitting the IC calls. * Refactor recording of source positions in the top-level compiler. * Correct the recorded source positions for assignments and property loads. * Fix bug on x64 where source positions were not recorded before a calling a call-IC. * Correct some inconsistencies between IA-32 and X64 top-level code generator. We now pass all regression tests with --always-fast-compiler. Review URL: http://codereview.chromium.org/550043 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-15 12:00:59 +00:00
// Record source code position before IC call.
SetSourcePosition(expr->position());
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
__ mov(ecx, prop->key()->AsLiteral()->handle());
StoreIC interface changed on ia32 to take receiver in edx, not on stack. Review URL: http://codereview.chromium.org/555162 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 08:35:38 +00:00
if (expr->ends_initialization_block()) {
__ mov(edx, Operand(esp, 0));
} else {
__ pop(edx);
}
Refactor the somewhat complicated code generation for assignments into a platform-independent structure and a few platform-specific helpers to do the heavy lifting. Review URL: http://codereview.chromium.org/342073 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 11:01:47 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ nop();
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
// If the assignment ends an initialization block, revert to fast case.
if (expr->ends_initialization_block()) {
__ push(eax); // Result of assignment, saved even if not needed.
__ push(Operand(esp, kPointerSize)); // Receiver is under value.
__ CallRuntime(Runtime::kToFastProperties, 1);
__ pop(eax);
StoreIC interface changed on ia32 to take receiver in edx, not on stack. Review URL: http://codereview.chromium.org/555162 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 08:35:38 +00:00
DropAndApply(1, context_, eax);
} else {
Apply(context_, eax);
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
}
Refactor the somewhat complicated code generation for assignments into a platform-independent structure and a few platform-specific helpers to do the heavy lifting. Review URL: http://codereview.chromium.org/342073 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 11:01:47 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EmitKeyedPropertyAssignment(Assignment* expr) {
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
// Assignment to a property, using a keyed store IC.
// If the assignment starts a block of assignments to the same object,
// change to slow case to avoid the quadratic behavior of repeatedly
// adding fast properties.
if (expr->starts_initialization_block()) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ push(result_register());
// Receiver is now under the key and value.
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
__ push(Operand(esp, 2 * kPointerSize));
__ CallRuntime(Runtime::kToSlowProperties, 1);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ pop(result_register());
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
}
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
__ pop(ecx);
if (expr->ends_initialization_block()) {
__ mov(edx, Operand(esp, 0)); // Leave receiver on the stack for later.
} else {
__ pop(edx);
}
Fix issue 541 and some refactoring of the top-level compiler. * Refactor VisitProperty to use the platform-specific methods for emitting the IC calls. * Refactor recording of source positions in the top-level compiler. * Correct the recorded source positions for assignments and property loads. * Fix bug on x64 where source positions were not recorded before a calling a call-IC. * Correct some inconsistencies between IA-32 and X64 top-level code generator. We now pass all regression tests with --always-fast-compiler. Review URL: http://codereview.chromium.org/550043 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-15 12:00:59 +00:00
// Record source code position before IC call.
SetSourcePosition(expr->position());
Refactor the somewhat complicated code generation for assignments into a platform-independent structure and a few platform-specific helpers to do the heavy lifting. Review URL: http://codereview.chromium.org/342073 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 11:01:47 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
// This nop signals to the IC that there is no inlined code at the call
// site for it to patch.
__ nop();
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
// If the assignment ends an initialization block, revert to fast case.
if (expr->ends_initialization_block()) {
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
__ pop(edx);
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
__ push(eax); // Result of assignment, saved even if not needed.
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
__ push(edx);
Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Review URL: http://codereview.chromium.org/348038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 13:30:24 +00:00
__ CallRuntime(Runtime::kToFastProperties, 1);
__ pop(eax);
}
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
Apply(context_, eax);
Refactor the somewhat complicated code generation for assignments into a platform-independent structure and a few platform-specific helpers to do the heavy lifting. Review URL: http://codereview.chromium.org/342073 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 11:01:47 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitProperty(Property* expr) {
Support for property access (named, keyed) in the fast compiler. The generated code is similar to the existing code, but we never inline any IC code in the fast compiler. Review URL: http://codereview.chromium.org/337045 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 16:11:12 +00:00
Comment cmnt(masm_, "[ Property");
Expression* key = expr->key();
Some cleanup of the toplevel code generator: * Rename the operation of filling a context with a value. Formerly it was 'Move', now it's 'Apply' so as to avoid confusion with various other Moves (eg, in the toplevel codegen, in the macro assemblers). * Use the abstraction Drop rather than math on the stack pointer. * Add a predicate on AST expression nodes to abstract a repeated test whether we should us a regular (named) IC or a keyed IC. Review URL: http://codereview.chromium.org/546006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-12 08:48:26 +00:00
if (key->IsPropertyName()) {
Change LoadIC interface on ia32 to take arguments in registers. Review URL: http://codereview.chromium.org/573009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-12 10:32:24 +00:00
VisitForValue(expr->obj(), kAccumulator);
Fix issue 541 and some refactoring of the top-level compiler. * Refactor VisitProperty to use the platform-specific methods for emitting the IC calls. * Refactor recording of source positions in the top-level compiler. * Correct the recorded source positions for assignments and property loads. * Fix bug on x64 where source positions were not recorded before a calling a call-IC. * Correct some inconsistencies between IA-32 and X64 top-level code generator. We now pass all regression tests with --always-fast-compiler. Review URL: http://codereview.chromium.org/550043 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-15 12:00:59 +00:00
EmitNamedPropertyLoad(expr);
Change LoadIC interface on ia32 to take arguments in registers. Review URL: http://codereview.chromium.org/573009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-12 10:32:24 +00:00
Apply(context_, eax);
Support for property access (named, keyed) in the fast compiler. The generated code is similar to the existing code, but we never inline any IC code in the fast compiler. Review URL: http://codereview.chromium.org/337045 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 16:11:12 +00:00
} else {
Change LoadIC interface on ia32 to take arguments in registers. Review URL: http://codereview.chromium.org/573009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-12 10:32:24 +00:00
VisitForValue(expr->obj(), kStack);
Change KeyedLoadIC interface on ia32 to take receiver and name in registers. Review URL: http://codereview.chromium.org/601080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 10:09:54 +00:00
VisitForValue(expr->key(), kAccumulator);
__ pop(edx);
Fix issue 541 and some refactoring of the top-level compiler. * Refactor VisitProperty to use the platform-specific methods for emitting the IC calls. * Refactor recording of source positions in the top-level compiler. * Correct the recorded source positions for assignments and property loads. * Fix bug on x64 where source positions were not recorded before a calling a call-IC. * Correct some inconsistencies between IA-32 and X64 top-level code generator. We now pass all regression tests with --always-fast-compiler. Review URL: http://codereview.chromium.org/550043 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-15 12:00:59 +00:00
EmitKeyedPropertyLoad(expr);
Change KeyedLoadIC interface on ia32 to take receiver and name in registers. Review URL: http://codereview.chromium.org/601080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 10:09:54 +00:00
Apply(context_, eax);
Support for property access (named, keyed) in the fast compiler. The generated code is similar to the existing code, but we never inline any IC code in the fast compiler. Review URL: http://codereview.chromium.org/337045 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 16:11:12 +00:00
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EmitCallWithIC(Call* expr,
Streamline the calling convention of the call ICs by passing the property name in a register rather than on the stack below the receiver and arguments. Implemented only for IA32, passing the name in the ecx register to match the calling convention of the load ICs. Review URL: http://codereview.chromium.org/502028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-17 10:23:20 +00:00
Handle<Object> name,
RelocInfo::Mode mode) {
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
// Code common for calls using the IC.
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
ZoneList<Expression*>* args = expr->arguments();
int arg_count = args->length();
for (int i = 0; i < arg_count; i++) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(args->at(i), kStack);
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
}
Streamline the calling convention of the call ICs by passing the property name in a register rather than on the stack below the receiver and arguments. Implemented only for IA32, passing the name in the ecx register to match the calling convention of the load ICs. Review URL: http://codereview.chromium.org/502028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-17 10:23:20 +00:00
__ Set(ecx, Immediate(name));
// Record source position of the IC call.
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
SetSourcePosition(expr->position());
Streamline the calling convention of the call ICs by passing the property name in a register rather than on the stack below the receiver and arguments. Implemented only for IA32, passing the name in the ecx register to match the calling convention of the load ICs. Review URL: http://codereview.chromium.org/502028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-17 10:23:20 +00:00
InLoopFlag in_loop = (loop_depth() > 0) ? IN_LOOP : NOT_IN_LOOP;
Handle<Code> ic = CodeGenerator::ComputeCallInitialize(arg_count, in_loop);
__ call(ic, mode);
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
// Restore context register.
__ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
Apply(context_, eax);
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
}
Extend CallIC to support non-constant names. This speeds up constructs like this: var zz='replace'; '123'[zz]('3','4'); Review URL: http://codereview.chromium.org/2280007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-06-07 08:27:32 +00:00
void FullCodeGenerator::EmitKeyedCallWithIC(Call* expr,
Expression* key,
RelocInfo::Mode mode) {
// Code common for calls using the IC.
ZoneList<Expression*>* args = expr->arguments();
int arg_count = args->length();
for (int i = 0; i < arg_count; i++) {
VisitForValue(args->at(i), kStack);
}
VisitForValue(key, kAccumulator);
__ mov(ecx, eax);
// Record source position of the IC call.
SetSourcePosition(expr->position());
InLoopFlag in_loop = (loop_depth() > 0) ? IN_LOOP : NOT_IN_LOOP;
Handle<Code> ic = CodeGenerator::ComputeKeyedCallInitialize(
arg_count, in_loop);
__ call(ic, mode);
// Restore context register.
__ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
Apply(context_, eax);
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EmitCallWithStub(Call* expr) {
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
// Code common for calls using the call stub.
ZoneList<Expression*>* args = expr->arguments();
int arg_count = args->length();
for (int i = 0; i < arg_count; i++) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(args->at(i), kStack);
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
}
// Record source position for debugger.
SetSourcePosition(expr->position());
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
InLoopFlag in_loop = (loop_depth() > 0) ? IN_LOOP : NOT_IN_LOOP;
CallFunctionStub stub(arg_count, in_loop, RECEIVER_MIGHT_BE_VALUE);
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
__ CallStub(&stub);
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
// Restore context register.
__ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
DropAndApply(1, context_, eax);
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
}
Add VisitCallNew to fast compiler. Review URL: http://codereview.chromium.org/334041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 14:52:55 +00:00
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitCall(Call* expr) {
Fix a latent bug in the top-level compilation of function calls. Calls to a non-global variable would go through the "call to a global" path, rather than the "call to an arbitrary (other) expression" path. Review URL: http://codereview.chromium.org/355009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 12:47:19 +00:00
Comment cmnt(masm_, "[ Call");
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
Expression* fun = expr->expression();
Support for function calls on an arbitrary expression that returns a function in the top-level compiler. e.g. function f() { return (function() { return true; }) } f()() Review URL: http://codereview.chromium.org/346029 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 12:04:35 +00:00
Variable* var = fun->AsVariableProxy()->AsVariable();
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
Fix a latent bug in the top-level compilation of function calls. Calls to a non-global variable would go through the "call to a global" path, rather than the "call to an arbitrary (other) expression" path. Review URL: http://codereview.chromium.org/355009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 12:47:19 +00:00
if (var != NULL && var->is_possibly_eval()) {
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// In a call to eval, we first call %ResolvePossiblyDirectEval to
// resolve the function we need to call and the receiver of the
// call. Then we call the resolved function using the given
// arguments.
VisitForValue(fun, kStack);
__ push(Immediate(Factory::undefined_value())); // Reserved receiver slot.
// Push the arguments.
ZoneList<Expression*>* args = expr->arguments();
int arg_count = args->length();
for (int i = 0; i < arg_count; i++) {
VisitForValue(args->at(i), kStack);
}
// Push copy of the function - found below the arguments.
__ push(Operand(esp, (arg_count + 1) * kPointerSize));
// Push copy of the first argument or undefined if it doesn't exist.
if (arg_count > 0) {
__ push(Operand(esp, arg_count * kPointerSize));
} else {
__ push(Immediate(Factory::undefined_value()));
}
// Push the receiver of the enclosing function and do runtime call.
__ push(Operand(ebp, (2 + scope()->num_parameters()) * kPointerSize));
__ CallRuntime(Runtime::kResolvePossiblyDirectEval, 3);
// The runtime call returns a pair of values in eax (function) and
// edx (receiver). Touch up the stack with the right values.
__ mov(Operand(esp, (arg_count + 0) * kPointerSize), edx);
__ mov(Operand(esp, (arg_count + 1) * kPointerSize), eax);
// Record source position for debugger.
SetSourcePosition(expr->position());
InLoopFlag in_loop = (loop_depth() > 0) ? IN_LOOP : NOT_IN_LOOP;
CallFunctionStub stub(arg_count, in_loop, RECEIVER_MIGHT_BE_VALUE);
__ CallStub(&stub);
// Restore context register.
__ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
DropAndApply(1, context_, eax);
Fix a latent bug in the top-level compilation of function calls. Calls to a non-global variable would go through the "call to a global" path, rather than the "call to an arbitrary (other) expression" path. Review URL: http://codereview.chromium.org/355009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 12:47:19 +00:00
} else if (var != NULL && !var->is_this() && var->is_global()) {
Streamline the calling convention of the call ICs by passing the property name in a register rather than on the stack below the receiver and arguments. Implemented only for IA32, passing the name in the ecx register to match the calling convention of the load ICs. Review URL: http://codereview.chromium.org/502028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-17 10:23:20 +00:00
// Push global object as receiver for the call IC.
Fix a latent bug in the top-level compilation of function calls. Calls to a non-global variable would go through the "call to a global" path, rather than the "call to an arbitrary (other) expression" path. Review URL: http://codereview.chromium.org/355009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 12:47:19 +00:00
__ push(CodeGenerator::GlobalObject());
Streamline the calling convention of the call ICs by passing the property name in a register rather than on the stack below the receiver and arguments. Implemented only for IA32, passing the name in the ecx register to match the calling convention of the load ICs. Review URL: http://codereview.chromium.org/502028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-17 10:23:20 +00:00
EmitCallWithIC(expr, var->name(), RelocInfo::CODE_TARGET_CONTEXT);
Fix a latent bug in the top-level compilation of function calls. Calls to a non-global variable would go through the "call to a global" path, rather than the "call to an arbitrary (other) expression" path. Review URL: http://codereview.chromium.org/355009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 12:47:19 +00:00
} else if (var != NULL && var->slot() != NULL &&
var->slot()->type() == Slot::LOOKUP) {
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Call to a lookup slot (dynamically introduced variable). Call the
// runtime to find the function to call (returned in eax) and the object
// holding it (returned in edx).
__ push(context_register());
__ push(Immediate(var->name()));
__ CallRuntime(Runtime::kLoadContextSlot, 2);
__ push(eax); // Function.
__ push(edx); // Receiver.
EmitCallWithStub(expr);
Support for function calls on an arbitrary expression that returns a function in the top-level compiler. e.g. function f() { return (function() { return true; }) } f()() Review URL: http://codereview.chromium.org/346029 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 12:04:35 +00:00
} else if (fun->AsProperty() != NULL) {
Fix a latent bug in the top-level compilation of function calls. Calls to a non-global variable would go through the "call to a global" path, rather than the "call to an arbitrary (other) expression" path. Review URL: http://codereview.chromium.org/355009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 12:47:19 +00:00
// Call to an object property.
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
Property* prop = fun->AsProperty();
Literal* key = prop->key()->AsLiteral();
if (key != NULL && key->handle()->IsSymbol()) {
Fix a latent bug in the top-level compilation of function calls. Calls to a non-global variable would go through the "call to a global" path, rather than the "call to an arbitrary (other) expression" path. Review URL: http://codereview.chromium.org/355009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 12:47:19 +00:00
// Call to a named property, use call IC.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(prop->obj(), kStack);
Streamline the calling convention of the call ICs by passing the property name in a register rather than on the stack below the receiver and arguments. Implemented only for IA32, passing the name in the ecx register to match the calling convention of the load ICs. Review URL: http://codereview.chromium.org/502028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-17 10:23:20 +00:00
EmitCallWithIC(expr, key->handle(), RelocInfo::CODE_TARGET);
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
} else {
Extend CallIC to support non-constant names. This speeds up constructs like this: var zz='replace'; '123'[zz]('3','4'); Review URL: http://codereview.chromium.org/2280007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-06-07 08:27:32 +00:00
// Call to a keyed property.
// For a synthetic property use keyed load IC followed by function call,
// for a regular property use keyed CallIC.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(prop->obj(), kStack);
Change KeyedLoadIC interface on ia32 to take receiver and name in registers. Review URL: http://codereview.chromium.org/601080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 10:09:54 +00:00
if (prop->is_synthetic()) {
Extend CallIC to support non-constant names. This speeds up constructs like this: var zz='replace'; '123'[zz]('3','4'); Review URL: http://codereview.chromium.org/2280007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-06-07 08:27:32 +00:00
VisitForValue(prop->key(), kAccumulator);
// Record source code position for IC call.
SetSourcePosition(prop->position());
Change KeyedLoadIC interface on ia32 to take receiver and name in registers. Review URL: http://codereview.chromium.org/601080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 10:09:54 +00:00
__ pop(edx); // We do not need to keep the receiver.
Extend CallIC to support non-constant names. This speeds up constructs like this: var zz='replace'; '123'[zz]('3','4'); Review URL: http://codereview.chromium.org/2280007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-06-07 08:27:32 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::KeyedLoadIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
// By emitting a nop we make sure that we do not have a "test eax,..."
// instruction after the call as it is treated specially
// by the LoadIC code.
__ nop();
Change KeyedLoadIC interface on ia32 to take receiver and name in registers. Review URL: http://codereview.chromium.org/601080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 10:09:54 +00:00
// Push result (function).
__ push(eax);
// Push Global receiver.
Fix bug in top-level code generator with global receiver. We did not correcty pass the global receiver object in some cases. This change fixes this bug on all three platforms. Review URL: http://codereview.chromium.org/542053 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3596 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-13 12:13:37 +00:00
__ mov(ecx, CodeGenerator::GlobalObject());
__ push(FieldOperand(ecx, GlobalObject::kGlobalReceiverOffset));
Extend CallIC to support non-constant names. This speeds up constructs like this: var zz='replace'; '123'[zz]('3','4'); Review URL: http://codereview.chromium.org/2280007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-06-07 08:27:32 +00:00
EmitCallWithStub(expr);
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
} else {
Extend CallIC to support non-constant names. This speeds up constructs like this: var zz='replace'; '123'[zz]('3','4'); Review URL: http://codereview.chromium.org/2280007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-06-07 08:27:32 +00:00
EmitKeyedCallWithIC(expr, prop->key(), RelocInfo::CODE_TARGET);
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
}
}
Support for function calls on an arbitrary expression that returns a function in the top-level compiler. e.g. function f() { return (function() { return true; }) } f()() Review URL: http://codereview.chromium.org/346029 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 12:04:35 +00:00
} else {
Begin using the top-level code generator for code that is inside directly-applied function literals that are themselves compiled with the top-level code generator. The choice is guarded by a test that the function is anonymous (thus not expected to be recursive) and not in a loop. A compilation hint is set in the shared function info and used to make the choice. Review URL: http://codereview.chromium.org/341081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 14:48:59 +00:00
// Call to some other expression. If the expression is an anonymous
// function literal not called in a loop, mark it as one that should
Refactor the selection of code generator and add the possibility of a simpler backend for non-toplevel code. Review URL: http://codereview.chromium.org/549158 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3721 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-27 15:23:48 +00:00
// also use the full code generator.
Begin using the top-level code generator for code that is inside directly-applied function literals that are themselves compiled with the top-level code generator. The choice is guarded by a test that the function is anonymous (thus not expected to be recursive) and not in a loop. A compilation hint is set in the shared function info and used to make the choice. Review URL: http://codereview.chromium.org/341081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 14:48:59 +00:00
FunctionLiteral* lit = fun->AsFunctionLiteral();
if (lit != NULL &&
lit->name()->Equals(Heap::empty_string()) &&
loop_depth() == 0) {
Refactor the selection of code generator and add the possibility of a simpler backend for non-toplevel code. Review URL: http://codereview.chromium.org/549158 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3721 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-27 15:23:48 +00:00
lit->set_try_full_codegen(true);
Begin using the top-level code generator for code that is inside directly-applied function literals that are themselves compiled with the top-level code generator. The choice is guarded by a test that the function is anonymous (thus not expected to be recursive) and not in a loop. A compilation hint is set in the shared function info and used to make the choice. Review URL: http://codereview.chromium.org/341081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 14:48:59 +00:00
}
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(fun, kStack);
Support for function calls on an arbitrary expression that returns a function in the top-level compiler. e.g. function f() { return (function() { return true; }) } f()() Review URL: http://codereview.chromium.org/346029 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 12:04:35 +00:00
// Load global receiver object.
__ mov(ebx, CodeGenerator::GlobalObject());
__ push(FieldOperand(ebx, GlobalObject::kGlobalReceiverOffset));
// Emit function call.
EmitCallWithStub(expr);
Support for calls on named and keyed properties in the fast compiler of the form: o.x() and o[expr]() other changes: - Fix missing relocation info for StoreIC on global object. - Generate only one common return sequence instead of always appending "return <undefined>" at the end of each function: The first JS return-statement will generate the common return sequence. All other return-statements will generate a unconditional branch to the common return sequence. Review URL: http://codereview.chromium.org/340037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 10:22:31 +00:00
}
}
Begin using the top-level code generator for code that is inside directly-applied function literals that are themselves compiled with the top-level code generator. The choice is guarded by a test that the function is anonymous (thus not expected to be recursive) and not in a loop. A compilation hint is set in the shared function info and used to make the choice. Review URL: http://codereview.chromium.org/341081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 14:48:59 +00:00
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitCallNew(CallNew* expr) {
Add VisitCallNew to fast compiler. Review URL: http://codereview.chromium.org/334041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 14:52:55 +00:00
Comment cmnt(masm_, "[ CallNew");
// According to ECMA-262, section 11.2.2, page 44, the function
// expression in new calls must be evaluated before the
// arguments.
// Push function on the stack.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(expr->expression(), kStack);
Add VisitCallNew to fast compiler. Review URL: http://codereview.chromium.org/334041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 14:52:55 +00:00
// Push global object (receiver).
__ push(CodeGenerator::GlobalObject());
// Push the arguments ("left-to-right") on the stack.
Move the Location class into the AST Expression class as a member. Since it is (currently) only an enum, change it to an enum (for now). Review URL: http://codereview.chromium.org/342035 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3181 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 08:36:46 +00:00
ZoneList<Expression*>* args = expr->arguments();
Add VisitCallNew to fast compiler. Review URL: http://codereview.chromium.org/334041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 14:52:55 +00:00
int arg_count = args->length();
for (int i = 0; i < arg_count; i++) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(args->at(i), kStack);
Add VisitCallNew to fast compiler. Review URL: http://codereview.chromium.org/334041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 14:52:55 +00:00
}
// Call the construct call builtin that handles allocation and
// constructor invocation.
Move the Location class into the AST Expression class as a member. Since it is (currently) only an enum, change it to an enum (for now). Review URL: http://codereview.chromium.org/342035 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3181 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 08:36:46 +00:00
SetSourcePosition(expr->position());
Add VisitCallNew to fast compiler. Review URL: http://codereview.chromium.org/334041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 14:52:55 +00:00
// Load function, arg_count into edi and eax.
__ Set(eax, Immediate(arg_count));
// Function is in esp[arg_count + 1].
__ mov(edi, Operand(esp, eax, times_pointer_size, kPointerSize));
Handle<Code> construct_builtin(Builtins::builtin(Builtins::JSConstructCall));
__ call(construct_builtin, RelocInfo::CONSTRUCT_CALL);
// Replace function on TOS with result in eax, or pop it.
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
DropAndApply(1, context_, eax);
Add VisitCallNew to fast compiler. Review URL: http://codereview.chromium.org/334041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-27 14:52:55 +00:00
}
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
void FullCodeGenerator::EmitIsSmi(ZoneList<Expression*>* args) {
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kAccumulator);
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
PrepareTest(&materialize_true, &materialize_false, &if_true, &if_false);
__ test(eax, Immediate(kSmiTagMask));
__ j(zero, if_true);
__ jmp(if_false);
Apply(context_, if_true, if_false);
}
void FullCodeGenerator::EmitIsNonNegativeSmi(ZoneList<Expression*>* args) {
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kAccumulator);
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
PrepareTest(&materialize_true, &materialize_false, &if_true, &if_false);
__ test(eax, Immediate(kSmiTagMask | 0x80000000));
__ j(zero, if_true);
__ jmp(if_false);
Apply(context_, if_true, if_false);
}
void FullCodeGenerator::EmitIsObject(ZoneList<Expression*>* args) {
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kAccumulator);
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
PrepareTest(&materialize_true, &materialize_false, &if_true, &if_false);
__ test(eax, Immediate(kSmiTagMask));
__ j(zero, if_false);
__ cmp(eax, Factory::null_value());
__ j(equal, if_true);
__ mov(ebx, FieldOperand(eax, HeapObject::kMapOffset));
// Undetectable objects behave like undefined when tested with typeof.
__ movzx_b(ecx, FieldOperand(ebx, Map::kBitFieldOffset));
__ test(ecx, Immediate(1 << Map::kIsUndetectable));
__ j(not_zero, if_false);
__ movzx_b(ecx, FieldOperand(ebx, Map::kInstanceTypeOffset));
__ cmp(ecx, FIRST_JS_OBJECT_TYPE);
Reapply r4686: Complete version of full codegen for x64. Already reviewed at: http://codereview.chromium.org/2078022/show TBR=vegorov@chromium.org Review URL: http://codereview.chromium.org/2137008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-20 14:33:02 +00:00
__ j(below, if_false);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
__ cmp(ecx, LAST_JS_OBJECT_TYPE);
Reapply r4686: Complete version of full codegen for x64. Already reviewed at: http://codereview.chromium.org/2078022/show TBR=vegorov@chromium.org Review URL: http://codereview.chromium.org/2137008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-20 14:33:02 +00:00
__ j(below_equal, if_true);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
__ jmp(if_false);
Apply(context_, if_true, if_false);
}
void FullCodeGenerator::EmitIsUndetectableObject(ZoneList<Expression*>* args) {
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kAccumulator);
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
PrepareTest(&materialize_true, &materialize_false, &if_true, &if_false);
__ test(eax, Immediate(kSmiTagMask));
__ j(zero, if_false);
__ mov(ebx, FieldOperand(eax, HeapObject::kMapOffset));
__ movzx_b(ebx, FieldOperand(ebx, Map::kBitFieldOffset));
__ test(ebx, Immediate(1 << Map::kIsUndetectable));
__ j(not_zero, if_true);
__ jmp(if_false);
Apply(context_, if_true, if_false);
}
void FullCodeGenerator::EmitIsFunction(ZoneList<Expression*>* args) {
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kAccumulator);
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
PrepareTest(&materialize_true, &materialize_false, &if_true, &if_false);
__ test(eax, Immediate(kSmiTagMask));
__ j(zero, if_false);
__ CmpObjectType(eax, JS_FUNCTION_TYPE, ebx);
__ j(equal, if_true);
__ jmp(if_false);
Apply(context_, if_true, if_false);
}
void FullCodeGenerator::EmitIsArray(ZoneList<Expression*>* args) {
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kAccumulator);
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
PrepareTest(&materialize_true, &materialize_false, &if_true, &if_false);
__ test(eax, Immediate(kSmiTagMask));
__ j(equal, if_false);
__ CmpObjectType(eax, JS_ARRAY_TYPE, ebx);
__ j(equal, if_true);
__ jmp(if_false);
Apply(context_, if_true, if_false);
}
void FullCodeGenerator::EmitIsRegExp(ZoneList<Expression*>* args) {
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kAccumulator);
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
PrepareTest(&materialize_true, &materialize_false, &if_true, &if_false);
__ test(eax, Immediate(kSmiTagMask));
__ j(equal, if_false);
__ CmpObjectType(eax, JS_REGEXP_TYPE, ebx);
__ j(equal, if_true);
__ jmp(if_false);
Apply(context_, if_true, if_false);
}
void FullCodeGenerator::EmitIsConstructCall(ZoneList<Expression*>* args) {
ASSERT(args->length() == 0);
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
PrepareTest(&materialize_true, &materialize_false, &if_true, &if_false);
// Get the frame pointer for the calling frame.
__ mov(eax, Operand(ebp, StandardFrameConstants::kCallerFPOffset));
// Skip the arguments adaptor frame if it exists.
Label check_frame_marker;
__ cmp(Operand(eax, StandardFrameConstants::kContextOffset),
Immediate(Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR)));
__ j(not_equal, &check_frame_marker);
__ mov(eax, Operand(eax, StandardFrameConstants::kCallerFPOffset));
// Check the marker in the calling frame.
__ bind(&check_frame_marker);
__ cmp(Operand(eax, StandardFrameConstants::kMarkerOffset),
Immediate(Smi::FromInt(StackFrame::CONSTRUCT)));
__ j(equal, if_true);
__ jmp(if_false);
Apply(context_, if_true, if_false);
}
void FullCodeGenerator::EmitObjectEquals(ZoneList<Expression*>* args) {
ASSERT(args->length() == 2);
// Load the two objects into registers and perform the comparison.
VisitForValue(args->at(0), kStack);
VisitForValue(args->at(1), kAccumulator);
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
PrepareTest(&materialize_true, &materialize_false, &if_true, &if_false);
__ pop(ebx);
__ cmp(eax, Operand(ebx));
__ j(equal, if_true);
__ jmp(if_false);
Apply(context_, if_true, if_false);
}
void FullCodeGenerator::EmitArguments(ZoneList<Expression*>* args) {
ASSERT(args->length() == 1);
// ArgumentsAccessStub expects the key in edx and the formal
// parameter count in eax.
VisitForValue(args->at(0), kAccumulator);
__ mov(edx, eax);
__ mov(eax, Immediate(Smi::FromInt(scope()->num_parameters())));
ArgumentsAccessStub stub(ArgumentsAccessStub::READ_ELEMENT);
__ CallStub(&stub);
Apply(context_, eax);
}
void FullCodeGenerator::EmitArgumentsLength(ZoneList<Expression*>* args) {
ASSERT(args->length() == 0);
Label exit;
// Get the number of formal parameters.
__ Set(eax, Immediate(Smi::FromInt(scope()->num_parameters())));
// Check if the calling frame is an arguments adaptor frame.
__ mov(ebx, Operand(ebp, StandardFrameConstants::kCallerFPOffset));
__ cmp(Operand(ebx, StandardFrameConstants::kContextOffset),
Immediate(Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR)));
__ j(not_equal, &exit);
// Arguments adaptor case: Read the arguments length from the
// adaptor frame.
__ mov(eax, Operand(ebx, ArgumentsAdaptorFrameConstants::kLengthOffset));
__ bind(&exit);
if (FLAG_debug_code) __ AbortIfNotSmi(eax);
Apply(context_, eax);
}
void FullCodeGenerator::EmitClassOf(ZoneList<Expression*>* args) {
ASSERT(args->length() == 1);
Label done, null, function, non_function_constructor;
VisitForValue(args->at(0), kAccumulator);
// If the object is a smi, we return null.
__ test(eax, Immediate(kSmiTagMask));
__ j(zero, &null);
// Check that the object is a JS object but take special care of JS
// functions to make sure they have 'Function' as their class.
ARM: Update the full compiler to handle all code The full compiler is now complete on ARM as well. The syntax checker is still used to determine whether to use it for top level code or not during normal execution. When debugging is enabled all code will be compiled with the full compiler. This change removes the temporary flag --force-full-compiler and now the flag --always-full-compiler enables the full compiler for all code on all platforms. This also fixes building on Intel platform without debugger support (ENABLE_DEBUGGER_SUPPORT not defined) and adds full check for the full compiler for lazily compiled code. Review URL: http://codereview.chromium.org/2163006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-25 14:08:17 +00:00
__ CmpObjectType(eax, FIRST_JS_OBJECT_TYPE, eax); // Map is now in eax.
Reapply r4686: Complete version of full codegen for x64. Already reviewed at: http://codereview.chromium.org/2078022/show TBR=vegorov@chromium.org Review URL: http://codereview.chromium.org/2137008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-20 14:33:02 +00:00
__ j(below, &null);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// As long as JS_FUNCTION_TYPE is the last instance type and it is
// right after LAST_JS_OBJECT_TYPE, we can avoid checking for
// LAST_JS_OBJECT_TYPE.
ASSERT(LAST_TYPE == JS_FUNCTION_TYPE);
ASSERT(JS_FUNCTION_TYPE == LAST_JS_OBJECT_TYPE + 1);
__ cmp(ebx, JS_FUNCTION_TYPE);
__ j(equal, &function);
// Check if the constructor in the map is a function.
__ mov(eax, FieldOperand(eax, Map::kConstructorOffset));
__ CmpObjectType(eax, JS_FUNCTION_TYPE, ebx);
__ j(not_equal, &non_function_constructor);
// eax now contains the constructor function. Grab the
// instance class name from there.
__ mov(eax, FieldOperand(eax, JSFunction::kSharedFunctionInfoOffset));
__ mov(eax, FieldOperand(eax, SharedFunctionInfo::kInstanceClassNameOffset));
__ jmp(&done);
// Functions have class 'Function'.
__ bind(&function);
__ mov(eax, Factory::function_class_symbol());
__ jmp(&done);
// Objects with a non-function constructor have class 'Object'.
__ bind(&non_function_constructor);
__ mov(eax, Factory::Object_symbol());
__ jmp(&done);
// Non-JS objects have class null.
__ bind(&null);
__ mov(eax, Factory::null_value());
// All done.
__ bind(&done);
Apply(context_, eax);
}
void FullCodeGenerator::EmitLog(ZoneList<Expression*>* args) {
// Conditionally generate a log call.
// Args:
// 0 (literal string): The type of logging (corresponds to the flags).
// This is used to determine whether or not to generate the log call.
// 1 (string): Format string. Access the string at argument index 2
// with '%2s' (see Logger::LogRuntime for all the formats).
// 2 (array): Arguments to the format string.
ASSERT_EQ(args->length(), 3);
#ifdef ENABLE_LOGGING_AND_PROFILING
if (CodeGenerator::ShouldGenerateLog(args->at(0))) {
VisitForValue(args->at(1), kStack);
VisitForValue(args->at(2), kStack);
__ CallRuntime(Runtime::kLog, 2);
}
#endif
// Finally, we're expected to leave a value on the top of the stack.
__ mov(eax, Factory::undefined_value());
Apply(context_, eax);
}
void FullCodeGenerator::EmitRandomHeapNumber(ZoneList<Expression*>* args) {
ASSERT(args->length() == 0);
Label slow_allocate_heapnumber;
Label heapnumber_allocated;
__ AllocateHeapNumber(edi, ebx, ecx, &slow_allocate_heapnumber);
__ jmp(&heapnumber_allocated);
__ bind(&slow_allocate_heapnumber);
// To allocate a heap number, and ensure that it is not a smi, we
// call the runtime function FUnaryMinus on 0, returning the double
// -0.0. A new, distinct heap number is returned each time.
__ push(Immediate(Smi::FromInt(0)));
__ CallRuntime(Runtime::kNumberUnaryMinus, 1);
__ mov(edi, eax);
__ bind(&heapnumber_allocated);
__ PrepareCallCFunction(0, ebx);
__ CallCFunction(ExternalReference::random_uint32_function(), 0);
// Convert 32 random bits in eax to 0.(32 random bits) in a double
// by computing:
// ( 1.(20 0s)(32 random bits) x 2^20 ) - (1.0 x 2^20)).
// This is implemented on both SSE2 and FPU.
if (CpuFeatures::IsSupported(SSE2)) {
CpuFeatures::Scope fscope(SSE2);
__ mov(ebx, Immediate(0x49800000)); // 1.0 x 2^20 as single.
__ movd(xmm1, Operand(ebx));
__ movd(xmm0, Operand(eax));
__ cvtss2sd(xmm1, xmm1);
__ pxor(xmm0, xmm1);
__ subsd(xmm0, xmm1);
__ movdbl(FieldOperand(edi, HeapNumber::kValueOffset), xmm0);
} else {
// 0x4130000000000000 is 1.0 x 2^20 as a double.
__ mov(FieldOperand(edi, HeapNumber::kExponentOffset),
Immediate(0x41300000));
__ mov(FieldOperand(edi, HeapNumber::kMantissaOffset), eax);
__ fld_d(FieldOperand(edi, HeapNumber::kValueOffset));
__ mov(FieldOperand(edi, HeapNumber::kMantissaOffset), Immediate(0));
__ fld_d(FieldOperand(edi, HeapNumber::kValueOffset));
__ fsubp(1);
__ fstp_d(FieldOperand(edi, HeapNumber::kValueOffset));
}
__ mov(eax, edi);
Apply(context_, eax);
}
void FullCodeGenerator::EmitSubString(ZoneList<Expression*>* args) {
// Load the arguments on the stack and call the stub.
SubStringStub stub;
ASSERT(args->length() == 3);
VisitForValue(args->at(0), kStack);
VisitForValue(args->at(1), kStack);
VisitForValue(args->at(2), kStack);
__ CallStub(&stub);
Apply(context_, eax);
}
void FullCodeGenerator::EmitRegExpExec(ZoneList<Expression*>* args) {
// Load the arguments on the stack and call the stub.
RegExpExecStub stub;
ASSERT(args->length() == 4);
VisitForValue(args->at(0), kStack);
VisitForValue(args->at(1), kStack);
VisitForValue(args->at(2), kStack);
VisitForValue(args->at(3), kStack);
__ CallStub(&stub);
Apply(context_, eax);
}
void FullCodeGenerator::EmitValueOf(ZoneList<Expression*>* args) {
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kAccumulator); // Load the object.
Label done;
// If the object is a smi return the object.
__ test(eax, Immediate(kSmiTagMask));
__ j(zero, &done);
// If the object is not a value type, return the object.
__ CmpObjectType(eax, JS_VALUE_TYPE, ebx);
__ j(not_equal, &done);
__ mov(eax, FieldOperand(eax, JSValue::kValueOffset));
__ bind(&done);
Apply(context_, eax);
}
void FullCodeGenerator::EmitMathPow(ZoneList<Expression*>* args) {
// Load the arguments on the stack and call the runtime function.
ASSERT(args->length() == 2);
VisitForValue(args->at(0), kStack);
VisitForValue(args->at(1), kStack);
__ CallRuntime(Runtime::kMath_pow, 2);
Apply(context_, eax);
}
void FullCodeGenerator::EmitSetValueOf(ZoneList<Expression*>* args) {
ASSERT(args->length() == 2);
VisitForValue(args->at(0), kStack); // Load the object.
VisitForValue(args->at(1), kAccumulator); // Load the value.
__ pop(ebx); // eax = value. ebx = object.
Label done;
// If the object is a smi, return the value.
__ test(ebx, Immediate(kSmiTagMask));
__ j(zero, &done);
// If the object is not a value type, return the value.
__ CmpObjectType(ebx, JS_VALUE_TYPE, ecx);
__ j(not_equal, &done);
// Store the value.
__ mov(FieldOperand(ebx, JSValue::kValueOffset), eax);
// Update the write barrier. Save the value as it will be
// overwritten by the write barrier code and is needed afterward.
__ mov(edx, eax);
__ RecordWrite(ebx, JSValue::kValueOffset, edx, ecx);
__ bind(&done);
Apply(context_, eax);
}
void FullCodeGenerator::EmitNumberToString(ZoneList<Expression*>* args) {
ASSERT_EQ(args->length(), 1);
// Load the argument on the stack and call the stub.
VisitForValue(args->at(0), kStack);
NumberToStringStub stub;
__ CallStub(&stub);
Apply(context_, eax);
}
Custom call IC-s for String.prototype.{charAt,charCodeAt}. These string methods can be composed from two basic blocks: charCodeAt and fromCharCode, both of which have fast cases for certain types of inputs. In this patch these two blocks are refactored to allow generating the fast cases without having to jump around the slow cases. In the slow cases since they can now be invoked both from inline runtime functions and from IC stubs we either have to save/restore state of the current frame or enter/leave a new internal frame. This is handled by new RuntimeCallHelper interface. Its implementation for virtual frame is based on FrameRegisterState class extracted from DeferredCode class. Review URL: http://codereview.chromium.org/2087009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-26 14:23:19 +00:00
void FullCodeGenerator::EmitStringCharFromCode(ZoneList<Expression*>* args) {
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kAccumulator);
Custom call IC-s for String.prototype.{charAt,charCodeAt}. These string methods can be composed from two basic blocks: charCodeAt and fromCharCode, both of which have fast cases for certain types of inputs. In this patch these two blocks are refactored to allow generating the fast cases without having to jump around the slow cases. In the slow cases since they can now be invoked both from inline runtime functions and from IC stubs we either have to save/restore state of the current frame or enter/leave a new internal frame. This is handled by new RuntimeCallHelper interface. Its implementation for virtual frame is based on FrameRegisterState class extracted from DeferredCode class. Review URL: http://codereview.chromium.org/2087009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-26 14:23:19 +00:00
Label done;
StringCharFromCodeGenerator generator(eax, ebx);
generator.GenerateFast(masm_);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
__ jmp(&done);
Custom call IC-s for String.prototype.{charAt,charCodeAt}. These string methods can be composed from two basic blocks: charCodeAt and fromCharCode, both of which have fast cases for certain types of inputs. In this patch these two blocks are refactored to allow generating the fast cases without having to jump around the slow cases. In the slow cases since they can now be invoked both from inline runtime functions and from IC stubs we either have to save/restore state of the current frame or enter/leave a new internal frame. This is handled by new RuntimeCallHelper interface. Its implementation for virtual frame is based on FrameRegisterState class extracted from DeferredCode class. Review URL: http://codereview.chromium.org/2087009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-26 14:23:19 +00:00
NopRuntimeCallHelper call_helper;
generator.GenerateSlow(masm_, call_helper);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
__ bind(&done);
Custom call IC-s for String.prototype.{charAt,charCodeAt}. These string methods can be composed from two basic blocks: charCodeAt and fromCharCode, both of which have fast cases for certain types of inputs. In this patch these two blocks are refactored to allow generating the fast cases without having to jump around the slow cases. In the slow cases since they can now be invoked both from inline runtime functions and from IC stubs we either have to save/restore state of the current frame or enter/leave a new internal frame. This is handled by new RuntimeCallHelper interface. Its implementation for virtual frame is based on FrameRegisterState class extracted from DeferredCode class. Review URL: http://codereview.chromium.org/2087009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-26 14:23:19 +00:00
Apply(context_, ebx);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
}
Custom call IC-s for String.prototype.{charAt,charCodeAt}. These string methods can be composed from two basic blocks: charCodeAt and fromCharCode, both of which have fast cases for certain types of inputs. In this patch these two blocks are refactored to allow generating the fast cases without having to jump around the slow cases. In the slow cases since they can now be invoked both from inline runtime functions and from IC stubs we either have to save/restore state of the current frame or enter/leave a new internal frame. This is handled by new RuntimeCallHelper interface. Its implementation for virtual frame is based on FrameRegisterState class extracted from DeferredCode class. Review URL: http://codereview.chromium.org/2087009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-26 14:23:19 +00:00
void FullCodeGenerator::EmitStringCharCodeAt(ZoneList<Expression*>* args) {
ASSERT(args->length() == 2);
VisitForValue(args->at(0), kStack);
VisitForValue(args->at(1), kAccumulator);
Register object = ebx;
Register index = eax;
Register scratch = ecx;
Register result = edx;
__ pop(object);
Label need_conversion;
Label index_out_of_range;
Label done;
StringCharCodeAtGenerator generator(object,
index,
scratch,
result,
&need_conversion,
&need_conversion,
&index_out_of_range,
STRING_INDEX_IS_NUMBER);
generator.GenerateFast(masm_);
__ jmp(&done);
__ bind(&index_out_of_range);
// When the index is out of range, the spec requires us to return
// NaN.
__ Set(result, Immediate(Factory::nan_value()));
__ jmp(&done);
__ bind(&need_conversion);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Move the undefined value into the result register, which will
Custom call IC-s for String.prototype.{charAt,charCodeAt}. These string methods can be composed from two basic blocks: charCodeAt and fromCharCode, both of which have fast cases for certain types of inputs. In this patch these two blocks are refactored to allow generating the fast cases without having to jump around the slow cases. In the slow cases since they can now be invoked both from inline runtime functions and from IC stubs we either have to save/restore state of the current frame or enter/leave a new internal frame. This is handled by new RuntimeCallHelper interface. Its implementation for virtual frame is based on FrameRegisterState class extracted from DeferredCode class. Review URL: http://codereview.chromium.org/2087009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-26 14:23:19 +00:00
// trigger conversion.
__ Set(result, Immediate(Factory::undefined_value()));
__ jmp(&done);
NopRuntimeCallHelper call_helper;
generator.GenerateSlow(masm_, call_helper);
__ bind(&done);
Apply(context_, result);
}
void FullCodeGenerator::EmitStringCharAt(ZoneList<Expression*>* args) {
ASSERT(args->length() == 2);
VisitForValue(args->at(0), kStack);
VisitForValue(args->at(1), kAccumulator);
Register object = ebx;
Register index = eax;
Register scratch1 = ecx;
Register scratch2 = edx;
Register result = eax;
__ pop(object);
Label need_conversion;
Label index_out_of_range;
Label done;
StringCharAtGenerator generator(object,
index,
scratch1,
scratch2,
result,
&need_conversion,
&need_conversion,
&index_out_of_range,
STRING_INDEX_IS_NUMBER);
generator.GenerateFast(masm_);
__ jmp(&done);
__ bind(&index_out_of_range);
// When the index is out of range, the spec requires us to return
// the empty string.
__ Set(result, Immediate(Factory::empty_string()));
__ jmp(&done);
__ bind(&need_conversion);
// Move smi zero into the result register, which will trigger
// conversion.
__ Set(result, Immediate(Smi::FromInt(0)));
__ jmp(&done);
NopRuntimeCallHelper call_helper;
generator.GenerateSlow(masm_, call_helper);
__ bind(&done);
Apply(context_, result);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
}
Custom call IC-s for String.prototype.{charAt,charCodeAt}. These string methods can be composed from two basic blocks: charCodeAt and fromCharCode, both of which have fast cases for certain types of inputs. In this patch these two blocks are refactored to allow generating the fast cases without having to jump around the slow cases. In the slow cases since they can now be invoked both from inline runtime functions and from IC stubs we either have to save/restore state of the current frame or enter/leave a new internal frame. This is handled by new RuntimeCallHelper interface. Its implementation for virtual frame is based on FrameRegisterState class extracted from DeferredCode class. Review URL: http://codereview.chromium.org/2087009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-26 14:23:19 +00:00
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
void FullCodeGenerator::EmitStringAdd(ZoneList<Expression*>* args) {
ASSERT_EQ(2, args->length());
VisitForValue(args->at(0), kStack);
VisitForValue(args->at(1), kStack);
StringAddStub stub(NO_STRING_ADD_FLAGS);
__ CallStub(&stub);
Apply(context_, eax);
}
void FullCodeGenerator::EmitStringCompare(ZoneList<Expression*>* args) {
ASSERT_EQ(2, args->length());
VisitForValue(args->at(0), kStack);
VisitForValue(args->at(1), kStack);
StringCompareStub stub;
__ CallStub(&stub);
Apply(context_, eax);
}
void FullCodeGenerator::EmitMathSin(ZoneList<Expression*>* args) {
// Load the argument on the stack and call the stub.
TranscendentalCacheStub stub(TranscendentalCache::SIN);
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kStack);
__ CallStub(&stub);
Apply(context_, eax);
}
void FullCodeGenerator::EmitMathCos(ZoneList<Expression*>* args) {
// Load the argument on the stack and call the stub.
TranscendentalCacheStub stub(TranscendentalCache::COS);
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kStack);
__ CallStub(&stub);
Apply(context_, eax);
}
void FullCodeGenerator::EmitMathSqrt(ZoneList<Expression*>* args) {
// Load the argument on the stack and call the runtime function.
ASSERT(args->length() == 1);
VisitForValue(args->at(0), kStack);
__ CallRuntime(Runtime::kMath_sqrt, 1);
Apply(context_, eax);
}
void FullCodeGenerator::EmitCallFunction(ZoneList<Expression*>* args) {
ASSERT(args->length() >= 2);
int arg_count = args->length() - 2; // For receiver and function.
VisitForValue(args->at(0), kStack); // Receiver.
for (int i = 0; i < arg_count; i++) {
VisitForValue(args->at(i + 1), kStack);
}
VisitForValue(args->at(arg_count + 1), kAccumulator); // Function.
// InvokeFunction requires function in edi. Move it in there.
if (!result_register().is(edi)) __ mov(edi, result_register());
ParameterCount count(arg_count);
__ InvokeFunction(edi, count, CALL_FUNCTION);
__ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
Apply(context_, eax);
}
void FullCodeGenerator::EmitRegExpConstructResult(ZoneList<Expression*>* args) {
ASSERT(args->length() == 3);
VisitForValue(args->at(0), kStack);
VisitForValue(args->at(1), kStack);
VisitForValue(args->at(2), kStack);
__ CallRuntime(Runtime::kRegExpConstructResult, 3);
Apply(context_, eax);
}
void FullCodeGenerator::EmitSwapElements(ZoneList<Expression*>* args) {
ASSERT(args->length() == 3);
VisitForValue(args->at(0), kStack);
VisitForValue(args->at(1), kStack);
VisitForValue(args->at(2), kStack);
__ CallRuntime(Runtime::kSwapElements, 3);
Apply(context_, eax);
}
void FullCodeGenerator::EmitGetFromCache(ZoneList<Expression*>* args) {
ASSERT_EQ(2, args->length());
ASSERT_NE(NULL, args->at(0)->AsLiteral());
int cache_id = Smi::cast(*(args->at(0)->AsLiteral()->handle()))->value();
Handle<FixedArray> jsfunction_result_caches(
Top::global_context()->jsfunction_result_caches());
if (jsfunction_result_caches->length() <= cache_id) {
__ Abort("Attempt to use undefined cache.");
__ mov(eax, Factory::undefined_value());
Apply(context_, eax);
return;
}
VisitForValue(args->at(1), kAccumulator);
Register key = eax;
Register cache = ebx;
Register tmp = ecx;
__ mov(cache, CodeGenerator::ContextOperand(esi, Context::GLOBAL_INDEX));
__ mov(cache,
FieldOperand(cache, GlobalObject::kGlobalContextOffset));
__ mov(cache,
CodeGenerator::ContextOperand(
cache, Context::JSFUNCTION_RESULT_CACHES_INDEX));
__ mov(cache,
FieldOperand(cache, FixedArray::OffsetOfElementAt(cache_id)));
Label done, not_found;
// tmp now holds finger offset as a smi.
ASSERT(kSmiTag == 0 && kSmiTagSize == 1);
__ mov(tmp, FieldOperand(cache, JSFunctionResultCache::kFingerOffset));
__ cmp(key, CodeGenerator::FixedArrayElementOperand(cache, tmp));
__ j(not_equal, &not_found);
__ mov(eax, CodeGenerator::FixedArrayElementOperand(cache, tmp, 1));
__ jmp(&done);
__ bind(&not_found);
// Call runtime to perform the lookup.
__ push(cache);
__ push(key);
__ CallRuntime(Runtime::kGetFromCache, 2);
__ bind(&done);
Apply(context_, eax);
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitCallRuntime(CallRuntime* expr) {
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
Handle<String> name = expr->name();
if (name->length() > 0 && name->Get(0) == '_') {
Comment cmnt(masm_, "[ InlineRuntimeCall");
EmitInlineRuntimeCall(expr);
return;
}
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
Comment cmnt(masm_, "[ CallRuntime");
ZoneList<Expression*>* args = expr->arguments();
Added fast compiler support for calling JS runtime functions. Also added a simple test that invokes a JS runtime function in top-level code. Review URL: http://codereview.chromium.org/437081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3371 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-27 00:28:06 +00:00
if (expr->is_jsruntime()) {
// Prepare for calling JS runtime function.
__ mov(eax, CodeGenerator::GlobalObject());
__ push(FieldOperand(eax, GlobalObject::kBuiltinsOffset));
}
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
// Push the arguments ("left-to-right").
int arg_count = args->length();
for (int i = 0; i < arg_count; i++) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(args->at(i), kStack);
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
}
Added fast compiler support for calling JS runtime functions. Also added a simple test that invokes a JS runtime function in top-level code. Review URL: http://codereview.chromium.org/437081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3371 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-27 00:28:06 +00:00
if (expr->is_jsruntime()) {
Streamline the calling convention of the call ICs by passing the property name in a register rather than on the stack below the receiver and arguments. Implemented only for IA32, passing the name in the ecx register to match the calling convention of the load ICs. Review URL: http://codereview.chromium.org/502028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-17 10:23:20 +00:00
// Call the JS runtime function via a call IC.
__ Set(ecx, Immediate(expr->name()));
InLoopFlag in_loop = (loop_depth() > 0) ? IN_LOOP : NOT_IN_LOOP;
Handle<Code> ic = CodeGenerator::ComputeCallInitialize(arg_count, in_loop);
Added fast compiler support for calling JS runtime functions. Also added a simple test that invokes a JS runtime function in top-level code. Review URL: http://codereview.chromium.org/437081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3371 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-27 00:28:06 +00:00
__ call(ic, RelocInfo::CODE_TARGET);
// Restore context register.
__ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
} else {
// Call the C runtime function.
__ CallRuntime(expr->function(), arg_count);
}
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
Apply(context_, eax);
Adding declaration of global variables and functions in new compiler. Adding calls to global functions to the new compiler. Review URL: http://codereview.chromium.org/302002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-21 09:17:39 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitUnaryOperation(UnaryOperation* expr) {
Add void operator to fast compiler. Review URL: http://codereview.chromium.org/342055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 11:32:42 +00:00
switch (expr->op()) {
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
case Token::DELETE: {
Comment cmnt(masm_, "[ UnaryOperation (DELETE)");
Property* prop = expr->expression()->AsProperty();
Variable* var = expr->expression()->AsVariableProxy()->AsVariable();
if (prop == NULL && var == NULL) {
// Result of deleting non-property, non-variable reference is true.
// The subexpression may have side effects.
VisitForEffect(expr->expression());
Apply(context_, true);
} else if (var != NULL &&
!var->is_global() &&
var->slot() != NULL &&
var->slot()->type() != Slot::LOOKUP) {
// Result of deleting non-global, non-dynamic variables is false.
// The subexpression does not have side effects.
Apply(context_, false);
} else {
// Property or variable reference. Call the delete builtin with
// object and property name as arguments.
if (prop != NULL) {
VisitForValue(prop->obj(), kStack);
VisitForValue(prop->key(), kStack);
} else if (var->is_global()) {
__ push(CodeGenerator::GlobalObject());
__ push(Immediate(var->name()));
} else {
// Non-global variable. Call the runtime to look up the context
// where the variable was introduced.
__ push(context_register());
__ push(Immediate(var->name()));
__ CallRuntime(Runtime::kLookupContext, 2);
__ push(eax);
__ push(Immediate(var->name()));
}
__ InvokeBuiltin(Builtins::DELETE, CALL_FUNCTION);
Apply(context_, eax);
}
break;
}
Implement typeof in fast compiler. Review URL: http://codereview.chromium.org/354027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 10:15:25 +00:00
case Token::VOID: {
Comment cmnt(masm_, "[ UnaryOperation (VOID)");
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
VisitForEffect(expr->expression());
switch (context_) {
Add void operator to fast compiler. Review URL: http://codereview.chromium.org/342055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 11:32:42 +00:00
case Expression::kUninitialized:
UNREACHABLE();
break;
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
case Expression::kEffect:
break;
Add void operator to fast compiler. Review URL: http://codereview.chromium.org/342055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 11:32:42 +00:00
case Expression::kValue:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
switch (location_) {
case kAccumulator:
__ mov(result_register(), Factory::undefined_value());
break;
case kStack:
__ push(Immediate(Factory::undefined_value()));
break;
}
Add void operator to fast compiler. Review URL: http://codereview.chromium.org/342055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 11:32:42 +00:00
break;
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
case Expression::kTestValue:
// Value is false so it's needed.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
switch (location_) {
case kAccumulator:
__ mov(result_register(), Factory::undefined_value());
break;
case kStack:
__ push(Immediate(Factory::undefined_value()));
break;
}
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
// Fall through.
Style cleanup of switches over Slot::Type in the nonoptimizing code generator. The Slot::Type enumeration has four values. It should never be necessary to use a default to handle the case of a value out of range of the enumeration. Doing so silences a useful warning when one of the enumeration values is actually forgotten or when a new enumeration value is added. Review URL: http://codereview.chromium.org/521019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3532 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 09:11:10 +00:00
case Expression::kTest:
Initial implementation of top-level compilation of expressions in test context. Test contexts are used for the left subexpressions of short-circuited boolean operators. The right subexpressions inherit their expression context from the binary op expression. Compilation of short-circuited operations in effect and test context is straightforward: effect(e0 || e1) = test(e0, L0, L1) L1: effect(e1) L0: test(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test(e1, L0, L1) Because the value of the first subexpression may be needed as the value of the whole expression in a value context, we introduce a hybrid value/test contest (the value is needed if true, but not if false). value(e0 || e1) = value/test(e0, L0, L1) L1: value(e1) L0: The compilation of value/test and test/value (introduced by boolean AND) is: value/test(e0 || e1, L0, L1) = value/test(e0, L0, L2) L2: value/test(e1, L0, L1) test/value(e0 || e1, L0, L1) = test(e0, L0, L2) L2: test/value(e1, L0, L1) Boolean AND is the dual. The AST nodes themselves (not their parents) are responsible for producing the proper result (effect, value, or control flow) depending on their context. Review URL: http://codereview.chromium.org/339082 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 14:06:48 +00:00
case Expression::kValueTest:
__ jmp(false_label_);
Add void operator to fast compiler. Review URL: http://codereview.chromium.org/342055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 11:32:42 +00:00
break;
}
break;
Implement typeof in fast compiler. Review URL: http://codereview.chromium.org/354027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 10:15:25 +00:00
}
Add void operator to fast compiler. Review URL: http://codereview.chromium.org/342055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 11:32:42 +00:00
Add unary not operator to fast compiler. Review URL: http://codereview.chromium.org/343057 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 10:17:12 +00:00
case Token::NOT: {
Implement typeof in fast compiler. Review URL: http://codereview.chromium.org/354027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 10:15:25 +00:00
Comment cmnt(masm_, "[ UnaryOperation (NOT)");
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
// Notice that the labels are swapped.
PrepareTest(&materialize_true, &materialize_false, &if_false, &if_true);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForControl(expr->expression(), if_true, if_false);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
Apply(context_, if_false, if_true); // Labels swapped.
Add unary not operator to fast compiler. Review URL: http://codereview.chromium.org/343057 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 10:17:12 +00:00
break;
}
Implement typeof in fast compiler. Review URL: http://codereview.chromium.org/354027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 10:15:25 +00:00
case Token::TYPEOF: {
Comment cmnt(masm_, "[ UnaryOperation (TYPEOF)");
VariableProxy* proxy = expr->expression()->AsVariableProxy();
Make "typeof this" return object in fast compiler. Review URL: http://codereview.chromium.org/366028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3227 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 12:45:53 +00:00
if (proxy != NULL &&
!proxy->var()->is_this() &&
proxy->var()->is_global()) {
Implement typeof in fast compiler. Review URL: http://codereview.chromium.org/354027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 10:15:25 +00:00
Comment cmnt(masm_, "Global variable");
Change LoadIC interface on ia32 to take arguments in registers. Review URL: http://codereview.chromium.org/573009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-12 10:32:24 +00:00
__ mov(eax, CodeGenerator::GlobalObject());
Implement typeof in fast compiler. Review URL: http://codereview.chromium.org/354027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 10:15:25 +00:00
__ mov(ecx, Immediate(proxy->name()));
Handle<Code> ic(Builtins::builtin(Builtins::LoadIC_Initialize));
// Use a regular load, not a contextual load, to avoid a reference
// error.
__ call(ic, RelocInfo::CODE_TARGET);
Change LoadIC interface on ia32 to take arguments in registers. Review URL: http://codereview.chromium.org/573009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-12 10:32:24 +00:00
__ push(eax);
Implement typeof in fast compiler. Review URL: http://codereview.chromium.org/354027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 10:15:25 +00:00
} else if (proxy != NULL &&
proxy->var()->slot() != NULL &&
proxy->var()->slot()->type() == Slot::LOOKUP) {
__ push(esi);
__ push(Immediate(proxy->name()));
__ CallRuntime(Runtime::kLoadContextSlotNoReferenceError, 2);
__ push(eax);
} else {
// This expression cannot throw a reference error at the top level.
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(expr->expression(), kStack);
Implement typeof in fast compiler. Review URL: http://codereview.chromium.org/354027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 10:15:25 +00:00
}
__ CallRuntime(Runtime::kTypeof, 1);
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
Apply(context_, eax);
Implement typeof in fast compiler. Review URL: http://codereview.chromium.org/354027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-05 10:15:25 +00:00
break;
}
Implement unary addition in the full (non-optimizing) code generator. Review URL: http://codereview.chromium.org/555099 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-26 13:57:11 +00:00
case Token::ADD: {
Comment cmt(masm_, "[ UnaryOperation (ADD)");
VisitForValue(expr->expression(), kAccumulator);
Label no_conversion;
__ test(result_register(), Immediate(kSmiTagMask));
__ j(zero, &no_conversion);
__ push(result_register());
__ InvokeBuiltin(Builtins::TO_NUMBER, CALL_FUNCTION);
__ bind(&no_conversion);
Apply(context_, result_register());
break;
}
Implement SUB and BIT_NOT unary operations in full codegenerator. This change depends on landing the BIT_NOT unary op stub on arm. That change is out for review. Review URL: http://codereview.chromium.org/557016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3727 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-28 08:15:00 +00:00
case Token::SUB: {
Comment cmt(masm_, "[ UnaryOperation (SUB)");
bool overwrite =
(expr->expression()->AsBinaryOperation() != NULL &&
expr->expression()->AsBinaryOperation()->ResultOverwriteAllowed());
GenericUnaryOpStub stub(Token::SUB, overwrite);
// GenericUnaryOpStub expects the argument to be in the
// accumulator register eax.
VisitForValue(expr->expression(), kAccumulator);
__ CallStub(&stub);
Apply(context_, eax);
break;
}
case Token::BIT_NOT: {
Comment cmt(masm_, "[ UnaryOperation (BIT_NOT)");
bool overwrite =
(expr->expression()->AsBinaryOperation() != NULL &&
expr->expression()->AsBinaryOperation()->ResultOverwriteAllowed());
GenericUnaryOpStub stub(Token::BIT_NOT, overwrite);
// GenericUnaryOpStub expects the argument to be in the
// accumulator register eax.
VisitForValue(expr->expression(), kAccumulator);
// Avoid calling the stub for Smis.
Label smi, done;
__ test(result_register(), Immediate(kSmiTagMask));
__ j(zero, &smi);
// Non-smi: call stub leaving result in accumulator register.
__ CallStub(&stub);
__ jmp(&done);
// Perform operation directly on Smis.
__ bind(&smi);
__ not_(result_register());
__ and_(result_register(), ~kSmiTagMask); // Remove inverted smi-tag.
__ bind(&done);
Apply(context_, result_register());
Add missing break. TBR=ager@chromium.org Review URL: http://codereview.chromium.org/548178 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3730 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-28 09:08:01 +00:00
break;
Implement SUB and BIT_NOT unary operations in full codegenerator. This change depends on landing the BIT_NOT unary op stub on arm. That change is out for review. Review URL: http://codereview.chromium.org/557016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3727 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-28 08:15:00 +00:00
}
Add void operator to fast compiler. Review URL: http://codereview.chromium.org/342055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-30 11:32:42 +00:00
default:
UNREACHABLE();
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
Begin using the top-level code generator for code that is inside directly-applied function literals that are themselves compiled with the top-level code generator. The choice is guarded by a test that the function is anonymous (thus not expected to be recursive) and not in a loop. A compilation hint is set in the shared function info and used to make the choice. Review URL: http://codereview.chromium.org/341081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 14:48:59 +00:00
Comment cmnt(masm_, "[ CountOperation");
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Invalid left-hand sides are rewritten to have a 'throw ReferenceError'
// as the left-hand side.
if (!expr->expression()->IsValidLeftHandSide()) {
VisitForEffect(expr->expression());
return;
}
Support for post-fix count operations (x++, x--) where x is a global variable for the top-level compiler. Review URL: http://codereview.chromium.org/342058 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 10:22:22 +00:00
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
// Expression can only be a property, a global or a (parameter or local)
// slot. Variables with rewrite to .arguments are treated as KEYED_PROPERTY.
enum LhsKind { VARIABLE, NAMED_PROPERTY, KEYED_PROPERTY };
LhsKind assign_type = VARIABLE;
Property* prop = expr->expression()->AsProperty();
// In case of a property we use the uninitialized expression context
// of the key to detect a named property.
if (prop != NULL) {
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
assign_type =
(prop->key()->IsPropertyName()) ? NAMED_PROPERTY : KEYED_PROPERTY;
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
}
// Evaluate expression and get value.
if (assign_type == VARIABLE) {
ASSERT(expr->expression()->AsVariableProxy()->var() != NULL);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Location saved_location = location_;
Inline smi code in count operations in the full code generator. We now test for a smi before calling ToNumber and inline the smi increment/decrement for ++ and --. There only a small increase in code size but loops in top-level code are becoming much faster as a result. Review URL: http://codereview.chromium.org/553056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-22 14:07:25 +00:00
location_ = kAccumulator;
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
EmitVariableLoad(expr->expression()->AsVariableProxy()->var(),
Expression::kValue);
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
location_ = saved_location;
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
} else {
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
// Reserve space for result of postfix operation.
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
if (expr->is_postfix() && context_ != Expression::kEffect) {
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
__ push(Immediate(Smi::FromInt(0)));
}
if (assign_type == NAMED_PROPERTY) {
Change LoadIC interface on ia32 to take arguments in registers. Review URL: http://codereview.chromium.org/573009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-12 10:32:24 +00:00
// Put the object both on the stack and in the accumulator.
VisitForValue(prop->obj(), kAccumulator);
__ push(eax);
Fix issue 541 and some refactoring of the top-level compiler. * Refactor VisitProperty to use the platform-specific methods for emitting the IC calls. * Refactor recording of source positions in the top-level compiler. * Correct the recorded source positions for assignments and property loads. * Fix bug on x64 where source positions were not recorded before a calling a call-IC. * Correct some inconsistencies between IA-32 and X64 top-level code generator. We now pass all regression tests with --always-fast-compiler. Review URL: http://codereview.chromium.org/550043 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-15 12:00:59 +00:00
EmitNamedPropertyLoad(prop);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
} else {
Change LoadIC interface on ia32 to take arguments in registers. Review URL: http://codereview.chromium.org/573009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-12 10:32:24 +00:00
VisitForValue(prop->obj(), kStack);
Change KeyedLoadIC interface on ia32 to take receiver and name in registers. Review URL: http://codereview.chromium.org/601080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-18 10:09:54 +00:00
VisitForValue(prop->key(), kAccumulator);
__ mov(edx, Operand(esp, 0));
__ push(eax);
Fix issue 541 and some refactoring of the top-level compiler. * Refactor VisitProperty to use the platform-specific methods for emitting the IC calls. * Refactor recording of source positions in the top-level compiler. * Correct the recorded source positions for assignments and property loads. * Fix bug on x64 where source positions were not recorded before a calling a call-IC. * Correct some inconsistencies between IA-32 and X64 top-level code generator. We now pass all regression tests with --always-fast-compiler. Review URL: http://codereview.chromium.org/550043 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-15 12:00:59 +00:00
EmitKeyedPropertyLoad(prop);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
}
}
Inline smi code in count operations in the full code generator. We now test for a smi before calling ToNumber and inline the smi increment/decrement for ++ and --. There only a small increase in code size but loops in top-level code are becoming much faster as a result. Review URL: http://codereview.chromium.org/553056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-22 14:07:25 +00:00
// Call ToNumber only if operand is not a smi.
Label no_conversion;
__ test(eax, Immediate(kSmiTagMask));
__ j(zero, &no_conversion);
__ push(eax);
Support for post-fix count operations (x++, x--) where x is a global variable for the top-level compiler. Review URL: http://codereview.chromium.org/342058 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 10:22:22 +00:00
__ InvokeBuiltin(Builtins::TO_NUMBER, CALL_FUNCTION);
Inline smi code in count operations in the full code generator. We now test for a smi before calling ToNumber and inline the smi increment/decrement for ++ and --. There only a small increase in code size but loops in top-level code are becoming much faster as a result. Review URL: http://codereview.chromium.org/553056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-22 14:07:25 +00:00
__ bind(&no_conversion);
Support for post-fix count operations (x++, x--) where x is a global variable for the top-level compiler. Review URL: http://codereview.chromium.org/342058 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 10:22:22 +00:00
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
// Save result for postfix expressions.
if (expr->is_postfix()) {
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
switch (context_) {
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
case Expression::kUninitialized:
UNREACHABLE();
case Expression::kEffect:
// Do not save result.
break;
Style cleanup of switches over Slot::Type in the nonoptimizing code generator. The Slot::Type enumeration has four values. It should never be necessary to use a default to handle the case of a value out of range of the enumeration. Doing so silences a useful warning when one of the enumeration values is actually forgotten or when a new enumeration value is added. Review URL: http://codereview.chromium.org/521019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3532 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-05 09:11:10 +00:00
case Expression::kValue:
case Expression::kTest:
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
case Expression::kValueTest:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
case Expression::kTestValue:
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
// Save the result on the stack. If we have a named or keyed property
// we store the result under the receiver that is currently on top
// of the stack.
switch (assign_type) {
case VARIABLE:
__ push(eax);
break;
case NAMED_PROPERTY:
__ mov(Operand(esp, kPointerSize), eax);
break;
case KEYED_PROPERTY:
__ mov(Operand(esp, 2 * kPointerSize), eax);
break;
}
break;
}
Support for post-fix count operations (x++, x--) where x is a global variable for the top-level compiler. Review URL: http://codereview.chromium.org/342058 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 10:22:22 +00:00
}
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
Inline smi code in count operations in the full code generator. We now test for a smi before calling ToNumber and inline the smi increment/decrement for ++ and --. There only a small increase in code size but loops in top-level code are becoming much faster as a result. Review URL: http://codereview.chromium.org/553056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-22 14:07:25 +00:00
// Inline smi case if we are in a loop.
Label stub_call, done;
if (loop_depth() > 0) {
if (expr->op() == Token::INC) {
__ add(Operand(eax), Immediate(Smi::FromInt(1)));
} else {
__ sub(Operand(eax), Immediate(Smi::FromInt(1)));
}
__ j(overflow, &stub_call);
// We could eliminate this smi check if we split the code at
// the first smi check before calling ToNumber.
__ test(eax, Immediate(kSmiTagMask));
__ j(zero, &done);
__ bind(&stub_call);
// Call stub. Undo operation first.
if (expr->op() == Token::INC) {
__ sub(Operand(eax), Immediate(Smi::FromInt(1)));
} else {
__ add(Operand(eax), Immediate(Smi::FromInt(1)));
}
}
Fix a problem when compiling built-ins with the top-level compiler. Replace runtime call to NumberAdd with call to binary op stub. Until now the top-level compiler always called a runtime function for count operations. In some places we expected in the JS builtins smis as arguments. If we perform a count operation before all smis would get converted into heap numbers by the runtime number add function and result in a runtime assert. Also: Add missing debugger information in the top-level compiler for do-while loops. Review URL: http://codereview.chromium.org/548029 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3610 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-14 17:22:59 +00:00
// Call stub for +1/-1.
GenericBinaryOpStub stub(expr->binary_op(),
NO_OVERWRITE,
Make more use of the NumberInfo data. Makes NumberInfo into a real class. Fix bug where NumberInfo was lost in ToRegister. Allow 17 bits in safe Smis instead of 16. Review URL: http://codereview.chromium.org/668151 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4046 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-03-05 23:54:13 +00:00
NO_GENERIC_BINARY_FLAGS,
Rename NumberInfo to TypeInfo. Since we add more type (StringType, PrimitiveType) the name NumberInfo does not make sense anymore. Review URL: http://codereview.chromium.org/1207006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4268 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-03-25 12:44:15 +00:00
TypeInfo::Unknown());
Support register arguments in more cases. 1. MUL and DIV on SMIs. 2. When calling GenericBinaryOpStub from a virtual frame. 3. When generating code for a loop counter. Overall performance gain is about 0.6%. Review URL: http://codereview.chromium.org/555098 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3708 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-26 10:27:27 +00:00
stub.GenerateCall(masm(), eax, Smi::FromInt(1));
Inline smi code in count operations in the full code generator. We now test for a smi before calling ToNumber and inline the smi increment/decrement for ++ and --. There only a small increase in code size but loops in top-level code are becoming much faster as a result. Review URL: http://codereview.chromium.org/553056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-22 14:07:25 +00:00
__ bind(&done);
Support for post-fix count operations (x++, x--) where x is a global variable for the top-level compiler. Review URL: http://codereview.chromium.org/342058 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 10:22:22 +00:00
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
// Store the value returned in eax.
switch (assign_type) {
case VARIABLE:
if (expr->is_postfix()) {
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Perform the assignment as if via '='.
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
EmitVariableAssignment(expr->expression()->AsVariableProxy()->var(),
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
Token::ASSIGN,
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
Expression::kEffect);
// For all contexts except kEffect: We have the result on
// top of the stack.
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
if (context_ != Expression::kEffect) {
ApplyTOS(context_);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
}
} else {
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// Perform the assignment as if via '='.
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
EmitVariableAssignment(expr->expression()->AsVariableProxy()->var(),
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
Token::ASSIGN,
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
context_);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
}
Support for post-fix count operations (x++, x--) where x is a global variable for the top-level compiler. Review URL: http://codereview.chromium.org/342058 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 10:22:22 +00:00
break;
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
case NAMED_PROPERTY: {
__ mov(ecx, prop->key()->AsLiteral()->handle());
StoreIC interface changed on ia32 to take receiver in edx, not on stack. Review URL: http://codereview.chromium.org/555162 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 08:35:38 +00:00
__ pop(edx);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
// This nop signals to the IC that there is no inlined code at the call
// site for it to patch.
__ nop();
if (expr->is_postfix()) {
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
if (context_ != Expression::kEffect) {
ApplyTOS(context_);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
}
} else {
StoreIC interface changed on ia32 to take receiver in edx, not on stack. Review URL: http://codereview.chromium.org/555162 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-01 08:35:38 +00:00
Apply(context_, eax);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
}
Support for post-fix count operations (x++, x--) where x is a global variable for the top-level compiler. Review URL: http://codereview.chromium.org/342058 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 10:22:22 +00:00
break;
}
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
case KEYED_PROPERTY: {
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
__ pop(ecx);
__ pop(edx);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
// This nop signals to the IC that there is no inlined code at the call
// site for it to patch.
__ nop();
if (expr->is_postfix()) {
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
// Result is on the stack
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
if (context_ != Expression::kEffect) {
ApplyTOS(context_);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
}
} else {
Change KeyedStoreIC interface to take value, key, and receiver in registers. Review URL: http://codereview.chromium.org/608031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-02-25 18:04:25 +00:00
Apply(context_, eax);
Added general pre- and postfix count operations to top-level compiler. Until now we only supported postfix operations on global variables. This change add generic count operations to the top-level compiler. I tried to re-use code from the code generator used for assignment expressions where possible. Review URL: http://codereview.chromium.org/496009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-04 13:56:31 +00:00
}
Support for post-fix count operations (x++, x--) where x is a global variable for the top-level compiler. Review URL: http://codereview.chromium.org/342058 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 10:22:22 +00:00
break;
}
}
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitBinaryOperation(BinaryOperation* expr) {
Begin using the top-level code generator for code that is inside directly-applied function literals that are themselves compiled with the top-level code generator. The choice is guarded by a test that the function is anonymous (thus not expected to be recursive) and not in a loop. A compilation hint is set in the shared function info and used to make the choice. Review URL: http://codereview.chromium.org/341081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 14:48:59 +00:00
Comment cmnt(masm_, "[ BinaryOperation");
Add binary operations to fast compiler. Review URL: http://codereview.chromium.org/342019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-29 11:55:03 +00:00
switch (expr->op()) {
case Token::COMMA:
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
VisitForEffect(expr->left());
Add binary operations to fast compiler. Review URL: http://codereview.chromium.org/342019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-29 11:55:03 +00:00
Visit(expr->right());
break;
case Token::OR:
case Token::AND:
EmitLogicalOperation(expr);
break;
case Token::ADD:
case Token::SUB:
case Token::DIV:
case Token::MOD:
case Token::MUL:
case Token::BIT_OR:
case Token::BIT_AND:
case Token::BIT_XOR:
case Token::SHL:
case Token::SHR:
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
case Token::SAR:
VisitForValue(expr->left(), kStack);
VisitForValue(expr->right(), kAccumulator);
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
EmitBinaryOp(expr->op(), context_);
Add binary operations to fast compiler. Review URL: http://codereview.chromium.org/342019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-29 11:55:03 +00:00
break;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
Add binary operations to fast compiler. Review URL: http://codereview.chromium.org/342019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-29 11:55:03 +00:00
default:
UNREACHABLE();
}
}
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
void FullCodeGenerator::EmitNullCompare(bool strict,
Register obj,
Register null_const,
Label* if_true,
Label* if_false,
Register scratch) {
__ cmp(obj, Operand(null_const));
if (strict) {
__ j(equal, if_true);
} else {
__ j(equal, if_true);
__ cmp(obj, Factory::undefined_value());
__ j(equal, if_true);
__ test(obj, Immediate(kSmiTagMask));
__ j(zero, if_false);
// It can be an undetectable object.
__ mov(scratch, FieldOperand(obj, HeapObject::kMapOffset));
__ movzx_b(scratch, FieldOperand(scratch, Map::kBitFieldOffset));
__ test(scratch, Immediate(1 << Map::kIsUndetectable));
__ j(not_zero, if_true);
}
__ jmp(if_false);
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitCompareOperation(CompareOperation* expr) {
Begin using the top-level code generator for code that is inside directly-applied function literals that are themselves compiled with the top-level code generator. The choice is guarded by a test that the function is anonymous (thus not expected to be recursive) and not in a loop. A compilation hint is set in the shared function info and used to make the choice. Review URL: http://codereview.chromium.org/341081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-03 14:48:59 +00:00
Comment cmnt(masm_, "[ CompareOperation");
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
Cleanup the handling of control flow in the toplevel code generator. Do abstract the setting and restoring of 'argument' state into a function that takes arguments. Do not set the argument state in the code generator unless it represents arguments to a recursive call to Visit. Review URL: http://codereview.chromium.org/550010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-13 11:29:08 +00:00
// Always perform the comparison for its control flow. Pack the result
// into the expression's context after the comparison is performed.
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
Label materialize_true, materialize_false;
Label* if_true = NULL;
Label* if_false = NULL;
PrepareTest(&materialize_true, &materialize_false, &if_true, &if_false);
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(expr->left(), kStack);
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
switch (expr->op()) {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
case Token::IN:
VisitForValue(expr->right(), kStack);
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
__ InvokeBuiltin(Builtins::IN, CALL_FUNCTION);
__ cmp(eax, Factory::true_value());
Cleanup the handling of control flow in the toplevel code generator. Do abstract the setting and restoring of 'argument' state into a function that takes arguments. Do not set the argument state in the code generator unless it represents arguments to a recursive call to Visit. Review URL: http://codereview.chromium.org/550010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-13 11:29:08 +00:00
__ j(equal, if_true);
__ jmp(if_false);
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
break;
case Token::INSTANCEOF: {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(expr->right(), kStack);
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
InstanceofStub stub;
__ CallStub(&stub);
__ test(eax, Operand(eax));
Cleanup the handling of control flow in the toplevel code generator. Do abstract the setting and restoring of 'argument' state into a function that takes arguments. Do not set the argument state in the code generator unless it represents arguments to a recursive call to Visit. Review URL: http://codereview.chromium.org/550010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-13 11:29:08 +00:00
__ j(zero, if_true); // The stub returns 0 for true.
__ jmp(if_false);
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
break;
}
default: {
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
VisitForValue(expr->right(), kAccumulator);
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
Condition cc = no_condition;
bool strict = false;
switch (expr->op()) {
case Token::EQ_STRICT:
strict = true;
// Fall through
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
case Token::EQ: {
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
cc = equal;
__ pop(edx);
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
// If either operand is constant null we do a fast compare
// against null.
Literal* right_literal = expr->right()->AsLiteral();
Literal* left_literal = expr->left()->AsLiteral();
if (right_literal != NULL && right_literal->handle()->IsNull()) {
EmitNullCompare(strict, edx, eax, if_true, if_false, ecx);
Apply(context_, if_true, if_false);
return;
} else if (left_literal != NULL && left_literal->handle()->IsNull()) {
EmitNullCompare(strict, eax, edx, if_true, if_false, ecx);
Apply(context_, if_true, if_false);
return;
}
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
break;
Add complete implementation of full compiler for the ia32 architecture This makes the full compiler handle all constructs on ia32. However the syntax checker for the full compiler is still the same so for both normal operation and with the flag --always-full-compiler the coverage of the full compiler will be the same. This is on preparation for improving the debugger break point experience where the plan is to only use code from full code generator when debugging JavaScript. Runs all tests on all three platforms in release and debug mode. The tests also run with both the following flags to the test runner --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables. Review URL: http://codereview.chromium.org/1989012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-19 07:32:32 +00:00
}
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
case Token::LT:
cc = less;
__ pop(edx);
break;
case Token::GT:
// Reverse left and right sizes to obtain ECMA-262 conversion order.
cc = less;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ mov(edx, result_register());
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
__ pop(eax);
break;
case Token::LTE:
// Reverse left and right sizes to obtain ECMA-262 conversion order.
cc = greater_equal;
Introduce 'top-of-stack caching' to the toplevel code generator by allowing the value of the rightmost subexpressions to be evaluated into an accumulator register (eg, eax, rax, or r0) rather than onto the stack. Review URL: http://codereview.chromium.org/541047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-18 14:04:55 +00:00
__ mov(edx, result_register());
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
__ pop(eax);
break;
case Token::GTE:
cc = greater_equal;
__ pop(edx);
break;
case Token::IN:
case Token::INSTANCEOF:
default:
UNREACHABLE();
}
// The comparison stub expects the smi vs. smi case to be handled
// before it is called.
Label slow_case;
__ mov(ecx, Operand(edx));
__ or_(ecx, Operand(eax));
__ test(ecx, Immediate(kSmiTagMask));
__ j(not_zero, &slow_case, not_taken);
__ cmp(edx, Operand(eax));
Cleanup the handling of control flow in the toplevel code generator. Do abstract the setting and restoring of 'argument' state into a function that takes arguments. Do not set the argument state in the code generator unless it represents arguments to a recursive call to Visit. Review URL: http://codereview.chromium.org/550010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-13 11:29:08 +00:00
__ j(cc, if_true);
__ jmp(if_false);
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
__ bind(&slow_case);
CompareStub stub(cc, strict);
__ CallStub(&stub);
__ test(eax, Operand(eax));
Cleanup the handling of control flow in the toplevel code generator. Do abstract the setting and restoring of 'argument' state into a function that takes arguments. Do not set the argument state in the code generator unless it represents arguments to a recursive call to Visit. Review URL: http://codereview.chromium.org/550010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-13 11:29:08 +00:00
__ j(cc, if_true);
__ jmp(if_false);
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
}
}
Cleanup the handling of control flow in the toplevel code generator. Do abstract the setting and restoring of 'argument' state into a function that takes arguments. Do not set the argument state in the code generator unless it represents arguments to a recursive call to Visit. Review URL: http://codereview.chromium.org/550010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-13 11:29:08 +00:00
// Convert the result of the comparison into one expected for this
// expression's context.
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
Apply(context_, if_true, if_false);
Commiting changelist issue 348039 outside the codereview tool. Add comparisons to fast compiler git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-02 15:01:06 +00:00
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
Adding ThisFunction expression to top-level compiler. Review URL: http://codereview.chromium.org/466056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3430 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 15:10:39 +00:00
__ mov(eax, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Review URL: http://codereview.chromium.org/546075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-19 12:41:02 +00:00
Apply(context_, eax);
Adding ThisFunction expression to top-level compiler. Review URL: http://codereview.chromium.org/466056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3430 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-07 15:10:39 +00:00
}
Simple toplevel code generator support for short-circuited boolean OR in a non-test (ie, value or effect) context. (It is implicitly not in a test context because the code generator does not support expressions in a test context yet.) Compilation is essentially the same as in the optimized code generator. The expression (e0 || e1) is compiled as if it were (let (temp = e0) temp ? temp : e1). On ia32 and x64 a single shared ToBoolean stub is used to convert a value to a flag. The inlined checks assumed by the stub are reordered to compare to undefined (the common case in toplevel code?) first. On ARM a call to the runtime is used. In the interest of code size no checks are yet inlined on ARM. Review URL: http://codereview.chromium.org/334006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-23 10:42:14 +00:00
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
Register FullCodeGenerator::result_register() { return eax; }
Fast-codegen: Implementing try/finally on top of nesting context. Review URL: http://codereview.chromium.org/492002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3461 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-14 11:09:25 +00:00
Fast codegen: Implement with. Review URL: http://codereview.chromium.org/491077 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-16 09:51:07 +00:00
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
Register FullCodeGenerator::context_register() { return esi; }
Fast codegen: Implement with. Review URL: http://codereview.chromium.org/491077 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-16 09:51:07 +00:00
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::StoreToFrameField(int frame_offset, Register value) {
Fast codegen: Implement with. Review URL: http://codereview.chromium.org/491077 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-16 09:51:07 +00:00
ASSERT_EQ(POINTER_SIZE_ALIGN(frame_offset), frame_offset);
__ mov(Operand(ebp, frame_offset), value);
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::LoadContextField(Register dst, int context_index) {
Fast codegen: Implement with. Review URL: http://codereview.chromium.org/491077 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-16 09:51:07 +00:00
__ mov(dst, CodeGenerator::ContextOperand(esi, context_index));
}
Fast-codegen: Implementing try/finally on top of nesting context. Review URL: http://codereview.chromium.org/492002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3461 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-14 11:09:25 +00:00
// ----------------------------------------------------------------------------
// Non-local control flow support.
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::EnterFinallyBlock() {
Fast-codegen: Implementing try/finally on top of nesting context. Review URL: http://codereview.chromium.org/492002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3461 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-14 11:09:25 +00:00
// Cook return address on top of stack (smi encoded Code* delta)
ASSERT(!result_register().is(edx));
__ mov(edx, Operand(esp, 0));
__ sub(Operand(edx), Immediate(masm_->CodeObject()));
ASSERT_EQ(1, kSmiTagSize + kSmiShiftSize);
ASSERT_EQ(0, kSmiTag);
__ add(edx, Operand(edx)); // Convert to smi.
__ mov(Operand(esp, 0), edx);
// Store result register while executing finally block.
__ push(result_register());
}
Rename the toplevel code generator from "Fast" to "Full". It was always ambiguous whether it tried to generate fast code, or generate it quickly. Review URL: http://codereview.chromium.org/549108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-20 15:51:03 +00:00
void FullCodeGenerator::ExitFinallyBlock() {
Fast-codegen: Implementing try/finally on top of nesting context. Review URL: http://codereview.chromium.org/492002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3461 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-12-14 11:09:25 +00:00
ASSERT(!result_register().is(edx));
// Restore result register from stack.
__ pop(result_register());
// Uncook return address.
__ mov(edx, Operand(esp, 0));
__ sar(edx, 1); // Convert smi to int.
__ add(Operand(edx), Immediate(masm_->CodeObject()));
__ mov(Operand(esp, 0), edx);
// And return.
__ ret(0);
}
#undef __
Simple toplevel code generator support for short-circuited boolean OR in a non-test (ie, value or effect) context. (It is implicitly not in a test context because the code generator does not support expressions in a test context yet.) Compilation is essentially the same as in the optimized code generator. The expression (e0 || e1) is compiled as if it were (let (temp = e0) temp ? temp : e1). On ia32 and x64 a single shared ToBoolean stub is used to convert a value to a flag. The inlined checks assumed by the stub are reordered to compare to undefined (the common case in toplevel code?) first. On ARM a call to the runtime is used. In the interest of code size no checks are yet inlined on ARM. Review URL: http://codereview.chromium.org/334006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-23 10:42:14 +00:00
Initial infrastructure for fast compilation of top-level code. The fast code generator is optimized for compilation time and code size. Currently it is only implemented on IA32. It is potentially triggered for any code in the global scope (including code eval'd in the global scope). It performs a syntactic check and chooses to compile in fast mode if the AST contains only supported constructs and matches some other constraints. Initially supported constructs are * ExpressionStatement, * ReturnStatement, * VariableProxy (variable references) to parameters and stack-allocated locals, * Assignment with lhs a parameter or stack-allocated local, and * Literal This allows compilation of literals at the top level and not much else. All intermediate values are allocated to temporaries and the stack is used for all temporaries. The extra memory traffic is a known issue. The code generated for 'true' is: 0 push ebp 1 mov ebp,esp 3 push esi 4 push edi 5 push 0xf5cca135 ;; object: 0xf5cca135 <undefined> 10 cmp esp,[0x8277efc] 16 jnc 27 (0xf5cbbb1b) 22 call 0xf5cac960 ;; code: STUB, StackCheck, minor: 0 27 push 0xf5cca161 ;; object: 0xf5cca161 <true> 32 mov eax,[esp] 35 mov [ebp+0xf4],eax 38 pop eax 39 mov eax,[ebp+0xf4] 42 mov esp,ebp ;; js return 44 pop ebp 45 ret 0x4 48 mov eax,0xf5cca135 ;; object: 0xf5cca135 <undefined> 53 mov esp,ebp ;; js return 55 pop ebp 56 ret 0x4 Review URL: http://codereview.chromium.org/273050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-14 19:30:50 +00:00
} } // namespace v8::internal
Allow build-time selection between ia32 and x86_64 in the GYP/Xcode Mac Chromium build. v8.gyp no longer sets any V8_TARGET_ARCH_* macro on the Mac. Instead, the proper V8_TARGET_ARCH_* macro will be set by src/globals.h in the same way as the V8_HOST_ARCH_* macro when it detects that no target macro is currently defined. The Mac build will attempt to compile all ia32 and x86_64 .cc files. #ifdef guards in each of these target-specific source files prevent their compilation when the associated target is not selected. For completeness, these #ifdef guards are also provided for the arm and mips .cc files. BUG=706 TEST=x86_64 Mac GYP/Xcode-based Chromium build (still depends on other changes) Review URL: http://codereview.chromium.org/2133003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4666 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-17 15:41:35 +00:00
Fix presubmit error. TBR=ager@chromium.org Review URL: http://codereview.chromium.org/2117010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4669 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-18 06:59:23 +00:00
#endif // V8_TARGET_ARCH_IA32
Reference in New Issue Copy Permalink