AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
1e5c03c78e
v8/test/inspector/debugger/other-pause-reasons-expected.txt

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

38 lines
1.9 KiB
Plaintext
Raw Normal View History

[debugger] Explicitly encode 'other' as reason for breaks and pauses This CL explicitly encodes the 'other' reason for breaking for: * regular breakpoints * triggered pause events. The reason for explicitly encoding the reason is that we may otherwise not know why we pause when we handle it. This knowledge is needed in order to fully support instrumentation breakpoints, e.g. if we do not know that we paused on a triggered pause, and this happens to overlap with an instrumentation, we would previously only report 'instrumentation' as a reason which would be wrong. Bug: chromium:1229541 Change-Id: I93c08f965a491f6d34f280157b182a78d5b3cf07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289638 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#77970}
2021-11-18 08:24:37 +00:00
Test that all 'other' reasons are explicitly encoded on a pause event if they overlap with another reason
Running test: testBreakpointPauseReason
[debugger] Fix step out when instrumentation breaks are turned on When triggering a step out action, we check whether we already are at a return or suspend location. If not, we first flood all return positions with breakpoints, set the fast_forward_to_return_ flag and continue. With the new way of reporting instrumentation breakpoints, we now may get into the situation where we stopped on an instrumentation, but may still need to continue until we reach the return point for the step out. This CL fixes a bug in which we ran into a DCHECK that expected us to stop on a return location (since fast_forward_to_return_ is set to true), but we didn't. Drive-by: adapt other stepping tests to properly wait for all pauses Bug: chromium:1229541 Change-Id: Ie5fd358922f4cdaf1f8584bb0b35e87b0e221fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3480094 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#79226}
2022-02-23 10:27:52 +00:00
Paused with reason instrumentation, data {"scriptId":"3","url":"foo.js"} and scriptId: 3.
Paused with reason other, data {} and scriptId: 3.
[debugger] Explicitly encode 'other' as reason for breaks and pauses This CL explicitly encodes the 'other' reason for breaking for: * regular breakpoints * triggered pause events. The reason for explicitly encoding the reason is that we may otherwise not know why we pause when we handle it. This knowledge is needed in order to fully support instrumentation breakpoints, e.g. if we do not know that we paused on a triggered pause, and this happens to overlap with an instrumentation, we would previously only report 'instrumentation' as a reason which would be wrong. Bug: chromium:1229541 Change-Id: I93c08f965a491f6d34f280157b182a78d5b3cf07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289638 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#77970}
2021-11-18 08:24:37 +00:00
Running test: testTriggeredPausePauseReason
[debugger] Fix step out when instrumentation breaks are turned on When triggering a step out action, we check whether we already are at a return or suspend location. If not, we first flood all return positions with breakpoints, set the fast_forward_to_return_ flag and continue. With the new way of reporting instrumentation breakpoints, we now may get into the situation where we stopped on an instrumentation, but may still need to continue until we reach the return point for the step out. This CL fixes a bug in which we ran into a DCHECK that expected us to stop on a return location (since fast_forward_to_return_ is set to true), but we didn't. Drive-by: adapt other stepping tests to properly wait for all pauses Bug: chromium:1229541 Change-Id: Ie5fd358922f4cdaf1f8584bb0b35e87b0e221fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3480094 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#79226}
2022-02-23 10:27:52 +00:00
Paused with reason instrumentation, data {"scriptId":"4","url":"foo.js"} and scriptId: 4.
Paused with reason other, data {} and scriptId: 4.
[debugger] Explicitly encode 'other' as a reason when stepping Previously, we would encode 'other' as a reason for pausing when stepping too, however, it would not show as such in case it would overlap with another reason. This CL makes sure that we always report 'other' as a reason if we are stepping. Drive-by: only encode 'other' as a reason once Bug: chromium:1229541 Change-Id: Id73822dff68d1d54a2f1fafdf2a097e1377ece75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295346 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#78118}
2021-11-23 09:14:18 +00:00
Running test: testSteppingPauseReason
[debugger] Fix step out when instrumentation breaks are turned on When triggering a step out action, we check whether we already are at a return or suspend location. If not, we first flood all return positions with breakpoints, set the fast_forward_to_return_ flag and continue. With the new way of reporting instrumentation breakpoints, we now may get into the situation where we stopped on an instrumentation, but may still need to continue until we reach the return point for the step out. This CL fixes a bug in which we ran into a DCHECK that expected us to stop on a return location (since fast_forward_to_return_ is set to true), but we didn't. Drive-by: adapt other stepping tests to properly wait for all pauses Bug: chromium:1229541 Change-Id: Ie5fd358922f4cdaf1f8584bb0b35e87b0e221fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3480094 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#79226}
2022-02-23 10:27:52 +00:00
Paused with reason instrumentation, data {"scriptId":"5","url":"foo.js"} and scriptId: 5.
Paused with reason other, data {} and scriptId: 5.
Paused with reason other, data {} and scriptId: 5.
Paused with reason instrumentation, data {"scriptId":"6","url":"bar.js"} and scriptId: 6.
Paused with reason other, data {} and scriptId: 6.
[debugger] Explicitly encode 'other' as a reason when stepping Previously, we would encode 'other' as a reason for pausing when stepping too, however, it would not show as such in case it would overlap with another reason. This CL makes sure that we always report 'other' as a reason if we are stepping. Drive-by: only encode 'other' as a reason once Bug: chromium:1229541 Change-Id: Id73822dff68d1d54a2f1fafdf2a097e1377ece75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295346 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#78118}
2021-11-23 09:14:18 +00:00
Running test: testOnlyReportOtherWithEmptyDataOnce
[debugger] Fix step out when instrumentation breaks are turned on When triggering a step out action, we check whether we already are at a return or suspend location. If not, we first flood all return positions with breakpoints, set the fast_forward_to_return_ flag and continue. With the new way of reporting instrumentation breakpoints, we now may get into the situation where we stopped on an instrumentation, but may still need to continue until we reach the return point for the step out. This CL fixes a bug in which we ran into a DCHECK that expected us to stop on a return location (since fast_forward_to_return_ is set to true), but we didn't. Drive-by: adapt other stepping tests to properly wait for all pauses Bug: chromium:1229541 Change-Id: Ie5fd358922f4cdaf1f8584bb0b35e87b0e221fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3480094 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#79226}
2022-02-23 10:27:52 +00:00
Paused with reason other, data {} and scriptId: 7.
[debugger] Explicitly encode debugger statements in didPause This CL makes sure to forward the information that we are pausing because of a debugger statement, and to encode it explicitly as an 'other' reason when reporting the pause to the front-end. Drive-by: refactoring the way break reasons are propagated by introducing a new enum for break reasons Bug: chromium:1229541, chromium:1133307 Change-Id: I9d2e8d8da54d96a231eff9d1f62b74507955b18f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306978 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#78202}
2021-12-02 09:26:01 +00:00
Running test: testDebuggerStatementReason
[debugger] Fix step out when instrumentation breaks are turned on When triggering a step out action, we check whether we already are at a return or suspend location. If not, we first flood all return positions with breakpoints, set the fast_forward_to_return_ flag and continue. With the new way of reporting instrumentation breakpoints, we now may get into the situation where we stopped on an instrumentation, but may still need to continue until we reach the return point for the step out. This CL fixes a bug in which we ran into a DCHECK that expected us to stop on a return location (since fast_forward_to_return_ is set to true), but we didn't. Drive-by: adapt other stepping tests to properly wait for all pauses Bug: chromium:1229541 Change-Id: Ie5fd358922f4cdaf1f8584bb0b35e87b0e221fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3480094 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#79226}
2022-02-23 10:27:52 +00:00
Paused with reason instrumentation, data {"scriptId":"8","url":"foo.js"} and scriptId: 8.
Paused with reason other, data {} and scriptId: 8.
[debugger] Remove separate `didPause` for instrumentation breakpoints This removes the additional call to `didPause` solely for instrumentation breakpoints. They will be reported along with any other pause reasons, and if several apply, 'ambiguous' will be reported as a reason. Bug: chromium:1229541 Change-Id: I38557248dc2274c2ff2c396aa19073f4a5c5abd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3300134 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#78271}
2021-12-06 12:12:41 +00:00
Running test: testAsyncSteppingPauseReason
[debugger] Fix step out when instrumentation breaks are turned on When triggering a step out action, we check whether we already are at a return or suspend location. If not, we first flood all return positions with breakpoints, set the fast_forward_to_return_ flag and continue. With the new way of reporting instrumentation breakpoints, we now may get into the situation where we stopped on an instrumentation, but may still need to continue until we reach the return point for the step out. This CL fixes a bug in which we ran into a DCHECK that expected us to stop on a return location (since fast_forward_to_return_ is set to true), but we didn't. Drive-by: adapt other stepping tests to properly wait for all pauses Bug: chromium:1229541 Change-Id: Ie5fd358922f4cdaf1f8584bb0b35e87b0e221fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3480094 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#79226}
2022-02-23 10:27:52 +00:00
Paused with reason instrumentation, data {"scriptId":"9","url":"foo.js"} and scriptId: 9.
Paused with reason other, data {} and scriptId: 9.
Paused with reason other, data {} and scriptId: 9.
Paused with reason instrumentation, data {"scriptId":"10","url":"bar.js"} and scriptId: 10.
Paused with reason other, data {} and scriptId: 10.
Paused with reason other, data {} and scriptId: 10.
Running test: testSteppingOutPauseReason
Paused with reason instrumentation, data {"scriptId":"11","url":"foo.js"} and scriptId: 11.
Paused with reason other, data {} and scriptId: 11.
Paused with reason instrumentation, data {"scriptId":"12","url":"bar.js"} and scriptId: 12.
Paused with reason other, data {} and scriptId: 11.
Reference in New Issue Copy Permalink