Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
// Copyright 2009 the V8 project authors. All rights reserved.
|
|
|
|
// Redistribution and use in source and binary forms, with or without
|
|
|
|
// modification, are permitted provided that the following conditions are
|
|
|
|
// met:
|
|
|
|
//
|
|
|
|
// * Redistributions of source code must retain the above copyright
|
|
|
|
// notice, this list of conditions and the following disclaimer.
|
|
|
|
// * Redistributions in binary form must reproduce the above
|
|
|
|
// copyright notice, this list of conditions and the following
|
|
|
|
// disclaimer in the documentation and/or other materials provided
|
|
|
|
// with the distribution.
|
|
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
|
|
// contributors may be used to endorse or promote products derived
|
|
|
|
// from this software without specific prior written permission.
|
|
|
|
//
|
|
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
|
|
|
|
#include "v8.h"
|
|
|
|
|
|
|
|
#include "codegen-inl.h"
|
|
|
|
#include "debug.h"
|
|
|
|
#include "fast-codegen.h"
|
|
|
|
|
|
|
|
namespace v8 {
|
|
|
|
namespace internal {
|
|
|
|
|
|
|
|
#define __ ACCESS_MASM(masm_)
|
|
|
|
|
|
|
|
// Generate code for a JS function. On entry to the function the receiver
|
|
|
|
// and arguments have been pushed on the stack left to right, with the
|
|
|
|
// return address on top of them. The actual argument count matches the
|
|
|
|
// formal parameter count expected by the function.
|
|
|
|
//
|
|
|
|
// The live registers are:
|
|
|
|
// o rdi: the JS function object being called (ie, ourselves)
|
|
|
|
// o rsi: our context
|
|
|
|
// o rbp: our caller's frame pointer
|
|
|
|
// o rsp: stack pointer (pointing to return address)
|
|
|
|
//
|
|
|
|
// The function builds a JS frame. Please see JavaScriptFrameConstants in
|
|
|
|
// frames-x64.h for its layout.
|
|
|
|
void FastCodeGenerator::Generate(FunctionLiteral* fun) {
|
|
|
|
function_ = fun;
|
2009-10-15 15:27:37 +00:00
|
|
|
SetFunctionPosition(fun);
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
|
|
|
|
__ push(rbp); // Caller's frame pointer.
|
|
|
|
__ movq(rbp, rsp);
|
|
|
|
__ push(rsi); // Callee's context.
|
|
|
|
__ push(rdi); // Callee's JS Function.
|
|
|
|
|
|
|
|
{ Comment cmnt(masm_, "[ Allocate locals");
|
|
|
|
int locals_count = fun->scope()->num_stack_slots();
|
|
|
|
for (int i = 0; i < locals_count; i++) {
|
|
|
|
__ PushRoot(Heap::kUndefinedValueRootIndex);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
{ Comment cmnt(masm_, "[ Stack check");
|
|
|
|
Label ok;
|
|
|
|
__ CompareRoot(rsp, Heap::kStackLimitRootIndex);
|
|
|
|
__ j(above_equal, &ok);
|
|
|
|
StackCheckStub stub;
|
|
|
|
__ CallStub(&stub);
|
|
|
|
__ bind(&ok);
|
|
|
|
}
|
|
|
|
|
2009-10-21 09:17:39 +00:00
|
|
|
{ Comment cmnt(masm_, "[ Declarations");
|
|
|
|
VisitDeclarations(fun->scope()->declarations());
|
|
|
|
}
|
|
|
|
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
{ Comment cmnt(masm_, "[ Body");
|
|
|
|
VisitStatements(fun->body());
|
|
|
|
}
|
|
|
|
|
|
|
|
{ Comment cmnt(masm_, "[ return <undefined>;");
|
|
|
|
// Emit a 'return undefined' in case control fell off the end of the
|
|
|
|
// body.
|
|
|
|
__ LoadRoot(rax, Heap::kUndefinedValueRootIndex);
|
2009-10-15 15:27:37 +00:00
|
|
|
SetReturnPosition(fun);
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
__ RecordJSReturn();
|
|
|
|
// Do not use the leave instruction here because it is too short to
|
|
|
|
// patch with the code required by the debugger.
|
|
|
|
__ movq(rsp, rbp);
|
|
|
|
__ pop(rbp);
|
|
|
|
__ ret((fun->scope()->num_parameters() + 1) * kPointerSize);
|
|
|
|
#ifdef ENABLE_DEBUGGER_SUPPORT
|
|
|
|
// Add padding that will be overwritten by a debugger breakpoint. We
|
|
|
|
// have just generated "movq rsp, rbp; pop rbp; ret k" with length 7
|
|
|
|
// (3 + 1 + 3).
|
|
|
|
const int kPadding = Debug::kX64JSReturnSequenceLength - 7;
|
|
|
|
for (int i = 0; i < kPadding; ++i) {
|
|
|
|
masm_->int3();
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-10-21 09:17:39 +00:00
|
|
|
void FastCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) {
|
|
|
|
// Call the runtime to declare the globals.
|
|
|
|
__ Push(pairs);
|
|
|
|
__ push(rsi); // The context is the second argument.
|
|
|
|
__ Push(Smi::FromInt(is_eval_ ? 1 : 0));
|
|
|
|
__ CallRuntime(Runtime::kDeclareGlobals, 3);
|
|
|
|
// Return value is ignored.
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
void FastCodeGenerator::VisitBlock(Block* stmt) {
|
|
|
|
Comment cmnt(masm_, "[ Block");
|
|
|
|
SetStatementPosition(stmt);
|
|
|
|
VisitStatements(stmt->statements());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
void FastCodeGenerator::VisitExpressionStatement(ExpressionStatement* stmt) {
|
|
|
|
Comment cmnt(masm_, "[ ExpressionStatement");
|
2009-10-15 15:27:37 +00:00
|
|
|
SetStatementPosition(stmt);
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
Visit(stmt->expression());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
void FastCodeGenerator::VisitReturnStatement(ReturnStatement* stmt) {
|
|
|
|
Comment cmnt(masm_, "[ ReturnStatement");
|
2009-10-15 15:27:37 +00:00
|
|
|
SetStatementPosition(stmt);
|
2009-10-19 10:36:42 +00:00
|
|
|
Expression* expr = stmt->expression();
|
|
|
|
Visit(expr);
|
|
|
|
|
|
|
|
// Complete the statement based on the location of the subexpression.
|
|
|
|
Location source = expr->location();
|
|
|
|
ASSERT(!source.is_nowhere());
|
|
|
|
if (source.is_temporary()) {
|
|
|
|
__ pop(rax);
|
|
|
|
} else {
|
|
|
|
ASSERT(source.is_constant());
|
|
|
|
ASSERT(expr->AsLiteral() != NULL);
|
|
|
|
__ Move(rax, expr->AsLiteral()->handle());
|
|
|
|
}
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
__ RecordJSReturn();
|
|
|
|
// Do not use the leave instruction here because it is too short to
|
|
|
|
// patch with the code required by the debugger.
|
|
|
|
__ movq(rsp, rbp);
|
|
|
|
__ pop(rbp);
|
|
|
|
__ ret((function_->scope()->num_parameters() + 1) * kPointerSize);
|
|
|
|
#ifdef ENABLE_DEBUGGER_SUPPORT
|
|
|
|
// Add padding that will be overwritten by a debugger breakpoint. We
|
|
|
|
// have just generated "movq rsp, rbp; pop rbp; ret k" with length 7
|
|
|
|
// (3 + 1 + 3).
|
|
|
|
const int kPadding = Debug::kX64JSReturnSequenceLength - 7;
|
|
|
|
for (int i = 0; i < kPadding; ++i) {
|
|
|
|
masm_->int3();
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-10-21 09:17:39 +00:00
|
|
|
void FastCodeGenerator::VisitFunctionLiteral(FunctionLiteral* expr) {
|
|
|
|
Comment cmnt(masm_, "[ FunctionLiteral");
|
|
|
|
|
|
|
|
// Build the function boilerplate and instantiate it.
|
|
|
|
Handle<JSFunction> boilerplate = BuildBoilerplate(expr);
|
|
|
|
if (HasStackOverflow()) return;
|
|
|
|
|
|
|
|
ASSERT(boilerplate->IsBoilerplate());
|
|
|
|
|
|
|
|
// Create a new closure.
|
|
|
|
__ Push(boilerplate);
|
|
|
|
__ push(rsi);
|
|
|
|
__ CallRuntime(Runtime::kNewClosure, 2);
|
|
|
|
|
|
|
|
if (expr->location().is_temporary()) {
|
|
|
|
__ push(rax);
|
|
|
|
} else {
|
|
|
|
ASSERT(expr->location().is_nowhere());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-10-16 09:46:09 +00:00
|
|
|
void FastCodeGenerator::VisitVariableProxy(VariableProxy* expr) {
|
|
|
|
Comment cmnt(masm_, "[ VariableProxy");
|
|
|
|
Expression* rewrite = expr->var()->rewrite();
|
|
|
|
ASSERT(rewrite != NULL);
|
|
|
|
|
|
|
|
Slot* slot = rewrite->AsSlot();
|
|
|
|
ASSERT(slot != NULL);
|
|
|
|
{ Comment cmnt(masm_, "[ Slot");
|
|
|
|
if (expr->location().is_temporary()) {
|
|
|
|
__ push(Operand(rbp, SlotOffset(slot)));
|
|
|
|
} else {
|
|
|
|
ASSERT(expr->location().is_nowhere());
|
|
|
|
}
|
Added first support for tracking locations of expressions in the
fast-mode code generator.
AST expression nodes are annotated with a location when doing the
initial syntactic check of the AST. In the current implementation,
expression locations are 'temporary' (ie, allocated to the stack) or
'nowhere' (ie, the expression's value is not needed though it must be
evaluated for side effects).
For the assignment '.result = true' on IA32, we had before (with the
true value already on top of the stack):
32 mov eax,[esp]
35 mov [ebp+0xf4],eax
38 pop eax
Now:
32 pop [ebp+0xf4]
======== On x64, before:
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
Now:
37 pop [rbp-0x18]
======== On ARM, before (with the true value in register ip):
36 str ip, [sp, #-4]!
40 ldr ip, [sp, #+0]
44 str ip, [fp, #-12]
48 add sp, sp, #4
Now:
36 str ip, [fp, #-12]
Review URL: http://codereview.chromium.org/267118
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3076 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 16:42:22 +00:00
|
|
|
}
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
void FastCodeGenerator::VisitAssignment(Assignment* expr) {
|
|
|
|
Comment cmnt(masm_, "[ Assignment");
|
|
|
|
ASSERT(expr->op() == Token::ASSIGN || expr->op() == Token::INIT_VAR);
|
2009-10-19 10:36:42 +00:00
|
|
|
Expression* rhs = expr->value();
|
|
|
|
Visit(rhs);
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
|
Added support for assignments to global variables in the toplevel code
generator. We use the normal store IC mechanism with the global
object as the receiver. The following code is generated for 'x=true'
at toplevel.
======== IA32:
27 mov eax,0xf5d06161 ;; object: 0xf5d06161 <true>
32 mov ecx,0xf5d09c35 ;; object: 0xf5d09c35 <String[1]: x>
37 push [esi+0x17]
40 call StoreIC_Initialize (0xf5ce75c0) ;; code: STORE_IC, UNINITIALIZED
45 mov [esp],eax
======== X64:
25 movq rax,0x7f867a7b6199 ;; object: 0x7f867a7b6199 <true>
35 movq rcx,0x7f867a7bae71 ;; object: 0x7f867a7bae71 <String[1]: x>
45 push [rsi+0x2f]
49 call StoreIC_Initialize (0x7f8655929ac0) ;; code: STORE_IC, UNINITIALIZED
54 movq [rsp],rax
======== ARM:
32 e59f0054 ldr r0, [pc, #+84] ;; object: 0xf5b78161 <true>
36 e59f2054 ldr r2, [pc, #+84] ;; object: 0xf5b7bc35 <String[1]: x>
40 e598c017 ldr ip, [r8, #+23]
44 e52dc004 str ip, [sp, #-4]!
48 e1a0e00f mov lr, pc
52 e59ff048 ldr pc, [pc, #+72] ;; debug: statement 0
;; code: STORE_IC, UNINITIALIZED
56 e58d0000 str r0, [sp, #+0]
Review URL: http://codereview.chromium.org/305005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-20 13:37:26 +00:00
|
|
|
// Left-hand side can only be a global or a (parameter or local) slot.
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
Variable* var = expr->target()->AsVariableProxy()->AsVariable();
|
Added support for assignments to global variables in the toplevel code
generator. We use the normal store IC mechanism with the global
object as the receiver. The following code is generated for 'x=true'
at toplevel.
======== IA32:
27 mov eax,0xf5d06161 ;; object: 0xf5d06161 <true>
32 mov ecx,0xf5d09c35 ;; object: 0xf5d09c35 <String[1]: x>
37 push [esi+0x17]
40 call StoreIC_Initialize (0xf5ce75c0) ;; code: STORE_IC, UNINITIALIZED
45 mov [esp],eax
======== X64:
25 movq rax,0x7f867a7b6199 ;; object: 0x7f867a7b6199 <true>
35 movq rcx,0x7f867a7bae71 ;; object: 0x7f867a7bae71 <String[1]: x>
45 push [rsi+0x2f]
49 call StoreIC_Initialize (0x7f8655929ac0) ;; code: STORE_IC, UNINITIALIZED
54 movq [rsp],rax
======== ARM:
32 e59f0054 ldr r0, [pc, #+84] ;; object: 0xf5b78161 <true>
36 e59f2054 ldr r2, [pc, #+84] ;; object: 0xf5b7bc35 <String[1]: x>
40 e598c017 ldr ip, [r8, #+23]
44 e52dc004 str ip, [sp, #-4]!
48 e1a0e00f mov lr, pc
52 e59ff048 ldr pc, [pc, #+72] ;; debug: statement 0
;; code: STORE_IC, UNINITIALIZED
56 e58d0000 str r0, [sp, #+0]
Review URL: http://codereview.chromium.org/305005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-20 13:37:26 +00:00
|
|
|
ASSERT(var != NULL);
|
|
|
|
ASSERT(var->is_global() || var->slot() != NULL);
|
Added first support for tracking locations of expressions in the
fast-mode code generator.
AST expression nodes are annotated with a location when doing the
initial syntactic check of the AST. In the current implementation,
expression locations are 'temporary' (ie, allocated to the stack) or
'nowhere' (ie, the expression's value is not needed though it must be
evaluated for side effects).
For the assignment '.result = true' on IA32, we had before (with the
true value already on top of the stack):
32 mov eax,[esp]
35 mov [ebp+0xf4],eax
38 pop eax
Now:
32 pop [ebp+0xf4]
======== On x64, before:
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
Now:
37 pop [rbp-0x18]
======== On ARM, before (with the true value in register ip):
36 str ip, [sp, #-4]!
40 ldr ip, [sp, #+0]
44 str ip, [fp, #-12]
48 add sp, sp, #4
Now:
36 str ip, [fp, #-12]
Review URL: http://codereview.chromium.org/267118
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3076 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 16:42:22 +00:00
|
|
|
|
2009-10-19 10:36:42 +00:00
|
|
|
// Complete the assignment based on the location of the right-hand-side
|
|
|
|
// value and the desired location of the assignment value.
|
|
|
|
Location destination = expr->location();
|
|
|
|
Location source = rhs->location();
|
|
|
|
ASSERT(!destination.is_constant());
|
|
|
|
ASSERT(!source.is_nowhere());
|
|
|
|
|
Added support for assignments to global variables in the toplevel code
generator. We use the normal store IC mechanism with the global
object as the receiver. The following code is generated for 'x=true'
at toplevel.
======== IA32:
27 mov eax,0xf5d06161 ;; object: 0xf5d06161 <true>
32 mov ecx,0xf5d09c35 ;; object: 0xf5d09c35 <String[1]: x>
37 push [esi+0x17]
40 call StoreIC_Initialize (0xf5ce75c0) ;; code: STORE_IC, UNINITIALIZED
45 mov [esp],eax
======== X64:
25 movq rax,0x7f867a7b6199 ;; object: 0x7f867a7b6199 <true>
35 movq rcx,0x7f867a7bae71 ;; object: 0x7f867a7bae71 <String[1]: x>
45 push [rsi+0x2f]
49 call StoreIC_Initialize (0x7f8655929ac0) ;; code: STORE_IC, UNINITIALIZED
54 movq [rsp],rax
======== ARM:
32 e59f0054 ldr r0, [pc, #+84] ;; object: 0xf5b78161 <true>
36 e59f2054 ldr r2, [pc, #+84] ;; object: 0xf5b7bc35 <String[1]: x>
40 e598c017 ldr ip, [r8, #+23]
44 e52dc004 str ip, [sp, #-4]!
48 e1a0e00f mov lr, pc
52 e59ff048 ldr pc, [pc, #+72] ;; debug: statement 0
;; code: STORE_IC, UNINITIALIZED
56 e58d0000 str r0, [sp, #+0]
Review URL: http://codereview.chromium.org/305005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-20 13:37:26 +00:00
|
|
|
if (var->is_global()) {
|
|
|
|
// Assignment to a global variable, use inline caching. Right-hand-side
|
|
|
|
// value is passed in rax, variable name in rcx, and the global object
|
|
|
|
// on the stack.
|
|
|
|
if (source.is_temporary()) {
|
|
|
|
__ pop(rax);
|
|
|
|
} else {
|
|
|
|
ASSERT(source.is_constant());
|
|
|
|
ASSERT(rhs->AsLiteral() != NULL);
|
|
|
|
__ Move(rax, rhs->AsLiteral()->handle());
|
|
|
|
}
|
|
|
|
__ Move(rcx, var->name());
|
|
|
|
__ push(CodeGenerator::GlobalObject());
|
|
|
|
Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));
|
|
|
|
__ Call(ic, RelocInfo::CODE_TARGET);
|
|
|
|
// Overwrite the global object on the stack with the result if needed.
|
2009-10-19 10:36:42 +00:00
|
|
|
if (destination.is_temporary()) {
|
Added support for assignments to global variables in the toplevel code
generator. We use the normal store IC mechanism with the global
object as the receiver. The following code is generated for 'x=true'
at toplevel.
======== IA32:
27 mov eax,0xf5d06161 ;; object: 0xf5d06161 <true>
32 mov ecx,0xf5d09c35 ;; object: 0xf5d09c35 <String[1]: x>
37 push [esi+0x17]
40 call StoreIC_Initialize (0xf5ce75c0) ;; code: STORE_IC, UNINITIALIZED
45 mov [esp],eax
======== X64:
25 movq rax,0x7f867a7b6199 ;; object: 0x7f867a7b6199 <true>
35 movq rcx,0x7f867a7bae71 ;; object: 0x7f867a7bae71 <String[1]: x>
45 push [rsi+0x2f]
49 call StoreIC_Initialize (0x7f8655929ac0) ;; code: STORE_IC, UNINITIALIZED
54 movq [rsp],rax
======== ARM:
32 e59f0054 ldr r0, [pc, #+84] ;; object: 0xf5b78161 <true>
36 e59f2054 ldr r2, [pc, #+84] ;; object: 0xf5b7bc35 <String[1]: x>
40 e598c017 ldr ip, [r8, #+23]
44 e52dc004 str ip, [sp, #-4]!
48 e1a0e00f mov lr, pc
52 e59ff048 ldr pc, [pc, #+72] ;; debug: statement 0
;; code: STORE_IC, UNINITIALIZED
56 e58d0000 str r0, [sp, #+0]
Review URL: http://codereview.chromium.org/305005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-20 13:37:26 +00:00
|
|
|
__ movq(Operand(rsp, 0), rax);
|
2009-10-19 10:36:42 +00:00
|
|
|
} else {
|
Added support for assignments to global variables in the toplevel code
generator. We use the normal store IC mechanism with the global
object as the receiver. The following code is generated for 'x=true'
at toplevel.
======== IA32:
27 mov eax,0xf5d06161 ;; object: 0xf5d06161 <true>
32 mov ecx,0xf5d09c35 ;; object: 0xf5d09c35 <String[1]: x>
37 push [esi+0x17]
40 call StoreIC_Initialize (0xf5ce75c0) ;; code: STORE_IC, UNINITIALIZED
45 mov [esp],eax
======== X64:
25 movq rax,0x7f867a7b6199 ;; object: 0x7f867a7b6199 <true>
35 movq rcx,0x7f867a7bae71 ;; object: 0x7f867a7bae71 <String[1]: x>
45 push [rsi+0x2f]
49 call StoreIC_Initialize (0x7f8655929ac0) ;; code: STORE_IC, UNINITIALIZED
54 movq [rsp],rax
======== ARM:
32 e59f0054 ldr r0, [pc, #+84] ;; object: 0xf5b78161 <true>
36 e59f2054 ldr r2, [pc, #+84] ;; object: 0xf5b7bc35 <String[1]: x>
40 e598c017 ldr ip, [r8, #+23]
44 e52dc004 str ip, [sp, #-4]!
48 e1a0e00f mov lr, pc
52 e59ff048 ldr pc, [pc, #+72] ;; debug: statement 0
;; code: STORE_IC, UNINITIALIZED
56 e58d0000 str r0, [sp, #+0]
Review URL: http://codereview.chromium.org/305005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-20 13:37:26 +00:00
|
|
|
__ pop(rax);
|
2009-10-19 10:36:42 +00:00
|
|
|
}
|
Added first support for tracking locations of expressions in the
fast-mode code generator.
AST expression nodes are annotated with a location when doing the
initial syntactic check of the AST. In the current implementation,
expression locations are 'temporary' (ie, allocated to the stack) or
'nowhere' (ie, the expression's value is not needed though it must be
evaluated for side effects).
For the assignment '.result = true' on IA32, we had before (with the
true value already on top of the stack):
32 mov eax,[esp]
35 mov [ebp+0xf4],eax
38 pop eax
Now:
32 pop [ebp+0xf4]
======== On x64, before:
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
Now:
37 pop [rbp-0x18]
======== On ARM, before (with the true value in register ip):
36 str ip, [sp, #-4]!
40 ldr ip, [sp, #+0]
44 str ip, [fp, #-12]
48 add sp, sp, #4
Now:
36 str ip, [fp, #-12]
Review URL: http://codereview.chromium.org/267118
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3076 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 16:42:22 +00:00
|
|
|
} else {
|
Added support for assignments to global variables in the toplevel code
generator. We use the normal store IC mechanism with the global
object as the receiver. The following code is generated for 'x=true'
at toplevel.
======== IA32:
27 mov eax,0xf5d06161 ;; object: 0xf5d06161 <true>
32 mov ecx,0xf5d09c35 ;; object: 0xf5d09c35 <String[1]: x>
37 push [esi+0x17]
40 call StoreIC_Initialize (0xf5ce75c0) ;; code: STORE_IC, UNINITIALIZED
45 mov [esp],eax
======== X64:
25 movq rax,0x7f867a7b6199 ;; object: 0x7f867a7b6199 <true>
35 movq rcx,0x7f867a7bae71 ;; object: 0x7f867a7bae71 <String[1]: x>
45 push [rsi+0x2f]
49 call StoreIC_Initialize (0x7f8655929ac0) ;; code: STORE_IC, UNINITIALIZED
54 movq [rsp],rax
======== ARM:
32 e59f0054 ldr r0, [pc, #+84] ;; object: 0xf5b78161 <true>
36 e59f2054 ldr r2, [pc, #+84] ;; object: 0xf5b7bc35 <String[1]: x>
40 e598c017 ldr ip, [r8, #+23]
44 e52dc004 str ip, [sp, #-4]!
48 e1a0e00f mov lr, pc
52 e59ff048 ldr pc, [pc, #+72] ;; debug: statement 0
;; code: STORE_IC, UNINITIALIZED
56 e58d0000 str r0, [sp, #+0]
Review URL: http://codereview.chromium.org/305005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-20 13:37:26 +00:00
|
|
|
if (source.is_temporary()) {
|
|
|
|
if (destination.is_temporary()) {
|
|
|
|
// Case 'temp1 <- (var = temp0)'. Preserve right-hand-side temporary
|
|
|
|
// on the stack.
|
|
|
|
__ movq(kScratchRegister, Operand(rsp, 0));
|
|
|
|
__ movq(Operand(rbp, SlotOffset(var->slot())), kScratchRegister);
|
|
|
|
} else {
|
|
|
|
ASSERT(destination.is_nowhere());
|
|
|
|
// Case 'var = temp'. Discard right-hand-side temporary.
|
|
|
|
__ pop(Operand(rbp, SlotOffset(var->slot())));
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
ASSERT(source.is_constant());
|
|
|
|
ASSERT(rhs->AsLiteral() != NULL);
|
|
|
|
// Two cases: 'temp <- (var = constant)', or 'var = constant' with a
|
|
|
|
// discarded result. Always perform the assignment.
|
|
|
|
__ Move(kScratchRegister, rhs->AsLiteral()->handle());
|
|
|
|
__ movq(Operand(rbp, SlotOffset(var->slot())), kScratchRegister);
|
|
|
|
if (destination.is_temporary()) {
|
|
|
|
// Case 'temp <- (var = constant)'. Save result.
|
|
|
|
__ push(kScratchRegister);
|
|
|
|
}
|
2009-10-19 10:36:42 +00:00
|
|
|
}
|
Added first support for tracking locations of expressions in the
fast-mode code generator.
AST expression nodes are annotated with a location when doing the
initial syntactic check of the AST. In the current implementation,
expression locations are 'temporary' (ie, allocated to the stack) or
'nowhere' (ie, the expression's value is not needed though it must be
evaluated for side effects).
For the assignment '.result = true' on IA32, we had before (with the
true value already on top of the stack):
32 mov eax,[esp]
35 mov [ebp+0xf4],eax
38 pop eax
Now:
32 pop [ebp+0xf4]
======== On x64, before:
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
Now:
37 pop [rbp-0x18]
======== On ARM, before (with the true value in register ip):
36 str ip, [sp, #-4]!
40 ldr ip, [sp, #+0]
44 str ip, [fp, #-12]
48 add sp, sp, #4
Now:
36 str ip, [fp, #-12]
Review URL: http://codereview.chromium.org/267118
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3076 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 16:42:22 +00:00
|
|
|
}
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-10-21 09:17:39 +00:00
|
|
|
void FastCodeGenerator::VisitCall(Call* expr) {
|
|
|
|
Expression* fun = expr->expression();
|
|
|
|
ZoneList<Expression*>* args = expr->arguments();
|
|
|
|
Variable* var = fun->AsVariableProxy()->AsVariable();
|
|
|
|
ASSERT(var != NULL && !var->is_this() && var->is_global());
|
|
|
|
ASSERT(!var->is_possibly_eval());
|
|
|
|
|
|
|
|
__ Push(var->name());
|
|
|
|
// Push global object (receiver).
|
|
|
|
__ push(CodeGenerator::GlobalObject());
|
|
|
|
int arg_count = args->length();
|
|
|
|
for (int i = 0; i < arg_count; i++) {
|
|
|
|
Visit(args->at(i));
|
|
|
|
ASSERT(!args->at(i)->location().is_nowhere());
|
|
|
|
if (args->at(i)->location().is_constant()) {
|
|
|
|
ASSERT(args->at(i)->AsLiteral() != NULL);
|
|
|
|
__ Push(args->at(i)->AsLiteral()->handle());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Record source position for debugger
|
|
|
|
SetSourcePosition(expr->position());
|
|
|
|
// Call the IC initialization code.
|
|
|
|
Handle<Code> ic = CodeGenerator::ComputeCallInitialize(arg_count,
|
|
|
|
NOT_IN_LOOP);
|
|
|
|
__ call(ic, RelocInfo::CODE_TARGET_CONTEXT);
|
|
|
|
// Restore context register.
|
|
|
|
__ movq(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
|
|
|
|
// Discard the function left on TOS.
|
|
|
|
if (expr->location().is_temporary()) {
|
|
|
|
__ movq(Operand(rsp, 0), rax);
|
|
|
|
} else {
|
|
|
|
ASSERT(expr->location().is_nowhere());
|
|
|
|
__ pop(rax);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
void FastCodeGenerator::VisitCallRuntime(CallRuntime* expr) {
|
|
|
|
Comment cmnt(masm_, "[ CallRuntime");
|
|
|
|
ZoneList<Expression*>* args = expr->arguments();
|
|
|
|
Runtime::Function* function = expr->function();
|
|
|
|
|
|
|
|
ASSERT(function != NULL);
|
|
|
|
|
|
|
|
// Push the arguments ("left-to-right").
|
|
|
|
int arg_count = args->length();
|
|
|
|
for (int i = 0; i < arg_count; i++) {
|
|
|
|
Visit(args->at(i));
|
|
|
|
ASSERT(!args->at(i)->location().is_nowhere());
|
|
|
|
if (args->at(i)->location().is_constant()) {
|
|
|
|
ASSERT(args->at(i)->AsLiteral() != NULL);
|
|
|
|
__ Push(args->at(i)->AsLiteral()->handle());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
__ CallRuntime(function, arg_count);
|
|
|
|
if (expr->location().is_temporary()) {
|
|
|
|
__ push(rax);
|
|
|
|
} else {
|
|
|
|
ASSERT(expr->location().is_nowhere());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
Port the initial fast code generator to x64. For the constant true in
top-level code we generate:
0 push rbp
1 movq rbp,rsp
4 push rsi
5 push rdi
6 push [r13+0x8]
10 cmpq rsp,[r13+0x0]
14 jnc 25 (0x7ff2c378ff19)
20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0
25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true>
35 push r10
37 movq rax,[rsp]
41 movq [rbp-0x18],rax
45 pop rax
46 push [rbp-0x18]
50 pop rax
51 movq rsp,rbp ;; js return
54 pop rbp
55 ret 0x8
58 int3
59 int3
60 int3
61 int3
62 int3
63 int3
64 movq rax,[r13+0x8]
68 movq rsp,rbp ;; js return
71 pop rbp
72 ret 0x8
75 int3
76 int3
77 int3
78 int3
79 int3
80 int3
Review URL: http://codereview.chromium.org/264066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-10-15 11:21:26 +00:00
|
|
|
} } // namespace v8::internal
|