2014-08-14 09:07:58 +00:00
|
|
|
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file.
|
|
|
|
|
2014-09-09 14:18:17 +00:00
|
|
|
#include <limits>
|
|
|
|
|
2014-08-14 09:07:58 +00:00
|
|
|
#include "src/base/bits.h"
|
|
|
|
#include "src/base/macros.h"
|
|
|
|
#include "testing/gtest-support.h"
|
|
|
|
|
2014-09-02 13:36:35 +00:00
|
|
|
#ifdef DEBUG
|
|
|
|
#define DISABLE_IN_RELEASE(Name) Name
|
|
|
|
#else
|
|
|
|
#define DISABLE_IN_RELEASE(Name) DISABLED_##Name
|
|
|
|
#endif
|
|
|
|
|
2014-08-14 09:07:58 +00:00
|
|
|
namespace v8 {
|
|
|
|
namespace base {
|
|
|
|
namespace bits {
|
|
|
|
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
TEST(Bits, CountPopulation16) {
|
|
|
|
EXPECT_EQ(0u, CountPopulation(uint16_t{0}));
|
|
|
|
EXPECT_EQ(1u, CountPopulation(uint16_t{1}));
|
|
|
|
EXPECT_EQ(4u, CountPopulation(uint16_t{0x1111}));
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(8u, CountPopulation(uint16_t{0xF0F0}));
|
|
|
|
EXPECT_EQ(12u, CountPopulation(uint16_t{0xF0FF}));
|
|
|
|
EXPECT_EQ(16u, CountPopulation(uint16_t{0xFFFF}));
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
}
|
|
|
|
|
2014-09-02 13:36:35 +00:00
|
|
|
TEST(Bits, CountPopulation32) {
|
2017-10-18 15:32:55 +00:00
|
|
|
EXPECT_EQ(0u, CountPopulation(uint32_t{0}));
|
|
|
|
EXPECT_EQ(1u, CountPopulation(uint32_t{1}));
|
|
|
|
EXPECT_EQ(8u, CountPopulation(uint32_t{0x11111111}));
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(16u, CountPopulation(uint32_t{0xF0F0F0F0}));
|
|
|
|
EXPECT_EQ(24u, CountPopulation(uint32_t{0xFFF0F0FF}));
|
|
|
|
EXPECT_EQ(32u, CountPopulation(uint32_t{0xFFFFFFFF}));
|
2014-08-20 12:10:41 +00:00
|
|
|
}
|
|
|
|
|
2014-10-09 09:18:31 +00:00
|
|
|
TEST(Bits, CountPopulation64) {
|
2017-10-18 15:32:55 +00:00
|
|
|
EXPECT_EQ(0u, CountPopulation(uint64_t{0}));
|
|
|
|
EXPECT_EQ(1u, CountPopulation(uint64_t{1}));
|
|
|
|
EXPECT_EQ(2u, CountPopulation(uint64_t{0x8000000000000001}));
|
|
|
|
EXPECT_EQ(8u, CountPopulation(uint64_t{0x11111111}));
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(16u, CountPopulation(uint64_t{0xF0F0F0F0}));
|
|
|
|
EXPECT_EQ(24u, CountPopulation(uint64_t{0xFFF0F0FF}));
|
|
|
|
EXPECT_EQ(32u, CountPopulation(uint64_t{0xFFFFFFFF}));
|
2017-10-18 15:32:55 +00:00
|
|
|
EXPECT_EQ(16u, CountPopulation(uint64_t{0x1111111111111111}));
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(32u, CountPopulation(uint64_t{0xF0F0F0F0F0F0F0F0}));
|
|
|
|
EXPECT_EQ(48u, CountPopulation(uint64_t{0xFFF0F0FFFFF0F0FF}));
|
|
|
|
EXPECT_EQ(64u, CountPopulation(uint64_t{0xFFFFFFFFFFFFFFFF}));
|
2014-10-09 09:18:31 +00:00
|
|
|
}
|
|
|
|
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
TEST(Bits, CountLeadingZeros16) {
|
|
|
|
EXPECT_EQ(16u, CountLeadingZeros(uint16_t{0}));
|
|
|
|
EXPECT_EQ(15u, CountLeadingZeros(uint16_t{1}));
|
|
|
|
TRACED_FORRANGE(uint16_t, shift, 0, 15) {
|
|
|
|
EXPECT_EQ(15u - shift,
|
|
|
|
CountLeadingZeros(static_cast<uint16_t>(1 << shift)));
|
|
|
|
}
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(4u, CountLeadingZeros(uint16_t{0x0F0F}));
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
}
|
2014-10-09 09:18:31 +00:00
|
|
|
|
2014-09-02 13:36:35 +00:00
|
|
|
TEST(Bits, CountLeadingZeros32) {
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
EXPECT_EQ(32u, CountLeadingZeros(uint32_t{0}));
|
|
|
|
EXPECT_EQ(31u, CountLeadingZeros(uint32_t{1}));
|
2014-08-20 12:10:41 +00:00
|
|
|
TRACED_FORRANGE(uint32_t, shift, 0, 31) {
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
EXPECT_EQ(31u - shift, CountLeadingZeros(uint32_t{1} << shift));
|
2014-08-20 12:10:41 +00:00
|
|
|
}
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(4u, CountLeadingZeros(uint32_t{0x0F0F0F0F}));
|
2014-08-20 12:10:41 +00:00
|
|
|
}
|
|
|
|
|
2014-10-09 09:18:31 +00:00
|
|
|
TEST(Bits, CountLeadingZeros64) {
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
EXPECT_EQ(64u, CountLeadingZeros(uint64_t{0}));
|
|
|
|
EXPECT_EQ(63u, CountLeadingZeros(uint64_t{1}));
|
2014-10-09 09:18:31 +00:00
|
|
|
TRACED_FORRANGE(uint32_t, shift, 0, 63) {
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
EXPECT_EQ(63u - shift, CountLeadingZeros(uint64_t{1} << shift));
|
2014-10-09 09:18:31 +00:00
|
|
|
}
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(36u, CountLeadingZeros(uint64_t{0x0F0F0F0F}));
|
|
|
|
EXPECT_EQ(4u, CountLeadingZeros(uint64_t{0x0F0F0F0F00000000}));
|
2014-10-09 09:18:31 +00:00
|
|
|
}
|
|
|
|
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
TEST(Bits, CountTrailingZeros16) {
|
|
|
|
EXPECT_EQ(16u, CountTrailingZeros(uint16_t{0}));
|
|
|
|
EXPECT_EQ(15u, CountTrailingZeros(uint16_t{0x8000}));
|
|
|
|
TRACED_FORRANGE(uint16_t, shift, 0, 15) {
|
|
|
|
EXPECT_EQ(shift, CountTrailingZeros(static_cast<uint16_t>(1 << shift)));
|
|
|
|
}
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(4u, CountTrailingZeros(uint16_t{0xF0F0u}));
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
}
|
2014-10-09 09:18:31 +00:00
|
|
|
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
TEST(Bits, CountTrailingZerosu32) {
|
|
|
|
EXPECT_EQ(32u, CountTrailingZeros(uint32_t{0}));
|
|
|
|
EXPECT_EQ(31u, CountTrailingZeros(uint32_t{0x80000000}));
|
2014-08-20 12:10:41 +00:00
|
|
|
TRACED_FORRANGE(uint32_t, shift, 0, 31) {
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
EXPECT_EQ(shift, CountTrailingZeros(uint32_t{1} << shift));
|
2014-08-20 12:10:41 +00:00
|
|
|
}
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(4u, CountTrailingZeros(uint32_t{0xF0F0F0F0u}));
|
2014-08-20 12:10:41 +00:00
|
|
|
}
|
|
|
|
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
TEST(Bits, CountTrailingZerosi32) {
|
|
|
|
EXPECT_EQ(32u, CountTrailingZeros(int32_t{0}));
|
|
|
|
TRACED_FORRANGE(uint32_t, shift, 0, 31) {
|
|
|
|
EXPECT_EQ(shift, CountTrailingZeros(int32_t{1} << shift));
|
|
|
|
}
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(4u, CountTrailingZeros(int32_t{0x70F0F0F0u}));
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
EXPECT_EQ(2u, CountTrailingZeros(int32_t{-4}));
|
|
|
|
EXPECT_EQ(0u, CountTrailingZeros(int32_t{-1}));
|
|
|
|
}
|
2014-08-20 12:10:41 +00:00
|
|
|
|
2014-10-09 09:18:31 +00:00
|
|
|
TEST(Bits, CountTrailingZeros64) {
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
EXPECT_EQ(64u, CountTrailingZeros(uint64_t{0}));
|
|
|
|
EXPECT_EQ(63u, CountTrailingZeros(uint64_t{0x8000000000000000}));
|
2014-10-09 09:18:31 +00:00
|
|
|
TRACED_FORRANGE(uint32_t, shift, 0, 63) {
|
Reland "[bits] Consolidate Count{Leading,Trailing}Zeros"
This is a reland of 7d231e576a6ffd651041094ba10bc5b39777528c, fixed to
avoid instantiating CountLeadingZeros for bits==0.
Original change's description:
> [bits] Consolidate Count{Leading,Trailing}Zeros
>
> Instead of having one method for 32 bit integers and one for 64 bit,
> plus a templatized version to choose from those two, just implement one
> version which handles unsigned integers of any size. Also, make them
> constexpr.
> The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
> order to keep the amount of code changes small. Also, sometimes it
> improves readability by stating exactly the size of the argument,
> especially for leading zeros (where zero-extending would add more
> leading zeros).
>
> CountLeadingZeros now uses a binary search inspired implementation
> as proposed in Hacker's Delight. It's more than 20% faster on x64 if
> the builtins are disabled.
> CountTrailingZeros falls back to CountPopulation instead of counting in
> a naive loop. This is ~50% faster.
>
> R=mstarzinger@chromium.org
>
> Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
> Reviewed-on: https://chromium-review.googlesource.com/741231
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49106}
Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
Reviewed-on: https://chromium-review.googlesource.com/753903
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49138}
2017-11-06 11:09:53 +00:00
|
|
|
EXPECT_EQ(shift, CountTrailingZeros(uint64_t{1} << shift));
|
2014-10-09 09:18:31 +00:00
|
|
|
}
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(4u, CountTrailingZeros(uint64_t{0xF0F0F0F0}));
|
|
|
|
EXPECT_EQ(36u, CountTrailingZeros(uint64_t{0xF0F0F0F000000000}));
|
2014-10-09 09:18:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-09-02 13:36:35 +00:00
|
|
|
TEST(Bits, IsPowerOfTwo32) {
|
2017-07-12 13:59:52 +00:00
|
|
|
EXPECT_FALSE(IsPowerOfTwo(0U));
|
2014-09-02 13:36:35 +00:00
|
|
|
TRACED_FORRANGE(uint32_t, shift, 0, 31) {
|
2017-07-12 13:59:52 +00:00
|
|
|
EXPECT_TRUE(IsPowerOfTwo(1U << shift));
|
|
|
|
EXPECT_FALSE(IsPowerOfTwo((1U << shift) + 5U));
|
|
|
|
EXPECT_FALSE(IsPowerOfTwo(~(1U << shift)));
|
2014-09-02 13:36:35 +00:00
|
|
|
}
|
|
|
|
TRACED_FORRANGE(uint32_t, shift, 2, 31) {
|
2017-07-12 13:59:52 +00:00
|
|
|
EXPECT_FALSE(IsPowerOfTwo((1U << shift) - 1U));
|
2014-09-02 13:36:35 +00:00
|
|
|
}
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_FALSE(IsPowerOfTwo(0xFFFFFFFF));
|
2014-09-02 13:36:35 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(Bits, IsPowerOfTwo64) {
|
2017-12-01 08:58:16 +00:00
|
|
|
EXPECT_FALSE(IsPowerOfTwo(uint64_t{0}));
|
2014-09-02 13:36:35 +00:00
|
|
|
TRACED_FORRANGE(uint32_t, shift, 0, 63) {
|
2017-12-01 08:58:16 +00:00
|
|
|
EXPECT_TRUE(IsPowerOfTwo(uint64_t{1} << shift));
|
|
|
|
EXPECT_FALSE(IsPowerOfTwo((uint64_t{1} << shift) + 5U));
|
|
|
|
EXPECT_FALSE(IsPowerOfTwo(~(uint64_t{1} << shift)));
|
2014-09-02 13:36:35 +00:00
|
|
|
}
|
|
|
|
TRACED_FORRANGE(uint32_t, shift, 2, 63) {
|
2017-12-01 08:58:16 +00:00
|
|
|
EXPECT_FALSE(IsPowerOfTwo((uint64_t{1} << shift) - 1U));
|
2014-09-02 13:36:35 +00:00
|
|
|
}
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_FALSE(IsPowerOfTwo(uint64_t{0xFFFFFFFFFFFFFFFF}));
|
2014-09-02 13:36:35 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(Bits, RoundUpToPowerOfTwo32) {
|
|
|
|
TRACED_FORRANGE(uint32_t, shift, 0, 31) {
|
|
|
|
EXPECT_EQ(1u << shift, RoundUpToPowerOfTwo32(1u << shift));
|
|
|
|
}
|
2017-04-27 16:16:53 +00:00
|
|
|
EXPECT_EQ(1u, RoundUpToPowerOfTwo32(0));
|
|
|
|
EXPECT_EQ(1u, RoundUpToPowerOfTwo32(1));
|
2014-09-02 13:36:35 +00:00
|
|
|
EXPECT_EQ(4u, RoundUpToPowerOfTwo32(3));
|
2017-12-02 00:30:37 +00:00
|
|
|
EXPECT_EQ(0x80000000u, RoundUpToPowerOfTwo32(0x7FFFFFFFu));
|
2014-09-02 13:36:35 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(BitsDeathTest, DISABLE_IN_RELEASE(RoundUpToPowerOfTwo32)) {
|
2014-09-02 15:22:36 +00:00
|
|
|
ASSERT_DEATH_IF_SUPPORTED({ RoundUpToPowerOfTwo32(0x80000001u); },
|
2017-07-10 19:46:48 +00:00
|
|
|
".*heck failed:.* << 31");
|
2017-04-27 16:16:53 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST(Bits, RoundUpToPowerOfTwo64) {
|
|
|
|
TRACED_FORRANGE(uint64_t, shift, 0, 63) {
|
|
|
|
uint64_t value = uint64_t{1} << shift;
|
|
|
|
EXPECT_EQ(value, RoundUpToPowerOfTwo64(value));
|
|
|
|
}
|
|
|
|
EXPECT_EQ(uint64_t{1}, RoundUpToPowerOfTwo64(0));
|
|
|
|
EXPECT_EQ(uint64_t{1}, RoundUpToPowerOfTwo64(1));
|
|
|
|
EXPECT_EQ(uint64_t{4}, RoundUpToPowerOfTwo64(3));
|
|
|
|
EXPECT_EQ(uint64_t{1} << 63, RoundUpToPowerOfTwo64((uint64_t{1} << 63) - 1));
|
|
|
|
EXPECT_EQ(uint64_t{1} << 63, RoundUpToPowerOfTwo64(uint64_t{1} << 63));
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(BitsDeathTest, DISABLE_IN_RELEASE(RoundUpToPowerOfTwo64)) {
|
|
|
|
ASSERT_DEATH_IF_SUPPORTED({ RoundUpToPowerOfTwo64((uint64_t{1} << 63) + 1); },
|
2017-07-10 19:46:48 +00:00
|
|
|
".*heck failed:.* << 63");
|
2014-09-02 13:36:35 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(Bits, RoundDownToPowerOfTwo32) {
|
|
|
|
TRACED_FORRANGE(uint32_t, shift, 0, 31) {
|
|
|
|
EXPECT_EQ(1u << shift, RoundDownToPowerOfTwo32(1u << shift));
|
|
|
|
}
|
|
|
|
EXPECT_EQ(0u, RoundDownToPowerOfTwo32(0));
|
|
|
|
EXPECT_EQ(4u, RoundDownToPowerOfTwo32(5));
|
|
|
|
EXPECT_EQ(0x80000000u, RoundDownToPowerOfTwo32(0x80000001u));
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(Bits, RotateRight32) {
|
2014-08-14 09:07:58 +00:00
|
|
|
TRACED_FORRANGE(uint32_t, shift, 0, 31) {
|
|
|
|
EXPECT_EQ(0u, RotateRight32(0u, shift));
|
|
|
|
}
|
|
|
|
EXPECT_EQ(1u, RotateRight32(1, 0));
|
|
|
|
EXPECT_EQ(1u, RotateRight32(2, 1));
|
|
|
|
EXPECT_EQ(0x80000000u, RotateRight32(1, 1));
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-09-02 13:36:35 +00:00
|
|
|
TEST(Bits, RotateRight64) {
|
2014-08-14 09:07:58 +00:00
|
|
|
TRACED_FORRANGE(uint64_t, shift, 0, 63) {
|
|
|
|
EXPECT_EQ(0u, RotateRight64(0u, shift));
|
|
|
|
}
|
|
|
|
EXPECT_EQ(1u, RotateRight64(1, 0));
|
|
|
|
EXPECT_EQ(1u, RotateRight64(2, 1));
|
2017-12-01 08:58:16 +00:00
|
|
|
EXPECT_EQ(uint64_t{0x8000000000000000}, RotateRight64(1, 1));
|
2014-08-14 09:07:58 +00:00
|
|
|
}
|
|
|
|
|
2014-09-09 14:18:17 +00:00
|
|
|
|
|
|
|
TEST(Bits, SignedAddOverflow32) {
|
|
|
|
int32_t val = 0;
|
|
|
|
EXPECT_FALSE(SignedAddOverflow32(0, 0, &val));
|
|
|
|
EXPECT_EQ(0, val);
|
|
|
|
EXPECT_TRUE(
|
|
|
|
SignedAddOverflow32(std::numeric_limits<int32_t>::max(), 1, &val));
|
|
|
|
EXPECT_EQ(std::numeric_limits<int32_t>::min(), val);
|
|
|
|
EXPECT_TRUE(
|
|
|
|
SignedAddOverflow32(std::numeric_limits<int32_t>::min(), -1, &val));
|
|
|
|
EXPECT_EQ(std::numeric_limits<int32_t>::max(), val);
|
|
|
|
EXPECT_TRUE(SignedAddOverflow32(std::numeric_limits<int32_t>::max(),
|
|
|
|
std::numeric_limits<int32_t>::max(), &val));
|
|
|
|
EXPECT_EQ(-2, val);
|
|
|
|
TRACED_FORRANGE(int32_t, i, 1, 50) {
|
|
|
|
TRACED_FORRANGE(int32_t, j, 1, i) {
|
|
|
|
EXPECT_FALSE(SignedAddOverflow32(i, j, &val));
|
|
|
|
EXPECT_EQ(i + j, val);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(Bits, SignedSubOverflow32) {
|
|
|
|
int32_t val = 0;
|
|
|
|
EXPECT_FALSE(SignedSubOverflow32(0, 0, &val));
|
|
|
|
EXPECT_EQ(0, val);
|
|
|
|
EXPECT_TRUE(
|
|
|
|
SignedSubOverflow32(std::numeric_limits<int32_t>::min(), 1, &val));
|
|
|
|
EXPECT_EQ(std::numeric_limits<int32_t>::max(), val);
|
|
|
|
EXPECT_TRUE(
|
|
|
|
SignedSubOverflow32(std::numeric_limits<int32_t>::max(), -1, &val));
|
|
|
|
EXPECT_EQ(std::numeric_limits<int32_t>::min(), val);
|
|
|
|
TRACED_FORRANGE(int32_t, i, 1, 50) {
|
|
|
|
TRACED_FORRANGE(int32_t, j, 1, i) {
|
|
|
|
EXPECT_FALSE(SignedSubOverflow32(i, j, &val));
|
|
|
|
EXPECT_EQ(i - j, val);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-10-14 05:03:04 +00:00
|
|
|
|
|
|
|
TEST(Bits, SignedMulHigh32) {
|
|
|
|
EXPECT_EQ(0, SignedMulHigh32(0, 0));
|
|
|
|
TRACED_FORRANGE(int32_t, i, 1, 50) {
|
|
|
|
TRACED_FORRANGE(int32_t, j, 1, i) { EXPECT_EQ(0, SignedMulHigh32(i, j)); }
|
|
|
|
}
|
|
|
|
EXPECT_EQ(-1073741824, SignedMulHigh32(std::numeric_limits<int32_t>::max(),
|
|
|
|
std::numeric_limits<int32_t>::min()));
|
|
|
|
EXPECT_EQ(-1073741824, SignedMulHigh32(std::numeric_limits<int32_t>::min(),
|
|
|
|
std::numeric_limits<int32_t>::max()));
|
|
|
|
EXPECT_EQ(1, SignedMulHigh32(1024 * 1024 * 1024, 4));
|
|
|
|
EXPECT_EQ(2, SignedMulHigh32(8 * 1024, 1024 * 1024));
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(Bits, SignedMulHighAndAdd32) {
|
|
|
|
TRACED_FORRANGE(int32_t, i, 1, 50) {
|
|
|
|
EXPECT_EQ(i, SignedMulHighAndAdd32(0, 0, i));
|
|
|
|
TRACED_FORRANGE(int32_t, j, 1, i) {
|
|
|
|
EXPECT_EQ(i, SignedMulHighAndAdd32(j, j, i));
|
|
|
|
}
|
|
|
|
EXPECT_EQ(i + 1, SignedMulHighAndAdd32(1024 * 1024 * 1024, 4, i));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-10-26 12:49:56 +00:00
|
|
|
|
|
|
|
TEST(Bits, SignedDiv32) {
|
|
|
|
EXPECT_EQ(std::numeric_limits<int32_t>::min(),
|
|
|
|
SignedDiv32(std::numeric_limits<int32_t>::min(), -1));
|
|
|
|
EXPECT_EQ(std::numeric_limits<int32_t>::max(),
|
|
|
|
SignedDiv32(std::numeric_limits<int32_t>::max(), 1));
|
|
|
|
TRACED_FORRANGE(int32_t, i, 0, 50) {
|
|
|
|
EXPECT_EQ(0, SignedDiv32(i, 0));
|
|
|
|
TRACED_FORRANGE(int32_t, j, 1, i) {
|
|
|
|
EXPECT_EQ(1, SignedDiv32(j, j));
|
|
|
|
EXPECT_EQ(i / j, SignedDiv32(i, j));
|
|
|
|
EXPECT_EQ(-i / j, SignedDiv32(i, -j));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(Bits, SignedMod32) {
|
|
|
|
EXPECT_EQ(0, SignedMod32(std::numeric_limits<int32_t>::min(), -1));
|
|
|
|
EXPECT_EQ(0, SignedMod32(std::numeric_limits<int32_t>::max(), 1));
|
|
|
|
TRACED_FORRANGE(int32_t, i, 0, 50) {
|
|
|
|
EXPECT_EQ(0, SignedMod32(i, 0));
|
|
|
|
TRACED_FORRANGE(int32_t, j, 1, i) {
|
|
|
|
EXPECT_EQ(0, SignedMod32(j, j));
|
|
|
|
EXPECT_EQ(i % j, SignedMod32(i, j));
|
|
|
|
EXPECT_EQ(i % j, SignedMod32(i, -j));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-06-12 12:03:03 +00:00
|
|
|
TEST(Bits, UnsignedAddOverflow32) {
|
|
|
|
uint32_t val = 0;
|
|
|
|
EXPECT_FALSE(UnsignedAddOverflow32(0, 0, &val));
|
|
|
|
EXPECT_EQ(0u, val);
|
|
|
|
EXPECT_TRUE(
|
|
|
|
UnsignedAddOverflow32(std::numeric_limits<uint32_t>::max(), 1u, &val));
|
|
|
|
EXPECT_EQ(std::numeric_limits<uint32_t>::min(), val);
|
|
|
|
EXPECT_TRUE(UnsignedAddOverflow32(std::numeric_limits<uint32_t>::max(),
|
|
|
|
std::numeric_limits<uint32_t>::max(),
|
|
|
|
&val));
|
|
|
|
TRACED_FORRANGE(uint32_t, i, 1, 50) {
|
|
|
|
TRACED_FORRANGE(uint32_t, j, 1, i) {
|
|
|
|
EXPECT_FALSE(UnsignedAddOverflow32(i, j, &val));
|
|
|
|
EXPECT_EQ(i + j, val);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-10-26 12:49:56 +00:00
|
|
|
TEST(Bits, UnsignedDiv32) {
|
|
|
|
TRACED_FORRANGE(uint32_t, i, 0, 50) {
|
|
|
|
EXPECT_EQ(0u, UnsignedDiv32(i, 0));
|
|
|
|
TRACED_FORRANGE(uint32_t, j, i + 1, 100) {
|
|
|
|
EXPECT_EQ(1u, UnsignedDiv32(j, j));
|
|
|
|
EXPECT_EQ(i / j, UnsignedDiv32(i, j));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(Bits, UnsignedMod32) {
|
|
|
|
TRACED_FORRANGE(uint32_t, i, 0, 50) {
|
|
|
|
EXPECT_EQ(0u, UnsignedMod32(i, 0));
|
|
|
|
TRACED_FORRANGE(uint32_t, j, i + 1, 100) {
|
|
|
|
EXPECT_EQ(0u, UnsignedMod32(j, j));
|
|
|
|
EXPECT_EQ(i % j, UnsignedMod32(i, j));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-08-14 09:07:58 +00:00
|
|
|
} // namespace bits
|
|
|
|
} // namespace base
|
|
|
|
} // namespace v8
|