AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
3eb6b7aca6
v8/tools/v8heapconst.py

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

596 lines
27 KiB
Python
Raw Normal View History

Remove always-true --harmony-symbol-description runtime flag It shipped in Chrome 70. Bug: v8:7807, v8:8562 Change-Id: I5c5a9fc23656018ee6e9115af7a0c779230e681b Reviewed-on: https://chromium-review.googlesource.com/c/1450787 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#59589}
2019-02-14 10:00:15 +00:00
# Copyright 2019 the V8 project authors. All rights reserved.
[tools] Improve grokdump.py - Add new address markers: T: tagged pointer in the minidump C: address into a module in the minidump S: pointer into the exception stack in the minidump *: other address in the minidump - Show ASCII decoding of address in dd - Display potential frame markers on the exception stack: 00000032212fdae8: 0000000300000000 ........ Smi(3) EXIT frame marker - Display relative addresses, useful to detect stack frames: 00000032212fdb68: 00000032212fdb98 S ........ [+6]=00000032212fdcb0 S 00000032212fdb70: 0000010ff5ca0a84 ........ 00000032212fdb78: 000001064c1fa881 ........ 00000032212fdb80: 0000016a8e52fcb1 ........ 00000032212fdb88: 0000010ff5ca0981 ........ 00000032212fdb90: 0000000d00000000 ........ Smi(13) INTERNAL frame marker 00000032212fdb98: 00000032212fdcb0 S ........ [+35]=00000032212fdd61 S Change-Id: I56bd7e6723a34bcb668719246dd5ff2898224928 Reviewed-on: https://chromium-review.googlesource.com/461862 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#44269}
2017-03-30 11:44:00 +00:00
# Use of this source code is governed by a BSD-style license that can
# be found in the LICENSE file.
Generate grokdump constants with 'make grokdump' now. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/21771002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16022 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-02 09:02:02 +00:00
Introduce mkgrokdump to update tools/v8heapconst.py. - Migrate make grokdump to GYP and GN - Move code from d8 into stand-alone execution - Add test case to ensure it's up-to-date Review-Url: https://codereview.chromium.org/2809653003 Cr-Original-Original-Commit-Position: refs/heads/master@{#44687} Committed: https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df5e42a Review-Url: https://codereview.chromium.org/2809653003 Cr-Original-Commit-Position: refs/heads/master@{#44710} Committed: https://chromium.googlesource.com/v8/v8/+/477f00557458d383bd9ebef281890ba485ee882a Review-Url: https://codereview.chromium.org/2809653003 Cr-Commit-Position: refs/heads/master@{#44738}
2017-04-20 06:14:53 +00:00
# This file is automatically generated by mkgrokdump and should not
# be modified manually.
Generate grokdump constants with 'make grokdump' now. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/21771002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16022 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-02 09:02:02 +00:00
# List of known V8 instance types.
[runtime] Add ReadOnlyRoots.empty_array_list() - Simplify HeapObject::IsArrayList check - Dehandlify ArrayList initialization - Prevent auto-formatting of v8heapconst.py Change-Id: I9849ad82dae1a2dc671433e8d5eb8ec63ed830c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447906 Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79114}
2022-02-15 22:18:48 +00:00
# yapf: disable
Generate grokdump constants with 'make grokdump' now. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/21771002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16022 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-02 09:02:02 +00:00
INSTANCE_TYPES = {
Update heap constants R=ishell@chromium.org BUG= Review-Url: https://codereview.chromium.org/2590923002 Cr-Commit-Position: refs/heads/master@{#41865}
2016-12-20 15:26:08 +00:00
0: "INTERNALIZED_STRING_TYPE",
2: "EXTERNAL_INTERNALIZED_STRING_TYPE",
[grokdump] Update grokdump to decode new map layouts, and dump-heap-constants to 512kb pages BUG= Change-Id: I5e60705764b8ea20b171981cdd44d57a928fa34d Reviewed-on: https://chromium-review.googlesource.com/461178 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#44188}
2017-03-28 08:44:17 +00:00
8: "ONE_BYTE_INTERNALIZED_STRING_TYPE",
10: "EXTERNAL_ONE_BYTE_INTERNALIZED_STRING_TYPE",
Revert "[objects] Remove uncached internal external string type" This reverts commit b3d09001eb012ebf75816f5be51a2b1db47e55f2. Reason for revert: https://chromium-review.googlesource.com/c/v8/v8/+/2565511 has to be reverted, and this was a follow-up to that Original change's description: > [objects] Remove uncached internal external string type > > We shouldn't be creating those anymore since they are not thread-safe. > > Bug: v8:7790 > Change-Id: I4546d995fa32eb076c8dfe9d95301fad719c9e07 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2615347 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72006} TBR=rmcilroy@chromium.org,leszeks@chromium.org,solanes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7790 Change-Id: I4eb1a6b8446fa602eeb5bf29fbf1fe57182cdbf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2627605 Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#72122}
2021-01-14 15:12:09 +00:00
18: "UNCACHED_EXTERNAL_INTERNALIZED_STRING_TYPE",
26: "UNCACHED_EXTERNAL_ONE_BYTE_INTERNALIZED_STRING_TYPE",
[cleanup] Remove obsolete "one byte data hint" for strings. In the early days of Chrome when we used WebKit there was no support for ASCII strings on the C++ side, so we put a hint onto these two-byte strings that said "string only contains one byte data", such that internally in V8 when these were involved in string operations, we could instead create the *cheaper* one byte strings. Nowadays Blink properly supports one-byte string representations and this additional hint only comes with overhead, since we check it in quite a few places (i.e. on the hot path for string concatenation), plus we end up consuming more memory due to the additional string maps. Removing the hint also frees one bit in the InstanceType zoo for strings. This alone improves performance on the `bench-dom-serialize.js` test case by around **3%**. Tbr: mstarzinger@chromium.org Bug: v8:6622, v8:8834, v8:8939 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: I0753f2859cee7b5a37b6f0da64d8ec39fcb044ff Doc: https://bit.ly/fast-string-concatenation-in-javascript Reviewed-on: https://chromium-review.googlesource.com/c/1498478 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60006}
2019-03-04 12:55:22 +00:00
32: "STRING_TYPE",
33: "CONS_STRING_TYPE",
34: "EXTERNAL_STRING_TYPE",
35: "SLICED_STRING_TYPE",
37: "THIN_STRING_TYPE",
40: "ONE_BYTE_STRING_TYPE",
41: "CONS_ONE_BYTE_STRING_TYPE",
42: "EXTERNAL_ONE_BYTE_STRING_TYPE",
43: "SLICED_ONE_BYTE_STRING_TYPE",
45: "THIN_ONE_BYTE_STRING_TYPE",
50: "UNCACHED_EXTERNAL_STRING_TYPE",
58: "UNCACHED_EXTERNAL_ONE_BYTE_STRING_TYPE",
[string] Add a is_shared bit to strings and String::Share The is_shared bit bumps the number of reserved bits for Strings' InstanceType from 6 to 7. This has the side effect of shuffling the InstanceType enum values. There are no users of this bit yet. This is steps 1-2 from the following design doc [1], in preparation for sharing internalized and in-place-internalizable strings. [1] https://docs.google.com/document/d/1c5i8f2EfKIQygGZ23hNiGxouvRISjUMnJjNsOodj6z0/edit?usp=sharing Bug: v8:12007 Change-Id: Idf11a6035305f0375b4f824ffd32a64f6b5b043b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3266017 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77831}
2021-11-10 22:42:10 +00:00
96: "SHARED_STRING_TYPE",
[string] Make String::MakeThin threadsafe for shared strings For shared strings, String::MakeThin is protected by using the map word of the string being migrated as a spinlock. Note that this CL does not make it safe yet to access character data from multiple threads. The spinlock here only protects write-write races in String::MakeThin. For more information, see the following two design docs: https://docs.google.com/document/d/1c5i8f2EfKIQygGZ23hNiGxouvRISjUMnJjNsOodj6z0/edit https://docs.google.com/document/d/1Drzigf17t4ofy0evDmaIL5p0MDZuAl95c9fSeX-QjVg/edit Bug: v8:12007 Change-Id: I9c47412c6ec7360a672b65a8576b4f6156ee5846 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3313429 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78257}
2021-12-06 19:23:51 +00:00
101: "SHARED_THIN_STRING_TYPE",
[string] Add a is_shared bit to strings and String::Share The is_shared bit bumps the number of reserved bits for Strings' InstanceType from 6 to 7. This has the side effect of shuffling the InstanceType enum values. There are no users of this bit yet. This is steps 1-2 from the following design doc [1], in preparation for sharing internalized and in-place-internalizable strings. [1] https://docs.google.com/document/d/1c5i8f2EfKIQygGZ23hNiGxouvRISjUMnJjNsOodj6z0/edit?usp=sharing Bug: v8:12007 Change-Id: Idf11a6035305f0375b4f824ffd32a64f6b5b043b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3266017 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77831}
2021-11-10 22:42:10 +00:00
104: "SHARED_ONE_BYTE_STRING_TYPE",
[string] Make String::MakeThin threadsafe for shared strings For shared strings, String::MakeThin is protected by using the map word of the string being migrated as a spinlock. Note that this CL does not make it safe yet to access character data from multiple threads. The spinlock here only protects write-write races in String::MakeThin. For more information, see the following two design docs: https://docs.google.com/document/d/1c5i8f2EfKIQygGZ23hNiGxouvRISjUMnJjNsOodj6z0/edit https://docs.google.com/document/d/1Drzigf17t4ofy0evDmaIL5p0MDZuAl95c9fSeX-QjVg/edit Bug: v8:12007 Change-Id: I9c47412c6ec7360a672b65a8576b4f6156ee5846 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3313429 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78257}
2021-12-06 19:23:51 +00:00
109: "SHARED_THIN_ONE_BYTE_STRING_TYPE",
[string] Add a is_shared bit to strings and String::Share The is_shared bit bumps the number of reserved bits for Strings' InstanceType from 6 to 7. This has the side effect of shuffling the InstanceType enum values. There are no users of this bit yet. This is steps 1-2 from the following design doc [1], in preparation for sharing internalized and in-place-internalizable strings. [1] https://docs.google.com/document/d/1c5i8f2EfKIQygGZ23hNiGxouvRISjUMnJjNsOodj6z0/edit?usp=sharing Bug: v8:12007 Change-Id: Idf11a6035305f0375b4f824ffd32a64f6b5b043b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3266017 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77831}
2021-11-10 22:42:10 +00:00
128: "SYMBOL_TYPE",
129: "BIG_INT_BASE_TYPE",
130: "HEAP_NUMBER_TYPE",
131: "ODDBALL_TYPE",
132: "PROMISE_FULFILL_REACTION_JOB_TASK_TYPE",
133: "PROMISE_REJECT_REACTION_JOB_TASK_TYPE",
134: "CALLABLE_TASK_TYPE",
135: "CALLBACK_TASK_TYPE",
136: "PROMISE_RESOLVE_THENABLE_JOB_TASK_TYPE",
137: "LOAD_HANDLER_TYPE",
138: "STORE_HANDLER_TYPE",
139: "FUNCTION_TEMPLATE_INFO_TYPE",
140: "OBJECT_TEMPLATE_INFO_TYPE",
141: "ACCESS_CHECK_INFO_TYPE",
142: "ACCESSOR_INFO_TYPE",
143: "ACCESSOR_PAIR_TYPE",
144: "ALIASED_ARGUMENTS_ENTRY_TYPE",
145: "ALLOCATION_MEMENTO_TYPE",
146: "ALLOCATION_SITE_TYPE",
147: "ARRAY_BOILERPLATE_DESCRIPTION_TYPE",
148: "ASM_WASM_DATA_TYPE",
149: "ASYNC_GENERATOR_REQUEST_TYPE",
150: "BREAK_POINT_TYPE",
151: "BREAK_POINT_INFO_TYPE",
152: "CACHED_TEMPLATE_OBJECT_TYPE",
153: "CALL_HANDLER_INFO_TYPE",
[refactor] Rename StackFrameInfo to CallSiteInfo. This is the second step in the refactoring to make v8::StackFrame more lightweight and usable for (long time storage) by the V8 inspector (see https://bit.ly/v8-stack-frame for an overview). This is a purely mechanical change without any functional aspects. The intention is to make the use case for the CallSiteInfo objects clear, namely to serve as the backing store for the CallSite objects exposed via the Error.prepareStackTrace() API and used under the hood to implement the error.stack accessor. Doc: https://bit.ly/v8-stack-frame Bug: chromium:1258599, chromium:1278647, chromium:1278650 Change-Id: I39dffd1f1a8e5158ddc56f2a0a2b1b28321f487a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3300138 Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#78361}
2021-12-14 05:47:56 +00:00
154: "CALL_SITE_INFO_TYPE",
155: "CLASS_POSITIONS_TYPE",
156: "DEBUG_INFO_TYPE",
157: "ENUM_CACHE_TYPE",
[inspector] Capture stack trace only once for JSError objects. When creating a new JSError object (or using the non-standard API `Error.captureStackTrace`) V8 would previously capture the "simple stack trace" (as FixedArray of CallSiteInfo instances) to be used for the non- standard `error.stack` property, and if the inspector was active also capture the "detailed stack trace" (as FixedArray of StackFrameInfo instances). This turns out to be quite a lot of overhead, both in terms of execution time as well as memory pressure, especially since the information needed for the inspector is a proper subset of the information needed by `error.stack`. So this CL addresses the above issue by capturing only the "simple stack trace" (in the common case) and computing the "detailed stack trace" from the "simple stack trace" when on demand. This is accomplished by introducing a new ErrorStackData container that is used to store the stack trace information on JSErrors when the inspector is active. When capturing stack trace for a JSError object while the inspector is active, we take the maximum of the program controlled stack trace limit and the inspector requested stack trace limit, and memorize the program controlled stack trace limit for later formatting (to ensure that the presence of the inspector is not observable by the program). On the `standalone.js` benchmark from crbug.com/1283162 (with the default max call stack size of 200) we reduce execution time by around 16% compared to ToT. And compared to V8 9.9.4 (the version prior to the regression in crbug.com/1280831), we are 6% faster now. Doc: https://bit.ly/v8-cheaper-inspector-stack-traces Bug: chromium:1280831, chromium:1278650, chromium:1258599 Bug: chromium:1280803, chromium:1280832, chromium:1280818 Fixed: chromium:1283162 Change-Id: I57dac73e0ecf7d50ea57c3eb4981067deb28133e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3366660 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#78542}
2022-01-10 06:53:37 +00:00
158: "ERROR_STACK_DATA_TYPE",
159: "FEEDBACK_CELL_TYPE",
160: "FUNCTION_TEMPLATE_RARE_DATA_TYPE",
161: "INTERCEPTOR_INFO_TYPE",
162: "INTERPRETER_DATA_TYPE",
163: "MODULE_REQUEST_TYPE",
164: "PROMISE_CAPABILITY_TYPE",
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
165: "PROMISE_ON_STACK_TYPE",
166: "PROMISE_REACTION_TYPE",
167: "PROPERTY_DESCRIPTOR_OBJECT_TYPE",
168: "PROTOTYPE_INFO_TYPE",
169: "REG_EXP_BOILERPLATE_DESCRIPTION_TYPE",
170: "SCRIPT_TYPE",
171: "SCRIPT_OR_MODULE_TYPE",
172: "SOURCE_TEXT_MODULE_INFO_ENTRY_TYPE",
173: "STACK_FRAME_INFO_TYPE",
174: "TEMPLATE_OBJECT_DESCRIPTION_TYPE",
175: "TUPLE2_TYPE",
176: "WASM_CONTINUATION_OBJECT_TYPE",
177: "WASM_EXCEPTION_TAG_TYPE",
178: "WASM_INDIRECT_FUNCTION_TABLE_TYPE",
179: "FIXED_ARRAY_TYPE",
180: "HASH_TABLE_TYPE",
181: "EPHEMERON_HASH_TABLE_TYPE",
182: "GLOBAL_DICTIONARY_TYPE",
183: "NAME_DICTIONARY_TYPE",
184: "NAME_TO_INDEX_HASH_TABLE_TYPE",
185: "NUMBER_DICTIONARY_TYPE",
186: "ORDERED_HASH_MAP_TYPE",
187: "ORDERED_HASH_SET_TYPE",
188: "ORDERED_NAME_DICTIONARY_TYPE",
189: "REGISTERED_SYMBOL_TABLE_TYPE",
190: "SIMPLE_NUMBER_DICTIONARY_TYPE",
191: "CLOSURE_FEEDBACK_CELL_ARRAY_TYPE",
192: "OBJECT_BOILERPLATE_DESCRIPTION_TYPE",
193: "SCRIPT_CONTEXT_TABLE_TYPE",
194: "BYTE_ARRAY_TYPE",
195: "BYTECODE_ARRAY_TYPE",
196: "FIXED_DOUBLE_ARRAY_TYPE",
197: "INTERNAL_CLASS_WITH_SMI_ELEMENTS_TYPE",
198: "SLOPPY_ARGUMENTS_ELEMENTS_TYPE",
199: "TURBOFAN_BITSET_TYPE_TYPE",
200: "TURBOFAN_HEAP_CONSTANT_TYPE_TYPE",
201: "TURBOFAN_OTHER_NUMBER_CONSTANT_TYPE_TYPE",
202: "TURBOFAN_RANGE_TYPE_TYPE",
203: "TURBOFAN_UNION_TYPE_TYPE",
[string] Add a is_shared bit to strings and String::Share The is_shared bit bumps the number of reserved bits for Strings' InstanceType from 6 to 7. This has the side effect of shuffling the InstanceType enum values. There are no users of this bit yet. This is steps 1-2 from the following design doc [1], in preparation for sharing internalized and in-place-internalizable strings. [1] https://docs.google.com/document/d/1c5i8f2EfKIQygGZ23hNiGxouvRISjUMnJjNsOodj6z0/edit?usp=sharing Bug: v8:12007 Change-Id: Idf11a6035305f0375b4f824ffd32a64f6b5b043b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3266017 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77831}
2021-11-10 22:42:10 +00:00
204: "FOREIGN_TYPE",
[wasm] Internal representation for function references Design doc: bit.ly/3jEVgzz We separate the internal representation of function references in Wasm from their JSFunction-based (external) representation. This improves performance of call_ref by requiring less indirections to load the context and call target from a function reference. In the boundary between wasm and JS/the C API, we add transformations between the two representations. Detailed changes: - Introduce WasmInternalFunction, containing fields required by call_ref, as well as a reference to the corresponding WasmExternalFunction. Add a reference to the WasmInternalFunction in WasmFunctionData. The {WasmInternalFunction::FromExternal} helper extracts the internal out of an external function. - Change {WasmInstanceObject::external_functions()} to internal functions. - Change wasm function tables to contain internal functions. - Change the following code to use internal functions: - call_ref in liftoff and Turbofan - function type checks in liftoff and Turbofan - CallRefIC and GenericJSToWasmWrapper builtins - {InitExprInterface::RefFunc} - module-compiler.cc in {ProcessTypeFeedback} - In module-instantiate.cc, in function-rtt creation. - Add transformations between internal and external functions in: - WasmWrapperGraphBuilder::{ToJS, BuildUnpackObjectWrapper, FromJS, BuildJSToJSWrapper}. - debug-wasm-objects.cc in {FunctionProxy::Get}, {WasmValueObject::New} and {AddWasmTableObjectInternalProperties}. - runtime-wasm.cc in ReplaceWrapper - the C and JS APIs - module-instantiate.cc, in import and export processing, as well as {InitializeIndirectFunctionTables} - WasmTableObject::{IsValidElement, SetFunctionTableEntry} - {WasmGlobalObject::SetFuncRef} - Simplify body descriptors of WasmExternalFunction variants. - Adjust tests. Bug: v8:11510 Change-Id: I8377f46f55c3771391ae1c5c8201a83854ee7878 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3277878 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78068}
2021-11-23 14:31:18 +00:00
205: "WASM_INTERNAL_FUNCTION_TYPE",
206: "WASM_TYPE_INFO_TYPE",
[debug] Introduce a dedicated StackFrameInfo for v8::StackFrame. This is the final change list in the list of refactorings to split off the implementations of v8::StackFrame and CallSite objects (as used by the V8 JavaScript stack API). See https://bit.ly/v8-stack-frame for the whole story. This CL adds the v8::internal::StackFrameInfo class as new backing implementation of v8::StackFrame, and puts it into debug-objects.tq to indicate that it's used for the debugger API only. This new class is lightweight and only holds on to static information about the stack frame, and is thus usable for the V8 inspector to implement async stack traces in a cheaper manner going forward. Doc: https://bit.ly/v8-stack-frame Bug: chromium:1258599, chromium:1278650 Fixed: chromium:1278647 Change-Id: I4dbf2d850f47797263af225895129499169aad02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3302794 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#78382}
2021-12-15 05:32:05 +00:00
207: "AWAIT_CONTEXT_TYPE",
208: "BLOCK_CONTEXT_TYPE",
209: "CATCH_CONTEXT_TYPE",
210: "DEBUG_EVALUATE_CONTEXT_TYPE",
211: "EVAL_CONTEXT_TYPE",
212: "FUNCTION_CONTEXT_TYPE",
213: "MODULE_CONTEXT_TYPE",
214: "NATIVE_CONTEXT_TYPE",
215: "SCRIPT_CONTEXT_TYPE",
216: "WITH_CONTEXT_TYPE",
[inspector] Capture stack trace only once for JSError objects. When creating a new JSError object (or using the non-standard API `Error.captureStackTrace`) V8 would previously capture the "simple stack trace" (as FixedArray of CallSiteInfo instances) to be used for the non- standard `error.stack` property, and if the inspector was active also capture the "detailed stack trace" (as FixedArray of StackFrameInfo instances). This turns out to be quite a lot of overhead, both in terms of execution time as well as memory pressure, especially since the information needed for the inspector is a proper subset of the information needed by `error.stack`. So this CL addresses the above issue by capturing only the "simple stack trace" (in the common case) and computing the "detailed stack trace" from the "simple stack trace" when on demand. This is accomplished by introducing a new ErrorStackData container that is used to store the stack trace information on JSErrors when the inspector is active. When capturing stack trace for a JSError object while the inspector is active, we take the maximum of the program controlled stack trace limit and the inspector requested stack trace limit, and memorize the program controlled stack trace limit for later formatting (to ensure that the presence of the inspector is not observable by the program). On the `standalone.js` benchmark from crbug.com/1283162 (with the default max call stack size of 200) we reduce execution time by around 16% compared to ToT. And compared to V8 9.9.4 (the version prior to the regression in crbug.com/1280831), we are 6% faster now. Doc: https://bit.ly/v8-cheaper-inspector-stack-traces Bug: chromium:1280831, chromium:1278650, chromium:1258599 Bug: chromium:1280803, chromium:1280832, chromium:1280818 Fixed: chromium:1283162 Change-Id: I57dac73e0ecf7d50ea57c3eb4981067deb28133e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3366660 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#78542}
2022-01-10 06:53:37 +00:00
217: "UNCOMPILED_DATA_WITH_PREPARSE_DATA_TYPE",
218: "UNCOMPILED_DATA_WITH_PREPARSE_DATA_AND_JOB_TYPE",
219: "UNCOMPILED_DATA_WITHOUT_PREPARSE_DATA_TYPE",
220: "UNCOMPILED_DATA_WITHOUT_PREPARSE_DATA_WITH_JOB_TYPE",
221: "WASM_FUNCTION_DATA_TYPE",
222: "WASM_CAPI_FUNCTION_DATA_TYPE",
223: "WASM_EXPORTED_FUNCTION_DATA_TYPE",
224: "WASM_JS_FUNCTION_DATA_TYPE",
[runtime] Adds a hashtable object (name => index) In preparation to use the hash table in the scope_info, we setup a hashtable from name to indices. Bug: v8:12315 Change-Id: I77f1eb40191c2fb2d40127e1e84dbc41ca2e4b70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3386804 Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#78646}
2022-01-17 11:15:27 +00:00
225: "EXPORTED_SUB_CLASS_BASE_TYPE",
226: "EXPORTED_SUB_CLASS_TYPE",
227: "EXPORTED_SUB_CLASS2_TYPE",
228: "SMALL_ORDERED_HASH_MAP_TYPE",
229: "SMALL_ORDERED_HASH_SET_TYPE",
230: "SMALL_ORDERED_NAME_DICTIONARY_TYPE",
[symbol table] use plain hash table to implement symbol table in isolate The per-Isolate Symbol tables are implemented using NameDictionary before, which has additional property details overhead And NameDictionary is limited to 2^23, which limits the Symbol tables to be a maximum of 2^23. - replace NameDictionary with SymbolTable in isolate Bug: v8:12575 Change-Id: Ica4f05aac3494f7dfa3a074c240d4ba25df814e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3476897 Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#79285}
2022-02-25 11:32:18 +00:00
231: "ABSTRACT_INTERNAL_CLASS_SUBCLASS1_TYPE",
232: "ABSTRACT_INTERNAL_CLASS_SUBCLASS2_TYPE",
233: "DESCRIPTOR_ARRAY_TYPE",
234: "STRONG_DESCRIPTOR_ARRAY_TYPE",
235: "SOURCE_TEXT_MODULE_TYPE",
236: "SYNTHETIC_MODULE_TYPE",
237: "WEAK_FIXED_ARRAY_TYPE",
238: "TRANSITION_ARRAY_TYPE",
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
239: "CELL_TYPE",
240: "CODE_TYPE",
241: "CODE_DATA_CONTAINER_TYPE",
242: "COVERAGE_INFO_TYPE",
243: "EMBEDDER_DATA_ARRAY_TYPE",
244: "FEEDBACK_METADATA_TYPE",
245: "FEEDBACK_VECTOR_TYPE",
246: "FILLER_TYPE",
247: "FREE_SPACE_TYPE",
248: "INTERNAL_CLASS_TYPE",
249: "INTERNAL_CLASS_WITH_STRUCT_ELEMENTS_TYPE",
250: "MAP_TYPE",
251: "MEGA_DOM_HANDLER_TYPE",
252: "ON_HEAP_BASIC_BLOCK_PROFILER_DATA_TYPE",
253: "PREPARSE_DATA_TYPE",
254: "PROPERTY_ARRAY_TYPE",
255: "PROPERTY_CELL_TYPE",
256: "SCOPE_INFO_TYPE",
257: "SHARED_FUNCTION_INFO_TYPE",
258: "SMI_BOX_TYPE",
259: "SMI_PAIR_TYPE",
260: "SORT_STATE_TYPE",
261: "SWISS_NAME_DICTIONARY_TYPE",
262: "WASM_API_FUNCTION_REF_TYPE",
263: "WASM_ON_FULFILLED_DATA_TYPE",
264: "WEAK_ARRAY_LIST_TYPE",
265: "WEAK_CELL_TYPE",
266: "WASM_ARRAY_TYPE",
267: "WASM_STRUCT_TYPE",
268: "JS_PROXY_TYPE",
[torque] Generate instance types Design doc: https://docs.google.com/document/d/1ZU6rCvF2YHBGMLujWqqaxlPsjFfjKDE9C3-EugfdlAE/edit Changes from the design doc: - Changed to use 'class' declarations rather than 'type' declarations for things that need instance types but whose layout is not known to Torque. These declarations end with a semicolon rather than having a full set of methods and fields surrounded by {}. If the class's name should not be treated as a class name in generated output (because it's actually a template, or doesn't exist at all), we use the standard 'generates' clause to declare the most appropriate C++ class. - Removed @instanceTypeName. - @highestInstanceType became @highestInstanceTypeWithinParentClassRange to indicate a semantic change: it no longer denotes the highest instance type globally, but only within the range of values for its immediate parent class. This lets us use it for Oddball, which is expected to be the highest primitive type. - Added new abstract classes JSCustomElementsObject and JSSpecialObject to help with some range checks. - Added @lowestInstanceTypeWithinParentClassRange so we can move the new classes JSCustomElementsObject and JSSpecialObject to the beginning of the JSObject range. This seems like the least-brittle way to establish ranges that also include JSProxy (and these ranges are verified with static assertions in instance-type.h). - Renamed @instanceTypeValue to @apiExposedInstanceTypeValue. - Renamed @instanceTypeFlags to @reserveBitsInInstanceType. This change introduces the new annotations and adds the ability for Torque to assign instance types that satisfy those annotations. Torque now emits two new macros: - TORQUE_ASSIGNED_INSTANCE_TYPES, which is used to define the InstanceType enumeration - TORQUE_ASSIGNED_INSTANCE_TYPE_LIST, which replaces the non-String parts of INSTANCE_TYPE_LIST The design document mentions a couple of other macro lists that could easily be replaced, but I'd like to defer those to a subsequent checkin because this one is already pretty large. Bug: v8:7793 Change-Id: Ie71d93a9d5b610e62be0ffa3bb36180c3357a6e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1757094 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#64258}
2019-10-11 21:52:06 +00:00
1057: "JS_OBJECT_TYPE",
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
269: "JS_GLOBAL_OBJECT_TYPE",
270: "JS_GLOBAL_PROXY_TYPE",
271: "JS_MODULE_NAMESPACE_TYPE",
Reduce max instance type enum value. We collect instance type statistics in FatalProcessOutOfMemory into an array, which is allocated to the max instance type value. While we want to leave space to ensure new instance types do not affect constants in the API, we can be more frugal. We currently serialize 350 maps into the startup/context snapshot. Even if we assign a distinct instance type to each of these maps, we would still have more than enough to spare with this change. R=ulan@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I3e583c2c8da3342e9132d96046b5d80cd41afd72 Reviewed-on: https://chromium-review.googlesource.com/842542 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#50302}
2017-12-22 17:20:47 +00:00
1040: "JS_SPECIAL_API_OBJECT_TYPE",
[objects] Rename JSValue to JSPrimitiveWrapper We currently use the class name “JSValue” for JSObjects that wrap primitive values. This name is a common source of confusion. This patch switches to a name that’s more clear. In addition to manual tweaks, the patch applies the following mechanical global replacements: before | after --------------------------------|-------------------------------------- if_valueisnotvalue | if_valueisnotwrapper if_valueisvalue | if_valueiswrapper js_value | js_primitive_wrapper JS_VALUE_TYPE | JS_PRIMITIVE_WRAPPER_TYPE JSPrimitiveWrapperType | JSPrimitiveWrapper type jsvalue | js_primitive_wrapper JSValue | JSPrimitiveWrapper _GENERATED_JSVALUE_FIELDS | _GENERATED_JSPRIMITIVE_WRAPPER_FIELDS Change-Id: I9d9edea784eab6067b013e1f781e4db2070f807c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672942 Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#62337}
2019-06-24 13:13:34 +00:00
1041: "JS_PRIMITIVE_WRAPPER_TYPE",
[api] Implement signature checks using instance types Rather than depending on slow signature checks, receiver type checks are performed using fast numeric instance type checks. This CL adds a instance type range for embedders to assign values and uses these to perform type checks. Bug: v8:11476 Change-Id: Ie8236ae47ca0ba93ae76a7e690b81aa0a2b0f3e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2883623 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#76162}
2021-08-09 07:44:18 +00:00
1058: "JS_API_OBJECT_TYPE",
2058: "JS_LAST_DUMMY_API_OBJECT_TYPE",
Check instance type before initializing embedder data slots JSObject::InitializeBody now checks whether the instance type of the object being initialized can have embedder data slots around the initialization logic for these slots. This fixes a performance regression on certain benchmarks. To perform this check efficiently, a new instance type, JSObjectWithEmbedderSlots, is introduced so that the check becomes a simple range check. Bug: chromium:1304139 Change-Id: I00c892bc2276e950b59602257ca1c2435c10e517 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3507712 Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#79497}
2022-03-14 17:35:42 +00:00
2059: "JS_DATA_VIEW_TYPE",
2060: "JS_TYPED_ARRAY_TYPE",
2061: "JS_ARRAY_BUFFER_TYPE",
2062: "JS_PROMISE_TYPE",
2063: "JS_BOUND_FUNCTION_TYPE",
2064: "JS_WRAPPED_FUNCTION_TYPE",
2065: "JS_FUNCTION_TYPE",
2066: "BIGINT64_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2067: "BIGUINT64_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2068: "FLOAT32_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2069: "FLOAT64_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2070: "INT16_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2071: "INT32_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2072: "INT8_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2073: "UINT16_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2074: "UINT32_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2075: "UINT8_CLAMPED_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2076: "UINT8_TYPED_ARRAY_CONSTRUCTOR_TYPE",
2077: "JS_ARRAY_CONSTRUCTOR_TYPE",
2078: "JS_PROMISE_CONSTRUCTOR_TYPE",
2079: "JS_REG_EXP_CONSTRUCTOR_TYPE",
2080: "JS_CLASS_CONSTRUCTOR_TYPE",
2081: "JS_ARRAY_ITERATOR_PROTOTYPE_TYPE",
2082: "JS_ITERATOR_PROTOTYPE_TYPE",
2083: "JS_MAP_ITERATOR_PROTOTYPE_TYPE",
2084: "JS_OBJECT_PROTOTYPE_TYPE",
2085: "JS_PROMISE_PROTOTYPE_TYPE",
2086: "JS_REG_EXP_PROTOTYPE_TYPE",
2087: "JS_SET_ITERATOR_PROTOTYPE_TYPE",
2088: "JS_SET_PROTOTYPE_TYPE",
2089: "JS_STRING_ITERATOR_PROTOTYPE_TYPE",
2090: "JS_TYPED_ARRAY_PROTOTYPE_TYPE",
2091: "JS_MAP_KEY_ITERATOR_TYPE",
2092: "JS_MAP_KEY_VALUE_ITERATOR_TYPE",
2093: "JS_MAP_VALUE_ITERATOR_TYPE",
2094: "JS_SET_KEY_VALUE_ITERATOR_TYPE",
2095: "JS_SET_VALUE_ITERATOR_TYPE",
2096: "JS_GENERATOR_OBJECT_TYPE",
2097: "JS_ASYNC_FUNCTION_OBJECT_TYPE",
2098: "JS_ASYNC_GENERATOR_OBJECT_TYPE",
2099: "JS_MAP_TYPE",
2100: "JS_SET_TYPE",
2101: "JS_WEAK_MAP_TYPE",
2102: "JS_WEAK_SET_TYPE",
2103: "JS_ARGUMENTS_OBJECT_TYPE",
2104: "JS_ARRAY_TYPE",
2105: "JS_ARRAY_ITERATOR_TYPE",
2106: "JS_ASYNC_FROM_SYNC_ITERATOR_TYPE",
2107: "JS_COLLATOR_TYPE",
2108: "JS_CONTEXT_EXTENSION_OBJECT_TYPE",
2109: "JS_DATE_TYPE",
2110: "JS_DATE_TIME_FORMAT_TYPE",
2111: "JS_DISPLAY_NAMES_TYPE",
2112: "JS_ERROR_TYPE",
2113: "JS_EXTERNAL_OBJECT_TYPE",
2114: "JS_FINALIZATION_REGISTRY_TYPE",
2115: "JS_LIST_FORMAT_TYPE",
2116: "JS_LOCALE_TYPE",
2117: "JS_MESSAGE_OBJECT_TYPE",
2118: "JS_NUMBER_FORMAT_TYPE",
2119: "JS_PLURAL_RULES_TYPE",
Refactor ExternalObjects Instead of implementing ExternalObjects as plain JSObjects with a single EmbedderDataSlot pointing to a Foreign containing the actual raw pointer, this CL now creates a new JSExternalObject type that directly contains the external pointer. As a side-effect of this refactoring, nullptr values are now no longer valid for ExternalObjects. Change-Id: Ic8ff334681c966e823ca70f34dd1efaaa21a0789 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3513234 Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#79459}
2022-03-10 18:44:52 +00:00
2120: "JS_REG_EXP_TYPE",
2121: "JS_REG_EXP_STRING_ITERATOR_TYPE",
2122: "JS_RELATIVE_TIME_FORMAT_TYPE",
2123: "JS_SEGMENT_ITERATOR_TYPE",
2124: "JS_SEGMENTER_TYPE",
2125: "JS_SEGMENTS_TYPE",
2126: "JS_SHADOW_REALM_TYPE",
2127: "JS_SHARED_STRUCT_TYPE",
2128: "JS_STRING_ITERATOR_TYPE",
2129: "JS_TEMPORAL_CALENDAR_TYPE",
2130: "JS_TEMPORAL_DURATION_TYPE",
2131: "JS_TEMPORAL_INSTANT_TYPE",
2132: "JS_TEMPORAL_PLAIN_DATE_TYPE",
2133: "JS_TEMPORAL_PLAIN_DATE_TIME_TYPE",
2134: "JS_TEMPORAL_PLAIN_MONTH_DAY_TYPE",
2135: "JS_TEMPORAL_PLAIN_TIME_TYPE",
2136: "JS_TEMPORAL_PLAIN_YEAR_MONTH_TYPE",
2137: "JS_TEMPORAL_TIME_ZONE_TYPE",
2138: "JS_TEMPORAL_ZONED_DATE_TIME_TYPE",
2139: "JS_V8_BREAK_ITERATOR_TYPE",
2140: "JS_WEAK_REF_TYPE",
2141: "WASM_GLOBAL_OBJECT_TYPE",
2142: "WASM_INSTANCE_OBJECT_TYPE",
2143: "WASM_MEMORY_OBJECT_TYPE",
2144: "WASM_MODULE_OBJECT_TYPE",
2145: "WASM_SUSPENDER_OBJECT_TYPE",
2146: "WASM_TABLE_OBJECT_TYPE",
2147: "WASM_TAG_OBJECT_TYPE",
2148: "WASM_VALUE_OBJECT_TYPE",
Generate grokdump constants with 'make grokdump' now. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/21771002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16022 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-02 09:02:02 +00:00
}
# List of known V8 maps.
KNOWN_MAPS = {
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02151): (250, "MetaMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02179): (131, "NullMap"),
("read_only_space", 0x021a1): (234, "StrongDescriptorArrayMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x021c9): (264, "WeakArrayListMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x0220d): (157, "EnumCacheMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02241): (179, "FixedArrayMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x0228d): (8, "OneByteInternalizedStringMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x022d9): (247, "FreeSpaceMap"),
("read_only_space", 0x02301): (246, "OnePointerFillerMap"),
("read_only_space", 0x02329): (246, "TwoPointerFillerMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02351): (131, "UninitializedMap"),
("read_only_space", 0x023c9): (131, "UndefinedMap"),
("read_only_space", 0x0240d): (130, "HeapNumberMap"),
("read_only_space", 0x02441): (131, "TheHoleMap"),
("read_only_space", 0x024a1): (131, "BooleanMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02545): (194, "ByteArrayMap"),
("read_only_space", 0x0256d): (179, "FixedCOWArrayMap"),
("read_only_space", 0x02595): (180, "HashTableMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x025bd): (128, "SymbolMap"),
("read_only_space", 0x025e5): (40, "OneByteStringMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x0260d): (256, "ScopeInfoMap"),
("read_only_space", 0x02635): (257, "SharedFunctionInfoMap"),
("read_only_space", 0x0265d): (240, "CodeMap"),
("read_only_space", 0x02685): (239, "CellMap"),
("read_only_space", 0x026ad): (255, "GlobalPropertyCellMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x026d5): (204, "ForeignMap"),
("read_only_space", 0x026fd): (238, "TransitionArrayMap"),
("read_only_space", 0x02725): (45, "ThinOneByteStringMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x0274d): (245, "FeedbackVectorMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02785): (131, "ArgumentsMarkerMap"),
("read_only_space", 0x027e5): (131, "ExceptionMap"),
("read_only_space", 0x02841): (131, "TerminationExceptionMap"),
("read_only_space", 0x028a9): (131, "OptimizedOutMap"),
("read_only_space", 0x02909): (131, "StaleRegisterMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02969): (193, "ScriptContextTableMap"),
("read_only_space", 0x02991): (191, "ClosureFeedbackCellArrayMap"),
("read_only_space", 0x029b9): (244, "FeedbackMetadataArrayMap"),
("read_only_space", 0x029e1): (179, "ArrayListMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02a09): (129, "BigIntMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02a31): (192, "ObjectBoilerplateDescriptionMap"),
("read_only_space", 0x02a59): (195, "BytecodeArrayMap"),
("read_only_space", 0x02a81): (241, "CodeDataContainerMap"),
("read_only_space", 0x02aa9): (242, "CoverageInfoMap"),
("read_only_space", 0x02ad1): (196, "FixedDoubleArrayMap"),
("read_only_space", 0x02af9): (182, "GlobalDictionaryMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02b21): (159, "ManyClosuresCellMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02b49): (251, "MegaDomHandlerMap"),
("read_only_space", 0x02b71): (179, "ModuleInfoMap"),
("read_only_space", 0x02b99): (183, "NameDictionaryMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02bc1): (159, "NoClosuresCellMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02be9): (185, "NumberDictionaryMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02c11): (159, "OneClosureCellMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02c39): (186, "OrderedHashMapMap"),
("read_only_space", 0x02c61): (187, "OrderedHashSetMap"),
("read_only_space", 0x02c89): (184, "NameToIndexHashTableMap"),
("read_only_space", 0x02cb1): (189, "RegisteredSymbolTableMap"),
("read_only_space", 0x02cd9): (188, "OrderedNameDictionaryMap"),
("read_only_space", 0x02d01): (253, "PreparseDataMap"),
("read_only_space", 0x02d29): (254, "PropertyArrayMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02d51): (153, "SideEffectCallHandlerInfoMap"),
("read_only_space", 0x02d79): (153, "SideEffectFreeCallHandlerInfoMap"),
("read_only_space", 0x02da1): (153, "NextCallSideEffectFreeCallHandlerInfoMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02dc9): (190, "SimpleNumberDictionaryMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02df1): (228, "SmallOrderedHashMapMap"),
("read_only_space", 0x02e19): (229, "SmallOrderedHashSetMap"),
("read_only_space", 0x02e41): (230, "SmallOrderedNameDictionaryMap"),
("read_only_space", 0x02e69): (235, "SourceTextModuleMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02e91): (261, "SwissNameDictionaryMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02eb9): (236, "SyntheticModuleMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02ee1): (262, "WasmApiFunctionRefMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02f09): (222, "WasmCapiFunctionDataMap"),
("read_only_space", 0x02f31): (223, "WasmExportedFunctionDataMap"),
("read_only_space", 0x02f59): (205, "WasmInternalFunctionMap"),
("read_only_space", 0x02f81): (224, "WasmJSFunctionDataMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x02fa9): (263, "WasmOnFulfilledDataMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x02fd1): (206, "WasmTypeInfoMap"),
("read_only_space", 0x02ff9): (237, "WeakFixedArrayMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x03021): (181, "EphemeronHashTableMap"),
("read_only_space", 0x03049): (243, "EmbedderDataArrayMap"),
("read_only_space", 0x03071): (265, "WeakCellMap"),
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x03099): (32, "StringMap"),
("read_only_space", 0x030c1): (41, "ConsOneByteStringMap"),
("read_only_space", 0x030e9): (33, "ConsStringMap"),
("read_only_space", 0x03111): (37, "ThinStringMap"),
("read_only_space", 0x03139): (35, "SlicedStringMap"),
("read_only_space", 0x03161): (43, "SlicedOneByteStringMap"),
("read_only_space", 0x03189): (34, "ExternalStringMap"),
("read_only_space", 0x031b1): (42, "ExternalOneByteStringMap"),
("read_only_space", 0x031d9): (50, "UncachedExternalStringMap"),
("read_only_space", 0x03201): (0, "InternalizedStringMap"),
("read_only_space", 0x03229): (2, "ExternalInternalizedStringMap"),
("read_only_space", 0x03251): (10, "ExternalOneByteInternalizedStringMap"),
("read_only_space", 0x03279): (18, "UncachedExternalInternalizedStringMap"),
("read_only_space", 0x032a1): (26, "UncachedExternalOneByteInternalizedStringMap"),
("read_only_space", 0x032c9): (58, "UncachedExternalOneByteStringMap"),
("read_only_space", 0x032f1): (104, "SharedOneByteStringMap"),
("read_only_space", 0x03319): (96, "SharedStringMap"),
("read_only_space", 0x03341): (109, "SharedThinOneByteStringMap"),
("read_only_space", 0x03369): (101, "SharedThinStringMap"),
("read_only_space", 0x03391): (96, "TwoByteSeqStringMigrationSentinelMap"),
("read_only_space", 0x033b9): (104, "OneByteSeqStringMigrationSentinelMap"),
("read_only_space", 0x033e1): (131, "SelfReferenceMarkerMap"),
("read_only_space", 0x03409): (131, "BasicBlockCountersMarkerMap"),
("read_only_space", 0x0344d): (147, "ArrayBoilerplateDescriptionMap"),
("read_only_space", 0x0354d): (161, "InterceptorInfoMap"),
("read_only_space", 0x0601d): (132, "PromiseFulfillReactionJobTaskMap"),
("read_only_space", 0x06045): (133, "PromiseRejectReactionJobTaskMap"),
("read_only_space", 0x0606d): (134, "CallableTaskMap"),
("read_only_space", 0x06095): (135, "CallbackTaskMap"),
("read_only_space", 0x060bd): (136, "PromiseResolveThenableJobTaskMap"),
("read_only_space", 0x060e5): (139, "FunctionTemplateInfoMap"),
("read_only_space", 0x0610d): (140, "ObjectTemplateInfoMap"),
("read_only_space", 0x06135): (141, "AccessCheckInfoMap"),
("read_only_space", 0x0615d): (142, "AccessorInfoMap"),
("read_only_space", 0x06185): (143, "AccessorPairMap"),
("read_only_space", 0x061ad): (144, "AliasedArgumentsEntryMap"),
("read_only_space", 0x061d5): (145, "AllocationMementoMap"),
("read_only_space", 0x061fd): (148, "AsmWasmDataMap"),
("read_only_space", 0x06225): (149, "AsyncGeneratorRequestMap"),
("read_only_space", 0x0624d): (150, "BreakPointMap"),
("read_only_space", 0x06275): (151, "BreakPointInfoMap"),
("read_only_space", 0x0629d): (152, "CachedTemplateObjectMap"),
("read_only_space", 0x062c5): (154, "CallSiteInfoMap"),
("read_only_space", 0x062ed): (155, "ClassPositionsMap"),
("read_only_space", 0x06315): (156, "DebugInfoMap"),
("read_only_space", 0x0633d): (158, "ErrorStackDataMap"),
("read_only_space", 0x06365): (160, "FunctionTemplateRareDataMap"),
("read_only_space", 0x0638d): (162, "InterpreterDataMap"),
("read_only_space", 0x063b5): (163, "ModuleRequestMap"),
("read_only_space", 0x063dd): (164, "PromiseCapabilityMap"),
[debug] Hold on to promises weakly from the debugger's promise stack. The debugger maintains a stack of promises used for catch prediction with promise builtins and async functions. Previously this stack would hold on to the individual promises strongly, and subtle bugs that lead to not properly cleaning up the stack in some corner cases would often lead to significant memory issues (e.g. leaking whole iframes). This refactors the PromiseOnStack to be (a) on the V8 heap, rather than allocating C++ structs with global handles pointing to the promises, and (b) hold on to the promises only weakly. While this will not guarantee proper promise stack management, it will at least ensure that edge cases don't lead to catastrophic (debugger only) leaks. Bug: chromium:1292063 Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79594}
2022-03-24 07:24:23 +00:00
("read_only_space", 0x06405): (165, "PromiseOnStackMap"),
("read_only_space", 0x0642d): (166, "PromiseReactionMap"),
("read_only_space", 0x06455): (167, "PropertyDescriptorObjectMap"),
("read_only_space", 0x0647d): (168, "PrototypeInfoMap"),
("read_only_space", 0x064a5): (169, "RegExpBoilerplateDescriptionMap"),
("read_only_space", 0x064cd): (170, "ScriptMap"),
("read_only_space", 0x064f5): (171, "ScriptOrModuleMap"),
("read_only_space", 0x0651d): (172, "SourceTextModuleInfoEntryMap"),
("read_only_space", 0x06545): (173, "StackFrameInfoMap"),
("read_only_space", 0x0656d): (174, "TemplateObjectDescriptionMap"),
("read_only_space", 0x06595): (175, "Tuple2Map"),
("read_only_space", 0x065bd): (176, "WasmContinuationObjectMap"),
("read_only_space", 0x065e5): (177, "WasmExceptionTagMap"),
("read_only_space", 0x0660d): (178, "WasmIndirectFunctionTableMap"),
("read_only_space", 0x06635): (198, "SloppyArgumentsElementsMap"),
("read_only_space", 0x0665d): (233, "DescriptorArrayMap"),
("read_only_space", 0x06685): (219, "UncompiledDataWithoutPreparseDataMap"),
("read_only_space", 0x066ad): (217, "UncompiledDataWithPreparseDataMap"),
("read_only_space", 0x066d5): (220, "UncompiledDataWithoutPreparseDataWithJobMap"),
("read_only_space", 0x066fd): (218, "UncompiledDataWithPreparseDataAndJobMap"),
("read_only_space", 0x06725): (252, "OnHeapBasicBlockProfilerDataMap"),
("read_only_space", 0x0674d): (199, "TurbofanBitsetTypeMap"),
("read_only_space", 0x06775): (203, "TurbofanUnionTypeMap"),
("read_only_space", 0x0679d): (202, "TurbofanRangeTypeMap"),
("read_only_space", 0x067c5): (200, "TurbofanHeapConstantTypeMap"),
("read_only_space", 0x067ed): (201, "TurbofanOtherNumberConstantTypeMap"),
("read_only_space", 0x06815): (248, "InternalClassMap"),
("read_only_space", 0x0683d): (259, "SmiPairMap"),
("read_only_space", 0x06865): (258, "SmiBoxMap"),
("read_only_space", 0x0688d): (225, "ExportedSubClassBaseMap"),
("read_only_space", 0x068b5): (226, "ExportedSubClassMap"),
("read_only_space", 0x068dd): (231, "AbstractInternalClassSubclass1Map"),
("read_only_space", 0x06905): (232, "AbstractInternalClassSubclass2Map"),
("read_only_space", 0x0692d): (197, "InternalClassWithSmiElementsMap"),
("read_only_space", 0x06955): (249, "InternalClassWithStructElementsMap"),
("read_only_space", 0x0697d): (227, "ExportedSubClass2Map"),
("read_only_space", 0x069a5): (260, "SortStateMap"),
("read_only_space", 0x069cd): (146, "AllocationSiteWithWeakNextMap"),
("read_only_space", 0x069f5): (146, "AllocationSiteWithoutWeakNextMap"),
("read_only_space", 0x06a1d): (137, "LoadHandler1Map"),
("read_only_space", 0x06a45): (137, "LoadHandler2Map"),
("read_only_space", 0x06a6d): (137, "LoadHandler3Map"),
("read_only_space", 0x06a95): (138, "StoreHandler0Map"),
("read_only_space", 0x06abd): (138, "StoreHandler1Map"),
("read_only_space", 0x06ae5): (138, "StoreHandler2Map"),
("read_only_space", 0x06b0d): (138, "StoreHandler3Map"),
Check instance type before initializing embedder data slots JSObject::InitializeBody now checks whether the instance type of the object being initialized can have embedder data slots around the initialization logic for these slots. This fixes a performance regression on certain benchmarks. To perform this check efficiently, a new instance type, JSObjectWithEmbedderSlots, is introduced so that the check becomes a simple range check. Bug: chromium:1304139 Change-Id: I00c892bc2276e950b59602257ca1c2435c10e517 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3507712 Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#79497}
2022-03-14 17:35:42 +00:00
("map_space", 0x02151): (2113, "ExternalMap"),
("map_space", 0x02179): (2117, "JSMessageObjectMap"),
Generate grokdump constants with 'make grokdump' now. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/21771002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16022 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-02 09:02:02 +00:00
}
# List of known V8 objects.
KNOWN_OBJECTS = {
[heap] Improve accounting of PagedSpace::CommittedPhysicalMemory() Instead of using the high water mark for determining this metric, we use a bitset for all active/used system pages on a V8 heap page. Each time when allocating a LAB on a page, we add the pages of that memory range to that bitset. During sweeping we rebuild that bitset from scratch and replace it with the old one in case free pages are discarded by the GC. We DCHECK here that the sweeper only ever removes pages. This has the nice benefit of ensuring that we don't miss any allocations (like we do now for concurrent allocations). CommittedPhysicalMemory for a page is then calculated by counting the set bits in the bitset and multiplying it with the system page size. This should be simpler to verify and track the "real" effective size more precisely. One case where we are partially less precise than the current implementation is for LABs. In order to reduce complexity we now treat all pages of a LAB allocation as active immediately. In the current implementation we tried to only account the actual used part of the LAB when changing the LAB later. This is more complex to track correctly but also doesn't account the currently used LAB in effective size. Change-Id: Ia83df9ad5fbb852f0717c4c396b5074604bd21e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497363 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79428}
2022-03-09 16:49:56 +00:00
("read_only_space", 0x021f1): "EmptyWeakArrayList",
("read_only_space", 0x021fd): "EmptyDescriptorArray",
("read_only_space", 0x02235): "EmptyEnumCache",
("read_only_space", 0x02269): "EmptyFixedArray",
("read_only_space", 0x02271): "NullValue",
("read_only_space", 0x02379): "UninitializedValue",
("read_only_space", 0x023f1): "UndefinedValue",
("read_only_space", 0x02435): "NanValue",
("read_only_space", 0x02469): "TheHoleValue",
("read_only_space", 0x02495): "HoleNanValue",
("read_only_space", 0x024c9): "TrueValue",
("read_only_space", 0x02509): "FalseValue",
("read_only_space", 0x02539): "empty_string",
("read_only_space", 0x02775): "EmptyScopeInfo",
("read_only_space", 0x027ad): "ArgumentsMarker",
("read_only_space", 0x0280d): "Exception",
("read_only_space", 0x02869): "TerminationException",
("read_only_space", 0x028d1): "OptimizedOut",
("read_only_space", 0x02931): "StaleRegister",
("read_only_space", 0x03431): "EmptyPropertyArray",
("read_only_space", 0x03439): "EmptyByteArray",
("read_only_space", 0x03441): "EmptyObjectBoilerplateDescription",
("read_only_space", 0x03475): "EmptyArrayBoilerplateDescription",
("read_only_space", 0x03481): "EmptyClosureFeedbackCellArray",
("read_only_space", 0x03489): "EmptySlowElementDictionary",
("read_only_space", 0x034ad): "EmptyOrderedHashMap",
("read_only_space", 0x034c1): "EmptyOrderedHashSet",
("read_only_space", 0x034d5): "EmptyFeedbackMetadata",
("read_only_space", 0x034e1): "EmptyPropertyDictionary",
("read_only_space", 0x03509): "EmptyOrderedPropertyDictionary",
("read_only_space", 0x03521): "EmptySwissPropertyDictionary",
("read_only_space", 0x03575): "NoOpInterceptorInfo",
("read_only_space", 0x0359d): "EmptyArrayList",
("read_only_space", 0x035a9): "EmptyWeakFixedArray",
("read_only_space", 0x035b1): "InfinityValue",
("read_only_space", 0x035bd): "MinusZeroValue",
("read_only_space", 0x035c9): "MinusInfinityValue",
("read_only_space", 0x035d5): "SelfReferenceMarker",
("read_only_space", 0x03615): "BasicBlockCountersMarker",
("read_only_space", 0x03659): "OffHeapTrampolineRelocationInfo",
("read_only_space", 0x03665): "GlobalThisBindingScopeInfo",
("read_only_space", 0x03695): "EmptyFunctionScopeInfo",
("read_only_space", 0x036b9): "NativeScopeInfo",
("read_only_space", 0x036d1): "HashSeed",
("old_space", 0x0421d): "ArgumentsIteratorAccessor",
("old_space", 0x04261): "ArrayLengthAccessor",
("old_space", 0x042a5): "BoundFunctionLengthAccessor",
("old_space", 0x042e9): "BoundFunctionNameAccessor",
("old_space", 0x0432d): "ErrorStackAccessor",
("old_space", 0x04371): "FunctionArgumentsAccessor",
("old_space", 0x043b5): "FunctionCallerAccessor",
("old_space", 0x043f9): "FunctionNameAccessor",
("old_space", 0x0443d): "FunctionLengthAccessor",
("old_space", 0x04481): "FunctionPrototypeAccessor",
("old_space", 0x044c5): "StringLengthAccessor",
("old_space", 0x04509): "InvalidPrototypeValidityCell",
("old_space", 0x04511): "EmptyScript",
("old_space", 0x04551): "ManyClosuresCell",
("old_space", 0x0455d): "ArrayConstructorProtector",
("old_space", 0x04571): "NoElementsProtector",
("old_space", 0x04585): "MegaDOMProtector",
("old_space", 0x04599): "IsConcatSpreadableProtector",
("old_space", 0x045ad): "ArraySpeciesProtector",
("old_space", 0x045c1): "TypedArraySpeciesProtector",
("old_space", 0x045d5): "PromiseSpeciesProtector",
("old_space", 0x045e9): "RegExpSpeciesProtector",
("old_space", 0x045fd): "StringLengthProtector",
("old_space", 0x04611): "ArrayIteratorProtector",
("old_space", 0x04625): "ArrayBufferDetachingProtector",
("old_space", 0x04639): "PromiseHookProtector",
("old_space", 0x0464d): "PromiseResolveProtector",
("old_space", 0x04661): "MapIteratorProtector",
("old_space", 0x04675): "PromiseThenProtector",
("old_space", 0x04689): "SetIteratorProtector",
("old_space", 0x0469d): "StringIteratorProtector",
("old_space", 0x046b1): "SingleCharacterStringCache",
("old_space", 0x04ab9): "StringSplitCache",
("old_space", 0x04ec1): "RegExpMultipleCache",
("old_space", 0x052c9): "BuiltinsConstantsTable",
("old_space", 0x056f5): "AsyncFunctionAwaitRejectSharedFun",
("old_space", 0x05719): "AsyncFunctionAwaitResolveSharedFun",
("old_space", 0x0573d): "AsyncGeneratorAwaitRejectSharedFun",
("old_space", 0x05761): "AsyncGeneratorAwaitResolveSharedFun",
("old_space", 0x05785): "AsyncGeneratorYieldResolveSharedFun",
("old_space", 0x057a9): "AsyncGeneratorReturnResolveSharedFun",
("old_space", 0x057cd): "AsyncGeneratorReturnClosedRejectSharedFun",
("old_space", 0x057f1): "AsyncGeneratorReturnClosedResolveSharedFun",
("old_space", 0x05815): "AsyncIteratorValueUnwrapSharedFun",
("old_space", 0x05839): "PromiseAllResolveElementSharedFun",
("old_space", 0x0585d): "PromiseAllSettledResolveElementSharedFun",
("old_space", 0x05881): "PromiseAllSettledRejectElementSharedFun",
("old_space", 0x058a5): "PromiseAnyRejectElementSharedFun",
("old_space", 0x058c9): "PromiseCapabilityDefaultRejectSharedFun",
("old_space", 0x058ed): "PromiseCapabilityDefaultResolveSharedFun",
("old_space", 0x05911): "PromiseCatchFinallySharedFun",
("old_space", 0x05935): "PromiseGetCapabilitiesExecutorSharedFun",
("old_space", 0x05959): "PromiseThenFinallySharedFun",
("old_space", 0x0597d): "PromiseThrowerFinallySharedFun",
("old_space", 0x059a1): "PromiseValueThunkFinallySharedFun",
("old_space", 0x059c5): "ProxyRevokeSharedFun",
[ptr-compr][x64] Enable pointer compression on x64 Chromium LSAN bot failures are fixed on Chromium side: https://chromium-review.googlesource.com/c/chromium/src/+/1926472 Bug: v8:7703 Change-Id: I830b747ca2f2f1b3c5adf31b42b3b8112c5d4457 Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_cfi_rel_ng Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel,mac-rel,linux_chromium_asan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925149 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#65136}
2019-11-24 23:19:26 +00:00
}
# Lower 32 bits of first page addresses for various heap spaces.
HEAP_FIRST_PAGES = {
[ext-code-space] Enable external code space on x64 and desktop arm64 This is a reland #3. The fixes were landed separately. Perf Sheriffs: this CL might regress some benchmarks while improving the others. Bug: v8:11880 Change-Id: I8ed5bf59360649718960dc34c06015ee6ff1532a Cq-Include-Trybots: luci.v8.try:v8_android_arm64_compile_dbg Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3422643 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78854}
2022-01-28 14:23:46 +00:00
0x000c0000: "old_space",
0x00100000: "map_space",
0x00000000: "read_only_space",
Generate grokdump constants with 'make grokdump' now. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/21771002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16022 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-02 09:02:02 +00:00
}
[tools] Improve grokdump.py - Add new address markers: T: tagged pointer in the minidump C: address into a module in the minidump S: pointer into the exception stack in the minidump *: other address in the minidump - Show ASCII decoding of address in dd - Display potential frame markers on the exception stack: 00000032212fdae8: 0000000300000000 ........ Smi(3) EXIT frame marker - Display relative addresses, useful to detect stack frames: 00000032212fdb68: 00000032212fdb98 S ........ [+6]=00000032212fdcb0 S 00000032212fdb70: 0000010ff5ca0a84 ........ 00000032212fdb78: 000001064c1fa881 ........ 00000032212fdb80: 0000016a8e52fcb1 ........ 00000032212fdb88: 0000010ff5ca0981 ........ 00000032212fdb90: 0000000d00000000 ........ Smi(13) INTERNAL frame marker 00000032212fdb98: 00000032212fdcb0 S ........ [+35]=00000032212fdd61 S Change-Id: I56bd7e6723a34bcb668719246dd5ff2898224928 Reviewed-on: https://chromium-review.googlesource.com/461862 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#44269}
2017-03-30 11:44:00 +00:00
# List of known V8 Frame Markers.
FRAME_MARKERS = (
"ENTRY",
Naming consistency and further small cleanups to frames.h R=mstarzinger@chromium.org Bug: Change-Id: Ia416acd8c12a3c8e3fdfabc56a4cd31cb946c88c Reviewed-on: https://chromium-review.googlesource.com/599949 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47135}
2017-08-03 14:30:20 +00:00
"CONSTRUCT_ENTRY",
[tools] Improve grokdump.py - Add new address markers: T: tagged pointer in the minidump C: address into a module in the minidump S: pointer into the exception stack in the minidump *: other address in the minidump - Show ASCII decoding of address in dd - Display potential frame markers on the exception stack: 00000032212fdae8: 0000000300000000 ........ Smi(3) EXIT frame marker - Display relative addresses, useful to detect stack frames: 00000032212fdb68: 00000032212fdb98 S ........ [+6]=00000032212fdcb0 S 00000032212fdb70: 0000010ff5ca0a84 ........ 00000032212fdb78: 000001064c1fa881 ........ 00000032212fdb80: 0000016a8e52fcb1 ........ 00000032212fdb88: 0000010ff5ca0981 ........ 00000032212fdb90: 0000000d00000000 ........ Smi(13) INTERNAL frame marker 00000032212fdb98: 00000032212fdcb0 S ........ [+35]=00000032212fdd61 S Change-Id: I56bd7e6723a34bcb668719246dd5ff2898224928 Reviewed-on: https://chromium-review.googlesource.com/461862 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#44269}
2017-03-30 11:44:00 +00:00
"EXIT",
[wasm][debug] Rename WasmCompiledFrame to WasmFrame Also, rename the WASM_COMPILED frame type to just WASM. R=jkummerow@chromium.org Bug: v8:10389 Change-Id: I71f16f41a69f8b0295ba34bd7d7fad71729546f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187613 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67698}
2020-05-07 12:29:48 +00:00
"WASM",
[tools] Improve grokdump.py - Add new address markers: T: tagged pointer in the minidump C: address into a module in the minidump S: pointer into the exception stack in the minidump *: other address in the minidump - Show ASCII decoding of address in dd - Display potential frame markers on the exception stack: 00000032212fdae8: 0000000300000000 ........ Smi(3) EXIT frame marker - Display relative addresses, useful to detect stack frames: 00000032212fdb68: 00000032212fdb98 S ........ [+6]=00000032212fdcb0 S 00000032212fdb70: 0000010ff5ca0a84 ........ 00000032212fdb78: 000001064c1fa881 ........ 00000032212fdb80: 0000016a8e52fcb1 ........ 00000032212fdb88: 0000010ff5ca0981 ........ 00000032212fdb90: 0000000d00000000 ........ Smi(13) INTERNAL frame marker 00000032212fdb98: 00000032212fdcb0 S ........ [+35]=00000032212fdd61 S Change-Id: I56bd7e6723a34bcb668719246dd5ff2898224928 Reviewed-on: https://chromium-review.googlesource.com/461862 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#44269}
2017-03-30 11:44:00 +00:00
"WASM_TO_JS",
"JS_TO_WASM",
[wasm] Add suspend wrapper stub - Add suspend asm builtin stub, and call it from the suspending wasm-to-js wrapper - Rename frame type to match both builtins (prompt and suspend) - Add suspend bool to the import cache key R=ahaas@chromium.org CC=​​fgm@chromium.org Bug: v8:12191 Change-Id: Ie5a8ca7cbe4bcb91697e05b6470e3d632d608993 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3345004 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#78628}
2022-01-14 14:20:07 +00:00
"STACK_SWITCH",
[wasm] Add a separate frame type for debug break frames The frame created by the WasmDebugBreak builtin now has a separate frame type, which will (later) allow to inspect the spilled registers. Once Liftoff supports reference types, this frame will also need special GC support for spilled heap references. R=jkummerow@chromium.org Bug: v8:10222 Change-Id: I110e51d1e6d09b0f44dcdd1cdcaafa2eaa64fddd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083013 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66531}
2020-03-02 11:24:13 +00:00
"WASM_DEBUG_BREAK",
[wasm] [debug] Implement calling imported wasm functions The interpreter was not able to call imported wasm functions (hitting UNIMPLEMENTED). This CL fixes this by creating a "CWasmEntry", which is signature-specific. It has JS linkage and receives the wasm code object to call and a buffer containing all arguments (similar to the interpreter entry). It loads all arguments from the buffer and calls the given code object. The c-wasm-entry code objects are cached per instance, such that we only create them once per signature. These wasm entry stubs will also allow us to call back to compiled code from the interpreter, which we might want to do to reduce the slowdown of executing wasm for debugging. R=titzer@chromium.org Bug: chromium:735792 Change-Id: I7fecec3a7bec62a9de40fff115b684759b12a28b Reviewed-on: https://chromium-review.googlesource.com/600308 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47195}
2017-08-07 11:40:21 +00:00
"C_WASM_ENTRY",
[wasm-c-api] New call descriptor and stackframe kind So far, calls to Wasm C/C++ API functions reused the call descriptors of WasmImportWrappers, and the stack frame type of regular Wasm functions. This CL cleans that up by introducing separate implementations for both. No change in functionality or performance is expected. Change-Id: I79301fa81da52283cc776ddf19d4712372f3a58b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632235 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61914}
2019-05-29 10:42:21 +00:00
"WASM_EXIT",
[wasm] Introduce specialized WasmCompileLazy frame type. This makes the WasmCompileLazy builtin push a new WASM_COMPILE_LAZY frame type. We can thereby remove the workaround to return a relocated instance from the underlying runtime function. It also removes the last remaining embedded code objects from {WasmCode} objects. R=titzer@chromium.org Change-Id: Ic9c3f59339e8d7bed53ea0ed70ef50dfe640f1c6 Reviewed-on: https://chromium-review.googlesource.com/1073455 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53405}
2018-05-29 10:53:23 +00:00
"WASM_COMPILE_LAZY",
[tools] Improve grokdump.py - Add new address markers: T: tagged pointer in the minidump C: address into a module in the minidump S: pointer into the exception stack in the minidump *: other address in the minidump - Show ASCII decoding of address in dd - Display potential frame markers on the exception stack: 00000032212fdae8: 0000000300000000 ........ Smi(3) EXIT frame marker - Display relative addresses, useful to detect stack frames: 00000032212fdb68: 00000032212fdb98 S ........ [+6]=00000032212fdcb0 S 00000032212fdb70: 0000010ff5ca0a84 ........ 00000032212fdb78: 000001064c1fa881 ........ 00000032212fdb80: 0000016a8e52fcb1 ........ 00000032212fdb88: 0000010ff5ca0981 ........ 00000032212fdb90: 0000000d00000000 ........ Smi(13) INTERNAL frame marker 00000032212fdb98: 00000032212fdcb0 S ........ [+35]=00000032212fdd61 S Change-Id: I56bd7e6723a34bcb668719246dd5ff2898224928 Reviewed-on: https://chromium-review.googlesource.com/461862 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#44269}
2017-03-30 11:44:00 +00:00
"INTERPRETED",
[sparkplug] Change Sparkplug to Baseline Currently we sometimes refer to baseline code or the baseline compiler by its codename (Sparkplug). The codename is fun, but we should be consistent and call things by one name or the other. Following the pattern of Ignition stuff being called "interpreter", we call Sparkplug "baseline", and leave the codename only in flags and variants. Bug: v8:11420 Change-Id: I432e5629518be7c7ad38b6acff024c91d4cfd6d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692186 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#72696}
2021-02-12 11:41:57 +00:00
"BASELINE",
[sparkplug] Upstream Sparkplug Sparkplug is a new baseline, non-optimising second-tier compiler, designed to fit in the compiler trade-off space between Ignition and TurboProp/TurboFan. Design doc: https://docs.google.com/document/d/13c-xXmFOMcpUQNqo66XWQt3u46TsBjXrHrh4c045l-A/edit?usp=sharing Bug: v8:11420 Change-Id: Ideb7270db3d6548eedd8337a3f596eb6f8fea6b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667514 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#72686}
2021-02-12 08:41:14 +00:00
"OPTIMIZED",
[tools] Improve grokdump.py - Add new address markers: T: tagged pointer in the minidump C: address into a module in the minidump S: pointer into the exception stack in the minidump *: other address in the minidump - Show ASCII decoding of address in dd - Display potential frame markers on the exception stack: 00000032212fdae8: 0000000300000000 ........ Smi(3) EXIT frame marker - Display relative addresses, useful to detect stack frames: 00000032212fdb68: 00000032212fdb98 S ........ [+6]=00000032212fdcb0 S 00000032212fdb70: 0000010ff5ca0a84 ........ 00000032212fdb78: 000001064c1fa881 ........ 00000032212fdb80: 0000016a8e52fcb1 ........ 00000032212fdb88: 0000010ff5ca0981 ........ 00000032212fdb90: 0000000d00000000 ........ Smi(13) INTERNAL frame marker 00000032212fdb98: 00000032212fdcb0 S ........ [+35]=00000032212fdd61 S Change-Id: I56bd7e6723a34bcb668719246dd5ff2898224928 Reviewed-on: https://chromium-review.googlesource.com/461862 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#44269}
2017-03-30 11:44:00 +00:00
"STUB",
Inline Array.prototype.forEach in TurboFan This CL contains a few pieces: - A new mechanism to create "BuiltinContinuation" checkpoints in TurboFan graphs, which--when triggered--swizzle the values in the the FrameState to be parameters to a typically TF-generated builtin that resumes execution to finish the slow-case functionality. - Continuation builtins that have special handling in the deoptimizer and their own new frame type to ensure that the values they need to begin executing can be stashed away and restored immediately before the builtin is called via a trampoline that runs when the continuation builtin's frame execution resumes. - An implementation of Array.prototype.forEach in TurboFan that can be used to inline it. The inlined forEach implementation uses the checkpoints mechanism described above to deopt in the middle of the forEach in the cases that optimization invariants are violated. There is a slightly different continuation stub for each deopt point in the forEach implementation to ensure the correct side-effects, i.e. that the deopt of the builtin isn't programmatically observable. Review-Url: https://codereview.chromium.org/2803853005 Cr-Commit-Position: refs/heads/master@{#45764}
2017-06-07 13:23:33 +00:00
"BUILTIN_CONTINUATION",
"JAVA_SCRIPT_BUILTIN_CONTINUATION",
[promises/deoptimizer] Support "catching" builtin continuations This CL allows builtin continuations to handle pending exceptions. This implements exception handling for the promise constructor in case of deoptimization. Bug: v8:7584 Change-Id: Ib5df5eb6606abb3f9690f294397981858dbdbf25 Reviewed-on: https://chromium-review.googlesource.com/983912 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52340}
2018-04-04 06:31:33 +00:00
"JAVA_SCRIPT_BUILTIN_CONTINUATION_WITH_CATCH",
[tools] Improve grokdump.py - Add new address markers: T: tagged pointer in the minidump C: address into a module in the minidump S: pointer into the exception stack in the minidump *: other address in the minidump - Show ASCII decoding of address in dd - Display potential frame markers on the exception stack: 00000032212fdae8: 0000000300000000 ........ Smi(3) EXIT frame marker - Display relative addresses, useful to detect stack frames: 00000032212fdb68: 00000032212fdb98 S ........ [+6]=00000032212fdcb0 S 00000032212fdb70: 0000010ff5ca0a84 ........ 00000032212fdb78: 000001064c1fa881 ........ 00000032212fdb80: 0000016a8e52fcb1 ........ 00000032212fdb88: 0000010ff5ca0981 ........ 00000032212fdb90: 0000000d00000000 ........ Smi(13) INTERNAL frame marker 00000032212fdb98: 00000032212fdcb0 S ........ [+35]=00000032212fdd61 S Change-Id: I56bd7e6723a34bcb668719246dd5ff2898224928 Reviewed-on: https://chromium-review.googlesource.com/461862 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#44269}
2017-03-30 11:44:00 +00:00
"INTERNAL",
"CONSTRUCT",
"BUILTIN",
"BUILTIN_EXIT",
[cpu-profiler] Introduce NativeFrame type. The new frame type is inteneded to represent native C++ stack frames. JS code may sometimes make calls to helper native functions that do not provide any special stack layout besides the return address and frame pointer. Currently the stack iterator bails out when it sees an unknown frame. The patch allows the iterator to unwind stacks having such frames. BUG=chromium:768540 Change-Id: I9c273c7015695a6733c0a0c52b522fca7b25de0d Reviewed-on: https://chromium-review.googlesource.com/794991 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#50058}
2017-12-12 22:19:44 +00:00
"NATIVE",
[tools] Improve grokdump.py - Add new address markers: T: tagged pointer in the minidump C: address into a module in the minidump S: pointer into the exception stack in the minidump *: other address in the minidump - Show ASCII decoding of address in dd - Display potential frame markers on the exception stack: 00000032212fdae8: 0000000300000000 ........ Smi(3) EXIT frame marker - Display relative addresses, useful to detect stack frames: 00000032212fdb68: 00000032212fdb98 S ........ [+6]=00000032212fdcb0 S 00000032212fdb70: 0000010ff5ca0a84 ........ 00000032212fdb78: 000001064c1fa881 ........ 00000032212fdb80: 0000016a8e52fcb1 ........ 00000032212fdb88: 0000010ff5ca0981 ........ 00000032212fdb90: 0000000d00000000 ........ Smi(13) INTERNAL frame marker 00000032212fdb98: 00000032212fdcb0 S ........ [+35]=00000032212fdd61 S Change-Id: I56bd7e6723a34bcb668719246dd5ff2898224928 Reviewed-on: https://chromium-review.googlesource.com/461862 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#44269}
2017-03-30 11:44:00 +00:00
)
Introduce mkgrokdump to update tools/v8heapconst.py. - Migrate make grokdump to GYP and GN - Move code from d8 into stand-alone execution - Add test case to ensure it's up-to-date Review-Url: https://codereview.chromium.org/2809653003 Cr-Original-Original-Commit-Position: refs/heads/master@{#44687} Committed: https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df5e42a Review-Url: https://codereview.chromium.org/2809653003 Cr-Original-Commit-Position: refs/heads/master@{#44710} Committed: https://chromium.googlesource.com/v8/v8/+/477f00557458d383bd9ebef281890ba485ee882a Review-Url: https://codereview.chromium.org/2809653003 Cr-Commit-Position: refs/heads/master@{#44738}
2017-04-20 06:14:53 +00:00
# This set of constants is generated from a shipping build.
Reference in New Issue Copy Permalink