v8/test/unittests/runtime/runtime-debug-unittest.cc

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

59 lines
1.7 KiB
C++
Raw Normal View History

// Copyright 2021 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Revert "[include] Split out v8.h" This reverts commit d1b27019d3bf86360ea838c317f8505fac6d3a7e. Reason for revert: Broke vtune build, tsan build and possibly others Original change's description: > [include] Split out v8.h > > This moves every single class/function out of include/v8.h into a > separate header in include/, which v8.h then includes so that > externally nothing appears to have changed. > > Every include of v8.h from inside v8 has been changed to a more > fine-grained include. > > Previously inline functions defined at the bottom of v8.h would call > private non-inline functions in the V8 class. Since that class is now > in v8-initialization.h and is rarely included (as that would create > dependency cycles), this is not possible and so those methods have been > moved out of the V8 class into the namespace v8::api_internal. > > None of the previous files in include/ now #include v8.h, which means > if embedders were relying on this transitive dependency then it will > give compile failures. > > v8-inspector.h does depend on v8-scripts.h for the time being to ensure > that Chrome continue to compile but that change will be reverted once > those transitive #includes in chrome are changed to include it directly. > > Full design: > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing > > Bug: v8:11965 > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76424} Bug: v8:11965 Change-Id: Id57313ae992e720c8b19abc975cd69729e1344aa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113627 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#76428}
2021-08-23 11:52:36 +00:00
#include "include/v8.h"
#include "src/api/api.h"
#include "src/objects/objects-inl.h"
#include "src/runtime/runtime.h"
#include "test/unittests/test-utils.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace v8 {
namespace internal {
namespace {
using RuntimeTest = TestWithContext;
TEST_F(RuntimeTest, ReturnsPrototype) {
TryCatch try_catch(isolate());
Local<v8::Object> object = v8::Object::New(isolate());
Handle<JSArray> i_result =
Runtime::GetInternalProperties(i_isolate(), Utils::OpenHandle(*object))
.ToHandleChecked();
Local<Array> result = Utils::ToLocal(i_result);
EXPECT_GE(result->Length(), 1u);
char name_buffer[100];
result->Get(context(), 0)
.ToLocalChecked()
.As<v8::String>()
->WriteUtf8(isolate(), name_buffer);
EXPECT_EQ("[[Prototype]]", std::string(name_buffer));
}
bool AccessCheck(Local<v8::Context> accessing_context,
Local<v8::Object> accessed_object, Local<Value> data) {
return false;
}
TEST_F(RuntimeTest, DoesNotReturnPrototypeWhenInacessible) {
TryCatch try_catch(isolate());
Local<ObjectTemplate> object_template = ObjectTemplate::New(isolate());
object_template->SetAccessCheckCallback(AccessCheck);
Local<v8::Object> object =
object_template->NewInstance(context()).ToLocalChecked();
Handle<JSArray> i_result =
Runtime::GetInternalProperties(i_isolate(), Utils::OpenHandle(*object))
.ToHandleChecked();
Local<Array> result = Utils::ToLocal(i_result);
EXPECT_EQ(0u, result->Length());
}
} // namespace
} // namespace internal
} // namespace v8