2013-07-22 08:32:24 +00:00
|
|
|
// Copyright 2011 the V8 project authors. All rights reserved.
|
|
|
|
// Redistribution and use in source and binary forms, with or without
|
|
|
|
// modification, are permitted provided that the following conditions are
|
|
|
|
// met:
|
|
|
|
//
|
|
|
|
// * Redistributions of source code must retain the above copyright
|
|
|
|
// notice, this list of conditions and the following disclaimer.
|
|
|
|
// * Redistributions in binary form must reproduce the above
|
|
|
|
// copyright notice, this list of conditions and the following
|
|
|
|
// disclaimer in the documentation and/or other materials provided
|
|
|
|
// with the distribution.
|
|
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
|
|
// contributors may be used to endorse or promote products derived
|
|
|
|
// from this software without specific prior written permission.
|
|
|
|
//
|
|
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
|
2013-12-18 08:09:37 +00:00
|
|
|
#include <utility>
|
|
|
|
|
2014-06-03 08:12:43 +00:00
|
|
|
#include "src/v8.h"
|
2013-07-22 08:32:24 +00:00
|
|
|
|
2016-09-01 12:01:33 +00:00
|
|
|
#include "src/factory.h"
|
2014-06-03 08:12:43 +00:00
|
|
|
#include "src/global-handles.h"
|
2016-09-01 12:01:33 +00:00
|
|
|
#include "src/isolate.h"
|
|
|
|
// FIXME(mstarzinger, marja): This is weird, but required because of the missing
|
|
|
|
// (disallowed) include: src/factory.h -> src/objects-inl.h
|
|
|
|
#include "src/objects-inl.h"
|
|
|
|
// FIXME(mstarzinger, marja): This is weird, but required because of the missing
|
2017-02-07 14:05:02 +00:00
|
|
|
// (disallowed) include: src/feedback-vector.h ->
|
|
|
|
// src/feedback-vector-inl.h
|
|
|
|
#include "src/feedback-vector-inl.h"
|
2014-06-03 08:12:43 +00:00
|
|
|
#include "test/cctest/cctest.h"
|
2016-05-20 13:30:22 +00:00
|
|
|
#include "test/cctest/heap/heap-utils.h"
|
2013-07-22 08:32:24 +00:00
|
|
|
|
|
|
|
using namespace v8::internal;
|
|
|
|
|
|
|
|
static Isolate* GetIsolateFrom(LocalContext* context) {
|
|
|
|
return reinterpret_cast<Isolate*>((*context)->GetIsolate());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static Handle<JSWeakSet> AllocateJSWeakSet(Isolate* isolate) {
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
Handle<Map> map = factory->NewMap(JS_WEAK_SET_TYPE, JSWeakSet::kSize);
|
|
|
|
Handle<JSObject> weakset_obj = factory->NewJSObjectFromMap(map);
|
|
|
|
Handle<JSWeakSet> weakset(JSWeakSet::cast(*weakset_obj));
|
2014-05-28 08:35:16 +00:00
|
|
|
// Do not leak handles for the hash table, it would make entries strong.
|
|
|
|
{
|
|
|
|
HandleScope scope(isolate);
|
|
|
|
Handle<ObjectHashTable> table = ObjectHashTable::New(isolate, 1);
|
|
|
|
weakset->set_table(*table);
|
|
|
|
}
|
2013-07-22 08:32:24 +00:00
|
|
|
return weakset;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int NumberOfWeakCalls = 0;
|
2016-05-06 12:29:00 +00:00
|
|
|
static void WeakPointerCallback(const v8::WeakCallbackInfo<void>& data) {
|
2013-12-18 08:09:37 +00:00
|
|
|
std::pair<v8::Persistent<v8::Value>*, int>* p =
|
|
|
|
reinterpret_cast<std::pair<v8::Persistent<v8::Value>*, int>*>(
|
|
|
|
data.GetParameter());
|
2015-12-07 05:36:41 +00:00
|
|
|
CHECK_EQ(1234, p->second);
|
2013-07-22 08:32:24 +00:00
|
|
|
NumberOfWeakCalls++;
|
2013-12-18 08:09:37 +00:00
|
|
|
p->first->Reset();
|
2013-07-22 08:32:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(WeakSet_Weakness) {
|
|
|
|
FLAG_incremental_marking = false;
|
|
|
|
LocalContext context;
|
|
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
HandleScope scope(isolate);
|
|
|
|
Handle<JSWeakSet> weakset = AllocateJSWeakSet(isolate);
|
|
|
|
GlobalHandles* global_handles = isolate->global_handles();
|
|
|
|
|
|
|
|
// Keep global reference to the key.
|
|
|
|
Handle<Object> key;
|
|
|
|
{
|
|
|
|
HandleScope scope(isolate);
|
|
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
|
|
|
key = global_handles->Create(*object);
|
|
|
|
}
|
|
|
|
CHECK(!global_handles->IsWeak(key.location()));
|
|
|
|
|
|
|
|
// Put entry into weak set.
|
|
|
|
{
|
|
|
|
HandleScope scope(isolate);
|
2015-02-05 09:40:13 +00:00
|
|
|
Handle<Smi> smi(Smi::FromInt(23), isolate);
|
Move hash code from hidden string to a private symbol
* Hash code is now just done with a private own symbol instead of the hidden string, which predates symbols.
* In the long run we should do all hidden properties this way and get rid of the
hidden magic 0-length string with the zero hash code. The advantages include
less complexity and being able to do things from JS in a natural way.
* Initially, the performance of weak set regressed, because it's a little harder
to do the lookup in C++. Instead of heroics in C++ to make things faster I
moved some functionality into JS and got the performance back. JS is supposed to be good at looking up named properties on objects.
* This also changes hash codes of Smis so that they are always Smis.
Performance figures are in the comments to the code review. Summary: Most of js-perf-test/Collections is neutral. Set and Map with object keys are 40-50% better. WeakMap is -5% and WeakSet is +9%. After the measurements, I fixed global proxies, which cost 1% on most tests and 5% on the weak ones :-(.
In the code review comments is a patch with an example of the heroics we could do in C++ to make lookup faster (I hope we don't have to do this. Instead of checking for the property, then doing a new lookup to insert it, we could do one lookup and handle the addition immediately). With the current benchmarks above this buys us nothing, but if we go back to doing more lookups in C++ instead of in stubs and JS then it's a win.
In a similar vein we could give the magic zero hash code to the hash code
symbol. Then when we look up the hash code we would sometimes see the table
with all the hidden properties. This dual use of the field for either the hash
code or the table with all hidden properties and the hash code is rather ugly,
and this CL gets rid of it. I'd be loath to bring it back. On the benchmarks quoted above it's slightly slower than moving the hash code lookup to JS like in this CL.
One worry is that the benchmark results above are more monomorphic than real
world code, so may be overstating the performance benefits of moving to JS. I
think this is part of a general issue we have with handling polymorphic code in
JS and any solutions there will benefit this solution, which boils down to
regular property access. Any improvement there will lift all boats.
R=adamk@chromium.org, verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1149863005
Cr-Commit-Position: refs/heads/master@{#28622}
2015-05-26 11:26:26 +00:00
|
|
|
int32_t hash = Object::GetOrCreateHash(isolate, key)->value();
|
2015-08-26 13:18:46 +00:00
|
|
|
JSWeakCollection::Set(weakset, key, smi, hash);
|
2013-07-22 08:32:24 +00:00
|
|
|
}
|
|
|
|
CHECK_EQ(1, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
|
|
|
|
|
|
|
// Force a full GC.
|
2016-09-07 10:02:58 +00:00
|
|
|
CcTest::CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
|
2013-07-22 08:32:24 +00:00
|
|
|
CHECK_EQ(0, NumberOfWeakCalls);
|
|
|
|
CHECK_EQ(1, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
|
|
|
CHECK_EQ(
|
|
|
|
0, ObjectHashTable::cast(weakset->table())->NumberOfDeletedElements());
|
|
|
|
|
|
|
|
// Make the global reference to the key weak.
|
2017-01-25 10:46:01 +00:00
|
|
|
std::pair<Handle<Object>*, int> handle_and_id(&key, 1234);
|
|
|
|
GlobalHandles::MakeWeak(
|
|
|
|
key.location(), reinterpret_cast<void*>(&handle_and_id),
|
|
|
|
&WeakPointerCallback, v8::WeakCallbackType::kParameter);
|
2013-07-22 08:32:24 +00:00
|
|
|
CHECK(global_handles->IsWeak(key.location()));
|
|
|
|
|
2016-09-07 10:02:58 +00:00
|
|
|
CcTest::CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
|
2013-07-22 08:32:24 +00:00
|
|
|
CHECK_EQ(1, NumberOfWeakCalls);
|
|
|
|
CHECK_EQ(0, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
2016-04-15 12:15:54 +00:00
|
|
|
CHECK_EQ(
|
|
|
|
1, ObjectHashTable::cast(weakset->table())->NumberOfDeletedElements());
|
2013-07-22 08:32:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(WeakSet_Shrinking) {
|
|
|
|
LocalContext context;
|
|
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
HandleScope scope(isolate);
|
|
|
|
Handle<JSWeakSet> weakset = AllocateJSWeakSet(isolate);
|
|
|
|
|
|
|
|
// Check initial capacity.
|
|
|
|
CHECK_EQ(32, ObjectHashTable::cast(weakset->table())->Capacity());
|
|
|
|
|
|
|
|
// Fill up weak set to trigger capacity change.
|
|
|
|
{
|
|
|
|
HandleScope scope(isolate);
|
|
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
|
|
for (int i = 0; i < 32; i++) {
|
|
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
2015-02-05 09:40:13 +00:00
|
|
|
Handle<Smi> smi(Smi::FromInt(i), isolate);
|
Move hash code from hidden string to a private symbol
* Hash code is now just done with a private own symbol instead of the hidden string, which predates symbols.
* In the long run we should do all hidden properties this way and get rid of the
hidden magic 0-length string with the zero hash code. The advantages include
less complexity and being able to do things from JS in a natural way.
* Initially, the performance of weak set regressed, because it's a little harder
to do the lookup in C++. Instead of heroics in C++ to make things faster I
moved some functionality into JS and got the performance back. JS is supposed to be good at looking up named properties on objects.
* This also changes hash codes of Smis so that they are always Smis.
Performance figures are in the comments to the code review. Summary: Most of js-perf-test/Collections is neutral. Set and Map with object keys are 40-50% better. WeakMap is -5% and WeakSet is +9%. After the measurements, I fixed global proxies, which cost 1% on most tests and 5% on the weak ones :-(.
In the code review comments is a patch with an example of the heroics we could do in C++ to make lookup faster (I hope we don't have to do this. Instead of checking for the property, then doing a new lookup to insert it, we could do one lookup and handle the addition immediately). With the current benchmarks above this buys us nothing, but if we go back to doing more lookups in C++ instead of in stubs and JS then it's a win.
In a similar vein we could give the magic zero hash code to the hash code
symbol. Then when we look up the hash code we would sometimes see the table
with all the hidden properties. This dual use of the field for either the hash
code or the table with all hidden properties and the hash code is rather ugly,
and this CL gets rid of it. I'd be loath to bring it back. On the benchmarks quoted above it's slightly slower than moving the hash code lookup to JS like in this CL.
One worry is that the benchmark results above are more monomorphic than real
world code, so may be overstating the performance benefits of moving to JS. I
think this is part of a general issue we have with handling polymorphic code in
JS and any solutions there will benefit this solution, which boils down to
regular property access. Any improvement there will lift all boats.
R=adamk@chromium.org, verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1149863005
Cr-Commit-Position: refs/heads/master@{#28622}
2015-05-26 11:26:26 +00:00
|
|
|
int32_t hash = Object::GetOrCreateHash(isolate, object)->value();
|
2015-08-26 13:18:46 +00:00
|
|
|
JSWeakCollection::Set(weakset, object, smi, hash);
|
2013-07-22 08:32:24 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check increased capacity.
|
|
|
|
CHECK_EQ(128, ObjectHashTable::cast(weakset->table())->Capacity());
|
|
|
|
|
|
|
|
// Force a full GC.
|
|
|
|
CHECK_EQ(32, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
|
|
|
CHECK_EQ(
|
|
|
|
0, ObjectHashTable::cast(weakset->table())->NumberOfDeletedElements());
|
2016-09-07 10:02:58 +00:00
|
|
|
CcTest::CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
|
2013-07-22 08:32:24 +00:00
|
|
|
CHECK_EQ(0, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
|
|
|
CHECK_EQ(
|
|
|
|
32, ObjectHashTable::cast(weakset->table())->NumberOfDeletedElements());
|
|
|
|
|
|
|
|
// Check shrunk capacity.
|
|
|
|
CHECK_EQ(32, ObjectHashTable::cast(weakset->table())->Capacity());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// Test that weak set values on an evacuation candidate which are not reachable
|
|
|
|
// by other paths are correctly recorded in the slots buffer.
|
|
|
|
TEST(WeakSet_Regress2060a) {
|
2014-04-14 13:52:41 +00:00
|
|
|
if (i::FLAG_never_compact) return;
|
2013-07-22 08:32:24 +00:00
|
|
|
FLAG_always_compact = true;
|
|
|
|
LocalContext context;
|
|
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
Heap* heap = isolate->heap();
|
|
|
|
HandleScope scope(isolate);
|
2014-05-09 16:39:33 +00:00
|
|
|
Handle<JSFunction> function = factory->NewFunction(
|
|
|
|
factory->function_string());
|
2013-07-22 08:32:24 +00:00
|
|
|
Handle<JSObject> key = factory->NewJSObject(function);
|
|
|
|
Handle<JSWeakSet> weakset = AllocateJSWeakSet(isolate);
|
|
|
|
|
|
|
|
// Start second old-space page so that values land on evacuation candidate.
|
2015-04-07 11:31:57 +00:00
|
|
|
Page* first_page = heap->old_space()->anchor()->next_page();
|
2016-05-20 13:30:22 +00:00
|
|
|
heap::SimulateFullSpace(heap->old_space());
|
2013-07-22 08:32:24 +00:00
|
|
|
|
|
|
|
// Fill up weak set with values on an evacuation candidate.
|
|
|
|
{
|
|
|
|
HandleScope scope(isolate);
|
|
|
|
for (int i = 0; i < 32; i++) {
|
|
|
|
Handle<JSObject> object = factory->NewJSObject(function, TENURED);
|
2016-02-10 09:46:27 +00:00
|
|
|
CHECK(!heap->InNewSpace(*object));
|
2013-07-22 08:32:24 +00:00
|
|
|
CHECK(!first_page->Contains(object->address()));
|
Move hash code from hidden string to a private symbol
* Hash code is now just done with a private own symbol instead of the hidden string, which predates symbols.
* In the long run we should do all hidden properties this way and get rid of the
hidden magic 0-length string with the zero hash code. The advantages include
less complexity and being able to do things from JS in a natural way.
* Initially, the performance of weak set regressed, because it's a little harder
to do the lookup in C++. Instead of heroics in C++ to make things faster I
moved some functionality into JS and got the performance back. JS is supposed to be good at looking up named properties on objects.
* This also changes hash codes of Smis so that they are always Smis.
Performance figures are in the comments to the code review. Summary: Most of js-perf-test/Collections is neutral. Set and Map with object keys are 40-50% better. WeakMap is -5% and WeakSet is +9%. After the measurements, I fixed global proxies, which cost 1% on most tests and 5% on the weak ones :-(.
In the code review comments is a patch with an example of the heroics we could do in C++ to make lookup faster (I hope we don't have to do this. Instead of checking for the property, then doing a new lookup to insert it, we could do one lookup and handle the addition immediately). With the current benchmarks above this buys us nothing, but if we go back to doing more lookups in C++ instead of in stubs and JS then it's a win.
In a similar vein we could give the magic zero hash code to the hash code
symbol. Then when we look up the hash code we would sometimes see the table
with all the hidden properties. This dual use of the field for either the hash
code or the table with all hidden properties and the hash code is rather ugly,
and this CL gets rid of it. I'd be loath to bring it back. On the benchmarks quoted above it's slightly slower than moving the hash code lookup to JS like in this CL.
One worry is that the benchmark results above are more monomorphic than real
world code, so may be overstating the performance benefits of moving to JS. I
think this is part of a general issue we have with handling polymorphic code in
JS and any solutions there will benefit this solution, which boils down to
regular property access. Any improvement there will lift all boats.
R=adamk@chromium.org, verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1149863005
Cr-Commit-Position: refs/heads/master@{#28622}
2015-05-26 11:26:26 +00:00
|
|
|
int32_t hash = Object::GetOrCreateHash(isolate, key)->value();
|
2015-08-26 13:18:46 +00:00
|
|
|
JSWeakCollection::Set(weakset, key, object, hash);
|
2013-07-22 08:32:24 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Force compacting garbage collection.
|
|
|
|
CHECK(FLAG_always_compact);
|
2016-09-07 10:02:58 +00:00
|
|
|
CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask);
|
2013-07-22 08:32:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// Test that weak set keys on an evacuation candidate which are reachable by
|
|
|
|
// other strong paths are correctly recorded in the slots buffer.
|
|
|
|
TEST(WeakSet_Regress2060b) {
|
2014-04-14 13:52:41 +00:00
|
|
|
if (i::FLAG_never_compact) return;
|
2013-07-22 08:32:24 +00:00
|
|
|
FLAG_always_compact = true;
|
|
|
|
#ifdef VERIFY_HEAP
|
|
|
|
FLAG_verify_heap = true;
|
|
|
|
#endif
|
|
|
|
|
|
|
|
LocalContext context;
|
|
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
Heap* heap = isolate->heap();
|
|
|
|
HandleScope scope(isolate);
|
2014-05-09 16:39:33 +00:00
|
|
|
Handle<JSFunction> function = factory->NewFunction(
|
|
|
|
factory->function_string());
|
2013-07-22 08:32:24 +00:00
|
|
|
|
|
|
|
// Start second old-space page so that keys land on evacuation candidate.
|
2015-04-07 11:31:57 +00:00
|
|
|
Page* first_page = heap->old_space()->anchor()->next_page();
|
2016-05-20 13:30:22 +00:00
|
|
|
heap::SimulateFullSpace(heap->old_space());
|
2013-07-22 08:32:24 +00:00
|
|
|
|
|
|
|
// Fill up weak set with keys on an evacuation candidate.
|
|
|
|
Handle<JSObject> keys[32];
|
|
|
|
for (int i = 0; i < 32; i++) {
|
|
|
|
keys[i] = factory->NewJSObject(function, TENURED);
|
2016-02-10 09:46:27 +00:00
|
|
|
CHECK(!heap->InNewSpace(*keys[i]));
|
2013-07-22 08:32:24 +00:00
|
|
|
CHECK(!first_page->Contains(keys[i]->address()));
|
|
|
|
}
|
|
|
|
Handle<JSWeakSet> weakset = AllocateJSWeakSet(isolate);
|
|
|
|
for (int i = 0; i < 32; i++) {
|
2015-02-05 09:40:13 +00:00
|
|
|
Handle<Smi> smi(Smi::FromInt(i), isolate);
|
Move hash code from hidden string to a private symbol
* Hash code is now just done with a private own symbol instead of the hidden string, which predates symbols.
* In the long run we should do all hidden properties this way and get rid of the
hidden magic 0-length string with the zero hash code. The advantages include
less complexity and being able to do things from JS in a natural way.
* Initially, the performance of weak set regressed, because it's a little harder
to do the lookup in C++. Instead of heroics in C++ to make things faster I
moved some functionality into JS and got the performance back. JS is supposed to be good at looking up named properties on objects.
* This also changes hash codes of Smis so that they are always Smis.
Performance figures are in the comments to the code review. Summary: Most of js-perf-test/Collections is neutral. Set and Map with object keys are 40-50% better. WeakMap is -5% and WeakSet is +9%. After the measurements, I fixed global proxies, which cost 1% on most tests and 5% on the weak ones :-(.
In the code review comments is a patch with an example of the heroics we could do in C++ to make lookup faster (I hope we don't have to do this. Instead of checking for the property, then doing a new lookup to insert it, we could do one lookup and handle the addition immediately). With the current benchmarks above this buys us nothing, but if we go back to doing more lookups in C++ instead of in stubs and JS then it's a win.
In a similar vein we could give the magic zero hash code to the hash code
symbol. Then when we look up the hash code we would sometimes see the table
with all the hidden properties. This dual use of the field for either the hash
code or the table with all hidden properties and the hash code is rather ugly,
and this CL gets rid of it. I'd be loath to bring it back. On the benchmarks quoted above it's slightly slower than moving the hash code lookup to JS like in this CL.
One worry is that the benchmark results above are more monomorphic than real
world code, so may be overstating the performance benefits of moving to JS. I
think this is part of a general issue we have with handling polymorphic code in
JS and any solutions there will benefit this solution, which boils down to
regular property access. Any improvement there will lift all boats.
R=adamk@chromium.org, verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1149863005
Cr-Commit-Position: refs/heads/master@{#28622}
2015-05-26 11:26:26 +00:00
|
|
|
int32_t hash = Object::GetOrCreateHash(isolate, keys[i])->value();
|
2015-08-26 13:18:46 +00:00
|
|
|
JSWeakCollection::Set(weakset, keys[i], smi, hash);
|
2013-07-22 08:32:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Force compacting garbage collection. The subsequent collections are used
|
|
|
|
// to verify that key references were actually updated.
|
|
|
|
CHECK(FLAG_always_compact);
|
2016-09-07 10:02:58 +00:00
|
|
|
CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask);
|
|
|
|
CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask);
|
|
|
|
CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask);
|
2013-07-22 08:32:24 +00:00
|
|
|
}
|