2015-10-02 15:14:16 +00:00
|
|
|
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file.
|
|
|
|
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <utility>
|
|
|
|
|
|
|
|
#include "test/cctest/test-api.h"
|
|
|
|
|
|
|
|
#include "src/v8.h"
|
|
|
|
|
|
|
|
#include "src/compilation-cache.h"
|
|
|
|
#include "src/execution.h"
|
|
|
|
#include "src/global-handles.h"
|
2018-04-09 19:11:22 +00:00
|
|
|
#include "src/heap/factory.h"
|
2015-10-02 15:14:16 +00:00
|
|
|
#include "src/ic/stub-cache.h"
|
2017-02-23 11:46:29 +00:00
|
|
|
#include "src/objects-inl.h"
|
2015-10-02 15:14:16 +00:00
|
|
|
|
2017-08-11 11:22:28 +00:00
|
|
|
namespace v8 {
|
|
|
|
namespace internal {
|
2017-09-21 03:29:52 +00:00
|
|
|
namespace test_elements_kind {
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
//
|
|
|
|
// Helper functions.
|
|
|
|
//
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
Handle<String> MakeString(const char* str) {
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
return factory->InternalizeUtf8String(str);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
Handle<String> MakeName(const char* str, int suffix) {
|
|
|
|
EmbeddedVector<char, 128> buffer;
|
|
|
|
SNPrintF(buffer, "%s%d", str, suffix);
|
|
|
|
return MakeString(buffer.start());
|
|
|
|
}
|
|
|
|
|
|
|
|
template <typename T, typename M>
|
2018-06-20 12:44:39 +00:00
|
|
|
bool EQUALS(Isolate* isolate, Handle<T> left, Handle<M> right) {
|
2015-10-02 15:14:16 +00:00
|
|
|
if (*left == *right) return true;
|
2018-06-20 12:44:39 +00:00
|
|
|
return JSObject::Equals(isolate, Handle<Object>::cast(left),
|
2015-10-02 15:14:16 +00:00
|
|
|
Handle<Object>::cast(right))
|
|
|
|
.FromJust();
|
|
|
|
}
|
|
|
|
|
|
|
|
template <typename T, typename M>
|
2018-06-20 12:44:39 +00:00
|
|
|
bool EQUALS(Isolate* isolate, Handle<T> left, M right) {
|
|
|
|
return EQUALS(isolate, left, handle(right, isolate));
|
2015-10-02 15:14:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
template <typename T, typename M>
|
2018-06-20 12:44:39 +00:00
|
|
|
bool EQUALS(Isolate* isolate, T left, Handle<M> right) {
|
|
|
|
return EQUALS(isolate, handle(left, isolate), right);
|
2015-10-02 15:14:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
|
|
|
|
//
|
|
|
|
// Tests
|
|
|
|
//
|
|
|
|
|
|
|
|
TEST(JSObjectAddingProperties) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
|
|
|
|
Handle<FixedArray> empty_fixed_array(factory->empty_fixed_array());
|
2017-07-17 23:30:32 +00:00
|
|
|
Handle<PropertyArray> empty_property_array(factory->empty_property_array());
|
2017-11-08 12:56:08 +00:00
|
|
|
Handle<JSFunction> function =
|
|
|
|
factory->NewFunctionForTest(factory->empty_string());
|
2015-10-02 15:14:16 +00:00
|
|
|
Handle<Object> value(Smi::FromInt(42), isolate);
|
|
|
|
|
|
|
|
Handle<JSObject> object = factory->NewJSObject(function);
|
2018-06-23 09:05:50 +00:00
|
|
|
Handle<Map> previous_map(object->map(), isolate);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, previous_map->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, object->property_array(), empty_property_array));
|
|
|
|
CHECK(EQUALS(isolate, object->elements(), empty_fixed_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// for the default constructor function no in-object properties are reserved
|
|
|
|
// hence adding a single property will initialize the property-array
|
|
|
|
Handle<String> name = MakeName("property", 0);
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(object, name, value, NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_NE(object->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, object->map()->elements_kind());
|
2017-07-11 20:56:40 +00:00
|
|
|
CHECK_LE(1, object->property_array()->length());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, object->elements(), empty_fixed_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(JSObjectInObjectAddingProperties) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
|
|
|
|
Handle<FixedArray> empty_fixed_array(factory->empty_fixed_array());
|
2017-07-17 23:30:32 +00:00
|
|
|
Handle<PropertyArray> empty_property_array(factory->empty_property_array());
|
2017-11-08 12:56:08 +00:00
|
|
|
Handle<JSFunction> function =
|
|
|
|
factory->NewFunctionForTest(factory->empty_string());
|
2015-10-02 15:14:16 +00:00
|
|
|
int nof_inobject_properties = 10;
|
|
|
|
// force in object properties by changing the expected_nof_properties
|
|
|
|
function->shared()->set_expected_nof_properties(nof_inobject_properties);
|
|
|
|
Handle<Object> value(Smi::FromInt(42), isolate);
|
|
|
|
|
|
|
|
Handle<JSObject> object = factory->NewJSObject(function);
|
2018-06-23 09:05:50 +00:00
|
|
|
Handle<Map> previous_map(object->map(), isolate);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, previous_map->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, object->property_array(), empty_property_array));
|
|
|
|
CHECK(EQUALS(isolate, object->elements(), empty_fixed_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// we have reserved space for in-object properties, hence adding up to
|
|
|
|
// |nof_inobject_properties| will not create a property store
|
|
|
|
for (int i = 0; i < nof_inobject_properties; i++) {
|
|
|
|
Handle<String> name = MakeName("property", i);
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(object, name, value, NONE)
|
|
|
|
.Check();
|
|
|
|
}
|
|
|
|
CHECK_NE(object->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, object->map()->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, object->property_array(), empty_property_array));
|
|
|
|
CHECK(EQUALS(isolate, object->elements(), empty_fixed_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// adding one more property will not fit in the in-object properties, thus
|
|
|
|
// creating a property store
|
|
|
|
int index = nof_inobject_properties + 1;
|
|
|
|
Handle<String> name = MakeName("property", index);
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(object, name, value, NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_NE(object->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, object->map()->elements_kind());
|
2015-10-02 15:14:16 +00:00
|
|
|
// there must be at least 1 element in the properies store
|
2017-07-11 20:56:40 +00:00
|
|
|
CHECK_LE(1, object->property_array()->length());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, object->elements(), empty_fixed_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(JSObjectAddingElements) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
|
|
|
|
Handle<String> name;
|
|
|
|
Handle<FixedArray> empty_fixed_array(factory->empty_fixed_array());
|
2017-07-17 23:30:32 +00:00
|
|
|
Handle<PropertyArray> empty_property_array(factory->empty_property_array());
|
2017-11-08 12:56:08 +00:00
|
|
|
Handle<JSFunction> function =
|
|
|
|
factory->NewFunctionForTest(factory->empty_string());
|
2015-10-02 15:14:16 +00:00
|
|
|
Handle<Object> value(Smi::FromInt(42), isolate);
|
|
|
|
|
|
|
|
Handle<JSObject> object = factory->NewJSObject(function);
|
2018-06-23 09:05:50 +00:00
|
|
|
Handle<Map> previous_map(object->map(), isolate);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, previous_map->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, object->property_array(), empty_property_array));
|
|
|
|
CHECK(EQUALS(isolate, object->elements(), empty_fixed_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// Adding an indexed element initializes the elements array
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(object, name, value, NONE)
|
|
|
|
.Check();
|
|
|
|
// no change in elements_kind => no map transition
|
|
|
|
CHECK_EQ(object->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, object->map()->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, object->property_array(), empty_property_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
CHECK_LE(1, object->elements()->length());
|
|
|
|
|
|
|
|
// Adding more consecutive elements without a change in the backing store
|
|
|
|
int non_dict_backing_store_limit = 100;
|
|
|
|
for (int i = 1; i < non_dict_backing_store_limit; i++) {
|
|
|
|
name = MakeName("", i);
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(object, name, value, NONE)
|
|
|
|
.Check();
|
|
|
|
}
|
|
|
|
// no change in elements_kind => no map transition
|
|
|
|
CHECK_EQ(object->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, object->map()->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, object->property_array(), empty_property_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
CHECK_LE(non_dict_backing_store_limit, object->elements()->length());
|
|
|
|
|
|
|
|
// Adding an element at an very large index causes a change to
|
|
|
|
// DICTIONARY_ELEMENTS
|
|
|
|
name = MakeString("100000000");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(object, name, value, NONE)
|
|
|
|
.Check();
|
|
|
|
// change in elements_kind => map transition
|
|
|
|
CHECK_NE(object->map(), *previous_map);
|
2017-02-07 14:20:02 +00:00
|
|
|
CHECK_EQ(DICTIONARY_ELEMENTS, object->map()->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, object->property_array(), empty_property_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
CHECK_LE(non_dict_backing_store_limit, object->elements()->length());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(JSArrayAddingProperties) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
|
|
|
|
Handle<FixedArray> empty_fixed_array(factory->empty_fixed_array());
|
2017-07-17 23:30:32 +00:00
|
|
|
Handle<PropertyArray> empty_property_array(factory->empty_property_array());
|
2015-10-02 15:14:16 +00:00
|
|
|
Handle<Object> value(Smi::FromInt(42), isolate);
|
|
|
|
|
|
|
|
Handle<JSArray> array =
|
2017-06-30 11:26:14 +00:00
|
|
|
factory->NewJSArray(ElementsKind::PACKED_SMI_ELEMENTS, 0, 0);
|
2018-06-23 09:05:50 +00:00
|
|
|
Handle<Map> previous_map(array->map(), isolate);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_SMI_ELEMENTS, previous_map->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, array->property_array(), empty_property_array));
|
|
|
|
CHECK(EQUALS(isolate, array->elements(), empty_fixed_array));
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(0, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// for the default constructor function no in-object properties are reserved
|
|
|
|
// hence adding a single property will initialize the property-array
|
|
|
|
Handle<String> name = MakeName("property", 0);
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value, NONE)
|
|
|
|
.Check();
|
|
|
|
// No change in elements_kind but added property => new map
|
|
|
|
CHECK_NE(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_SMI_ELEMENTS, array->map()->elements_kind());
|
2017-07-11 20:56:40 +00:00
|
|
|
CHECK_LE(1, array->property_array()->length());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, array->elements(), empty_fixed_array));
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(0, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(JSArrayAddingElements) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
|
|
|
|
Handle<String> name;
|
|
|
|
Handle<FixedArray> empty_fixed_array(factory->empty_fixed_array());
|
2017-07-17 23:30:32 +00:00
|
|
|
Handle<PropertyArray> empty_property_array(factory->empty_property_array());
|
2015-10-02 15:14:16 +00:00
|
|
|
Handle<Object> value(Smi::FromInt(42), isolate);
|
|
|
|
|
|
|
|
Handle<JSArray> array =
|
2017-06-30 11:26:14 +00:00
|
|
|
factory->NewJSArray(ElementsKind::PACKED_SMI_ELEMENTS, 0, 0);
|
2018-06-23 09:05:50 +00:00
|
|
|
Handle<Map> previous_map(array->map(), isolate);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_SMI_ELEMENTS, previous_map->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, array->property_array(), empty_property_array));
|
|
|
|
CHECK(EQUALS(isolate, array->elements(), empty_fixed_array));
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(0, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// Adding an indexed element initializes the elements array
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value, NONE)
|
|
|
|
.Check();
|
|
|
|
// no change in elements_kind => no map transition
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_SMI_ELEMENTS, array->map()->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, array->property_array(), empty_property_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
CHECK_LE(1, array->elements()->length());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(1, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// Adding more consecutive elements without a change in the backing store
|
|
|
|
int non_dict_backing_store_limit = 100;
|
|
|
|
for (int i = 1; i < non_dict_backing_store_limit; i++) {
|
|
|
|
name = MakeName("", i);
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value, NONE)
|
|
|
|
.Check();
|
|
|
|
}
|
|
|
|
// no change in elements_kind => no map transition
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_SMI_ELEMENTS, array->map()->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, array->property_array(), empty_property_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
CHECK_LE(non_dict_backing_store_limit, array->elements()->length());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(non_dict_backing_store_limit, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// Adding an element at an very large index causes a change to
|
|
|
|
// DICTIONARY_ELEMENTS
|
|
|
|
int index = 100000000;
|
|
|
|
name = MakeName("", index);
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value, NONE)
|
|
|
|
.Check();
|
|
|
|
// change in elements_kind => map transition
|
|
|
|
CHECK_NE(array->map(), *previous_map);
|
2017-02-07 14:20:02 +00:00
|
|
|
CHECK_EQ(DICTIONARY_ELEMENTS, array->map()->elements_kind());
|
2018-06-20 12:44:39 +00:00
|
|
|
CHECK(EQUALS(isolate, array->property_array(), empty_property_array));
|
2015-10-02 15:14:16 +00:00
|
|
|
CHECK_LE(non_dict_backing_store_limit, array->elements()->length());
|
|
|
|
CHECK_LE(array->elements()->length(), index);
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(index + 1, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(JSArrayAddingElementsGeneralizingiFastSmiElements) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
|
|
|
|
Handle<String> name;
|
|
|
|
Handle<Object> value_smi(Smi::FromInt(42), isolate);
|
|
|
|
Handle<Object> value_string(MakeString("value"));
|
|
|
|
Handle<Object> value_double = factory->NewNumber(3.1415);
|
|
|
|
|
|
|
|
Handle<JSArray> array =
|
2017-06-30 11:26:14 +00:00
|
|
|
factory->NewJSArray(ElementsKind::PACKED_SMI_ELEMENTS, 0, 0);
|
2018-06-23 09:05:50 +00:00
|
|
|
Handle<Map> previous_map(array->map(), isolate);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_SMI_ELEMENTS, previous_map->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(0, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// `array[0] = smi_value` doesn't change the elements_kind
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_smi,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
// no change in elements_kind => no map transition
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_SMI_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(1, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// `delete array[0]` does not alter length, but changes the elments_kind
|
|
|
|
name = MakeString("0");
|
2015-11-26 09:34:11 +00:00
|
|
|
CHECK(JSReceiver::DeletePropertyOrElement(array, name).FromMaybe(false));
|
2015-10-02 15:14:16 +00:00
|
|
|
CHECK_NE(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_SMI_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(1, Smi::ToInt(array->length()));
|
2018-06-11 09:53:20 +00:00
|
|
|
previous_map = handle(array->map(), isolate);
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// add a couple of elements again
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_smi,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
name = MakeString("1");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_smi,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_SMI_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(2, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// Adding a string to the array changes from FAST_HOLEY_SMI to FAST_HOLEY
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_string,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_NE(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(2, Smi::ToInt(array->length()));
|
2018-06-11 09:53:20 +00:00
|
|
|
previous_map = handle(array->map(), isolate);
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// We don't transition back to FAST_SMI even if we remove the string
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_smi,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
|
|
|
|
|
|
|
// Adding a double doesn't change the map either
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_double,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(JSArrayAddingElementsGeneralizingFastElements) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
|
|
|
|
Handle<String> name;
|
|
|
|
Handle<Object> value_smi(Smi::FromInt(42), isolate);
|
|
|
|
Handle<Object> value_string(MakeString("value"));
|
|
|
|
|
|
|
|
Handle<JSArray> array =
|
2017-06-30 11:26:14 +00:00
|
|
|
factory->NewJSArray(ElementsKind::PACKED_ELEMENTS, 0, 0);
|
2018-06-23 09:05:50 +00:00
|
|
|
Handle<Map> previous_map(array->map(), isolate);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_ELEMENTS, previous_map->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(0, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// `array[0] = smi_value` doesn't change the elements_kind
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_smi,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
// no change in elements_kind => no map transition
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(1, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// `delete array[0]` does not alter length, but changes the elments_kind
|
|
|
|
name = MakeString("0");
|
2015-11-26 09:34:11 +00:00
|
|
|
CHECK(JSReceiver::DeletePropertyOrElement(array, name).FromMaybe(false));
|
2015-10-02 15:14:16 +00:00
|
|
|
CHECK_NE(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(1, Smi::ToInt(array->length()));
|
2018-06-11 09:53:20 +00:00
|
|
|
previous_map = handle(array->map(), isolate);
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// add a couple of elements, elements_kind stays HOLEY
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_string,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
name = MakeString("1");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_smi,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(2, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST(JSArrayAddingElementsGeneralizingiFastDoubleElements) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
|
|
|
|
Handle<String> name;
|
|
|
|
Handle<Object> value_smi(Smi::FromInt(42), isolate);
|
|
|
|
Handle<Object> value_string(MakeString("value"));
|
|
|
|
Handle<Object> value_double = factory->NewNumber(3.1415);
|
|
|
|
|
|
|
|
Handle<JSArray> array =
|
2017-06-30 11:26:14 +00:00
|
|
|
factory->NewJSArray(ElementsKind::PACKED_SMI_ELEMENTS, 0, 0);
|
2018-06-23 09:05:50 +00:00
|
|
|
Handle<Map> previous_map(array->map(), isolate);
|
2015-10-02 15:14:16 +00:00
|
|
|
|
2017-06-30 11:26:14 +00:00
|
|
|
// `array[0] = value_double` changes |elements_kind| to PACKED_DOUBLE_ELEMENTS
|
2015-10-02 15:14:16 +00:00
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_double,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_NE(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_DOUBLE_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(1, Smi::ToInt(array->length()));
|
2018-06-11 09:53:20 +00:00
|
|
|
previous_map = handle(array->map(), isolate);
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// `array[1] = value_smi` doesn't alter the |elements_kind|
|
|
|
|
name = MakeString("1");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_smi,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(PACKED_DOUBLE_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(2, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// `delete array[0]` does not alter length, but changes the elments_kind
|
|
|
|
name = MakeString("0");
|
2015-11-26 09:34:11 +00:00
|
|
|
CHECK(JSReceiver::DeletePropertyOrElement(array, name).FromMaybe(false));
|
2015-10-02 15:14:16 +00:00
|
|
|
CHECK_NE(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_DOUBLE_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(2, Smi::ToInt(array->length()));
|
2018-06-11 09:53:20 +00:00
|
|
|
previous_map = handle(array->map(), isolate);
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// filling the hole `array[0] = value_smi` again doesn't transition back
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_double,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_DOUBLE_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(2, Smi::ToInt(array->length()));
|
2015-10-02 15:14:16 +00:00
|
|
|
|
2017-06-30 11:26:14 +00:00
|
|
|
// Adding a string to the array changes to elements_kind PACKED_ELEMENTS
|
2015-10-02 15:14:16 +00:00
|
|
|
name = MakeString("1");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_string,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_NE(array->map(), *previous_map);
|
2017-06-30 11:26:14 +00:00
|
|
|
CHECK_EQ(HOLEY_ELEMENTS, array->map()->elements_kind());
|
2017-07-10 12:58:27 +00:00
|
|
|
CHECK_EQ(2, Smi::ToInt(array->length()));
|
2018-06-11 09:53:20 +00:00
|
|
|
previous_map = handle(array->map(), isolate);
|
2015-10-02 15:14:16 +00:00
|
|
|
|
|
|
|
// Adding a double doesn't change the map
|
|
|
|
name = MakeString("0");
|
|
|
|
JSObject::DefinePropertyOrElementIgnoreAttributes(array, name, value_double,
|
|
|
|
NONE)
|
|
|
|
.Check();
|
|
|
|
CHECK_EQ(array->map(), *previous_map);
|
|
|
|
}
|
2017-08-11 11:22:28 +00:00
|
|
|
|
2017-09-21 03:29:52 +00:00
|
|
|
} // namespace test_elements_kind
|
2017-08-11 11:22:28 +00:00
|
|
|
} // namespace internal
|
|
|
|
} // namespace v8
|