2016-04-19 14:19:58 +00:00
|
|
|
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file.
|
|
|
|
|
2017-02-23 11:46:29 +00:00
|
|
|
#include "src/assembler-inl.h"
|
2016-04-19 14:19:58 +00:00
|
|
|
#include "test/cctest/cctest.h"
|
|
|
|
#include "test/cctest/compiler/value-helper.h"
|
|
|
|
#include "test/cctest/wasm/wasm-run-utils.h"
|
2016-10-05 11:59:47 +00:00
|
|
|
#include "test/common/wasm/test-signatures.h"
|
2017-04-25 11:29:17 +00:00
|
|
|
#include "test/common/wasm/wasm-macro-gen.h"
|
2016-04-19 14:19:58 +00:00
|
|
|
|
|
|
|
using namespace v8::base;
|
|
|
|
using namespace v8::internal;
|
|
|
|
using namespace v8::internal::compiler;
|
|
|
|
using namespace v8::internal::wasm;
|
|
|
|
|
|
|
|
using v8::Local;
|
|
|
|
using v8::Utils;
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
#define CHECK_CSTREQ(exp, found) \
|
|
|
|
do { \
|
|
|
|
const char* exp_ = (exp); \
|
|
|
|
const char* found_ = (found); \
|
2016-05-06 09:07:30 +00:00
|
|
|
DCHECK_NOT_NULL(exp); \
|
|
|
|
if (V8_UNLIKELY(found_ == nullptr || strcmp(exp_, found_) != 0)) { \
|
2016-04-19 14:19:58 +00:00
|
|
|
V8_Fatal(__FILE__, __LINE__, \
|
|
|
|
"Check failed: (%s) != (%s) ('%s' vs '%s').", #exp, #found, \
|
2016-05-06 09:07:30 +00:00
|
|
|
exp_, found_ ? found_ : "<null>"); \
|
2016-04-19 14:19:58 +00:00
|
|
|
} \
|
|
|
|
} while (0)
|
|
|
|
|
2017-08-24 21:49:48 +00:00
|
|
|
void PrintStackTrace(v8::Isolate* isolate, v8::Local<v8::StackTrace> stack) {
|
2016-04-19 14:19:58 +00:00
|
|
|
printf("Stack Trace (length %d):\n", stack->GetFrameCount());
|
|
|
|
for (int i = 0, e = stack->GetFrameCount(); i != e; ++i) {
|
|
|
|
v8::Local<v8::StackFrame> frame = stack->GetFrame(i);
|
|
|
|
v8::Local<v8::String> script = frame->GetScriptName();
|
|
|
|
v8::Local<v8::String> func = frame->GetFunctionName();
|
2017-08-24 21:49:48 +00:00
|
|
|
printf(
|
|
|
|
"[%d] (%s) %s:%d:%d\n", i,
|
|
|
|
script.IsEmpty() ? "<null>" : *v8::String::Utf8Value(isolate, script),
|
|
|
|
func.IsEmpty() ? "<null>" : *v8::String::Utf8Value(isolate, func),
|
|
|
|
frame->GetLineNumber(), frame->GetColumn());
|
2016-04-19 14:19:58 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct ExceptionInfo {
|
2016-05-06 09:07:30 +00:00
|
|
|
const char* func_name;
|
2017-08-31 10:28:47 +00:00
|
|
|
int line_nr; // 1-based
|
|
|
|
int column; // 1-based
|
2016-04-19 14:19:58 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
template <int N>
|
2017-08-24 21:49:48 +00:00
|
|
|
void CheckExceptionInfos(v8::internal::Isolate* i_isolate, Handle<Object> exc,
|
2016-04-19 14:19:58 +00:00
|
|
|
const ExceptionInfo (&excInfos)[N]) {
|
2016-04-20 15:09:36 +00:00
|
|
|
// Check that it's indeed an Error object.
|
2016-06-27 09:31:59 +00:00
|
|
|
CHECK(exc->IsJSError());
|
2016-04-19 14:19:58 +00:00
|
|
|
|
2017-08-24 21:49:48 +00:00
|
|
|
v8::Isolate* v8_isolate = reinterpret_cast<v8::Isolate*>(i_isolate);
|
|
|
|
|
2016-04-20 15:09:36 +00:00
|
|
|
// Extract stack frame from the exception.
|
2016-04-19 14:19:58 +00:00
|
|
|
Local<v8::Value> localExc = Utils::ToLocal(exc);
|
|
|
|
v8::Local<v8::StackTrace> stack = v8::Exception::GetStackTrace(localExc);
|
2017-08-24 21:49:48 +00:00
|
|
|
PrintStackTrace(v8_isolate, stack);
|
2016-04-19 14:19:58 +00:00
|
|
|
CHECK(!stack.IsEmpty());
|
|
|
|
CHECK_EQ(N, stack->GetFrameCount());
|
|
|
|
|
|
|
|
for (int frameNr = 0; frameNr < N; ++frameNr) {
|
|
|
|
v8::Local<v8::StackFrame> frame = stack->GetFrame(frameNr);
|
2017-08-24 21:49:48 +00:00
|
|
|
v8::String::Utf8Value funName(v8_isolate, frame->GetFunctionName());
|
2016-05-06 09:07:30 +00:00
|
|
|
CHECK_CSTREQ(excInfos[frameNr].func_name, *funName);
|
2017-08-31 10:28:47 +00:00
|
|
|
// Line and column are 1-based in v8::StackFrame, just as in ExceptionInfo.
|
2016-05-06 09:07:30 +00:00
|
|
|
CHECK_EQ(excInfos[frameNr].line_nr, frame->GetLineNumber());
|
|
|
|
CHECK_EQ(excInfos[frameNr].column, frame->GetColumn());
|
2016-04-19 14:19:58 +00:00
|
|
|
}
|
2017-08-31 10:28:47 +00:00
|
|
|
|
|
|
|
CheckComputeLocation(i_isolate, exc, excInfos[0]);
|
|
|
|
}
|
|
|
|
|
|
|
|
void CheckComputeLocation(v8::internal::Isolate* i_isolate, Handle<Object> exc,
|
|
|
|
const ExceptionInfo& topLocation) {
|
|
|
|
MessageLocation loc;
|
|
|
|
CHECK(i_isolate->ComputeLocationFromStackTrace(&loc, exc));
|
|
|
|
printf("loc start: %d, end: %d\n", loc.start_pos(), loc.end_pos());
|
|
|
|
Handle<JSMessageObject> message = i_isolate->CreateMessage(exc, nullptr);
|
|
|
|
printf("msg start: %d, end: %d, line: %d, col: %d\n",
|
|
|
|
message->start_position(), message->end_position(),
|
|
|
|
message->GetLineNumber(), message->GetColumnNumber());
|
|
|
|
CHECK_EQ(loc.start_pos(), message->start_position());
|
|
|
|
CHECK_EQ(loc.end_pos(), message->end_position());
|
|
|
|
// In the message, the line is 1-based, but the column is 0-based.
|
|
|
|
CHECK_EQ(topLocation.line_nr, message->GetLineNumber());
|
|
|
|
CHECK_LE(1, topLocation.column);
|
|
|
|
CHECK_EQ(topLocation.column - 1, message->GetColumnNumber());
|
2016-04-19 14:19:58 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
2017-06-09 12:21:52 +00:00
|
|
|
// Call from JS to wasm to JS and throw an Error from JS.
|
2016-04-19 14:19:58 +00:00
|
|
|
TEST(CollectDetailedWasmStack_ExplicitThrowFromJs) {
|
2016-12-16 10:13:11 +00:00
|
|
|
WasmRunner<void> r(kExecuteCompiled);
|
2016-04-19 14:19:58 +00:00
|
|
|
TestSignatures sigs;
|
|
|
|
|
2017-08-19 16:34:11 +00:00
|
|
|
uint32_t js_throwing_index = r.builder().AddJsFunction(
|
2016-04-19 14:19:58 +00:00
|
|
|
sigs.v_v(),
|
Revert "[wasm] Reland "[wasm] redirect wasm calls to js functions through a GCed table""
This reverts commit 649b1e70e73dbdc98fe9655f454f0ace0113c990.
Reason for revert: A1 Jetstream bots are still failing.
Original change's description:
> [wasm] Reland "[wasm] redirect wasm calls to js functions through a GCed table"
>
> This reverts commit 25f03308a7c34df996e93178ba4d29de8949349a.
>
> Reason for revert: Fix the cause of bot failure and reland
>
> Original change's description:
> > Revert "[wasm] redirect wasm calls to js functions through a GCed table"
> >
> > This reverts commit eb65f35e96a417b7792400a3867560248d9809f2.
> >
> > Reason for revert: Broke jetstream benchmark on android.
> >
> > BUG=chromium:750828
> >
> > Original change's description:
> > > [wasm] redirect wasm calls to js functions through a GCed table
> > >
> > > With this patch, rather than embedding the JSReceiver address directly
> > > in the WasmToJS wrappers, we put that in a fixed array with global handle
> > > scope and instead embed the location of the handle and the index in the
> > > wrapper. This ensures that the wrapper doesn't need to be patched if the
> > > GC kicks in. This is needed to get the WASM code off the GCed heap.
> > >
> > > R=mtrofin@chromium.org
> > >
> > > Bug:
> > > Change-Id: Ie5a77a78cdecec51b04f702c63b8e4285e6a2d8d
> > > Reviewed-on: https://chromium-review.googlesource.com/581682
> > > Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
> > > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#46884}
> >
> > TBR=mtrofin@chromium.org,aseemgarg@google.com,aseemgarg@chromium.org,clemensh@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Change-Id: I26f49ee0a1fe73cc5d8852ded87b56638be39ebf
> > Reviewed-on: https://chromium-review.googlesource.com/596268
> > Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#47059}
>
> R=mtrofin@chromium.org,aseemgarg@google.com,aseemgarg@chromium.org,clemensh@chromium.org,sullivan@chromium.org
>
> Change-Id: I29ef35f6e612a706d9f571da3e7beb1da8b5052b
> Bug: chromium:750828
> Reviewed-on: https://chromium-review.googlesource.com/597010
> Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
> Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#47177}
TBR=bradnelson@chromium.org,sullivan@chromium.org,mtrofin@chromium.org,aseemgarg@google.com,aseemgarg@chromium.org,clemensh@chromium.org
Bug: chromium:750828
Change-Id: I04b12c0eb0705ad809822a7d7461423be77d942a
Reviewed-on: https://chromium-review.googlesource.com/606867
Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
Reviewed-by: Aseem Garg <aseemgarg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47231}
2017-08-08 19:01:16 +00:00
|
|
|
"(function js() {\n function a() {\n throw new Error(); };\n a(); })");
|
2016-04-19 14:19:58 +00:00
|
|
|
|
2016-05-06 09:07:30 +00:00
|
|
|
// Add a nop such that we don't always get position 1.
|
2016-12-16 10:13:11 +00:00
|
|
|
BUILD(r, WASM_NOP, WASM_CALL_FUNCTION0(js_throwing_index));
|
|
|
|
uint32_t wasm_index_1 = r.function()->func_index;
|
2016-04-19 14:19:58 +00:00
|
|
|
|
2016-12-19 15:03:13 +00:00
|
|
|
WasmFunctionCompiler& f2 = r.NewFunction<void>("call_main");
|
2016-12-16 10:13:11 +00:00
|
|
|
BUILD(f2, WASM_CALL_FUNCTION0(wasm_index_1));
|
|
|
|
uint32_t wasm_index_2 = f2.function_index();
|
2016-04-19 14:19:58 +00:00
|
|
|
|
2017-08-19 16:34:11 +00:00
|
|
|
Handle<JSFunction> js_wasm_wrapper = r.builder().WrapCode(wasm_index_2);
|
2016-04-19 14:19:58 +00:00
|
|
|
|
2016-04-20 15:09:36 +00:00
|
|
|
Handle<JSFunction> js_trampoline = Handle<JSFunction>::cast(
|
2016-04-19 14:19:58 +00:00
|
|
|
v8::Utils::OpenHandle(*v8::Local<v8::Function>::Cast(
|
|
|
|
CompileRun("(function callFn(fn) { fn(); })"))));
|
|
|
|
|
2016-04-20 15:09:36 +00:00
|
|
|
Isolate* isolate = js_wasm_wrapper->GetIsolate();
|
2016-04-19 14:19:58 +00:00
|
|
|
isolate->SetCaptureStackTraceForUncaughtExceptions(true, 10,
|
|
|
|
v8::StackTrace::kOverview);
|
|
|
|
Handle<Object> global(isolate->context()->global_object(), isolate);
|
2016-04-20 15:09:36 +00:00
|
|
|
MaybeHandle<Object> maybe_exc;
|
|
|
|
Handle<Object> args[] = {js_wasm_wrapper};
|
2016-04-19 14:19:58 +00:00
|
|
|
MaybeHandle<Object> returnObjMaybe =
|
2017-01-17 13:01:03 +00:00
|
|
|
Execution::TryCall(isolate, js_trampoline, global, 1, args,
|
|
|
|
Execution::MessageHandling::kReport, &maybe_exc);
|
2016-04-19 14:19:58 +00:00
|
|
|
CHECK(returnObjMaybe.is_null());
|
|
|
|
|
2016-11-14 16:00:03 +00:00
|
|
|
// Line and column are 1-based, so add 1 for the expected wasm output.
|
2016-04-20 15:09:36 +00:00
|
|
|
ExceptionInfo expected_exceptions[] = {
|
2016-12-19 15:03:13 +00:00
|
|
|
{"a", 3, 8}, // -
|
|
|
|
{"js", 4, 2}, // -
|
|
|
|
{"main", static_cast<int>(wasm_index_1) + 1, 3}, // -
|
|
|
|
{"call_main", static_cast<int>(wasm_index_2) + 1, 2}, // -
|
|
|
|
{"callFn", 1, 24} // -
|
2016-05-06 09:07:30 +00:00
|
|
|
};
|
2017-08-24 21:49:48 +00:00
|
|
|
CheckExceptionInfos(isolate, maybe_exc.ToHandleChecked(),
|
|
|
|
expected_exceptions);
|
2016-04-20 15:09:36 +00:00
|
|
|
}
|
|
|
|
|
2017-06-09 12:21:52 +00:00
|
|
|
// Trigger a trap in wasm, stack should be JS -> wasm -> wasm.
|
2016-04-20 15:09:36 +00:00
|
|
|
TEST(CollectDetailedWasmStack_WasmError) {
|
2017-08-31 10:28:47 +00:00
|
|
|
for (int pos_shift = 0; pos_shift < 3; ++pos_shift) {
|
|
|
|
// Test a position with 1, 2 or 3 bytes needed to represent it.
|
|
|
|
int unreachable_pos = 1 << (8 * pos_shift);
|
|
|
|
TestSignatures sigs;
|
|
|
|
// Create a WasmRunner with stack checks and traps enabled.
|
|
|
|
WasmRunner<int> r(kExecuteCompiled, "main", true);
|
|
|
|
|
|
|
|
std::vector<byte> code(unreachable_pos + 1, kExprNop);
|
|
|
|
code[unreachable_pos] = kExprUnreachable;
|
|
|
|
r.Build(code.data(), code.data() + code.size());
|
|
|
|
|
|
|
|
uint32_t wasm_index_1 = r.function()->func_index;
|
|
|
|
|
|
|
|
WasmFunctionCompiler& f2 = r.NewFunction<int>("call_main");
|
|
|
|
BUILD(f2, WASM_CALL_FUNCTION0(0));
|
|
|
|
uint32_t wasm_index_2 = f2.function_index();
|
|
|
|
|
|
|
|
Handle<JSFunction> js_wasm_wrapper = r.builder().WrapCode(wasm_index_2);
|
|
|
|
|
|
|
|
Handle<JSFunction> js_trampoline = Handle<JSFunction>::cast(
|
|
|
|
v8::Utils::OpenHandle(*v8::Local<v8::Function>::Cast(
|
|
|
|
CompileRun("(function callFn(fn) { fn(); })"))));
|
|
|
|
|
|
|
|
Isolate* isolate = js_wasm_wrapper->GetIsolate();
|
|
|
|
isolate->SetCaptureStackTraceForUncaughtExceptions(
|
|
|
|
true, 10, v8::StackTrace::kOverview);
|
|
|
|
Handle<Object> global(isolate->context()->global_object(), isolate);
|
|
|
|
MaybeHandle<Object> maybe_exc;
|
|
|
|
Handle<Object> args[] = {js_wasm_wrapper};
|
|
|
|
MaybeHandle<Object> maybe_return_obj =
|
|
|
|
Execution::TryCall(isolate, js_trampoline, global, 1, args,
|
|
|
|
Execution::MessageHandling::kReport, &maybe_exc);
|
|
|
|
CHECK(maybe_return_obj.is_null());
|
|
|
|
Handle<Object> exception = maybe_exc.ToHandleChecked();
|
|
|
|
|
|
|
|
static constexpr int kMainLocalsLength = 1;
|
|
|
|
// Line and column are 1-based, so add 1 for the expected wasm output.
|
|
|
|
const int expected_main_pos = unreachable_pos + kMainLocalsLength + 1;
|
|
|
|
ExceptionInfo expected_exceptions[] = {
|
|
|
|
{"main", static_cast<int>(wasm_index_1) + 1, expected_main_pos}, // -
|
|
|
|
{"call_main", static_cast<int>(wasm_index_2) + 1, 2}, // -
|
|
|
|
{"callFn", 1, 24} //-
|
|
|
|
};
|
|
|
|
CheckExceptionInfos(isolate, exception, expected_exceptions);
|
|
|
|
}
|
2016-04-19 14:19:58 +00:00
|
|
|
}
|