AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
6d1522d500
v8/src/external-reference-table.cc

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

452 lines
19 KiB
C++
Raw Normal View History

Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "src/external-reference-table.h"
#include "src/accessors.h"
#include "src/assembler.h"
#include "src/counters.h"
#include "src/ic/stub-cache.h"
[wasm] use ccall to set/clear thread in wasm flag CCalls have significantly less overhead than runtime calls which will improve runtime performance on programs that make lots of transitions between JS and Wasm. Bug: v8:5277 Change-Id: If09dea97f24eb43753847e2b894ebc1ba5168c23 Reviewed-on: https://chromium-review.googlesource.com/688481 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48297}
2017-10-04 21:08:55 +00:00
#include "src/trap-handler/trap-handler.h"
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
[serializer] print use count of external references. R=peria@chromium.org, vogelheim@chromium.org BUG=chromium:617892 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2495213003 Cr-Commit-Position: refs/heads/master@{#40981}
2016-11-15 08:58:54 +00:00
#if defined(DEBUG) && defined(V8_OS_LINUX) && !defined(V8_OS_ANDROID)
#define SYMBOLIZE_FUNCTION
#include <execinfo.h>
Release malloced symbol tables Bug:chromium:617892 Change-Id: I9993191fb632ca49f020e8073e7e409c86932a29 Reviewed-on: https://chromium-review.googlesource.com/485202 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#44827}
2017-04-25 03:01:11 +00:00
#include <vector>
[serializer] print use count of external references. R=peria@chromium.org, vogelheim@chromium.org BUG=chromium:617892 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2495213003 Cr-Commit-Position: refs/heads/master@{#40981}
2016-11-15 08:58:54 +00:00
#endif // DEBUG && V8_OS_LINUX && !V8_OS_ANDROID
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
namespace v8 {
namespace internal {
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
// Forward declarations for C++ builtins.
#define FORWARD_DECLARE(Name) \
Object* Builtin_##Name(int argc, Object** args, Isolate* isolate);
BUILTIN_LIST_C(FORWARD_DECLARE)
#undef FORWARD_DECLARE
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
ExternalReferenceTable* ExternalReferenceTable::instance(Isolate* isolate) {
ExternalReferenceTable* external_reference_table =
isolate->external_reference_table();
Use nullptr instead of NULL where possible New code should use nullptr instead of NULL. This patch updates existing use of NULL to nullptr where applicable, making the code base more consistent. BUG=v8:6928,v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I4687f5b96fcfd88b41fa970a2b937b4f6538777c Reviewed-on: https://chromium-review.googlesource.com/718338 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48557}
2017-10-13 16:33:03 +00:00
if (external_reference_table == nullptr) {
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
external_reference_table = new ExternalReferenceTable(isolate);
isolate->set_external_reference_table(external_reference_table);
}
return external_reference_table;
}
ExternalReferenceTable::ExternalReferenceTable(Isolate* isolate) {
[serializer] small fixes for blink snapshot. Changes include: - Adding V8_EXPORT macro for SnapshotCreator - Removing outdated DCHECKs. - Allow nullptr as external reference. This required a... - Refactoring of hashmaps used by the serializer. - Remove external references for counters. These are not used anywhere for isolates that are being serialized. - Put template infos into the partial snapshot cache. - Remove unnecessary presubmit check for external references. mksnapshot crashes if external references are missing. R=jochen@chromium.org, vogelheim@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2490783004 Cr-Commit-Position: refs/heads/master@{#40949}
2016-11-14 07:17:22 +00:00
// nullptr is preserved through serialization/deserialization.
Add(nullptr, "nullptr");
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
AddReferences(isolate);
AddBuiltins(isolate);
AddRuntimeFunctions(isolate);
AddIsolateAddresses(isolate);
AddAccessors(isolate);
AddStubCache(isolate);
}
Free memory allocated by backtrace_symbols immediately. R=petermarshall@chromium.org Bug: v8:6687 Change-Id: Ic447a6cd5cb8a7a251b4820fc82f1f1d033be355 Reviewed-on: https://chromium-review.googlesource.com/612067 Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47340}
2017-08-11 10:26:42 +00:00
const char* ExternalReferenceTable::ResolveSymbol(void* address) {
[serializer] print use count of external references. R=peria@chromium.org, vogelheim@chromium.org BUG=chromium:617892 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2495213003 Cr-Commit-Position: refs/heads/master@{#40981}
2016-11-15 08:58:54 +00:00
#ifdef SYMBOLIZE_FUNCTION
Free memory allocated by backtrace_symbols immediately. R=petermarshall@chromium.org Bug: v8:6687 Change-Id: Ic447a6cd5cb8a7a251b4820fc82f1f1d033be355 Reviewed-on: https://chromium-review.googlesource.com/612067 Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47340}
2017-08-11 10:26:42 +00:00
char** names = backtrace_symbols(&address, 1);
const char* name = names[0];
// The array of names is malloc'ed. However, each name string is static
// and do not need to be freed.
free(names);
return name;
[serializer] print use count of external references. R=peria@chromium.org, vogelheim@chromium.org BUG=chromium:617892 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2495213003 Cr-Commit-Position: refs/heads/master@{#40981}
2016-11-15 08:58:54 +00:00
#else
return "<unresolved>";
#endif // SYMBOLIZE_FUNCTION
}
[cleanup] Make Add() out-of-line in ExternalReferenceTable. We call this ~140 times from addReferences() and AddStubCache, which caused size to increase. Bug: Change-Id: Ib08d435abb82b3e07121adf023f96f6f0b33733e Reviewed-on: https://chromium-review.googlesource.com/660120 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#47949}
2017-09-11 13:02:28 +00:00
void ExternalReferenceTable::Add(Address address, const char* name) {
refs_.emplace_back(address, name);
}
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
void ExternalReferenceTable::AddReferences(Isolate* isolate) {
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
// Miscellaneous
Add(ExternalReference::roots_array_start(isolate).address(),
"Heap::roots_array_start()");
Add(ExternalReference::address_of_stack_limit(isolate).address(),
"StackGuard::address_of_jslimit()");
Add(ExternalReference::address_of_real_stack_limit(isolate).address(),
"StackGuard::address_of_real_jslimit()");
Add(ExternalReference::new_space_allocation_limit_address(isolate).address(),
"Heap::NewSpaceAllocationLimitAddress()");
Add(ExternalReference::new_space_allocation_top_address(isolate).address(),
"Heap::NewSpaceAllocationTopAddress()");
Add(ExternalReference::mod_two_doubles_operation(isolate).address(),
"mod_two_doubles");
Add(ExternalReference::handle_scope_next_address(isolate).address(),
"HandleScope::next");
Add(ExternalReference::handle_scope_limit_address(isolate).address(),
"HandleScope::limit");
Add(ExternalReference::handle_scope_level_address(isolate).address(),
"HandleScope::level");
Add(ExternalReference::new_deoptimizer_function(isolate).address(),
"Deoptimizer::New()");
Add(ExternalReference::compute_output_frames_function(isolate).address(),
"Deoptimizer::ComputeOutputFrames()");
Add(ExternalReference::address_of_min_int().address(),
"LDoubleConstant::min_int");
Add(ExternalReference::address_of_one_half().address(),
"LDoubleConstant::one_half");
Add(ExternalReference::isolate_address(isolate).address(), "isolate");
[builtins] Implement lazy deserialization for TFJ builtins This adds support for lazy deserialization of JS-linkage (TFJ) builtins, still gated behind the --lazy-deserialization flag. If enabled, we proceed as follows: During isolate initialization, only eager builtins are deserialized. All references to lazy builtins are replaced by the DeserializeLazy builtin. In particular, this happens in the builtin table (Builtins::builtins_) and in SharedFunctionInfo objects. When calling into a not-yet deserialized function (i.e. the JSFunction's code object is the DeserializeLazy builtin), the DeserializeLazy builtin takes over. It checks the builtin table to see if the target builtin (determined by looking at the builtin id stored on the SharedFunctionInfo) has already been deserialized. If so, it simply copies the builtin code object to the JSFunction and SharedFunctionInfo. Otherwise, we enter Runtime::kDeserializeLazy to deserialize the builtin. With --lazy-deserialization, isolate deserialization is 11% faster (1.5ms vs. 1.7ms), and code_space->Size() is 33% lower (984K vs. 1475K). Moving relocation infos & handler tables out of the partial snapshot cache would additionally let us save up to 30K per isolate. Adding code stubs to that list increases further potential savings to 262K. Bug: v8:6624 Change-Id: I0ac7d05d165d2466998269bd431ac076a311cbeb Reviewed-on: https://chromium-review.googlesource.com/649166 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47818}
2017-09-05 09:24:39 +00:00
Add(ExternalReference::builtins_address(isolate).address(), "builtins");
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
Add(ExternalReference::interpreter_dispatch_table_address(isolate).address(),
"Interpreter::dispatch_table_address");
[Interpreter] Adapt Call bytecode handlers to drop their stack-frame. This change adapts the Call bytecode handlers such that they don't require a stack frame. It does this by modifying the call bytecode handler to tail-call the Call or InterpreterPushArgsAndCall builtins. As a result, the callee function will return to the InterpreterEntryTrampoline when it returns (since this is the return address on the interpreter frame), which is adapted to dispatch to the next bytecode handler. The return bytecode handler is modified to tail-call a new InterpreterExitTramoline instead of returning to the InterpreterEntryTrampoline. Overall this significanlty reduces the amount of stack space required for interpreter frames, increasing the maximum depth of recursive calls from around 6000 to around 12,500 on x64. BUG=chromium:753705 Change-Id: I23328e4cef878df3aca4db763b47d72a2cce664c Reviewed-on: https://chromium-review.googlesource.com/634364 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#47617}
2017-08-25 20:56:04 +00:00
Add(ExternalReference::bytecode_size_table_address(isolate).address(),
"Bytecodes::bytecode_size_table_address");
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
Add(ExternalReference::address_of_negative_infinity().address(),
"LDoubleConstant::negative_infinity");
Add(ExternalReference::power_double_double_function(isolate).address(),
"power_double_double_function");
[builtins] Unify most of the remaining Math builtins. Import fdlibm versions of acos, acosh, asin and asinh, which are more precise and produce the same result across platforms (we were using libm versions for asin and acos so far, where both speed and precision depended on the operating system so far). Introduce appropriate TurboFan operators for these functions and use them both for inlining and for the generic builtin. Also migrate the Math.imul and Math.fround builtins to TurboFan builtins to ensure that their behavior is always exactly the same as the inlined TurboFan version (i.e. C++ truncation semantics for double to float don't necessarily meet the JavaScript semantics). For completeness, also migrate Math.sign, which can even get some nice love in TurboFan. Drive-by-fix: Some alpha-sorting on the Math related functions, and cleanup the list of Math intrinsics that we have to export via the native context currently. BUG=v8:3266,v8:3496,v8:3509,v8:3952,v8:5169,v8:5170,v8:5171,v8:5172 TBR=rossberg@chromium.org R=franzih@chromium.org Review-Url: https://codereview.chromium.org/2116753002 Cr-Commit-Position: refs/heads/master@{#37476}
2016-07-01 11:11:33 +00:00
Add(ExternalReference::ieee754_acos_function(isolate).address(),
"base::ieee754::acos");
Add(ExternalReference::ieee754_acosh_function(isolate).address(),
"base::ieee754::acosh");
Add(ExternalReference::ieee754_asin_function(isolate).address(),
"base::ieee754::asin");
Add(ExternalReference::ieee754_asinh_function(isolate).address(),
"base::ieee754::asinh");
[builtins] Introduce proper Float64Atan and Float64Atan2 operators. Import base::ieee754::atan() and base::ieee754::atan2() from fdlibm and introduce Float64Atan and Float64Atan2 TurboFan operators based on those, similar to what we already did for Float64Log and Float64Log1p. Rewrite Math.atan() and Math.atan2() as TurboFan builtin and use the operators to also inline Math.atan() and Math.atan2() into optimized TurboFan functions. R=yangguo@chromium.org BUG=v8:5086,v8:5095 Review-Url: https://codereview.chromium.org/2065503002 Cr-Commit-Position: refs/heads/master@{#36916}
2016-06-13 07:06:49 +00:00
Add(ExternalReference::ieee754_atan_function(isolate).address(),
"base::ieee754::atan");
[builtins] Unify Atanh, Cbrt and Expm1 as exports from flibm. BUG=v8:5103 Review-Url: https://codereview.chromium.org/2068743002 Cr-Commit-Position: refs/heads/master@{#37058}
2016-06-17 09:13:22 +00:00
Add(ExternalReference::ieee754_atanh_function(isolate).address(),
"base::ieee754::atanh");
[builtins] Unify most of the remaining Math builtins. Import fdlibm versions of acos, acosh, asin and asinh, which are more precise and produce the same result across platforms (we were using libm versions for asin and acos so far, where both speed and precision depended on the operating system so far). Introduce appropriate TurboFan operators for these functions and use them both for inlining and for the generic builtin. Also migrate the Math.imul and Math.fround builtins to TurboFan builtins to ensure that their behavior is always exactly the same as the inlined TurboFan version (i.e. C++ truncation semantics for double to float don't necessarily meet the JavaScript semantics). For completeness, also migrate Math.sign, which can even get some nice love in TurboFan. Drive-by-fix: Some alpha-sorting on the Math related functions, and cleanup the list of Math intrinsics that we have to export via the native context currently. BUG=v8:3266,v8:3496,v8:3509,v8:3952,v8:5169,v8:5170,v8:5171,v8:5172 TBR=rossberg@chromium.org R=franzih@chromium.org Review-Url: https://codereview.chromium.org/2116753002 Cr-Commit-Position: refs/heads/master@{#37476}
2016-07-01 11:11:33 +00:00
Add(ExternalReference::ieee754_atan2_function(isolate).address(),
"base::ieee754::atan2");
[builtins] Introduce proper Float64Tan operator. Import base::ieee754::tan() from fdlibm and introduce Float64Tan TurboFan operator based on that, similar to what we do for Float64Cos and Float64Sin. Rewrite Math.tan() as TurboFan builtin and use those operators to also inline Math.tan() into optimized TurboFan functions. Drive-by-fix: Kill the %_ConstructDouble intrinsics, and provide only the %ConstructDouble runtime entry for writing tests. BUG=v8:5086,v8:5126 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2083453002 Cr-Commit-Position: refs/heads/master@{#37087}
2016-06-20 05:51:37 +00:00
Add(ExternalReference::ieee754_cbrt_function(isolate).address(),
"base::ieee754::cbrt");
[builtins] Introduce proper Float64Cos and Float64Sin. Import base::ieee754::cos() and base::ieee754::sin() from fdlibm and introduce Float64Cos and Float64Sin TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.cos() and Math.sin() as TurboFan builtins and use those operators to also inline Math.cos() and Math.sin() into optimized TurboFan functions. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=mvstanton@chromium.org BUG=v8:5086,v8:5118 Review-Url: https://codereview.chromium.org/2073123002 Cr-Commit-Position: refs/heads/master@{#37072}
2016-06-17 15:21:48 +00:00
Add(ExternalReference::ieee754_cos_function(isolate).address(),
"base::ieee754::cos");
[builtins] Unify Cosh, Sinh and Tanh as exports from flibm BUG=v8:5086 Review-Url: https://codereview.chromium.org/2083573002 Cr-Commit-Position: refs/heads/master@{#37424}
2016-06-30 08:41:05 +00:00
Add(ExternalReference::ieee754_cosh_function(isolate).address(),
"base::ieee754::cosh");
[builtins] Introduce proper Float64Exp operator. Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.exp() as TurboFan builtin and use that operator to also inline Math.exp() into optimized TurboFan functions. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108,chromium:620786 R=mvstanton@chromium.org Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260 Review-Url: https://codereview.chromium.org/2077533002 Cr-Original-Commit-Position: refs/heads/master@{#37037} Cr-Commit-Position: refs/heads/master@{#37047}
2016-06-17 05:19:35 +00:00
Add(ExternalReference::ieee754_exp_function(isolate).address(),
"base::ieee754::exp");
[builtins] Unify Atanh, Cbrt and Expm1 as exports from flibm. BUG=v8:5103 Review-Url: https://codereview.chromium.org/2068743002 Cr-Commit-Position: refs/heads/master@{#37058}
2016-06-17 09:13:22 +00:00
Add(ExternalReference::ieee754_expm1_function(isolate).address(),
"base::ieee754::expm1");
[builtins] Introduce proper base::ieee754::log. This switches Math.log to use an fdlibm based version of log, imported as base::ieee754::log, and use that consistently everywhere, i.e. change the Float64Log TurboFan operators on Intel to use the C++ implementation as well (same for Crankshaft). R=yangguo@chromium.org BUG=v8:5065,v8:5086 Review-Url: https://codereview.chromium.org/2053893003 Cr-Commit-Position: refs/heads/master@{#36880}
2016-06-10 05:51:58 +00:00
Add(ExternalReference::ieee754_log_function(isolate).address(),
"base::ieee754::log");
[builtins] Introduce proper Float64Log1p operator. Import base::ieee754::log1p() from fdlibm and introduce a Float64Log1p TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.log1p() as TurboFan builtin and use that operator to also inline Math.log1p() into optimized TurboFan functions. Also unify the handling of the special IEEE 754 functions somewhat in the TurboFan backends. At some point we can hopefully express this completely in the InstructionSelector (once we have an idea what to do with the ST(0) return issue on IA-32/X87). Drive-by-fix: Add some more test coverage for the log function. R=yangguo@chromium.org BUG=v8:5086,v8:5092 Review-Url: https://codereview.chromium.org/2060743002 Cr-Commit-Position: refs/heads/master@{#36914}
2016-06-13 05:46:38 +00:00
Add(ExternalReference::ieee754_log1p_function(isolate).address(),
"base::ieee754::log1p");
[builtins] Introduce proper Float64Log2 and Float64Log10 operators. BUG=v8:5095 Review-Url: https://codereview.chromium.org/2063693002 Cr-Commit-Position: refs/heads/master@{#37035}
2016-06-16 11:22:32 +00:00
Add(ExternalReference::ieee754_log10_function(isolate).address(),
"base::ieee754::log10");
[builtins] Introduce proper Float64Tan operator. Import base::ieee754::tan() from fdlibm and introduce Float64Tan TurboFan operator based on that, similar to what we do for Float64Cos and Float64Sin. Rewrite Math.tan() as TurboFan builtin and use those operators to also inline Math.tan() into optimized TurboFan functions. Drive-by-fix: Kill the %_ConstructDouble intrinsics, and provide only the %ConstructDouble runtime entry for writing tests. BUG=v8:5086,v8:5126 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2083453002 Cr-Commit-Position: refs/heads/master@{#37087}
2016-06-20 05:51:37 +00:00
Add(ExternalReference::ieee754_log2_function(isolate).address(),
"base::ieee754::log2");
[builtins] Introduce proper Float64Cos and Float64Sin. Import base::ieee754::cos() and base::ieee754::sin() from fdlibm and introduce Float64Cos and Float64Sin TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.cos() and Math.sin() as TurboFan builtins and use those operators to also inline Math.cos() and Math.sin() into optimized TurboFan functions. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=mvstanton@chromium.org BUG=v8:5086,v8:5118 Review-Url: https://codereview.chromium.org/2073123002 Cr-Commit-Position: refs/heads/master@{#37072}
2016-06-17 15:21:48 +00:00
Add(ExternalReference::ieee754_sin_function(isolate).address(),
"base::ieee754::sin");
[builtins] Unify Cosh, Sinh and Tanh as exports from flibm BUG=v8:5086 Review-Url: https://codereview.chromium.org/2083573002 Cr-Commit-Position: refs/heads/master@{#37424}
2016-06-30 08:41:05 +00:00
Add(ExternalReference::ieee754_sinh_function(isolate).address(),
"base::ieee754::sinh");
[builtins] Introduce proper Float64Tan operator. Import base::ieee754::tan() from fdlibm and introduce Float64Tan TurboFan operator based on that, similar to what we do for Float64Cos and Float64Sin. Rewrite Math.tan() as TurboFan builtin and use those operators to also inline Math.tan() into optimized TurboFan functions. Drive-by-fix: Kill the %_ConstructDouble intrinsics, and provide only the %ConstructDouble runtime entry for writing tests. BUG=v8:5086,v8:5126 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2083453002 Cr-Commit-Position: refs/heads/master@{#37087}
2016-06-20 05:51:37 +00:00
Add(ExternalReference::ieee754_tan_function(isolate).address(),
"base::ieee754::tan");
[builtins] Unify Cosh, Sinh and Tanh as exports from flibm BUG=v8:5086 Review-Url: https://codereview.chromium.org/2083573002 Cr-Commit-Position: refs/heads/master@{#37424}
2016-06-30 08:41:05 +00:00
Add(ExternalReference::ieee754_tanh_function(isolate).address(),
"base::ieee754::tanh");
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
Add(ExternalReference::store_buffer_top(isolate).address(),
"store_buffer_top");
[heap] Implement write barrier in code stub assembly Bug: 749486 The feature is off by default, and could be turned on via `v8_enable_csa_write_barrier = true`. With this CL, only x64 uses this feature Change-Id: Ie024f08b7d796a4cc4d55285dc9fe796780f0e53 Reviewed-on: https://chromium-review.googlesource.com/588891 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Albert Mingkun Yang <albertnetymk@google.com> Cr-Commit-Position: refs/heads/master@{#47122}
2017-08-03 11:17:17 +00:00
Add(ExternalReference::heap_is_marking_flag_address(isolate).address(),
"heap_is_marking_flag_address");
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
Add(ExternalReference::address_of_the_hole_nan().address(), "the_hole_nan");
Add(ExternalReference::get_date_field_function(isolate).address(),
"JSDate::GetField");
Add(ExternalReference::date_cache_stamp(isolate).address(),
"date_cache_stamp");
Add(ExternalReference::address_of_pending_message_obj(isolate).address(),
"address_of_pending_message_obj");
Add(ExternalReference::cpu_features().address(), "cpu_features");
Add(ExternalReference::old_space_allocation_top_address(isolate).address(),
"Heap::OldSpaceAllocationTopAddress");
Add(ExternalReference::old_space_allocation_limit_address(isolate).address(),
"Heap::OldSpaceAllocationLimitAddress");
Add(ExternalReference::allocation_sites_list_address(isolate).address(),
"Heap::allocation_sites_list_address()");
Add(ExternalReference::address_of_uint32_bias().address(), "uint32_bias");
Add(ExternalReference::is_profiling_address(isolate).address(),
Remove dependencies of V8 on cpu-profiler is_profiling. Move is_profiling to the isolate for now. BUG=v8:4789 Review-Url: https://codereview.chromium.org/2040683002 Cr-Commit-Position: refs/heads/master@{#36838}
2016-06-09 05:23:34 +00:00
"Isolate::is_profiling");
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
Add(ExternalReference::scheduled_exception_address(isolate).address(),
"Isolate::scheduled_exception");
Add(ExternalReference::invoke_function_callback(isolate).address(),
"InvokeFunctionCallback");
Add(ExternalReference::invoke_accessor_getter_callback(isolate).address(),
"InvokeAccessorGetterCallback");
Add(ExternalReference::wasm_f32_trunc(isolate).address(),
"wasm::f32_trunc_wrapper");
Add(ExternalReference::wasm_f32_floor(isolate).address(),
"wasm::f32_floor_wrapper");
Add(ExternalReference::wasm_f32_ceil(isolate).address(),
"wasm::f32_ceil_wrapper");
Add(ExternalReference::wasm_f32_nearest_int(isolate).address(),
"wasm::f32_nearest_int_wrapper");
Add(ExternalReference::wasm_f64_trunc(isolate).address(),
"wasm::f64_trunc_wrapper");
Add(ExternalReference::wasm_f64_floor(isolate).address(),
"wasm::f64_floor_wrapper");
Add(ExternalReference::wasm_f64_ceil(isolate).address(),
"wasm::f64_ceil_wrapper");
Add(ExternalReference::wasm_f64_nearest_int(isolate).address(),
"wasm::f64_nearest_int_wrapper");
Add(ExternalReference::wasm_int64_to_float32(isolate).address(),
"wasm::int64_to_float32_wrapper");
Add(ExternalReference::wasm_uint64_to_float32(isolate).address(),
"wasm::uint64_to_float32_wrapper");
Add(ExternalReference::wasm_int64_to_float64(isolate).address(),
"wasm::int64_to_float64_wrapper");
Add(ExternalReference::wasm_uint64_to_float64(isolate).address(),
"wasm::uint64_to_float64_wrapper");
Add(ExternalReference::wasm_float32_to_int64(isolate).address(),
"wasm::float32_to_int64_wrapper");
Add(ExternalReference::wasm_float32_to_uint64(isolate).address(),
"wasm::float32_to_uint64_wrapper");
Add(ExternalReference::wasm_float64_to_int64(isolate).address(),
"wasm::float64_to_int64_wrapper");
Add(ExternalReference::wasm_float64_to_uint64(isolate).address(),
"wasm::float64_to_uint64_wrapper");
[wasm] Use a C wrapper function to calculate F64Pow. This CL more or less reverts commit https://codereview.chromium.org/2107733002/ The use of the MathPow code stub that was introduced by that commit caused problems on arm64, and the MathPow code stub was also an obstacle in the implementation of parallel code generation. In addition this CL turns on the mjsunit/wasm/embenchen tests for arm64 which were turned off because of problems with MathPow on arm64. R=titzer@chromium.org, bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2166793002 Cr-Commit-Position: refs/heads/master@{#37911}
2016-07-20 14:24:47 +00:00
Add(ExternalReference::wasm_float64_pow(isolate).address(),
"wasm::float64_pow");
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
Add(ExternalReference::wasm_int64_div(isolate).address(), "wasm::int64_div");
Add(ExternalReference::wasm_int64_mod(isolate).address(), "wasm::int64_mod");
Add(ExternalReference::wasm_uint64_div(isolate).address(),
"wasm::uint64_div");
Add(ExternalReference::wasm_uint64_mod(isolate).address(),
"wasm::uint64_mod");
[wasm] New implementation of popcnt and ctz. This patch provides a new implementation of popcnt and ctz in the case where the platform does not provide these instructions. Instead of building a TF graph which implements it we now call a C function. Additionally I turned on additional tests in test-run-wasm-64.cc R=titzer@chromium.org Review URL: https://codereview.chromium.org/1857363003 Cr-Commit-Position: refs/heads/master@{#35685}
2016-04-21 07:45:36 +00:00
Add(ExternalReference::wasm_word32_ctz(isolate).address(),
"wasm::word32_ctz");
Add(ExternalReference::wasm_word64_ctz(isolate).address(),
"wasm::word64_ctz");
Add(ExternalReference::wasm_word32_popcnt(isolate).address(),
"wasm::word32_popcnt");
Add(ExternalReference::wasm_word64_popcnt(isolate).address(),
"wasm::word64_popcnt");
[wasm] use ccall to set/clear thread in wasm flag CCalls have significantly less overhead than runtime calls which will improve runtime performance on programs that make lots of transitions between JS and Wasm. Bug: v8:5277 Change-Id: If09dea97f24eb43753847e2b894ebc1ba5168c23 Reviewed-on: https://chromium-review.googlesource.com/688481 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48297}
2017-10-04 21:08:55 +00:00
// If the trap handler is not supported, the optimizer will remove these
// runtime functions. In this case, the arm simulator will break if we add
// them to the external reference table.
[wasm] Add thread-in-wasm flag builtins for x64 target This was causing trouble with Fuchsia, since mksnapshot was built and run on Linux which supports trap handlers, while Fuchsia does not yet. This change causes the external references to match between Fuchsia and Linux. Bug: chromium:772057 Change-Id: I8e8f3539e3f5c4b798c364101ef2d16b5137f16d Reviewed-on: https://chromium-review.googlesource.com/706109 Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48408}
2017-10-06 21:30:57 +00:00
#ifdef V8_TARGET_ARCH_X64
Add(ExternalReference::wasm_set_thread_in_wasm_flag(isolate).address(),
"wasm::set_thread_in_wasm_flag");
Add(ExternalReference::wasm_clear_thread_in_wasm_flag(isolate).address(),
"wasm::clear_thread_in_wasm_flag");
#endif
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
Add(ExternalReference::f64_acos_wrapper_function(isolate).address(),
"f64_acos_wrapper");
Add(ExternalReference::f64_asin_wrapper_function(isolate).address(),
"f64_asin_wrapper");
Add(ExternalReference::f64_mod_wrapper_function(isolate).address(),
"f64_mod_wrapper");
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
Add(ExternalReference::wasm_call_trap_callback_for_testing(isolate).address(),
"wasm::call_trap_callback_for_testing");
[runtime] Port simple String.prototype.indexOf cases to TF Builtin Many websites use simple calls to String.prototype.indexOf with either a one character ASCII needle or needles bigger than the search string. This CL adds a TFJ builtin for these simple cases, giving up to factor 5 speedup. Drive-by-fix: Add default Object type to Arguments.at BUG= Review-Url: https://codereview.chromium.org/2539093002 Cr-Commit-Position: refs/heads/master@{#41760}
2016-12-16 13:24:07 +00:00
Add(ExternalReference::libc_memchr_function(isolate).address(),
"libc_memchr");
[builtins] Copy array contents using JS in ConstructByArrayLike. The last CL https://chromium-review.googlesource.com/c/456707/ caused some pretty heavy performance regressions. After experimenting, it seems the easiest and most straight-forward way to copy the elements into the new typed array is to do it in JS. Adds a fast path for typed arrays, where the source typed array has the same elements kind, in which case we can just copy the backing store using memcpy. This CL also removes regression test 319120 which is from a pwn2own vulnerability. The old code path enforced a maximum byte_length that was too low, which this change removes. The length property of the typed array must be a Smi, but the byte_length, which can be up to 8x larger than length for a Float64Array, can be a heap number. We can also re-use some of the logic from ConstructByLength when deciding whether to allocate the buffer on- or off-heap, so that is factored out into InitializeBasedOnLength. We can also re-use the DoInitialize helper instead of calling into the runtime, meaning we can remove InitializeFromArrayLike. BUG=v8:5977,chromium:705503,chromium:705394 Change-Id: I63372652091d4bdf3a9491acef9b4e3ac793a755 Reviewed-on: https://chromium-review.googlesource.com/459621 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#44301}
2017-03-30 13:16:55 +00:00
Add(ExternalReference::libc_memcpy_function(isolate).address(),
"libc_memcpy");
[csa] add FastArrayShift builtin Bug: v8:6380 Change-Id: I85728099bcf188929c81e234a34b2bc308ddab16 Reviewed-on: https://chromium-review.googlesource.com/506016 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#45378}
2017-05-17 14:39:34 +00:00
Add(ExternalReference::libc_memmove_function(isolate).address(),
"libc_memmove");
[builtins] Reland of Port TypedArrayInitialize to CodeStubAssembler. Turbofan is a lot slower than Crankshaft at constructing TypedArrays, because we always go to the C++ builtin. Port the builtin to CSA to improve performance, and to clean up the implementation, which is split across multiple files and pieces at the moment. This CL increases the performance with --future to roughly the same as with crankshaft. BUG=v8:5977 Change-Id: Id0d91a4592de41a3a308846d79bd44a608931762 Reviewed-on: https://chromium-review.googlesource.com/448537 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#43548}
2017-03-02 13:35:39 +00:00
Add(ExternalReference::libc_memset_function(isolate).address(),
"libc_memset");
[arm64] Mark std::printf as an external reference Arm64's implementation of `TurboAssembler::Abort()` supports printing the bailout reason to the standard output without calling to the runtime. For this to work, we need access to the host's printf function so we can call it directly. In the general case, `Abort` does call the runtime, however, we cannot do it if we want to abort from inside CEntryStub. Bug: v8:6939 Change-Id: I2a57603cdc182a45cf770f405bd6ae449f40a047 Reviewed-on: https://chromium-review.googlesource.com/730746 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#48790}
2017-10-20 11:49:37 +00:00
Add(ExternalReference::printf_function(isolate).address(), "printf");
[builtins] HasOwnProperty: handle non-internalized string keys Taking the slow runtime path for every non-internalized string key can be avoided by doing optimistic string table lookups: if there is a matching entry, use that; if there isn't, then no existing object has a property with that name. The hashing/internalizing logic is in C++ and called directly. Review-Url: https://codereview.chromium.org/2811333002 Cr-Commit-Position: refs/heads/master@{#44650}
2017-04-13 14:41:22 +00:00
Add(ExternalReference::try_internalize_string_function(isolate).address(),
"try_internalize_string_function");
[csa] Add C++ compile time type checks to CSA. Bug: Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I2e1b36303f8b9ad4a3dc4e488123e6e4ce8b02ec Reviewed-on: https://chromium-review.googlesource.com/533033 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#47149}
2017-08-03 14:27:11 +00:00
Add(ExternalReference::check_object_type(isolate).address(),
"check_object_type");
[string] Move String.p.toLowerCase to CSA This CL migrates the CPP builtin to CSA with fast paths for strings that can be unpacked to direct one-byte strings. Short strings are handled directly in CSA, others need to call into C for conversion. Microbenchmarks for "abcd".toLowerCase() show speedups of 2.5x. BUG=v8:6353,v8:6344 Review-Url: https://codereview.chromium.org/2859203002 Cr-Commit-Position: refs/heads/master@{#45141}
2017-05-05 15:59:08 +00:00
#ifdef V8_INTL_SUPPORT
Add(ExternalReference::intl_convert_one_byte_to_lower(isolate).address(),
"intl_convert_one_byte_to_lower");
Add(ExternalReference::intl_to_latin1_lower_table(isolate).address(),
"intl_to_latin1_lower_table");
#endif // V8_INTL_SUPPORT
[string] Widen StringIndexOf fast path The StringIndexOf fast path used to be very narrow, only allowing one-byte single-char search strings (and a one-byte subject string). This changes the CSA fast path to call into our internal SearchString C++ function instead (after attempting to unpack both Strings), and can handle strings of arbitrary length and encoding. The only remaining runtime call is when either string needs to be flattened. BUG= Review-Url: https://codereview.chromium.org/2814373002 Cr-Commit-Position: refs/heads/master@{#44718}
2017-04-19 10:47:03 +00:00
Add(ExternalReference::search_string_raw<const uint8_t, const uint8_t>(
isolate)
.address(),
"search_string_raw<1-byte, 1-byte>");
Add(ExternalReference::search_string_raw<const uint8_t, const uc16>(isolate)
.address(),
"search_string_raw<1-byte, 2-byte>");
Add(ExternalReference::search_string_raw<const uc16, const uint8_t>(isolate)
.address(),
"search_string_raw<2-byte, 1-byte>");
Add(ExternalReference::search_string_raw<const uc16, const uc16>(isolate)
.address(),
"search_string_raw<1-byte, 2-byte>");
Initial optimization of Map.prototype.(get|has) in Turbofan. This introduces a new builtin (MapLookupHashIndex) and uses it in Turbofan to compute Map.p.get and Map.p.has. I have also refactored the existing CSA builtins for Map.p.get and Map.p.has to use the new builtin under the hood. The code for the lookup has been also improved. - Specialized lookups for smis, strings, heap numbers and everything else. - the advantage is that we can use fast equalities for the lookup. - strings can likely be optimized further if we care about the internalized string fast case. - Instead of a call to runtime to get the hash code, we now call C directly. In the Turbofan implementation itself, there are no special optimizations yet. The next step is to teach load elimination to reuse the indexes from previous calls of MapLookupHashIndex. BUG=v8:6410 Change-Id: I0b1a70493eb031d444e51002f6b2cc1f30ea2b68 Reviewed-on: https://chromium-review.googlesource.com/560169 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#46510}
2017-07-10 11:30:04 +00:00
Add(ExternalReference::orderedhashmap_gethash_raw(isolate).address(),
"orderedhashmap_gethash_raw");
[Collections] Replace GenericHash runtime call with fast C call Bug: v8:5717 Change-Id: I3775001a6148e25f15b11410449a6f8b7693f122 Reviewed-on: https://chromium-review.googlesource.com/625276 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#47589}
2017-08-22 01:02:06 +00:00
Add(ExternalReference::get_or_create_hash_raw(isolate).address(),
"get_or_create_hash_raw");
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
Add(ExternalReference::log_enter_external_function(isolate).address(),
"Logger::EnterExternal");
Add(ExternalReference::log_leave_external_function(isolate).address(),
"Logger::LeaveExternal");
Add(ExternalReference::address_of_minus_one_half().address(),
"double_constants.minus_one_half");
Add(ExternalReference::stress_deopt_count(isolate).address(),
"Isolate::stress_deopt_count_address()");
Add(ExternalReference::runtime_function_table_address(isolate).address(),
"Runtime::runtime_function_table_address()");
[x64] add Absps/d and Negps/d macro BUG= Review-Url: https://codereview.chromium.org/2161513002 Cr-Commit-Position: refs/heads/master@{#37937}
2016-07-21 11:01:44 +00:00
Add(ExternalReference::address_of_float_abs_constant().address(),
"float_absolute_constant");
Add(ExternalReference::address_of_float_neg_constant().address(),
"float_negate_constant");
Add(ExternalReference::address_of_double_abs_constant().address(),
"double_absolute_constant");
Add(ExternalReference::address_of_double_neg_constant().address(),
"double_negate_constant");
[inspector] change target promise for kDebugWillHandle & kDebugDidHandle - kDebugPromiseCreated(task, parent_task) This event occurs when promise is created (PromiseHookType::Init). V8Debugger uses this event to maintain task -> parent task map. - kDebugEnqueueAsyncFunction(task) This event occurs when first internal promise for async function is created. V8Debugger collects stack trace at this point. - kDebugEnqueuePromiseResolve(task), This event occurs when Promise fulfills with resolved status. V8Debugger collects stack trace at this point. - kDebugEnqueuePromiseReject(task), This event occurs when Promise fulfills with rejected status. V8Debugger collects stack trace at this point. - kDebugPromiseCollected, This event occurs when Promise is collected and no other chained callbacks can be added. V8Debugger removes information about async task for this promise. - kDebugWillHandle, This event occurs when chained promise function (either resolve or reject handler) is called. V8Debugger installs parent promise's stack (based on task -> parent_task map) as current if available or current promise's scheduled stack otherwise. - kDebugDidHandle, This event occurs after chained promise function has finished. V8Debugger restores asynchronous call chain to previous one. With this change all instrumentation calls are related to current promise (before WillHandle and DidHandle were related to next async task). Before V8Debugger supported only the following: - asyncTaskScheduled(task1) - asyncTaskStarted(task1) - asyncTaskFinished(task1) Now V8Debugger supports the following: - asyncTaskScheduled(parent_task) .. - asyncTaskCreated(task, parent_task), - asyncTaskStarted(task), uses parent_task scheduled stack - asyncTaskScheduled(task) - asyncTaskFinished(task) Additionally: WillHandle and DidHandle were migrated to PromiseHook API. More details: https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE BUG=v8:5738 R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2650803003 Cr-Commit-Position: refs/heads/master@{#42644}
2017-01-25 07:05:43 +00:00
Add(ExternalReference::promise_hook_or_debug_is_active_address(isolate)
.address(),
"Isolate::promise_hook_or_debug_is_active_address()");
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
// Debug addresses
Add(ExternalReference::debug_is_active_address(isolate).address(),
"Debug::is_active_address()");
[debugger] infrastructure for side-effect-free debug-evaluate. R=jgruber@chromium.org, mstarzinger@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2622863003 Cr-Commit-Position: refs/heads/master@{#42270}
2017-01-12 14:18:45 +00:00
Add(ExternalReference::debug_hook_on_function_call_address(isolate).address(),
"Debug::hook_on_function_call_address()");
[debugger] simplify debug stepping. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2068603002 Cr-Commit-Position: refs/heads/master@{#36960}
2016-06-14 11:07:40 +00:00
Add(ExternalReference::debug_last_step_action_address(isolate).address(),
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
"Debug::step_in_enabled_address()");
[debug] implement intuitive semantics for stepping over await call. R=*bmeurer@chromium.org, caitpotter88@gmail.com, *littledan@chromium.org, *ulan@chromium.org BUG=v8:4483 Review-Url: https://codereview.chromium.org/2033223003 Cr-Commit-Position: refs/heads/master@{#36718}
2016-06-03 15:30:42 +00:00
Add(ExternalReference::debug_suspended_generator_address(isolate).address(),
"Debug::step_suspended_generator_address()");
[liveedit] reimplement frame restarting. Previously, when restarting a frame, we would rewrite all frames between the debugger activation and the frame to restart to squash them, and replace the return address with that of a builtin to leave that rewritten frame, and restart the function by calling it. We now simply remember the frame to drop to, and upon returning from the debugger, we check whether to drop the frame, load the new FP, and restart the function. R=jgruber@chromium.org, mstarzinger@chromium.org BUG=v8:5587 Review-Url: https://codereview.chromium.org/2636913002 Cr-Commit-Position: refs/heads/master@{#42725}
2017-01-27 07:31:03 +00:00
Add(ExternalReference::debug_restart_fp_address(isolate).address(),
"Debug::restart_fp_address()");
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
[regexp] Add support for dotAll flag The dotAll flag changes behavior of the dot '.' character to match every possible single character instead of excluding certain line terminators. The implementation is staged behind --harmony-regexp-dotall. Spec proposal: https://github.com/mathiasbynens/es-regexp-dotall-flag BUG=v8:6172 Review-Url: https://codereview.chromium.org/2780173002 Cr-Commit-Position: refs/heads/master@{#44295}
2017-03-31 09:20:13 +00:00
Add(ExternalReference::address_of_regexp_dotall_flag(isolate).address(),
"FLAG_harmony_regexp_dotall");
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
#ifndef V8_INTERPRETED_REGEXP
Add(ExternalReference::re_case_insensitive_compare_uc16(isolate).address(),
"NativeRegExpMacroAssembler::CaseInsensitiveCompareUC16()");
Add(ExternalReference::re_check_stack_guard_state(isolate).address(),
"RegExpMacroAssembler*::CheckStackGuardState()");
Add(ExternalReference::re_grow_stack(isolate).address(),
"NativeRegExpMacroAssembler::GrowStack()");
Add(ExternalReference::re_word_character_map().address(),
"NativeRegExpMacroAssembler::word_character_map");
Add(ExternalReference::address_of_regexp_stack_limit(isolate).address(),
"RegExpStack::limit_address()");
Add(ExternalReference::address_of_regexp_stack_memory_address(isolate)
.address(),
"RegExpStack::memory_address()");
Add(ExternalReference::address_of_regexp_stack_memory_size(isolate).address(),
"RegExpStack::memory_size()");
Add(ExternalReference::address_of_static_offsets_vector(isolate).address(),
"OffsetsVector::static_offsets_vector");
#endif // V8_INTERPRETED_REGEXP
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
// Runtime entries
Add(ExternalReference::delete_handle_scope_extensions(isolate).address(),
"HandleScope::DeleteExtensions");
Add(ExternalReference::incremental_marking_record_write_function(isolate)
.address(),
"IncrementalMarking::RecordWrite");
Add(ExternalReference::store_buffer_overflow_function(isolate).address(),
"StoreBuffer::StoreBufferOverflow");
}
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
void ExternalReferenceTable::AddBuiltins(Isolate* isolate) {
struct CBuiltinEntry {
Address address;
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
const char* name;
};
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
static const CBuiltinEntry c_builtins[] = {
#define DEF_ENTRY(Name, ...) {FUNCTION_ADDR(&Builtin_##Name), "Builtin_" #Name},
[builtins] unify builtins list. Now builtins are sorted by use, not implementation. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2145413002 Cr-Commit-Position: refs/heads/master@{#37761}
2016-07-14 12:45:56 +00:00
BUILTIN_LIST_C(DEF_ENTRY)
#undef DEF_ENTRY
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
};
for (unsigned i = 0; i < arraysize(c_builtins); ++i) {
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
Add(ExternalReference(c_builtins[i].address, isolate).address(),
c_builtins[i].name);
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
}
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
}
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
void ExternalReferenceTable::AddRuntimeFunctions(Isolate* isolate) {
struct RuntimeEntry {
Runtime::FunctionId id;
const char* name;
};
static const RuntimeEntry runtime_functions[] = {
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
#define RUNTIME_ENTRY(name, i1, i2) {Runtime::k##name, "Runtime::" #name},
FOR_EACH_INTRINSIC(RUNTIME_ENTRY)
#undef RUNTIME_ENTRY
};
for (unsigned i = 0; i < arraysize(runtime_functions); ++i) {
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
ExternalReference ref(runtime_functions[i].id, isolate);
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
Add(ref.address(), runtime_functions[i].name);
}
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
}
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
void ExternalReferenceTable::AddIsolateAddresses(Isolate* isolate) {
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
// Top addresses
static const char* address_names[] = {
#define BUILD_NAME_LITERAL(Name, name) "Isolate::" #name "_address",
Use nullptr instead of NULL where possible New code should use nullptr instead of NULL. This patch updates existing use of NULL to nullptr where applicable, making the code base more consistent. BUG=v8:6928,v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I4687f5b96fcfd88b41fa970a2b937b4f6538777c Reviewed-on: https://chromium-review.googlesource.com/718338 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48557}
2017-10-13 16:33:03 +00:00
FOR_EACH_ISOLATE_ADDRESS_NAME(BUILD_NAME_LITERAL) nullptr
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
#undef BUILD_NAME_LITERAL
};
[iwyu] Include isolate.h less. This removes the include from: assembler.h (moved Isolate::AddressId to globals.h / IsolateAddressId) counters.h (ditto) elements.h (trivial) keys.h (trivial + iwyu fixes) property.h (trivial) transitions.h (trivial) vm-state.h (trivial) heap/code-stats.h (trivial + drive-by iwyuing) BUG=v8:5294 Change-Id: I36b8c07d4edf4177f1a987a393569f5191167ed3 Reviewed-on: https://chromium-review.googlesource.com/532879 Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#46176}
2017-06-23 12:21:39 +00:00
for (int i = 0; i < IsolateAddressId::kIsolateAddressCount; ++i) {
Add(isolate->get_address_from_id(static_cast<IsolateAddressId>(i)),
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
address_names[i]);
}
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
}
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
void ExternalReferenceTable::AddAccessors(Isolate* isolate) {
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
// Accessors
struct AccessorRefTable {
Address address;
const char* name;
};
Reland of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset #1 id:1 of https://codereview.chromium.org/1906453002/ ) Reason for revert: Needs other reverts too. Original issue's description: > Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset #8 id:140001 of https://codereview.chromium.org/1892533004/ ) > > Reason for revert: > Blocks roll: https://codereview.chromium.org/1896103002/ > > Can also be seen on internal waterfall: https://chromegw.corp.google.com/i/internal.client.v8/builders/v8_cros_perf_1/builds/7558 > > Original issue's description: > > Change calling convention of CallApiGetterStub to accept the AccessorInfo > > > > MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com> > > > > Committed: https://crrev.com/d2b0a4b727f77f97960c7fa71da3431591dc959f > > Cr-Commit-Position: refs/heads/master@{#35606} > > TBR=rodolph.perfetta@arm.com,jkummerow@chromium.org,jacob.bramley@arm.com,verwaest@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true TBR=rodolph.perfetta@arm.com,jkummerow@chromium.org,jacob.bramley@arm.com,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1903093003 Cr-Commit-Position: refs/heads/master@{#35645}
2016-04-20 08:01:08 +00:00
static const AccessorRefTable getters[] = {
[serializer] wipe simulator redirects for accessor infos. R=jochen@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2561783002 Cr-Commit-Position: refs/heads/master@{#41587}
2016-12-08 12:13:34 +00:00
#define ACCESSOR_INFO_DECLARATION(name) \
{FUNCTION_ADDR(&Accessors::name##Getter), "Accessors::" #name "Getter"},
Revert of [serializer] print use count of external references. (patchset #2 id:20001 of https://codereview.chromium.org/2495213003/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20vtunejit/builds/14690 compile Original issue's description: > [serializer] print use count of external references. > > R=peria@chromium.org, vogelheim@chromium.org > BUG=chromium:617892 > NOPRESUBMIT=true TBR=peria@chromium.org,vogelheim@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2498163003 Cr-Commit-Position: refs/heads/master@{#40980}
2016-11-15 07:42:55 +00:00
ACCESSOR_INFO_LIST(ACCESSOR_INFO_DECLARATION)
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
#undef ACCESSOR_INFO_DECLARATION
Reland of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset #1 id:1 of https://codereview.chromium.org/1906453002/ ) Reason for revert: Needs other reverts too. Original issue's description: > Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset #8 id:140001 of https://codereview.chromium.org/1892533004/ ) > > Reason for revert: > Blocks roll: https://codereview.chromium.org/1896103002/ > > Can also be seen on internal waterfall: https://chromegw.corp.google.com/i/internal.client.v8/builders/v8_cros_perf_1/builds/7558 > > Original issue's description: > > Change calling convention of CallApiGetterStub to accept the AccessorInfo > > > > MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com> > > > > Committed: https://crrev.com/d2b0a4b727f77f97960c7fa71da3431591dc959f > > Cr-Commit-Position: refs/heads/master@{#35606} > > TBR=rodolph.perfetta@arm.com,jkummerow@chromium.org,jacob.bramley@arm.com,verwaest@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true TBR=rodolph.perfetta@arm.com,jkummerow@chromium.org,jacob.bramley@arm.com,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1903093003 Cr-Commit-Position: refs/heads/master@{#35645}
2016-04-20 08:01:08 +00:00
};
static const AccessorRefTable setters[] = {
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
#define ACCESSOR_SETTER_DECLARATION(name) \
[serializer] print use count of external references. R=peria@chromium.org, vogelheim@chromium.org BUG=chromium:617892 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2495213003 Cr-Commit-Position: refs/heads/master@{#40981}
2016-11-15 08:58:54 +00:00
{ FUNCTION_ADDR(&Accessors::name), "Accessors::" #name},
Revert of [serializer] print use count of external references. (patchset #2 id:20001 of https://codereview.chromium.org/2495213003/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20vtunejit/builds/14690 compile Original issue's description: > [serializer] print use count of external references. > > R=peria@chromium.org, vogelheim@chromium.org > BUG=chromium:617892 > NOPRESUBMIT=true TBR=peria@chromium.org,vogelheim@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2498163003 Cr-Commit-Position: refs/heads/master@{#40980}
2016-11-15 07:42:55 +00:00
ACCESSOR_SETTER_LIST(ACCESSOR_SETTER_DECLARATION)
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
#undef ACCESSOR_INFO_DECLARATION
};
Reland of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset #1 id:1 of https://codereview.chromium.org/1906453002/ ) Reason for revert: Needs other reverts too. Original issue's description: > Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset #8 id:140001 of https://codereview.chromium.org/1892533004/ ) > > Reason for revert: > Blocks roll: https://codereview.chromium.org/1896103002/ > > Can also be seen on internal waterfall: https://chromegw.corp.google.com/i/internal.client.v8/builders/v8_cros_perf_1/builds/7558 > > Original issue's description: > > Change calling convention of CallApiGetterStub to accept the AccessorInfo > > > > MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com> > > > > Committed: https://crrev.com/d2b0a4b727f77f97960c7fa71da3431591dc959f > > Cr-Commit-Position: refs/heads/master@{#35606} > > TBR=rodolph.perfetta@arm.com,jkummerow@chromium.org,jacob.bramley@arm.com,verwaest@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true TBR=rodolph.perfetta@arm.com,jkummerow@chromium.org,jacob.bramley@arm.com,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1903093003 Cr-Commit-Position: refs/heads/master@{#35645}
2016-04-20 08:01:08 +00:00
for (unsigned i = 0; i < arraysize(getters); ++i) {
[serializer] wipe simulator redirects for accessor infos. R=jochen@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2561783002 Cr-Commit-Position: refs/heads/master@{#41587}
2016-12-08 12:13:34 +00:00
Add(getters[i].address, getters[i].name);
Reland of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset #1 id:1 of https://codereview.chromium.org/1906453002/ ) Reason for revert: Needs other reverts too. Original issue's description: > Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset #8 id:140001 of https://codereview.chromium.org/1892533004/ ) > > Reason for revert: > Blocks roll: https://codereview.chromium.org/1896103002/ > > Can also be seen on internal waterfall: https://chromegw.corp.google.com/i/internal.client.v8/builders/v8_cros_perf_1/builds/7558 > > Original issue's description: > > Change calling convention of CallApiGetterStub to accept the AccessorInfo > > > > MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com> > > > > Committed: https://crrev.com/d2b0a4b727f77f97960c7fa71da3431591dc959f > > Cr-Commit-Position: refs/heads/master@{#35606} > > TBR=rodolph.perfetta@arm.com,jkummerow@chromium.org,jacob.bramley@arm.com,verwaest@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true TBR=rodolph.perfetta@arm.com,jkummerow@chromium.org,jacob.bramley@arm.com,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1903093003 Cr-Commit-Position: refs/heads/master@{#35645}
2016-04-20 08:01:08 +00:00
}
for (unsigned i = 0; i < arraysize(setters); ++i) {
Add(setters[i].address, setters[i].name);
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
}
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
}
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
void ExternalReferenceTable::AddStubCache(Isolate* isolate) {
[ic] Split megamorphic stub cache in two caches (for loads and for stores). After this CL we can avoid using Code::flags in hash computations for megamorphic stub caches and therefore the unused ICState field can be finally removed from flags. BUG=chromium:618701 Review-Url: https://codereview.chromium.org/2123983004 Cr-Commit-Position: refs/heads/master@{#37708}
2016-07-13 10:24:55 +00:00
StubCache* load_stub_cache = isolate->load_stub_cache();
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
// Stub cache tables
[ic] Split megamorphic stub cache in two caches (for loads and for stores). After this CL we can avoid using Code::flags in hash computations for megamorphic stub caches and therefore the unused ICState field can be finally removed from flags. BUG=chromium:618701 Review-Url: https://codereview.chromium.org/2123983004 Cr-Commit-Position: refs/heads/master@{#37708}
2016-07-13 10:24:55 +00:00
Add(load_stub_cache->key_reference(StubCache::kPrimary).address(),
"Load StubCache::primary_->key");
Add(load_stub_cache->value_reference(StubCache::kPrimary).address(),
"Load StubCache::primary_->value");
Add(load_stub_cache->map_reference(StubCache::kPrimary).address(),
"Load StubCache::primary_->map");
Add(load_stub_cache->key_reference(StubCache::kSecondary).address(),
"Load StubCache::secondary_->key");
Add(load_stub_cache->value_reference(StubCache::kSecondary).address(),
"Load StubCache::secondary_->value");
Add(load_stub_cache->map_reference(StubCache::kSecondary).address(),
"Load StubCache::secondary_->map");
StubCache* store_stub_cache = isolate->store_stub_cache();
// Stub cache tables
Add(store_stub_cache->key_reference(StubCache::kPrimary).address(),
"Store StubCache::primary_->key");
Add(store_stub_cache->value_reference(StubCache::kPrimary).address(),
"Store StubCache::primary_->value");
Add(store_stub_cache->map_reference(StubCache::kPrimary).address(),
"Store StubCache::primary_->map");
Add(store_stub_cache->key_reference(StubCache::kSecondary).address(),
"Store StubCache::secondary_->key");
Add(store_stub_cache->value_reference(StubCache::kSecondary).address(),
"Store StubCache::secondary_->value");
Add(store_stub_cache->map_reference(StubCache::kSecondary).address(),
"Store StubCache::secondary_->map");
[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
2016-07-18 08:47:04 +00:00
}
Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1812853002 Cr-Commit-Position: refs/heads/master@{#34858}
2016-03-17 13:14:11 +00:00
} // namespace internal
} // namespace v8
Reference in New Issue Copy Permalink