2017-02-24 17:48:49 +00:00
|
|
|
#
|
|
|
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
|
|
|
#
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
wrap: no
|
|
|
|
|
test function name: f
|
|
|
|
|
async iteration: yes
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
snippet: "
|
|
|
|
|
async function f() {
|
|
|
|
|
for await (let x of [1, 2, 3]) {}
|
|
|
|
|
}
|
|
|
|
|
f();
|
|
|
|
|
"
|
2019-08-23 14:23:52 +00:00
|
|
|
frame size: 19
|
2017-02-24 17:48:49 +00:00
|
|
|
parameter count: 1
|
2021-02-17 14:36:58 +00:00
|
|
|
bytecode array length: 272
|
2017-02-24 17:48:49 +00:00
|
|
|
bytecodes: [
|
2019-01-31 15:36:58 +00:00
|
|
|
B(SwitchOnGeneratorState), R(0), U8(0), U8(2),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Mov), R(closure), R(4),
|
|
|
|
|
B(Mov), R(this), R(5),
|
2020-02-10 16:09:27 +00:00
|
|
|
/* 16 E> */ B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionEnter), R(4), U8(2),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star0),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Mov), R(context), R(4),
|
|
|
|
|
/* 43 S> */ B(CreateArrayLiteral), U8(2), U8(0), U8(37),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaNamedProperty), R(7), U8(3), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfUndefinedOrNull), U8(14),
|
|
|
|
|
B(Star8),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(CallProperty0), R(8), R(7), U8(3),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfJSReceiver), U8(21),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(CallRuntime), U16(Runtime::kThrowSymbolAsyncIteratorInvalid), R(0), U8(0),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(7), U8(4), U8(5),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(CallProperty0), R(8), R(7), U8(7),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_CreateAsyncFromSyncIterator), R(8), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star6),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(6), U8(5), U8(9),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(context), R(10),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaTrue),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-01-14 14:15:52 +00:00
|
|
|
/* 38 S> */ B(CallProperty0), R(5), R(6), U8(11),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star13),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(0), R(12),
|
|
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionAwaitUncaught), R(12), U8(2),
|
|
|
|
|
B(SuspendGenerator), R(0), R(0), U8(12), U8(0),
|
|
|
|
|
B(ResumeGenerator), R(0), R(0), U8(12),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star12),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star13),
|
2017-05-24 15:48:27 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(13),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(JumpIfTrue), U8(5),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(12),
|
Reland "[async-iteration] implement spec-change to `yield` in async generators"
Per https://github.com/tc39/proposal-async-iteration/pull/102/files:
AsyncGeneratorResolve no longer unwraps a value component. Instead, the value is
unwrapped before the builtin call via Await, allowing Promise rejections to
affect the generator control flow.
Thus, all `yield <expr>` implicitly become `yield await <expr>`.
Additionally, `return <expr>` becomes `return await <expr>`. Finally, when the
generator is resumed with `.return()`, the parameter passed to .return() is
awaited before generator execution properly continues).
BUG=v8:6187, v8:5855
R=littledan@chromium.org, neis@chromium.org, adamk@chromium.org
TBR=rmcilroy@chromium.org, neis@chromium.org
Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: Id7718028fd555481f9f4ca0dbecfa788e3057c48
Reviewed-on: https://chromium-review.googlesource.com/594500
Reviewed-by: Caitlin Potter <caitp@igalia.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Caitlin Potter <caitp@igalia.com>
Cr-Commit-Position: refs/heads/master@{#47058}
2017-08-01 14:45:03 +00:00
|
|
|
B(ReThrow),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(12),
|
|
|
|
|
B(Mov), R(12), R(11),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(JumpIfJSReceiver), U8(7),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(11), U8(1),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(11), U8(6), U8(13),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfToBooleanTrue), U8(20),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(11), U8(7), U8(15),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star11),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(11), R(1),
|
2019-01-31 15:36:58 +00:00
|
|
|
/* 38 S> */ B(Mov), R(1), R(3),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(11),
|
2021-02-17 14:36:58 +00:00
|
|
|
/* 23 E> */ B(JumpLoop), U8(70), I8(0),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaSmi), I8(-1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star9),
|
|
|
|
|
B(Star8),
|
|
|
|
|
B(Jump), U8(5),
|
|
|
|
|
B(Star9),
|
2018-10-11 08:35:56 +00:00
|
|
|
B(LdaZero),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaTheHole),
|
2020-03-11 15:07:16 +00:00
|
|
|
B(SetPendingMessage),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star10),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(7),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfToBooleanTrue), U8(72),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(Mov), R(context), R(14),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(6), U8(8), U8(17),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfUndefinedOrNull), U8(63),
|
|
|
|
|
B(Star15),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(CallProperty0), R(15), R(6), U8(19),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Star), R(17),
|
|
|
|
|
B(Mov), R(0), R(16),
|
|
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionAwaitUncaught), R(16), U8(2),
|
|
|
|
|
B(SuspendGenerator), R(0), R(0), U8(16), U8(1),
|
|
|
|
|
B(ResumeGenerator), R(0), R(0), U8(16),
|
|
|
|
|
B(Star), R(16),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Star), R(17),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(17),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(JumpIfTrue), U8(5),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(16),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(ReThrow),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(16),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfJSReceiver), U8(20),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Star), R(18),
|
|
|
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(18), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Jump), U8(11),
|
|
|
|
|
B(Star14),
|
2018-01-23 13:51:38 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(8),
|
2018-01-23 13:51:38 +00:00
|
|
|
B(JumpIfTrue), U8(5),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(Ldar), R(14),
|
2018-01-23 13:51:38 +00:00
|
|
|
B(ReThrow),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(10),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(SetPendingMessage),
|
2017-05-16 15:20:09 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(8),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(JumpIfFalse), U8(5),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(9),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(ReThrow),
|
|
|
|
|
B(LdaUndefined),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star6),
|
[async] Improve async function handling.
This change introduces new intrinsics used to desugar async functions
in the Parser and the BytecodeGenerator, namely we introduce a new
%_AsyncFunctionEnter intrinsic that constructs the generator object
for the async function (and in the future will also create the outer
promise for the async function). This generator object is internal
and never escapes to user code, plus since async functions don't have
a "prototype" property, we can just a single map here instead of tracking
the prototype/initial_map on every async function. This saves one word
per async function plus one initial_map per async function that was
invoked at least once.
We also introduce two new intrinsics %_AsyncFunctionReject, which
rejects the outer promise with the caught exception, and another
%_AsyncFunctionResolve, which resolves the outer promise with the
right hand side of the `return` statement. These functions also perform
the DevTools part of the job (aka popping from the promise stack and
sending the debug event). This allows us to get rid of the implicit
try-finally from async functions completely; because the finally
block only called to the %AsyncFunctionPromiseRelease builtin, which
was used to inform DevTools.
In essence we now turn an async function like
```js
async function f(x) { return await bar(x); }
```
into something like this (in Parser and BytecodeGenerator respectively):
```
function f(x) {
.generator_object = %_AsyncFunctionEnter(.closure, this);
.promise = %AsyncFunctionCreatePromise();
try {
.tmp = await bar(x);
return %_AsyncFunctionResolve(.promise, .tmp);
} catch (e) {
return %_AsyncFunctionReject(.promise, e);
}
}
```
Overall the bytecode for async functions gets significantly shorter
already (and will get even shorter once we put the outer promise into
the async function generator object). For example the bytecode for a
simple async function
```js
async function f(x) { return await x; }
```
goes from 175 bytes to 110 bytes (a ~38% reduction in size), which
is in particular due to the simplification around the try-finally
removal.
Overall this seems to improve the doxbee-async-es2017-native test by
around 2-3%. On the test case mentioned in v8:8276 we go from
1124ms to 441ms, which corresponds to a 60% reduction in total
execution time!
Tbr: marja@chromium.org
Bug: v8:7253, v8:7522, v8:8276
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id29dc92de7490b387ff697860c900cee44c9a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/1269041
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56502}
2018-10-10 05:54:39 +00:00
|
|
|
B(LdaTrue),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(Mov), R(0), R(5),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionResolve), R(5), U8(3),
|
[async] Improve async function handling.
This change introduces new intrinsics used to desugar async functions
in the Parser and the BytecodeGenerator, namely we introduce a new
%_AsyncFunctionEnter intrinsic that constructs the generator object
for the async function (and in the future will also create the outer
promise for the async function). This generator object is internal
and never escapes to user code, plus since async functions don't have
a "prototype" property, we can just a single map here instead of tracking
the prototype/initial_map on every async function. This saves one word
per async function plus one initial_map per async function that was
invoked at least once.
We also introduce two new intrinsics %_AsyncFunctionReject, which
rejects the outer promise with the caught exception, and another
%_AsyncFunctionResolve, which resolves the outer promise with the
right hand side of the `return` statement. These functions also perform
the DevTools part of the job (aka popping from the promise stack and
sending the debug event). This allows us to get rid of the implicit
try-finally from async functions completely; because the finally
block only called to the %AsyncFunctionPromiseRelease builtin, which
was used to inform DevTools.
In essence we now turn an async function like
```js
async function f(x) { return await bar(x); }
```
into something like this (in Parser and BytecodeGenerator respectively):
```
function f(x) {
.generator_object = %_AsyncFunctionEnter(.closure, this);
.promise = %AsyncFunctionCreatePromise();
try {
.tmp = await bar(x);
return %_AsyncFunctionResolve(.promise, .tmp);
} catch (e) {
return %_AsyncFunctionReject(.promise, e);
}
}
```
Overall the bytecode for async functions gets significantly shorter
already (and will get even shorter once we put the outer promise into
the async function generator object). For example the bytecode for a
simple async function
```js
async function f(x) { return await x; }
```
goes from 175 bytes to 110 bytes (a ~38% reduction in size), which
is in particular due to the simplification around the try-finally
removal.
Overall this seems to improve the doxbee-async-es2017-native test by
around 2-3%. On the test case mentioned in v8:8276 we go from
1124ms to 441ms, which corresponds to a 60% reduction in total
execution time!
Tbr: marja@chromium.org
Bug: v8:7253, v8:7522, v8:8276
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id29dc92de7490b387ff697860c900cee44c9a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/1269041
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56502}
2018-10-10 05:54:39 +00:00
|
|
|
/* 57 S> */ B(Return),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(CreateCatchContext), R(5), U8(9),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star4),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaTheHole),
|
|
|
|
|
B(SetPendingMessage),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Ldar), R(4),
|
|
|
|
|
B(PushContext), R(5),
|
Reland x3 "[runtime] Remove extension slots from context objects"
Original change's description:
> [runtime] Remove extension slots from context objects
>
> Context objects have an extension slot, which contains further
> additional data that depends on the type of the context.
>
> This CL removes the extension slot from contexts that don't need
> them, hence reducing memory.
>
> The following contexts will still have an extension slot: native,
> module, await, block and with contexts. See objects/contexts.h for
> what the slot is used for.
> The following contexts will not have an extension slot anymore (they
> were not used before): script, catch and builtin contexts.
> Eval and function contexts only have the extension slot if they
> contain a sloppy eval.
>
> Bug: v8:9744
> Change-Id: I8ca56c22fa02437bbac392ea72174ebfca80e030
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863191
> Commit-Queue: Victor Gomes <victorgomes@google.com>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Auto-Submit: Victor Gomes <victorgomes@google.com>
> Cr-Commit-Position: refs/heads/master@{#64372}
TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org
Bug: v8:9744
Change-Id: I8700ed2fa62c89e86c39bb16ac3167f38ea8d63f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873695
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64477}
2019-10-22 12:59:24 +00:00
|
|
|
B(LdaImmutableCurrentContextSlot), U8(2),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2018-05-30 14:21:39 +00:00
|
|
|
B(LdaTrue),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(Mov), R(0), R(6),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionReject), R(6), U8(3),
|
2021-04-30 04:54:17 +00:00
|
|
|
B(Return),
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
constant pool: [
|
2021-02-17 14:36:58 +00:00
|
|
|
Smi [85],
|
|
|
|
|
Smi [183],
|
2018-07-05 18:34:09 +00:00
|
|
|
ARRAY_BOILERPLATE_DESCRIPTION_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
SYMBOL_TYPE,
|
2019-09-06 12:41:00 +00:00
|
|
|
SYMBOL_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["return"],
|
2018-02-16 12:36:47 +00:00
|
|
|
SCOPE_INFO_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
handlers: [
|
2021-02-17 14:36:58 +00:00
|
|
|
[18, 248, 248],
|
|
|
|
|
[66, 139, 145],
|
|
|
|
|
[158, 214, 216],
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
snippet: "
|
|
|
|
|
async function f() {
|
|
|
|
|
for await (let x of [1, 2, 3]) { return x; }
|
|
|
|
|
}
|
|
|
|
|
f();
|
|
|
|
|
"
|
2019-08-23 14:23:52 +00:00
|
|
|
frame size: 19
|
2017-02-24 17:48:49 +00:00
|
|
|
parameter count: 1
|
2021-02-17 14:36:58 +00:00
|
|
|
bytecode array length: 292
|
2017-02-24 17:48:49 +00:00
|
|
|
bytecodes: [
|
2019-01-31 15:36:58 +00:00
|
|
|
B(SwitchOnGeneratorState), R(0), U8(0), U8(2),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Mov), R(closure), R(4),
|
|
|
|
|
B(Mov), R(this), R(5),
|
2020-02-10 16:09:27 +00:00
|
|
|
/* 16 E> */ B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionEnter), R(4), U8(2),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star0),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Mov), R(context), R(4),
|
|
|
|
|
/* 43 S> */ B(CreateArrayLiteral), U8(2), U8(0), U8(37),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaNamedProperty), R(7), U8(3), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfUndefinedOrNull), U8(14),
|
|
|
|
|
B(Star8),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(CallProperty0), R(8), R(7), U8(3),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfJSReceiver), U8(21),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(CallRuntime), U16(Runtime::kThrowSymbolAsyncIteratorInvalid), R(0), U8(0),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(7), U8(4), U8(5),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(CallProperty0), R(8), R(7), U8(7),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_CreateAsyncFromSyncIterator), R(8), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star6),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(6), U8(5), U8(9),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(context), R(10),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaTrue),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-01-14 14:15:52 +00:00
|
|
|
/* 38 S> */ B(CallProperty0), R(5), R(6), U8(11),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star13),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(0), R(12),
|
|
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionAwaitUncaught), R(12), U8(2),
|
|
|
|
|
B(SuspendGenerator), R(0), R(0), U8(12), U8(0),
|
|
|
|
|
B(ResumeGenerator), R(0), R(0), U8(12),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star12),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star13),
|
2017-05-24 15:48:27 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(13),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(JumpIfTrue), U8(5),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(12),
|
Reland "[async-iteration] implement spec-change to `yield` in async generators"
Per https://github.com/tc39/proposal-async-iteration/pull/102/files:
AsyncGeneratorResolve no longer unwraps a value component. Instead, the value is
unwrapped before the builtin call via Await, allowing Promise rejections to
affect the generator control flow.
Thus, all `yield <expr>` implicitly become `yield await <expr>`.
Additionally, `return <expr>` becomes `return await <expr>`. Finally, when the
generator is resumed with `.return()`, the parameter passed to .return() is
awaited before generator execution properly continues).
BUG=v8:6187, v8:5855
R=littledan@chromium.org, neis@chromium.org, adamk@chromium.org
TBR=rmcilroy@chromium.org, neis@chromium.org
Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: Id7718028fd555481f9f4ca0dbecfa788e3057c48
Reviewed-on: https://chromium-review.googlesource.com/594500
Reviewed-by: Caitlin Potter <caitp@igalia.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Caitlin Potter <caitp@igalia.com>
Cr-Commit-Position: refs/heads/master@{#47058}
2017-08-01 14:45:03 +00:00
|
|
|
B(ReThrow),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(12),
|
|
|
|
|
B(Mov), R(12), R(11),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(JumpIfJSReceiver), U8(7),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(11), U8(1),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(11), U8(6), U8(13),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfToBooleanTrue), U8(23),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(11), U8(7), U8(15),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star11),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(11), R(1),
|
2019-01-31 15:36:58 +00:00
|
|
|
/* 38 S> */ B(Mov), R(1), R(3),
|
2019-01-02 16:12:54 +00:00
|
|
|
/* 56 S> */ B(LdaSmi), I8(1),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(11), R(9),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
|
|
|
|
B(Jump), U8(11),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaSmi), I8(-1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star9),
|
|
|
|
|
B(Star8),
|
|
|
|
|
B(Jump), U8(5),
|
|
|
|
|
B(Star9),
|
2019-01-02 16:12:54 +00:00
|
|
|
B(LdaZero),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaTheHole),
|
|
|
|
|
B(SetPendingMessage),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star10),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(7),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfToBooleanTrue), U8(72),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(Mov), R(context), R(14),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(6), U8(8), U8(17),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfUndefinedOrNull), U8(63),
|
|
|
|
|
B(Star15),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(CallProperty0), R(15), R(6), U8(19),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Star), R(17),
|
|
|
|
|
B(Mov), R(0), R(16),
|
|
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionAwaitUncaught), R(16), U8(2),
|
|
|
|
|
B(SuspendGenerator), R(0), R(0), U8(16), U8(1),
|
|
|
|
|
B(ResumeGenerator), R(0), R(0), U8(16),
|
|
|
|
|
B(Star), R(16),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Star), R(17),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(17),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(JumpIfTrue), U8(5),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(16),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(ReThrow),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(16),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfJSReceiver), U8(20),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Star), R(18),
|
|
|
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(18), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Jump), U8(11),
|
|
|
|
|
B(Star14),
|
2018-01-23 13:51:38 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(8),
|
2018-01-23 13:51:38 +00:00
|
|
|
B(JumpIfTrue), U8(5),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(Ldar), R(14),
|
2018-01-23 13:51:38 +00:00
|
|
|
B(ReThrow),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Ldar), R(10),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(SetPendingMessage),
|
|
|
|
|
B(Ldar), R(8),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(SwitchOnSmiNoFeedback), U8(9), U8(2), I8(0),
|
[async] Improve async function handling.
This change introduces new intrinsics used to desugar async functions
in the Parser and the BytecodeGenerator, namely we introduce a new
%_AsyncFunctionEnter intrinsic that constructs the generator object
for the async function (and in the future will also create the outer
promise for the async function). This generator object is internal
and never escapes to user code, plus since async functions don't have
a "prototype" property, we can just a single map here instead of tracking
the prototype/initial_map on every async function. This saves one word
per async function plus one initial_map per async function that was
invoked at least once.
We also introduce two new intrinsics %_AsyncFunctionReject, which
rejects the outer promise with the caught exception, and another
%_AsyncFunctionResolve, which resolves the outer promise with the
right hand side of the `return` statement. These functions also perform
the DevTools part of the job (aka popping from the promise stack and
sending the debug event). This allows us to get rid of the implicit
try-finally from async functions completely; because the finally
block only called to the %AsyncFunctionPromiseRelease builtin, which
was used to inform DevTools.
In essence we now turn an async function like
```js
async function f(x) { return await bar(x); }
```
into something like this (in Parser and BytecodeGenerator respectively):
```
function f(x) {
.generator_object = %_AsyncFunctionEnter(.closure, this);
.promise = %AsyncFunctionCreatePromise();
try {
.tmp = await bar(x);
return %_AsyncFunctionResolve(.promise, .tmp);
} catch (e) {
return %_AsyncFunctionReject(.promise, e);
}
}
```
Overall the bytecode for async functions gets significantly shorter
already (and will get even shorter once we put the outer promise into
the async function generator object). For example the bytecode for a
simple async function
```js
async function f(x) { return await x; }
```
goes from 175 bytes to 110 bytes (a ~38% reduction in size), which
is in particular due to the simplification around the try-finally
removal.
Overall this seems to improve the doxbee-async-es2017-native test by
around 2-3%. On the test case mentioned in v8:8276 we go from
1124ms to 441ms, which corresponds to a 60% reduction in total
execution time!
Tbr: marja@chromium.org
Bug: v8:7253, v8:7522, v8:8276
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id29dc92de7490b387ff697860c900cee44c9a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/1269041
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56502}
2018-10-10 05:54:39 +00:00
|
|
|
B(Jump), U8(19),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(9),
|
2019-01-02 16:12:54 +00:00
|
|
|
B(ReThrow),
|
[async] Improve async function handling.
This change introduces new intrinsics used to desugar async functions
in the Parser and the BytecodeGenerator, namely we introduce a new
%_AsyncFunctionEnter intrinsic that constructs the generator object
for the async function (and in the future will also create the outer
promise for the async function). This generator object is internal
and never escapes to user code, plus since async functions don't have
a "prototype" property, we can just a single map here instead of tracking
the prototype/initial_map on every async function. This saves one word
per async function plus one initial_map per async function that was
invoked at least once.
We also introduce two new intrinsics %_AsyncFunctionReject, which
rejects the outer promise with the caught exception, and another
%_AsyncFunctionResolve, which resolves the outer promise with the
right hand side of the `return` statement. These functions also perform
the DevTools part of the job (aka popping from the promise stack and
sending the debug event). This allows us to get rid of the implicit
try-finally from async functions completely; because the finally
block only called to the %AsyncFunctionPromiseRelease builtin, which
was used to inform DevTools.
In essence we now turn an async function like
```js
async function f(x) { return await bar(x); }
```
into something like this (in Parser and BytecodeGenerator respectively):
```
function f(x) {
.generator_object = %_AsyncFunctionEnter(.closure, this);
.promise = %AsyncFunctionCreatePromise();
try {
.tmp = await bar(x);
return %_AsyncFunctionResolve(.promise, .tmp);
} catch (e) {
return %_AsyncFunctionReject(.promise, e);
}
}
```
Overall the bytecode for async functions gets significantly shorter
already (and will get even shorter once we put the outer promise into
the async function generator object). For example the bytecode for a
simple async function
```js
async function f(x) { return await x; }
```
goes from 175 bytes to 110 bytes (a ~38% reduction in size), which
is in particular due to the simplification around the try-finally
removal.
Overall this seems to improve the doxbee-async-es2017-native test by
around 2-3%. On the test case mentioned in v8:8276 we go from
1124ms to 441ms, which corresponds to a 60% reduction in total
execution time!
Tbr: marja@chromium.org
Bug: v8:7253, v8:7522, v8:8276
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id29dc92de7490b387ff697860c900cee44c9a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/1269041
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56502}
2018-10-10 05:54:39 +00:00
|
|
|
B(LdaTrue),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Star), R(16),
|
|
|
|
|
B(Mov), R(0), R(14),
|
|
|
|
|
B(Mov), R(9), R(15),
|
|
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionResolve), R(14), U8(3),
|
[debug] Don't put a source position on internal `Return`s.
Be explicit about source positions for `Return`s in the
BytecodeGenerator, and only do self-healing explicitly in the
`ReturnStatement` translation, where an end position of
`kNoSourcePosition` is turned into the return position of the
function literal.
This allows us to reason more easily about which `Return`s actually
receive a meaningful source position, and in particular it allows us
to construct the internal `Return`s for `yield` and `yield*` with no
source position attached to them. Previously they'd get the source
position for the implicit (final) return attached to it, which confused
the debugger and led to breakpoints being set in the completely wrong
spot.
Considering the simplified example
```
function* foo(){
var a = 1;
}
```
this would previously generate the following bytecode
```
0 : SwitchOnGeneratorState r0, [0], [1] { 0: @20 }
4 : Mov <closure>, r2
7 : Mov <this>, r3
13 E> 10 : InvokeIntrinsic [_CreateJSGeneratorObject], r2-r3
14 : Star0
13 E> 15 : SuspendGenerator r0, r0-r1, [0]
20 : ResumeGenerator r0, r0-r1
24 : Star2
25 : InvokeIntrinsic [_GeneratorGetResumeMode], r0-r0
29 : SwitchOnSmiNoFeedback [1], [2], [0] { 0: @39, 1: @36 }
33 : Ldar r2
13 E> 35 : Throw
36 : Ldar r2
30 S> 38 : Return <=========================== internal Return
27 S> 39 : LdaSmi [1]
41 : Star1
42 : LdaUndefined
30 S> 43 : Return
```
where everything between offset 4 and 42 corresponds to the implicit
yield at the beginning of every generator function, in particular the
code between 20 and 42 corresponds to that initial yields resumption
logic. Notice how the internal Return at offset 38 gets assigned the
source position of the function literal (the same as the implicit
return at the end). This confuses the debugger quite a bit when trying
to set a breakpoint on the closing brace, since it's going in bytecode
order and will thus discover the `Return` at offset 38 first (matching
the source position 30 it's currently looking for) and setting the
breakpoint there. This `Return` bytecode however is only executed when
the generator is resumed via `GeneratorPrototype.return()`, and it'll
not hit when the developer uses the generator normally, which is not
the desired behavior and extremely confusing (especially since stepping
on the other hand works as expected).
With this patch, we no longer slap a source position (and in particular
not the function literal's return position) onto these internal
`Return`s as you can see from the generated bytecode below:
```
0 : SwitchOnGeneratorState r0, [0], [1] { 0: @20 }
4 : Mov <closure>, r2
7 : Mov <this>, r3
13 E> 10 : InvokeIntrinsic [_CreateJSGeneratorObject], r2-r3
14 : Star0
13 E> 15 : SuspendGenerator r0, r0-r1, [0]
20 : ResumeGenerator r0, r0-r1
24 : Star2
25 : InvokeIntrinsic [_GeneratorGetResumeMode], r0-r0
29 : SwitchOnSmiNoFeedback [1], [2], [0] { 0: @39, 1: @36 }
33 : Ldar r2
13 E> 35 : Throw
36 : Ldar r2
38 : Return
27 S> 39 : LdaSmi [1]
41 : Star1
42 : LdaUndefined
30 S> 43 : Return
```
This also allows us to remove the break position finding hack that was
kept in BreakIterator::BreakIndexFromPosition() for generators and
modules.
Fixed: chromium:901819
Change-Id: If19a6b26e2622d49b6b5e54bf7a162747543f970
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727820
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73119}
2021-03-01 19:04:43 +00:00
|
|
|
B(Return),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaUndefined),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star6),
|
[async] Improve async function handling.
This change introduces new intrinsics used to desugar async functions
in the Parser and the BytecodeGenerator, namely we introduce a new
%_AsyncFunctionEnter intrinsic that constructs the generator object
for the async function (and in the future will also create the outer
promise for the async function). This generator object is internal
and never escapes to user code, plus since async functions don't have
a "prototype" property, we can just a single map here instead of tracking
the prototype/initial_map on every async function. This saves one word
per async function plus one initial_map per async function that was
invoked at least once.
We also introduce two new intrinsics %_AsyncFunctionReject, which
rejects the outer promise with the caught exception, and another
%_AsyncFunctionResolve, which resolves the outer promise with the
right hand side of the `return` statement. These functions also perform
the DevTools part of the job (aka popping from the promise stack and
sending the debug event). This allows us to get rid of the implicit
try-finally from async functions completely; because the finally
block only called to the %AsyncFunctionPromiseRelease builtin, which
was used to inform DevTools.
In essence we now turn an async function like
```js
async function f(x) { return await bar(x); }
```
into something like this (in Parser and BytecodeGenerator respectively):
```
function f(x) {
.generator_object = %_AsyncFunctionEnter(.closure, this);
.promise = %AsyncFunctionCreatePromise();
try {
.tmp = await bar(x);
return %_AsyncFunctionResolve(.promise, .tmp);
} catch (e) {
return %_AsyncFunctionReject(.promise, e);
}
}
```
Overall the bytecode for async functions gets significantly shorter
already (and will get even shorter once we put the outer promise into
the async function generator object). For example the bytecode for a
simple async function
```js
async function f(x) { return await x; }
```
goes from 175 bytes to 110 bytes (a ~38% reduction in size), which
is in particular due to the simplification around the try-finally
removal.
Overall this seems to improve the doxbee-async-es2017-native test by
around 2-3%. On the test case mentioned in v8:8276 we go from
1124ms to 441ms, which corresponds to a 60% reduction in total
execution time!
Tbr: marja@chromium.org
Bug: v8:7253, v8:7522, v8:8276
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id29dc92de7490b387ff697860c900cee44c9a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/1269041
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56502}
2018-10-10 05:54:39 +00:00
|
|
|
B(LdaTrue),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(Mov), R(0), R(5),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionResolve), R(5), U8(3),
|
[async] Improve async function handling.
This change introduces new intrinsics used to desugar async functions
in the Parser and the BytecodeGenerator, namely we introduce a new
%_AsyncFunctionEnter intrinsic that constructs the generator object
for the async function (and in the future will also create the outer
promise for the async function). This generator object is internal
and never escapes to user code, plus since async functions don't have
a "prototype" property, we can just a single map here instead of tracking
the prototype/initial_map on every async function. This saves one word
per async function plus one initial_map per async function that was
invoked at least once.
We also introduce two new intrinsics %_AsyncFunctionReject, which
rejects the outer promise with the caught exception, and another
%_AsyncFunctionResolve, which resolves the outer promise with the
right hand side of the `return` statement. These functions also perform
the DevTools part of the job (aka popping from the promise stack and
sending the debug event). This allows us to get rid of the implicit
try-finally from async functions completely; because the finally
block only called to the %AsyncFunctionPromiseRelease builtin, which
was used to inform DevTools.
In essence we now turn an async function like
```js
async function f(x) { return await bar(x); }
```
into something like this (in Parser and BytecodeGenerator respectively):
```
function f(x) {
.generator_object = %_AsyncFunctionEnter(.closure, this);
.promise = %AsyncFunctionCreatePromise();
try {
.tmp = await bar(x);
return %_AsyncFunctionResolve(.promise, .tmp);
} catch (e) {
return %_AsyncFunctionReject(.promise, e);
}
}
```
Overall the bytecode for async functions gets significantly shorter
already (and will get even shorter once we put the outer promise into
the async function generator object). For example the bytecode for a
simple async function
```js
async function f(x) { return await x; }
```
goes from 175 bytes to 110 bytes (a ~38% reduction in size), which
is in particular due to the simplification around the try-finally
removal.
Overall this seems to improve the doxbee-async-es2017-native test by
around 2-3%. On the test case mentioned in v8:8276 we go from
1124ms to 441ms, which corresponds to a 60% reduction in total
execution time!
Tbr: marja@chromium.org
Bug: v8:7253, v8:7522, v8:8276
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id29dc92de7490b387ff697860c900cee44c9a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/1269041
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56502}
2018-10-10 05:54:39 +00:00
|
|
|
/* 68 S> */ B(Return),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(CreateCatchContext), R(5), U8(11),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star4),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaTheHole),
|
|
|
|
|
B(SetPendingMessage),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Ldar), R(4),
|
|
|
|
|
B(PushContext), R(5),
|
Reland x3 "[runtime] Remove extension slots from context objects"
Original change's description:
> [runtime] Remove extension slots from context objects
>
> Context objects have an extension slot, which contains further
> additional data that depends on the type of the context.
>
> This CL removes the extension slot from contexts that don't need
> them, hence reducing memory.
>
> The following contexts will still have an extension slot: native,
> module, await, block and with contexts. See objects/contexts.h for
> what the slot is used for.
> The following contexts will not have an extension slot anymore (they
> were not used before): script, catch and builtin contexts.
> Eval and function contexts only have the extension slot if they
> contain a sloppy eval.
>
> Bug: v8:9744
> Change-Id: I8ca56c22fa02437bbac392ea72174ebfca80e030
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863191
> Commit-Queue: Victor Gomes <victorgomes@google.com>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Auto-Submit: Victor Gomes <victorgomes@google.com>
> Cr-Commit-Position: refs/heads/master@{#64372}
TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org
Bug: v8:9744
Change-Id: I8700ed2fa62c89e86c39bb16ac3167f38ea8d63f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873695
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64477}
2019-10-22 12:59:24 +00:00
|
|
|
B(LdaImmutableCurrentContextSlot), U8(2),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2018-05-30 14:21:39 +00:00
|
|
|
B(LdaTrue),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(Mov), R(0), R(6),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionReject), R(6), U8(3),
|
2021-04-30 04:54:17 +00:00
|
|
|
B(Return),
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
constant pool: [
|
2021-02-17 14:36:58 +00:00
|
|
|
Smi [85],
|
|
|
|
|
Smi [186],
|
2018-07-05 18:34:09 +00:00
|
|
|
ARRAY_BOILERPLATE_DESCRIPTION_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
SYMBOL_TYPE,
|
2019-09-06 12:41:00 +00:00
|
|
|
SYMBOL_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["return"],
|
2017-05-16 11:36:04 +00:00
|
|
|
Smi [6],
|
2019-01-02 16:12:54 +00:00
|
|
|
Smi [9],
|
2018-02-16 12:36:47 +00:00
|
|
|
SCOPE_INFO_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
handlers: [
|
2021-02-17 14:36:58 +00:00
|
|
|
[18, 268, 268],
|
|
|
|
|
[66, 142, 148],
|
|
|
|
|
[161, 217, 219],
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
snippet: "
|
|
|
|
|
async function f() {
|
|
|
|
|
for await (let x of [10, 20, 30]) {
|
|
|
|
|
if (x == 10) continue;
|
|
|
|
|
if (x == 20) break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
f();
|
|
|
|
|
"
|
2019-08-23 14:23:52 +00:00
|
|
|
frame size: 19
|
2017-02-24 17:48:49 +00:00
|
|
|
parameter count: 1
|
2021-02-17 14:36:58 +00:00
|
|
|
bytecode array length: 288
|
2017-02-24 17:48:49 +00:00
|
|
|
bytecodes: [
|
2019-01-31 15:36:58 +00:00
|
|
|
B(SwitchOnGeneratorState), R(0), U8(0), U8(2),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Mov), R(closure), R(4),
|
|
|
|
|
B(Mov), R(this), R(5),
|
2020-02-10 16:09:27 +00:00
|
|
|
/* 16 E> */ B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionEnter), R(4), U8(2),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star0),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Mov), R(context), R(4),
|
|
|
|
|
/* 43 S> */ B(CreateArrayLiteral), U8(2), U8(0), U8(37),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaNamedProperty), R(7), U8(3), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfUndefinedOrNull), U8(14),
|
|
|
|
|
B(Star8),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(CallProperty0), R(8), R(7), U8(3),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfJSReceiver), U8(21),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(CallRuntime), U16(Runtime::kThrowSymbolAsyncIteratorInvalid), R(0), U8(0),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(7), U8(4), U8(5),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(CallProperty0), R(8), R(7), U8(7),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_CreateAsyncFromSyncIterator), R(8), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star6),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(6), U8(5), U8(9),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(context), R(10),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaTrue),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-01-14 14:15:52 +00:00
|
|
|
/* 38 S> */ B(CallProperty0), R(5), R(6), U8(11),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star13),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(0), R(12),
|
|
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionAwaitUncaught), R(12), U8(2),
|
|
|
|
|
B(SuspendGenerator), R(0), R(0), U8(12), U8(0),
|
|
|
|
|
B(ResumeGenerator), R(0), R(0), U8(12),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star12),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star13),
|
2017-05-24 15:48:27 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(13),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(JumpIfTrue), U8(5),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(12),
|
Reland "[async-iteration] implement spec-change to `yield` in async generators"
Per https://github.com/tc39/proposal-async-iteration/pull/102/files:
AsyncGeneratorResolve no longer unwraps a value component. Instead, the value is
unwrapped before the builtin call via Await, allowing Promise rejections to
affect the generator control flow.
Thus, all `yield <expr>` implicitly become `yield await <expr>`.
Additionally, `return <expr>` becomes `return await <expr>`. Finally, when the
generator is resumed with `.return()`, the parameter passed to .return() is
awaited before generator execution properly continues).
BUG=v8:6187, v8:5855
R=littledan@chromium.org, neis@chromium.org, adamk@chromium.org
TBR=rmcilroy@chromium.org, neis@chromium.org
Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: Id7718028fd555481f9f4ca0dbecfa788e3057c48
Reviewed-on: https://chromium-review.googlesource.com/594500
Reviewed-by: Caitlin Potter <caitp@igalia.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Caitlin Potter <caitp@igalia.com>
Cr-Commit-Position: refs/heads/master@{#47058}
2017-08-01 14:45:03 +00:00
|
|
|
B(ReThrow),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(12),
|
|
|
|
|
B(Mov), R(12), R(11),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(JumpIfJSReceiver), U8(7),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(11), U8(1),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(11), U8(6), U8(13),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfToBooleanTrue), U8(36),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(11), U8(7), U8(15),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star11),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(11), R(1),
|
2019-01-31 15:36:58 +00:00
|
|
|
/* 38 S> */ B(Mov), R(1), R(3),
|
2017-05-24 13:54:57 +00:00
|
|
|
/* 63 S> */ B(LdaSmi), I8(10),
|
2019-01-31 15:36:58 +00:00
|
|
|
/* 69 E> */ B(TestEqual), R(3), U8(17),
|
2017-05-24 13:54:57 +00:00
|
|
|
B(JumpIfFalse), U8(4),
|
2019-01-14 14:15:52 +00:00
|
|
|
/* 76 S> */ B(Jump), U8(11),
|
2017-05-24 13:54:57 +00:00
|
|
|
/* 90 S> */ B(LdaSmi), I8(20),
|
2019-01-31 15:36:58 +00:00
|
|
|
/* 96 E> */ B(TestEqual), R(3), U8(18),
|
2017-05-24 13:54:57 +00:00
|
|
|
B(JumpIfFalse), U8(4),
|
2020-03-20 11:13:04 +00:00
|
|
|
/* 103 S> */ B(Jump), U8(5),
|
2021-02-17 14:36:58 +00:00
|
|
|
/* 23 E> */ B(JumpLoop), U8(86), I8(0),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaSmi), I8(-1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star9),
|
|
|
|
|
B(Star8),
|
|
|
|
|
B(Jump), U8(5),
|
|
|
|
|
B(Star9),
|
2018-10-11 08:35:56 +00:00
|
|
|
B(LdaZero),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaTheHole),
|
|
|
|
|
B(SetPendingMessage),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star10),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(7),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfToBooleanTrue), U8(72),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(Mov), R(context), R(14),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(LdaNamedProperty), R(6), U8(8), U8(19),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfUndefinedOrNull), U8(63),
|
|
|
|
|
B(Star15),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(CallProperty0), R(15), R(6), U8(21),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Star), R(17),
|
|
|
|
|
B(Mov), R(0), R(16),
|
|
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionAwaitUncaught), R(16), U8(2),
|
|
|
|
|
B(SuspendGenerator), R(0), R(0), U8(16), U8(1),
|
|
|
|
|
B(ResumeGenerator), R(0), R(0), U8(16),
|
|
|
|
|
B(Star), R(16),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Star), R(17),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(17),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(JumpIfTrue), U8(5),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(16),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(ReThrow),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(16),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfJSReceiver), U8(20),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Star), R(18),
|
|
|
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(18), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Jump), U8(11),
|
|
|
|
|
B(Star14),
|
2018-01-23 13:51:38 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(8),
|
2018-01-23 13:51:38 +00:00
|
|
|
B(JumpIfTrue), U8(5),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(Ldar), R(14),
|
2018-01-23 13:51:38 +00:00
|
|
|
B(ReThrow),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(10),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(SetPendingMessage),
|
2017-05-16 15:20:09 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(8),
|
2017-07-13 13:53:13 +00:00
|
|
|
B(JumpIfFalse), U8(5),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(9),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(ReThrow),
|
|
|
|
|
B(LdaUndefined),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star6),
|
[async] Improve async function handling.
This change introduces new intrinsics used to desugar async functions
in the Parser and the BytecodeGenerator, namely we introduce a new
%_AsyncFunctionEnter intrinsic that constructs the generator object
for the async function (and in the future will also create the outer
promise for the async function). This generator object is internal
and never escapes to user code, plus since async functions don't have
a "prototype" property, we can just a single map here instead of tracking
the prototype/initial_map on every async function. This saves one word
per async function plus one initial_map per async function that was
invoked at least once.
We also introduce two new intrinsics %_AsyncFunctionReject, which
rejects the outer promise with the caught exception, and another
%_AsyncFunctionResolve, which resolves the outer promise with the
right hand side of the `return` statement. These functions also perform
the DevTools part of the job (aka popping from the promise stack and
sending the debug event). This allows us to get rid of the implicit
try-finally from async functions completely; because the finally
block only called to the %AsyncFunctionPromiseRelease builtin, which
was used to inform DevTools.
In essence we now turn an async function like
```js
async function f(x) { return await bar(x); }
```
into something like this (in Parser and BytecodeGenerator respectively):
```
function f(x) {
.generator_object = %_AsyncFunctionEnter(.closure, this);
.promise = %AsyncFunctionCreatePromise();
try {
.tmp = await bar(x);
return %_AsyncFunctionResolve(.promise, .tmp);
} catch (e) {
return %_AsyncFunctionReject(.promise, e);
}
}
```
Overall the bytecode for async functions gets significantly shorter
already (and will get even shorter once we put the outer promise into
the async function generator object). For example the bytecode for a
simple async function
```js
async function f(x) { return await x; }
```
goes from 175 bytes to 110 bytes (a ~38% reduction in size), which
is in particular due to the simplification around the try-finally
removal.
Overall this seems to improve the doxbee-async-es2017-native test by
around 2-3%. On the test case mentioned in v8:8276 we go from
1124ms to 441ms, which corresponds to a 60% reduction in total
execution time!
Tbr: marja@chromium.org
Bug: v8:7253, v8:7522, v8:8276
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id29dc92de7490b387ff697860c900cee44c9a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/1269041
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56502}
2018-10-10 05:54:39 +00:00
|
|
|
B(LdaTrue),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(Mov), R(0), R(5),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionResolve), R(5), U8(3),
|
[async] Improve async function handling.
This change introduces new intrinsics used to desugar async functions
in the Parser and the BytecodeGenerator, namely we introduce a new
%_AsyncFunctionEnter intrinsic that constructs the generator object
for the async function (and in the future will also create the outer
promise for the async function). This generator object is internal
and never escapes to user code, plus since async functions don't have
a "prototype" property, we can just a single map here instead of tracking
the prototype/initial_map on every async function. This saves one word
per async function plus one initial_map per async function that was
invoked at least once.
We also introduce two new intrinsics %_AsyncFunctionReject, which
rejects the outer promise with the caught exception, and another
%_AsyncFunctionResolve, which resolves the outer promise with the
right hand side of the `return` statement. These functions also perform
the DevTools part of the job (aka popping from the promise stack and
sending the debug event). This allows us to get rid of the implicit
try-finally from async functions completely; because the finally
block only called to the %AsyncFunctionPromiseRelease builtin, which
was used to inform DevTools.
In essence we now turn an async function like
```js
async function f(x) { return await bar(x); }
```
into something like this (in Parser and BytecodeGenerator respectively):
```
function f(x) {
.generator_object = %_AsyncFunctionEnter(.closure, this);
.promise = %AsyncFunctionCreatePromise();
try {
.tmp = await bar(x);
return %_AsyncFunctionResolve(.promise, .tmp);
} catch (e) {
return %_AsyncFunctionReject(.promise, e);
}
}
```
Overall the bytecode for async functions gets significantly shorter
already (and will get even shorter once we put the outer promise into
the async function generator object). For example the bytecode for a
simple async function
```js
async function f(x) { return await x; }
```
goes from 175 bytes to 110 bytes (a ~38% reduction in size), which
is in particular due to the simplification around the try-finally
removal.
Overall this seems to improve the doxbee-async-es2017-native test by
around 2-3%. On the test case mentioned in v8:8276 we go from
1124ms to 441ms, which corresponds to a 60% reduction in total
execution time!
Tbr: marja@chromium.org
Bug: v8:7253, v8:7522, v8:8276
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id29dc92de7490b387ff697860c900cee44c9a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/1269041
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56502}
2018-10-10 05:54:39 +00:00
|
|
|
/* 114 S> */ B(Return),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(CreateCatchContext), R(5), U8(9),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star4),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaTheHole),
|
|
|
|
|
B(SetPendingMessage),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Ldar), R(4),
|
|
|
|
|
B(PushContext), R(5),
|
Reland x3 "[runtime] Remove extension slots from context objects"
Original change's description:
> [runtime] Remove extension slots from context objects
>
> Context objects have an extension slot, which contains further
> additional data that depends on the type of the context.
>
> This CL removes the extension slot from contexts that don't need
> them, hence reducing memory.
>
> The following contexts will still have an extension slot: native,
> module, await, block and with contexts. See objects/contexts.h for
> what the slot is used for.
> The following contexts will not have an extension slot anymore (they
> were not used before): script, catch and builtin contexts.
> Eval and function contexts only have the extension slot if they
> contain a sloppy eval.
>
> Bug: v8:9744
> Change-Id: I8ca56c22fa02437bbac392ea72174ebfca80e030
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863191
> Commit-Queue: Victor Gomes <victorgomes@google.com>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Auto-Submit: Victor Gomes <victorgomes@google.com>
> Cr-Commit-Position: refs/heads/master@{#64372}
TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org
Bug: v8:9744
Change-Id: I8700ed2fa62c89e86c39bb16ac3167f38ea8d63f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873695
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64477}
2019-10-22 12:59:24 +00:00
|
|
|
B(LdaImmutableCurrentContextSlot), U8(2),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2018-05-30 14:21:39 +00:00
|
|
|
B(LdaTrue),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2019-01-31 15:36:58 +00:00
|
|
|
B(Mov), R(0), R(6),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionReject), R(6), U8(3),
|
2021-04-30 04:54:17 +00:00
|
|
|
B(Return),
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
constant pool: [
|
2021-02-17 14:36:58 +00:00
|
|
|
Smi [85],
|
|
|
|
|
Smi [199],
|
2018-07-05 18:34:09 +00:00
|
|
|
ARRAY_BOILERPLATE_DESCRIPTION_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
SYMBOL_TYPE,
|
2019-09-06 12:41:00 +00:00
|
|
|
SYMBOL_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["return"],
|
2018-02-16 12:36:47 +00:00
|
|
|
SCOPE_INFO_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
handlers: [
|
2021-02-17 14:36:58 +00:00
|
|
|
[18, 264, 264],
|
|
|
|
|
[66, 155, 161],
|
|
|
|
|
[174, 230, 232],
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
snippet: "
|
|
|
|
|
async function f() {
|
|
|
|
|
var x = { 'a': 1, 'b': 2 };
|
|
|
|
|
for (x['a'] of [1,2,3]) { return x['a']; }
|
|
|
|
|
}
|
|
|
|
|
f();
|
|
|
|
|
"
|
2020-05-07 19:34:44 +00:00
|
|
|
frame size: 14
|
2017-02-24 17:48:49 +00:00
|
|
|
parameter count: 1
|
2021-02-17 14:36:58 +00:00
|
|
|
bytecode array length: 204
|
2017-02-24 17:48:49 +00:00
|
|
|
bytecodes: [
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Mov), R(closure), R(2),
|
|
|
|
|
B(Mov), R(this), R(3),
|
2020-02-10 16:09:27 +00:00
|
|
|
/* 16 E> */ B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionEnter), R(2), U8(2),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star0),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Mov), R(context), R(2),
|
2018-11-08 08:55:43 +00:00
|
|
|
/* 31 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(41),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star1),
|
2017-07-27 12:45:00 +00:00
|
|
|
/* 68 S> */ B(CreateArrayLiteral), U8(1), U8(1), U8(37),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2019-09-06 12:41:00 +00:00
|
|
|
B(GetIterator), R(5), U8(2), U8(4),
|
2019-12-20 14:06:40 +00:00
|
|
|
B(JumpIfJSReceiver), U8(7),
|
|
|
|
|
B(CallRuntime), U16(Runtime::kThrowSymbolIteratorInvalid), R(0), U8(0),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star4),
|
2019-08-08 20:43:41 +00:00
|
|
|
B(LdaNamedProperty), R(4), U8(2), U8(6),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star3),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(context), R(8),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaTrue),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2019-01-14 14:15:52 +00:00
|
|
|
/* 59 S> */ B(CallProperty0), R(3), R(4), U8(8),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star9),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(JumpIfJSReceiver), U8(7),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(9), U8(1),
|
|
|
|
|
B(LdaNamedProperty), R(9), U8(3), U8(10),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfToBooleanTrue), U8(28),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(LdaNamedProperty), R(9), U8(4), U8(12),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star9),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(9),
|
2019-08-08 20:43:41 +00:00
|
|
|
/* 58 E> */ B(StaNamedProperty), R(1), U8(5), U8(14),
|
|
|
|
|
/* 87 S> */ B(LdaNamedProperty), R(1), U8(5), U8(16),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaSmi), I8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star6),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(1), R(10),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Jump), U8(11),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaSmi), I8(-1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star7),
|
|
|
|
|
B(Star6),
|
|
|
|
|
B(Jump), U8(5),
|
|
|
|
|
B(Star7),
|
2019-01-02 16:12:54 +00:00
|
|
|
B(LdaZero),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star6),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaTheHole),
|
|
|
|
|
B(SetPendingMessage),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star8),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(5),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfToBooleanTrue), U8(35),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(Mov), R(context), R(11),
|
2019-08-08 20:43:41 +00:00
|
|
|
B(LdaNamedProperty), R(4), U8(6), U8(18),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfUndefinedOrNull), U8(26),
|
|
|
|
|
B(Star12),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(CallProperty0), R(12), R(4), U8(20),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(JumpIfJSReceiver), U8(19),
|
|
|
|
|
B(Star13),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(13), U8(1),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Jump), U8(11),
|
|
|
|
|
B(Star11),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(LdaZero),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(TestReferenceEqual), R(6),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(JumpIfTrue), U8(5),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(Ldar), R(11),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(ReThrow),
|
|
|
|
|
B(Ldar), R(8),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(SetPendingMessage),
|
|
|
|
|
B(Ldar), R(6),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(SwitchOnSmiNoFeedback), U8(7), U8(2), I8(0),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Jump), U8(18),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Ldar), R(7),
|
2019-01-02 16:12:54 +00:00
|
|
|
B(ReThrow),
|
[async] Improve async function handling.
This change introduces new intrinsics used to desugar async functions
in the Parser and the BytecodeGenerator, namely we introduce a new
%_AsyncFunctionEnter intrinsic that constructs the generator object
for the async function (and in the future will also create the outer
promise for the async function). This generator object is internal
and never escapes to user code, plus since async functions don't have
a "prototype" property, we can just a single map here instead of tracking
the prototype/initial_map on every async function. This saves one word
per async function plus one initial_map per async function that was
invoked at least once.
We also introduce two new intrinsics %_AsyncFunctionReject, which
rejects the outer promise with the caught exception, and another
%_AsyncFunctionResolve, which resolves the outer promise with the
right hand side of the `return` statement. These functions also perform
the DevTools part of the job (aka popping from the promise stack and
sending the debug event). This allows us to get rid of the implicit
try-finally from async functions completely; because the finally
block only called to the %AsyncFunctionPromiseRelease builtin, which
was used to inform DevTools.
In essence we now turn an async function like
```js
async function f(x) { return await bar(x); }
```
into something like this (in Parser and BytecodeGenerator respectively):
```
function f(x) {
.generator_object = %_AsyncFunctionEnter(.closure, this);
.promise = %AsyncFunctionCreatePromise();
try {
.tmp = await bar(x);
return %_AsyncFunctionResolve(.promise, .tmp);
} catch (e) {
return %_AsyncFunctionReject(.promise, e);
}
}
```
Overall the bytecode for async functions gets significantly shorter
already (and will get even shorter once we put the outer promise into
the async function generator object). For example the bytecode for a
simple async function
```js
async function f(x) { return await x; }
```
goes from 175 bytes to 110 bytes (a ~38% reduction in size), which
is in particular due to the simplification around the try-finally
removal.
Overall this seems to improve the doxbee-async-es2017-native test by
around 2-3%. On the test case mentioned in v8:8276 we go from
1124ms to 441ms, which corresponds to a 60% reduction in total
execution time!
Tbr: marja@chromium.org
Bug: v8:7253, v8:7522, v8:8276
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id29dc92de7490b387ff697860c900cee44c9a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/1269041
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56502}
2018-10-10 05:54:39 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star13),
|
2019-08-23 14:23:52 +00:00
|
|
|
B(Mov), R(0), R(11),
|
|
|
|
|
B(Mov), R(7), R(12),
|
|
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionResolve), R(11), U8(3),
|
[debug] Don't put a source position on internal `Return`s.
Be explicit about source positions for `Return`s in the
BytecodeGenerator, and only do self-healing explicitly in the
`ReturnStatement` translation, where an end position of
`kNoSourcePosition` is turned into the return position of the
function literal.
This allows us to reason more easily about which `Return`s actually
receive a meaningful source position, and in particular it allows us
to construct the internal `Return`s for `yield` and `yield*` with no
source position attached to them. Previously they'd get the source
position for the implicit (final) return attached to it, which confused
the debugger and led to breakpoints being set in the completely wrong
spot.
Considering the simplified example
```
function* foo(){
var a = 1;
}
```
this would previously generate the following bytecode
```
0 : SwitchOnGeneratorState r0, [0], [1] { 0: @20 }
4 : Mov <closure>, r2
7 : Mov <this>, r3
13 E> 10 : InvokeIntrinsic [_CreateJSGeneratorObject], r2-r3
14 : Star0
13 E> 15 : SuspendGenerator r0, r0-r1, [0]
20 : ResumeGenerator r0, r0-r1
24 : Star2
25 : InvokeIntrinsic [_GeneratorGetResumeMode], r0-r0
29 : SwitchOnSmiNoFeedback [1], [2], [0] { 0: @39, 1: @36 }
33 : Ldar r2
13 E> 35 : Throw
36 : Ldar r2
30 S> 38 : Return <=========================== internal Return
27 S> 39 : LdaSmi [1]
41 : Star1
42 : LdaUndefined
30 S> 43 : Return
```
where everything between offset 4 and 42 corresponds to the implicit
yield at the beginning of every generator function, in particular the
code between 20 and 42 corresponds to that initial yields resumption
logic. Notice how the internal Return at offset 38 gets assigned the
source position of the function literal (the same as the implicit
return at the end). This confuses the debugger quite a bit when trying
to set a breakpoint on the closing brace, since it's going in bytecode
order and will thus discover the `Return` at offset 38 first (matching
the source position 30 it's currently looking for) and setting the
breakpoint there. This `Return` bytecode however is only executed when
the generator is resumed via `GeneratorPrototype.return()`, and it'll
not hit when the developer uses the generator normally, which is not
the desired behavior and extremely confusing (especially since stepping
on the other hand works as expected).
With this patch, we no longer slap a source position (and in particular
not the function literal's return position) onto these internal
`Return`s as you can see from the generated bytecode below:
```
0 : SwitchOnGeneratorState r0, [0], [1] { 0: @20 }
4 : Mov <closure>, r2
7 : Mov <this>, r3
13 E> 10 : InvokeIntrinsic [_CreateJSGeneratorObject], r2-r3
14 : Star0
13 E> 15 : SuspendGenerator r0, r0-r1, [0]
20 : ResumeGenerator r0, r0-r1
24 : Star2
25 : InvokeIntrinsic [_GeneratorGetResumeMode], r0-r0
29 : SwitchOnSmiNoFeedback [1], [2], [0] { 0: @39, 1: @36 }
33 : Ldar r2
13 E> 35 : Throw
36 : Ldar r2
38 : Return
27 S> 39 : LdaSmi [1]
41 : Star1
42 : LdaUndefined
30 S> 43 : Return
```
This also allows us to remove the break position finding hack that was
kept in BreakIterator::BreakIndexFromPosition() for generators and
modules.
Fixed: chromium:901819
Change-Id: If19a6b26e2622d49b6b5e54bf7a162747543f970
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727820
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73119}
2021-03-01 19:04:43 +00:00
|
|
|
B(Return),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaUndefined),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star4),
|
2018-01-11 17:24:11 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Mov), R(0), R(3),
|
|
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionResolve), R(3), U8(3),
|
[async] Improve async function handling.
This change introduces new intrinsics used to desugar async functions
in the Parser and the BytecodeGenerator, namely we introduce a new
%_AsyncFunctionEnter intrinsic that constructs the generator object
for the async function (and in the future will also create the outer
promise for the async function). This generator object is internal
and never escapes to user code, plus since async functions don't have
a "prototype" property, we can just a single map here instead of tracking
the prototype/initial_map on every async function. This saves one word
per async function plus one initial_map per async function that was
invoked at least once.
We also introduce two new intrinsics %_AsyncFunctionReject, which
rejects the outer promise with the caught exception, and another
%_AsyncFunctionResolve, which resolves the outer promise with the
right hand side of the `return` statement. These functions also perform
the DevTools part of the job (aka popping from the promise stack and
sending the debug event). This allows us to get rid of the implicit
try-finally from async functions completely; because the finally
block only called to the %AsyncFunctionPromiseRelease builtin, which
was used to inform DevTools.
In essence we now turn an async function like
```js
async function f(x) { return await bar(x); }
```
into something like this (in Parser and BytecodeGenerator respectively):
```
function f(x) {
.generator_object = %_AsyncFunctionEnter(.closure, this);
.promise = %AsyncFunctionCreatePromise();
try {
.tmp = await bar(x);
return %_AsyncFunctionResolve(.promise, .tmp);
} catch (e) {
return %_AsyncFunctionReject(.promise, e);
}
}
```
Overall the bytecode for async functions gets significantly shorter
already (and will get even shorter once we put the outer promise into
the async function generator object). For example the bytecode for a
simple async function
```js
async function f(x) { return await x; }
```
goes from 175 bytes to 110 bytes (a ~38% reduction in size), which
is in particular due to the simplification around the try-finally
removal.
Overall this seems to improve the doxbee-async-es2017-native test by
around 2-3%. On the test case mentioned in v8:8276 we go from
1124ms to 441ms, which corresponds to a 60% reduction in total
execution time!
Tbr: marja@chromium.org
Bug: v8:7253, v8:7522, v8:8276
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id29dc92de7490b387ff697860c900cee44c9a7a4
Reviewed-on: https://chromium-review.googlesource.com/c/1269041
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56502}
2018-10-10 05:54:39 +00:00
|
|
|
/* 96 S> */ B(Return),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star3),
|
2020-05-07 19:34:44 +00:00
|
|
|
B(CreateCatchContext), R(3), U8(9),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star2),
|
2017-02-24 17:48:49 +00:00
|
|
|
B(LdaTheHole),
|
|
|
|
|
B(SetPendingMessage),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Ldar), R(2),
|
|
|
|
|
B(PushContext), R(3),
|
Reland x3 "[runtime] Remove extension slots from context objects"
Original change's description:
> [runtime] Remove extension slots from context objects
>
> Context objects have an extension slot, which contains further
> additional data that depends on the type of the context.
>
> This CL removes the extension slot from contexts that don't need
> them, hence reducing memory.
>
> The following contexts will still have an extension slot: native,
> module, await, block and with contexts. See objects/contexts.h for
> what the slot is used for.
> The following contexts will not have an extension slot anymore (they
> were not used before): script, catch and builtin contexts.
> Eval and function contexts only have the extension slot if they
> contain a sloppy eval.
>
> Bug: v8:9744
> Change-Id: I8ca56c22fa02437bbac392ea72174ebfca80e030
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863191
> Commit-Queue: Victor Gomes <victorgomes@google.com>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Auto-Submit: Victor Gomes <victorgomes@google.com>
> Cr-Commit-Position: refs/heads/master@{#64372}
TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org
Bug: v8:9744
Change-Id: I8700ed2fa62c89e86c39bb16ac3167f38ea8d63f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873695
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64477}
2019-10-22 12:59:24 +00:00
|
|
|
B(LdaImmutableCurrentContextSlot), U8(2),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star5),
|
2018-05-30 14:21:39 +00:00
|
|
|
B(LdaFalse),
|
2021-02-17 14:36:58 +00:00
|
|
|
B(Star6),
|
2019-01-14 14:15:52 +00:00
|
|
|
B(Mov), R(0), R(4),
|
|
|
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionReject), R(4), U8(3),
|
2021-04-30 04:54:17 +00:00
|
|
|
B(Return),
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
constant pool: [
|
2018-07-05 18:34:09 +00:00
|
|
|
OBJECT_BOILERPLATE_DESCRIPTION_TYPE,
|
|
|
|
|
ARRAY_BOILERPLATE_DESCRIPTION_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["a"],
|
|
|
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["return"],
|
2017-05-16 11:36:04 +00:00
|
|
|
Smi [6],
|
2019-01-02 16:12:54 +00:00
|
|
|
Smi [9],
|
2018-02-16 12:36:47 +00:00
|
|
|
SCOPE_INFO_TYPE,
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
handlers: [
|
2021-02-17 14:36:58 +00:00
|
|
|
[14, 180, 180],
|
|
|
|
|
[46, 92, 98],
|
|
|
|
|
[111, 130, 132],
|
2017-02-24 17:48:49 +00:00
|
|
|
]
|
|
|
|
|
|
