2017-12-07 13:02:05 +00:00
|
|
|
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file.
|
|
|
|
|
2019-01-29 19:12:21 +00:00
|
|
|
#include <unordered_map>
|
|
|
|
#include <vector>
|
|
|
|
|
2017-12-07 13:02:05 +00:00
|
|
|
#include "include/v8.h"
|
2019-05-17 12:13:44 +00:00
|
|
|
#include "src/api/api-inl.h"
|
2019-02-14 21:10:30 +00:00
|
|
|
#include "src/heap/heap-inl.h"
|
2017-12-07 13:02:05 +00:00
|
|
|
#include "src/objects/module.h"
|
2019-05-23 08:51:46 +00:00
|
|
|
#include "src/objects/objects-inl.h"
|
2017-12-07 13:02:05 +00:00
|
|
|
#include "src/objects/script.h"
|
|
|
|
#include "src/objects/shared-function-info.h"
|
|
|
|
#include "test/cctest/cctest.h"
|
2019-01-29 19:12:21 +00:00
|
|
|
#include "test/cctest/heap/heap-utils.h"
|
2017-12-07 13:02:05 +00:00
|
|
|
|
|
|
|
namespace v8 {
|
2019-08-20 15:08:13 +00:00
|
|
|
|
|
|
|
// See test below: TracedGlobalNoDestructor.
|
|
|
|
template <>
|
|
|
|
struct TracedGlobalTrait<v8::TracedGlobal<v8::Value>> {
|
|
|
|
static constexpr bool kRequiresExplicitDestruction = false;
|
|
|
|
};
|
|
|
|
|
2017-12-07 13:02:05 +00:00
|
|
|
namespace internal {
|
|
|
|
namespace heap {
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
v8::Local<v8::Object> ConstructTraceableJSApiObject(
|
|
|
|
v8::Local<v8::Context> context, void* first_field, void* second_field) {
|
|
|
|
v8::EscapableHandleScope scope(context->GetIsolate());
|
|
|
|
v8::Local<v8::FunctionTemplate> function_t =
|
|
|
|
v8::FunctionTemplate::New(context->GetIsolate());
|
|
|
|
v8::Local<v8::ObjectTemplate> instance_t = function_t->InstanceTemplate();
|
|
|
|
instance_t->SetInternalFieldCount(2);
|
|
|
|
v8::Local<v8::Function> function =
|
|
|
|
function_t->GetFunction(context).ToLocalChecked();
|
|
|
|
v8::Local<v8::Object> instance =
|
|
|
|
function->NewInstance(context).ToLocalChecked();
|
|
|
|
instance->SetAlignedPointerInInternalField(0, first_field);
|
|
|
|
instance->SetAlignedPointerInInternalField(1, second_field);
|
|
|
|
CHECK(!instance.IsEmpty());
|
|
|
|
i::Handle<i::JSReceiver> js_obj = v8::Utils::OpenHandle(*instance);
|
2019-05-23 07:47:44 +00:00
|
|
|
CHECK_EQ(i::JS_API_OBJECT_TYPE, js_obj->map().instance_type());
|
2017-12-07 13:02:05 +00:00
|
|
|
return scope.Escape(instance);
|
|
|
|
}
|
|
|
|
|
2019-03-11 09:00:31 +00:00
|
|
|
enum class TracePrologueBehavior { kNoop, kCallV8WriteBarrier };
|
|
|
|
|
2017-12-07 13:02:05 +00:00
|
|
|
class TestEmbedderHeapTracer final : public v8::EmbedderHeapTracer {
|
|
|
|
public:
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer() = default;
|
2019-03-11 09:00:31 +00:00
|
|
|
TestEmbedderHeapTracer(TracePrologueBehavior prologue_behavior,
|
|
|
|
v8::Global<v8::Array> array)
|
|
|
|
: prologue_behavior_(prologue_behavior), array_(std::move(array)) {}
|
2017-12-07 13:02:05 +00:00
|
|
|
|
|
|
|
void RegisterV8References(
|
|
|
|
const std::vector<std::pair<void*, void*>>& embedder_fields) final {
|
|
|
|
registered_from_v8_.insert(registered_from_v8_.end(),
|
|
|
|
embedder_fields.begin(), embedder_fields.end());
|
|
|
|
}
|
|
|
|
|
2019-01-30 10:38:18 +00:00
|
|
|
void AddReferenceForTracing(v8::TracedGlobal<v8::Object>* global) {
|
|
|
|
to_register_with_v8_.push_back(global);
|
2017-12-07 13:02:05 +00:00
|
|
|
}
|
|
|
|
|
2018-10-12 10:45:09 +00:00
|
|
|
bool AdvanceTracing(double deadline_in_ms) final {
|
2019-01-30 10:38:18 +00:00
|
|
|
for (auto global : to_register_with_v8_) {
|
|
|
|
RegisterEmbedderReference(global->As<v8::Value>());
|
2017-12-07 13:02:05 +00:00
|
|
|
}
|
|
|
|
to_register_with_v8_.clear();
|
2018-10-12 10:45:09 +00:00
|
|
|
return true;
|
2017-12-07 13:02:05 +00:00
|
|
|
}
|
|
|
|
|
2018-10-12 10:45:09 +00:00
|
|
|
bool IsTracingDone() final { return to_register_with_v8_.empty(); }
|
|
|
|
|
2019-04-29 16:01:01 +00:00
|
|
|
void TracePrologue(EmbedderHeapTracer::TraceFlags) final {
|
2019-03-11 09:00:31 +00:00
|
|
|
if (prologue_behavior_ == TracePrologueBehavior::kCallV8WriteBarrier) {
|
|
|
|
auto local = array_.Get(isolate());
|
|
|
|
local->Set(local->CreationContext(), 0, v8::Object::New(isolate()))
|
|
|
|
.Check();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-12-07 13:02:05 +00:00
|
|
|
void TraceEpilogue() final {}
|
2018-08-21 17:14:19 +00:00
|
|
|
void EnterFinalPause(EmbedderStackState) final {}
|
2017-12-07 13:02:05 +00:00
|
|
|
|
|
|
|
bool IsRegisteredFromV8(void* first_field) const {
|
|
|
|
for (auto pair : registered_from_v8_) {
|
|
|
|
if (pair.first == first_field) return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2019-01-29 19:12:21 +00:00
|
|
|
void ConsiderTracedGlobalAsRoot(bool value) {
|
|
|
|
consider_traced_global_as_root_ = value;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool IsRootForNonTracingGC(const v8::TracedGlobal<v8::Value>& handle) final {
|
|
|
|
return consider_traced_global_as_root_;
|
|
|
|
}
|
|
|
|
|
2017-12-07 13:02:05 +00:00
|
|
|
private:
|
|
|
|
std::vector<std::pair<void*, void*>> registered_from_v8_;
|
2019-01-30 10:38:18 +00:00
|
|
|
std::vector<v8::TracedGlobal<v8::Object>*> to_register_with_v8_;
|
2019-01-29 19:12:21 +00:00
|
|
|
bool consider_traced_global_as_root_ = true;
|
2019-03-11 09:00:31 +00:00
|
|
|
TracePrologueBehavior prologue_behavior_ = TracePrologueBehavior::kNoop;
|
|
|
|
v8::Global<v8::Array> array_;
|
2017-12-07 13:02:05 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
TEST(V8RegisteringEmbedderReference) {
|
|
|
|
// Tests that wrappers are properly registered with the embedder heap
|
|
|
|
// tracer.
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2017-12-07 13:02:05 +00:00
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate);
|
|
|
|
v8::Context::Scope context_scope(context);
|
|
|
|
|
|
|
|
void* first_field = reinterpret_cast<void*>(0x2);
|
|
|
|
v8::Local<v8::Object> api_object =
|
|
|
|
ConstructTraceableJSApiObject(context, first_field, nullptr);
|
|
|
|
CHECK(!api_object.IsEmpty());
|
|
|
|
CcTest::CollectGarbage(i::OLD_SPACE);
|
|
|
|
CHECK(tracer.IsRegisteredFromV8(first_field));
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(EmbedderRegisteringV8Reference) {
|
|
|
|
// Tests that references that are registered by the embedder heap tracer are
|
|
|
|
// considered live by V8.
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2017-12-07 13:02:05 +00:00
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate);
|
|
|
|
v8::Context::Scope context_scope(context);
|
|
|
|
|
2019-01-30 10:38:18 +00:00
|
|
|
v8::TracedGlobal<v8::Object> g;
|
2017-12-07 13:02:05 +00:00
|
|
|
{
|
|
|
|
v8::HandleScope inner_scope(isolate);
|
|
|
|
v8::Local<v8::Object> o =
|
|
|
|
v8::Local<v8::Object>::New(isolate, v8::Object::New(isolate));
|
|
|
|
g.Reset(isolate, o);
|
|
|
|
}
|
|
|
|
tracer.AddReferenceForTracing(&g);
|
|
|
|
CcTest::CollectGarbage(i::OLD_SPACE);
|
|
|
|
CHECK(!g.IsEmpty());
|
|
|
|
}
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
void ResurrectingFinalizer(
|
|
|
|
const v8::WeakCallbackInfo<v8::Global<v8::Object>>& data) {
|
|
|
|
data.GetParameter()->ClearWeak();
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
TEST(TracingInRevivedSubgraph) {
|
|
|
|
// Tests that wrappers are traced when they are contained with in a subgraph
|
|
|
|
// that is revived by a finalizer.
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2017-12-07 13:02:05 +00:00
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate);
|
|
|
|
v8::Context::Scope context_scope(context);
|
|
|
|
|
|
|
|
v8::Global<v8::Object> g;
|
|
|
|
void* first_field = reinterpret_cast<void*>(0x4);
|
|
|
|
{
|
|
|
|
v8::HandleScope inner_scope(isolate);
|
|
|
|
v8::Local<v8::Object> api_object =
|
|
|
|
ConstructTraceableJSApiObject(context, first_field, nullptr);
|
|
|
|
CHECK(!api_object.IsEmpty());
|
|
|
|
v8::Local<v8::Object> o =
|
|
|
|
v8::Local<v8::Object>::New(isolate, v8::Object::New(isolate));
|
|
|
|
o->Set(context, v8_str("link"), api_object).FromJust();
|
|
|
|
g.Reset(isolate, o);
|
|
|
|
g.SetWeak(&g, ResurrectingFinalizer, v8::WeakCallbackType::kFinalizer);
|
|
|
|
}
|
|
|
|
CcTest::CollectGarbage(i::OLD_SPACE);
|
|
|
|
CHECK(tracer.IsRegisteredFromV8(first_field));
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracingInEphemerons) {
|
|
|
|
// Tests that wrappers that are part of ephemerons are traced.
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2017-12-07 13:02:05 +00:00
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate);
|
|
|
|
v8::Context::Scope context_scope(context);
|
|
|
|
|
|
|
|
v8::Local<v8::Object> key =
|
|
|
|
v8::Local<v8::Object>::New(isolate, v8::Object::New(isolate));
|
|
|
|
void* first_field = reinterpret_cast<void*>(0x8);
|
|
|
|
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
|
|
|
|
Handle<JSWeakMap> weak_map = i_isolate->factory()->NewJSWeakMap();
|
|
|
|
{
|
|
|
|
v8::HandleScope inner_scope(isolate);
|
|
|
|
v8::Local<v8::Object> api_object =
|
|
|
|
ConstructTraceableJSApiObject(context, first_field, nullptr);
|
|
|
|
CHECK(!api_object.IsEmpty());
|
|
|
|
Handle<JSObject> js_key =
|
2018-06-11 09:53:20 +00:00
|
|
|
handle(JSObject::cast(*v8::Utils::OpenHandle(*key)), i_isolate);
|
2017-12-07 13:02:05 +00:00
|
|
|
Handle<JSReceiver> js_api_object = v8::Utils::OpenHandle(*api_object);
|
2019-05-23 07:47:44 +00:00
|
|
|
int32_t hash = js_key->GetOrCreateHash(i_isolate).value();
|
2017-12-07 13:02:05 +00:00
|
|
|
JSWeakCollection::Set(weak_map, js_key, js_api_object, hash);
|
|
|
|
}
|
|
|
|
CcTest::CollectGarbage(i::OLD_SPACE);
|
|
|
|
CHECK(tracer.IsRegisteredFromV8(first_field));
|
|
|
|
}
|
|
|
|
|
2018-07-11 11:23:10 +00:00
|
|
|
TEST(FinalizeTracingIsNoopWhenNotMarking) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
Isolate* i_isolate = CcTest::i_isolate();
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2018-07-11 11:23:10 +00:00
|
|
|
|
|
|
|
// Finalize a potentially running garbage collection.
|
|
|
|
i_isolate->heap()->CollectGarbage(OLD_SPACE,
|
|
|
|
GarbageCollectionReason::kTesting);
|
|
|
|
CHECK(i_isolate->heap()->incremental_marking()->IsStopped());
|
|
|
|
|
|
|
|
int gc_counter = i_isolate->heap()->gc_count();
|
|
|
|
tracer.FinalizeTracing();
|
|
|
|
CHECK(i_isolate->heap()->incremental_marking()->IsStopped());
|
|
|
|
CHECK_EQ(gc_counter, i_isolate->heap()->gc_count());
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(FinalizeTracingWhenMarking) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
Isolate* i_isolate = CcTest::i_isolate();
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2018-07-11 11:23:10 +00:00
|
|
|
|
|
|
|
// Finalize a potentially running garbage collection.
|
|
|
|
i_isolate->heap()->CollectGarbage(OLD_SPACE,
|
|
|
|
GarbageCollectionReason::kTesting);
|
|
|
|
if (i_isolate->heap()->mark_compact_collector()->sweeping_in_progress()) {
|
|
|
|
i_isolate->heap()->mark_compact_collector()->EnsureSweepingCompleted();
|
|
|
|
}
|
|
|
|
CHECK(i_isolate->heap()->incremental_marking()->IsStopped());
|
|
|
|
|
|
|
|
i::IncrementalMarking* marking = i_isolate->heap()->incremental_marking();
|
|
|
|
marking->Start(i::GarbageCollectionReason::kTesting);
|
|
|
|
// Sweeping is not runing so we should immediately start marking.
|
|
|
|
CHECK(marking->IsMarking());
|
|
|
|
tracer.FinalizeTracing();
|
|
|
|
CHECK(marking->IsStopped());
|
|
|
|
}
|
|
|
|
|
2018-08-21 17:14:19 +00:00
|
|
|
TEST(GarbageCollectionForTesting) {
|
|
|
|
ManualGCScope manual_gc;
|
2018-08-24 07:50:54 +00:00
|
|
|
i::FLAG_expose_gc = true;
|
2018-08-21 17:14:19 +00:00
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
Isolate* i_isolate = CcTest::i_isolate();
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2018-08-21 17:14:19 +00:00
|
|
|
|
|
|
|
int saved_gc_counter = i_isolate->heap()->gc_count();
|
|
|
|
tracer.GarbageCollectionForTesting(EmbedderHeapTracer::kUnknown);
|
|
|
|
CHECK_GT(i_isolate->heap()->gc_count(), saved_gc_counter);
|
|
|
|
}
|
|
|
|
|
2019-01-29 19:12:21 +00:00
|
|
|
namespace {
|
|
|
|
|
|
|
|
void ConstructJSObject(v8::Isolate* isolate, v8::Local<v8::Context> context,
|
|
|
|
v8::TracedGlobal<v8::Object>* global) {
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
v8::Local<v8::Object> object(v8::Object::New(isolate));
|
|
|
|
CHECK(!object.IsEmpty());
|
|
|
|
*global = v8::TracedGlobal<v8::Object>(isolate, object);
|
|
|
|
CHECK(!global->IsEmpty());
|
|
|
|
}
|
|
|
|
|
|
|
|
void ConstructJSApiObject(v8::Isolate* isolate, v8::Local<v8::Context> context,
|
|
|
|
v8::TracedGlobal<v8::Object>* global) {
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
v8::Local<v8::Object> object(
|
|
|
|
ConstructTraceableJSApiObject(context, nullptr, nullptr));
|
|
|
|
CHECK(!object.IsEmpty());
|
|
|
|
*global = v8::TracedGlobal<v8::Object>(isolate, object);
|
|
|
|
CHECK(!global->IsEmpty());
|
|
|
|
}
|
|
|
|
|
|
|
|
enum class SurvivalMode { kSurvives, kDies };
|
|
|
|
|
|
|
|
template <typename ModifierFunction, typename ConstructTracedGlobalFunction>
|
|
|
|
void TracedGlobalTest(v8::Isolate* isolate,
|
|
|
|
ConstructTracedGlobalFunction construct_function,
|
|
|
|
ModifierFunction modifier_function, void (*gc_function)(),
|
|
|
|
SurvivalMode survives) {
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate);
|
|
|
|
v8::Context::Scope context_scope(context);
|
|
|
|
|
|
|
|
v8::TracedGlobal<v8::Object> global;
|
|
|
|
construct_function(isolate, context, &global);
|
2019-02-11 15:07:56 +00:00
|
|
|
CHECK(InYoungGeneration(isolate, global));
|
2019-01-29 19:12:21 +00:00
|
|
|
modifier_function(global);
|
|
|
|
gc_function();
|
|
|
|
CHECK_IMPLIES(survives == SurvivalMode::kSurvives, !global.IsEmpty());
|
|
|
|
CHECK_IMPLIES(survives == SurvivalMode::kDies, global.IsEmpty());
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
TEST(TracedGlobalReset) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
|
|
|
|
v8::TracedGlobal<v8::Object> traced;
|
|
|
|
ConstructJSObject(isolate, isolate->GetCurrentContext(), &traced);
|
|
|
|
CHECK(!traced.IsEmpty());
|
|
|
|
traced.Reset();
|
|
|
|
CHECK(traced.IsEmpty());
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalInStdVector) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
|
|
|
|
std::vector<v8::TracedGlobal<v8::Object>> vec;
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
vec.emplace_back(isolate, v8::Object::New(isolate));
|
|
|
|
}
|
|
|
|
CHECK(!vec[0].IsEmpty());
|
|
|
|
InvokeMarkSweep();
|
|
|
|
CHECK(vec[0].IsEmpty());
|
|
|
|
}
|
|
|
|
|
2019-08-28 14:56:24 +00:00
|
|
|
TEST(TracedGlobalCopyWithDestructor) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
i::GlobalHandles* global_handles = CcTest::i_isolate()->global_handles();
|
|
|
|
|
|
|
|
static_assert(TracedGlobalTrait<
|
|
|
|
v8::TracedGlobal<v8::Object>>::kRequiresExplicitDestruction,
|
|
|
|
"destructor expected");
|
|
|
|
|
|
|
|
const size_t initial_count = global_handles->handles_count();
|
|
|
|
v8::TracedGlobal<v8::Object> global1;
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
global1.Reset(isolate, v8::Object::New(isolate));
|
|
|
|
}
|
|
|
|
v8::TracedGlobal<v8::Object> global2(global1);
|
|
|
|
v8::TracedGlobal<v8::Object> global3;
|
|
|
|
global3 = global2;
|
|
|
|
CHECK_EQ(initial_count + 3, global_handles->handles_count());
|
|
|
|
CHECK(!global1.IsEmpty());
|
|
|
|
CHECK_EQ(global1, global2);
|
|
|
|
CHECK_EQ(global2, global3);
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
auto tmp = v8::Local<v8::Object>::New(isolate, global3);
|
|
|
|
CHECK(!tmp.IsEmpty());
|
|
|
|
InvokeMarkSweep();
|
|
|
|
}
|
|
|
|
CHECK_EQ(initial_count + 3, global_handles->handles_count());
|
|
|
|
CHECK(!global1.IsEmpty());
|
|
|
|
CHECK_EQ(global1, global2);
|
|
|
|
CHECK_EQ(global2, global3);
|
|
|
|
InvokeMarkSweep();
|
|
|
|
CHECK_EQ(initial_count, global_handles->handles_count());
|
|
|
|
CHECK(global1.IsEmpty());
|
|
|
|
CHECK_EQ(global1, global2);
|
|
|
|
CHECK_EQ(global2, global3);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalCopyNoDestructor) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
i::GlobalHandles* global_handles = CcTest::i_isolate()->global_handles();
|
|
|
|
|
|
|
|
static_assert(!TracedGlobalTrait<
|
|
|
|
v8::TracedGlobal<v8::Value>>::kRequiresExplicitDestruction,
|
|
|
|
"no destructor expected");
|
|
|
|
|
|
|
|
const size_t initial_count = global_handles->handles_count();
|
|
|
|
v8::TracedGlobal<v8::Value> global1;
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
global1.Reset(isolate, v8::Object::New(isolate));
|
|
|
|
}
|
|
|
|
v8::TracedGlobal<v8::Value> global2(global1);
|
|
|
|
v8::TracedGlobal<v8::Value> global3;
|
|
|
|
global3 = global2;
|
|
|
|
CHECK_EQ(initial_count + 3, global_handles->handles_count());
|
|
|
|
CHECK(!global1.IsEmpty());
|
|
|
|
CHECK_EQ(global1, global2);
|
|
|
|
CHECK_EQ(global2, global3);
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
auto tmp = v8::Local<v8::Value>::New(isolate, global3);
|
|
|
|
CHECK(!tmp.IsEmpty());
|
|
|
|
InvokeMarkSweep();
|
|
|
|
}
|
|
|
|
CHECK_EQ(initial_count + 3, global_handles->handles_count());
|
|
|
|
CHECK(!global1.IsEmpty());
|
|
|
|
CHECK_EQ(global1, global2);
|
|
|
|
CHECK_EQ(global2, global3);
|
|
|
|
InvokeMarkSweep();
|
|
|
|
CHECK_EQ(initial_count, global_handles->handles_count());
|
|
|
|
}
|
|
|
|
|
2019-01-29 19:12:21 +00:00
|
|
|
TEST(TracedGlobalInStdUnorderedMap) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
|
|
|
|
std::unordered_map<int, v8::TracedGlobal<v8::Object>> map;
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
map.emplace(std::piecewise_construct, std::forward_as_tuple(1),
|
|
|
|
std::forward_as_tuple(isolate, v8::Object::New(isolate)));
|
|
|
|
}
|
|
|
|
CHECK(!map[1].IsEmpty());
|
|
|
|
InvokeMarkSweep();
|
|
|
|
CHECK(map[1].IsEmpty());
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalToUnmodifiedJSObjectDiesOnMarkSweep) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
TracedGlobalTest(
|
|
|
|
CcTest::isolate(), ConstructJSObject,
|
|
|
|
[](const TracedGlobal<v8::Object>& global) {}, InvokeMarkSweep,
|
|
|
|
SurvivalMode::kDies);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalToUnmodifiedJSObjectSurvivesMarkSweepWhenHeldAliveOtherwise) {
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::Global<v8::Object> strong_global;
|
|
|
|
TracedGlobalTest(
|
|
|
|
CcTest::isolate(), ConstructJSObject,
|
|
|
|
[isolate, &strong_global](const TracedGlobal<v8::Object>& global) {
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
strong_global = v8::Global<v8::Object>(isolate, global.Get(isolate));
|
|
|
|
},
|
|
|
|
InvokeMarkSweep, SurvivalMode::kSurvives);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalToUnmodifiedJSObjectSurvivesScavenge) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
TracedGlobalTest(
|
|
|
|
CcTest::isolate(), ConstructJSObject,
|
|
|
|
[](const TracedGlobal<v8::Object>& global) {}, InvokeScavenge,
|
|
|
|
SurvivalMode::kSurvives);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalToUnmodifiedJSObjectSurvivesScavengeWhenExcludedFromRoots) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2019-01-29 19:12:21 +00:00
|
|
|
tracer.ConsiderTracedGlobalAsRoot(false);
|
|
|
|
TracedGlobalTest(
|
|
|
|
CcTest::isolate(), ConstructJSObject,
|
|
|
|
[](const TracedGlobal<v8::Object>& global) {}, InvokeScavenge,
|
|
|
|
SurvivalMode::kSurvives);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalToUnmodifiedJSApiObjectSurvivesScavengePerDefault) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2019-01-29 19:12:21 +00:00
|
|
|
tracer.ConsiderTracedGlobalAsRoot(true);
|
|
|
|
TracedGlobalTest(
|
|
|
|
CcTest::isolate(), ConstructJSApiObject,
|
|
|
|
[](const TracedGlobal<v8::Object>& global) {}, InvokeScavenge,
|
|
|
|
SurvivalMode::kSurvives);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalToUnmodifiedJSApiObjectDiesOnScavengeWhenExcludedFromRoots) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2019-01-29 19:12:21 +00:00
|
|
|
tracer.ConsiderTracedGlobalAsRoot(false);
|
|
|
|
TracedGlobalTest(
|
|
|
|
CcTest::isolate(), ConstructJSApiObject,
|
|
|
|
[](const TracedGlobal<v8::Object>& global) {}, InvokeScavenge,
|
|
|
|
SurvivalMode::kDies);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalWrapperClassId) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2019-01-29 19:12:21 +00:00
|
|
|
|
|
|
|
v8::TracedGlobal<v8::Object> traced;
|
|
|
|
ConstructJSObject(isolate, isolate->GetCurrentContext(), &traced);
|
|
|
|
CHECK_EQ(0, traced.WrapperClassId());
|
|
|
|
traced.SetWrapperClassId(17);
|
|
|
|
CHECK_EQ(17, traced.WrapperClassId());
|
|
|
|
}
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
class TracedGlobalVisitor final
|
|
|
|
: public v8::EmbedderHeapTracer::TracedGlobalHandleVisitor {
|
|
|
|
public:
|
|
|
|
~TracedGlobalVisitor() override = default;
|
|
|
|
void VisitTracedGlobalHandle(const TracedGlobal<Value>& value) final {
|
|
|
|
if (value.WrapperClassId() == 57) {
|
|
|
|
count_++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
size_t count() const { return count_; }
|
|
|
|
|
|
|
|
private:
|
|
|
|
size_t count_ = 0;
|
|
|
|
};
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
TEST(TracedGlobalIteration) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
2019-01-30 10:38:18 +00:00
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2019-01-29 19:12:21 +00:00
|
|
|
|
|
|
|
v8::TracedGlobal<v8::Object> traced;
|
|
|
|
ConstructJSObject(isolate, isolate->GetCurrentContext(), &traced);
|
|
|
|
CHECK(!traced.IsEmpty());
|
|
|
|
traced.SetWrapperClassId(57);
|
|
|
|
TracedGlobalVisitor visitor;
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
tracer.IterateTracedGlobalHandles(&visitor);
|
|
|
|
}
|
|
|
|
CHECK_EQ(1, visitor.count());
|
|
|
|
}
|
|
|
|
|
2019-02-04 19:26:44 +00:00
|
|
|
namespace {
|
|
|
|
|
|
|
|
void FinalizationCallback(const WeakCallbackInfo<void>& data) {
|
|
|
|
v8::TracedGlobal<v8::Object>* traced =
|
|
|
|
reinterpret_cast<v8::TracedGlobal<v8::Object>*>(data.GetParameter());
|
|
|
|
CHECK_EQ(reinterpret_cast<void*>(0x4), data.GetInternalField(0));
|
|
|
|
CHECK_EQ(reinterpret_cast<void*>(0x8), data.GetInternalField(1));
|
|
|
|
traced->Reset();
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
TEST(TracedGlobalSetFinalizationCallbackScavenge) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
TestEmbedderHeapTracer tracer;
|
|
|
|
tracer.ConsiderTracedGlobalAsRoot(false);
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2019-02-04 19:26:44 +00:00
|
|
|
|
|
|
|
v8::TracedGlobal<v8::Object> traced;
|
|
|
|
ConstructJSApiObject(isolate, isolate->GetCurrentContext(), &traced);
|
|
|
|
CHECK(!traced.IsEmpty());
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
auto local = traced.Get(isolate);
|
|
|
|
local->SetAlignedPointerInInternalField(0, reinterpret_cast<void*>(0x4));
|
|
|
|
local->SetAlignedPointerInInternalField(1, reinterpret_cast<void*>(0x8));
|
|
|
|
}
|
|
|
|
traced.SetFinalizationCallback(&traced, FinalizationCallback);
|
|
|
|
heap::InvokeScavenge();
|
|
|
|
CHECK(traced.IsEmpty());
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalSetFinalizationCallbackMarkSweep) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
TestEmbedderHeapTracer tracer;
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2019-02-04 19:26:44 +00:00
|
|
|
|
|
|
|
v8::TracedGlobal<v8::Object> traced;
|
|
|
|
ConstructJSApiObject(isolate, isolate->GetCurrentContext(), &traced);
|
|
|
|
CHECK(!traced.IsEmpty());
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
auto local = traced.Get(isolate);
|
|
|
|
local->SetAlignedPointerInInternalField(0, reinterpret_cast<void*>(0x4));
|
|
|
|
local->SetAlignedPointerInInternalField(1, reinterpret_cast<void*>(0x8));
|
|
|
|
}
|
|
|
|
traced.SetFinalizationCallback(&traced, FinalizationCallback);
|
|
|
|
heap::InvokeMarkSweep();
|
|
|
|
CHECK(traced.IsEmpty());
|
|
|
|
}
|
|
|
|
|
2019-03-11 09:00:31 +00:00
|
|
|
TEST(TracePrologueCallingIntoV8WriteBarrier) {
|
|
|
|
// Regression test: https://crbug.com/940003
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
v8::Global<v8::Array> global;
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
auto local = v8::Array::New(isolate, 10);
|
|
|
|
global.Reset(isolate, local);
|
|
|
|
}
|
|
|
|
TestEmbedderHeapTracer tracer(TracePrologueBehavior::kCallV8WriteBarrier,
|
|
|
|
std::move(global));
|
2019-04-23 15:04:17 +00:00
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2019-03-11 09:00:31 +00:00
|
|
|
SimulateIncrementalMarking(CcTest::i_isolate()->heap());
|
2019-09-02 16:10:46 +00:00
|
|
|
// Finish GC to avoid removing the tracer while GC is running which may end up
|
|
|
|
// in an infinite loop because of unprocessed objects.
|
|
|
|
heap::InvokeMarkSweep();
|
2019-03-11 09:00:31 +00:00
|
|
|
}
|
|
|
|
|
2019-08-20 15:08:13 +00:00
|
|
|
TEST(TracedGlobalWithDestructor) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
TestEmbedderHeapTracer tracer;
|
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2019-08-21 08:57:54 +00:00
|
|
|
i::GlobalHandles* global_handles = CcTest::i_isolate()->global_handles();
|
2019-08-20 15:08:13 +00:00
|
|
|
|
2019-08-21 08:57:54 +00:00
|
|
|
const size_t initial_count = global_handles->handles_count();
|
|
|
|
auto* traced = new v8::TracedGlobal<v8::Object>();
|
2019-08-20 15:08:13 +00:00
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
v8::Local<v8::Object> object(ConstructTraceableJSApiObject(
|
2019-08-21 08:57:54 +00:00
|
|
|
isolate->GetCurrentContext(), nullptr, nullptr));
|
2019-08-20 15:08:13 +00:00
|
|
|
CHECK(traced->IsEmpty());
|
|
|
|
*traced = v8::TracedGlobal<v8::Object>(isolate, object);
|
|
|
|
CHECK(!traced->IsEmpty());
|
2019-08-21 08:57:54 +00:00
|
|
|
CHECK_EQ(initial_count + 1, global_handles->handles_count());
|
2019-08-20 15:08:13 +00:00
|
|
|
}
|
2019-08-21 08:57:54 +00:00
|
|
|
static_assert(TracedGlobalTrait<
|
|
|
|
v8::TracedGlobal<v8::Object>>::kRequiresExplicitDestruction,
|
|
|
|
"destructor expected");
|
|
|
|
delete traced;
|
|
|
|
CHECK_EQ(initial_count, global_handles->handles_count());
|
|
|
|
// GC should not need to clear the handle.
|
2019-08-20 15:08:13 +00:00
|
|
|
heap::InvokeMarkSweep();
|
2019-08-21 08:57:54 +00:00
|
|
|
CHECK_EQ(initial_count, global_handles->handles_count());
|
2019-08-20 15:08:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalNoDestructor) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
TestEmbedderHeapTracer tracer;
|
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
2019-08-21 08:57:54 +00:00
|
|
|
i::GlobalHandles* global_handles = CcTest::i_isolate()->global_handles();
|
2019-08-20 15:08:13 +00:00
|
|
|
|
2019-08-21 08:57:54 +00:00
|
|
|
const size_t initial_count = global_handles->handles_count();
|
2019-08-20 15:08:13 +00:00
|
|
|
char* memory = new char[sizeof(v8::TracedGlobal<v8::Value>)];
|
|
|
|
auto* traced = new (memory) v8::TracedGlobal<v8::Value>();
|
|
|
|
{
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
v8::Local<v8::Value> object(ConstructTraceableJSApiObject(
|
2019-08-21 08:57:54 +00:00
|
|
|
isolate->GetCurrentContext(), nullptr, nullptr));
|
2019-08-20 15:08:13 +00:00
|
|
|
CHECK(traced->IsEmpty());
|
|
|
|
*traced = v8::TracedGlobal<v8::Value>(isolate, object);
|
|
|
|
CHECK(!traced->IsEmpty());
|
2019-08-21 08:57:54 +00:00
|
|
|
CHECK_EQ(initial_count + 1, global_handles->handles_count());
|
2019-08-20 15:08:13 +00:00
|
|
|
}
|
2019-08-21 08:57:54 +00:00
|
|
|
static_assert(!TracedGlobalTrait<
|
|
|
|
v8::TracedGlobal<v8::Value>>::kRequiresExplicitDestruction,
|
|
|
|
"no destructor expected");
|
2019-08-20 15:08:13 +00:00
|
|
|
traced->~TracedGlobal<v8::Value>();
|
2019-08-21 08:57:54 +00:00
|
|
|
CHECK_EQ(initial_count + 1, global_handles->handles_count());
|
|
|
|
// GC should clear the handle.
|
2019-08-20 15:08:13 +00:00
|
|
|
heap::InvokeMarkSweep();
|
2019-08-21 08:57:54 +00:00
|
|
|
CHECK_EQ(initial_count, global_handles->handles_count());
|
2019-08-20 15:08:13 +00:00
|
|
|
delete[] memory;
|
|
|
|
}
|
|
|
|
|
2019-08-23 09:28:14 +00:00
|
|
|
namespace {
|
|
|
|
|
|
|
|
class EmptyEmbedderHeapTracer : public v8::EmbedderHeapTracer {
|
|
|
|
public:
|
|
|
|
void RegisterV8References(
|
|
|
|
const std::vector<std::pair<void*, void*>>& embedder_fields) final {}
|
|
|
|
|
|
|
|
bool AdvanceTracing(double deadline_in_ms) final { return true; }
|
|
|
|
bool IsTracingDone() final { return true; }
|
|
|
|
void TracePrologue(EmbedderHeapTracer::TraceFlags) final {}
|
|
|
|
void TraceEpilogue() final {}
|
|
|
|
void EnterFinalPause(EmbedderStackState) final {}
|
|
|
|
};
|
|
|
|
|
|
|
|
// EmbedderHeapTracer that can optimize Scavenger handling when used with
|
|
|
|
// TraceGlobal handles that have destructors.
|
|
|
|
class EmbedderHeapTracerDestructorNonTracingClearing final
|
|
|
|
: public EmptyEmbedderHeapTracer {
|
|
|
|
public:
|
|
|
|
explicit EmbedderHeapTracerDestructorNonTracingClearing(
|
|
|
|
uint16_t class_id_to_optimize)
|
|
|
|
: class_id_to_optimize_(class_id_to_optimize) {}
|
|
|
|
|
|
|
|
bool IsRootForNonTracingGC(const v8::TracedGlobal<v8::Value>& handle) final {
|
|
|
|
return handle.WrapperClassId() != class_id_to_optimize_;
|
|
|
|
}
|
|
|
|
|
|
|
|
void ResetHandleInNonTracingGC(
|
|
|
|
const v8::TracedGlobal<v8::Value>& handle) final {
|
|
|
|
// Not called when used with handles that have destructors.
|
|
|
|
CHECK(false);
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
uint16_t class_id_to_optimize_;
|
|
|
|
};
|
|
|
|
|
|
|
|
// EmbedderHeapTracer that can optimize Scavenger handling when used with
|
|
|
|
// TraceGlobal handles without destructors.
|
|
|
|
class EmbedderHeapTracerNoDestructorNonTracingClearing final
|
|
|
|
: public EmptyEmbedderHeapTracer {
|
|
|
|
public:
|
|
|
|
explicit EmbedderHeapTracerNoDestructorNonTracingClearing(
|
|
|
|
uint16_t class_id_to_optimize)
|
|
|
|
: class_id_to_optimize_(class_id_to_optimize) {}
|
|
|
|
|
|
|
|
bool IsRootForNonTracingGC(const v8::TracedGlobal<v8::Value>& handle) final {
|
|
|
|
return handle.WrapperClassId() != class_id_to_optimize_;
|
|
|
|
}
|
|
|
|
|
|
|
|
void ResetHandleInNonTracingGC(
|
|
|
|
const v8::TracedGlobal<v8::Value>& handle) final {
|
|
|
|
if (handle.WrapperClassId() != class_id_to_optimize_) return;
|
|
|
|
|
|
|
|
// Convention (for test): Objects that are optimized have their first field
|
|
|
|
// set as a back pointer.
|
|
|
|
TracedGlobal<v8::Value>* original_handle =
|
|
|
|
reinterpret_cast<TracedGlobal<v8::Value>*>(
|
|
|
|
v8::Object::GetAlignedPointerFromInternalField(
|
|
|
|
handle.As<v8::Object>(), 0));
|
|
|
|
original_handle->Reset();
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
uint16_t class_id_to_optimize_;
|
|
|
|
};
|
|
|
|
|
|
|
|
template <typename T>
|
|
|
|
void SetupOptimizedAndNonOptimizedHandle(
|
|
|
|
v8::Isolate* isolate, uint16_t optimized_class_id,
|
|
|
|
v8::TracedGlobal<T>* optimized_handle,
|
|
|
|
v8::TracedGlobal<T>* non_optimized_handle) {
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
|
|
|
|
v8::Local<v8::Object> optimized_object(ConstructTraceableJSApiObject(
|
|
|
|
isolate->GetCurrentContext(), optimized_handle, nullptr));
|
|
|
|
CHECK(optimized_handle->IsEmpty());
|
|
|
|
*optimized_handle = v8::TracedGlobal<T>(isolate, optimized_object);
|
|
|
|
CHECK(!optimized_handle->IsEmpty());
|
|
|
|
optimized_handle->SetWrapperClassId(optimized_class_id);
|
|
|
|
|
|
|
|
v8::Local<v8::Object> non_optimized_object(ConstructTraceableJSApiObject(
|
|
|
|
isolate->GetCurrentContext(), nullptr, nullptr));
|
|
|
|
CHECK(non_optimized_handle->IsEmpty());
|
|
|
|
*non_optimized_handle = v8::TracedGlobal<T>(isolate, non_optimized_object);
|
|
|
|
CHECK(!non_optimized_handle->IsEmpty());
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
TEST(TracedGlobalDestructorReclaimedOnScavenge) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
constexpr uint16_t kClassIdToOptimize = 17;
|
|
|
|
EmbedderHeapTracerDestructorNonTracingClearing tracer(kClassIdToOptimize);
|
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
|
|
|
i::GlobalHandles* global_handles = CcTest::i_isolate()->global_handles();
|
|
|
|
|
|
|
|
static_assert(TracedGlobalTrait<
|
|
|
|
v8::TracedGlobal<v8::Object>>::kRequiresExplicitDestruction,
|
|
|
|
"destructor expected");
|
|
|
|
const size_t initial_count = global_handles->handles_count();
|
|
|
|
auto* optimized_handle = new v8::TracedGlobal<v8::Object>();
|
|
|
|
auto* non_optimized_handle = new v8::TracedGlobal<v8::Object>();
|
|
|
|
SetupOptimizedAndNonOptimizedHandle(isolate, kClassIdToOptimize,
|
|
|
|
optimized_handle, non_optimized_handle);
|
|
|
|
CHECK_EQ(initial_count + 2, global_handles->handles_count());
|
|
|
|
heap::InvokeScavenge();
|
|
|
|
CHECK_EQ(initial_count + 1, global_handles->handles_count());
|
|
|
|
CHECK(optimized_handle->IsEmpty());
|
|
|
|
delete optimized_handle;
|
|
|
|
CHECK(!non_optimized_handle->IsEmpty());
|
|
|
|
delete non_optimized_handle;
|
|
|
|
CHECK_EQ(initial_count, global_handles->handles_count());
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(TracedGlobalNoDestructorReclaimedOnScavenge) {
|
|
|
|
ManualGCScope manual_gc;
|
|
|
|
CcTest::InitializeVM();
|
|
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
constexpr uint16_t kClassIdToOptimize = 23;
|
|
|
|
EmbedderHeapTracerNoDestructorNonTracingClearing tracer(kClassIdToOptimize);
|
|
|
|
heap::TemporaryEmbedderHeapTracerScope tracer_scope(isolate, &tracer);
|
|
|
|
i::GlobalHandles* global_handles = CcTest::i_isolate()->global_handles();
|
|
|
|
|
|
|
|
static_assert(!TracedGlobalTrait<
|
|
|
|
v8::TracedGlobal<v8::Value>>::kRequiresExplicitDestruction,
|
|
|
|
"no destructor expected");
|
|
|
|
const size_t initial_count = global_handles->handles_count();
|
|
|
|
auto* optimized_handle = new v8::TracedGlobal<v8::Value>();
|
|
|
|
auto* non_optimized_handle = new v8::TracedGlobal<v8::Value>();
|
|
|
|
SetupOptimizedAndNonOptimizedHandle(isolate, kClassIdToOptimize,
|
|
|
|
optimized_handle, non_optimized_handle);
|
|
|
|
CHECK_EQ(initial_count + 2, global_handles->handles_count());
|
|
|
|
heap::InvokeScavenge();
|
|
|
|
CHECK_EQ(initial_count + 1, global_handles->handles_count());
|
|
|
|
CHECK(optimized_handle->IsEmpty());
|
|
|
|
delete optimized_handle;
|
|
|
|
CHECK(!non_optimized_handle->IsEmpty());
|
|
|
|
non_optimized_handle->Reset();
|
|
|
|
delete non_optimized_handle;
|
|
|
|
CHECK_EQ(initial_count, global_handles->handles_count());
|
|
|
|
}
|
|
|
|
|
2017-12-07 13:02:05 +00:00
|
|
|
} // namespace heap
|
|
|
|
} // namespace internal
|
|
|
|
} // namespace v8
|