AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
7bace1d41a
v8/test/inspector/debugger/wasm-script-code-offset-streaming-expected.txt

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

10 lines
617 B
Plaintext
Raw Normal View History

Reland "[wasm][inspector][test] Add more tests for code offsets" This is a reland of 4719dae1a4ab2067120cf0dbab89514adf662b73. The "V8 Linux64 TSAN - stress-incremental-marking" bot adds the --stress-incremental-marking flag for all variants, hence the SKIP in the status file was not triggered. We just explicitly disable the --stress-incremental-marking flag for the two new tests. This works for the "stress_incremental_marking" variant as well as the specific bot. Original change's description: > [wasm][inspector][test] Add more tests for code offsets > > The code offsets are sometimes wrong when compiled with streaming > compilation. Thus add more tests for synchronous, asynchronous, and > streaming compilation. The reported code offsets should all match. This > will be fixed in a follow-up CL. > > In order to make asynchronous WebAssembly compilation finish, the > inspector-test executable needs to pump the message loop before waiting > for new tasks to come in, just as other executables like d8. > This is added in this CL, but because of another bug this is skipped in > the stress-incremental-marking variant. Hence the new tests are also > skipped there. > > R=szuend@chromium.org > CC=ahaas@chromium.org > > Bug: chromium:1150303, v8:10748 > Change-Id: Ie1d63c8d6795e61627d838b7fa7b21e6728befc0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562382 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71483} Bug: chromium:1150303 Bug: v8:10748 Change-Id: I9adb9fc0250fab5c43dc85b695f4d338a9c7183c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565128 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71492}
2020-11-30 13:45:16 +00:00
Tests reported code offsets on wasm scripts
Wasm script parsed: ID 0, startColumn: 0, endColumn: 29, codeOffset: 0
Wasm script parsed: ID 1, startColumn: 0, endColumn: 29, codeOffset: 0
Wasm script parsed: ID 2, startColumn: 0, endColumn: 32, codeOffset: 31
Wasm script parsed: ID 3, startColumn: 0, endColumn: 32, codeOffset: 0
Wasm script parsed: ID 4, startColumn: 0, endColumn: 40, codeOffset: 36
Wasm script parsed: ID 5, startColumn: 0, endColumn: 40, codeOffset: 36
Wasm script parsed: ID 6, startColumn: 0, endColumn: 44, codeOffset: 36
[wasm] Pass correct code section start in streaming compilation The streaming decoder computed the code section start from the passed "offset". That offset is computed from the module offset *after* the number of functions has been read. Hence 1 is subtracted, with the comment: // The offset passed to {ProcessCodeSectionHeader} is an error offset and // not the start offset of a buffer. Therefore we need the -1 here. That subtraction of 1 worked when the number of functions was encoded in a 1-byte LEB, otherwise it was off. This CL fixes the immediate issue of passing the right code offset. The usage of the previously existing offset also seems wrong, and I will try to clean that up in a follow-up CL. R=ahaas@chromium.org CC=szuend@chromium.org Bug: chromium:1150303 Change-Id: I64bb2ececeb4749b7ba2096cd148ccb4079eca4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562383 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71503}
2020-11-27 16:07:29 +00:00
Wasm script parsed: ID 7, startColumn: 0, endColumn: 44, codeOffset: 36
Reference in New Issue Copy Permalink