AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
a4e162f761
v8/test/inspector/debugger/wasm-stepping-byte-offsets-expected.txt

301 lines
6.0 KiB
Plaintext
Raw Normal View History

Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
Tests stepping through wasm scripts by byte offsets
Setting up global instance variable.
Hash all strings as unsigned values A previous CL (https://crrev.com/c/1926769) changed hashing to always treat the input as signed values. This causes problems, since the hash of a one-byte string differs the hash of the identical two-byte string. Hence this CL switches to treating all values as unsigned in hashing. The bug cannot easily be reproduced in v8 alone, since we would need to create an internalized two-byte string, which contains one-byte data. Blink manages to create such a string via external strings. R=jkummerow@chromium.org Bug: chromium:1025184, chromium:1027131 Change-Id: Id41aa0e463691c02099a08c6e9d837a079c872df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930615 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65113}
2019-11-22 11:41:15 +00:00
Got wasm script: wasm://wasm/7dfc8356
Setting breakpoint on offset 59 (should be propagated to 60, the offset of the call), url wasm://wasm/7dfc8356
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
{
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
columnNumber : 60
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
lineNumber : 0
scriptId : <scriptId>
}
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:60
at wasm_B (0:60):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":3}
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
stack: {"0":1024}
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:39
at wasm_A (0:39):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
locals: {"arg#0":1024}
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
stack: {}
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
at wasm_B (0:60):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":3}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepOver called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:40
at wasm_A (0:40):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
locals: {"arg#0":1024}
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
stack: {}
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
at wasm_B (0:60):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":3}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepOut called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:62
at wasm_B (0:62):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":3}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepOut called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:60
at wasm_B (0:60):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
locals: {"arg#0":2}
stack: {"0":1024}
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepOver called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:62
at wasm_B (0:62):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":2}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:44
at wasm_B (0:44):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":2}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.resume called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:60
at wasm_B (0:60):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":1}
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
stack: {"0":1024}
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:39
at wasm_A (0:39):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
locals: {"arg#0":1024}
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
stack: {}
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
at wasm_B (0:60):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":1}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepOut called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:62
at wasm_B (0:62):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":1}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:44
at wasm_B (0:44):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":1}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:46
at wasm_B (0:46):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":1}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:48
at wasm_B (0:48):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":1}
stack: {"0":1}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:50
at wasm_B (0:50):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":1}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:52
at wasm_B (0:52):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":1}
stack: {"0":1}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:54
at wasm_B (0:54):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":1}
stack: {"0":1,"1":1}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:55
at wasm_B (0:55):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":1}
stack: {"0":0}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:57
at wasm_B (0:57):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":0}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:60
at wasm_B (0:60):
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":0}
stack: {"0":1024}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:39
at wasm_A (0:39):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
locals: {"arg#0":1024}
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
stack: {}
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
at wasm_B (0:60):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":0}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:40
at wasm_A (0:40):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
locals: {"arg#0":1024}
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
stack: {}
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
at wasm_B (0:60):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":0}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:41
at wasm_A (0:41):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
Reland "[wasm] Prevent breakpoints on nonbreakable positions" This is an unmodified reland of 3c98a2a36a97bb30e0555d5a155dd9be77f4386e. The actual issue was fixed in https://crrev.com/c/1926769. Original change's description: > [wasm] Prevent breakpoints on nonbreakable positions > > If a breakpoint is set on a non-breakable position, the wasm interpreter > just stores the value 0xFF (kInternalBreakpoint) in the function body > (actually, a copy of the function body). This might overwrite immediates > and cause subsequent failures in the wasm interpreter. > > In JavaScript, breakpoints are just forwarded to the next breakable > position. This CL implements the same for WebAssembly. > A cctest tests this behavior, and the existing > wasm-stepping-byte-offsets.js inspector test is extended to also set the > breakpoint within an i32 constant immediate. > > R=leese@chromium.org, mstarzinger@chromium.org > CC=​bmeurer@chromium.org > > Bug: chromium:1025184 > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65070} Bug: chromium:1025184 Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65093}
2019-11-20 11:27:40 +00:00
locals: {"arg#0":1024}
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
stack: {}
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
at wasm_B (0:60):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":0}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.stepInto called
Remove fake wasm scripts from V8 backend Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
2020-01-09 12:11:55 +00:00
Paused at wasm://wasm/7dfc8356:0:62
at wasm_B (0:62):
Report real module in addition to fake scripts Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
2019-11-06 15:51:44 +00:00
- scope (global):
-- skipped
- scope (local):
locals: {"arg#0":0}
stack: {}
at (anonymous) (0:17):
- scope (global):
-- skipped
Debugger.resume called
exports.main returned!
Finished!
Reference in New Issue Copy Permalink