2012-09-24 09:38:46 +00:00
|
|
|
# Copyright 2012 the V8 project authors. All rights reserved.
|
|
|
|
# Redistribution and use in source and binary forms, with or without
|
|
|
|
# modification, are permitted provided that the following conditions are
|
|
|
|
# met:
|
|
|
|
#
|
|
|
|
# * Redistributions of source code must retain the above copyright
|
|
|
|
# notice, this list of conditions and the following disclaimer.
|
|
|
|
# * Redistributions in binary form must reproduce the above
|
|
|
|
# copyright notice, this list of conditions and the following
|
|
|
|
# disclaimer in the documentation and/or other materials provided
|
|
|
|
# with the distribution.
|
|
|
|
# * Neither the name of Google Inc. nor the names of its
|
|
|
|
# contributors may be used to endorse or promote products derived
|
|
|
|
# from this software without specific prior written permission.
|
|
|
|
#
|
|
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
|
|
|
|
|
2017-02-13 15:33:49 +00:00
|
|
|
import os
|
2012-09-24 09:38:46 +00:00
|
|
|
import subprocess
|
2015-06-12 13:43:52 +00:00
|
|
|
import sys
|
2015-05-11 09:26:37 +00:00
|
|
|
from threading import Timer
|
2012-09-24 09:38:46 +00:00
|
|
|
|
|
|
|
from ..local import utils
|
|
|
|
from ..objects import output
|
|
|
|
|
|
|
|
|
|
|
|
SEM_INVALID_VALUE = -1
|
|
|
|
SEM_NOGPFAULTERRORBOX = 0x0002 # Microsoft Platform SDK WinBase.h
|
|
|
|
|
|
|
|
|
|
|
|
def Win32SetErrorMode(mode):
|
|
|
|
prev_error_mode = SEM_INVALID_VALUE
|
|
|
|
try:
|
|
|
|
import ctypes
|
|
|
|
prev_error_mode = \
|
|
|
|
ctypes.windll.kernel32.SetErrorMode(mode) #@UndefinedVariable
|
|
|
|
except ImportError:
|
|
|
|
pass
|
|
|
|
return prev_error_mode
|
|
|
|
|
|
|
|
|
Reland of [date] Add ICU backend for timezone info behind a flag (patchset #1 id:1 of https://codereview.chromium.org/2811103002/ )
Reason for revert:
Reland with tests marked as off in no-i18n mode
Original issue's description:
> Revert of [date] Add ICU backend for timezone info behind a flag (patchset #17 id:320001 of https://codereview.chromium.org/2724373002/ )
>
> Reason for revert:
> Breaks noi18n:
> https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/13314
>
> Original issue's description:
> > [date] Add ICU backend for timezone info behind a flag
> >
> > This patch implements a timezone backend which is based on ICU, rather
> > than operating system calls. It can be turned on by passing the
> > --icu-timezone-data flag. The goal here is to take advantage of ICU's
> > data, which is more complete than the data that some system calls expose.
> > For example, without any special code, this patch fixes the time zone
> > of Lord Howe Island to have a correct 30 minute DST offset, rather than
> > 60 minutes as the OS backends assume it to have.
> >
> > Unfortunately, the parenthized timezone name in Date.prototype.toString()
> > differs across platforms. This patch chooses the long timezone name,
> > which matches Windows behavior and might be the most intelligible, but
> > the web compatibility impact is unclear.
> >
> > BUG=v8:6031,v8:2137,v8:6076
> >
> > Review-Url: https://codereview.chromium.org/2724373002
> > Cr-Commit-Position: refs/heads/master@{#44562}
> > Committed: https://chromium.googlesource.com/v8/v8/+/b213f2399038a615cdfbfa0201cddc113d304018
>
> TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,littledan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:6031,v8:2137,v8:6076
>
> Review-Url: https://codereview.chromium.org/2811103002
> Cr-Commit-Position: refs/heads/master@{#44565}
> Committed: https://chromium.googlesource.com/v8/v8/+/13ad50811024ace5623d5d4d13cea4ef21f4affd
TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,machenbach@chromium.org
BUG=v8:6031,v8:2137,v8:6076
Review-Url: https://codereview.chromium.org/2813863002
Cr-Commit-Position: refs/heads/master@{#44575}
2017-04-11 13:17:29 +00:00
|
|
|
def RunProcess(verbose, timeout, args, additional_env, **rest):
|
2014-05-14 13:30:57 +00:00
|
|
|
if verbose: print "#", " ".join(args)
|
|
|
|
popen_args = args
|
|
|
|
prev_error_mode = SEM_INVALID_VALUE
|
|
|
|
if utils.IsWindows():
|
|
|
|
popen_args = subprocess.list2cmdline(args)
|
|
|
|
# Try to change the error mode to avoid dialogs on fatal errors. Don't
|
|
|
|
# touch any existing error mode flags by merging the existing error mode.
|
|
|
|
# See http://blogs.msdn.com/oldnewthing/archive/2004/07/27/198410.aspx.
|
|
|
|
error_mode = SEM_NOGPFAULTERRORBOX
|
|
|
|
prev_error_mode = Win32SetErrorMode(error_mode)
|
|
|
|
Win32SetErrorMode(error_mode | prev_error_mode)
|
2015-09-29 08:41:26 +00:00
|
|
|
|
2017-02-13 15:33:49 +00:00
|
|
|
env = os.environ.copy()
|
Reland of [date] Add ICU backend for timezone info behind a flag (patchset #1 id:1 of https://codereview.chromium.org/2811103002/ )
Reason for revert:
Reland with tests marked as off in no-i18n mode
Original issue's description:
> Revert of [date] Add ICU backend for timezone info behind a flag (patchset #17 id:320001 of https://codereview.chromium.org/2724373002/ )
>
> Reason for revert:
> Breaks noi18n:
> https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/13314
>
> Original issue's description:
> > [date] Add ICU backend for timezone info behind a flag
> >
> > This patch implements a timezone backend which is based on ICU, rather
> > than operating system calls. It can be turned on by passing the
> > --icu-timezone-data flag. The goal here is to take advantage of ICU's
> > data, which is more complete than the data that some system calls expose.
> > For example, without any special code, this patch fixes the time zone
> > of Lord Howe Island to have a correct 30 minute DST offset, rather than
> > 60 minutes as the OS backends assume it to have.
> >
> > Unfortunately, the parenthized timezone name in Date.prototype.toString()
> > differs across platforms. This patch chooses the long timezone name,
> > which matches Windows behavior and might be the most intelligible, but
> > the web compatibility impact is unclear.
> >
> > BUG=v8:6031,v8:2137,v8:6076
> >
> > Review-Url: https://codereview.chromium.org/2724373002
> > Cr-Commit-Position: refs/heads/master@{#44562}
> > Committed: https://chromium.googlesource.com/v8/v8/+/b213f2399038a615cdfbfa0201cddc113d304018
>
> TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,littledan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:6031,v8:2137,v8:6076
>
> Review-Url: https://codereview.chromium.org/2811103002
> Cr-Commit-Position: refs/heads/master@{#44565}
> Committed: https://chromium.googlesource.com/v8/v8/+/13ad50811024ace5623d5d4d13cea4ef21f4affd
TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,machenbach@chromium.org
BUG=v8:6031,v8:2137,v8:6076
Review-Url: https://codereview.chromium.org/2813863002
Cr-Commit-Position: refs/heads/master@{#44575}
2017-04-11 13:17:29 +00:00
|
|
|
env.update(additional_env)
|
2017-02-13 15:33:49 +00:00
|
|
|
# GTest shard information is read by the V8 tests runner. Make sure it
|
|
|
|
# doesn't leak into the execution of gtests we're wrapping. Those might
|
|
|
|
# otherwise apply a second level of sharding and as a result skip tests.
|
|
|
|
env.pop('GTEST_TOTAL_SHARDS', None)
|
|
|
|
env.pop('GTEST_SHARD_INDEX', None)
|
|
|
|
|
2015-09-29 08:41:26 +00:00
|
|
|
try:
|
|
|
|
process = subprocess.Popen(
|
|
|
|
args=popen_args,
|
|
|
|
stdout=subprocess.PIPE,
|
|
|
|
stderr=subprocess.PIPE,
|
2017-02-13 15:33:49 +00:00
|
|
|
env=env,
|
2015-09-29 08:41:26 +00:00
|
|
|
**rest
|
|
|
|
)
|
|
|
|
except Exception as e:
|
|
|
|
sys.stderr.write("Error executing: %s\n" % popen_args)
|
|
|
|
raise e
|
|
|
|
|
2014-05-14 13:30:57 +00:00
|
|
|
if (utils.IsWindows() and prev_error_mode != SEM_INVALID_VALUE):
|
|
|
|
Win32SetErrorMode(prev_error_mode)
|
2012-09-24 09:38:46 +00:00
|
|
|
|
2015-05-11 09:26:37 +00:00
|
|
|
def kill_process(process, timeout_result):
|
|
|
|
timeout_result[0] = True
|
|
|
|
try:
|
2015-06-12 13:43:52 +00:00
|
|
|
if utils.IsWindows():
|
|
|
|
if verbose:
|
|
|
|
print "Attempting to kill process %d" % process.pid
|
|
|
|
sys.stdout.flush()
|
|
|
|
tk = subprocess.Popen(
|
|
|
|
'taskkill /T /F /PID %d' % process.pid,
|
|
|
|
stdout=subprocess.PIPE,
|
|
|
|
stderr=subprocess.PIPE,
|
|
|
|
)
|
|
|
|
stdout, stderr = tk.communicate()
|
|
|
|
if verbose:
|
|
|
|
print "Taskkill results for %d" % process.pid
|
|
|
|
print stdout
|
|
|
|
print stderr
|
|
|
|
print "Return code: %d" % tk.returncode
|
|
|
|
sys.stdout.flush()
|
|
|
|
else:
|
2017-10-11 13:49:03 +00:00
|
|
|
if utils.GuessOS() == "macos":
|
|
|
|
# TODO(machenbach): Temporary output for investigating hanging test
|
|
|
|
# driver on mac.
|
|
|
|
print "Attempting to kill process %d - cmd %s" % (process.pid, args)
|
2017-10-13 08:19:52 +00:00
|
|
|
try:
|
|
|
|
print subprocess.check_output(
|
|
|
|
"ps -e | egrep 'd8|cctest|unittests'", shell=True)
|
|
|
|
except Exception:
|
|
|
|
pass
|
2017-10-11 13:49:03 +00:00
|
|
|
sys.stdout.flush()
|
2015-06-12 13:43:52 +00:00
|
|
|
process.kill()
|
2017-10-12 12:58:07 +00:00
|
|
|
if utils.GuessOS() == "macos":
|
|
|
|
# TODO(machenbach): Temporary output for investigating hanging test
|
|
|
|
# driver on mac. This will probably not print much, since kill only
|
|
|
|
# sends the signal.
|
|
|
|
print "Return code after signalling the kill: %s" % process.returncode
|
2017-10-13 08:19:52 +00:00
|
|
|
sys.stdout.flush()
|
2017-10-12 12:58:07 +00:00
|
|
|
|
2015-05-11 09:26:37 +00:00
|
|
|
except OSError:
|
|
|
|
sys.stderr.write('Error: Process %s already ended.\n' % process.pid)
|
2012-09-24 09:38:46 +00:00
|
|
|
|
2015-05-11 09:26:37 +00:00
|
|
|
# Pseudo object to communicate with timer thread.
|
|
|
|
timeout_result = [False]
|
2012-09-24 09:38:46 +00:00
|
|
|
|
2015-05-11 09:26:37 +00:00
|
|
|
timer = Timer(timeout, kill_process, [process, timeout_result])
|
|
|
|
timer.start()
|
|
|
|
stdout, stderr = process.communicate()
|
|
|
|
timer.cancel()
|
2016-03-08 10:47:58 +00:00
|
|
|
|
|
|
|
return output.Output(
|
|
|
|
process.returncode,
|
|
|
|
timeout_result[0],
|
2016-06-29 20:32:18 +00:00
|
|
|
stdout.decode('utf-8', 'replace').encode('utf-8'),
|
|
|
|
stderr.decode('utf-8', 'replace').encode('utf-8'),
|
2016-03-08 10:47:58 +00:00
|
|
|
process.pid,
|
|
|
|
)
|
2012-09-24 09:38:46 +00:00
|
|
|
|
|
|
|
|
2017-10-16 09:29:50 +00:00
|
|
|
# TODO(machenbach): Instead of passing args around, we should introduce an
|
|
|
|
# immutable Command class (that just represents the command with all flags and
|
|
|
|
# is pretty-printable) and a member method for running such a command.
|
Reland of [date] Add ICU backend for timezone info behind a flag (patchset #1 id:1 of https://codereview.chromium.org/2811103002/ )
Reason for revert:
Reland with tests marked as off in no-i18n mode
Original issue's description:
> Revert of [date] Add ICU backend for timezone info behind a flag (patchset #17 id:320001 of https://codereview.chromium.org/2724373002/ )
>
> Reason for revert:
> Breaks noi18n:
> https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/13314
>
> Original issue's description:
> > [date] Add ICU backend for timezone info behind a flag
> >
> > This patch implements a timezone backend which is based on ICU, rather
> > than operating system calls. It can be turned on by passing the
> > --icu-timezone-data flag. The goal here is to take advantage of ICU's
> > data, which is more complete than the data that some system calls expose.
> > For example, without any special code, this patch fixes the time zone
> > of Lord Howe Island to have a correct 30 minute DST offset, rather than
> > 60 minutes as the OS backends assume it to have.
> >
> > Unfortunately, the parenthized timezone name in Date.prototype.toString()
> > differs across platforms. This patch chooses the long timezone name,
> > which matches Windows behavior and might be the most intelligible, but
> > the web compatibility impact is unclear.
> >
> > BUG=v8:6031,v8:2137,v8:6076
> >
> > Review-Url: https://codereview.chromium.org/2724373002
> > Cr-Commit-Position: refs/heads/master@{#44562}
> > Committed: https://chromium.googlesource.com/v8/v8/+/b213f2399038a615cdfbfa0201cddc113d304018
>
> TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,littledan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:6031,v8:2137,v8:6076
>
> Review-Url: https://codereview.chromium.org/2811103002
> Cr-Commit-Position: refs/heads/master@{#44565}
> Committed: https://chromium.googlesource.com/v8/v8/+/13ad50811024ace5623d5d4d13cea4ef21f4affd
TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,machenbach@chromium.org
BUG=v8:6031,v8:2137,v8:6076
Review-Url: https://codereview.chromium.org/2813863002
Cr-Commit-Position: refs/heads/master@{#44575}
2017-04-11 13:17:29 +00:00
|
|
|
def Execute(args, verbose=False, timeout=None, env=None):
|
2015-05-11 09:26:37 +00:00
|
|
|
args = [ c for c in args if c != "" ]
|
Reland of [date] Add ICU backend for timezone info behind a flag (patchset #1 id:1 of https://codereview.chromium.org/2811103002/ )
Reason for revert:
Reland with tests marked as off in no-i18n mode
Original issue's description:
> Revert of [date] Add ICU backend for timezone info behind a flag (patchset #17 id:320001 of https://codereview.chromium.org/2724373002/ )
>
> Reason for revert:
> Breaks noi18n:
> https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/13314
>
> Original issue's description:
> > [date] Add ICU backend for timezone info behind a flag
> >
> > This patch implements a timezone backend which is based on ICU, rather
> > than operating system calls. It can be turned on by passing the
> > --icu-timezone-data flag. The goal here is to take advantage of ICU's
> > data, which is more complete than the data that some system calls expose.
> > For example, without any special code, this patch fixes the time zone
> > of Lord Howe Island to have a correct 30 minute DST offset, rather than
> > 60 minutes as the OS backends assume it to have.
> >
> > Unfortunately, the parenthized timezone name in Date.prototype.toString()
> > differs across platforms. This patch chooses the long timezone name,
> > which matches Windows behavior and might be the most intelligible, but
> > the web compatibility impact is unclear.
> >
> > BUG=v8:6031,v8:2137,v8:6076
> >
> > Review-Url: https://codereview.chromium.org/2724373002
> > Cr-Commit-Position: refs/heads/master@{#44562}
> > Committed: https://chromium.googlesource.com/v8/v8/+/b213f2399038a615cdfbfa0201cddc113d304018
>
> TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,littledan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:6031,v8:2137,v8:6076
>
> Review-Url: https://codereview.chromium.org/2811103002
> Cr-Commit-Position: refs/heads/master@{#44565}
> Committed: https://chromium.googlesource.com/v8/v8/+/13ad50811024ace5623d5d4d13cea4ef21f4affd
TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,machenbach@chromium.org
BUG=v8:6031,v8:2137,v8:6076
Review-Url: https://codereview.chromium.org/2813863002
Cr-Commit-Position: refs/heads/master@{#44575}
2017-04-11 13:17:29 +00:00
|
|
|
return RunProcess(verbose, timeout, args, env or {})
|