v8/test/message/fail/modules-cycle2.js

// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// MODULE

import {a} from "modules-skip-cycle2.js";
export {a as b};
[modules] Detect and throw exceptions for cyclic dependencies Use an unordered_map<Module, unordered_set<String>> to keep track of visited Module/ExportName pairs during ResolveExport. This required adding a Hash() method to Module, which is accomplished by allocating a Symbol and storing it in the SharedFunctionInfo::name slot, then delegating the hash to that Symbol. Also added a helper method Module::shared() to easily get ahold of the SharedFunctionInfo and call it in the appropriate places instead of re-doing the ternary operator. BUG=v8:1569 Review-Url: https://codereview.chromium.org/2367623004 Cr-Commit-Position: refs/heads/master@{#39743} 2016-09-26 22:42:09 +00:00			`// Copyright 2016 the V8 project authors. All rights reserved.`
			`// Use of this source code is governed by a BSD-style license that can be`
			`// found in the LICENSE file.`
			`//`
			`// MODULE`

[modules] Improve error messages. For instance, when an import cannot be resolved, actually point at the corresponding import statement. BUG=v8:1569 Review-Url: https://codereview.chromium.org/2451153002 Cr-Commit-Position: refs/heads/master@{#40594} 2016-10-26 15:09:47 +00:00			`import {a} from "modules-skip-cycle2.js";`
[modules] Detect and throw exceptions for cyclic dependencies Use an unordered_map<Module, unordered_set<String>> to keep track of visited Module/ExportName pairs during ResolveExport. This required adding a Hash() method to Module, which is accomplished by allocating a Symbol and storing it in the SharedFunctionInfo::name slot, then delegating the hash to that Symbol. Also added a helper method Module::shared() to easily get ahold of the SharedFunctionInfo and call it in the appropriate places instead of re-doing the ternary operator. BUG=v8:1569 Review-Url: https://codereview.chromium.org/2367623004 Cr-Commit-Position: refs/heads/master@{#39743} 2016-09-26 22:42:09 +00:00			`export {a as b};`