AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
d195ce148b
v8/test/mjsunit/wasm/wasm-gc-js-roundtrip.js

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

147 lines
5.6 KiB
JavaScript
Raw Normal View History

[wasm-gc] Fix and extend JS roundtrip for gc types Changes: - Wrap eqref and i31ref objects in the temporary wasm object wrapper (in addition to dataref and anyref). Accept those types in IsJSCompatibleSignature(). - Handle null correctly in all cases (i.e., do not wrap/unwrap it). - Improve some error messages. - Handle kRttWithDepth in one case where it was omitted. - Some small structure improvements. - Add an extensive test. Bug: v8:7748, v8:11606 Change-Id: Ie519f2c87421664dd02cf29fe94f9a9d7510bae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794422 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73725}
2021-03-30 15:23:00 +00:00
// Copyright 2021 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --experimental-wasm-gc
[d8][mjsunit][tools] Improve d8 file API - Add d8.file.read() and d8.file.execute() helpers - Change tools and tests to use new d8.file helper - Unify error throwing in v8::Shell::ReadFile Change-Id: I5ef4cb27f217508a367106f01e872a4059d5e399 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928505 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74883}
2021-06-01 12:46:36 +00:00
d8.file.execute('test/mjsunit/wasm/wasm-module-builder.js');
[wasm-gc] Fix and extend JS roundtrip for gc types Changes: - Wrap eqref and i31ref objects in the temporary wasm object wrapper (in addition to dataref and anyref). Accept those types in IsJSCompatibleSignature(). - Handle null correctly in all cases (i.e., do not wrap/unwrap it). - Improve some error messages. - Handle kRttWithDepth in one case where it was omitted. - Some small structure improvements. - Add an extensive test. Bug: v8:7748, v8:11606 Change-Id: Ie519f2c87421664dd02cf29fe94f9a9d7510bae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794422 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73725}
2021-03-30 15:23:00 +00:00
let instance = (() => {
let builder = new WasmModuleBuilder();
let struct = builder.addStruct([makeField(kWasmI32, true)]);
let array = builder.addArray(kWasmF64, true);
let sig = builder.addType(makeSig([kWasmI32], [kWasmI32]));
let func = builder.addFunction('inc', sig)
.addBody([kExprLocalGet, 0, kExprI32Const, 1, kExprI32Add])
.exportAs('inc');
builder.addFunction('struct_producer', makeSig([], [kWasmDataRef]))
[test][wasm-gc] Replace (array|struct).new_[default_]with_rtt Bug: v8:7748 Change-Id: Ib8fadc272178fb0d49f7d5fab7d1953e2328a1ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3770107 Auto-Submit: Matthias Liedtke <mliedtke@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81787}
2022-07-18 15:31:03 +00:00
.addBody([kGCPrefix, kExprStructNewDefault, struct])
[wasm-gc] Fix and extend JS roundtrip for gc types Changes: - Wrap eqref and i31ref objects in the temporary wasm object wrapper (in addition to dataref and anyref). Accept those types in IsJSCompatibleSignature(). - Handle null correctly in all cases (i.e., do not wrap/unwrap it). - Improve some error messages. - Handle kRttWithDepth in one case where it was omitted. - Some small structure improvements. - Add an extensive test. Bug: v8:7748, v8:11606 Change-Id: Ie519f2c87421664dd02cf29fe94f9a9d7510bae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794422 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73725}
2021-03-30 15:23:00 +00:00
.exportFunc();
builder.addFunction('array_producer', makeSig([], [kWasmDataRef]))
.addBody([
[test][wasm-gc] Replace (array|struct).new_[default_]with_rtt Bug: v8:7748 Change-Id: Ib8fadc272178fb0d49f7d5fab7d1953e2328a1ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3770107 Auto-Submit: Matthias Liedtke <mliedtke@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81787}
2022-07-18 15:31:03 +00:00
kExprI32Const, 10,
kGCPrefix, kExprArrayNewDefault, array
[wasm-gc] Fix and extend JS roundtrip for gc types Changes: - Wrap eqref and i31ref objects in the temporary wasm object wrapper (in addition to dataref and anyref). Accept those types in IsJSCompatibleSignature(). - Handle null correctly in all cases (i.e., do not wrap/unwrap it). - Improve some error messages. - Handle kRttWithDepth in one case where it was omitted. - Some small structure improvements. - Add an extensive test. Bug: v8:7748, v8:11606 Change-Id: Ie519f2c87421664dd02cf29fe94f9a9d7510bae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794422 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73725}
2021-03-30 15:23:00 +00:00
])
.exportFunc();
builder.addFunction('i31_producer', makeSig([], [kWasmI31Ref]))
.addBody([kExprI32Const, 5, kGCPrefix, kExprI31New])
.exportFunc();
builder.addFunction('func_producer', makeSig([], [wasmRefType(sig)]))
.addBody([kExprRefFunc, func.index])
.exportFunc();
let test_types = {
i31: kWasmI31Ref,
struct: kWasmDataRef,
array: kWasmDataRef,
raw_struct: struct,
raw_array: array,
typed_func: sig,
data: kWasmDataRef,
eq: kWasmEqRef,
func: kWasmFuncRef,
any: kWasmAnyRef,
};
for (key in test_types) {
[wasm-gc][refactor] Rename optRef -> refNull This makes the internal V8 name consistent with the text-format name. Bug: v8:7748 Change-Id: I44f7ac1eb5e634b4f829e596bf1f14caeb748d54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3726291 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81491}
2022-07-01 11:50:04 +00:00
let type = wasmRefNullType(test_types[key]);
[wasm-gc] Fix and extend JS roundtrip for gc types Changes: - Wrap eqref and i31ref objects in the temporary wasm object wrapper (in addition to dataref and anyref). Accept those types in IsJSCompatibleSignature(). - Handle null correctly in all cases (i.e., do not wrap/unwrap it). - Improve some error messages. - Handle kRttWithDepth in one case where it was omitted. - Some small structure improvements. - Add an extensive test. Bug: v8:7748, v8:11606 Change-Id: Ie519f2c87421664dd02cf29fe94f9a9d7510bae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794422 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73725}
2021-03-30 15:23:00 +00:00
builder.addFunction(key + '_id', makeSig([type], [type]))
.addBody([kExprLocalGet, 0])
.exportFunc();
builder.addFunction(key + '_null', makeSig([], [type]))
[wasm-gc][test] Add builtin ref type handling in wasm-module-builder We currently print reference type indices as unsigned LEB. This will not work properly for large indices (>=64), as they will be interpreted as negative indices when read back. They may also alias with builtin types. In this CL, we fix this by defining builtin types as negative numbers. We add positive byte constants that can be used in function bodies. We adapt wasm-module-builder and tests to the above changes. Bug: v8:7748 Change-Id: I4dfaa65d4cbf77a6731ca2283148bd842ea5c56b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3080569 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#76176}
2021-08-09 15:48:11 +00:00
.addBody([kExprRefNull, ...wasmSignedLeb(test_types[key])])
[wasm-gc] Fix and extend JS roundtrip for gc types Changes: - Wrap eqref and i31ref objects in the temporary wasm object wrapper (in addition to dataref and anyref). Accept those types in IsJSCompatibleSignature(). - Handle null correctly in all cases (i.e., do not wrap/unwrap it). - Improve some error messages. - Handle kRttWithDepth in one case where it was omitted. - Some small structure improvements. - Add an extensive test. Bug: v8:7748, v8:11606 Change-Id: Ie519f2c87421664dd02cf29fe94f9a9d7510bae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794422 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73725}
2021-03-30 15:23:00 +00:00
.exportFunc();
}
return builder.instantiate({});
})();
// Wasm-exposed null is the same as JS null.
assertEquals(instance.exports.struct_null(), null);
// We can roundtrip an i31.
instance.exports.i31_id(instance.exports.i31_producer());
// We can roundtrip any null as i31.
instance.exports.i31_id(instance.exports.i31_null());
instance.exports.i31_id(instance.exports.struct_null());
// We cannot roundtrip a struct as i31.
assertThrows(
() => instance.exports.i31_id(instance.exports.struct_producer()),
TypeError, 'type incompatibility when transforming from/to JS');
// We can roundtrip a struct as dataref.
instance.exports.data_id(instance.exports.struct_producer());
// We can roundtrip an array as dataref.
instance.exports.data_id(instance.exports.array_producer());
// We can roundtrip any null as dataref.
instance.exports.data_id(instance.exports.data_null());
instance.exports.data_id(instance.exports.i31_null());
// We cannot roundtrip an i31 as dataref.
assertThrows(
() => instance.exports.data_id(instance.exports.i31_producer()), TypeError,
'type incompatibility when transforming from/to JS');
// We can roundtrip a struct as eqref.
instance.exports.eq_id(instance.exports.struct_producer());
// We can roundtrip an array as eqref.
instance.exports.eq_id(instance.exports.array_producer());
// We can roundtrip an i31 as eqref.
instance.exports.eq_id(instance.exports.i31_producer());
// We can roundtrip any null as eqref.
instance.exports.eq_id(instance.exports.data_null());
instance.exports.eq_id(instance.exports.i31_null());
instance.exports.eq_id(instance.exports.func_null());
// We cannot roundtrip a func as eqref.
assertThrows(
() => instance.exports.eq_id(instance.exports.func_producer()), TypeError,
'type incompatibility when transforming from/to JS');
// We can roundtrip a struct as anyref.
instance.exports.any_id(instance.exports.struct_producer());
// We can roundtrip an array as anyref.
instance.exports.any_id(instance.exports.array_producer());
// We can roundtrip an i31 as anyref.
instance.exports.any_id(instance.exports.i31_producer());
// We can roundtrip a func as anyref.
instance.exports.any_id(instance.exports.func_producer());
// We can roundtrip any null as anyref.
instance.exports.any_id(instance.exports.data_null());
instance.exports.any_id(instance.exports.i31_null());
instance.exports.any_id(instance.exports.func_null());
// We can roundtrip a JS object as anyref.
instance.exports.any_id(instance);
// We can roundtrip a typed function.
instance.exports.typed_func_id(instance.exports.func_producer());
// We can roundtrip any null as typed funcion.
instance.exports.typed_func_id(instance.exports.i31_null());
instance.exports.typed_func_id(instance.exports.struct_null());
// We cannot roundtrip a struct as typed funcion.
assertThrows(
() => instance.exports.typed_func_id(instance.exports.struct_producer()),
TypeError, 'type incompatibility when transforming from/to JS');
// We can roundtrip a func.
instance.exports.func_id(instance.exports.func_producer());
// We can roundtrip any null as func.
instance.exports.func_id(instance.exports.i31_null());
instance.exports.func_id(instance.exports.struct_null());
// We cannot roundtrip an i31 as func.
assertThrows(
() => instance.exports.func_id(instance.exports.i31_producer()), TypeError,
'type incompatibility when transforming from/to JS');
// We cannot directly roundtrip structs or arrays.
// TODO(7748): Switch these tests once we can.
assertThrows(
() => instance.exports.raw_struct_id(instance.exports.struct_producer()),
TypeError, 'type incompatibility when transforming from/to JS');
assertThrows(
() => instance.exports.raw_array_id(instance.exports.array_producer()),
TypeError, 'type incompatibility when transforming from/to JS');
Reference in New Issue Copy Permalink