2014-08-20 13:05:03 +00:00
|
|
|
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file.
|
|
|
|
|
2015-02-20 10:11:45 +00:00
|
|
|
#include "src/compiler/js-inlining.h"
|
|
|
|
|
2014-10-21 12:16:37 +00:00
|
|
|
#include "src/ast.h"
|
|
|
|
#include "src/ast-numbering.h"
|
2015-09-01 10:30:40 +00:00
|
|
|
#include "src/compiler.h"
|
2015-02-20 10:11:45 +00:00
|
|
|
#include "src/compiler/all-nodes.h"
|
2014-08-20 13:05:03 +00:00
|
|
|
#include "src/compiler/ast-graph-builder.h"
|
|
|
|
#include "src/compiler/common-operator.h"
|
2015-10-14 12:20:39 +00:00
|
|
|
#include "src/compiler/graph-reducer.h"
|
2014-08-20 13:05:03 +00:00
|
|
|
#include "src/compiler/js-operator.h"
|
|
|
|
#include "src/compiler/node-matchers.h"
|
2015-01-29 09:17:45 +00:00
|
|
|
#include "src/compiler/node-properties.h"
|
2015-03-09 08:37:01 +00:00
|
|
|
#include "src/compiler/operator-properties.h"
|
2015-09-09 10:24:17 +00:00
|
|
|
#include "src/isolate-inl.h"
|
2014-08-20 13:05:03 +00:00
|
|
|
#include "src/parser.h"
|
|
|
|
#include "src/rewriter.h"
|
|
|
|
#include "src/scopes.h"
|
|
|
|
|
|
|
|
namespace v8 {
|
|
|
|
namespace internal {
|
|
|
|
namespace compiler {
|
|
|
|
|
2015-03-17 18:51:08 +00:00
|
|
|
#define TRACE(...) \
|
|
|
|
do { \
|
|
|
|
if (FLAG_trace_turbo_inlining) PrintF(__VA_ARGS__); \
|
|
|
|
} while (false)
|
|
|
|
|
2015-02-17 10:30:54 +00:00
|
|
|
|
2015-11-12 08:50:51 +00:00
|
|
|
// Provides convenience accessors for the common layout of nodes having either
|
|
|
|
// the {JSCallFunction} or the {JSCallConstruct} operator.
|
|
|
|
class JSCallAccessor {
|
2014-08-20 13:05:03 +00:00
|
|
|
public:
|
2015-11-12 08:50:51 +00:00
|
|
|
explicit JSCallAccessor(Node* call) : call_(call) {
|
|
|
|
DCHECK(call->opcode() == IrOpcode::kJSCallFunction ||
|
|
|
|
call->opcode() == IrOpcode::kJSCallConstruct);
|
2015-02-17 10:30:54 +00:00
|
|
|
}
|
2014-08-20 13:05:03 +00:00
|
|
|
|
2015-11-12 08:50:51 +00:00
|
|
|
Node* target() {
|
|
|
|
// Both, {JSCallFunction} and {JSCallConstruct}, have same layout here.
|
|
|
|
return call_->InputAt(0);
|
|
|
|
}
|
2015-02-17 10:30:54 +00:00
|
|
|
|
2015-11-12 08:50:51 +00:00
|
|
|
Node* receiver() {
|
|
|
|
DCHECK_EQ(IrOpcode::kJSCallFunction, call_->opcode());
|
|
|
|
return call_->InputAt(1);
|
2014-08-20 13:05:03 +00:00
|
|
|
}
|
|
|
|
|
2015-11-13 11:53:16 +00:00
|
|
|
Node* new_target() {
|
2015-11-12 08:50:51 +00:00
|
|
|
DCHECK_EQ(IrOpcode::kJSCallConstruct, call_->opcode());
|
|
|
|
return call_->InputAt(formal_arguments() + 1);
|
2015-02-17 10:30:54 +00:00
|
|
|
}
|
|
|
|
|
2015-10-30 06:58:56 +00:00
|
|
|
Node* frame_state_before() {
|
|
|
|
return NodeProperties::GetFrameStateInput(call_, 1);
|
|
|
|
}
|
2015-11-12 08:50:51 +00:00
|
|
|
|
2015-10-30 06:58:56 +00:00
|
|
|
Node* frame_state_after() {
|
2015-11-12 08:50:51 +00:00
|
|
|
// Both, {JSCallFunction} and {JSCallConstruct}, have frame state after.
|
2015-10-30 06:58:56 +00:00
|
|
|
return NodeProperties::GetFrameStateInput(call_, 0);
|
|
|
|
}
|
2015-02-17 10:30:54 +00:00
|
|
|
|
2015-11-12 08:50:51 +00:00
|
|
|
int formal_arguments() {
|
|
|
|
// Both, {JSCallFunction} and {JSCallConstruct}, have two extra inputs:
|
2015-11-13 11:53:16 +00:00
|
|
|
// - JSCallConstruct: Includes target function and new target.
|
2015-11-12 08:50:51 +00:00
|
|
|
// - JSCallFunction: Includes target function and receiver.
|
|
|
|
return call_->op()->ValueInputCount() - 2;
|
|
|
|
}
|
|
|
|
|
2014-08-20 13:05:03 +00:00
|
|
|
private:
|
2015-02-17 10:30:54 +00:00
|
|
|
Node* call_;
|
2014-08-20 13:05:03 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
2015-02-20 10:11:45 +00:00
|
|
|
class CopyVisitor {
|
2014-09-12 11:06:37 +00:00
|
|
|
public:
|
|
|
|
CopyVisitor(Graph* source_graph, Graph* target_graph, Zone* temp_zone)
|
[turbofan] Proper dead code elimination as regular reducer.
The three different concerns that the ControlReducer used to deal with
are now properly separated into
a.) DeadCodeElimination, which is a regular AdvancedReducer, that
propagates Dead via control edges,
b.) CommonOperatorReducer, which does strength reduction on common
operators (i.e. Branch, Phi, and friends), and
c.) GraphTrimming, which removes dead->live edges from the graph.
This will make it possible to run the DeadCodeElimination together with
other passes that actually introduce Dead nodes, i.e. typed lowering;
and it opens the door for general inlining without two stage fix point
iteration.
To make the DeadCodeElimination easier and more uniform, we basically
reverted the introduction of DeadValue and DeadEffect, and changed the
Dead operator to produce control, value and effect. Note however that
this is not a requirement, but merely a way to make dead propagation
easier and more uniform. We could always go back and decide to have
different Dead operators if some other change requires that.
Note that there are several additional opportunities for cleanup now,
i.e. OSR deconstruction could be a regular reducer now, and we don't
need to use TheHole as dead value marker in the GraphReducer. And we can
actually run the dead code elimination together with the other passes
instead of using separate passes over the graph. We will do this in
follow up CLs.
R=jarin@chromium.org, mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/1193833002
Cr-Commit-Position: refs/heads/master@{#29146}
2015-06-19 12:07:17 +00:00
|
|
|
: sentinel_op_(IrOpcode::kDead, Operator::kNoProperties, "Sentinel", 0, 0,
|
|
|
|
0, 0, 0, 0),
|
2015-02-20 10:11:45 +00:00
|
|
|
sentinel_(target_graph->NewNode(&sentinel_op_)),
|
|
|
|
copies_(source_graph->NodeCount(), sentinel_, temp_zone),
|
2014-09-12 11:06:37 +00:00
|
|
|
source_graph_(source_graph),
|
|
|
|
target_graph_(target_graph),
|
2015-02-20 10:11:45 +00:00
|
|
|
temp_zone_(temp_zone) {}
|
|
|
|
|
|
|
|
Node* GetCopy(Node* orig) { return copies_[orig->id()]; }
|
2014-09-12 11:06:37 +00:00
|
|
|
|
2015-02-20 10:11:45 +00:00
|
|
|
void CopyGraph() {
|
2014-09-12 11:06:37 +00:00
|
|
|
NodeVector inputs(temp_zone_);
|
2015-02-20 10:11:45 +00:00
|
|
|
// TODO(bmeurer): AllNodes should be turned into something like
|
|
|
|
// Graph::CollectNodesReachableFromEnd() and the gray set stuff should be
|
|
|
|
// removed since it's only needed by the visualizer.
|
|
|
|
AllNodes all(temp_zone_, source_graph_);
|
|
|
|
// Copy all nodes reachable from end.
|
|
|
|
for (Node* orig : all.live) {
|
|
|
|
Node* copy = GetCopy(orig);
|
|
|
|
if (copy != sentinel_) {
|
|
|
|
// Mapping already exists.
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
// Copy the node.
|
|
|
|
inputs.clear();
|
|
|
|
for (Node* input : orig->inputs()) inputs.push_back(copies_[input->id()]);
|
|
|
|
copy = target_graph_->NewNode(orig->op(), orig->InputCount(),
|
|
|
|
inputs.empty() ? nullptr : &inputs[0]);
|
|
|
|
copies_[orig->id()] = copy;
|
2014-09-12 11:06:37 +00:00
|
|
|
}
|
2015-02-20 10:11:45 +00:00
|
|
|
// For missing inputs.
|
|
|
|
for (Node* orig : all.live) {
|
|
|
|
Node* copy = copies_[orig->id()];
|
|
|
|
for (int i = 0; i < copy->InputCount(); ++i) {
|
|
|
|
Node* input = copy->InputAt(i);
|
|
|
|
if (input == sentinel_) {
|
|
|
|
copy->ReplaceInput(i, GetCopy(orig->InputAt(i)));
|
|
|
|
}
|
|
|
|
}
|
2014-09-12 11:06:37 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-02-20 10:11:45 +00:00
|
|
|
const NodeVector& copies() const { return copies_; }
|
2014-09-12 11:06:37 +00:00
|
|
|
|
|
|
|
private:
|
2015-02-20 10:11:45 +00:00
|
|
|
Operator const sentinel_op_;
|
|
|
|
Node* const sentinel_;
|
2014-09-12 11:06:37 +00:00
|
|
|
NodeVector copies_;
|
2015-02-20 10:11:45 +00:00
|
|
|
Graph* const source_graph_;
|
|
|
|
Graph* const target_graph_;
|
|
|
|
Zone* const temp_zone_;
|
2014-09-12 11:06:37 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
2015-11-19 12:47:29 +00:00
|
|
|
Reduction JSInliner::InlineCall(Node* call, Node* new_target, Node* context,
|
|
|
|
Node* frame_state, Node* start, Node* end) {
|
2014-08-28 12:18:25 +00:00
|
|
|
// The scheduler is smart enough to place our code; we just ensure {control}
|
2015-03-09 13:01:30 +00:00
|
|
|
// becomes the control input of the start of the inlinee, and {effect} becomes
|
|
|
|
// the effect input of the start of the inlinee.
|
2014-08-20 13:05:03 +00:00
|
|
|
Node* control = NodeProperties::GetControlInput(call);
|
2015-03-09 13:01:30 +00:00
|
|
|
Node* effect = NodeProperties::GetEffectInput(call);
|
2014-08-20 13:05:03 +00:00
|
|
|
|
2015-11-19 12:47:29 +00:00
|
|
|
int const inlinee_new_target_index =
|
|
|
|
static_cast<int>(start->op()->ValueOutputCount()) - 3;
|
2015-11-04 14:08:46 +00:00
|
|
|
int const inlinee_arity_index =
|
|
|
|
static_cast<int>(start->op()->ValueOutputCount()) - 2;
|
2015-05-21 13:02:18 +00:00
|
|
|
int const inlinee_context_index =
|
|
|
|
static_cast<int>(start->op()->ValueOutputCount()) - 1;
|
|
|
|
|
2015-11-19 12:47:29 +00:00
|
|
|
// {inliner_inputs} counts JSFunction, receiver, arguments, but not
|
|
|
|
// new target value, argument count, context, effect or control.
|
2014-10-29 18:46:44 +00:00
|
|
|
int inliner_inputs = call->op()->ValueInputCount();
|
2014-08-20 13:05:03 +00:00
|
|
|
// Iterate over all uses of the start node.
|
2015-05-21 13:02:18 +00:00
|
|
|
for (Edge edge : start->use_edges()) {
|
2014-12-02 14:38:55 +00:00
|
|
|
Node* use = edge.from();
|
2014-08-20 13:05:03 +00:00
|
|
|
switch (use->opcode()) {
|
|
|
|
case IrOpcode::kParameter: {
|
2015-04-22 11:34:43 +00:00
|
|
|
int index = 1 + ParameterIndexOf(use->op());
|
2015-09-16 13:04:25 +00:00
|
|
|
DCHECK_LE(index, inlinee_context_index);
|
2015-11-19 12:47:29 +00:00
|
|
|
if (index < inliner_inputs && index < inlinee_new_target_index) {
|
2014-08-20 13:05:03 +00:00
|
|
|
// There is an input from the call, and the index is a value
|
|
|
|
// projection but not the context, so rewire the input.
|
2015-07-06 12:56:05 +00:00
|
|
|
Replace(use, call->InputAt(index));
|
2015-11-19 12:47:29 +00:00
|
|
|
} else if (index == inlinee_new_target_index) {
|
|
|
|
// The projection is requesting the new target value.
|
|
|
|
Replace(use, new_target);
|
2015-11-04 14:08:46 +00:00
|
|
|
} else if (index == inlinee_arity_index) {
|
|
|
|
// The projection is requesting the number of arguments.
|
|
|
|
Replace(use, jsgraph_->Int32Constant(inliner_inputs - 2));
|
2014-08-20 13:05:03 +00:00
|
|
|
} else if (index == inlinee_context_index) {
|
2015-09-16 13:04:25 +00:00
|
|
|
// The projection is requesting the inlinee function context.
|
2015-07-06 12:56:05 +00:00
|
|
|
Replace(use, context);
|
2015-09-16 13:04:25 +00:00
|
|
|
} else {
|
2014-08-20 13:05:03 +00:00
|
|
|
// Call has fewer arguments than required, fill with undefined.
|
2015-07-06 12:56:05 +00:00
|
|
|
Replace(use, jsgraph_->UndefinedConstant());
|
2014-08-20 13:05:03 +00:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
2014-12-02 14:38:55 +00:00
|
|
|
if (NodeProperties::IsEffectEdge(edge)) {
|
2015-03-09 13:01:30 +00:00
|
|
|
edge.UpdateTo(effect);
|
2014-12-02 14:38:55 +00:00
|
|
|
} else if (NodeProperties::IsControlEdge(edge)) {
|
|
|
|
edge.UpdateTo(control);
|
2015-05-27 11:01:51 +00:00
|
|
|
} else if (NodeProperties::IsFrameStateEdge(edge)) {
|
|
|
|
edge.UpdateTo(frame_state);
|
2014-08-20 13:05:03 +00:00
|
|
|
} else {
|
|
|
|
UNREACHABLE();
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-05-26 10:31:55 +00:00
|
|
|
NodeVector values(local_zone_);
|
|
|
|
NodeVector effects(local_zone_);
|
|
|
|
NodeVector controls(local_zone_);
|
|
|
|
for (Node* const input : end->inputs()) {
|
|
|
|
switch (input->opcode()) {
|
|
|
|
case IrOpcode::kReturn:
|
|
|
|
values.push_back(NodeProperties::GetValueInput(input, 0));
|
|
|
|
effects.push_back(NodeProperties::GetEffectInput(input));
|
|
|
|
controls.push_back(NodeProperties::GetControlInput(input));
|
|
|
|
break;
|
2015-05-26 12:17:57 +00:00
|
|
|
case IrOpcode::kDeoptimize:
|
|
|
|
case IrOpcode::kTerminate:
|
|
|
|
case IrOpcode::kThrow:
|
2015-09-24 14:46:29 +00:00
|
|
|
NodeProperties::MergeControlToEnd(jsgraph_->graph(), jsgraph_->common(),
|
|
|
|
input);
|
2015-05-26 12:17:57 +00:00
|
|
|
break;
|
2015-05-26 10:31:55 +00:00
|
|
|
default:
|
|
|
|
UNREACHABLE();
|
|
|
|
break;
|
2015-05-21 13:02:18 +00:00
|
|
|
}
|
|
|
|
}
|
2015-05-26 10:31:55 +00:00
|
|
|
DCHECK_EQ(values.size(), effects.size());
|
|
|
|
DCHECK_EQ(values.size(), controls.size());
|
2015-09-15 11:19:02 +00:00
|
|
|
|
|
|
|
// Depending on whether the inlinee produces a value, we either replace value
|
|
|
|
// uses with said value or kill value uses if no value can be returned.
|
|
|
|
if (values.size() > 0) {
|
|
|
|
int const input_count = static_cast<int>(controls.size());
|
|
|
|
Node* control_output = jsgraph_->graph()->NewNode(
|
|
|
|
jsgraph_->common()->Merge(input_count), input_count, &controls.front());
|
|
|
|
values.push_back(control_output);
|
|
|
|
effects.push_back(control_output);
|
|
|
|
Node* value_output = jsgraph_->graph()->NewNode(
|
|
|
|
jsgraph_->common()->Phi(kMachAnyTagged, input_count),
|
|
|
|
static_cast<int>(values.size()), &values.front());
|
|
|
|
Node* effect_output = jsgraph_->graph()->NewNode(
|
|
|
|
jsgraph_->common()->EffectPhi(input_count),
|
|
|
|
static_cast<int>(effects.size()), &effects.front());
|
|
|
|
ReplaceWithValue(call, value_output, effect_output, control_output);
|
|
|
|
return Changed(value_output);
|
|
|
|
} else {
|
|
|
|
ReplaceWithValue(call, call, call, jsgraph_->Dead());
|
|
|
|
return Changed(call);
|
|
|
|
}
|
2014-08-20 13:05:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-11-12 08:50:51 +00:00
|
|
|
Node* JSInliner::CreateArtificialFrameState(Node* node, Node* outer_frame_state,
|
|
|
|
int parameter_count,
|
|
|
|
FrameStateType frame_state_type,
|
|
|
|
Handle<SharedFunctionInfo> shared) {
|
2015-06-23 07:17:07 +00:00
|
|
|
const FrameStateFunctionInfo* state_info =
|
|
|
|
jsgraph_->common()->CreateFrameStateFunctionInfo(
|
2015-11-12 08:50:51 +00:00
|
|
|
frame_state_type, parameter_count + 1, 0, shared,
|
[turbofan]: Add a context relaxation Reducer
In many cases, the context that TurboFan's ASTGraphBuilder or subsequent
reduction operations attaches to nodes does not need to be that exact
context, but rather only needs to be one with the same native context,
because it is used internally only to fetch the native context, e.g. for
creating and throwing exceptions.
This reducer recognizes common cases where the context that is specified
for a node can be relaxed to a canonical, less specific one. This
relaxed context can either be the enclosing function's context or a specific
Module or Script context that is explicitly created within the function.
This optimization is especially important for TurboFan-generated code stubs
which use context specialization and inlining to generate optimal code.
Without context relaxation, many extraneous moves are generated to pass
exactly the right context to internal functions like ToNumber and
AllocateHeapNumber, which only need the native context. By turning context
relaxation on, these moves disappear because all these common internal
context uses are unified to the context passed into the stub function, which
is typically already in the correct context register and remains there for
short stubs. It also eliminates the explicit use of a specialized context
constant in the code stub in these cases, which could cause memory leaks.
Review URL: https://codereview.chromium.org/1244583003
Cr-Commit-Position: refs/heads/master@{#29763}
2015-07-20 17:15:59 +00:00
|
|
|
CALL_MAINTAINS_NATIVE_CONTEXT);
|
2015-06-23 07:17:07 +00:00
|
|
|
|
2014-09-29 13:37:58 +00:00
|
|
|
const Operator* op = jsgraph_->common()->FrameState(
|
2015-06-23 07:17:07 +00:00
|
|
|
BailoutId(-1), OutputFrameStateCombine::Ignore(), state_info);
|
2014-09-18 08:56:52 +00:00
|
|
|
const Operator* op0 = jsgraph_->common()->StateValues(0);
|
|
|
|
Node* node0 = jsgraph_->graph()->NewNode(op0);
|
2015-10-22 12:21:39 +00:00
|
|
|
NodeVector params(local_zone_);
|
2015-11-12 08:50:51 +00:00
|
|
|
for (int parameter = 0; parameter < parameter_count + 1; ++parameter) {
|
|
|
|
params.push_back(node->InputAt(1 + parameter));
|
2014-09-18 08:56:52 +00:00
|
|
|
}
|
|
|
|
const Operator* op_param =
|
|
|
|
jsgraph_->common()->StateValues(static_cast<int>(params.size()));
|
|
|
|
Node* params_node = jsgraph_->graph()->NewNode(
|
|
|
|
op_param, static_cast<int>(params.size()), ¶ms.front());
|
2015-11-12 08:50:51 +00:00
|
|
|
return jsgraph_->graph()->NewNode(op, params_node, node0, node0,
|
|
|
|
jsgraph_->UndefinedConstant(),
|
|
|
|
node->InputAt(0), outer_frame_state);
|
2014-09-18 08:56:52 +00:00
|
|
|
}
|
|
|
|
|
2014-08-20 13:05:03 +00:00
|
|
|
|
2015-02-20 10:11:45 +00:00
|
|
|
Reduction JSInliner::Reduce(Node* node) {
|
2015-11-12 08:50:51 +00:00
|
|
|
if (!IrOpcode::IsInlineeOpcode(node->opcode())) return NoChange();
|
2015-02-20 10:11:45 +00:00
|
|
|
|
2015-11-12 08:50:51 +00:00
|
|
|
// This reducer can handle both normal function calls as well a constructor
|
|
|
|
// calls whenever the target is a constant function object, as follows:
|
|
|
|
// - JSCallFunction(target:constant, receiver, args...)
|
|
|
|
// - JSCallConstruct(target:constant, args..., new.target)
|
|
|
|
HeapObjectMatcher match(node->InputAt(0));
|
2015-10-07 12:18:21 +00:00
|
|
|
if (!match.HasValue() || !match.Value()->IsJSFunction()) return NoChange();
|
2015-08-31 08:24:52 +00:00
|
|
|
Handle<JSFunction> function = Handle<JSFunction>::cast(match.Value());
|
2015-10-07 12:18:21 +00:00
|
|
|
|
2015-11-12 08:50:51 +00:00
|
|
|
return ReduceJSCall(node, function);
|
2015-10-07 12:18:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-11-12 08:50:51 +00:00
|
|
|
Reduction JSInliner::ReduceJSCall(Node* node, Handle<JSFunction> function) {
|
|
|
|
DCHECK(IrOpcode::IsInlineeOpcode(node->opcode()));
|
|
|
|
JSCallAccessor call(node);
|
2015-02-20 10:11:45 +00:00
|
|
|
|
2015-10-07 11:43:20 +00:00
|
|
|
if (!function->shared()->IsInlineable()) {
|
|
|
|
// Function must be inlineable.
|
|
|
|
TRACE("Not inlining %s into %s because callee is not inlineable\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
|
|
|
return NoChange();
|
|
|
|
}
|
|
|
|
|
2015-11-24 17:16:40 +00:00
|
|
|
if (node->opcode() == IrOpcode::kJSCallConstruct &&
|
|
|
|
!function->IsConstructor()) {
|
|
|
|
// Constructor must be constructable.
|
|
|
|
TRACE("Not inlining %s into %s since constructor is not constructable.\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
|
|
|
return NoChange();
|
|
|
|
}
|
|
|
|
|
2015-11-04 14:08:46 +00:00
|
|
|
// Class constructors are callable, but [[Call]] will raise an exception.
|
|
|
|
// See ES6 section 9.2.1 [[Call]] ( thisArgument, argumentsList ).
|
|
|
|
if (IsClassConstructor(function->shared()->kind())) {
|
|
|
|
TRACE("Not inlining %s into %s because callee is classConstructor\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
|
|
|
return NoChange();
|
|
|
|
}
|
|
|
|
|
2015-07-20 14:53:28 +00:00
|
|
|
if (function->shared()->HasDebugInfo()) {
|
|
|
|
// Function contains break points.
|
|
|
|
TRACE("Not inlining %s into %s because callee may contain break points\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
|
|
|
return NoChange();
|
|
|
|
}
|
|
|
|
|
2015-06-30 11:38:19 +00:00
|
|
|
// Disallow cross native-context inlining for now. This means that all parts
|
|
|
|
// of the resulting code will operate on the same global object.
|
|
|
|
// This also prevents cross context leaks for asm.js code, where we could
|
|
|
|
// inline functions from a different context and hold on to that context (and
|
|
|
|
// closure) from the code object.
|
|
|
|
// TODO(turbofan): We might want to revisit this restriction later when we
|
|
|
|
// have a need for this, and we know how to model different native contexts
|
|
|
|
// in the same graph in a compositional way.
|
|
|
|
if (function->context()->native_context() !=
|
|
|
|
info_->context()->native_context()) {
|
|
|
|
TRACE("Not inlining %s into %s because of different native contexts\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
|
|
|
return NoChange();
|
|
|
|
}
|
|
|
|
|
2015-06-30 11:05:03 +00:00
|
|
|
// TODO(turbofan): TranslatedState::GetAdaptedArguments() currently relies on
|
|
|
|
// not inlining recursive functions. We might want to relax that at some
|
|
|
|
// point.
|
2015-10-30 06:58:56 +00:00
|
|
|
for (Node* frame_state = call.frame_state_after();
|
2015-06-30 11:05:03 +00:00
|
|
|
frame_state->opcode() == IrOpcode::kFrameState;
|
|
|
|
frame_state = frame_state->InputAt(kFrameStateOuterStateInput)) {
|
|
|
|
FrameStateInfo const& info = OpParameter<FrameStateInfo>(frame_state);
|
|
|
|
Handle<SharedFunctionInfo> shared_info;
|
|
|
|
if (info.shared_info().ToHandle(&shared_info) &&
|
|
|
|
*shared_info == function->shared()) {
|
|
|
|
TRACE("Not inlining %s into %s because call is recursive\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
|
|
|
return NoChange();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-10-15 12:01:52 +00:00
|
|
|
// TODO(turbofan): Inlining into a try-block is not yet supported.
|
|
|
|
if (NodeProperties::IsExceptionalCall(node)) {
|
|
|
|
TRACE("Not inlining %s into %s because of surrounding try-block\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
|
|
|
return NoChange();
|
|
|
|
}
|
|
|
|
|
2015-10-22 12:21:39 +00:00
|
|
|
Zone zone;
|
|
|
|
ParseInfo parse_info(&zone, function);
|
2015-03-24 14:17:05 +00:00
|
|
|
CompilationInfo info(&parse_info);
|
2015-10-14 12:20:39 +00:00
|
|
|
if (info_->is_deoptimization_enabled()) {
|
|
|
|
info.MarkAsDeoptimizationEnabled();
|
|
|
|
}
|
2015-02-17 10:30:54 +00:00
|
|
|
|
2015-09-09 10:24:17 +00:00
|
|
|
if (!Compiler::ParseAndAnalyze(info.parse_info())) {
|
|
|
|
TRACE("Not inlining %s into %s because parsing failed\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
|
|
|
if (info_->isolate()->has_pending_exception()) {
|
|
|
|
info_->isolate()->clear_pending_exception();
|
|
|
|
}
|
|
|
|
return NoChange();
|
|
|
|
}
|
|
|
|
|
2015-10-22 11:41:54 +00:00
|
|
|
// In strong mode, in case of too few arguments we need to throw a TypeError
|
|
|
|
// so we must not inline this call.
|
2015-11-12 08:50:51 +00:00
|
|
|
int parameter_count = info.literal()->parameter_count();
|
2015-10-22 11:41:54 +00:00
|
|
|
if (is_strong(info.language_mode()) &&
|
|
|
|
call.formal_arguments() < parameter_count) {
|
|
|
|
TRACE("Not inlining %s into %s because too few arguments for strong mode\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
|
|
|
return NoChange();
|
|
|
|
}
|
|
|
|
|
2015-09-09 10:24:17 +00:00
|
|
|
if (!Compiler::EnsureDeoptimizationSupport(&info)) {
|
|
|
|
TRACE("Not inlining %s into %s because deoptimization support failed\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
|
|
|
return NoChange();
|
|
|
|
}
|
2015-10-21 15:05:13 +00:00
|
|
|
// Remember that we inlined this function. This needs to be called right
|
|
|
|
// after we ensure deoptimization support so that the code flusher
|
|
|
|
// does not remove the code with the deoptimization support.
|
|
|
|
info_->AddInlinedFunction(info.shared_info());
|
|
|
|
|
|
|
|
// ----------------------------------------------------------------
|
|
|
|
// After this point, we've made a decision to inline this function.
|
|
|
|
// We shall not bailout from inlining if we got here.
|
2014-08-20 13:05:03 +00:00
|
|
|
|
2015-03-17 18:51:08 +00:00
|
|
|
TRACE("Inlining %s into %s\n",
|
|
|
|
function->shared()->DebugName()->ToCString().get(),
|
|
|
|
info_->shared_info()->DebugName()->ToCString().get());
|
2014-08-20 13:05:03 +00:00
|
|
|
|
2015-10-22 12:21:39 +00:00
|
|
|
// TODO(mstarzinger): We could use the temporary zone for the graph because
|
|
|
|
// nodes are copied. This however leads to Zone-Types being allocated in the
|
|
|
|
// wrong zone and makes the engine explode at high speeds. Explosion bad!
|
|
|
|
Graph graph(jsgraph_->zone());
|
2015-01-23 15:19:34 +00:00
|
|
|
JSGraph jsgraph(info.isolate(), &graph, jsgraph_->common(),
|
2015-10-16 12:38:46 +00:00
|
|
|
jsgraph_->javascript(), jsgraph_->simplified(),
|
|
|
|
jsgraph_->machine());
|
2015-07-06 12:56:05 +00:00
|
|
|
AstGraphBuilder graph_builder(local_zone_, &info, &jsgraph);
|
|
|
|
graph_builder.CreateGraph(false);
|
2014-08-20 13:05:03 +00:00
|
|
|
|
2015-10-22 12:21:39 +00:00
|
|
|
CopyVisitor visitor(&graph, jsgraph_->graph(), &zone);
|
2014-09-12 11:06:37 +00:00
|
|
|
visitor.CopyGraph();
|
2014-08-20 13:05:03 +00:00
|
|
|
|
2015-05-21 13:02:18 +00:00
|
|
|
Node* start = visitor.GetCopy(graph.start());
|
|
|
|
Node* end = visitor.GetCopy(graph.end());
|
2015-10-30 06:58:56 +00:00
|
|
|
Node* frame_state = call.frame_state_after();
|
2015-11-19 12:47:29 +00:00
|
|
|
Node* new_target = jsgraph_->UndefinedConstant();
|
2014-09-18 08:56:52 +00:00
|
|
|
|
2015-11-12 08:50:51 +00:00
|
|
|
// Insert nodes around the call that model the behavior required for a
|
|
|
|
// constructor dispatch and turn the constructor call into a regular call.
|
|
|
|
// This models the behavior usually accomplished by our {JSConstructStub}.
|
|
|
|
// Note that the context has to be the callers context (input to call node).
|
2015-11-24 17:16:40 +00:00
|
|
|
// TODO(4544): Once we support inlining builtins, make sure no implicit
|
|
|
|
// receiver is created for builtins that don't expect any.
|
2015-11-12 08:50:51 +00:00
|
|
|
if (node->opcode() == IrOpcode::kJSCallConstruct) {
|
|
|
|
Node* effect = NodeProperties::GetEffectInput(node);
|
|
|
|
Node* context = NodeProperties::GetContextInput(node);
|
2015-11-13 11:53:16 +00:00
|
|
|
Node* create = jsgraph_->graph()->NewNode(jsgraph_->javascript()->Create(),
|
|
|
|
call.target(), call.new_target(),
|
2015-11-13 14:05:36 +00:00
|
|
|
context, frame_state, effect);
|
2015-11-12 08:50:51 +00:00
|
|
|
NodeProperties::ReplaceEffectInput(node, create);
|
|
|
|
// TODO(4544): For derived constructors we should not allocate an implicit
|
|
|
|
// receiver and also the return value should not be checked afterwards.
|
|
|
|
CHECK(!IsClassConstructor(function->shared()->kind()));
|
|
|
|
// Swizzle the inputs of the {JSCallConstruct} node to look like inputs to
|
|
|
|
// any {JSCallFunction} node so that the rest of the inlining machinery
|
|
|
|
// behaves as if we were dealing with a regular function invocation.
|
2015-11-19 12:47:29 +00:00
|
|
|
new_target = call.new_target(); // Retrieve new target value input.
|
|
|
|
node->RemoveInput(call.formal_arguments() + 1); // Drop new target.
|
2015-11-12 08:50:51 +00:00
|
|
|
node->InsertInput(jsgraph_->graph()->zone(), 1, create);
|
|
|
|
// Insert a check of the return value to determine whether the return value
|
|
|
|
// or the implicit receiver should be selected as a result of the call.
|
|
|
|
Node* check = jsgraph_->graph()->NewNode(
|
|
|
|
jsgraph_->javascript()->CallRuntime(Runtime::kInlineIsSpecObject, 1),
|
|
|
|
node, context, node, start);
|
|
|
|
Node* select = jsgraph_->graph()->NewNode(
|
|
|
|
jsgraph_->common()->Select(kMachAnyTagged), check, node, create);
|
|
|
|
NodeProperties::ReplaceUses(node, select, check, node, node);
|
|
|
|
NodeProperties::ReplaceValueInput(select, node, 1);
|
|
|
|
NodeProperties::ReplaceValueInput(check, node, 0);
|
|
|
|
NodeProperties::ReplaceEffectInput(check, node);
|
|
|
|
// Insert a construct stub frame into the chain of frame states. This will
|
|
|
|
// reconstruct the proper frame when deoptimizing within the constructor.
|
|
|
|
frame_state = CreateArtificialFrameState(
|
|
|
|
node, frame_state, call.formal_arguments(),
|
|
|
|
FrameStateType::kConstructStub, info.shared_info());
|
|
|
|
}
|
|
|
|
|
|
|
|
// The inlinee specializes to the context from the JSFunction object.
|
|
|
|
// TODO(turbofan): We might want to load the context from the JSFunction at
|
|
|
|
// runtime in case we only know the SharedFunctionInfo once we have dynamic
|
|
|
|
// type feedback in the compiler.
|
|
|
|
Node* context = jsgraph_->Constant(handle(function->context()));
|
|
|
|
|
2015-10-27 12:13:32 +00:00
|
|
|
// Insert a JSConvertReceiver node for sloppy callees. Note that the context
|
2015-10-30 06:58:56 +00:00
|
|
|
// passed into this node has to be the callees context (loaded above). Note
|
|
|
|
// that the frame state passed to the JSConvertReceiver must be the frame
|
|
|
|
// state _before_ the call; it is not necessary to fiddle with the receiver
|
|
|
|
// in that frame state tho, as the conversion of the receiver can be repeated
|
|
|
|
// any number of times, it's not observable.
|
2015-11-12 08:50:51 +00:00
|
|
|
if (node->opcode() == IrOpcode::kJSCallFunction &&
|
|
|
|
is_sloppy(info.language_mode()) && !function->shared()->native()) {
|
2015-10-27 12:13:32 +00:00
|
|
|
const CallFunctionParameters& p = CallFunctionParametersOf(node->op());
|
|
|
|
Node* effect = NodeProperties::GetEffectInput(node);
|
|
|
|
Node* convert = jsgraph_->graph()->NewNode(
|
|
|
|
jsgraph_->javascript()->ConvertReceiver(p.convert_mode()),
|
2015-10-30 06:58:56 +00:00
|
|
|
call.receiver(), context, call.frame_state_before(), effect, start);
|
2015-10-27 12:13:32 +00:00
|
|
|
NodeProperties::ReplaceValueInput(node, convert, 1);
|
|
|
|
NodeProperties::ReplaceEffectInput(node, convert);
|
|
|
|
}
|
|
|
|
|
2015-10-30 06:58:56 +00:00
|
|
|
// Insert argument adaptor frame if required. The callees formal parameter
|
2015-11-19 12:47:29 +00:00
|
|
|
// count (i.e. value outputs of start node minus target, receiver, new target,
|
|
|
|
// arguments count and context) have to match the number of arguments passed
|
|
|
|
// to the call.
|
|
|
|
DCHECK_EQ(parameter_count, start->op()->ValueOutputCount() - 5);
|
2015-10-30 06:58:56 +00:00
|
|
|
if (call.formal_arguments() != parameter_count) {
|
2015-11-12 08:50:51 +00:00
|
|
|
frame_state = CreateArtificialFrameState(
|
|
|
|
node, frame_state, call.formal_arguments(),
|
|
|
|
FrameStateType::kArgumentsAdaptor, info.shared_info());
|
2015-10-30 06:58:56 +00:00
|
|
|
}
|
|
|
|
|
2015-11-19 12:47:29 +00:00
|
|
|
return InlineCall(node, new_target, context, frame_state, start, end);
|
2014-08-20 13:05:03 +00:00
|
|
|
}
|
2014-10-20 07:56:50 +00:00
|
|
|
|
2015-01-26 09:05:47 +00:00
|
|
|
} // namespace compiler
|
|
|
|
} // namespace internal
|
|
|
|
} // namespace v8
|