AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
d99a1b950e
v8/test/inspector/debugger/stepping-tail-call.js

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

82 lines
3.2 KiB
JavaScript
Raw Normal View History

[debugger] tuned StepNext and StepOut at return position Proposed behaviour: - StepNext at return position go into next function call (no changes with current behavior, but implemented in v8::Debug instead of hack on inspector side); - StepOut at return position go into next non-current function call. We need this to have better stepping in cases with native functions, blackboxed functions and/or different embedder calls (e.g. event listeners). New behavior could be illustrated with two examples (for more see stepping-with-natives-and-frameworks test): - let's assume that we've blackboxed callAll function, this function just takes its arguments and call one after another: var foo = () => 1; callAll(foo, foo, () => 2); If we break inside of first call of function foo. Then on.. ..StepNext - we're able to reach second call of function foo, ..StepOut - we're able to reach () => 2 call. - let's consider case with native function: [1,2,3].map(x => x * 2) If we break inside of first callback call, then with StepNext we can iterate through all calls of callback, with StepOut we go to next statement after .map call. Implementation details: - when we request break we schedule step-in function call for any step action at return position and for step-in at any position, - when we request StepOut at return position - we mark current function as needed-to-be-ignored inside of PrepareStepIn(function) call, - when we request StepOut at not return position - we set break at return position and ask debugger to just repeat last step action on next stepping-related break. Design doc: https://docs.google.com/document/d/1ihXHOIhP_q-fJCA0e2EiXz_Zr3B08KMjaPifcaqZ60Q/edit BUG=v8:6118,chromium:583193 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2758483002 Cr-Commit-Position: refs/heads/master@{#44028}
2017-03-22 14:16:18 +00:00
// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
[inspector] Refactor protocol-test.js This refactoring makes it easier to write advanced tests and gives full control over what's happening to the test code. It also forces description for every test. BUG=none Review-Url: https://codereview.chromium.org/2891213002 Cr-Commit-Position: refs/heads/master@{#45412}
2017-05-19 00:35:45 +00:00
let {session, contextGroup, Protocol} = InspectorTest.start('Checks stepping over tail calls.');
[debugger] tuned StepNext and StepOut at return position Proposed behaviour: - StepNext at return position go into next function call (no changes with current behavior, but implemented in v8::Debug instead of hack on inspector side); - StepOut at return position go into next non-current function call. We need this to have better stepping in cases with native functions, blackboxed functions and/or different embedder calls (e.g. event listeners). New behavior could be illustrated with two examples (for more see stepping-with-natives-and-frameworks test): - let's assume that we've blackboxed callAll function, this function just takes its arguments and call one after another: var foo = () => 1; callAll(foo, foo, () => 2); If we break inside of first call of function foo. Then on.. ..StepNext - we're able to reach second call of function foo, ..StepOut - we're able to reach () => 2 call. - let's consider case with native function: [1,2,3].map(x => x * 2) If we break inside of first callback call, then with StepNext we can iterate through all calls of callback, with StepOut we go to next statement after .map call. Implementation details: - when we request break we schedule step-in function call for any step action at return position and for step-in at any position, - when we request StepOut at return position - we mark current function as needed-to-be-ignored inside of PrepareStepIn(function) call, - when we request StepOut at not return position - we set break at return position and ask debugger to just repeat last step action on next stepping-related break. Design doc: https://docs.google.com/document/d/1ihXHOIhP_q-fJCA0e2EiXz_Zr3B08KMjaPifcaqZ60Q/edit BUG=v8:6118,chromium:583193 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2758483002 Cr-Commit-Position: refs/heads/master@{#44028}
2017-03-22 14:16:18 +00:00
[inspector] Refactor protocol-test.js This refactoring makes it easier to write advanced tests and gives full control over what's happening to the test code. It also forces description for every test. BUG=none Review-Url: https://codereview.chromium.org/2891213002 Cr-Commit-Position: refs/heads/master@{#45412}
2017-05-19 00:35:45 +00:00
session.setupScriptMap();
[inspector] follow up for e27d18c94337f908d75fdccb4c5263180dbb1511 - renamed inspector-test methods, - tuned comment in debug.h BUG=v8:6118 TBR=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2766283002 Cr-Commit-Position: refs/heads/master@{#44043}
2017-03-22 18:07:12 +00:00
InspectorTest.logProtocolCommandCalls('Debugger.pause');
InspectorTest.logProtocolCommandCalls('Debugger.stepInto');
InspectorTest.logProtocolCommandCalls('Debugger.stepOver');
InspectorTest.logProtocolCommandCalls('Debugger.stepOut');
InspectorTest.logProtocolCommandCalls('Debugger.resume');
[debugger] tuned StepNext and StepOut at return position Proposed behaviour: - StepNext at return position go into next function call (no changes with current behavior, but implemented in v8::Debug instead of hack on inspector side); - StepOut at return position go into next non-current function call. We need this to have better stepping in cases with native functions, blackboxed functions and/or different embedder calls (e.g. event listeners). New behavior could be illustrated with two examples (for more see stepping-with-natives-and-frameworks test): - let's assume that we've blackboxed callAll function, this function just takes its arguments and call one after another: var foo = () => 1; callAll(foo, foo, () => 2); If we break inside of first call of function foo. Then on.. ..StepNext - we're able to reach second call of function foo, ..StepOut - we're able to reach () => 2 call. - let's consider case with native function: [1,2,3].map(x => x * 2) If we break inside of first callback call, then with StepNext we can iterate through all calls of callback, with StepOut we go to next statement after .map call. Implementation details: - when we request break we schedule step-in function call for any step action at return position and for step-in at any position, - when we request StepOut at return position - we mark current function as needed-to-be-ignored inside of PrepareStepIn(function) call, - when we request StepOut at not return position - we set break at return position and ask debugger to just repeat last step action on next stepping-related break. Design doc: https://docs.google.com/document/d/1ihXHOIhP_q-fJCA0e2EiXz_Zr3B08KMjaPifcaqZ60Q/edit BUG=v8:6118,chromium:583193 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2758483002 Cr-Commit-Position: refs/heads/master@{#44028}
2017-03-22 14:16:18 +00:00
let source = `
function f(x) {
if (x == 2) debugger;
if (x-- > 0) return f(x);
}
f(5);
`;
Protocol.Debugger.enable();
Protocol.Debugger.setBlackboxPatterns({patterns: ['framework\.js']});
InspectorTest.runAsyncTestSuite([
async function testStepOver() {
Protocol.Runtime.evaluate({expression: source});
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOver();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOver();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOver();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOver();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOver();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOver();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOver();
await logPauseLocation(await Protocol.Debugger.oncePaused());
await Protocol.Debugger.resume();
},
async function testStepOut() {
Protocol.Runtime.evaluate({expression: source});
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOut();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOut();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOut();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOut();
await logPauseLocation(await Protocol.Debugger.oncePaused());
await Protocol.Debugger.resume();
},
async function testStepOutFromReturn() {
Protocol.Runtime.evaluate({expression: source});
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOver();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOver();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOut();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOut();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOut();
await logPauseLocation(await Protocol.Debugger.oncePaused());
Protocol.Debugger.stepOut();
await logPauseLocation(await Protocol.Debugger.oncePaused());
await Protocol.Debugger.resume();
}
]);
function logPauseLocation(message) {
[inspector] Refactor protocol-test.js This refactoring makes it easier to write advanced tests and gives full control over what's happening to the test code. It also forces description for every test. BUG=none Review-Url: https://codereview.chromium.org/2891213002 Cr-Commit-Position: refs/heads/master@{#45412}
2017-05-19 00:35:45 +00:00
session.logCallFrames(message.params.callFrames);
return session.logSourceLocation(message.params.callFrames[0].location);
[debugger] tuned StepNext and StepOut at return position Proposed behaviour: - StepNext at return position go into next function call (no changes with current behavior, but implemented in v8::Debug instead of hack on inspector side); - StepOut at return position go into next non-current function call. We need this to have better stepping in cases with native functions, blackboxed functions and/or different embedder calls (e.g. event listeners). New behavior could be illustrated with two examples (for more see stepping-with-natives-and-frameworks test): - let's assume that we've blackboxed callAll function, this function just takes its arguments and call one after another: var foo = () => 1; callAll(foo, foo, () => 2); If we break inside of first call of function foo. Then on.. ..StepNext - we're able to reach second call of function foo, ..StepOut - we're able to reach () => 2 call. - let's consider case with native function: [1,2,3].map(x => x * 2) If we break inside of first callback call, then with StepNext we can iterate through all calls of callback, with StepOut we go to next statement after .map call. Implementation details: - when we request break we schedule step-in function call for any step action at return position and for step-in at any position, - when we request StepOut at return position - we mark current function as needed-to-be-ignored inside of PrepareStepIn(function) call, - when we request StepOut at not return position - we set break at return position and ask debugger to just repeat last step action on next stepping-related break. Design doc: https://docs.google.com/document/d/1ihXHOIhP_q-fJCA0e2EiXz_Zr3B08KMjaPifcaqZ60Q/edit BUG=v8:6118,chromium:583193 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2758483002 Cr-Commit-Position: refs/heads/master@{#44028}
2017-03-22 14:16:18 +00:00
}
Reference in New Issue Copy Permalink