2017-12-20 12:02:45 +00:00
|
|
|
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file.
|
|
|
|
"use strict";
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* A thin wrapper around shell's 'read' function showing a file name on error.
|
|
|
|
*/
|
|
|
|
function readFile(fileName) {
|
|
|
|
try {
|
|
|
|
return read(fileName);
|
|
|
|
} catch (e) {
|
|
|
|
console.log(fileName + ': ' + (e.message || e));
|
|
|
|
throw e;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// ===========================================================================
|
|
|
|
|
|
|
|
// This is the only true formatting, why? For an international audience the
|
|
|
|
// confusion between the decimal and thousands separator is big (alternating
|
|
|
|
// between comma "," vs dot "."). The Swiss formatting uses "'" as a thousands
|
|
|
|
// separator, dropping most of that confusion.
|
2018-06-20 12:08:47 +00:00
|
|
|
const numberFormat = new Intl.NumberFormat('de-CH', {
|
2017-12-20 12:02:45 +00:00
|
|
|
maximumFractionDigits: 2,
|
|
|
|
minimumFractionDigits: 2,
|
|
|
|
});
|
|
|
|
|
|
|
|
function formatNumber(value) {
|
2018-06-20 12:08:47 +00:00
|
|
|
return numberFormat.format(value);
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
function BYTES(bytes, total) {
|
|
|
|
let units = ['B ', 'kB', 'mB', 'gB'];
|
|
|
|
let unitIndex = 0;
|
|
|
|
let value = bytes;
|
|
|
|
while (value > 1000 && unitIndex < units.length) {
|
|
|
|
value /= 1000;
|
|
|
|
unitIndex++;
|
|
|
|
}
|
|
|
|
let result = formatNumber(value).padStart(10) + ' ' + units[unitIndex];
|
|
|
|
if (total !== void 0 && total != 0) {
|
|
|
|
result += PERCENT(bytes, total).padStart(5);
|
|
|
|
}
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
function PERCENT(value, total) {
|
|
|
|
return Math.round(value / total * 100) + "%";
|
|
|
|
}
|
|
|
|
|
|
|
|
function timestampMin(list) {
|
|
|
|
let result = -1;
|
|
|
|
list.forEach(timestamp => {
|
|
|
|
if (result === -1) {
|
|
|
|
result = timestamp;
|
|
|
|
} else if (timestamp != -1) {
|
|
|
|
result = Math.min(result, timestamp);
|
|
|
|
}
|
|
|
|
});
|
|
|
|
return Math.round(result);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// ===========================================================================
|
|
|
|
class Script {
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
constructor(id) {
|
2017-12-20 12:02:45 +00:00
|
|
|
if (id === void 0 || id <= 0) {
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
throw new Error(`Invalid id=${id} for script`);
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
2018-06-27 08:50:49 +00:00
|
|
|
this.file = '';
|
|
|
|
this.id = id;
|
|
|
|
|
|
|
|
this.isNative = false;
|
2017-12-20 12:02:45 +00:00
|
|
|
this.isEval = false;
|
2018-06-27 08:50:49 +00:00
|
|
|
this.isBackgroundCompiled = false;
|
|
|
|
this.isDeserialized = false;
|
|
|
|
|
2017-12-20 12:02:45 +00:00
|
|
|
this.funktions = [];
|
|
|
|
this.metrics = new Map();
|
|
|
|
this.maxNestingLevel = 0;
|
|
|
|
|
|
|
|
this.firstEvent = -1;
|
|
|
|
this.firstParseEvent = -1;
|
|
|
|
this.lastParseEvent = -1;
|
|
|
|
this.executionTimestamp = -1;
|
|
|
|
this.compileTimestamp = -1;
|
|
|
|
this.lastEvent = -1;
|
|
|
|
|
|
|
|
this.compileTime = -0.0;
|
|
|
|
|
|
|
|
this.width = 0;
|
2018-06-20 12:08:47 +00:00
|
|
|
this.bytesTotal = -1;
|
2017-12-20 12:02:45 +00:00
|
|
|
this.ownBytes = -1;
|
|
|
|
this.finalized = false;
|
|
|
|
this.summary = '';
|
|
|
|
}
|
|
|
|
|
|
|
|
setFile(name) {
|
|
|
|
this.file = name;
|
|
|
|
this.isNative = name.startsWith('native ');
|
|
|
|
}
|
|
|
|
|
|
|
|
isEmpty() {
|
|
|
|
return this.funktions.length === 0
|
|
|
|
}
|
|
|
|
|
|
|
|
funktionAtPosition(start) {
|
|
|
|
if (start === 0) throw "position 0 is reserved for the script";
|
|
|
|
if (this.finalized) throw 'Finalized script has no source position!';
|
|
|
|
return this.funktions[start];
|
|
|
|
}
|
|
|
|
|
|
|
|
addMissingFunktions(list) {
|
|
|
|
if (this.finalized) throw 'script is finalized!';
|
|
|
|
list.forEach(fn => {
|
|
|
|
if (this.funktions[fn.start] === void 0) {
|
|
|
|
this.addFunktion(fn);
|
|
|
|
}
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
addFunktion(fn) {
|
|
|
|
if (this.finalized) throw 'script is finalized!';
|
|
|
|
if (fn.start === void 0) throw "Funktion has no start position";
|
|
|
|
if (this.funktions[fn.start] !== void 0) {
|
|
|
|
fn.print();
|
|
|
|
throw "adding same function twice to script";
|
|
|
|
}
|
|
|
|
this.funktions[fn.start] = fn;
|
|
|
|
}
|
|
|
|
|
|
|
|
finalize() {
|
|
|
|
this.finalized = true;
|
|
|
|
// Compact funktions as we no longer need access via start byte position.
|
|
|
|
this.funktions = this.funktions.filter(each => true);
|
|
|
|
let parent = null;
|
|
|
|
let maxNesting = 0;
|
|
|
|
// Iterate over the Funktions in byte position order.
|
|
|
|
this.funktions.forEach(fn => {
|
|
|
|
fn.fromEval = this.isEval;
|
|
|
|
if (parent === null) {
|
|
|
|
parent = fn;
|
|
|
|
} else {
|
|
|
|
// Walk up the nested chain of Funktions to find the parent.
|
|
|
|
while (parent !== null && !fn.isNestedIn(parent)) {
|
|
|
|
parent = parent.parent;
|
|
|
|
}
|
|
|
|
fn.parent = parent;
|
|
|
|
if (parent) {
|
|
|
|
maxNesting = Math.max(maxNesting, parent.addNestedFunktion(fn));
|
|
|
|
}
|
|
|
|
parent = fn;
|
|
|
|
}
|
|
|
|
this.firstParseEvent = this.firstParseEvent === -1 ?
|
|
|
|
fn.getFirstParseEvent() :
|
|
|
|
Math.min(this.firstParseEvent, fn.getFirstParseEvent());
|
|
|
|
this.lastParseEvent =
|
|
|
|
Math.max(this.lastParseEvent, fn.getLastParseEvent());
|
|
|
|
fn.getFirstEvent();
|
|
|
|
if (Number.isNaN(this.lastEvent)) throw "Invalid lastEvent";
|
|
|
|
this.lastEvent = Math.max(this.lastEvent, fn.getLastEvent());
|
|
|
|
if (Number.isNaN(this.lastEvent)) throw "Invalid lastEvent";
|
|
|
|
});
|
|
|
|
this.maxNestingLevel = maxNesting;
|
|
|
|
this.getFirstEvent();
|
|
|
|
}
|
|
|
|
|
|
|
|
print() {
|
|
|
|
console.log(this.toString());
|
|
|
|
}
|
|
|
|
|
|
|
|
toString() {
|
|
|
|
let str = `SCRIPT id=${this.id} file=${this.file}\n` +
|
|
|
|
`functions[${this.funktions.length}]:`;
|
|
|
|
this.funktions.forEach(fn => str += fn.toString());
|
|
|
|
return str;
|
|
|
|
}
|
|
|
|
|
|
|
|
getBytes() {
|
|
|
|
return this.bytesTotal;
|
|
|
|
}
|
|
|
|
|
|
|
|
getOwnBytes() {
|
|
|
|
if (this.ownBytes === -1) {
|
2018-06-27 08:50:49 +00:00
|
|
|
if (this.getBytes() === -1) {
|
|
|
|
if (this.isDeserialized || this.isEval) {
|
|
|
|
return this.ownBytes = 0;
|
|
|
|
}
|
|
|
|
}
|
2017-12-20 12:02:45 +00:00
|
|
|
this.ownBytes = this.funktions.reduce(
|
2018-06-20 12:08:47 +00:00
|
|
|
(bytes, each) => bytes - (each.isToplevel() ? each.getBytes() : 0),
|
2017-12-20 12:02:45 +00:00
|
|
|
this.getBytes());
|
|
|
|
if (this.ownBytes < 0) throw "Own bytes must be positive";
|
|
|
|
}
|
|
|
|
return this.ownBytes;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Also see Funktion.prototype.getMetricBytes
|
|
|
|
getMetricBytes(name) {
|
|
|
|
if (name == 'lazyCompileTimestamp') return this.getOwnBytes();
|
|
|
|
return this.getBytes();
|
|
|
|
}
|
|
|
|
|
|
|
|
getMetricTime(name) {
|
|
|
|
return this[name];
|
|
|
|
}
|
|
|
|
|
|
|
|
forEach(fn) {
|
|
|
|
fn(this);
|
|
|
|
this.funktions.forEach(fn);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Container helper for TotalScript / Script.
|
|
|
|
getScripts() {
|
|
|
|
return [this];
|
|
|
|
}
|
|
|
|
|
|
|
|
calculateMetrics(printSummary) {
|
|
|
|
let log = (str) => this.summary += str + '\n';
|
|
|
|
log("SCRIPT: " + this.id);
|
|
|
|
let all = this.funktions;
|
|
|
|
if (all.length === 0) return;
|
|
|
|
|
|
|
|
let nofFunktions = all.length;
|
|
|
|
let ownBytesSum = list => {
|
|
|
|
return list.reduce((bytes, each) => bytes + each.getOwnBytes(), 0)
|
|
|
|
};
|
|
|
|
|
|
|
|
let info = (name, funktions) => {
|
|
|
|
let ownBytes = ownBytesSum(funktions);
|
|
|
|
let nofPercent = Math.round(funktions.length / nofFunktions * 100);
|
|
|
|
let value = (funktions.length + "").padStart(6) +
|
|
|
|
(nofPercent + "%").padStart(5) +
|
|
|
|
BYTES(ownBytes, this.bytesTotal).padStart(10);
|
|
|
|
log((" - " + name).padEnd(20) + value);
|
|
|
|
this.metrics.set(name + "-bytes", ownBytes);
|
|
|
|
this.metrics.set(name + "-count", funktions.length);
|
|
|
|
this.metrics.set(name + "-count-percent", nofPercent);
|
|
|
|
this.metrics.set(name + "-bytes-percent",
|
|
|
|
Math.round(ownBytes / this.bytesTotal * 100));
|
|
|
|
};
|
|
|
|
|
|
|
|
log(" - file: " + this.file);
|
2018-06-27 08:50:49 +00:00
|
|
|
log(' - details: ' +
|
|
|
|
'isEval=' + this.isEval + ' deserialized=' + this.isDeserialized +
|
|
|
|
' streamed=' + this.isBackgroundCompiled);
|
2017-12-20 12:02:45 +00:00
|
|
|
info("scripts", this.getScripts());
|
|
|
|
info("functions", all);
|
|
|
|
info("toplevel fn", all.filter(each => each.isToplevel()));
|
|
|
|
info("preparsed", all.filter(each => each.preparseTime > 0));
|
|
|
|
|
|
|
|
|
|
|
|
info("fully parsed", all.filter(each => each.parseTime > 0));
|
|
|
|
// info("fn parsed", all.filter(each => each.parse2Time > 0));
|
|
|
|
// info("resolved", all.filter(each => each.resolutionTime > 0));
|
|
|
|
info("executed", all.filter(each => each.executionTimestamp > 0));
|
|
|
|
info("forEval", all.filter(each => each.fromEval));
|
|
|
|
info("lazy compiled", all.filter(each => each.lazyCompileTimestamp > 0));
|
|
|
|
info("eager compiled", all.filter(each => each.compileTimestamp > 0));
|
|
|
|
|
|
|
|
let parsingCost = new ExecutionCost('parse', all,
|
|
|
|
each => each.parseTime);
|
|
|
|
parsingCost.setMetrics(this.metrics);
|
|
|
|
log(parsingCost.toString())
|
|
|
|
|
|
|
|
let preParsingCost = new ExecutionCost('preparse', all,
|
|
|
|
each => each.preparseTime);
|
|
|
|
preParsingCost.setMetrics(this.metrics);
|
|
|
|
log(preParsingCost.toString())
|
|
|
|
|
|
|
|
let resolutionCost = new ExecutionCost('resolution', all,
|
|
|
|
each => each.resolutionTime);
|
|
|
|
resolutionCost.setMetrics(this.metrics);
|
|
|
|
log(resolutionCost.toString())
|
|
|
|
|
|
|
|
let nesting = new NestingDistribution(all);
|
|
|
|
nesting.setMetrics(this.metrics);
|
|
|
|
log(nesting.toString())
|
|
|
|
|
|
|
|
if (printSummary) console.log(this.summary);
|
|
|
|
}
|
|
|
|
|
|
|
|
getAccumulatedTimeMetrics(metrics, start, end, delta, incremental = false) {
|
|
|
|
// Returns an array of the following format:
|
|
|
|
// [ [start, acc(metric0, start, start), acc(metric1, ...), ...],
|
|
|
|
// [start+delta, acc(metric0, start, start+delta), ...],
|
|
|
|
// [start+delta*2, acc(metric0, start, start+delta*2), ...],
|
|
|
|
// ...
|
|
|
|
// ]
|
|
|
|
const timespan = end - start;
|
|
|
|
const kSteps = Math.ceil(timespan / delta);
|
|
|
|
// To reduce the time spent iterating over the funktions of this script
|
|
|
|
// we iterate once over all funktions and add the metric changes to each
|
|
|
|
// timepoint:
|
|
|
|
// [ [0, 300, ...], [1, 15, ...], [2, 100, ...], [3, 0, ...] ... ]
|
|
|
|
// In a second step we accumulate all values:
|
|
|
|
// [ [0, 300, ...], [1, 315, ...], [2, 415, ...], [3, 415, ...] ... ]
|
|
|
|
//
|
|
|
|
// To limit the number of data points required in the resulting graphs,
|
|
|
|
// only the rows for entries with actual changes are created.
|
|
|
|
|
|
|
|
const metricProperties = ["time"];
|
|
|
|
metrics.forEach(each => {
|
|
|
|
metricProperties.push(each + 'Timestamp');
|
|
|
|
metricProperties.push(each + 'Time');
|
|
|
|
});
|
|
|
|
// Create a packed {rowTemplate} which is copied later-on.
|
|
|
|
let indexToTime = (t) => (start + t * delta) / kSecondsToMillis;
|
|
|
|
let rowTemplate = [indexToTime(0)];
|
|
|
|
for (let i = 1; i < metricProperties.length; i++) rowTemplate.push(0.0);
|
|
|
|
// Create rows with 0-time entry.
|
|
|
|
let rows = new Array(rowTemplate.slice());
|
|
|
|
for (let t = 1; t <= kSteps; t++) rows.push(null);
|
|
|
|
// Create the real metric's property name on the Funktion object.
|
|
|
|
// Add the increments of each Funktion's metric to the result.
|
|
|
|
this.forEach(funktionOrScript => {
|
|
|
|
// Iterate over the Funktion's metric names, position 0 is the time.
|
|
|
|
for (let i = 1; i < metricProperties.length; i += 2) {
|
|
|
|
let property = metricProperties[i];
|
|
|
|
let timestamp = funktionOrScript[property];
|
|
|
|
if (timestamp === void 0) continue;
|
|
|
|
if (timestamp < 0 || end < timestamp) continue;
|
|
|
|
let index = Math.floor(timestamp / delta);
|
|
|
|
let row = rows[index];
|
|
|
|
if (row === null) {
|
|
|
|
// Add a new row if it didn't exist,
|
|
|
|
row = rows[index] = rowTemplate.slice();
|
|
|
|
// .. add the time offset.
|
|
|
|
row[0] = indexToTime(index);
|
|
|
|
}
|
|
|
|
// Add the metric value.
|
|
|
|
row[i] += funktionOrScript.getMetricBytes(property);
|
|
|
|
let timeMetricName = metricProperties[i + 1];
|
|
|
|
row[i + 1] += funktionOrScript.getMetricTime(timeMetricName);
|
|
|
|
}
|
|
|
|
});
|
|
|
|
// Create a packed array again with only the valid entries.
|
|
|
|
// Accumulate the incremental results by adding the metric values from
|
|
|
|
// the previous time window.
|
|
|
|
let previous = rows[0];
|
|
|
|
let result = [previous];
|
|
|
|
for (let t = 1; t < rows.length; t++) {
|
|
|
|
let current = rows[t];
|
|
|
|
if (current === null) {
|
|
|
|
// Ensure a zero data-point after each non-zero point.
|
|
|
|
if (incremental && rows[t - 1] !== null) {
|
|
|
|
let duplicate = rowTemplate.slice();
|
|
|
|
duplicate[0] = indexToTime(t);
|
|
|
|
result.push(duplicate);
|
|
|
|
}
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (!incremental) {
|
|
|
|
// Skip i==0 where the corresponding time value in seconds is.
|
|
|
|
for (let i = 1; i < metricProperties.length; i++) {
|
|
|
|
current[i] += previous[i];
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Make sure we have a data-point in time right before the current one.
|
|
|
|
if (rows[t - 1] === null) {
|
|
|
|
let duplicate = (incremental ? rowTemplate : previous).slice();
|
|
|
|
duplicate[0] = indexToTime(t - 1);
|
|
|
|
result.push(duplicate);
|
|
|
|
}
|
|
|
|
previous = current;
|
|
|
|
result.push(current);
|
|
|
|
}
|
|
|
|
// Make sure there is an entry at the last position to make sure all graphs
|
|
|
|
// have the same width.
|
|
|
|
const lastIndex = rows.length - 1;
|
|
|
|
if (rows[lastIndex] === null) {
|
|
|
|
let duplicate = previous.slice();
|
|
|
|
duplicate[0] = indexToTime(lastIndex);
|
|
|
|
result.push(duplicate);
|
|
|
|
}
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
getFunktionsAtTime(time, delta, metric) {
|
|
|
|
// Returns a list of Funktions whose metric changed in the
|
|
|
|
// [time-delta, time+delta] range.
|
|
|
|
return this.funktions.filter(
|
|
|
|
funktion => funktion.didMetricChange(time, delta, metric));
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
getFirstEvent() {
|
|
|
|
if (this.firstEvent === -1) {
|
|
|
|
// TODO(cbruni): add support for network request timestanp
|
|
|
|
this.firstEvent = this.firstParseEvent;
|
|
|
|
}
|
|
|
|
return this.firstEvent;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
class TotalScript extends Script {
|
|
|
|
constructor() {
|
|
|
|
super('all files', 'all files');
|
|
|
|
this.scripts = [];
|
|
|
|
}
|
|
|
|
|
|
|
|
addAllFunktions(script) {
|
|
|
|
// funktions is indexed by byte offset and as such not packed. Add every
|
|
|
|
// Funktion one by one to keep this.funktions packed.
|
|
|
|
script.funktions.forEach(fn => this.funktions.push(fn));
|
|
|
|
this.scripts.push(script);
|
|
|
|
this.bytesTotal += script.bytesTotal;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Iterate over all Scripts and nested Funktions.
|
|
|
|
forEach(fn) {
|
|
|
|
this.scripts.forEach(script => script.forEach(fn));
|
|
|
|
}
|
|
|
|
|
|
|
|
getScripts() {
|
|
|
|
return this.scripts;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// ===========================================================================
|
|
|
|
|
|
|
|
class NestingDistribution {
|
|
|
|
constructor(funktions) {
|
|
|
|
// Stores the nof bytes per function nesting level.
|
|
|
|
this.accumulator = [0, 0, 0, 0, 0];
|
|
|
|
// Max nof bytes encountered at any nesting level.
|
|
|
|
this.max = 0;
|
|
|
|
// avg bytes per nesting level.
|
|
|
|
this.avg = 0;
|
|
|
|
this.totalBytes = 0;
|
|
|
|
|
|
|
|
funktions.forEach(each => each.accumulateNestingLevel(this.accumulator));
|
|
|
|
this.max = this.accumulator.reduce((max, each) => Math.max(max, each), 0);
|
|
|
|
this.totalBytes = this.accumulator.reduce((sum, each) => sum + each, 0);
|
|
|
|
for (let i = 0; i < this.accumulator.length; i++) {
|
|
|
|
this.avg += this.accumulator[i] * i;
|
|
|
|
}
|
|
|
|
this.avg /= this.totalBytes;
|
|
|
|
}
|
|
|
|
|
|
|
|
print() {
|
|
|
|
console.log(this.toString())
|
|
|
|
}
|
|
|
|
|
|
|
|
toString() {
|
|
|
|
let ticks = " ▁▂▃▄▅▆▇█";
|
|
|
|
let accString = this.accumulator.reduce((str, each) => {
|
|
|
|
let index = Math.round(each / this.max * (ticks.length - 1));
|
|
|
|
return str + ticks[index];
|
|
|
|
}, '');
|
|
|
|
let percent0 = this.accumulator[0]
|
|
|
|
let percent1 = this.accumulator[1];
|
|
|
|
let percent2plus = this.accumulator.slice(2)
|
|
|
|
.reduce((sum, each) => sum + each, 0);
|
|
|
|
return " - nesting level: " +
|
|
|
|
' avg=' + formatNumber(this.avg) +
|
|
|
|
' l0=' + PERCENT(percent0, this.totalBytes) +
|
|
|
|
' l1=' + PERCENT(percent1, this.totalBytes) +
|
|
|
|
' l2+=' + PERCENT(percent2plus, this.totalBytes) +
|
|
|
|
' distribution=[' + accString + ']';
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
setMetrics(dict) {}
|
|
|
|
}
|
|
|
|
|
|
|
|
class ExecutionCost {
|
|
|
|
constructor(prefix, funktions, time_fn) {
|
|
|
|
this.prefix = prefix;
|
|
|
|
// Time spent on executed functions.
|
|
|
|
this.executedCost = 0
|
|
|
|
// Time spent on not executed functions.
|
|
|
|
this.nonExecutedCost = 0;
|
|
|
|
|
|
|
|
this.executedCost = funktions.reduce((sum, each) => {
|
|
|
|
return sum + (each.hasBeenExecuted() ? time_fn(each) : 0)
|
|
|
|
}, 0);
|
|
|
|
this.nonExecutedCost = funktions.reduce((sum, each) => {
|
|
|
|
return sum + (each.hasBeenExecuted() ? 0 : time_fn(each))
|
|
|
|
}, 0);
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
print() {
|
|
|
|
console.log(this.toString())
|
|
|
|
}
|
|
|
|
|
|
|
|
toString() {
|
|
|
|
return (' - ' + this.prefix + '-time:').padEnd(24) +
|
|
|
|
(" executed=" + formatNumber(this.executedCost) + 'ms').padEnd(20) +
|
|
|
|
" non-executed=" + formatNumber(this.nonExecutedCost) + 'ms';
|
|
|
|
}
|
|
|
|
|
|
|
|
setMetrics(dict) {
|
|
|
|
dict.set('parseMetric', this.executionCost);
|
|
|
|
dict.set('parseMetricNegative', this.nonExecutionCost);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// ===========================================================================
|
|
|
|
const kNoTimeMetrics = {
|
|
|
|
__proto__: null,
|
|
|
|
executionTime: 0,
|
|
|
|
firstEventTimestamp: 0,
|
|
|
|
firstParseEventTimestamp: 0,
|
|
|
|
lastParseTimestamp: 0,
|
|
|
|
lastEventTimestamp: 0
|
|
|
|
};
|
|
|
|
|
|
|
|
class Funktion {
|
|
|
|
constructor(name, start, end, script) {
|
|
|
|
if (start < 0) throw "invalid start position: " + start;
|
|
|
|
if (end <= 0) throw "invalid end position: " + end;
|
|
|
|
if (end <= start) throw "invalid start end positions";
|
|
|
|
|
|
|
|
this.name = name;
|
|
|
|
this.start = start;
|
|
|
|
this.end = end;
|
|
|
|
this.ownBytes = -1;
|
|
|
|
this.script = script;
|
|
|
|
this.parent = null;
|
|
|
|
this.fromEval = false;
|
|
|
|
this.nested = [];
|
|
|
|
this.nestingLevel = 0;
|
|
|
|
|
|
|
|
this.preparseTimestamp = -1;
|
|
|
|
this.parseTimestamp = -1;
|
|
|
|
this.parse2Timestamp = -1;
|
|
|
|
this.resolutionTimestamp = -1;
|
|
|
|
this.lazyCompileTimestamp = -1;
|
|
|
|
this.compileTimestamp = -1;
|
|
|
|
this.executionTimestamp = -1;
|
|
|
|
|
|
|
|
this.preparseTime = -0.0;
|
|
|
|
this.parseTime = -0.0;
|
|
|
|
this.parse2Time = -0.0;
|
|
|
|
this.resolutionTime = -0.0;
|
|
|
|
this.scopeResolutionTime = -0.0;
|
|
|
|
this.lazyCompileTime = -0.0;
|
|
|
|
this.compileTime = -0.0;
|
|
|
|
|
|
|
|
// Lazily computed properties.
|
|
|
|
this.firstEventTimestamp = -1;
|
|
|
|
this.firstParseEventTimestamp = -1;
|
|
|
|
this.lastParseTimestamp = -1;
|
|
|
|
this.lastEventTimestamp = -1;
|
|
|
|
|
|
|
|
if (script) this.script.addFunktion(this);
|
|
|
|
}
|
|
|
|
|
|
|
|
getMetricBytes(name) {
|
|
|
|
if (name == 'lazyCompileTimestamp') return this.getOwnBytes();
|
|
|
|
return this.getBytes();
|
|
|
|
}
|
|
|
|
|
|
|
|
getMetricTime(name) {
|
|
|
|
if (name in kNoTimeMetrics) return 0;
|
|
|
|
return this[name];
|
|
|
|
}
|
|
|
|
|
|
|
|
getFirstEvent() {
|
|
|
|
if (this.firstEventTimestamp === -1) {
|
|
|
|
this.firstEventTimestamp = timestampMin(
|
|
|
|
[this.parseTimestamp, this.preparseTimestamp,
|
|
|
|
this.resolutionTimestamp, this.executionTimestamp
|
|
|
|
]);
|
|
|
|
if (!(this.firstEventTimestamp > 0)) {
|
|
|
|
this.firstEventTimestamp = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return this.firstEventTimestamp;
|
|
|
|
}
|
|
|
|
|
|
|
|
getFirstParseEvent() {
|
|
|
|
if (this.firstParseEventTimestamp === -1) {
|
|
|
|
this.firstParseEventTimestamp = timestampMin(
|
|
|
|
[this.parseTimestamp, this.preparseTimestamp,
|
|
|
|
this.resolutionTimestamp
|
|
|
|
]);
|
|
|
|
if (!(this.firstParseEventTimestamp > 0)) {
|
|
|
|
this.firstParseEventTimestamp = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return this.firstParseEventTimestamp;
|
|
|
|
}
|
|
|
|
|
|
|
|
getLastParseEvent() {
|
|
|
|
if (this.lastParseTimestamp === -1) {
|
|
|
|
this.lastParseTimestamp = Math.max(
|
|
|
|
this.preparseTimestamp + this.preparseTime,
|
|
|
|
this.parseTimestamp + this.parseTime,
|
|
|
|
this.resolutionTimestamp + this.resolutionTime);
|
|
|
|
if (!(this.lastParseTimestamp > 0)) {
|
|
|
|
this.lastParseTimestamp = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return this.lastParseTimestamp;
|
|
|
|
}
|
|
|
|
|
|
|
|
getLastEvent() {
|
|
|
|
if (this.lastEventTimestamp === -1) {
|
|
|
|
this.lastEventTimestamp = Math.max(
|
|
|
|
this.getLastParseEvent(), this.executionTimestamp);
|
|
|
|
if (!(this.lastEventTimestamp > 0)) {
|
|
|
|
this.lastEventTimestamp = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return this.lastEventTimestamp;
|
|
|
|
}
|
|
|
|
|
|
|
|
isNestedIn(funktion) {
|
|
|
|
if (this.script != funktion.script) throw "Incompatible script";
|
|
|
|
return funktion.start < this.start && this.end <= funktion.end;
|
|
|
|
}
|
|
|
|
|
|
|
|
isToplevel() {
|
|
|
|
return this.parent === null
|
|
|
|
}
|
|
|
|
|
|
|
|
hasBeenExecuted() {
|
|
|
|
return this.executionTimestamp > 0
|
|
|
|
}
|
|
|
|
|
|
|
|
accumulateNestingLevel(accumulator) {
|
|
|
|
let value = accumulator[this.nestingLevel] || 0;
|
|
|
|
accumulator[this.nestingLevel] = value + this.getOwnBytes();
|
|
|
|
}
|
|
|
|
|
|
|
|
addNestedFunktion(child) {
|
|
|
|
if (this.script != child.script) throw "Incompatible script";
|
|
|
|
if (child == null) throw "Nesting non child";
|
|
|
|
this.nested.push(child);
|
|
|
|
if (this.nested.length > 1) {
|
|
|
|
// Make sure the nested children don't overlap and have been inserted in
|
|
|
|
// byte start position order.
|
|
|
|
let last = this.nested[this.nested.length - 2];
|
|
|
|
if (last.end > child.start || last.start > child.start ||
|
|
|
|
last.end > child.end || last.start > child.end) {
|
|
|
|
throw "Wrongly nested child added";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
child.nestingLevel = this.nestingLevel + 1;
|
|
|
|
return child.nestingLevel;
|
|
|
|
}
|
|
|
|
|
|
|
|
getBytes() {
|
|
|
|
return this.end - this.start;
|
|
|
|
}
|
|
|
|
|
|
|
|
getOwnBytes() {
|
|
|
|
if (this.ownBytes === -1) {
|
|
|
|
this.ownBytes = this.nested.reduce(
|
|
|
|
(bytes, each) => bytes - each.getBytes(),
|
|
|
|
this.getBytes());
|
|
|
|
if (this.ownBytes < 0) throw "Own bytes must be positive";
|
|
|
|
}
|
|
|
|
return this.ownBytes;
|
|
|
|
}
|
|
|
|
|
|
|
|
didMetricChange(time, delta, name) {
|
|
|
|
let value = this[name + 'Timestamp'];
|
|
|
|
return (time - delta) <= value && value <= (time + delta);
|
|
|
|
}
|
|
|
|
|
|
|
|
print() {
|
|
|
|
console.log(this.toString());
|
|
|
|
}
|
|
|
|
|
|
|
|
toString(details = true) {
|
|
|
|
let result = 'function' + (this.name ? ' ' + this.name : '') +
|
|
|
|
`() range=${this.start}-${this.end}`;
|
|
|
|
if (details) result += ` script=${this.script ? this.script.id : 'X'}`;
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// ===========================================================================
|
|
|
|
|
|
|
|
const kTimestampFactor = 1000;
|
|
|
|
const kSecondsToMillis = 1000;
|
|
|
|
|
|
|
|
function toTimestamp(microseconds) {
|
|
|
|
return microseconds / kTimestampFactor
|
|
|
|
}
|
|
|
|
|
|
|
|
function startOf(timestamp, time) {
|
|
|
|
let result = toTimestamp(timestamp) - time;
|
|
|
|
if (result < 0) throw "start timestamp cannnot be negative";
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
class ParseProcessor extends LogReader {
|
|
|
|
constructor() {
|
|
|
|
super();
|
2018-06-06 11:03:19 +00:00
|
|
|
this.dispatchTable_ = {
|
|
|
|
// Avoid accidental leaking of __proto__ properties and force this object
|
|
|
|
// to be in dictionary-mode.
|
|
|
|
__proto__: null,
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
// "function",{event type},
|
|
|
|
// {script id},{start position},{end position},{time},{timestamp},
|
|
|
|
// {function name}
|
2018-06-06 11:03:19 +00:00
|
|
|
'function': {
|
|
|
|
parsers: [
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
parseString, parseInt, parseInt, parseInt, parseFloat, parseInt,
|
|
|
|
parseString
|
2018-06-06 11:03:19 +00:00
|
|
|
],
|
|
|
|
processor: this.processFunctionEvent
|
2018-06-20 12:08:47 +00:00
|
|
|
},
|
|
|
|
// "compilation-cache", "hit"|"put", {type}, {start position},
|
|
|
|
// {end position}
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
'compilation-cache': {
|
|
|
|
parsers: [parseString, parseString, parseInt, parseInt],
|
2018-06-20 12:08:47 +00:00
|
|
|
processor: this.processCompilationCacheEvent
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
},
|
|
|
|
'script': {
|
|
|
|
parsers: [parseString, parseInt],
|
|
|
|
processor: this.processScriptEvent
|
|
|
|
},
|
|
|
|
// "script-details", {script_id}, {file}, {line}, {column}, {size}
|
|
|
|
'script-details': {
|
|
|
|
parsers: [parseInt, parseString, parseInt, parseInt, parseInt],
|
|
|
|
processor: this.processScriptDetails
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
};
|
2018-06-06 11:03:19 +00:00
|
|
|
this.functionEventDispatchTable_ = {
|
|
|
|
// Avoid accidental leaking of __proto__ properties and force this object
|
|
|
|
// to be in dictionary-mode.
|
|
|
|
__proto__: null,
|
|
|
|
'full-parse': this.processFull.bind(this),
|
2018-06-20 12:08:47 +00:00
|
|
|
'parse-function': this.processParseFunction.bind(this),
|
|
|
|
// TODO(cbruni): make sure arrow functions emit a normal parse-function
|
|
|
|
// event.
|
|
|
|
'parse': this.processParseFunction.bind(this),
|
2018-06-06 11:03:19 +00:00
|
|
|
'parse-script': this.processScript.bind(this),
|
|
|
|
'parse-eval': this.processEval.bind(this),
|
|
|
|
'preparse-no-resolution': this.processPreparseNoResolution.bind(this),
|
|
|
|
'preparse-resolution': this.processPreparseResolution.bind(this),
|
|
|
|
'first-execution': this.processFirstExecution.bind(this),
|
|
|
|
'compile-lazy': this.processCompileLazy.bind(this),
|
2018-06-20 12:08:47 +00:00
|
|
|
'compile': this.processCompile.bind(this),
|
|
|
|
'compile-eval': this.processCompileEval.bind(this),
|
2018-06-06 11:03:19 +00:00
|
|
|
'optimize-lazy': this.processOptimizeLazy.bind(this)
|
2017-12-20 12:02:45 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
this.idToScript = new Map();
|
|
|
|
this.fileToScript = new Map();
|
|
|
|
this.nameToFunction = new Map();
|
|
|
|
this.scripts = [];
|
|
|
|
this.totalScript = new TotalScript();
|
|
|
|
this.firstEvent = -1;
|
|
|
|
this.lastParseEvent = -1;
|
|
|
|
this.lastEvent = -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
print() {
|
|
|
|
console.log("scripts:");
|
|
|
|
this.idToScript.forEach(script => script.print());
|
|
|
|
}
|
|
|
|
|
|
|
|
processString(string) {
|
|
|
|
let end = string.length;
|
|
|
|
let current = 0;
|
|
|
|
let next = 0;
|
|
|
|
let line;
|
|
|
|
let i = 0;
|
|
|
|
let entry;
|
|
|
|
while (current < end) {
|
|
|
|
next = string.indexOf("\n", current);
|
|
|
|
if (next === -1) break;
|
|
|
|
i++;
|
|
|
|
line = string.substring(current, next);
|
|
|
|
current = next + 1;
|
|
|
|
this.processLogLine(line);
|
|
|
|
}
|
|
|
|
this.postProcess();
|
|
|
|
}
|
|
|
|
|
|
|
|
processLogFile(fileName) {
|
|
|
|
this.collectEntries = true
|
|
|
|
this.lastLogFileName_ = fileName;
|
|
|
|
var line;
|
|
|
|
while (line = readline()) {
|
|
|
|
this.processLogLine(line);
|
|
|
|
}
|
|
|
|
this.postProcess();
|
|
|
|
}
|
|
|
|
|
|
|
|
postProcess() {
|
|
|
|
this.scripts = Array.from(this.idToScript.values())
|
|
|
|
.filter(each => !each.isNative);
|
|
|
|
|
2018-06-27 08:50:49 +00:00
|
|
|
this.scripts.forEach(script => {
|
|
|
|
script.finalize();
|
|
|
|
script.calculateMetrics(false)
|
|
|
|
});
|
2017-12-20 12:02:45 +00:00
|
|
|
|
|
|
|
this.firstEvent =
|
|
|
|
timestampMin(this.scripts.map(each => each.firstEvent));
|
|
|
|
this.lastParseEvent = this.scripts.reduce(
|
|
|
|
(max, script) => Math.max(max, script.lastParseEvent), -1);
|
|
|
|
this.lastEvent = this.scripts.reduce(
|
|
|
|
(max, script) => Math.max(max, script.lastEvent), -1);
|
|
|
|
|
|
|
|
this.scripts.forEach(script => this.totalScript.addAllFunktions(script));
|
|
|
|
this.totalScript.calculateMetrics(true);
|
2018-06-20 12:08:47 +00:00
|
|
|
const series = {
|
|
|
|
firstParseEvent: 'Any Parse Event',
|
|
|
|
parse: 'Parsing',
|
|
|
|
preparse: 'Preparsing',
|
|
|
|
resolution: 'Preparsing with Var. Resolution',
|
|
|
|
lazyCompile: 'Lazy Compilation',
|
|
|
|
compile: 'Eager Compilation',
|
|
|
|
execution: 'First Execution',
|
|
|
|
};
|
|
|
|
let metrics = Object.keys(series);
|
2017-12-20 12:02:45 +00:00
|
|
|
this.totalScript.getAccumulatedTimeMetrics(metrics, 0, this.lastEvent, 10);
|
2018-06-06 11:03:19 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
processFunctionEvent(
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
eventName, scriptId, startPosition, endPosition, duration, timestamp,
|
|
|
|
functionName) {
|
2018-06-06 11:03:19 +00:00
|
|
|
let handlerFn = this.functionEventDispatchTable_[eventName];
|
|
|
|
if (handlerFn === undefined) {
|
|
|
|
console.error('Couldn\'t find handler for function event:' + eventName);
|
|
|
|
}
|
|
|
|
handlerFn(
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
scriptId, startPosition, endPosition, duration, timestamp,
|
2018-06-06 11:03:19 +00:00
|
|
|
functionName);
|
|
|
|
}
|
2017-12-20 12:02:45 +00:00
|
|
|
|
|
|
|
addEntry(entry) {
|
|
|
|
this.entries.push(entry);
|
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
lookupScript(id) {
|
|
|
|
return this.idToScript.get(id);
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
getOrCreateFunction(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
|
|
|
if (scriptId == -1) {
|
2018-06-06 11:03:19 +00:00
|
|
|
return this.lookupFunktionByRange(startPosition, endPosition);
|
|
|
|
}
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
let script = this.lookupScript(scriptId);
|
2017-12-20 12:02:45 +00:00
|
|
|
let funktion = script.funktionAtPosition(startPosition);
|
|
|
|
if (funktion === void 0) {
|
|
|
|
funktion = new Funktion(functionName, startPosition, endPosition, script);
|
|
|
|
}
|
|
|
|
return funktion;
|
|
|
|
}
|
|
|
|
|
2018-06-06 11:03:19 +00:00
|
|
|
// Iterates over all functions and tries to find matching ones.
|
|
|
|
lookupFunktionsByRange(start, end) {
|
|
|
|
let results = [];
|
|
|
|
this.idToScript.forEach(script => {
|
|
|
|
script.forEach(funktion => {
|
|
|
|
if (funktion.startPostion == start && funktion.endPosition == end) {
|
|
|
|
results.push(funktion);
|
|
|
|
}
|
|
|
|
});
|
|
|
|
});
|
|
|
|
return results;
|
|
|
|
}
|
|
|
|
lookupFunktionByRange(start, end) {
|
|
|
|
let results = this.lookupFunktionsByRange(start, end);
|
|
|
|
if (results.length != 1) throw "Could not find unique function by range";
|
|
|
|
return results[0];
|
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processScriptEvent(eventName, scriptId) {
|
2018-06-27 08:50:49 +00:00
|
|
|
if (['create', 'reserve-id', 'deserialize'].includes(eventName)) {
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
if (this.idToScript.has(scriptId)) return;
|
|
|
|
let script = new Script(scriptId);
|
|
|
|
this.idToScript.set(scriptId, script);
|
2018-06-27 08:50:49 +00:00
|
|
|
if (eventName == 'deserialize') script.isDeserialized = true;
|
|
|
|
return;
|
|
|
|
} else if (eventName === 'background-compile') {
|
|
|
|
this.idToScript.get(scriptId).isBackgroundCompiled = true;
|
|
|
|
return;
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
}
|
2018-06-27 08:50:49 +00:00
|
|
|
console.error('Unhandled script event: ' + eventName);
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
processScriptDetails(scriptId, file, startLine, startColumn, size) {
|
|
|
|
let script = this.lookupScript(scriptId);
|
|
|
|
script.setFile(file);
|
|
|
|
}
|
|
|
|
|
|
|
|
processEval(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
|
|
|
let script = this.lookupScript(scriptId);
|
2017-12-20 12:02:45 +00:00
|
|
|
script.isEval = true;
|
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processFull(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
2018-06-20 12:08:47 +00:00
|
|
|
if (startPosition == 0) {
|
|
|
|
// This should only happen for eval.
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
let script = this.lookupScript(scriptId);
|
2018-06-20 12:08:47 +00:00
|
|
|
script.isEval = true;
|
|
|
|
return;
|
|
|
|
}
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
let funktion = this.getOrCreateFunction(...arguments);
|
2017-12-20 12:02:45 +00:00
|
|
|
// TODO(cbruni): this should never happen, emit differen event from the
|
|
|
|
// parser.
|
|
|
|
if (funktion.parseTimestamp > 0) return;
|
2018-06-20 12:08:47 +00:00
|
|
|
funktion.parseTimestamp = startOf(timestamp, duration);
|
|
|
|
funktion.parseTime = duration;
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processParseFunction(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
|
|
|
let funktion = this.getOrCreateFunction(...arguments);
|
2018-06-20 12:08:47 +00:00
|
|
|
funktion.parseTimestamp = startOf(timestamp, duration);
|
|
|
|
funktion.parseTime = duration;
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processScript(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
2018-06-20 12:08:47 +00:00
|
|
|
// TODO timestamp and duration
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
let script = this.lookupScript(scriptId);
|
2018-06-20 12:08:47 +00:00
|
|
|
let ts = startOf(timestamp, duration);
|
2017-12-20 12:02:45 +00:00
|
|
|
script.parseTimestamp = ts;
|
|
|
|
script.firstEventTimestamp = ts;
|
|
|
|
script.firstParseEventTimestamp = ts;
|
2018-06-20 12:08:47 +00:00
|
|
|
script.parseTime = duration;
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processPreparseResolution(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
|
|
|
let funktion = this.getOrCreateFunction(...arguments);
|
2017-12-20 12:02:45 +00:00
|
|
|
// TODO(cbruni): this should never happen, emit different event from the
|
|
|
|
// parser.
|
|
|
|
if (funktion.resolutionTimestamp > 0) return;
|
2018-06-20 12:08:47 +00:00
|
|
|
funktion.resolutionTimestamp = startOf(timestamp, duration);
|
|
|
|
funktion.resolutionTime = duration;
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processPreparseNoResolution(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
|
|
|
let funktion = this.getOrCreateFunction(...arguments);
|
2018-06-20 12:08:47 +00:00
|
|
|
funktion.preparseTimestamp = startOf(timestamp, duration);
|
|
|
|
funktion.preparseTime = duration;
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processFirstExecution(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
|
|
|
let script = this.lookupScript(scriptId);
|
2017-12-20 12:02:45 +00:00
|
|
|
if (startPosition === 0) {
|
|
|
|
// undefined = eval fn execution
|
|
|
|
if (script) {
|
|
|
|
script.executionTimestamp = toTimestamp(timestamp);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
let funktion = script.funktionAtPosition(startPosition);
|
|
|
|
if (funktion) {
|
|
|
|
funktion.executionTimestamp = toTimestamp(timestamp);
|
|
|
|
} else if (functionName.length > 0) {
|
|
|
|
// throw new Error("Could not find function: " + functionName);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processCompileLazy(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
|
|
|
let funktion = this.getOrCreateFunction(...arguments);
|
2018-06-20 12:08:47 +00:00
|
|
|
funktion.lazyCompileTimestamp = startOf(timestamp, duration);
|
|
|
|
funktion.lazyCompileTime = duration;
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processCompile(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
|
|
|
let script = this.lookupScript(scriptId);
|
2017-12-20 12:02:45 +00:00
|
|
|
if (startPosition === 0) {
|
2018-06-20 12:08:47 +00:00
|
|
|
script.compileTimestamp = startOf(timestamp, duration);
|
|
|
|
script.compileTime = duration;
|
2017-12-20 12:02:45 +00:00
|
|
|
script.bytesTotal = endPosition;
|
|
|
|
} else {
|
|
|
|
let funktion = script.funktionAtPosition(startPosition);
|
2018-06-20 12:08:47 +00:00
|
|
|
if (funktion === undefined) {
|
|
|
|
// This should not happen since any funktion has to be parsed first.
|
|
|
|
console.log("processCompile funktion not found", ...arguments);
|
|
|
|
}
|
|
|
|
funktion.compileTimestamp = startOf(timestamp, duration);
|
|
|
|
funktion.compileTime = duration;
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
}
|
2018-06-20 12:08:47 +00:00
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processCompileEval(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
2018-06-20 12:08:47 +00:00
|
|
|
}
|
|
|
|
|
Reland "[parser][log] Log script id during background compilation"
This reverts commit a800e05007d42c84cd5627e5dfb305dfb9912844.
Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52ab98608e37284a5a944a4c63045625b9.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> > parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> > script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}
TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
2018-06-25 09:00:21 +00:00
|
|
|
processOptimizeLazy(
|
|
|
|
scriptId, startPosition, endPosition, duration, timestamp, functionName) {
|
2018-06-20 12:08:47 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
processCompilationCacheEvent(eventType, cacheType, startPosition,
|
|
|
|
endPosition) {
|
|
|
|
}
|
|
|
|
|
2017-12-20 12:02:45 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
class ArgumentsProcessor extends BaseArgumentsProcessor {
|
|
|
|
getArgsDispatch() {
|
|
|
|
return {};
|
|
|
|
}
|
|
|
|
|
|
|
|
getDefaultResults() {
|
|
|
|
return {
|
|
|
|
logFileName: 'v8.log',
|
|
|
|
range: 'auto,auto',
|
|
|
|
};
|
|
|
|
}
|
|
|
|
}
|