AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
f2062511ca
v8/test/cctest/interpreter/bytecode_expectations/LoadGlobal.golden

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

348 lines
11 KiB
Plaintext
Raw Normal View History

[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
#
# Autogenerated by generate-bytecode-expectations.
#
---
wrap: no
test function name: f
---
snippet: "
var a = 1;
function f() { return a; }
f()
"
frame size: 0
parameter count: 1
[ic] Pass name to LoadGlobalIC again. The reasons are: 1) The names dictionaries in the feedback metadata seems to consume a lot of memory and the idea didn't payoff. 2) The absence of a name parameter blocks data handlers support in LoadGlobalIC. This CL reverts a part of r37278 (https://codereview.chromium.org/2096653003/). BUG=chromium:576312, v8:5561 Review-Url: https://codereview.chromium.org/2510653002 Cr-Commit-Position: refs/heads/master@{#41046}
2016-11-16 18:17:22 +00:00
bytecode array length: 5
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
bytecodes: [
[interpreter] Add checks for source position to test-bytecode-generator. Prints source position information alongside bytecode. BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/1963663002 Cr-Commit-Position: refs/heads/master@{#36171}
2016-05-11 12:21:56 +00:00
/* 21 E> */ B(StackCheck),
[objects] Make feedback vector a first-class object Instead of having feedback vector as a subtype of FixedArray with reserved slots, make it a first-class variable-sized object with a fixed-size header. This allows us to compress counters to ints in the header, rather than forcing them to be Smis. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Icc5f088ffbc2e2651b845bc71ea42060639e3e48 Reviewed-on: https://chromium-review.googlesource.com/585129 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#46935}
2017-07-27 12:45:00 +00:00
/* 26 S> */ B(LdaGlobal), U8(0), U8(0),
[inspector] improve return position of explicit return in non-async function Goal of this CL: explicit return from non-async function has position after return expression as return position (will unblock [1]). BytecodeArrayBuilder has SetStatementPosition and SetExpressionPosition methods. If one of these methods is called then next generated bytecode will get passed position. It's general treatment for most cases. Unfortunately it doesn't work for Returns: - debugger requires source positions exactly on kReturn bytecode in stepping implementation, - BytecodeGenerator::BuildReturn and BytecodeGenerator::BuildAsyncReturn generates more then one bytecode and general solution will put return position on first generated bytecode, - it's not easy to split BuildReturn function into two parts to allow something like following in BytecodeGenerator::VisitReturnStatement since generated bytecodes are actually controlled by execution_control(). ..->BuildReturnPrologue(); ..->SetReturnPosition(stmt); ..->Return(); In this CL we pass ReturnStatement through ExecutionControl and use it for position when we emit return bytecode right here. So this CL only will improve return position for returns inside of non-async functions, I'll address async functions later. [1] https://chromium-review.googlesource.com/c/543161/ Change-Id: Iede512c120b00c209990bf50c20e7d23dc0d65db Reviewed-on: https://chromium-review.googlesource.com/560738 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46687}
2017-07-14 17:50:09 +00:00
/* 35 S> */ B(Return),
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
]
constant pool: [
[ic] Pass name to LoadGlobalIC again. The reasons are: 1) The names dictionaries in the feedback metadata seems to consume a lot of memory and the idea didn't payoff. 2) The absence of a name parameter blocks data handlers support in LoadGlobalIC. This CL reverts a part of r37278 (https://codereview.chromium.org/2096653003/). BUG=chromium:576312, v8:5561 Review-Url: https://codereview.chromium.org/2510653002 Cr-Commit-Position: refs/heads/master@{#41046}
2016-11-16 18:17:22 +00:00
ONE_BYTE_INTERNALIZED_STRING_TYPE ["a"],
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
]
handlers: [
]
---
snippet: "
function t() { }
function f() { return t; }
f()
"
frame size: 0
parameter count: 1
[ic] Pass name to LoadGlobalIC again. The reasons are: 1) The names dictionaries in the feedback metadata seems to consume a lot of memory and the idea didn't payoff. 2) The absence of a name parameter blocks data handlers support in LoadGlobalIC. This CL reverts a part of r37278 (https://codereview.chromium.org/2096653003/). BUG=chromium:576312, v8:5561 Review-Url: https://codereview.chromium.org/2510653002 Cr-Commit-Position: refs/heads/master@{#41046}
2016-11-16 18:17:22 +00:00
bytecode array length: 5
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
bytecodes: [
[interpreter] Add checks for source position to test-bytecode-generator. Prints source position information alongside bytecode. BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/1963663002 Cr-Commit-Position: refs/heads/master@{#36171}
2016-05-11 12:21:56 +00:00
/* 27 E> */ B(StackCheck),
[objects] Make feedback vector a first-class object Instead of having feedback vector as a subtype of FixedArray with reserved slots, make it a first-class variable-sized object with a fixed-size header. This allows us to compress counters to ints in the header, rather than forcing them to be Smis. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Icc5f088ffbc2e2651b845bc71ea42060639e3e48 Reviewed-on: https://chromium-review.googlesource.com/585129 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#46935}
2017-07-27 12:45:00 +00:00
/* 32 S> */ B(LdaGlobal), U8(0), U8(0),
[inspector] improve return position of explicit return in non-async function Goal of this CL: explicit return from non-async function has position after return expression as return position (will unblock [1]). BytecodeArrayBuilder has SetStatementPosition and SetExpressionPosition methods. If one of these methods is called then next generated bytecode will get passed position. It's general treatment for most cases. Unfortunately it doesn't work for Returns: - debugger requires source positions exactly on kReturn bytecode in stepping implementation, - BytecodeGenerator::BuildReturn and BytecodeGenerator::BuildAsyncReturn generates more then one bytecode and general solution will put return position on first generated bytecode, - it's not easy to split BuildReturn function into two parts to allow something like following in BytecodeGenerator::VisitReturnStatement since generated bytecodes are actually controlled by execution_control(). ..->BuildReturnPrologue(); ..->SetReturnPosition(stmt); ..->Return(); In this CL we pass ReturnStatement through ExecutionControl and use it for position when we emit return bytecode right here. So this CL only will improve return position for returns inside of non-async functions, I'll address async functions later. [1] https://chromium-review.googlesource.com/c/543161/ Change-Id: Iede512c120b00c209990bf50c20e7d23dc0d65db Reviewed-on: https://chromium-review.googlesource.com/560738 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46687}
2017-07-14 17:50:09 +00:00
/* 41 S> */ B(Return),
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
]
constant pool: [
[ic] Pass name to LoadGlobalIC again. The reasons are: 1) The names dictionaries in the feedback metadata seems to consume a lot of memory and the idea didn't payoff. 2) The absence of a name parameter blocks data handlers support in LoadGlobalIC. This CL reverts a part of r37278 (https://codereview.chromium.org/2096653003/). BUG=chromium:576312, v8:5561 Review-Url: https://codereview.chromium.org/2510653002 Cr-Commit-Position: refs/heads/master@{#41046}
2016-11-16 18:17:22 +00:00
ONE_BYTE_INTERNALIZED_STRING_TYPE ["t"],
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
]
handlers: [
]
---
snippet: "
a = 1;
function f() { return a; }
f()
"
frame size: 0
parameter count: 1
[ic] Pass name to LoadGlobalIC again. The reasons are: 1) The names dictionaries in the feedback metadata seems to consume a lot of memory and the idea didn't payoff. 2) The absence of a name parameter blocks data handlers support in LoadGlobalIC. This CL reverts a part of r37278 (https://codereview.chromium.org/2096653003/). BUG=chromium:576312, v8:5561 Review-Url: https://codereview.chromium.org/2510653002 Cr-Commit-Position: refs/heads/master@{#41046}
2016-11-16 18:17:22 +00:00
bytecode array length: 5
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
bytecodes: [
[interpreter] Add checks for source position to test-bytecode-generator. Prints source position information alongside bytecode. BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/1963663002 Cr-Commit-Position: refs/heads/master@{#36171}
2016-05-11 12:21:56 +00:00
/* 17 E> */ B(StackCheck),
[objects] Make feedback vector a first-class object Instead of having feedback vector as a subtype of FixedArray with reserved slots, make it a first-class variable-sized object with a fixed-size header. This allows us to compress counters to ints in the header, rather than forcing them to be Smis. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Icc5f088ffbc2e2651b845bc71ea42060639e3e48 Reviewed-on: https://chromium-review.googlesource.com/585129 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#46935}
2017-07-27 12:45:00 +00:00
/* 22 S> */ B(LdaGlobal), U8(0), U8(0),
[inspector] improve return position of explicit return in non-async function Goal of this CL: explicit return from non-async function has position after return expression as return position (will unblock [1]). BytecodeArrayBuilder has SetStatementPosition and SetExpressionPosition methods. If one of these methods is called then next generated bytecode will get passed position. It's general treatment for most cases. Unfortunately it doesn't work for Returns: - debugger requires source positions exactly on kReturn bytecode in stepping implementation, - BytecodeGenerator::BuildReturn and BytecodeGenerator::BuildAsyncReturn generates more then one bytecode and general solution will put return position on first generated bytecode, - it's not easy to split BuildReturn function into two parts to allow something like following in BytecodeGenerator::VisitReturnStatement since generated bytecodes are actually controlled by execution_control(). ..->BuildReturnPrologue(); ..->SetReturnPosition(stmt); ..->Return(); In this CL we pass ReturnStatement through ExecutionControl and use it for position when we emit return bytecode right here. So this CL only will improve return position for returns inside of non-async functions, I'll address async functions later. [1] https://chromium-review.googlesource.com/c/543161/ Change-Id: Iede512c120b00c209990bf50c20e7d23dc0d65db Reviewed-on: https://chromium-review.googlesource.com/560738 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46687}
2017-07-14 17:50:09 +00:00
/* 31 S> */ B(Return),
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
]
constant pool: [
[ic] Pass name to LoadGlobalIC again. The reasons are: 1) The names dictionaries in the feedback metadata seems to consume a lot of memory and the idea didn't payoff. 2) The absence of a name parameter blocks data handlers support in LoadGlobalIC. This CL reverts a part of r37278 (https://codereview.chromium.org/2096653003/). BUG=chromium:576312, v8:5561 Review-Url: https://codereview.chromium.org/2510653002 Cr-Commit-Position: refs/heads/master@{#41046}
2016-11-16 18:17:22 +00:00
ONE_BYTE_INTERNALIZED_STRING_TYPE ["a"],
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
]
handlers: [
]
---
snippet: "
a = 1;
function f(b) {
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
b.name;
return a;
}
f({name: 1});
"
[interpreter] Bytecode register optimizer. Online optimization stage for reducing redundant transfers between registers. BUG=V8:4280 LOG=N Review-Url: https://codereview.chromium.org/1997653002 Cr-Commit-Position: refs/heads/master@{#36551}
2016-05-27 15:57:35 +00:00
frame size: 0
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
parameter count: 2
[objects] Make feedback vector a first-class object Instead of having feedback vector as a subtype of FixedArray with reserved slots, make it a first-class variable-sized object with a fixed-size header. This allows us to compress counters to ints in the header, rather than forcing them to be Smis. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Icc5f088ffbc2e2651b845bc71ea42060639e3e48 Reviewed-on: https://chromium-review.googlesource.com/585129 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#46935}
2017-07-27 12:45:00 +00:00
bytecode array length: 520
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
bytecodes: [
[interpreter] Add checks for source position to test-bytecode-generator. Prints source position information alongside bytecode. BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/1963663002 Cr-Commit-Position: refs/heads/master@{#36171}
2016-05-11 12:21:56 +00:00
/* 17 E> */ B(StackCheck),
[objects] Make feedback vector a first-class object Instead of having feedback vector as a subtype of FixedArray with reserved slots, make it a first-class variable-sized object with a fixed-size header. This allows us to compress counters to ints in the header, rather than forcing them to be Smis. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Icc5f088ffbc2e2651b845bc71ea42060639e3e48 Reviewed-on: https://chromium-review.googlesource.com/585129 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#46935}
2017-07-27 12:45:00 +00:00
/* 27 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(0),
/* 37 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(2),
/* 47 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(4),
/* 57 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(6),
/* 67 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(8),
/* 77 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(10),
/* 87 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(12),
/* 97 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(14),
/* 107 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(16),
/* 117 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(18),
/* 127 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(20),
/* 137 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(22),
/* 147 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(24),
/* 157 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(26),
/* 167 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(28),
/* 177 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(30),
/* 187 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(32),
/* 197 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(34),
/* 207 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(36),
/* 217 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(38),
/* 227 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(40),
/* 237 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(42),
/* 247 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(44),
/* 257 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(46),
/* 267 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(48),
/* 277 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(50),
/* 287 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(52),
/* 297 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(54),
/* 307 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(56),
/* 317 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(58),
/* 327 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(60),
/* 337 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(62),
/* 347 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(64),
/* 357 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(66),
/* 367 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(68),
/* 377 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(70),
/* 387 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(72),
/* 397 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(74),
/* 407 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(76),
/* 417 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(78),
/* 427 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(80),
/* 437 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(82),
/* 447 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(84),
/* 457 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(86),
/* 467 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(88),
/* 477 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(90),
/* 487 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(92),
/* 497 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(94),
/* 507 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(96),
/* 517 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(98),
/* 527 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(100),
/* 537 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(102),
/* 547 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(104),
/* 557 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(106),
/* 567 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(108),
/* 577 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(110),
/* 587 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(112),
/* 597 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(114),
/* 607 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(116),
/* 617 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(118),
/* 627 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(120),
/* 637 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(122),
/* 647 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(124),
/* 657 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(126),
/* 667 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(128),
/* 677 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(130),
/* 687 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(132),
/* 697 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(134),
/* 707 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(136),
/* 717 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(138),
/* 727 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(140),
/* 737 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(142),
/* 747 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(144),
/* 757 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(146),
/* 767 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(148),
/* 777 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(150),
/* 787 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(152),
/* 797 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(154),
/* 807 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(156),
/* 817 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(158),
/* 827 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(160),
/* 837 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(162),
/* 847 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(164),
/* 857 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(166),
/* 867 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(168),
/* 877 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(170),
/* 887 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(172),
/* 897 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(174),
/* 907 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(176),
/* 917 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(178),
/* 927 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(180),
/* 937 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(182),
/* 947 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(184),
/* 957 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(186),
/* 967 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(188),
/* 977 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(190),
/* 987 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(192),
/* 997 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(194),
/* 1007 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(196),
/* 1017 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(198),
/* 1027 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(200),
/* 1037 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(202),
/* 1047 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(204),
/* 1057 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(206),
/* 1067 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(208),
/* 1077 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(210),
/* 1087 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(212),
/* 1097 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(214),
/* 1107 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(216),
/* 1117 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(218),
/* 1127 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(220),
/* 1137 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(222),
/* 1147 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(224),
/* 1157 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(226),
/* 1167 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(228),
/* 1177 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(230),
/* 1187 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(232),
/* 1197 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(234),
/* 1207 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(236),
/* 1217 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(238),
/* 1227 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(240),
/* 1237 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(242),
/* 1247 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(244),
/* 1257 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(246),
/* 1267 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(248),
/* 1277 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(250),
/* 1287 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(252),
/* 1297 S> */ B(LdaNamedProperty), R(arg0), U8(0), U8(254),
/* 1305 S> */ B(Wide), B(LdaGlobal), U16(1), U16(256),
[inspector] improve return position of explicit return in non-async function Goal of this CL: explicit return from non-async function has position after return expression as return position (will unblock [1]). BytecodeArrayBuilder has SetStatementPosition and SetExpressionPosition methods. If one of these methods is called then next generated bytecode will get passed position. It's general treatment for most cases. Unfortunately it doesn't work for Returns: - debugger requires source positions exactly on kReturn bytecode in stepping implementation, - BytecodeGenerator::BuildReturn and BytecodeGenerator::BuildAsyncReturn generates more then one bytecode and general solution will put return position on first generated bytecode, - it's not easy to split BuildReturn function into two parts to allow something like following in BytecodeGenerator::VisitReturnStatement since generated bytecodes are actually controlled by execution_control(). ..->BuildReturnPrologue(); ..->SetReturnPosition(stmt); ..->Return(); In this CL we pass ReturnStatement through ExecutionControl and use it for position when we emit return bytecode right here. So this CL only will improve return position for returns inside of non-async functions, I'll address async functions later. [1] https://chromium-review.googlesource.com/c/543161/ Change-Id: Iede512c120b00c209990bf50c20e7d23dc0d65db Reviewed-on: https://chromium-review.googlesource.com/560738 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46687}
2017-07-14 17:50:09 +00:00
/* 1314 S> */ B(Return),
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
]
constant pool: [
[Interpreter] Remove constant pool type in tests For historical reasons, the interpreter's bytecode expectations tests required a type for the constant pool. This had two disadvantages: 1. Strings and numbers were not visible in mixed pools, and 2. Mismatches of pool types (e.g. when rebaselining) would cause parser errors This removes the pool types, making everything 'mixed', but appending the values to string and number valued constants. Specifying a pool type in the *.golden header now prints a warning (for backwards compatibility). BUG=v8:5350 Review-Url: https://codereview.chromium.org/2310103002 Cr-Commit-Position: refs/heads/master@{#39216}
2016-09-06 16:10:19 +00:00
ONE_BYTE_INTERNALIZED_STRING_TYPE ["name"],
[ic] Pass name to LoadGlobalIC again. The reasons are: 1) The names dictionaries in the feedback metadata seems to consume a lot of memory and the idea didn't payoff. 2) The absence of a name parameter blocks data handlers support in LoadGlobalIC. This CL reverts a part of r37278 (https://codereview.chromium.org/2096653003/). BUG=chromium:576312, v8:5561 Review-Url: https://codereview.chromium.org/2510653002 Cr-Commit-Position: refs/heads/master@{#41046}
2016-11-16 18:17:22 +00:00
ONE_BYTE_INTERNALIZED_STRING_TYPE ["a"],
[Interpreter] Refactor bytecode generator test suite. Bytecode expectations have been moved to external (.golden) files, one per test. Each test in the suite builds a representation of the the compiled bytecode using BytecodeExpectationsPrinter. The output is then compared to the golden file. If the comparision fails, a textual diff can be used to identify the discrepancies. Only the test snippets are left in the cc file, which also allows to make it more compact and meaningful. Leaving the snippets in the cc file was a deliberate choice to allow keeping the "truth" about the tests in the cc file, which will rarely change, as opposed to golden files. Golden files can be generated and kept up to date using generate-bytecode-expectations, which also means that the test suite can be batch updated whenever the bytecode or golden format changes. The golden format has been slightly amended (no more comments about `void*`, add size of the bytecode array) following the consideration made while converting the tests. There is also a fix: BytecodeExpectationsPrinter::top_level_ was left uninitialized, leading to undefined behaviour. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1717293002 Cr-Commit-Position: refs/heads/master@{#34285}
2016-02-25 12:07:07 +00:00
]
handlers: [
]
Reference in New Issue Copy Permalink