2015-12-11 12:26:16 +00:00
|
|
|
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file.
|
|
|
|
|
2015-12-17 10:54:08 +00:00
|
|
|
// Flags: --expose-wasm
|
|
|
|
|
2015-12-11 12:26:16 +00:00
|
|
|
load("test/mjsunit/wasm/wasm-constants.js");
|
2016-03-07 19:32:35 +00:00
|
|
|
load("test/mjsunit/wasm/wasm-module-builder.js");
|
2015-12-11 12:26:16 +00:00
|
|
|
|
2016-06-21 12:52:57 +00:00
|
|
|
let kReturnValue = 117;
|
2016-03-07 19:32:35 +00:00
|
|
|
|
2016-06-21 12:52:57 +00:00
|
|
|
let buffer = (() => {
|
|
|
|
let builder = new WasmModuleBuilder();
|
2016-03-07 19:32:35 +00:00
|
|
|
builder.addMemory(1, 1, true);
|
2016-04-29 09:39:26 +00:00
|
|
|
builder.addFunction("main", kSig_i)
|
2016-03-07 19:32:35 +00:00
|
|
|
.addBody([kExprI8Const, kReturnValue])
|
|
|
|
.exportFunc();
|
|
|
|
|
2016-06-21 12:52:57 +00:00
|
|
|
return builder.toBuffer();
|
|
|
|
})()
|
|
|
|
|
|
|
|
function CheckInstance(instance) {
|
|
|
|
assertFalse(instance === undefined);
|
|
|
|
assertFalse(instance === null);
|
|
|
|
assertFalse(instance === 0);
|
|
|
|
assertEquals("object", typeof instance);
|
|
|
|
|
|
|
|
// Check the memory is an ArrayBuffer.
|
|
|
|
var mem = instance.exports.memory;
|
|
|
|
assertFalse(mem === undefined);
|
|
|
|
assertFalse(mem === null);
|
|
|
|
assertFalse(mem === 0);
|
|
|
|
assertEquals("object", typeof mem);
|
2016-09-23 17:58:07 +00:00
|
|
|
assertTrue(mem instanceof ArrayBuffer);
|
|
|
|
for (let i = 0; i < 4; i++) {
|
2016-06-21 12:52:57 +00:00
|
|
|
instance.exports.memory = 0; // should be ignored
|
|
|
|
assertSame(mem, instance.exports.memory);
|
|
|
|
}
|
|
|
|
|
2016-09-23 17:58:07 +00:00
|
|
|
assertEquals(65536, instance.exports.memory.byteLength);
|
|
|
|
|
2016-06-21 12:52:57 +00:00
|
|
|
// Check the properties of the main function.
|
|
|
|
let main = instance.exports.main;
|
|
|
|
assertFalse(main === undefined);
|
|
|
|
assertFalse(main === null);
|
|
|
|
assertFalse(main === 0);
|
|
|
|
assertEquals("function", typeof main);
|
|
|
|
|
|
|
|
assertEquals(kReturnValue, main());
|
2015-12-11 12:26:16 +00:00
|
|
|
}
|
|
|
|
|
2016-06-21 12:52:57 +00:00
|
|
|
// Deprecated experimental API.
|
|
|
|
CheckInstance(Wasm.instantiateModule(buffer));
|
2015-12-11 12:26:16 +00:00
|
|
|
|
2016-06-21 12:52:57 +00:00
|
|
|
// Official API
|
|
|
|
let module = new WebAssembly.Module(buffer);
|
|
|
|
CheckInstance(new WebAssembly.Instance(module));
|
2015-12-11 12:26:16 +00:00
|
|
|
|
2016-06-21 12:52:57 +00:00
|
|
|
let promise = WebAssembly.compile(buffer);
|
|
|
|
promise.then(module => CheckInstance(new WebAssembly.Instance(module)));
|
2016-07-14 16:27:51 +00:00
|
|
|
|
|
|
|
// Negative tests.
|
|
|
|
(function InvalidModules() {
|
|
|
|
let invalid_cases = [undefined, 1, "", "a", {some:1, obj: "b"}];
|
|
|
|
let len = invalid_cases.length;
|
|
|
|
for (var i = 0; i < len; ++i) {
|
|
|
|
try {
|
|
|
|
let instance = new WebAssembly.Instance(1);
|
|
|
|
assertUnreachable("should not be able to instantiate invalid modules.");
|
|
|
|
} catch (e) {
|
|
|
|
assertContains("Argument 0", e.toString());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
})();
|
|
|
|
|
|
|
|
// Compile async an invalid blob.
|
|
|
|
(function InvalidBinaryAsyncCompilation() {
|
|
|
|
let builder = new WasmModuleBuilder();
|
|
|
|
builder.addFunction("f", kSig_i_i)
|
2016-09-23 17:58:07 +00:00
|
|
|
.addBody([kExprCallImport, kArity0, 0]);
|
2016-07-14 16:27:51 +00:00
|
|
|
let promise = WebAssembly.compile(builder.toBuffer());
|
|
|
|
promise
|
|
|
|
.then(compiled =>
|
|
|
|
assertUnreachable("should not be able to compile invalid blob."))
|
|
|
|
.catch(e => assertContains("invalid signature index", e.toString()));
|
|
|
|
})();
|
|
|
|
|
|
|
|
// Multiple instances tests.
|
|
|
|
(function ManyInstances() {
|
|
|
|
let compiled_module = new WebAssembly.Module(buffer);
|
|
|
|
let instance_1 = new WebAssembly.Instance(compiled_module);
|
|
|
|
let instance_2 = new WebAssembly.Instance(compiled_module);
|
|
|
|
assertTrue(instance_1 != instance_2);
|
|
|
|
})();
|
|
|
|
|
|
|
|
(function ManyInstancesAsync() {
|
|
|
|
let promise = WebAssembly.compile(buffer);
|
|
|
|
promise.then(compiled_module => {
|
|
|
|
let instance_1 = new WebAssembly.Instance(compiled_module);
|
|
|
|
let instance_2 = new WebAssembly.Instance(compiled_module);
|
|
|
|
assertTrue(instance_1 != instance_2);
|
|
|
|
});
|
|
|
|
})();
|
|
|
|
|
|
|
|
(function InstancesAreIsolatedFromEachother() {
|
|
|
|
var builder = new WasmModuleBuilder();
|
|
|
|
builder.addMemory(1,1, true);
|
|
|
|
var kSig_v_i = makeSig([kAstI32], []);
|
|
|
|
var signature = builder.addType(kSig_v_i);
|
|
|
|
builder.addImport("some_value", kSig_i);
|
|
|
|
builder.addImport("writer", signature);
|
|
|
|
|
|
|
|
builder.addFunction("main", kSig_i_i)
|
|
|
|
.addBody([
|
2016-09-23 17:58:07 +00:00
|
|
|
kExprI32Const, 1,
|
2016-07-14 16:27:51 +00:00
|
|
|
kExprGetLocal, 0,
|
|
|
|
kExprI32LoadMem, 0, 0,
|
2016-09-23 17:58:07 +00:00
|
|
|
kExprCallIndirect, kArity1, signature,
|
2016-07-14 16:27:51 +00:00
|
|
|
kExprGetLocal,0,
|
|
|
|
kExprI32LoadMem,0, 0,
|
2016-09-23 17:58:07 +00:00
|
|
|
kExprCallImport, kArity0, 0,
|
2016-07-14 16:27:51 +00:00
|
|
|
kExprI32Add
|
|
|
|
]).exportFunc();
|
|
|
|
|
|
|
|
// writer(mem[i]);
|
|
|
|
// return mem[i] + some_value();
|
|
|
|
builder.addFunction("_wrap_writer", signature)
|
|
|
|
.addBody([
|
|
|
|
kExprGetLocal, 0,
|
2016-09-23 17:58:07 +00:00
|
|
|
kExprCallImport, kArity1, 1]);
|
|
|
|
builder.appendToTable([0, 1]);
|
2016-07-14 16:27:51 +00:00
|
|
|
|
|
|
|
|
|
|
|
var module = new WebAssembly.Module(builder.toBuffer());
|
|
|
|
var mem_1 = new ArrayBuffer(4);
|
|
|
|
var mem_2 = new ArrayBuffer(4);
|
|
|
|
var view_1 = new Int32Array(mem_1);
|
|
|
|
var view_2 = new Int32Array(mem_2);
|
|
|
|
|
|
|
|
view_1[0] = 42;
|
|
|
|
view_2[0] = 1000;
|
|
|
|
|
|
|
|
var outval_1;
|
|
|
|
var outval_2;
|
|
|
|
var i1 = new WebAssembly.Instance(module, {some_value: () => 1,
|
|
|
|
writer: (x)=>outval_1 = x }, mem_1);
|
|
|
|
var i2 = new WebAssembly.Instance(module, {some_value: () => 2,
|
|
|
|
writer: (x)=>outval_2 = x }, mem_2);
|
|
|
|
|
|
|
|
assertEquals(43, i1.exports.main(0));
|
|
|
|
assertEquals(1002, i2.exports.main(0));
|
|
|
|
|
|
|
|
assertEquals(42, outval_1);
|
|
|
|
assertEquals(1000, outval_2);
|
|
|
|
})();
|
2016-08-31 00:35:40 +00:00
|
|
|
|
|
|
|
(function GlobalsArePrivateToTheInstance() {
|
[wasm] reuse the first compiled module.
This change avoids needing to keep around an unused compiled
module. Instead, the result of compiling the wasm bytes is
given to the first instance. The module object and that instance object
point to the same compiled module. Instances are, then, cloned from
the compiled module the module object points to. When an instance is
collected, we make sure that the module object still has a clone
available, and, if the last instance is GC-ed, we also reset the compiled
module so that it does not reference its heap, so that it (==heap) may
be collected.
This is achieved by linking the clones in a double-linked list and
registering a finalizer for each. When we create an instance, we tie it
in the front of the list, making the module object point to it (O(1)). When
the finalizer is called, we relink the list over the dying object (O(1)). The
costliest operation is finalizing the last instance, since we need to visit
all wasm functions and reset heap references.
BUG=v8:5316
Committed: https://crrev.com/01f5af515728aebe6c5246f4f7dd6c573e8748af
Review-Url: https://codereview.chromium.org/2305903002
Cr-Original-Commit-Position: refs/heads/master@{#39153}
Cr-Commit-Position: refs/heads/master@{#39361}
2016-09-12 23:12:25 +00:00
|
|
|
var builder = new WasmModuleBuilder();
|
|
|
|
builder.addGlobal(kAstI32);
|
|
|
|
builder.addFunction("read", kSig_i_v)
|
|
|
|
.addBody([
|
|
|
|
kExprGetGlobal, 0])
|
|
|
|
.exportFunc();
|
|
|
|
|
|
|
|
builder.addFunction("write", kSig_v_i)
|
|
|
|
.addBody([
|
|
|
|
kExprGetLocal, 0,
|
|
|
|
kExprSetGlobal, 0])
|
|
|
|
.exportFunc();
|
|
|
|
|
|
|
|
var module = new WebAssembly.Module(builder.toBuffer());
|
|
|
|
var i1 = new WebAssembly.Instance(module);
|
|
|
|
var i2 = new WebAssembly.Instance(module);
|
|
|
|
i1.exports.write(1);
|
|
|
|
i2.exports.write(2);
|
|
|
|
assertEquals(1, i1.exports.read());
|
|
|
|
assertEquals(2, i2.exports.read());
|
|
|
|
})();
|
|
|
|
|
|
|
|
|
|
|
|
(function InstanceMemoryIsIsolated() {
|
2016-08-31 00:35:40 +00:00
|
|
|
var builder = new WasmModuleBuilder();
|
[wasm] reuse the first compiled module.
This change avoids needing to keep around an unused compiled
module. Instead, the result of compiling the wasm bytes is
given to the first instance. The module object and that instance object
point to the same compiled module. Instances are, then, cloned from
the compiled module the module object points to. When an instance is
collected, we make sure that the module object still has a clone
available, and, if the last instance is GC-ed, we also reset the compiled
module so that it does not reference its heap, so that it (==heap) may
be collected.
This is achieved by linking the clones in a double-linked list and
registering a finalizer for each. When we create an instance, we tie it
in the front of the list, making the module object point to it (O(1)). When
the finalizer is called, we relink the list over the dying object (O(1)). The
costliest operation is finalizing the last instance, since we need to visit
all wasm functions and reset heap references.
BUG=v8:5316
Committed: https://crrev.com/01f5af515728aebe6c5246f4f7dd6c573e8748af
Review-Url: https://codereview.chromium.org/2305903002
Cr-Original-Commit-Position: refs/heads/master@{#39153}
Cr-Commit-Position: refs/heads/master@{#39361}
2016-09-12 23:12:25 +00:00
|
|
|
builder.addMemory(1,1, true);
|
[wasm] reuse the first compiled module.
This change avoids needing to keep around an unused compiled
module. Instead, the result of compiling the wasm bytes is
given to the first instance. The module object and that instance object
point to the same compiled module. Instances are, then, cloned from
the compiled module the module object points to. When an instance is
collected, we make sure that the module object still has a clone
available, and, if the last instance is GC-ed, we also reset the compiled
module so that it does not reference its heap, so that it (==heap) may
be collected.
This is achieved by linking the clones in a double-linked list and
registering a finalizer for each. When we create an instance, we tie it
in the front of the list, making the module object point to it (O(1)). When
the finalizer is called, we relink the list over the dying object (O(1)). The
costliest operation is finalizing the last instance, since we need to visit
all wasm functions and reset heap references.
BUG=v8:5316
Review-Url: https://codereview.chromium.org/2305903002
Cr-Commit-Position: refs/heads/master@{#39153}
2016-09-05 10:08:02 +00:00
|
|
|
|
[wasm] reuse the first compiled module.
This change avoids needing to keep around an unused compiled
module. Instead, the result of compiling the wasm bytes is
given to the first instance. The module object and that instance object
point to the same compiled module. Instances are, then, cloned from
the compiled module the module object points to. When an instance is
collected, we make sure that the module object still has a clone
available, and, if the last instance is GC-ed, we also reset the compiled
module so that it does not reference its heap, so that it (==heap) may
be collected.
This is achieved by linking the clones in a double-linked list and
registering a finalizer for each. When we create an instance, we tie it
in the front of the list, making the module object point to it (O(1)). When
the finalizer is called, we relink the list over the dying object (O(1)). The
costliest operation is finalizing the last instance, since we need to visit
all wasm functions and reset heap references.
BUG=v8:5316
Committed: https://crrev.com/01f5af515728aebe6c5246f4f7dd6c573e8748af
Review-Url: https://codereview.chromium.org/2305903002
Cr-Original-Commit-Position: refs/heads/master@{#39153}
Cr-Commit-Position: refs/heads/master@{#39361}
2016-09-12 23:12:25 +00:00
|
|
|
builder.addFunction("f", kSig_i)
|
Revert of [wasm] reuse the first compiled module (patchset #12 id:220001 of https://codereview.chromium.org/2305903002/ )
Reason for revert:
mac gc stress failures:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/8341
Original issue's description:
> [wasm] reuse the first compiled module.
>
> This change avoids needing to keep around an unused compiled
> module. Instead, the result of compiling the wasm bytes is
> given to the first instance. The module object and that instance object
> point to the same compiled module. Instances are, then, cloned from
> the compiled module the module object points to. When an instance is
> collected, we make sure that the module object still has a clone
> available, and, if the last instance is GC-ed, we also reset the compiled
> module so that it does not reference its heap, so that it (==heap) may
> be collected.
>
> This is achieved by linking the clones in a double-linked list and
> registering a finalizer for each. When we create an instance, we tie it
> in the front of the list, making the module object point to it (O(1)). When
> the finalizer is called, we relink the list over the dying object (O(1)). The
> costliest operation is finalizing the last instance, since we need to visit
> all wasm functions and reset heap references.
>
> BUG=v8:5316
>
> Committed: https://crrev.com/01f5af515728aebe6c5246f4f7dd6c573e8748af
> Cr-Commit-Position: refs/heads/master@{#39153}
TBR=bradnelson@chromium.org,verwaest@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,mtrofin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5316
Review-Url: https://codereview.chromium.org/2306403002
Cr-Commit-Position: refs/heads/master@{#39154}
2016-09-05 10:49:33 +00:00
|
|
|
.addBody([
|
[wasm] reuse the first compiled module.
This change avoids needing to keep around an unused compiled
module. Instead, the result of compiling the wasm bytes is
given to the first instance. The module object and that instance object
point to the same compiled module. Instances are, then, cloned from
the compiled module the module object points to. When an instance is
collected, we make sure that the module object still has a clone
available, and, if the last instance is GC-ed, we also reset the compiled
module so that it does not reference its heap, so that it (==heap) may
be collected.
This is achieved by linking the clones in a double-linked list and
registering a finalizer for each. When we create an instance, we tie it
in the front of the list, making the module object point to it (O(1)). When
the finalizer is called, we relink the list over the dying object (O(1)). The
costliest operation is finalizing the last instance, since we need to visit
all wasm functions and reset heap references.
BUG=v8:5316
Committed: https://crrev.com/01f5af515728aebe6c5246f4f7dd6c573e8748af
Review-Url: https://codereview.chromium.org/2305903002
Cr-Original-Commit-Position: refs/heads/master@{#39153}
Cr-Commit-Position: refs/heads/master@{#39361}
2016-09-12 23:12:25 +00:00
|
|
|
kExprI32Const, 0,
|
|
|
|
kExprI32LoadMem, 0, 0
|
|
|
|
]).exportFunc();
|
|
|
|
|
|
|
|
var mem_1 = new ArrayBuffer(65536);
|
|
|
|
var mem_2 = new ArrayBuffer(65536);
|
|
|
|
var view_1 = new Int32Array(mem_1);
|
|
|
|
var view_2 = new Int32Array(mem_2);
|
|
|
|
view_1[0] = 1;
|
|
|
|
view_2[0] = 1000;
|
2016-08-31 00:35:40 +00:00
|
|
|
|
|
|
|
var module = new WebAssembly.Module(builder.toBuffer());
|
[wasm] reuse the first compiled module.
This change avoids needing to keep around an unused compiled
module. Instead, the result of compiling the wasm bytes is
given to the first instance. The module object and that instance object
point to the same compiled module. Instances are, then, cloned from
the compiled module the module object points to. When an instance is
collected, we make sure that the module object still has a clone
available, and, if the last instance is GC-ed, we also reset the compiled
module so that it does not reference its heap, so that it (==heap) may
be collected.
This is achieved by linking the clones in a double-linked list and
registering a finalizer for each. When we create an instance, we tie it
in the front of the list, making the module object point to it (O(1)). When
the finalizer is called, we relink the list over the dying object (O(1)). The
costliest operation is finalizing the last instance, since we need to visit
all wasm functions and reset heap references.
BUG=v8:5316
Committed: https://crrev.com/01f5af515728aebe6c5246f4f7dd6c573e8748af
Review-Url: https://codereview.chromium.org/2305903002
Cr-Original-Commit-Position: refs/heads/master@{#39153}
Cr-Commit-Position: refs/heads/master@{#39361}
2016-09-12 23:12:25 +00:00
|
|
|
var i1 = new WebAssembly.Instance(module, null, mem_1);
|
|
|
|
var i2 = new WebAssembly.Instance(module, null, mem_2);
|
|
|
|
|
|
|
|
assertEquals(1, i1.exports.f());
|
|
|
|
assertEquals(1000, i2.exports.f());
|
2016-08-31 00:35:40 +00:00
|
|
|
})();
|