AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Don't report failed map check as failed instance migration.

Browse Source 
Failed instance migration should only be reported if the map of the
object was originally marked as deprecated. Otherwise it's pretty
confusing to investigate deoptimizations.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2700143002
Cr-Commit-Position: refs/heads/master@{#43293}
This commit is contained in:
bmeurer 2017-02-17 11:15:26 -08:00 committed by Commit bot
parent 4dfd5e5ee2
commit 00a379a03e
1 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/compiler/effect-control-linearizer.cc
View File

@ -1102,16 +1102,14 @@ Node* EffectControlLinearizer::LowerCheckMaps(Node* node, Node* frame_state) {
// Perform the (deferred) instance migration.
__ Bind(&migrate);
{
auto migration_failed = __ MakeLabel<2>();
auto retry_check_maps = __ MakeLabel<2>();
// If map is not deprecated the migration attempt does not make sense.
Node* bitfield3 =
__ LoadField(AccessBuilder::ForMapBitField3(), value_map);
Node* if_not_deprecated = __ WordEqual(
__ Word32And(bitfield3, __ Int32Constant(Map::Deprecated::kMask)),
__ Int32Constant(0));
__ GotoIf(if_not_deprecated, &migration_failed);
__ DeoptimizeIf(DeoptimizeReason::kWrongMap, if_not_deprecated,
frame_state);
Operator::Properties properties = Operator::kNoDeopt | Operator::kNoThrow;
Runtime::FunctionId id = Runtime::kTryMigrateInstance;
@ -1122,15 +1120,8 @@ Node* EffectControlLinearizer::LowerCheckMaps(Node* node, Node* frame_state) {
__ ExternalConstant(ExternalReference(id, isolate())),
__ Int32Constant(1), __ NoContextConstant());
Node* check = ObjectIsSmi(result);
__ GotoIf(check, &retry_check_maps);
__ Goto(&migration_failed);
__ Bind(&migration_failed);
__ DeoptimizeIf(DeoptimizeReason::kInstanceMigrationFailed,
__ Int32Constant(1), frame_state);
__ Goto(&retry_check_maps);
__ Bind(&retry_check_maps);
__ DeoptimizeIf(DeoptimizeReason::kInstanceMigrationFailed, check,
frame_state);
}
// Reload the current map of the {value}.