From 00bb1a77c03ec951a5def21c64bee38cd855be7b Mon Sep 17 00:00:00 2001 From: Darshan Sen Date: Tue, 17 Aug 2021 20:26:20 +0530 Subject: [PATCH] [date] Fix Date#getMinutes() test failures After building V8 using Clang (./out/x64.release/v8_build_config.json says that "is_clang" is true), I could reproduce the referenced bug report locally. Replacing the getMinutes() calls with getUTCMinutes() calls fixed the test failure. Signed-off-by: Darshan Sen Bug: v8:11200 Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362 Reviewed-by: Toon Verwaest Commit-Queue: Toon Verwaest Cr-Commit-Position: refs/heads/main@{#76367} --- AUTHORS | 1 + test/mjsunit/regress/regress-crbug-422858.js | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/AUTHORS b/AUTHORS index 8a5cc08787..34bd4c57c6 100644 --- a/AUTHORS +++ b/AUTHORS @@ -86,6 +86,7 @@ Daniel Andersson Daniel Bevenius Daniel Dromboski Daniel James +Darshan Sen David Carlier David Manouchehri Deepak Mohan diff --git a/test/mjsunit/regress/regress-crbug-422858.js b/test/mjsunit/regress/regress-crbug-422858.js index ba75fc01a4..bede64025e 100644 --- a/test/mjsunit/regress/regress-crbug-422858.js +++ b/test/mjsunit/regress/regress-crbug-422858.js @@ -3,21 +3,21 @@ // found in the LICENSE file. var date = new Date("2016/01/02 10:00 GMT-8") -assertEquals(0, date.getMinutes()); +assertEquals(0, date.getUTCMinutes()); assertEquals(18, date.getUTCHours()); date = new Date("2016/01/02 10:00 GMT-12") -assertEquals(0, date.getMinutes()); +assertEquals(0, date.getUTCMinutes()); assertEquals(22, date.getUTCHours()); date = new Date("2016/01/02 10:00 GMT-123") -assertEquals(23, date.getMinutes()); +assertEquals(23, date.getUTCMinutes()); assertEquals(11, date.getUTCHours()); date = new Date("2016/01/02 10:00 GMT-0856") -assertEquals(56, date.getMinutes()); +assertEquals(56, date.getUTCMinutes()); assertEquals(18, date.getUTCHours()); date = new Date("2016/01/02 10:00 GMT-08000") -assertEquals(NaN, date.getMinutes()); +assertEquals(NaN, date.getUTCMinutes()); assertEquals(NaN, date.getUTCHours());