AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[node] reset node checkout on v8 update"

Browse Source 
This reverts commit ccfa4ca742.

Reason for revert: Infra supports this now.

Original change's description:
> [node] reset node checkout on v8 update
> 
> This is a temporary measure to get bots back in order.
> 
> Bug: chromium:860430
> 
> TBR=machenbach@chromium.org
> 
> Change-Id: I3275150f4bc5dfe8ab90984e15f8a1a469d70caf
> Reviewed-on: https://chromium-review.googlesource.com/1127166
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54269}

TBR=machenbach@chromium.org,yangguo@chromium.org

Change-Id: I6a74ab702fd32b278caebb665be6868b4712dffb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:860430
Reviewed-on: https://chromium-review.googlesource.com/1127721
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54287}
This commit is contained in:
Yang Guo 2018-07-06 09:41:09 +00:00 committed by Commit Bot
parent 1299ba9681
commit 00ff6b014d
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/node/update_node.py
View File

@ -81,12 +81,6 @@ def CommitPatch(options):
cwd=options.v8_path,
)
def ResetTarget(path):
"""Temporarily use this to clear the checkout on the bots"""
print ">> Resetting Node.js checkout"
subprocess.check_call(["git", "reset", "--hard"], cwd=path)
subprocess.check_call(["git", "clean", "-fxd"], cwd=path)
def UpdateTarget(repository, options, files_to_keep):
source = os.path.join(options.v8_path, *repository)
target = os.path.join(options.node_path, TARGET_SUBDIR, *repository)
@ -174,7 +168,6 @@ def Main(args):
if options.gclient:
RunGclient(options.v8_path)
# Commit patch on trybots to main V8 repository.
ResetTarget(options.node_path)
if options.with_patch:
CommitPatch(options)
# Update main V8 repository.