AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[infra] Make no-fail the default for numfuzz builders

Browse Source 
Remove infra-staging from numfuzz builders and add
no-fail instead. Also remove the staging builders.

Bug: v8:11826
Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg_ng,v8_numfuzz_ng,v8_numfuzz_tsan_ng
Change-Id: Icd7bc6275b5c78e38f0e75b5d133b3b7056f333e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182233
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77142}
This commit is contained in:
Al Muthanna Athamina 2021-09-29 16:42:41 +02:00 committed by V8 LUCI CQ
parent 51ebc66349
commit 010d43d2de
3 changed files with 32 additions and 192 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

208
infra/testing/builders.pyl
View File

@ -2048,6 +2048,11 @@
'suffix': 'threads',
'test_args': ['--total-timeout-sec=2100', '--stress-thread-pool-size=1']
},
{
'name': 'numfuzz',
'suffix': 'stack',
'test_args': ['--total-timeout-sec=2100', '--stress-stack-size=1']
},
{
'name': 'numfuzz',
'suffix': 'combined',
@ -2060,6 +2065,7 @@
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
'--stress-stack-size=1',
],
'shards': 4
},
@ -2097,6 +2103,11 @@
'suffix': 'threads',
'test_args': ['--total-timeout-sec=2100', '--stress-thread-pool-size=1']
},
{
'name': 'numfuzz',
'suffix': 'stack',
'test_args': ['--total-timeout-sec=2100', '--stress-stack-size=1']
},
{
'name': 'numfuzz',
'suffix': 'combined',
@ -2109,6 +2120,7 @@
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
'--stress-stack-size=1',
],
'shards': 3
},
@ -2125,171 +2137,22 @@
},
],
},
'V8 NumFuzz - staging': {
'swarming_dimensions': {
'os': 'Ubuntu-18.04',
},
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [
{
'name': 'numfuzz',
'suffix': 'deopt',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-deopt=1']
},
],
},
'V8 NumFuzz - TSAN - staging': {
'swarming_dimensions': {
'os': 'Ubuntu-18.04',
},
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [
{'name': 'd8testing_random_gc', 'shards': 2},
{
'name': 'numfuzz',
'suffix': 'marking',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-marking=1']
},
{
'name': 'numfuzz',
'suffix': 'delay',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-delay-tasks=1']
},
{
'name': 'numfuzz',
'suffix': 'threads',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-thread-pool-size=1']
},
{
'name': 'numfuzz',
'suffix': 'stack',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-stack-size=1']
},
{
'name': 'numfuzz',
'suffix': 'combined',
'test_args': [
'--infra-staging',
'--total-timeout-sec=2100',
'--stress-delay-tasks=4',
'--stress-deopt=2',
'--stress-compaction=2',
'--stress-gc=4',
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
'--stress-stack-size=1',
],
'shards': 4
},
{
'name': 'numfuzz',
'suffix': 'scavenge',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-scavenge=1']
},
],
},
'V8 NumFuzz - debug - staging': {
'swarming_dimensions': {
'os': 'Ubuntu-18.04',
},
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [
{'name': 'd8testing_random_gc'},
{
'name': 'numfuzz',
'suffix': 'marking',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-marking=1'],
'shards': 2
},
{
'name': 'numfuzz',
'suffix': 'delay',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-delay-tasks=1']
},
{
'name': 'numfuzz',
'suffix': 'threads',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-thread-pool-size=1']
},
{
'name': 'numfuzz',
'suffix': 'stack',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-stack-size=1']
},
{
'name': 'numfuzz',
'suffix': 'combined',
'test_args': [
'--infra-staging',
'--total-timeout-sec=2100',
'--stress-delay-tasks=4',
'--stress-deopt=2',
'--stress-compaction=2',
'--stress-gc=4',
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
'--stress-stack-size=1',
],
'shards': 3
},
{
'name': 'numfuzz',
'suffix': 'scavenge',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-scavenge=1']
},
{
'name': 'numfuzz',
'suffix': 'deopt',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-deopt=1'],
'shards': 2
},
],
},
'v8_numfuzz_ng_triggered': {
'swarming_dimensions': {
'os': 'Ubuntu-18.04',
},
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [
{
'name': 'numfuzz',
'suffix': 'deopt',
'test_args': ['--total-timeout-sec=900', '--stress-deopt=1']
},
{
'name': 'numfuzz',
'suffix': 'deopt-staging',
'test_args': ['--infra-staging', '--total-timeout-sec=900', '--stress-deopt=1']
},
],
},
'v8_numfuzz_tsan_ng_triggered': {
'swarming_dimensions': {
'os': 'Ubuntu-18.04',
},
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [
{
'name': 'numfuzz',
@ -2306,6 +2169,11 @@
'suffix': 'threads',
'test_args': ['--total-timeout-sec=900', '--stress-thread-pool-size=1']
},
{
'name': 'numfuzz',
'suffix': 'stack',
'test_args': ['--total-timeout-sec=900', '--stress-stack-size=1']
},
{
'name': 'numfuzz',
'suffix': 'combined',
@ -2318,21 +2186,7 @@
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
],
},
{
'name': 'numfuzz',
'suffix': 'combined-staging',
'test_args': [
'--infra-staging',
'--total-timeout-sec=900',
'--stress-delay-tasks=4',
'--stress-deopt=2',
'--stress-compaction=2',
'--stress-gc=4',
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
'--stress-stack-size=1',
],
},
{
@ -2346,11 +2200,6 @@
'swarming_dimensions': {
'os': 'Ubuntu-18.04',
},
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [
{'name': 'd8testing_random_gc'},
{
@ -2368,6 +2217,11 @@
'suffix': 'threads',
'test_args': ['--total-timeout-sec=900', '--stress-thread-pool-size=1']
},
{
'name': 'numfuzz',
'suffix': 'stack',
'test_args': ['--total-timeout-sec=900', '--stress-stack-size=1']
},
{
'name': 'numfuzz',
'suffix': 'combined',
@ -2380,21 +2234,7 @@
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
],
},
{
'name': 'numfuzz',
'suffix': 'combined-staging',
'test_args': [
'--infra-staging',
'--total-timeout-sec=900',
'--stress-delay-tasks=4',
'--stress-deopt=2',
'--stress-compaction=2',
'--stress-gc=4',
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
'--stress-stack-size=1',
],
},
{

10
tools/testrunner/num_fuzzer.py
View File

@ -124,9 +124,11 @@ class NumFuzzer(base_runner.BaseTestRunner):
def _runner_flags(self):
"""Extra default flags specific to the test runner implementation."""
flags = ['--no-abort-on-contradictory-flags', '--testing-d8-test-runner']
if self.infra_staging:
flags.append('--no-fail')
flags = [
'--no-abort-on-contradictory-flags',
'--testing-d8-test-runner',
'--no-fail'
]
return flags
def _get_statusfile_variables(self, options):
@ -163,7 +165,7 @@ class NumFuzzer(base_runner.BaseTestRunner):
# TODO(majeski): Improve sharding when combiner is present. Maybe select
# different random seeds for shards instead of splitting tests.
self._create_shard_proc(options),
ExpectationProc(self.infra_staging),
ExpectationProc(),
combiner,
self._create_fuzzer(fuzzer_rng, options),
sigproc,

6
tools/testrunner/testproc/expectation.py
View File

@ -9,15 +9,13 @@ from testrunner.outproc import base as outproc
class ExpectationProc(base.TestProcProducer):
"""Test processor passing tests and results through and forgiving timeouts."""
def __init__(self, infra_staging):
def __init__(self):
super(ExpectationProc, self).__init__('no-timeout')
self.infra_staging = infra_staging
def _next_test(self, test):
subtest = self._create_subtest(test, 'no_timeout')
subtest.allow_timeouts()
if self.infra_staging:
subtest.allow_pass()
subtest.allow_pass()
return self._send_test(subtest)
def _result_for(self, test, subtest, result):