From 01821ab3b6d9108572ca564801e13ceccf17e1e5 Mon Sep 17 00:00:00 2001 From: Clemens Hammacher Date: Thu, 2 May 2019 11:16:12 +0200 Subject: [PATCH] [test] Stress wasm code gc in "stress_background_compile" The "stress_background_compile" variant runs on all our bots. We combine it with testing wasm code GC (which kind of fits into background compile stressing) to get more coverage for that. Both features are orthogonal, so we can test both at the same time without loosing any coverage. R=machenbach@chromium.org CC=rmcilroy@chromium.org Bug: v8:8217 Change-Id: Ib17decd4869978ff98e302694fa73d70ceec120e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588472 Reviewed-by: Ross McIlroy Reviewed-by: Michael Achenbach Commit-Queue: Clemens Hammacher Cr-Commit-Position: refs/heads/master@{#61151} --- test/cctest/cctest.status | 4 ++-- test/webkit/webkit.status | 4 ++-- tools/testrunner/local/variants.py | 4 +++- tools/testrunner/standard_runner.py | 2 +- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status index 481f18fa03..c5cd7533f7 100644 --- a/test/cctest/cctest.status +++ b/test/cctest/cctest.status @@ -418,9 +418,9 @@ ############################################################################## # The test relies on deterministic compilation. -['variant == stress_background_compile', { +['variant == stress_js_bg_compile_wasm_code_gc', { 'test-compiler/DecideToPretenureDuringCompilation': [SKIP], -}], # variant == stress_background_compile +}], # variant == stress_js_bg_compile_wasm_code_gc ############################################################################## ['variant == no_wasm_traps', { diff --git a/test/webkit/webkit.status b/test/webkit/webkit.status index 82584b56fe..c15c3b62e5 100644 --- a/test/webkit/webkit.status +++ b/test/webkit/webkit.status @@ -109,10 +109,10 @@ }], # arch == arm64 and msan ############################################################################## -['variant in [nooptimization, stress, stress_background_compile] and (arch == arm or arch == arm64) and simulator_run', { +['variant in [nooptimization, stress, stress_js_bg_compile_wasm_code_gc] and (arch == arm or arch == arm64) and simulator_run', { # Slow tests: https://crbug.com/v8/7783 'dfg-double-vote-fuzz': [SKIP], -}], # variant in [nooptimization, stress, stress_background_compile] and (arch == arm or arch == arm64) and simulator_run +}], # variant in [nooptimization, stress, stress_js_bg_compile_wasm_code_gc] and (arch == arm or arch == arm64) and simulator_run ############################################################################## ['gcov_coverage', { diff --git a/tools/testrunner/local/variants.py b/tools/testrunner/local/variants.py index ed9b1b87f5..dc92db6099 100644 --- a/tools/testrunner/local/variants.py +++ b/tools/testrunner/local/variants.py @@ -23,7 +23,9 @@ ALL_VARIANT_FLAGS = { "slow_path": [["--force-slow-path"]], "stress": [["--stress-opt", "--always-opt", "--no-liftoff", "--no-wasm-tier-up"]], - "stress_background_compile": [["--stress-background-compile"]], + "stress_js_bg_compile_wasm_code_gc": [["--stress-background-compile", + "--wasm-code-gc", + "--stress-wasm-code-gc"]], "stress_incremental_marking": [["--stress-incremental-marking"]], # Trigger stress sampling allocation profiler with sample interval = 2^14 "stress_sampling": [["--stress-sampling-allocation-profiler=16384"]], diff --git a/tools/testrunner/standard_runner.py b/tools/testrunner/standard_runner.py index 25b6bf0756..bc79c015bd 100755 --- a/tools/testrunner/standard_runner.py +++ b/tools/testrunner/standard_runner.py @@ -34,7 +34,7 @@ VARIANTS = ['default'] MORE_VARIANTS = [ 'jitless', 'stress', - 'stress_background_compile', + 'stress_js_bg_compile_wasm_code_gc', 'stress_incremental_marking', ]