AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Remove dead field from AsyncStreamingProcessor

Browse Source 
The {async_counters_} field is not used, so we should remove it.

R=ahaas@chromium.org

Bug: v8:13447
Change-Id: I55c335b65f0ab12f8ccc4969741908cb33e1fa8b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4067024
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84612}
This commit is contained in:
Clemens Backes 2022-12-01 18:42:29 +01:00 committed by V8 LUCI CQ
parent 95cdb3c573
commit 01ec9f47b2
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/wasm/module-compiler.cc
View File

@ -2099,8 +2099,7 @@ void AsyncCompileJob::Abort() {
class AsyncStreamingProcessor final : public StreamingProcessor {
public:
explicit AsyncStreamingProcessor(AsyncCompileJob* job,
std::shared_ptr<Counters> counters);
explicit AsyncStreamingProcessor(AsyncCompileJob* job);
~AsyncStreamingProcessor() override;
@ -2145,7 +2144,6 @@ class AsyncStreamingProcessor final : public StreamingProcessor {
int num_functions_ = 0;
bool prefix_cache_hit_ = false;
bool before_code_section_ = true;
std::shared_ptr<Counters> async_counters_;
// Running hash of the wire bytes up to code section size, but excluding the
// code section itself. Used by the {NativeModuleCache} to detect potential
@ -2156,8 +2154,7 @@ class AsyncStreamingProcessor final : public StreamingProcessor {
std::shared_ptr<StreamingDecoder> AsyncCompileJob::CreateStreamingDecoder() {
DCHECK_NULL(stream_);
stream_ = StreamingDecoder::CreateAsyncStreamingDecoder(
std::make_unique<AsyncStreamingProcessor>(this,
isolate_->async_counters()));
std::make_unique<AsyncStreamingProcessor>(this));
return stream_;
}
@ -2724,12 +2721,10 @@ void AsyncCompileJob::FinishModule() {
GetWasmEngine()->RemoveCompileJob(this);
}
AsyncStreamingProcessor::AsyncStreamingProcessor(
AsyncCompileJob* job, std::shared_ptr<Counters> async_counters)
AsyncStreamingProcessor::AsyncStreamingProcessor(AsyncCompileJob* job)
: decoder_(job->enabled_features_),
job_(job),
compilation_unit_builder_(nullptr),
async_counters_(async_counters) {}
compilation_unit_builder_(nullptr) {}
AsyncStreamingProcessor::~AsyncStreamingProcessor() {
if (job_->native_module_ && job_->native_module_->wire_bytes().empty()) {