From 027f8d11c717e033a2178b5eeb940db93d90ed71 Mon Sep 17 00:00:00 2001 From: "whesse@chromium.org" Date: Thu, 30 Jul 2009 08:11:25 +0000 Subject: [PATCH] X64: Change wording of comments. Review URL: http://codereview.chromium.org/160381 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2583 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/x64/codegen-x64.cc | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc index fb9f1d2a92..769a8ee13b 100644 --- a/src/x64/codegen-x64.cc +++ b/src/x64/codegen-x64.cc @@ -4976,14 +4976,14 @@ void CodeGenerator::LikelySmiBinaryOperation(Token::Value op, // Complete the operation. if (op == Token::DIV) { - // Check for negative zero result. If result is zero, and divisor - // is negative, return a floating point negative zero. The jump - // to non_zero_result is safe w.r.t. the frame. + // Check for negative zero result. If the result is zero, and the + // divisor is negative, return a floating point negative zero. Label non_zero_result; __ testl(left->reg(), left->reg()); __ j(not_zero, &non_zero_result); __ testl(right->reg(), right->reg()); deferred->Branch(negative); + // The frame is identical on all paths reaching this label. __ bind(&non_zero_result); // Check for the corner case of dividing the most negative smi by // -1. We cannot use the overflow flag, since it is not set by @@ -5003,15 +5003,14 @@ void CodeGenerator::LikelySmiBinaryOperation(Token::Value op, frame_->Push("ient); } else { ASSERT(op == Token::MOD); - // Check for a negative zero result. If the result is zero, and - // the dividend is negative, return a floating point negative - // zero. The frame is unchanged between the jump to &non_zero_result - // and the target, so a Label can be used. + // Check for a negative zero result. If the result is zero, and the + // dividend is negative, return a floating point negative zero. Label non_zero_result; __ testl(rdx, rdx); __ j(not_zero, &non_zero_result); __ testl(left->reg(), left->reg()); deferred->Branch(negative); + // The frame is identical on all paths reaching this label. __ bind(&non_zero_result); deferred->BindExit(); left->Unuse();