[Temporal] Sync BalanceISODate to PR 2178

Only change the implementation in BalanceISODate from
https://github.com/tc39/proposal-temporal/pull/2178/files#diff-113bc23f7ddc769c78deac4268f2400a0a8ca75258f4a6a8af8219cf430a0788

Changes of other AOs in that PR is not in this cl.

Note: Split from cl/3864358

Bug: v8:11544
Change-Id: I8c8514642cdb522975b23bcc9c2bb9eb56cb2839
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3892177
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83141}

src/objects/js-temporal-objects.cc

@@ -4964,80 +4964,43 @@ Handle<String> UnitToString(Isolate* isolate, Unit unit) {
   }
 }
 
+// #sec-temporal-create-iso-date-record
+DateRecordCommon CreateISODateRecord(Isolate* isolate,
+                                     const DateRecordCommon& date) {
+  // 1. Assert: IsValidISODate(year, month, day) is true.
+  DCHECK(IsValidISODate(isolate, date));
+  // 2. Return the Record { [[Year]]: year, [[Month]]: month, [[Day]]: day }.
+  return date;
+}
+
 // #sec-temporal-balanceisodate
 DateRecordCommon BalanceISODate(Isolate* isolate,
                                 const DateRecordCommon& date) {
   TEMPORAL_ENTER_FUNC();
+  // 1. Let epochDays be MakeDay(𝔽(year), 𝔽(month - 1), 𝔽(day)).
+  double epoch_days = MakeDay(date.year, date.month - 1, date.day);
+  // 2. Assert: epochDays is finite.
+  DCHECK(std::isfinite(epoch_days));
+  // 3. Let ms be MakeDate(epochDays, +0𝔽).
+  double ms = MakeDate(epoch_days, 0);
+  // 4. Return CreateISODateRecord(ℝ(YearFromTime(ms)), ℝ(MonthFromTime(ms)) +
+  // 1, ℝ(DateFromTime(ms))).
+  int year = 0;
+  int month = 0;
+  int day = 0;
+  int wday = 0;
+  int hour = 0;
+  int minute = 0;
+  int second = 0;
+  int millisecond = 0;
 
-  DateRecordCommon result = date;
+  DCHECK(std::isfinite(ms));
-  // 1. Assert: year, month, and day are integers.
+  DCHECK_LT(ms, static_cast<double>(std::numeric_limits<int64_t>::max()));
-  // 2. Let balancedYearMonth be ! BalanceISOYearMonth(year, month).
+  DCHECK_GT(ms, static_cast<double>(std::numeric_limits<int64_t>::min()));
-  // 3. Set month to balancedYearMonth.[[Month]].
+  isolate->date_cache()->BreakDownTime(ms, &year, &month, &day, &wday, &hour,
-  // 4. Set year to balancedYearMonth.[[Year]].
+                                       &minute, &second, &millisecond);
-  BalanceISOYearMonth(isolate, &(result.year), &(result.month));
+
-  // 5. NOTE: To deal with negative numbers of days whose absolute value is
+  return CreateISODateRecord(isolate, {year, month + 1, day});
-  // greater than the number of days in a year, the following section subtracts
-  // years and adds days until the number of days is greater than −366 or −365.
-  // 6. If month > 2, then
-  // a. Let testYear be year.
-  // 7. Else,
-  // a. Let testYear be year − 1.
-  int32_t test_year = (date.month > 2) ? date.year : date.year - 1;
-  // 8. Repeat, while day < −1 × ! ISODaysInYear(testYear),
-  int32_t iso_days_in_year;
-  while (result.day < -(iso_days_in_year = ISODaysInYear(isolate, test_year))) {
-    // a. Set day to day + ! ISODaysInYear(testYear).
-    result.day += iso_days_in_year;
-    // b. Set year to year − 1.
-    (result.year)--;
-    // c. Set testYear to testYear − 1.
-    test_year--;
-  }
-  // 9. NOTE: To deal with numbers of days greater than the number of days in a
-  // year, the following section adds years and subtracts days until the number
-  // of days is less than 366 or 365.
-  // 10. Let testYear be year + 1.
-  test_year = (result.year) + 1;
-  // 11. Repeat, while day > ! ISODaysInYear(testYear),
-  while (result.day > (iso_days_in_year = ISODaysInYear(isolate, test_year))) {
-    // a. Set day to day − ! ISODaysInYear(testYear).
-    result.day -= iso_days_in_year;
-    // b. Set year to year + 1.
-    result.year++;
-    // c. Set testYear to testYear + 1.
-    test_year++;
-  }
-  // 12. NOTE: To deal with negative numbers of days whose absolute value is
-  // greater than the number of days in the current month, the following section
-  // subtracts months and adds days until the number of days is greater than 0.
-  // 13. Repeat, while day < 1,
-  while (result.day < 1) {
-    // a. Set balancedYearMonth to ! BalanceISOYearMonth(year, month − 1).
-    // b. Set year to balancedYearMonth.[[Year]].
-    // c. Set month to balancedYearMonth.[[Month]].
-    result.month -= 1;
-    BalanceISOYearMonth(isolate, &(result.year), &(result.month));
-    // d. Set day to day + ! ISODaysInMonth(year, month).
-    result.day += ISODaysInMonth(isolate, result.year, result.month);
-  }
-  // 14. NOTE: To deal with numbers of days greater than the number of days in
-  // the current month, the following section adds months and subtracts days
-  // until the number of days is less than the number of days in the month.
-  // 15. Repeat, while day > ! ISODaysInMonth(year, month),
-  int32_t iso_days_in_month;
-  while (result.day > (iso_days_in_month = ISODaysInMonth(isolate, result.year,
-                                                          result.month))) {
-    // a. Set day to day − ! ISODaysInMonth(year, month).
-    result.day -= iso_days_in_month;
-    // b. Set balancedYearMonth to ! BalanceISOYearMonth(year, month + 1).
-    // c. Set year to balancedYearMonth.[[Year]].
-    // d. Set month to balancedYearMonth.[[Month]].
-    result.month += 1;
-    BalanceISOYearMonth(isolate, &(result.year), &(result.month));
-  }
-  // 16. Return the new Record { [[Year]]: year, [[Month]]: month, [[Day]]: day
-  // }.
-  return result;
 }
 
 // #sec-temporal-adddatetime

test/test262/test262.status

@@ -444,10 +444,6 @@
   'built-ins/RegExp/prototype/Symbol.replace/get-flags-err': [FAIL],
   'built-ins/RegExp/prototype/Symbol.replace/get-unicode-error': [FAIL],
 
-  # PlainTime RelativeTime
-  # https://github.com/tc39/proposal-temporal/pull/1862
-  'built-ins/Temporal/Duration/prototype/total/timezone-getpossibleinstantsfor-iterable': [FAIL],
-
   # https://bugs.chromium.org/p/v8/issues/detail?id=11544
   'built-ins/Temporal/Duration/prototype/total/balance-negative-result': [FAIL],
   'intl402/Temporal/Calendar/prototype/dateFromFields/infinity-throws-rangeerror': [FAIL],
@@ -530,7 +526,6 @@
   'built-ins/Temporal/Duration/prototype/subtract/relativeto-propertybag-calendar-number': [FAIL],
   'built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-calendar-number': [FAIL],
 
-  'built-ins/Temporal/Duration/prototype/add/relativeto-year': [FAIL],
   'intl402/Temporal/Calendar/prototype/dateFromFields/order-of-operations': [FAIL],
   'intl402/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations': [FAIL],
   'intl402/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations': [FAIL],
@@ -554,7 +549,6 @@
   'staging/Temporal/Regex/old/timezone': [FAIL],
   'staging/Temporal/TimeZone/old/getNextTransition': [FAIL],
   'staging/Temporal/TimeZone/old/subminute-offset': [FAIL],
-  'staging/Temporal/UserCalendar/old/trivial-protocol-implementation': [FAIL],
   'staging/Temporal/ZonedDateTime/old/construction-and-properties': [FAIL],
   'staging/Temporal/ZonedDateTime/old/dst-math': [FAIL],
   'staging/Temporal/ZonedDateTime/old/dst-properties': [FAIL],