AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Remove sloppy-ness from SetAccumulator

Browse Source 
Bug: v8:9810
Change-Id: I7bf617680e2e4029553d44ae4d11990ffd7a8a7a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914212
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64949}
This commit is contained in:
Santiago Aboy Solanes 2019-11-13 15:09:10 +00:00 committed by Commit Bot
parent 7186b60147
commit 03b2be79c0
4 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/interpreter/interpreter-assembler.cc
View File

@ -157,8 +157,7 @@ TNode<Object> InterpreterAssembler::GetAccumulator() {
return TaggedPoisonOnSpeculation(GetAccumulatorUnchecked());
}
// TODO(v8:6949): Remove sloppy-ness from SetAccumulator's value argument.
void InterpreterAssembler::SetAccumulator(SloppyTNode<Object> value) {
void InterpreterAssembler::SetAccumulator(TNode<Object> value) {
DCHECK(Bytecodes::WritesAccumulator(bytecode_));
accumulator_use_ = accumulator_use_ | AccumulatorUse::kWrite;
accumulator_ = value;

2
src/interpreter/interpreter-assembler.h
View File

@ -67,7 +67,7 @@ class V8_EXPORT_PRIVATE InterpreterAssembler : public CodeStubAssembler {
TNode<Uint32T> BytecodeOperandIntrinsicId(int operand_index);
// Accumulator.
TNode<Object> GetAccumulator();
void SetAccumulator(SloppyTNode<Object> value);
void SetAccumulator(TNode<Object> value);
// Context.
TNode<Context> GetContext();

2
src/interpreter/interpreter-generator.cc
View File

@ -1692,7 +1692,7 @@ IGNITION_HANDLER(CallRuntime, InterpreterAssembler) {
TNode<Uint32T> function_id = BytecodeOperandRuntimeId(0);
RegListNodePair args = GetRegisterListAtOperandIndex(1);
TNode<Context> context = GetContext();
Node* result = CallRuntimeN(function_id, context, args);
TNode<Object> result = CAST(CallRuntimeN(function_id, context, args));
SetAccumulator(result);
Dispatch();
}

2
test/unittests/interpreter/interpreter-assembler-unittest.cc
View File

@ -46,7 +46,7 @@ InterpreterAssemblerTest::InterpreterAssemblerForTest::
GetAccumulator();
}
if (Bytecodes::WritesAccumulator(bytecode())) {
SetAccumulator(nullptr);
SetAccumulator(NullConstant());
}
}