[turbofan] Skip byteLength optimization if we cannot install dependencies

Bug: v8:11111, chromium:1376784
Change-Id: I1e1e7ab3cc2eebc87410ad1e9f8785cff67a08a3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4008263
Auto-Submit: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84101}
This commit is contained in:
Nico Hartmann 2022-11-07 17:07:49 +01:00 committed by V8 LUCI CQ
parent 3333e29f38
commit 03c96b8680
2 changed files with 35 additions and 1 deletions

View File

@ -7867,7 +7867,9 @@ Reduction JSCallReducer::ReduceArrayBufferViewAccessor(
return IsRabGsabTypedArrayElementsKind(map.elements_kind());
}));
CHECK(inference.RelyOnMapsViaStability(dependencies()));
if (!inference.RelyOnMapsViaStability(dependencies())) {
return inference.NoChange();
}
const bool depended_on_detaching_protector =
dependencies()->DependOnArrayBufferDetachingProtector();

View File

@ -0,0 +1,32 @@
// Copyright 2022 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --turbofan
function test() {
let depth = 100;
const arr = [];
const factory = class MyArray extends Uint8Array {
constructor() {
async function foo() { new factory(); }
if(depth-- > 0) {
const x = foo();
super(arr);
this.__proto__ = x;
const unused1 = super.byteLength;
} else {
super(arr);
}
}
};
const unused2 = new factory();
arr.__proto__ = factory;
return arr;
}
test();
%PrepareFunctionForOptimization(test);
test();
%OptimizeFunctionOnNextCall(test);
test();