From 040316463dad4d5b7f7f2b623d10353eabb2590e Mon Sep 17 00:00:00 2001 From: Ng Zhi An Date: Thu, 3 Sep 2020 14:43:01 -0700 Subject: [PATCH] [wasm-simd][scalar-lowering] Add missing comparison ops Some comparison ops are missing from the list, so an incorrect replacement type was set on those instructions. Bug: v8:10507 Change-Id: I1ebee298261a33863fe09e62e94336a792966a47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2393099 Reviewed-by: Bill Budge Commit-Queue: Zhi An Ng Cr-Commit-Position: refs/heads/master@{#69707} --- src/compiler/simd-scalar-lowering.cc | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/compiler/simd-scalar-lowering.cc b/src/compiler/simd-scalar-lowering.cc index 6ac308746f..fdbec24d60 100644 --- a/src/compiler/simd-scalar-lowering.cc +++ b/src/compiler/simd-scalar-lowering.cc @@ -128,15 +128,15 @@ void SimdScalarLowering::LowerGraph() { V(I32x4Eq) \ V(I32x4Ne) \ V(I32x4LtS) \ - V(I32x4LeS) \ + V(I32x4LtU) \ V(I32x4GtS) \ + V(I32x4GtU) \ + V(I32x4LeS) \ + V(I32x4LeU) \ V(I32x4GeS) \ + V(I32x4GeU) \ V(I32x4UConvertI16x8Low) \ V(I32x4UConvertI16x8High) \ - V(I32x4LtU) \ - V(I32x4LeU) \ - V(I32x4GtU) \ - V(I32x4GeU) \ V(I32x4Abs) \ V(S128And) \ V(S128Or) \ @@ -209,9 +209,13 @@ void SimdScalarLowering::LowerGraph() { V(I16x8Eq) \ V(I16x8Ne) \ V(I16x8LtS) \ - V(I16x8LeS) \ V(I16x8LtU) \ + V(I16x8GtS) \ + V(I16x8GtU) \ + V(I16x8LeS) \ V(I16x8LeU) \ + V(I16x8GeS) \ + V(I16x8GeU) \ V(I16x8RoundingAverageU) \ V(I16x8Abs) \ V(I16x8BitMask) @@ -241,9 +245,13 @@ void SimdScalarLowering::LowerGraph() { V(I8x16Eq) \ V(I8x16Ne) \ V(I8x16LtS) \ - V(I8x16LeS) \ V(I8x16LtU) \ + V(I8x16GtS) \ + V(I8x16GtU) \ + V(I8x16LeS) \ V(I8x16LeU) \ + V(I8x16GeS) \ + V(I8x16GeU) \ V(S8x16Swizzle) \ V(S8x16Shuffle) \ V(I8x16RoundingAverageU) \