AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "S390: fix byte count when pushing/popping doubles"

Browse Source 
This reverts commit 9caf26b94c.

Reason for revert: Needed to be changed to kNumCallerSavedDoubles

Original change's description:
> S390: fix byte count when pushing/popping doubles
>
> `NumRegs` runs a `population count` and must be used with
> a `RegList` and not with a regular integer value.
>
> kCallerSavedDoubles is a regular integer and should be used as is.
>
> Change-Id: Id9535134ad4ea02bebed9b506012084d93acc2c2
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2965159
> Reviewed-by: Junliang Yan <junyan@redhat.com>
> Commit-Queue: Milad Fa <mfarazma@redhat.com>
> Cr-Commit-Position: refs/heads/master@{#75213}

Change-Id: Ifae6ee99b698f5a1f68a7c42cda1743fd1cbf0d7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2969623
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Junliang Yan <junyan@redhat.com>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/master@{#75223}
This commit is contained in:
Milad Fa 2021-06-17 15:28:11 +00:00 committed by V8 LUCI CQ
parent 4168661924
commit 049760ec3b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/codegen/s390/macro-assembler-s390.cc
View File

@ -283,7 +283,7 @@ int TurboAssembler::RequiredStackSizeForCallerSaved(SaveFPRegsMode fp_mode,
bytes += NumRegs(list) * kSystemPointerSize;
if (fp_mode == SaveFPRegsMode::kSave) {
bytes += kCallerSavedDoubles * kDoubleSize;
bytes += NumRegs(kCallerSavedDoubles) * kDoubleSize;
}
return bytes;
@ -309,7 +309,7 @@ int TurboAssembler::PushCallerSaved(SaveFPRegsMode fp_mode, Register exclusion1,
if (fp_mode == SaveFPRegsMode::kSave) {
MultiPushDoubles(kCallerSavedDoubles);
bytes += kCallerSavedDoubles * kDoubleSize;
bytes += NumRegs(kCallerSavedDoubles) * kDoubleSize;
}
return bytes;
@ -320,7 +320,7 @@ int TurboAssembler::PopCallerSaved(SaveFPRegsMode fp_mode, Register exclusion1,
int bytes = 0;
if (fp_mode == SaveFPRegsMode::kSave) {
MultiPopDoubles(kCallerSavedDoubles);
bytes += kCallerSavedDoubles * kDoubleSize;
bytes += NumRegs(kCallerSavedDoubles) * kDoubleSize;
}
RegList exclusions = 0;